00:10:50 Unstable branch on crawl.kelbi.org updated to: 0.29-a0-483-g69413ace17 (34) 01:02:07 03PleasingFungus02 07[stellar-work] * 0.29-a0-484-gf57aedb6d1: New species: Star 10(11 days ago, 18 files, 154+ 15-) 13https://github.com/crawl/crawl/commit/f57aedb6d1f1 01:02:07 03PleasingFungus02 07[stellar-work] * 0.29-a0-485-gfd85ccf173: Merge deep, mountain and hill dwarves 10(10 days ago, 21 files, 57+ 78-) 13https://github.com/crawl/crawl/commit/fd85ccf17376 01:02:07 03PleasingFungus02 07[stellar-work] * 0.29-a0-486-g7d0ff3c18d: Add a description for short-lived 10(9 days ago, 2 files, 6+ 1-) 13https://github.com/crawl/crawl/commit/7d0ff3c18d69 01:02:07 03PleasingFungus02 07[stellar-work] * 0.29-a0-487-g72b560ab04: Make stars shine 10(9 days ago, 6 files, 18+ 4-) 13https://github.com/crawl/crawl/commit/72b560ab04b4 01:02:07 03PleasingFungus02 07[stellar-work] * 0.29-a0-488-g8cbc25e388: Remove damage shaving 10(39 minutes ago, 5 files, 22+ 19-) 13https://github.com/crawl/crawl/commit/8cbc25e3887a 01:02:07 03PleasingFungus02 07[stellar-work] * 0.29-a0-489-gb3762d8596: New star conduct: exploration healing 10(4 minutes ago, 6 files, 35+ 7-) 13https://github.com/crawl/crawl/commit/b3762d859690 01:34:54 Unstable branch on crawl.develz.org updated to: 0.29-a0-483-g69413ace17 (34) 01:56:25 Windows builds of master branch on crawl.develz.org updated to: 0.29-a0-483-g69413ace17 02:44:07 -!- Sting1 is now known as Sting 02:54:11 Monster database of master branch on crawl.develz.org updated to: 0.29-a0-483-g69413ace17 03:28:11 -!- bhaak_ is now known as bhaak 03:35:53 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-4699-g54b3c284c3 06:22:24 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-4699-g54b3c284c3 06:53:38 <06advil> I don’t understand what’s supposed to be happening here 06:53:56 <06advil> Just created isn’t set on arbitrary crashes 06:54:53 <06advil> And this reverts essentially how the prev code worked so it wouldn’t be a new bug? 07:36:45 <06advil> alright I found personjerry's description and it still doesn't make sense: "Huh, I found a bug. If you go down the stairs sometimes monsters hit you as soon as you arrive. But if you force quit and load from the stairs they don't get that hit in" 07:38:08 <06advil> if force quit = kill, maybe this makes sense but this is essentially save scumming, not a bug 07:39:12 <06advil> (and the revert won't fix it if I'm understanding right) 07:52:52 <06advil> yes, I have replicated this and the revert does not fix it, it seems that stair time is never applied if you crash immediately after entering the level 07:58:03 <06advil> I think it's simply because the save_game_state call happens before seen_monsters_react as well as the turn end 08:02:36 03advil02 07* 0.29-a0-484-g0e957ee05f: Revert "Revert "Make new stairs fast after crashing (advil)"" 10(4 minutes ago, 1 file, 3+ 2-) 13https://github.com/crawl/crawl/commit/0e957ee05f46 08:08:40 <06advil> there's all sorts of hilarious stuff that happens only after the save 08:09:10 <06advil> wonder if you could use force quit to keep polar vortex going 08:16:37 Unstable branch on crawl.akrasiac.org updated to: 0.29-a0-483-g69413ac (34) 08:17:12 Unstable branch on crawl.kelbi.org updated to: 0.29-a0-484-g0e957ee05f (34) 08:22:27 <06advil> hm, maybe this is even simpler, if you kill a crawl process while waiting for input it always rolls back (unless it saved during the last world_reacts), because there's no place for a hup check in that code path 08:23:00 <06advil> the stair interaction is weird because it does roll back to a point where the player didn't have control 08:23:34 <06advil> in principle what maybe should happen is that a save after that world_reacts should be guaranteed, but that's not very practical to implement 08:31:55 <06advil> side note, some day crawl_state.need_save should be renamed 08:32:57 Oh tell me to what so I can have some idea what it actually does, please? 08:33:08 <06advil> lol 08:33:15 <06advil> can_save maybe? 09:37:39 <10PleasingFungus> @advil ty for correcting me! i love a revert revert 🙂 09:37:55 <06advil> haha yw 09:38:04 <06advil> still can't figure out how to get it to save at the right time 09:38:27 <06advil> I got it to save the time but somehow monster action is still getting rolled back 🙃 09:38:49 <06advil> makes me doubt all I know about how the game loop is sequenced 10:19:46 New branch created: pull/2555 (1 commit) 13https://github.com/crawl/crawl/pull/2555 10:19:46 03sdynet02 07https://github.com/crawl/crawl/pull/2555 * 0.29-a0-485-g58726f930c: Tiny improvement of Oct's ring 10(2 minutes ago, 1 file, 4+ 5-) 13https://github.com/crawl/crawl/commit/58726f930c1e 12:35:28 03PleasingFungus02 07[stellar-work] * 0.29-a0-490-ge636572ef5: Halve explore healing 10(25 seconds ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/e636572ef5ee 12:49:38 <06advil> huh 12:49:46 <06advil> so, save_game(false) does not save the level 12:49:57 <06advil> I feel like that's something I should have known before now 12:54:26 <10PleasingFungus> huh 12:54:37 <10PleasingFungus> what does it do? 13:20:22 <06advil> pretty much every chunk except the current level, but the player is the important one 13:22:06 03advil02 07* 0.29-a0-485-g12ac202842: fix: save after world_reacts on level entry 10(21 minutes ago, 4 files, 12+ 3-) 13https://github.com/crawl/crawl/commit/12ac202842a1 13:24:04 <06advil> !source _save_game_base 13:24:05 <04Cerebot> Can't find _save_game_base. 13:24:21 <06advil> !source files.cc:2454 13:24:22 <04Cerebot> https://github.com/crawl/crawl/blob/master/crawl-ref/source/files.cc#L2454 13:24:27 <06advil> it calls that thing 13:25:07 <06advil> it's very obvious once you look at that vs _save_game_exit, but I just didn't know this at all 13:26:02 <06advil> you can also ensure a level save without a player save by causing a level excursion in map mode 13:47:24 Unstable branch on crawl.kelbi.org updated to: 0.29-a0-485-g12ac202842 (34) 14:22:09 <10PleasingFungus> neat 14:24:41 <06advil> I wonder if there's a good reason or if this was for efficiency in 1993 14:24:52 <06advil> seems risky to mess with though 14:31:25 <10PleasingFungus> very spooky for sure 14:32:23 <06advil> do you care if I close monkooky's thing about teleport? I don't think it's very practical to make use of knowing how any of that works 14:42:06 <06advil> hope that polearm bailey issue isn't actually going to be a wedge to argue about the mentioned past changes 14:42:33 <06advil> (tbc I plan to cut that off if it is) 14:46:09 <10PleasingFungus> polearm bailey issue? 14:46:46 <10PleasingFungus> i think i’m fine w closing monkooky’s tele issue - think he agreed w me that it was less of an issue than he’d initially believed 14:47:11 <10PleasingFungus> ty for looking at issues, btw! i’ve just had no energy for that for ages 14:47:18 <06advil> one I just closed 14:47:42 <10PleasingFungus> (to be clear, suspect monkooky still wants changes, but feels a bit less strongly about it) 14:47:49 <10PleasingFungus> will look 14:48:45 <10PleasingFungus> wow that polearm bailey thing is baffling 14:48:47 <06advil> I guess since TP time is measured in auts it may in general be better to do the slowest thing you can? 14:48:53 <10PleasingFungus> looks like a troll 14:48:55 <06advil> yeah, it seems oddly invented 14:49:14 <10PleasingFungus> mm, think you’re often better using healing, moving away from enemies, etc 14:49:25 <06advil> very fair 14:49:35 <10PleasingFungus> the long action is a super dangerous gamble 14:49:45 <10PleasingFungus> great if you land an instant tele to a safe spot 14:49:58 <10PleasingFungus> disastrous if tele is slow or if you land near foes 14:51:10 <06advil> oh, huh, the aut time from that last turn applies to the next world_reacts? 14:51:42 <06advil> I don't know if I would have guessed that but it doesn't surprise me codewise 14:51:48 <10PleasingFungus> i don’t understand 14:52:00 <10PleasingFungus> isn’t that how all turns work? 14:52:31 <06advil> yeah, it's just a bit odd if you spend 45aut swinging dark maul and then monsters somewhere else get 45 aut at you (or maybe I'm misunderstanding) 14:52:42 <10PleasingFungus> btw, a simpler ‘fix’ would to have durations expire after world reacts instead of before. but that might break other stuff 14:52:55 <10PleasingFungus> well, the whole thing is goofy 🙂 14:52:57 <10PleasingFungus> but yes, that's how it works 14:52:58 <06advil> yep 14:53:11 <06advil> yeah, it makes perfect sense knowing how the game loop works, just didn't intuit it 14:53:14 <10PleasingFungus> there's a simpler way to think about it: 14:53:55 <10PleasingFungus> 1. you take an action 2. durations expire 3. while you're recovering from the action, monsters get a chance to move if you think of it as a really big swing and you getting back in position afterward, (3) makes more sense... and (2) makes less, ha 14:54:26 <10PleasingFungus> (that is, if you think of the time passing during world_reacts rather than during your action) 14:55:02 <10PleasingFungus> ultimately i don't think it can ever make perfect sense if you think about it too hard. why can't really fast monsters interrupt you while you're midway through slowly casting a spell, huh? 14:55:38 <06advil> I wonder if with teleportitis you should do fast things 🤔 14:55:55 <10PleasingFungus> doing fast things is ftw 14:56:03 <10PleasingFungus> also i don't remember when teleportitis triggers 14:56:07 <06advil> I know, it joke 14:56:18 <10PleasingFungus> ha, you fool. i have rJoke++ 14:57:18 <06advil> we don't have :gloweye: here so I'm handicapped 14:59:27 <10PleasingFungus> lol 14:59:29 <10PleasingFungus> fr: 16:17:31 03kate-02 07* 0.29-a0-486-ga88943ba61: Fix Simulacrum not working on demons 10(18 minutes ago, 2 files, 5+ 4-) 13https://github.com/crawl/crawl/commit/a88943ba6193 16:20:59 <05kate> pleased to report that Cerebov the simulacrum is now real 16:21:09 <05kate> pair with death channel for maximum cerebovs 16:24:41 <05kate> i also sort of wonder if leaves_corpse should exist at all now? or at least if animate dead should care about it, seems probably fine for eg unseen horror zombies to be possible and just make animate dead only care about holiness 16:32:44 Unstable branch on crawl.kelbi.org updated to: 0.29-a0-486-ga88943ba61 (34) 16:35:05 <10PleasingFungus> kate: sounds good. orb guards not being zombiable confused someone in discord today 16:50:41 <05kate> hmm, i guess that does let you do things like make shining eye zombies that have no attacks 17:17:40 <10PleasingFungus> heh 17:34:40 <05kate> hmm, i wonder if you should also be able to zombify things that you have marked for yred bind soul 17:35:45 <05kate> currently you can't because i guess yred doesn't want to share them, but also you can already currently split monsters' souls into little pieces and death channel, simulacrum and yred bind them all at once 17:38:25 <05kate> seems feasible that all the necromancy spells shouldn't stack 100% or something, and have diminishing chances to work if you have multiple active per monster 17:46:45 <05kate> oh or i guess death channel has a special check elsewhere to not work with bind soul, thanks ATTR_DIVINE_DEATH_CHANNEL for making this extra complicated 18:13:05 03kate-02 07* 0.29-a0-487-g2245875f92: Allow all natural monsters to be zombified 10(87 minutes ago, 2 files, 2+ 2-) 13https://github.com/crawl/crawl/commit/2245875f922b 18:13:05 03kate-02 07* 0.29-a0-488-g2cb01fd4ca: Don't allow derived undead with no attacks 10(23 minutes ago, 4 files, 21+ 12-) 13https://github.com/crawl/crawl/commit/2cb01fd4ca1e 18:13:05 03kate-02 07* 0.29-a0-489-g7bd733b9cc: Fix a compiler warning (shadowed params) 10(12 minutes ago, 1 file, 4+ 4-) 13https://github.com/crawl/crawl/commit/7bd733b9cc94 18:23:42 Unstable branch on underhound.eu updated to: 0.29-a0-486-ga88943ba61 (34) 18:33:19 Unstable branch on crawl.kelbi.org updated to: 0.29-a0-489-g7bd733b9cc (34) 18:33:53 04Build failed for 08master @ 7bd733b9 06https://github.com/crawl/crawl/actions/runs/2387422456 18:36:36 whoopsie 18:47:21 <10PleasingFungus> /home/runner/work/crawl/crawl/crawl-ref/source/dat/des/branches/crypt.des:1427: unknown monster: "pearl dragon skeleton" 18:47:23 <10PleasingFungus> that's odd 18:48:26 are they MH_HOLY? 18:55:09 <09gammafunk> they are holy, yes 18:55:49 right, I bet that check applies to all derived undead then, not just Yred zombies 19:20:42 <10PleasingFungus> oop 19:21:29 They are a bit of an oxymoron, sorta 19:29:56 03PleasingFungus02 07* 0.29-a0-490-g77b3608bb8: Revert "Allow all natural monsters to be zombified" 10(35 seconds ago, 2 files, 2+ 2-) 13https://github.com/crawl/crawl/commit/77b3608bb84d 19:32:57 Unstable branch on crawl.kelbi.org updated to: 0.29-a0-490-g77b3608bb8 (34) 19:47:18 <05kate> oh oops 19:48:46 <05kate> wonder why i didn't get that error 19:49:21 <05kate> oh i guess because the des cache didn't get rebuilt 19:52:16 <10PleasingFungus> yeah i had to manually trigger it locally 19:53:32 <05kate> maybe the check can be for things that either are natural or have corpses, i guess demonic crawlers are another weird one that would break under my commit 20:33:09 <10PleasingFungus> plausible 20:33:13 <10PleasingFungus> do hell beasts have corpses..? 20:59:13 holysushi (L27 OpTm) Crash caused by signal #6: Aborted (Pan) 23:21:09 03PleasingFungus02 07[stellar-work] * 0.29-a0-491-ged6a292644: New species: Star 10(12 days ago, 18 files, 154+ 15-) 13https://github.com/crawl/crawl/commit/ed6a29264452 23:21:09 03PleasingFungus02 07[stellar-work] * 0.29-a0-492-gf9cb026bc7: Merge deep, mountain and hill dwarves 10(11 days ago, 21 files, 57+ 78-) 13https://github.com/crawl/crawl/commit/f9cb026bc710 23:21:09 03PleasingFungus02 07[stellar-work] * 0.29-a0-493-g4363e8f111: Add a description for short-lived 10(10 days ago, 2 files, 6+ 1-) 13https://github.com/crawl/crawl/commit/4363e8f1114b 23:21:09 03PleasingFungus02 07[stellar-work] * 0.29-a0-494-ge4112f70f0: Make stars shine 10(10 days ago, 6 files, 18+ 4-) 13https://github.com/crawl/crawl/commit/e4112f70f0c3 23:21:09 03PleasingFungus02 07[stellar-work] * 0.29-a0-495-g0d60148440: Remove damage shaving 10(23 hours ago, 5 files, 22+ 19-) 13https://github.com/crawl/crawl/commit/0d60148440d9 23:21:09 03PleasingFungus02 07[stellar-work] * 0.29-a0-496-g9cad6584ac: New star conduct: exploration healing 10(22 hours ago, 6 files, 35+ 7-) 13https://github.com/crawl/crawl/commit/9cad6584ac29 23:21:09 03PleasingFungus02 07[stellar-work] * 0.29-a0-497-g6998b446c6: Halve explore healing 10(11 hours ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/6998b446c679 23:21:09 03PleasingFungus02 07[stellar-work] * 0.29-a0-498-ga95355bcce: Add a dummy Star monster 10(2 hours ago, 7 files, 22+ 1-) 13https://github.com/crawl/crawl/commit/a95355bccec3 23:21:09 03PleasingFungus02 07[stellar-work] * 0.29-a0-499-g6f5bd2f96d: Adjust Star apts 10(9 minutes ago, 1 file, 3+ 3-) 13https://github.com/crawl/crawl/commit/6f5bd2f96d8e 23:21:09 03PleasingFungus02 07[stellar-work] * 0.29-a0-500-g97ca5c3d55: Fix LOS at low zot 10(11 seconds ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/97ca5c3d55ab 23:40:54 03PleasingFungus02 07[stellar-work] * 0.29-a0-501-g91e97d82c1: Soften the Zot clock 10(8 minutes ago, 2 files, 24+ 8-) 13https://github.com/crawl/crawl/commit/91e97d82c1f7 23:55:33 03PleasingFungus02 07[orcify_me_captain] * 0.29-a0-425-g049b6859d8: Ban the impossible, unstoppable DgWn^Beogh 10(52 seconds ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/049b6859d81e