00:28:40 <Yermak> P​leasingFungus, book of Earth doesn't contain Statue Form, but it still can be dropped by Roxanne.
00:29:24 <Yermak> Nice book of Earth description, btw!
00:30:37 <Discord|> <10P​leasingFungus> thanks! 🙂
00:31:06 <Discord|> <10P​leasingFungus> looks like roxanne should be dropping book of stone now instead
00:31:09 <Discord|> <10P​leasingFungus> i'll do a quick fix
00:37:36 <Cheibriados> 03PleasingFungus02 07* 0.27-a0-1564-g38290d930c: Tweak book of iron description 10(6 days ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/38290d930ca3
00:37:36 <Cheibriados> 03PleasingFungus02 07* 0.27-a0-1565-gad902ab807: Fix Roxanne books (Yermak) 10(5 minutes ago, 1 file, 3+ 2-) 13https://github.com/crawl/crawl/commit/ad902ab807c5
00:48:47 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.27-a0-1565-gad902ab807 (34)
01:34:35 <Gretell> Unstable branch on crawl.develz.org updated to: 0.27-a0-1565-gad902ab807 (34)
01:55:34 <Gretell> Windows builds of master branch on crawl.develz.org updated to: 0.27-a0-1565-gad902ab807
01:59:07 <Cheibriados> New branch created: pull/2034 (1 commit) 13https://github.com/crawl/crawl/pull/2034
01:59:07 <Cheibriados> 03sdynet02 07https://github.com/crawl/crawl/pull/2034 * 0.27-a0-1566-g3ceac718b8: Strengthening the power of the xom's chessboard 10(7 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/3ceac718b8f2
02:41:34 <Cbrotell> Unstable branch on cbro.berotato.org updated to: 0.27-a0-1565-gad902ab807 (34)
02:53:51 <Gretell> Monster database of master branch on crawl.develz.org updated to: 0.27-a0-1565-gad902ab807
03:31:52 <Kelbell> Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-4217-g7c68dc2372
09:19:34 -!- The topic of #crawl-dev is: Crawl Development | https://github.com/crawl/crawl | Logs: http://s-z.org/crawl-dev/ | People with +v have commit access | Please keep general Crawl-related chat to #crawl | Long stuff to a pastebin service, please
09:19:35 -!- The topic of #crawl is: Play Dungeon Crawl Stone Soup online now! Type ??online for instructions, ??lg / !lg for play stats | PM Sequell for long queries | http://crawl.develz.org | FooTV game replays: ??footv for instructions | #crawl-dev for dev discussion, #crawl-offtopic for offtopic
10:37:28 <Cheibriados> 03advil02 07[macros-redux] * 0.27-a0-1563-g17058b75ab: fix: various macro menu tweaks 10(3 minutes ago, 3 files, 27+ 13-) 13https://github.com/crawl/crawl/commit/17058b75ab25
11:26:42 <Discord|> <08n​icolae> in wizmode, if you regenerate the vestibule (for example, to test your subvaults), it seems to trip ASSERT(num_visits == 0 && levels_seen == 0 || num_visits > 0 && levels_seen > 0) in 'place-info.cc' at line 30 failed. a lot. if i were going to try to fix this, how would i go about doing that
12:29:16 <Discord|> <06a​dvil> probably something about how the wizmode command fixes those up; first figure out what the exact replication steps are?
12:30:02 <Discord|> <06a​dvil> fwiw I just tried it in &ctrl-r and &P and didn't get it either way
12:32:36 <Discord|> <08n​icolae> it regenerates fine, it's usually triggered by regenerating and then taking an exit from the vestibule or going into one of the hells but once or twice it seems to have been triggered by regenerating and then moving. it's possible it may have to do with going directly to hell with &~ instead of taking a normal entrance, i do that a lot. i'll try to dig into it later
12:47:07 <Kelbell> Sergey (L16 GrIE) ERROR in 'dbg-scan.cc' at line 684: Exit exit_swamp[98] didn't get generated. (Swamp:1)
12:47:40 <Kelbell> Sergey (L16 GrIE) ERROR in 'dbg-scan.cc' at line 684: Exit exit_swamp[98] didn't get generated. (Swamp:1)
12:49:05 <Kelbell> Sergey (L16 GrIE) ERROR in 'dbg-scan.cc' at line 684: Exit exit_swamp[98] didn't get generated. (Swamp:1)
12:50:19 <gammafunk> !crash
12:50:20 <Sequell> 23848. Sergey, XL16 GrIE, T:8452 (milestone): https://crawl.kelbi.org/crawl/morgue/Sergey/crash-Sergey-20210716-164851.txt
12:52:29 <advil> been seeing that one around
12:52:39 <Kelbell> Sergey (L16 GrIE) ERROR in 'dbg-scan.cc' at line 684: Exit exit_swamp[98] didn't get generated. (Swamp:1)
12:52:43 <advil> I tried to replicate it the other day with seed + version and didn't get anywhere
12:53:12 <Kelbell> Sergey (L16 GrIE) ERROR in 'dbg-scan.cc' at line 684: Exit exit_swamp[98] didn't get generated. (Swamp:1)
12:53:15 <Cheibriados> 07PleasingFungus02 * 0.27-a0-1565-gad902ab807: Fix Roxanne books (Yermak) 10(12 hours ago, 1 file, 3+ 2-) 13https://github.com/crawl/crawl/commit/ad902ab807c5
12:53:15 <gammafunk> %git
12:53:24 <advil> I don't think it's very new
12:53:48 <gammafunk> they are playing latest, at least
12:54:23 <advil> it seems to happen when reentering swamp 1 and for some reason the exit stairs are gone
12:54:23 <advil> is there any newish monster interaction with a swamp monster that could hide the stairs?
12:54:24 <gammafunk> guess it was also started in latest version
12:54:26 <advil> though there wasn't much in the log of the one I was looking at that would indicate, and I did test out a water nymph just to see and it was fine
12:55:58 <advil> !source Menu::set_title
12:55:59 <Sequell> Can't find Menu::set_title.
12:56:57 <advil> I think I just found a hilarious 13 year old memory management bug
12:57:13 <advil> !source menu.cc:968
12:57:13 <Sequell> https://github.com/crawl/crawl/blob/master/crawl-ref/source/menu.cc#L968
12:57:45 <advil> Menu initializes `title` to nullptr
12:59:29 <advil> aka I think this code is guaranteed to delete nullptr when setting a menu title
12:59:40 <gammafunk> nice
12:59:44 <advil> although this is one of those "how could this possibly have ever worked" things so perhaps I'm misunderstanding
12:59:48 <gammafunk> ...would that just be a crash?
13:00:16 <advil> I just got it to crash in this way by adding a new member variable to Menu
13:00:40 <advil> it also unconditionally deletes title when closing a menu so a menu-less title gets a double whammy
13:01:35 <advil> although in some versions of the c++ std deleting a nullptr maybe is ok?
13:04:37 <advil> "If expression evaluates to a null pointer value, no destructors are called, and the deallocation function may or may not be called (it's unspecified), but the default deallocation functions are guaranteed to do nothing when passed a null pointer. "
13:04:41 <advil> clear as mud
13:07:15 <advil> I don't see anything that should trigger a custom deallaction function, so I'm back to not understanding
13:08:23 <advil> ah, title is not nullptr, so this is something else
13:08:25 <advil> c++ is hard
13:11:08 <Cheibriados> 03PleasingFungus02 07* 0.27-a0-1566-g0d5cf0409e: Stop eleios from destroying the world 10(34 seconds ago, 1 file, 0+ 2-) 13https://github.com/crawl/crawl/commit/0d5cf0409e64
13:11:57 <advil> oh lol
13:12:19 <advil> I actually did try to get those things to trigger the swamp bug (because their desc said they were like water nymphs) and never got them to do it
13:13:49 <gammafunk> yeah, do you think some save compat with a TAG MINOR to randomly place an exit if none exists would be good?
13:14:26 <advil> although, I still don't fully understand if that commit was related to the exit bug
13:14:34 <advil> maybe if the exit never comes back?
13:15:57 <gammafunk> advil: looks like it's not doing a temporary terrain change at all, but a permanent one?
13:16:05 <gammafunk> so it's a vestige of tree deletion
13:16:18 <gammafunk> except now it's not teleporting into a tree
13:16:30 <gammafunk> so their landing site can be any habitable tile, e.g. the exit stair
13:16:34 <advil> oh yeah, that would wipe out anythin ghtere
13:16:39 <advil> *would have
13:18:34 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.27-a0-1566-g0d5cf0409e (34)
13:19:07 <gammafunk> maybe just add tag_minor with code that scans swamp:1 for any exit, if no exit exists, place one at random on a floor tile on the map?
13:20:44 <Henzell> Unstable branch on crawl.akrasiac.org updated to: 0.27-a0-1565-gad902ab (34)
13:32:01 <advil> I guess I was tisconnected while I said all that
13:32:06 <advil> *disconnected
13:32:41 <Discord|> <06a​dvil> +advil I think there might already be some code for this [13:29:19] +advil TAG_MINOR_GAUNTLET_TRAPPED [13:29:38] +advil although, looking at that it strikes me as a bad idea to unconditionally put it on the player's position, that'll wipe out other stairs :D [13:29:48] +advil guess it works for a portal as in that code [13:30:34] +advil I also have a vague memory that we had to do this in depths once
13:32:41 <Discord|> but I can't find the code if so
13:34:08 <advil> ugh, this Menu crash is so far defeating me, somehow adding a member variable is triggering something that is causing memory corruption that shows up in `title`
13:36:49 -!- Yermak_ is now known as Yermak
13:44:29 <advil> so according to lldb, when the = is executed in `void set_tag(const string& t) { tag = t; }`, there's memory corruption elsewhere in the class (tag is just a string mamber variable)
13:45:36 <advil> this seems like it must be a domino effect from something else?
13:46:21 <advil> looks completely innocuous to me
13:51:19 <advil> if I remove the & from that function signature it doesn't crash but leads to other inexplicable behavior
13:51:27 <advil> what even is going on
13:52:21 <advil> and maybe other crashes
14:30:37 <advil> ok, I reset my ccache and built from scratch and everything is fine now
14:30:55 <advil> so that is like an hour I'll never get back
14:59:00 <gammafunk> lol
14:59:36 <gammafunk> I have seen those spooky "ccache ghost bugs" from time to time
15:04:52 <Cheibriados> 03advil02 07[macros-redux] * 0.27-a0-1564-g56162a6ca2: fix: streamline new action entry 10(4 minutes ago, 3 files, 22+ 5-) 13https://github.com/crawl/crawl/commit/56162a6ca2fa
15:05:31 <advil> anecdotally I do get weird link issues more on M1
15:16:33 <advil> although come to think of it, I do a lot more multi-core compilation on on my M1 so maybe it's just that
15:16:56 <Pinkbeast> I'm pretty sure there's a race issue in the Makefile but I haven't found it
15:25:23 <advil> seems likely
15:26:40 <Pinkbeast> The usual manifestation (for me) is the tilesheets coming out mangled
15:27:09 <gammafunk> advil: had to google M1 to be sure I understood what that meant
15:27:32 <gammafunk> we have two or three dedicated mac devs now
15:36:43 <Cheibriados> 03advil02 07[macros-redux] * 0.27-a0-1565-gb99d809303: feat: command for quick macro adding/editing 10(5 minutes ago, 8 files, 25+ 7-) 13https://github.com/crawl/crawl/commit/b99d809303fd
15:43:40 <Discord|> <10P​leasingFungus> pinkbeast: i’ve definitely encountered tilesheet mangling as well; was unsure of cause
15:44:23 <advil> haven't seen that one, for me it is usually missing symbols at link time
16:11:28 <Discord|> <06a​dvil> does anyone know of issues that might follow in 2021 if we made allow_extended_colours default to true? There were historical problems with this but I can't really remember what they are and maybe they went away on their own
16:18:26 <Cheibriados> 03advil02 07* 0.27-a0-1567-g3b5a371ceb: feat: macro menu, the final form 10(19 hours ago, 9 files, 535+ 274-) 13https://github.com/crawl/crawl/commit/3b5a371ceb89
16:18:26 <Cheibriados> 03advil02 07* 0.27-a0-1568-g8c6f3a9b5b: fix: various macro menu tweaks 10(6 hours ago, 3 files, 27+ 13-) 13https://github.com/crawl/crawl/commit/8c6f3a9b5b77
16:18:26 <Cheibriados> 03advil02 07* 0.27-a0-1569-gbecab4ff2c: fix: streamline new action entry 10(77 minutes ago, 3 files, 22+ 5-) 13https://github.com/crawl/crawl/commit/becab4ff2c3c
16:18:26 <Cheibriados> 03advil02 07* 0.27-a0-1570-ge1855fdbe6: feat: command for quick macro adding/editing 10(47 minutes ago, 8 files, 25+ 7-) 13https://github.com/crawl/crawl/commit/e1855fdbe67e
16:25:50 <gammafunk> @advil Definitely support that idea if we can be sure the "default" terminals on all modern system can render e.g. darkgray foreground
16:26:21 <gammafunk> the author of that functionality hasn't been seen in a while; I think that person had a better idea about some of the potential issues involved with enabling by default
16:26:30 <gammafunk> well, the author of bold_brightens_foreground
16:28:54 <advil> oh hm
16:29:04 <advil> it seems that one issue is that footv has/had issues with 16 color ttyrecs?
16:29:21 <advil> yeah I'm looking back at old logs from 2017 that discuss this
16:32:29 <advil> "13:48:54 <johnny0> advil: the shalott footv webpage can't display colors 8-15 correctly, for example"
16:32:39 <advil> sadly this PR is still open https://github.com/shellinabox/shellinabox/pull/401
16:38:54 <gammafunk> advil: well, I know that it can properly render bold_brightens_foreground output
16:39:04 <gammafunk> ...do I know that?
16:39:12 <gammafunk> that sounds like it contradicts what you're saying
16:39:15 <gammafunk> !lm . -tv
16:39:16 <Sequell> 12312. gammafunk, XL24 PaFi, T:61697 (milestone) requested for FooTV: telnet://termcast.shalott.org or https://termcast.shalott.org.
16:39:46 <gammafunk> yeah, this is with that setting enabled, and it's renderig my console output ok
16:40:05 <gammafunk> but I don't understand the difference between that setting and enabling extended colors
16:45:33 <gammafunk> hrm
16:45:50 <gammafunk> I'm trying a save compat fix that wants to do a distance iterator from the player position
16:46:13 <gammafunk> the problem is that the player position seems to be invalid in the phase before level validation
16:46:27 <gammafunk> I would guess there's no way I can actually know what the player's position will end up being
16:47:06 <gammafunk> seems it's valid if you're already on the level when the level is loaded
16:47:11 <gammafunk> but when going up stairs, this is not the case
16:55:47 <advil> there's some code to fix up multiple branch exits, maybe try putting it there?
16:56:06 <advil> _fixup_branch_stairs() in dungeon.cc
16:59:20 <gammafunk> oh
16:59:25 <gammafunk> good call, I'll check that out
17:00:49 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.27-a0-1570-ge1855fdbe6 (34)
17:09:53 <gammafunk> I see, this doesn't really care about player position in any way either; I suppose my idea of spiral iterator from player pos is just not going to work unless I wan't to go down a bit of a rabbit hole
17:10:33 <gammafunk> my concern was potentially adding the stairs into some kind of teleport closet
17:11:04 <advil> oh this one is also in the builder anyways
17:11:26 <advil> so it's a bit useless
17:11:50 <gammafunk> maybe a quick fix using simple rectangle iterator from is relevant now, and if a slightly more elegant approach can be found later
17:12:04 <gammafunk> can update that save compat code accordingly
17:12:25 <gammafunk> my thought was to put the exit as near the player as possible, but it's not that simple
17:12:31 <advil> oh `_ensure_entry` was what I was remembering
17:13:00 <Discord|> <09h​ellmonk> Just find a down staircase and put it adjacent to that, guaranteed connectivity
17:13:49 <advil> that's more or less what _ensure_entry tries to do, it finds an upstairs and puts the branch entry to it nearby using rectangle_iterator
17:14:05 <advil> there are corner cases where that could do weird things, probably
17:14:08 <gammafunk> yeah
17:14:17 <gammafunk> the issue could be something like the stair closet vault
17:14:37 <gammafunk> but that can't place on depth 1
17:14:37 <advil> !source _ensure_entry
17:14:38 <Sequell> Can't find _ensure_entry.
17:14:45 <gammafunk> I'll take a look, thanks
17:14:46 <advil> !source tags.cc
17:14:46 <Sequell> https://github.com/crawl/crawl/blob/master/crawl-ref/source/tags.cc
17:15:15 <gammafunk> hrm
17:15:29 <gammafunk> I suppose
17:15:32 <gammafunk> I could add this save compat
17:15:35 <gammafunk> right into _ensure_entry
17:15:39 <gammafunk> it's the perfect spot
17:15:47 <gammafunk> called by _add_missing_branches
17:15:54 <gammafunk> which is itself save compat
17:15:58 <gammafunk> I think that'll work perfectly
17:17:11 <gammafunk> oh I guess
17:17:16 <gammafunk> I need _ensure_branch_exit
17:17:20 <gammafunk> a new function, don't I
17:17:34 <gammafunk> I can probably just generalize this
17:22:54 <gammafunk> this code is TAG_MAJORED but it sort of seems it shouldn't be
17:23:31 <advil> a bunch of the specifics look like the related to particular changes in dungeon architecture
17:24:10 <gammafunk> right
17:24:21 <Cheibriados> 07kilobyte02 * 0.14-a0-844-g7e7dc6c928: Recover games with missing Vaults/Zot entrances. 10(8 years ago, 1 file, 41+ 0-) 13https://github.com/crawl/crawl/commit/7e7dc6c928cd
17:24:21 <advil> %git 7e7dc6c928cd3
17:24:38 <gammafunk> I suppose it depends on whether you think a save-breaking ASSERT is better than a possibly ignored fix+error
17:24:53 <gammafunk> I guess with the assert you can just go and add the specific fix
17:25:00 <gammafunk> and have the game transfer
17:25:09 <advil> also that's probably back when they expected to change the major tag all the time
17:25:16 <gammafunk> heh, yeah there's that too
17:25:41 <gammafunk> I was just noticing when I was about to add another minor tag (which it turned out I won't need to), that we're at like 235 tags
17:25:45 <gammafunk> dangerously close...
17:25:56 <gammafunk> think we really actually must break save compat in 0.28
17:26:04 <advil> tm
17:26:10 <advil> :tm:
17:26:19 <advil> heh that works
17:26:33 <gammafunk> ranged reform and jiyva reform and save compat break, it's all 100% certain for 0.28!
17:26:46 <advil> and options!
17:27:42 <gammafunk> can't wait to try out the in-game lua editor and test changes to ready() on the fly
17:28:07 <gammafunk> self-editing qw
17:29:59 <Cheibriados> 03advil02 07* 0.27-a0-1571-g52be93032c: fix: default allow_extended_colours to true 10(2 minutes ago, 1 file, 1+ 6-) 13https://github.com/crawl/crawl/commit/52be93032c36
17:30:03 <Discord|> <06a​dvil> heh
17:30:09 <Discord|> <06a​dvil> I just decided to do it
17:30:21 <Discord|> <06a​dvil> we'll see if that wreaks havoc
17:32:37 <gammafunk> require an update to options.txt?
17:32:40 <gammafunk> ??options
17:32:40 <Sequell> rcfile[1/4]: https://github.com/crawl/crawl/blob/master/crawl-ref/docs/options_guide.txt
17:32:48 <advil> oh good point
17:33:19 <gammafunk> it'll be nice to not have those awful blue out-of-los ttyrecs, that's for sure
17:33:40 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.27-a0-1571-g52be93032c (34)
17:37:37 <Cheibriados> 03advil02 07* 0.27-a0-1572-gacd6f1ce93: docs: update allow_extended_colours in options guide (gammafunk) 10(55 seconds ago, 1 file, 3+ 2-) 13https://github.com/crawl/crawl/commit/acd6f1ce9397
17:48:11 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.27-a0-1572-gacd6f1ce93 (34)
17:50:35 <gammafunk> by the way, this doesn't actually guarantee connectivity
17:50:45 <gammafunk> because it's just a distance iterator
17:50:53 <gammafunk> still the best we can do
17:51:08 <gammafunk> I'm adapting _ensure_entry() into _ensure_exit()
17:51:30 <advil> it'll be pretty likely in almost all scenarios though
17:51:33 <gammafunk> yep
17:51:54 <gammafunk> I suppose you could also just include shallow and deep water?
17:52:06 <gammafunk> that *should* guarantee at least connectivity if flight is allowed
17:52:14 <gammafunk> but then the mummy with sac evo...
17:52:28 <gammafunk> you just can't win, can you
17:55:08 <gammafunk> going to go ahead and allow both floor and shallow water, call it day. if you managed to have a eleionoma corrupted swamp:1 save with the first downstairs surrounded by deep water, consider your game cursed
17:55:39 <gammafunk> well, even then you'd have to have this iterator put the save in some kind of teleport closet
17:55:55 <gammafunk> or be the fabled mummy with no flight and sac evo
17:56:14 <gammafunk> s/put the save/put the exit/
17:56:26 <advil> yeah, I would overwrite shallow water for sure (esp in this case)
17:56:30 <advil> deep water seems riskier
18:14:45 <Aliscans> m
18:23:36 <Lantell> Unstable branch on underhound.eu updated to: 0.27-a0-1572-gacd6f1ce93 (34)
18:28:41 <Cheibriados> Inaccessible transporter vault 13https://crawl.develz.org/mantis/view.php?id=12616 by Ge0ff
18:31:24 <gammafunk> cursed transporters vaults
18:31:34 <gammafunk> thinking it might be good to just surround those with floor tiles
18:31:59 <gammafunk> another good disconnected area to the north of that, wonder what that's about
18:33:08 <Cheibriados> 03gammafunk02 07* 0.27-a0-1573-g51fae8af72: fix: Place a Swamp exit in bugged saves (Sergey) 10(28 minutes ago, 1 file, 37+ 0-) 13https://github.com/crawl/crawl/commit/51fae8af727e
18:49:00 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.27-a0-1573-g51fae8af72 (34)
19:07:11 <advil> !lg ge0ff vs-- trog -log
19:07:12 <Sequell> 1. Ge0ff, XL27 VSWn, T:60017: https://crawl.xtahua.com/crawl/morgue/Ge0ff/morgue-Ge0ff-20210716-204219.txt
19:07:21 <advil> seems to be some seed instability issue here too
19:07:37 <advil> I don't get that depths 3, but generation is identical pre-depth
19:07:45 <advil> haven't seen a good seed bug in like a year
19:17:43 <Discord|> <09g​ammafunk> interesting
19:19:19 <Discord|> <09g​ammafunk> I am working on a local commit to just add floor around these transporter vaults unconditionally, since the broken map gen happens far too often. It'd still be nice to have a fix for the general problem. Really, you could well argue that these specific types of extreme challenge transporters are meant to be self contained and shouldn't require passage through the the transporter for level
19:19:19 <Discord|> connectivity.
19:19:43 <Discord|> <09g​ammafunk> So it's probably for the best to just add surrounding floor even if we do fix that problem
19:21:29 <Discord|> <09g​ammafunk> !lm ge0ff vswn won begin x=vlong
19:21:31 <Discord|> <04C​erebot> 1. 2021-07-15 18:20:49 Ge0ff the Cudgeller (L1 VSWn) began the quest for the Orb on turn 0. (D:1)
19:27:18 -!- allbery_b is now known as geekosaur
21:31:51 <Discord|> <10P​leasingFungus>              return (fires_ammo_type(*elaunch) == mt || !missiles())                    && (mons_weapon_damage_rating(*elaunch) < mdam_rating                        || mons_weapon_damage_rating(*elaunch) == mdam_rating                           && get_weapon_brand(*elaunch) == SPWPN_NORMAL                           && get_weapon_brand(launch) != SPWPN_NORMAL)                    &&
21:31:52 <Discord|> drop_item(slot, msg) && pickup(launch, slot, msg);
21:38:35 <Discord|> <09g​ammafunk> why it's merely a quite simple boolean result!
21:41:48 <Cheibriados> New branch created: pull/2035 (1 commit) 13https://github.com/crawl/crawl/pull/2035
21:41:48 <Cheibriados> 03mainiacjoe02 {GitHub} 07https://github.com/crawl/crawl/pull/2035 * 0.27-a0-1574-g25deaef51b: Mephitic Cloud --> Corpse Rot in Book of Vapours 10(3 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/25deaef51b51
21:44:16 <Discord|> <10P​leasingFungus> look carefully at the last line............ 😦
21:52:48 <Discord|> <09g​ammafunk> is it actually spending time dropping and item only to pick it up again? just for some weird purpose?
21:53:18 <Discord|> <09g​ammafunk> I don't know what those functions do, was focusing mostly on the crazy chain of booleans
22:27:45 <Discord|> <10P​leasingFungus> no, it's just the fact that it executes that code as part of a conditional
22:27:57 <Discord|> <10P​leasingFungus> or as part of a huge short-circuit boolean chain...
22:31:13 <Discord|> <10P​leasingFungus> hm, opinion: should wanderer starting skills have any correlation with the spells they start with?
22:35:22 <Cheibriados> 03PleasingFungus02 07* 0.27-a0-1574-g4a8006d288: Avert a riot (dinky) (OK Tukima launchers) 10(42 minutes ago, 2 files, 30+ 9-) 13https://github.com/crawl/crawl/commit/4a8006d28877
22:35:22 <Cheibriados> 03PleasingFungus02 07* 0.27-a0-1575-gd28e588067: Rename the Desolation entrance (Undo, ardl) 10(27 minutes ago, 2 files, 2+ 2-) 13https://github.com/crawl/crawl/commit/d28e58806775
22:35:22 <Cheibriados> 03PleasingFungus02 07* 0.27-a0-1576-g2387c0671f: Clarify spectral ego 10(16 minutes ago, 1 file, 3+ 2-) 13https://github.com/crawl/crawl/commit/2387c0671f5f
22:35:22 <Cheibriados> 03PleasingFungus02 07* 0.27-a0-1577-g29e9f9e103: Add storm form tile (alex1729) 10(15 minutes ago, 4 files, 2+ 2-) 13https://github.com/crawl/crawl/commit/29e9f9e103b5
22:35:22 <Cheibriados> 03PleasingFungus02 07* 0.27-a0-1578-g7cc0d9ac62: Remove wanderer debug code 10(9 minutes ago, 1 file, 0+ 2-) 13https://github.com/crawl/crawl/commit/7cc0d9ac62c3
22:36:16 <Discord|> <08n​icolae> that's just a tile for the ability icon!
22:42:07 <Discord|> <10P​leasingFungus> oh yeah i lied
22:42:10 <Discord|> <10P​leasingFungus> it's for the spell
22:42:12 <Discord|> <10P​leasingFungus> not the ability
22:42:15 <Discord|> <10P​leasingFungus> but not for the form itself
22:47:59 <Discord|> <09g​ammafunk> We discussed that a few days ago, and I think our mutual conclusion was yes, at least as far as you shouldn't have skills train for which you have no spells (and I guess similar logic applies to throwing and weapon skills)?
22:48:25 <Discord|> <10P​leasingFungus> i was wrong and the current code makes very little attempt to do that
22:48:43 <Discord|> <10P​leasingFungus> it chooses some skills that you get, and then it chooses some skills that you get appropriate items and/or spells for
22:48:47 <Discord|> <09g​ammafunk> no I mean, yes it should but it doesn't currently
22:49:06 <Discord|> <10P​leasingFungus> right, what i'm trying to say is: i was hoping it was a simple bug in existing functionality
22:49:06 <Discord|> <09g​ammafunk> unless you're talking about a different aspect from what we discussed at that time
22:49:09 <Discord|> <10P​leasingFungus> but it actually just needs a redesign
22:49:14 <Discord|> <09g​ammafunk> ah, that's fun
22:49:56 <Discord|> <09g​ammafunk> so presumably it should 1) generate stuff to give you and 2) look at the skills for that stuff, giving some of those skills (and then giving you some skills for other things like defenses not directly related to said stuff)
22:50:17 <Discord|> <09g​ammafunk> this feels like something previous devs would have debated, potentially a lot
22:51:31 <Discord|> <09g​ammafunk> like maybe kate will come in here and say "yeah elliptic and kilobtye and I decided back in 0.8 that...but we didn't agree that....and then dpeg said 'no, but...'..."
22:52:08 <Discord|> <09g​ammafunk> and then grunt went and implemented deep dwarf wanderer scion monsters and that distracted everyone
22:52:22 <Discord|> <10P​leasingFungus> fr: that
22:54:45 <Yermak> advil, is there an option to return to some of the previous macro editing variants? Two extra 'Esc' at the end is too much to finish new macro.
23:01:56 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.27-a0-1578-g7cc0d9ac62 (34)
23:13:46 <Yermak> New Nikola is deadly.
23:15:41 <Discord|> <10P​leasingFungus> He should be at least a little deadly.
23:16:02 <Discord|> <10P​leasingFungus> !killratio * nikola month
23:16:04 <Discord|> <04C​erebot> No battles for * and nikola (month).
23:16:15 <Discord|> <10P​leasingFungus> !killratio nikola * month
23:16:20 <Discord|> <04C​erebot> nikola wins 3.798% of battles against * (month).
23:16:36 <Discord|> <10P​leasingFungus> !killratio nikola * month current trunk
23:16:41 <Discord|> <04C​erebot> nikola wins 3.612% of battles against * (month current trunk).
23:52:53 <Discord|> <09g​ammafunk> !killratio nikola current !alpha
23:52:56 <Discord|> <04C​erebot> No battles for nikola and No games for current. (!alpha).
23:53:03 <Discord|> <09g​ammafunk> !killratio nikola * current !alpha
23:53:07 <Discord|> <04C​erebot> nikola wins 3.119% of battles against * (current !alpha).
23:53:14 <Discord|> <09g​ammafunk> probably got a bump
23:53:24 <Discord|> <09g​ammafunk> need the vlong of the spell change though