00:06:17 <Cheibriados> 03|amethyst02 07* 0.27-a0-1547-gd3c00ef09d: Fix quote formatting. 10(52 minutes ago, 1 file, 30+ 30-) 13https://github.com/crawl/crawl/commit/d3c00ef09de0
00:06:17 <Cheibriados> 03|amethyst02 07* 0.27-a0-1548-gf8a67e7463: Correct Abyss feature placement check. 10(44 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/f8a67e7463c0
00:18:55 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.27-a0-1548-gf8a67e7463 (34)
02:59:06 <Cbrotell> Unstable branch on cbro.berotato.org updated to: 0.27-a0-1548-gf8a67e7463 (34)
03:31:42 <Kelbell> Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-4217-g7c68dc2372
05:46:09 <Nivim> (Is Ignition slower when Xom does it than when you cast it? Are they implemented differently?)
06:26:01 <Nivim> Ah, promising batrobin dead to the expected results of the challenges I put on top. (Going to low HP in a wizlab followed by a trog wrath fireball finish it off.)
10:22:26 <Discord|> <10P​leasingFungus> nivim: i believe it’s exactly the same ignition implementation - what do you mean by slower?
10:22:37 <advil> slower as in real time?
10:22:38 <advil> jinx
10:29:13 -!- The topic of #crawl-dev is: Crawl Development | https://github.com/crawl/crawl | Logs: http://s-z.org/crawl-dev/ | People with +v have commit access | Please keep general Crawl-related chat to #crawl | Long stuff to a pastebin service, please
10:29:14 -!- The topic of #crawl is: Play Dungeon Crawl Stone Soup online now! Type ??servers for instructions, ??lg / !lg for play stats | PM Sequell for long queries | http://crawl.develz.org | FooTV game replays: ??footv for instructions | #crawl-dev for dev discussion, #crawl-offtopic for offtopic
10:34:02 -!- ProzacElf_ is now known as ProzacElf
10:34:48 <advil> does anyone know why the raw input thing for macros is needed?
10:38:02 <Discord|> <12e​bering> No idea
10:38:10 <Discord|> <12e​bering> I’m not even sure what it does?
10:39:25 <Discord|> <08n​icolae> in case the macro editor is on a paleo diet
10:44:06 <Discord|> <06a​dvil> it runs its own input loop; now that I type this out I guess it may allow you to enter edit keys from the text entry widget
13:29:51 <Henzell> Unstable branch on crawl.akrasiac.org updated to: 0.27-a0-1548-gf8a67e7 (34)
18:15:41 <Cheibriados> 03kate-02 07* 0.27-a0-1549-g492c89284f: Adjust weapon brand descriptions 10(24 hours ago, 1 file, 40+ 72-) 13https://github.com/crawl/crawl/commit/492c89284f24
18:15:41 <Cheibriados> 03kate-02 07* 0.27-a0-1550-ge1afea27ad: Update unrand descriptions and inscriptions 10(22 hours ago, 4 files, 218+ 122-) 13https://github.com/crawl/crawl/commit/e1afea27ad08
18:15:41 <Cheibriados> 03kate-02 07* 0.27-a0-1551-g622f6405ea: Rework the robe of Folly (hellmonk) 10(2 hours ago, 6 files, 21+ 8-) 13https://github.com/crawl/crawl/commit/622f6405ea13
18:22:52 <Lantell> Unstable branch on underhound.eu updated to: 0.27-a0-1548-gf8a67e7463 (34)
18:35:02 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.27-a0-1551-g622f6405ea (34)
18:38:45 <Discord|> <10P​leasingFungus> @kate should brill be marked temp useless w folly on?
18:39:28 <Discord|> <10P​leasingFungus> or, hm. does it still add another enhancer…
18:39:48 <Discord|> <10P​leasingFungus> would be good to be clear about how all this interacts
18:40:05 <Discord|> <05k​ate> it doesn't stack yeah, i guess could mark it temporarily useless
18:40:32 <Discord|> <05k​ate> or hmm, actually i guess it does add another enhancer
18:41:21 <Discord|> <05k​ate> could probably move DUR_BRILLIANCE into the archmagi check directly though
18:41:42 <Discord|> <10P​leasingFungus> maybe make it not add another enhancer (w both on) and then mark useless?
18:41:56 <Discord|> <10P​leasingFungus> might be what you just said
18:42:12 <Discord|> <05k​ate> yeah, i think that's probably clearest
18:42:47 <Discord|> <10P​leasingFungus> alternative is to make both stack and drop costs to 25%
18:43:22 <Discord|> <10P​leasingFungus> seems a lot
19:36:55 <Cheibriados> 03kate-02 07* 0.27-a0-1552-gbdbb211e1e: Don't let Folly's brilliance stack with the potion 10(20 minutes ago, 3 files, 4+ 4-) 13https://github.com/crawl/crawl/commit/bdbb211e1e64
19:36:55 <Cheibriados> 03kate-02 07* 0.27-a0-1553-g57bb12a6e0: Remove some food leftovers 10(9 minutes ago, 8 files, 4+ 20-) 13https://github.com/crawl/crawl/commit/57bb12a6e09a
19:37:31 <Discord|> <10P​leasingFungus> glad we brought you over to the dark side of silly commit messages
19:37:59 <Discord|> <05k​ate> heh, i'm all for it as long as it's still mostly clear what's actually being changed!
20:21:20 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.27-a0-1553-g57bb12a6e0 (34)
20:58:24 <Cheibriados> 03mgdelmonte02 07https://github.com/crawl/crawl/pull/1922 * 0.27-a0-1063-g21693acb1f: mgd-debug 10(9 weeks ago, 1 file, 3+ 0-) 13https://github.com/crawl/crawl/commit/21693acb1fb2
20:58:24 <Cheibriados> 03mgdelmonte02 07https://github.com/crawl/crawl/pull/1922 * 0.27-a0-1064-g616cfe6960: Revert "mgd-debug" 10(9 weeks ago, 1 file, 0+ 3-) 13https://github.com/crawl/crawl/commit/616cfe69608e
20:58:24 <Cheibriados> 03mgdelmonte02 07https://github.com/crawl/crawl/pull/1922 * 0.27-a0-1283-g9f6fb3821b: Merge remote-tracking branch 'upstream/master' 10(4 weeks ago, 0 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/9f6fb3821b60
20:58:24 <Cheibriados> 03mgdelmonte02 07https://github.com/crawl/crawl/pull/1922 * 0.27-a0-1304-g92952e5fa8: Merge remote-tracking branch 'upstream/master' 10(4 weeks ago, 0 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/92952e5fa8dd
20:58:24 <Cheibriados> 03mgdelmonte02 07https://github.com/crawl/crawl/pull/1922 * 0.27-a0-1306-g4f92f54c73: Merge branch 'master' of https://github.com/mgdelmonte/crawl 10(4 weeks ago, 0 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/4f92f54c73de
20:58:24 <Cheibriados> 03mgdelmonte02 07https://github.com/crawl/crawl/pull/1922 * 0.27-a0-1551-g9d742d07a1: Merge branch 'master' of https://github.com/mgdelmonte/crawl 10(29 hours ago, 0 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/9d742d07a18f
20:58:24 <Cheibriados> 03mgdelmonte02 07https://github.com/crawl/crawl/pull/1922 * 0.27-a0-1552-ge50014f6d3: added monster.target_desc 10(3 months ago, 3 files, 55+ 0-) 13https://github.com/crawl/crawl/commit/e50014f6d342
20:58:24 <Cheibriados> 03mgdelmonte02 07https://github.com/crawl/crawl/pull/1922 * 0.27-a0-1553-g701127ea9f: fix invisible whitespace problem 10(3 months ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/701127ea9f08
20:58:24 <Cheibriados> 03mgdelmonte02 07https://github.com/crawl/crawl/pull/1922 * 0.27-a0-1554-g2fdb9ac879: bugfix 10(9 weeks ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/2fdb9ac8794c
20:58:24 <Cheibriados> 03mgdelmonte02 07https://github.com/crawl/crawl/pull/1922 * 0.27-a0-1555-g804f754357: made separate functions 10(5 minutes ago, 8 files, 74+ 35-) 13https://github.com/crawl/crawl/commit/804f7543570f
20:58:24 <Cheibriados> 03mgdelmonte02 07https://github.com/crawl/crawl/pull/1922 * 0.27-a0-1559-gc2dc3ccdfc: fixup 10(3 minutes ago, 0 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/c2dc3ccdfcb3
21:03:30 <Cheibriados> 03mgdelmonte02 07https://github.com/crawl/crawl/pull/1922 * 0.27-a0-1556-gbfa5a1d47c: added monster.target_desc 10(3 months ago, 1 file, 0+ 1-) 13https://github.com/crawl/crawl/commit/bfa5a1d47c60
21:03:30 <Cheibriados> 03mgdelmonte02 07https://github.com/crawl/crawl/pull/1922 * 0.27-a0-1557-g91c270e0e2: fix invisible whitespace problem 10(3 months ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/91c270e0e23b
21:03:30 <Cheibriados> 03mgdelmonte02 07https://github.com/crawl/crawl/pull/1922 * 0.27-a0-1562-g736e37ef78: Merge branch 'monster-target' of https://github.com/mgdelmonte/crawl into monster-target 10(69 seconds ago, 0 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/736e37ef7822
21:03:30 <Cheibriados> 03mgdelmonte02 {GitHub} 07https://github.com/crawl/crawl/pull/1922 * 0.27-a0-1571-g4306e399fc: Merge branch 'crawl:master' into monster-target 10(25 seconds ago, 0 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/4306e399fcd0
21:23:53 <Cheibriados> 03mgdelmonte02 07https://github.com/crawl/crawl/pull/1922 * 0.27-a0-1563-g8f3c971514: checkwhite 10(79 seconds ago, 2 files, 2+ 2-) 13https://github.com/crawl/crawl/commit/8f3c97151449
21:23:53 <Cheibriados> 03mgdelmonte02 07https://github.com/crawl/crawl/pull/1922 * 0.27-a0-1573-g3acdf7a3c4: Merge branch 'monster-target' of https://github.com/mgdelmonte/crawl into monster-target 10(73 seconds ago, 0 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/3acdf7a3c417
21:32:22 <Discord|> <08n​icolae> i know i asked this before but i want to double check: for submitting vaults for multiple .des files, how should i have it arranged re pull requests/git branches/commits
21:33:35 <geekosaur> ideally don't do the above :)
21:33:43 <Discord|> <08n​icolae> gathered that, yeah
21:33:55 <geekosaur> squashing commits is a thing. or the other one you were shown with git reset
21:35:24 <geekosaur> anyway I'd guess it depends on how multiple
21:35:49 <geekosaur> I'd for example submit branch end changes as separate PRs
21:46:25 <Cheibriados> 03hellmonk02 {gammafunk} 07* 0.27-a0-1554-g214d61ee58: Abyssal woods Lair end 10(6 weeks ago, 1 file, 52+ 0-) 13https://github.com/crawl/crawl/commit/214d61ee5880
21:46:25 <Cheibriados> 03gammafunk02 07* 0.27-a0-1555-g0e7b3fb1d2: feat: tweak the abyssal woods Lair ending 10(63 minutes ago, 1 file, 46+ 36-) 13https://github.com/crawl/crawl/commit/0e7b3fb1d28d
22:03:54 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.27-a0-1555-g0e7b3fb1d2 (34)
22:55:00 <Discord|> <09g​ammafunk> @nicolae logical grouping that breaks up the function of the vaults is good. logical grouping does not need to be extremely well-defined or detailed. For example: monster and decor vaults for Spider branch in one batch, grouping by fact it's in Spider. If the number of vaults involved is fairly large, breaking those up into two PRs would be nice (decor vaults tend to be a lot easier to review).
22:55:01 <Discord|> Probably worth mentioning that things like decor vaults you would reasonably be comfortable in just merging yourself. If it's a large complicated vault or just a vault with big impact, like a branch ending, one PR per vault is nice.
22:55:37 <Discord|> <08n​icolae> that's a lot of PRs but i'll give it a shot
22:55:38 <Discord|> <09g​ammafunk> @nicolae in terms of commits, being a little more fine-grained in terms of function is nice, like one for the decor vaults, one for the monster vaults. Definitely preferable to have one commit per vault for complicated maps like branch endings
22:55:47 <Discord|> <09g​ammafunk> really? what all do you have?
22:56:02 <Discord|> <09g​ammafunk> it's definitely an art as well as a science
22:56:18 <Discord|> <08n​icolae> well, just in general, atm i think my only big-impact vaults are the extra hall of blades layouts
22:57:19 <Discord|> <09g​ammafunk> yeah, I could suggest a PR set if I knew more about the full set of vaults you're merging, but a single PR for hall of blades layouts sounds good
22:58:54 <Discord|> <09g​ammafunk> for the others, probably by branch is a starting point for PRs, but if they're all e.g. mini_monsters or all float, you could conceivably put them in one PR but try to break them up a bit into commits, or if over a couple files, use the files as a guide for when to make a new PR
22:59:35 <Discord|> <08n​icolae> makes sense
23:01:56 <Discord|> <08n​icolae> for elf, it's mostly a bunch of general vaults (decors, monsters), there's also some arrival vaults, some subvaults for the HoB entry, some HoB layouts, etc.
23:02:51 <Discord|> <09g​ammafunk> yeah, like I would probably do a HoB PR with maybe two commits, one for entries, one for layouts? If HoB layouts are really complicated, one commit for each laybout, but that's probably not necessary
23:03:47 <Discord|> <09g​ammafunk> and for the other stuff you have to go with what makes sense to you PR/commit wise, if it's kind of all over the place. I will say that decor vaults tend to be fast to review, monster vaults take much longer
23:03:55 <Discord|> <08n​icolae> noted