00:05:06 Unstable branch on crawl.kelbi.org updated to: 0.27-a0-1428-g2e30c3664c (34) 01:07:21 03PleasingFungus02 07* 0.27-a0-1429-g4113b66: Fix book of stone desc (hellmonk) 10(26 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/4113b66390ff 01:14:02 03PleasingFungus02 07* 0.27-a0-1430-g28b6d0f: Depluralize (ardl) 10(59 seconds ago, 4 files, 7+ 6-) 13https://github.com/crawl/crawl/commit/28b6d0f9156f 01:16:01 !tell Nivim I can't replicate the issue you describe with Fulminant Prism - when I kill myself with it, I get reasonable looking death messages. If you encounter it again, could you let me know? Thanks! :) 01:16:01 PleasingFungus: You have 1 message. Use !messages to read it. 01:16:01 PleasingFungus: OK, I'll let nivim know. 01:19:57 Unstable branch on crawl.kelbi.org updated to: 0.27-a0-1430-g28b6d0f915 (34) 01:28:29 04Build failed for 08master @ 28b6d0f9 06https://github.com/crawl/crawl/actions/runs/992503598 01:34:35 Unstable branch on crawl.develz.org updated to: 0.27-a0-1430-g28b6d0f915 (34) 01:55:42 Windows builds of master branch on crawl.develz.org updated to: 0.27-a0-1430-g28b6d0f915 01:57:38 <05kate> unfortunate gretell timing 01:58:47 03kate-02 07* 0.27-a0-1431-gcffa5a9: Fix book names in vaults 10(68 seconds ago, 4 files, 6+ 5-) 13https://github.com/crawl/crawl/commit/cffa5a9b1678 02:00:05 <10PleasingFungus> whoops 02:00:08 <10PleasingFungus> ty yet again 02:03:58 Unstable branch on crawl.kelbi.org updated to: 0.27-a0-1431-gcffa5a9b16 (34) 02:34:14 <09gammafunk> @nicolae if you want reviews of your work, you can always put it on a branch (either in your own fork or on a branch in the repo) and then make a PR 02:34:38 <09gammafunk> or are you wanting mantis solely for the convenience of something minimal? 02:54:17 Monster database of master branch on crawl.develz.org updated to: 0.27-a0-1431-gcffa5a9b16 02:54:17 Unstable branch on cbro.berotato.org updated to: 0.27-a0-1431-gcffa5a9b16 (34) 03:00:32 -!- Yermak_ is now known as Yermak 03:32:14 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-4217-g7c68dc2372 03:47:11 03ebering02 07* 0.27-a0-1432-g4eff083: docs: changelog typos (geekosaur) 10(46 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/4eff083807ca 03:47:11 03ebering02 07* 0.27-a0-1433-g9e18931: feat: Spell background adjustments part I (kate-, hellmonk) 10(45 minutes ago, 1 file, 0+ 6-) 13https://github.com/crawl/crawl/commit/9e18931815cf 03:47:11 03ebering02 07* 0.27-a0-1434-g6f15984: docs: remove starting books from the manual 10(2 minutes ago, 1 file, 19+ 23-) 13https://github.com/crawl/crawl/commit/6f1598492411 03:47:53 <12ebering> &versions 03:48:01 <04Cerebot> CAO: 0.27-a0-1420-g4d0b0a1, CBR2: 0.27-a0-1431-gcffa5a9b16, CDO: 0.27-a0-1384-g1422d76b99, CKO: 0.27-a0-1431-gcffa5a9b16, CPO: 0.27-a0-1431-gcffa5a9, CUE: 0.27-a0-1423-ge5d6b6ab6a, CWZ: 0.27-a0-1273-gec92ba881d, CXC: 0.27-a0-1416-g941b2bd30b, LLD: 0.27-a0-1422-ga6f8dd0138 03:48:26 <12ebering> ??rebuild 03:48:27 <04Cerebot> rebuild[1/2]: http://crawl.akrasiac.org/rebuild/ http://underhound.eu:81/rebuild/ https://cbro.berotato.org/rebuild/ http://crawl.xtahua.com/rebuild/ https://crawl.kelbi.org/rebuild/ Bug gammafunk, advil, |amethyst, or Nap.Kin for CDO. Use your powers wisely. 05:11:06 <12ebering> &versions 05:11:15 <04Cerebot> CAO: 0.27-a0-1420-g4d0b0a1, CBR2: 0.27-a0-1431-gcffa5a9b16, CDO: 0.27-a0-1384-g1422d76b99, CKO: 0.27-a0-1431-gcffa5a9b16, CPO: 0.27-a0-1434-g6f15984, CUE: 0.27-a0-1423-ge5d6b6ab6a, CWZ: 0.27-a0-1273-gec92ba881d, CXC: 0.27-a0-1416-g941b2bd30b, LLD: 0.27-a0-1422-ga6f8dd0138 06:04:35 Unstable branch on crawl.kelbi.org updated to: 0.27-a0-1434-g6f15984924 (34) 07:20:17 dinky3 (L19 SpDe) ERROR in 'mon-util.cc' at line 4720: bogus mc (no monster data): invalid monster_type 1000 (1000) (Elf:3) 09:50:14 !crashlog 09:50:15 23825. dinky3, XL19 SpDe, T:41237 (milestone): https://cbro.berotato.org/morgue/dinky3/crash-dinky3-20210702-112017.txt 10:30:23 <10PleasingFungus> classic dinky 11:47:58 blackman (L2 GnWr) Crash caused by signal #6: Aborted (D:1) 13:02:15 <08nicolae> i mostly stuck with mantis because it's easier but it probably wouldn't hurt to, like, actually start getting familiar with git in a more-hands on way, both from the standpoint of a crawl dev and the standpoint of someone who does coding occasionally for Work 13:03:05 <09gammafunk> yeah, it's very helpful too in that you'll actually have to put your vaults in the correct place and double-check their tagging, double-check their loading etc 13:03:22 <09gammafunk> At least I find it good to work directly from the des files in terms of testing changes 13:03:32 <09gammafunk> nothing wrong with working with a snippet file initially though 13:05:02 <09gammafunk> You can also use the online interface to make commits or the desktop app, if you prefer. Can put your work in a branch either in official repo or on your fork 13:05:14 <09gammafunk> The only thing you have to be aware of is making sure your commits are sanity checked before pushing to master, since you can break the build, cause crashes etc 13:05:16 <08nicolae> well i do actually test that stuff before i submit them, even on mantis 13:05:33 <09gammafunk> right, obviously, but it is slightly different as to what you're testing 13:05:55 <09gammafunk> if you finally put the vault in its final resting place, as it were, it's where it's actually going to reside in the shipped files 13:06:10 <08nicolae> i'll probably start with forks for now, i want to get the hang of doing stuff before i start YOLOing stuff into the master branch 13:06:37 <09gammafunk> sure, not a bad idea; and if you do work off of a branch or fork, you can make PRs out of them for review, if you want another pair of eyes to look first 13:06:55 <09gammafunk> and then they're easy to merge with a button if all looks well 13:07:38 <09gammafunk> or even if you do fix things, since you just force push to your branch (or leave in an additional commit, if that makes more sense) 13:08:01 <09gammafunk> at that point you or the reviewer can just click a merge button from the website 13:09:13 <08nicolae> i think i'll spend a day or two more scooping up quote submissions, and then i'll get to work making a branch/pull request 13:11:16 Unstable branch on crawl.akrasiac.org updated to: 0.27-a0-1434-g6f15984 (34) 13:24:14 <06advil> I still do bigger projects on a fork often 13:24:35 <06advil> I think if we were more conventional most stuff would be done on a fork actually 13:38:35 <10PleasingFungus> hm 13:39:10 <10PleasingFungus> thanks extremely unconventional for other git projects i’ve worked on 13:39:18 <10PleasingFungus> maybe more common in oss? 13:47:17 <08nicolae> Git Noob Question: if i'm going to make a branch for, say, just one file in the descript directory, should i make the branch there, or should i make it in the root (or whatever it's called) of my local git copy (~/crawl), or am i thinking about this all wrong 13:53:07 -!- ProzacElf_ is now known as ProzacElf 13:53:13 <08nicolae> oh, there's some stuff in the quickstart.txt git doc, i should probably read a thing 13:56:41 <10PleasingFungus> branches aren’t in a location 13:57:07 <10PleasingFungus> a branch is just an alias for a commit 13:57:28 <08nicolae> 🤔 13:57:53 <10PleasingFungus> instead of saying you’re on commit 1234DEADBEEF, you can say you’re on branch master or branch nicolae-quotes 13:57:56 <08nicolae> yeah, i think i was working with a too-simple head model of what git does 13:58:08 <10PleasingFungus> and that branch’s latest commit is 1234deadbeef 14:37:27 -!- ProzacElf_ is now known as ProzacElf 14:47:41 <08nicolae> how does the line spacing work for quotes, it seems to left-justify the first line, but any following line that doesn't begin with white space gets attached to the first line 14:54:42 <08nicolae> hrm, i think it's related to whether it's displayed on the same page as the description (items, spells) or on a separate quote page (monsters) 14:54:45 <08nicolae> ¯_(ツ)_/¯ 14:56:01 <10PleasingFungus> mysterious 14:56:31 <05kate> ooh nice, i wasn't going to go that aggressive for 0.27 but i like just going for it 15:01:09 <08nicolae> do i need to poke one of you to tell you my github username, i tried a dry run of pushing my quotes branch $ git push --dry-run -v origin nicolae-quotes-0721 Pushing to https://github.com/crawl/crawl.git Username for 'https://github.com': Password for 'https://nicolae-carpathia@github.com': remote: Permission to crawl/crawl.git denied to nicolae-carpathia. fatal: unable to access 15:01:10 'https://github.com/crawl/crawl.git/': The requested URL returned error: 403 15:02:33 <10PleasingFungus> yes 15:02:46 <08nicolae> i figured 15:03:03 <10PleasingFungus> i’m afk rn sry (on phone) 15:03:09 <08nicolae> no hurry 15:27:29 <05kate> @nicolae i should be able to invite you if you let me know your github name 15:40:20 <05kate> also re: the starting spell changes, i sort of liked the suggestion of animate armour replacing LRD in the EE book, although maybe that's spreading things a bit too thin in terms of multiple schools and directions to go in (and not exactly a great spell in a robe) 15:40:59 <10PleasingFungus> imo animate armour is not well suited to be a start spell 15:41:21 <10PleasingFungus> it really wants you to be able to cast a L4 dual school spell in at least medium armour 15:41:30 <10PleasingFungus> that’s not something you can do for a long time 15:42:06 <05kate> probably not yeah, more of a neat thing to find later when you can cast it mostly off one of the two skills and pick up a little bit of the other 15:42:31 <10PleasingFungus> fine with adding something else to the start 15:43:01 <10PleasingFungus> could add ledas now that it’s not in AM :p 15:43:07 <10PleasingFungus> don’t feel strongly either way 15:46:21 <05kate> i'm definitely curious to try the new starts out alongside the book changes, anyway. and then hopefully inspiration will strike for an exciting new low-level fire spell or a gell's rework or something for FE/Wr 15:47:59 -!- ProzacElf_ is now known as ProzacElf 15:49:10 <09hellmonk> Gells fiery gravitas 15:49:20 <09hellmonk> 2 birds 1 stone 16:34:17 <08wormsofcan> conjure ball fire 16:38:14 <08nicolae> nicolae-carpathia 17:37:33 <05kate> ok, that should be sent 17:40:26 <08nicolae> danke, i'm about to go do an errand but i'll give it another shot this evening or so 18:23:34 Unstable branch on underhound.eu updated to: 0.27-a0-1434-g6f15984924 (34) 19:11:23 New branch created: nicolae-quotes-0721 (1 commit) 13https://github.com/crawl/crawl/tree/nicolae-quotes-0721 19:11:23 03Nicolae Carpathia02 07[nicolae-quotes-0721] * 0.27-a0-1435-g35a2585: Adding new quotes to the Crawl quotes list 10(4 hours ago, 1 file, 312+ 17-) 13https://github.com/crawl/crawl/commit/35a25859757c 19:13:00 <08nicolae> okay, so that part worked, but i don't see it on the pull requests list 19:13:07 <08nicolae> https://github.com/crawl/crawl/pulls 19:13:23 <11nikheizen> Because you made a branch, not a PR? 19:13:28 <08nicolae> oh god dammit 19:13:45 <11nikheizen> You should be able to just make a PR of the branch on the github website. 19:14:28 <11nikheizen> If it sees you have a branch on your own fork it automatically suggests making a pull for that branch and I assume it might do similarly if you have a branch on the same repo. 19:15:06 <08nicolae> okay, there we go. i requested a pull. it says it's failing code linting. ach du lieber 19:16:27 <08nicolae> anyway. there we go. let me know if i botched things somehow 19:16:42 <11nikheizen> I wonder how many commits in mainline crawl just say "Checkwhite" or "Unbrace" 19:17:08 New branch created: pull/2011 (1 commit) 13https://github.com/crawl/crawl/pull/2011 19:17:08 Branch pull/2011 updated to be equal with nicolae-quotes-0721: 13https://github.com/crawl/crawl/pull/2011 19:28:55 04Build failed for 08nicolae-quotes-0721 @ 35a25859 06https://github.com/crawl/crawl/actions/runs/995100005 19:37:06 <08nicolae> nooo 19:37:20 <11nikheizen> ??travis 19:37:21 <04Cerebot> travis[1/2]: travis runs automatic builds of Crawl and its branches, ensuring that they compile properly, and running Crawl's tests on the subsequent builds to look for errors or crashes. See: https://travis-ci.org/crawl/crawl/ and {travis error}. 19:37:26 <11nikheizen> ??travis[2 19:37:27 <04Cerebot> travis[2/2]: Travis can't be bargained with. Travis can't be reasoned with. Travis doesn't feel pity, or remorse, or fear. And Travis absolutely will not stop, ever, until your project is dead. 19:37:34 <08nicolae> apparently 19:37:57 <11nikheizen> Do you know about util/checkwhite? 19:38:45 <11nikheizen> in crawl/crawl-ref/source/util there is a script called checkwhite which fixes this issue for your 19:48:18 <08nicolae> ah, i had not 19:58:34 03Nicolae Carpathia02 07[nicolae-quotes-0721] * 0.27-a0-1436-g7d03785: My very first checkwhite commit! 10(37 seconds ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/7d037859a2fd 19:58:48 Branch pull/2011 updated to be equal with nicolae-quotes-0721: 13https://github.com/crawl/crawl/pull/2011 20:03:20 <11nikheizen> And for C++ stuff there is a similar script called "unbrace" in the same directory. 20:03:35 <11nikheizen> Which gets rid of superfluous braces. 20:10:01 <08nicolae> nice, it looks like the checkwhite test already succeeded 😎 20:41:40 -!- allbery_b is now known as geekosaur 20:54:28 <11nikheizen> Also, since this is all in a branch/pr, if you want you can undo your checkwhite commit and then add the changed file(s), commit with --amend, and force push. 20:54:46 <08nicolae> eh, i'll do that next time 22:23:41 <10PleasingFungus> it's perfectly reasonable to add on checkwhite, etc as separate commits while you're working on a branch 22:23:49 <10PleasingFungus> that keeps it clear what you're doing 22:24:17 <10PleasingFungus> but when you merge into master, you want to merge everything into more sensible commits. I'm happy to help with this when the time comes 22:24:32 <10PleasingFungus> that way, the commit history on master is easier to read and reasonable about 22:43:53 <08nicolae> gotcha, thanks