01:06:16 <Cheibriados> 03PleasingFungus02 07* 0.27-a0-1346-g60794d8: Title artefact properties 10(3 minutes ago, 1 file, 50+ 31-) 13https://github.com/crawl/crawl/commit/60794d8430db
01:06:16 <Cheibriados> 03PleasingFungus02 07* 0.27-a0-1347-gd8886f0: Title armour properties 10(2 minutes ago, 1 file, 28+ 26-) 13https://github.com/crawl/crawl/commit/d8886f0a8900
01:19:53 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.27-a0-1347-gd8886f0a89 (34)
01:27:40 -!- mhcerri0 is now known as mhcerri
01:34:29 <Gretell> Unstable branch on crawl.develz.org updated to: 0.27-a0-1347-gd8886f0a89 (34)
01:54:42 <Gretell> Windows builds of master branch on crawl.develz.org updated to: 0.27-a0-1347-gd8886f0a89
02:18:46 <Cbrotell> Unstable branch on cbro.berotato.org updated to: 0.27-a0-1347-gd8886f0a89 (34)
02:39:18 <svendre> so it seems I'll need those commands from gammafunk, !next-cheat... it doesn't sound like it skips the current selection though. Does it wipe out all history? What if I want !next to continue skipping combos I've won?
02:53:18 <Gretell> Monster database of master branch on crawl.develz.org updated to: 0.27-a0-1347-gd8886f0a89
02:57:26 <gammafunk> svendre: !next already does skip combos that have been won. !next-cheat should delete the current cached result, and presumably could re-pick the same combo, although that should be very unlikely unless you have !next-pref stuff set that limits combo choices.
02:57:50 <gammafunk> in any case, if it does repick the same unwon combo, I'd just !next-cheat again
02:58:21 <svendre> gammafunk: yeah so FYI, I got HOAs, and won HOBr, but it didn't satisfy the condition
03:00:19 <gammafunk> I can take a look at it later, when I looked at the subcommands it seemed it should recognize
03:01:00 <svendre> if it's going to keep on picking As as a combo, but it isn't valid, or doesn't work - perhaps that needs fixed for all usage going forward. It sounds like I might actually want to set the !next-pref stuff to avoid the As since I only play trunk, as a way to get around that issue.
03:31:58 <Kelbell> Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-4217-g7c68dc2372
03:33:12 <Kelbell> Fork (bcadrencrawl) on crawl.kelbi.org updated to: 0.03-576-g0050c0acbb
05:39:40 <Cbrotell> puppykicker (L25 TrMo) ASSERT(!invalid_monster(&mons)) in 'mon-death.cc' at line 1470 failed. (Zot:2)
07:13:07 <Nivim> (What do Djinni use potions of magic for? They stay on autopickup after ID.)
07:14:43 <Discord|> <12e​bering> Re feature freeze and release timing: I would like to give players a bit more lead time on the t start than we did for .26, and announce a concrete date ~3-4 weeks before start since the community is diffuse and word travels somewhat slowly
07:14:48 <Discord|> <12e​bering> I’d also like to have time to tweak some t scripts, which I think I’ll have over the next month.
07:15:56 <Discord|> <12e​bering> So I propose we set Jul 30 as t start, and work back from there for freeze etc.
07:16:48 <Discord|> <12e​bering> As a bonus, that gives time to tweak the balance of reading-rainbow and wrap up other projects and prs without feeling ultra rushed
07:17:25 <Discord|> <12e​bering> So say freeze Jul 16 or 23 and release inbetween the two.
07:18:03 <Discord|> <12e​bering> They don’t, this is a bug
07:18:49 <Discord|> <12e​bering> Or even freeze a bit earlier and work a bit on our buglog (Jul 8). I know I tend to favor slightly longer release calendars than some other people though
07:19:13 <Discord|> <12e​bering> (In order to write a “bugs we’d like to fix” post and guide community patch writers.)
07:36:33 <Cheibriados> New branch created: pull/2000 (1 commit) 13https://github.com/crawl/crawl/pull/2000
07:36:33 <Cheibriados> 03root02 07https://github.com/crawl/crawl/pull/2000 * 0.27-a0-1348-g8bacef8: Corrects the description of Tin of Tremorstones 10(11 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/8bacef833846
07:47:31 <Cheibriados> New branch created: pull/2001 (1 commit) 13https://github.com/crawl/crawl/pull/2001
07:47:31 <Cheibriados> 03root02 07https://github.com/crawl/crawl/pull/2001 * 0.27-a0-1348-g1451a5c: Removed dead code ranged_attack::calc_to_hit 10(10 minutes ago, 2 files, 0+ 11-) 13https://github.com/crawl/crawl/commit/1451a5c38d97
09:24:00 <advil> I will be not at all around Jul 31-Aug 9, as in, possibly not even on internet in that range
09:24:01 <advil> so it's not my preferred time
09:24:08 <advil> but I don't need to be here
09:29:10 <advil> can't really be very available during that proposed feature freeze window either
09:48:33 <Discord|> <08w​ormsofcan> found some nice ash bugs
09:48:59 <Discord|> <08w​ormsofcan> if you try to shatter the macabre necklace while there's a ring in the slot, the game will tell you to uncurse the ring regardless of whether it's actually cursed
09:49:07 <Discord|> <08w​ormsofcan> and if you abandon ash it will just crash the game
09:54:14 <Discord|> <12e​bering> Dang, I guess depending on folks availability we could go a bit later (seems preferable to rushing)
09:54:28 <Discord|> <12e​bering> Amazing
09:55:47 <Discord|> <06a​dvil> for me the later in the summer the worse it gets, so it's probably not worth pushing even later for my sake
10:45:47 <Nivim> Why would Starburst give (twice) the prompt "That beam is likely to hit you. Continue anyway?"? Does it take into account the last target when it shouldn't?
10:51:01 <Discord|> <12e​bering> It fires a tracer for each beam path separately. The way the tracer code is set up it’s not technically feasible to save that state from check to check (though maybe it could be refactored using the targeter implemented for the quiver to only use one call to stop_attack_prompts)
10:51:22 <Discord|> <12e​bering> You must be standing very close to a lot of green crystal to trip that though
11:34:24 <Cheibriados> 03PleasingFungus02 07* 0.27-a0-1348-g58f33c6: Maybe fix dform steam res (advil, 2tousent) 10(29 seconds ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/58f33c6695b0
11:49:10 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.27-a0-1348-g58f33c6695 (34)
11:52:20 <Discord|> <09g​ammafunk> I'm ok with a bit of a delay on freeze/t
11:54:01 <Discord|> <09g​ammafunk> and to see if advil is truly gone in that early august timeframe, I shall ping him on discord/irc every day with outlandish sounding bugs related to areas he's worked on
11:54:08 <Discord|> <09g​ammafunk> then we'll know for sure
11:55:47 <Discord|> <10P​leasingFungus> i'm probably also going to be out in that timeframe (👶), but i'm not really very helpful wrt tourneys regardless, so it doesn't matter
11:55:50 <Discord|> <10P​leasingFungus> ebering's plan sgtm
12:10:15 <Discord|> <09g​ammafunk> I kind of wanted to go ahead and rewrite the scripts in python 3
12:10:29 <Discord|> <09g​ammafunk> but maybe that's not the best thing to try to do before t even with more time
12:41:17 <Discord|> <10P​leasingFungus> i mean, follow your heart
13:07:07 <Henzell> Unstable branch on crawl.akrasiac.org updated to: 0.27-a0-1348-g58f33c6 (34)
13:17:32 <Discord|> <12e​bering> @PleasingFungus finally(!) left my comments on your PR
13:17:54 <Discord|> <12e​bering> mostly bikeshedding, and if you want to delegate some description writing or vault reviewing I'm happy to help there
13:18:09 <Discord|> <12e​bering> imo press that merge button soon!
13:22:10 <Discord|> <10P​leasingFungus> thanks! might do it today
13:22:12 <Discord|> <10P​leasingFungus> we’ll see
13:22:33 <Discord|> <12e​bering> let me know if there are things I can do to help, I have a lil while
13:22:44 <Discord|> <12e​bering> otherwise I'll work on a final secret project for 0.27
13:28:07 <Discord|> <10P​leasingFungus> ooh
13:28:14 <Discord|> <10P​leasingFungus> i like secrets
13:28:19 <Discord|> <10P​leasingFungus> i think i should be able to handle it from here
13:28:26 <Discord|> <10P​leasingFungus> i'm glad the spreadsheet was helpful!
13:28:32 <Discord|> <10P​leasingFungus> (looking through your comments now)
13:29:26 <Discord|> <10P​leasingFungus> zohar just makes me think of "(don't mess with the) zohan". maybe that's my tragic cultural illiteracy, tho
13:29:30 <Discord|> <10P​leasingFungus> (i did google it to find the actual reference)
13:30:10 <Discord|> <10P​leasingFungus> other renames look good, agree with your idea for other books
13:36:46 <Discord|> <03w​heals> zohar feels a bit odd since we removed other item name level references to real world religions, but if there is a book by that name it should totally have summon guardian golem :P
13:39:34 <Discord|> <10P​leasingFungus> lol
13:42:55 <Discord|> <12e​bering> that trend is why I was less sure
13:47:19 <Discord|> <10P​leasingFungus> necronomicon is quite silly enough
13:47:29 <Discord|> <10P​leasingFungus> or… out of place, i guess
13:47:40 <Discord|> <10P​leasingFungus> grand grimoire is a deeper cut
14:59:43 <Cheibriados> 03PleasingFungus02 07* 0.27-a0-1349-g4272520: Make Damnation bolts only mulch on hit 10(25 seconds ago, 2 files, 3+ 2-) 13https://github.com/crawl/crawl/commit/427252043479
15:01:06 <Cheibriados> 03PleasingFungus02 07[tomb_of_the_unknown_books] * 0.27-a0-1350-gf014654: Remove known book tracking 10(12 days ago, 4 files, 30+ 13-) 13https://github.com/crawl/crawl/commit/f01465428456
15:01:06 <Cheibriados> 03PleasingFungus02 07[tomb_of_the_unknown_books] * 0.27-a0-1351-g47152c5: Remove book ID 10(12 days ago, 5 files, 25+ 81-) 13https://github.com/crawl/crawl/commit/47152c58aa12
15:01:16 <Cheibriados> Branch pull/1986 updated to be equal with tomb_of_the_unknown_books: 13https://github.com/crawl/crawl/pull/1986
15:01:36 <Cheibriados> 03PleasingFungus02 07* 0.27-a0-1350-gf014654: Remove known book tracking 10(12 days ago, 4 files, 30+ 13-) 13https://github.com/crawl/crawl/commit/f01465428456
15:01:36 <Cheibriados> 03PleasingFungus02 07* 0.27-a0-1351-g47152c5: Remove book ID 10(12 days ago, 5 files, 25+ 81-) 13https://github.com/crawl/crawl/commit/47152c58aa12
15:05:40 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.27-a0-1349-g4272520434 (34)
15:19:56 <Discord|> <08n​icolae> when's the freeze, again, i want to make sure i get my vaults in by then
15:20:53 <Discord|> <12e​bering> Jul 16 or 23 (no one weighed in more specifically than that but Jul 30 seems like a good t target)
15:21:00 <Discord|> <08n​icolae> oh, that's some time, nice
15:26:29 <Discord|> <12e​bering> ok I'll edit the plan and make it Official™
15:32:20 <Cheibriados> 03kate-02 07* 0.27-a0-1352-gbb9dc7d: Remove some obsolete Djinn code 10(36 minutes ago, 3 files, 1+ 27-) 13https://github.com/crawl/crawl/commit/bb9dc7d752a7
15:32:20 <Cheibriados> 03kate-02 07* 0.27-a0-1353-g14994ec: Adjust Slime floor zig scaling 10(5 minutes ago, 1 file, 2+ 1-) 13https://github.com/crawl/crawl/commit/14994ecaaf4b
15:33:17 <Discord|> <10P​leasingFungus> dang, that is old
15:35:36 <Discord|> <05k​ate> i think it got skipped over in the last batch of djinn cleanups yeah, for a while there was also still code to apply that antimagic duration if you got MP drained as an olddjinn
15:36:52 <Discord|> <05k​ate> next cleanup i want to do is probably pakellas, all the handling for evocations enhancers everywhere that does nothing is such a mess
15:39:17 <Discord|> <10P​leasingFungus> people keep saying they're bringing pak back
15:39:24 <Discord|> <10P​leasingFungus> by that i mean i think someone said that about six months ago
15:40:54 <Discord|> <05k​ate> hmm, i feel like it'd probably need a fundamental enough redesign that getting rid of the current dead code in advance would probably be a net positive if so
15:42:26 <Nivim> ebering: Sorry for not responding for so long, but got pulled away; I was beside no green crystal at all, and casting the spell did not result in any beams hitting me, and could not have so far as I could tell. It seemed the Starburst spell just randomly gave prompts for no reason, which was why I brought it up.
15:43:41 <Nivim> (It was in elf, with rock walls in a messy shape, an earth elemental, and I think a fire elementalist.)
15:43:41 <Discord|> <12e​bering> without more details (a screen shot at minimum, preferably a save back up) this will be very hard to debug
15:43:42 <Nivim> Darn; I'll try to find it again.
15:44:23 <Discord|> <12e​bering> Elf has green crystal walls in many vaults which bounce all bolt types, as well as rock walls with a green tile, so are you sure there was no green crystal in range?
15:44:54 <Nivim> Hm, I guess there could have been; I was playing tiles, but nothing was bouncing, even on succeeding casts.
15:45:00 <Nivim> s/tiles/consol/
15:45:05 <Nivim> Ugh, worst typo.
15:53:12 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.27-a0-1351-g47152c58aa (34)
16:00:34 <Nivim> Ok, found it, it was indeed green crystal and I didn't see the miss message at the time; I had checked the wrong walls for potential bouncing.
16:05:41 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.27-a0-1353-g14994ecaaf (34)
16:26:15 <Kelbell> bzbzbz (L16 OpTm) ERROR in 'spl-book.cc' at line 144: ASSERT failed: book of 47 out of range 0 (0) .. (int)ARRAYSZ(spellbook_templates) (43) (Lair:6)
16:26:43 <Kelbell> bzbzbz (L16 OpTm) ERROR in 'spl-book.cc' at line 144: ASSERT failed: book of 47 out of range 0 (0) .. (int)ARRAYSZ(spellbook_templates) (43) (Lair:6)
16:27:39 <Kelbell> bzbzbz (L16 OpTm) ERROR in 'spl-book.cc' at line 144: ASSERT failed: book of 47 out of range 0 (0) .. (int)ARRAYSZ(spellbook_templates) (43) (Lair:6)
16:43:12 <Kelbell> bzbzbz (L16 OpTm) ERROR in 'spl-book.cc' at line 144: ASSERT failed: book of 47 out of range 0 (0) .. (int)ARRAYSZ(spellbook_templates) (43) (Lair:6)
16:47:43 <Discord|> <10P​leasingFungus> whoops
16:47:46 <Discord|> <10P​leasingFungus> looks like i broke it
16:47:53 <Discord|> <10P​leasingFungus> !crashlog bzbzbz
16:47:54 <Discord|> <04C​erebot> 7. bzbzbz, XL16 OpTm, T:35303 (milestone): https://crawl.kelbi.org/crawl/morgue/bzbzbz/crash-bzbzbz-20210627-204253.txt
16:48:12 <Discord|> <08n​icolae> corngrats!
16:55:35 <Discord|> <10P​leasingFungus> randbooks are really something
16:55:35 <Discord|> <10P​leasingFungus> https://cdn.discordapp.com/attachments/747522859361894521/858812601734660106/unknown.png
16:58:45 <Cheibriados> 03PleasingFungus02 07* 0.27-a0-1354-gcaca448: Adjustments to book generation 10(11 days ago, 11 files, 138+ 181-) 13https://github.com/crawl/crawl/commit/caca448e2213
16:58:45 <Cheibriados> 03PleasingFungus02 07* 0.27-a0-1355-g1158a0e: Don't list the books a spell can be found in 10(11 days ago, 3 files, 3+ 49-) 13https://github.com/crawl/crawl/commit/1158a0e8621f
16:59:08 <Discord|> <10P​leasingFungus> well, "i don't know what broke, but maybe this will fix it?"
17:11:54 <dcss-ci> 04Build failed for 08master @ 1158a0e8 06https://github.com/crawl/crawl/actions/runs/976966291
17:15:03 <geekosaur> welp
17:15:49 -!- ProzacElf_ is now known as ProzacElf
17:18:26 <Discord|> <10P​leasingFungus> uh
17:19:09 <Discord|> <10P​leasingFungus> hm, same crash
17:21:08 <Discord|> <10P​leasingFungus> ah, got it
17:22:01 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.27-a0-1355-g1158a0e862 (34)
17:24:29 <Cheibriados> 03PleasingFungus02 07* 0.27-a0-1356-gb88236d: Maybe fix a book crash 10(16 seconds ago, 2 files, 3+ 4-) 13https://github.com/crawl/crawl/commit/b88236dc1638
17:27:37 <Kelbell> applebop (L4 MiFi) ERROR in 'random-pick.h' at line 147: bad distrib (D:3)
17:28:15 <Kelbell> MissyNym (L1 DsWz) ERROR in 'random-pick.h' at line 147: bad distrib (D:1)
17:28:58 <geekosaur> !crashlog applebop
17:28:59 <Sequell> 1. applebop, XL4 MiFi, T:1959 (milestone): https://crawl.kelbi.org/crawl/morgue/applebop/crash-applebop-20210627-212716.txt
17:29:01 <Kelbell> applebop (L4 MiFi) ERROR in 'random-pick.h' at line 147: bad distrib (D:3)
17:29:29 <Kelbell> MissyNym (L1 DsWz) ERROR in 'random-pick.h' at line 147: bad distrib (D:1)
17:29:40 <Kelbell> Shadowablaze (L1 SpGl) ERROR in 'random-pick.h' at line 147: bad distrib (D:1)
17:30:22 <Discord|> <08n​icolae> not sure you did
17:30:22 <Discord|> <10P​leasingFungus> oh no
17:30:22 <Discord|> <10P​leasingFungus> oh god
17:30:25 <Kelbell> rypofalem (L1 DrAE) ERROR in 'random-pick.h' at line 147: bad distrib (D:1)
17:30:43 <Discord|> <10P​leasingFungus> i don't understand! it works locally
17:30:46 <Discord|> <10P​leasingFungus> what is HAPPENING
17:31:04 <Discord|> <08n​icolae> oh no, this is why you wanted me on the dev team, you needed a patsy to take the fall
17:31:13 <Kelbell> applebop (L4 MiFi) ERROR in 'random-pick.h' at line 147: bad distrib (D:3)
17:31:14 <Discord|> <10P​leasingFungus> lol
17:31:24 <Kelbell> Esekla (L1 DjVM) ERROR in 'random-pick.h' at line 147: bad distrib (D:1)
17:31:54 <Kelbell> YSG (L9 DgFi) ERROR in 'random-pick.h' at line 147: bad distrib (D:8)
17:31:57 <Kelbell> Effigy (L1 FeTm) ERROR in 'random-pick.h' at line 147: bad distrib (D:1)
17:33:23 <Kelbell> slep (L1 DsWn) ERROR in 'random-pick.h' at line 147: bad distrib (D:3)
17:33:27 <Kelbell> applebop (L4 MiFi) ERROR in 'random-pick.h' at line 147: bad distrib (D:3)
17:34:11 <Discord|> <12e​bering> did you rebuild cko
17:34:18 <Discord|> <10P​leasingFungus> i think that is the problem
17:34:21 <Kelbell> applebop (L4 MiFi) ERROR in 'random-pick.h' at line 147: bad distrib (D:3)
17:34:29 <Discord|> <10P​leasingFungus> i didn't write a fix for whatever the hell this is
17:34:39 <Discord|> <10P​leasingFungus> i think it's something with spl-book.cc:choose_book_type
17:35:17 <Discord|> <10P​leasingFungus> but i don't know how to replicate it
17:35:51 <Discord|> <10P​leasingFungus> i think i need to create a book vault on an early D level maybe
17:35:51 <Discord|> <10P​leasingFungus> or maybe anywhere
17:35:51 <Kelbell> YSG (L9 DgFi) ERROR in 'random-pick.h' at line 147: bad distrib (D:8)
17:35:51 <Discord|> <12e​bering> do we include seeds in the crash number
17:35:57 <Discord|> <12e​bering> crash log
17:35:58 <Discord|> <12e​bering> yes!
17:36:00 <Discord|> <12e​bering> use the seed!
17:36:03 <Kelbell> slep (L1 DsWn) ERROR in 'random-pick.h' at line 147: bad distrib (D:3)
17:36:24 <Discord|> <12e​bering> (on mobile sorry not more helpful)
17:36:30 <Kelbell> applebop (L4 MiFi) ERROR in 'random-pick.h' at line 147: bad distrib (D:3)
17:37:05 <Discord|> <10P​leasingFungus> used the seed. it didn't crash
17:37:39 <dcss-ci> 04Build failed for 08master @ b88236dc 06https://github.com/crawl/crawl/actions/runs/977017141
17:37:48 <Kelbell> particleface (L7 OpAE) ERROR in 'random-pick.h' at line 147: bad distrib (D:6)
17:38:06 <Kelbell> slep (L1 DsWn) ERROR in 'random-pick.h' at line 147: bad distrib (D:3)
17:38:09 <Kelbell> applebop (L4 MiFi) ERROR in 'random-pick.h' at line 147: bad distrib (D:3)
17:38:10 <Kelbell> YSG (L9 DgFi) ERROR in 'random-pick.h' at line 147: bad distrib (D:8)
17:39:30 <Discord|> <10P​leasingFungus> tried with the exact commit
17:39:36 <Discord|> <10P​leasingFungus> i don't understand what's happening
17:40:16 <Kelbell> applebop (L4 MiFi) ERROR in 'random-pick.h' at line 147: bad distrib (D:3)
17:40:34 <Kelbell> slep (L2 DsWn) ERROR in 'random-pick.h' at line 147: bad distrib (D:3)
17:41:24 <Kelbell> particleface (L7 OpAE) ERROR in 'random-pick.h' at line 147: bad distrib (D:6)
17:41:47 <Kelbell> Shadowablaze (L3 SpGl) ERROR in 'random-pick.h' at line 147: bad distrib (D:2)
17:42:16 <Cheibriados> 03PleasingFungus02 07* 0.27-a0-1357-g5d287be: Revert "Adjustments to book generation" 10(23 seconds ago, 11 files, 181+ 139-) 13https://github.com/crawl/crawl/commit/5d287be60585
17:42:39 <Kelbell> YSG (L9 DgFi) ERROR in 'random-pick.h' at line 147: bad distrib (D:8)
17:43:00 <Kelbell> pedritolo (L13 FeCK) ERROR in 'random-pick.h' at line 147: bad distrib (Lair:6)
17:43:11 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.27-a0-1356-gb88236dc16 (34)
17:43:47 <Kelbell> slep (L1 DsWn) ERROR in 'random-pick.h' at line 147: bad distrib (D:2)
17:43:49 <Kelbell> bzbzbz (L16 OpTm) ERROR in 'spl-book.cc' at line 145: ASSERT failed: book of 47 out of range 0 (0) .. (int)ARRAYSZ(spellbook_templates) (43) (Lair:6)
17:44:00 <Discord|> <10P​leasingFungus> this doesn't fix the original bzbzbz crash
17:44:06 <Discord|> <10P​leasingFungus> (the revert doesn't, that is)
17:44:09 <Kelbell> Shadowablaze (L1 SpGl) ERROR in 'random-pick.h' at line 147: bad distrib (D:2)
17:44:24 <Kelbell> pedritolo (L13 FeCK) ERROR in 'random-pick.h' at line 147: bad distrib (Lair:6)
17:44:41 <Kelbell> YSG (L9 DgFi) ERROR in 'random-pick.h' at line 147: bad distrib (D:8)
17:45:07 <Discord|> <12e​bering> well cko only just now rebuilt to 1356, so these crashes haven't picked up the revert yet....
17:45:30 <Kelbell> slep (L1 DsWn) ERROR in 'random-pick.h' at line 147: bad distrib (D:2)
17:46:00 <Cheibriados> 03PleasingFungus02 07* 0.27-a0-1358-ga0a28fc: Revert "Maybe fix a book crash" 10(17 seconds ago, 2 files, 4+ 3-) 13https://github.com/crawl/crawl/commit/a0a28fc8c30f
17:46:23 <Discord|> <10P​leasingFungus> that last one doesn't even build
17:46:23 <Discord|> <10P​leasingFungus> ugh
17:46:23 <Discord|> <10P​leasingFungus> anyway, trying to repro the bzbzbz thing
17:46:23 <Kelbell> agentchuck (L27 OgAE) ERROR in 'spl-book.cc' at line 145: ASSERT failed: book of 44 out of range 0 (0) .. (int)ARRAYSZ(spellbook_templates) (43) (Hell)
17:46:23 <Discord|> <10P​leasingFungus> then will go back to figuring out what the heck is the bad distrib thing
17:46:46 <Kelbell> Shadowablaze (L2 SpGl) ERROR in 'random-pick.h' at line 147: bad distrib (D:2)
17:47:03 <Kelbell> particleface (L7 OpAE) ERROR in 'random-pick.h' at line 147: bad distrib (D:6)
17:47:04 <Kelbell> YSG (L9 DgFi) ERROR in 'random-pick.h' at line 147: bad distrib (D:8)
17:48:03 <Kelbell> Shadowablaze (L1 SpGl) ERROR in 'random-pick.h' at line 147: bad distrib (D:2)
17:48:09 <Kelbell> slep (L2 DsWn) ERROR in 'random-pick.h' at line 147: bad distrib (D:2)
17:48:29 <Kelbell> YSG (L9 DgFi) ERROR in 'random-pick.h' at line 147: bad distrib (D:8)
17:48:57 <Discord|> <10P​leasingFungus> 😦
17:49:20 <Kelbell> particleface (L7 OpAE) ERROR in 'random-pick.h' at line 147: bad distrib (D:6)
17:49:27 <Kelbell> rypofalem (L2 DrSu) ERROR in 'random-pick.h' at line 147: bad distrib (D:2)
17:49:39 <Kelbell> agentchuck (L27 OgAE) ERROR in 'spl-book.cc' at line 145: ASSERT failed: book of 44 out of range 0 (0) .. (int)ARRAYSZ(spellbook_templates) (43) (Hell)
17:50:50 <Kelbell> Shadowablaze (L3 SpGl) ERROR in 'random-pick.h' at line 147: bad distrib (D:3)
17:52:10 <Kelbell> Esekla (L1 DjVM) ERROR in 'random-pick.h' at line 147: bad distrib (D:1)
17:52:13 <Kelbell> Shadowablaze (L3 SpGl) ERROR in 'random-pick.h' at line 147: bad distrib (D:3)
17:52:31 <Discord|> <10P​leasingFungus> i just can't repro either of these bugs. doesn't matter what commit i'm on, doesn't matter whether i've built debug or non-debug, doesn't matter what seed i use.
17:52:40 <Kelbell> slep (L2 DsWn) ERROR in 'random-pick.h' at line 147: bad distrib (D:2)
17:52:53 <Discord|> <10P​leasingFungus> i'm at my wits end.
17:52:59 <Discord|> <10P​leasingFungus> !crashlog agentchuck
17:53:00 <Discord|> <04C​erebot> 4. agentchuck, XL27 OgAE, T:130242 (milestone): https://crawl.kelbi.org/crawl/morgue/agentchuck/crash-agentchuck-20210627-214801.txt
17:53:32 <Kelbell> YSG (L9 DgFi) ERROR in 'random-pick.h' at line 147: bad distrib (D:8)
17:53:33 <Kelbell> Shadowablaze (L3 SpGl) ERROR in 'random-pick.h' at line 147: bad distrib (D:3)
17:54:52 <dcss-ci> 04Build failed for 08master @ 5d287be6 06https://github.com/crawl/crawl/actions/runs/977043361
17:55:20 <Kelbell> YSG (L9 DgFi) ERROR in 'random-pick.h' at line 147: bad distrib (D:8)
17:56:44 <Discord|> <12e​bering> Did you do a fresh des cache?
17:57:22 <Discord|> <10P​leasingFungus> no, not sure how to force that
17:57:22 <Discord|> <10P​leasingFungus> i didn't change any des stuff afaik tho?
17:57:57 <Discord|> <12e​bering> I’m guessing in the dark on mobile; levelgen bugs mean des to me. The cache is in the saves dir
17:58:12 <Discord|> <12e​bering> (Wherever that is on your build)
17:58:19 <Kelbell> Esekla (L3 DjVM) ERROR in 'random-pick.h' at line 147: bad distrib (D:4)
17:58:26 <Discord|> <12e​bering> Just delete it all.
17:58:35 <Kelbell> Behavioral (L19 PaFi) ERROR in 'spl-book.cc' at line 145: ASSERT failed: book of 44 out of range 0 (0) .. (int)ARRAYSZ(spellbook_templates) (43) (Elf:1)
17:58:59 <Kelbell> YSG (L9 DgFi) ERROR in 'random-pick.h' at line 147: bad distrib (D:8)
17:59:04 <Kelbell> pedritolo (L12 FeCK) ERROR in 'random-pick.h' at line 147: bad distrib (Lair:6)
17:59:08 <Discord|> <12e​bering> Other possibility is save compat?
17:59:39 <Discord|> <10P​leasingFungus> that could possibly explain the assert failed bug, not the bad distrib bug but one thing at a time
17:59:45 <Kelbell> Behavioral (L19 PaFi) ERROR in 'spl-book.cc' at line 145: ASSERT failed: book of 44 out of range 0 (0) .. (int)ARRAYSZ(spellbook_templates) (43) (Elf:1)
18:01:06 <Discord|> <10P​leasingFungus> !crashlog Behavioral
18:01:07 <Discord|> <04C​erebot> 12. Behavioral, XL19 PaFi, T:52869 (milestone): https://crawl.kelbi.org/crawl/morgue/Behavioral/crash-Behavioral-20210627-215913.txt
18:01:08 <Kelbell> Behavioral (L19 PaFi) ERROR in 'spl-book.cc' at line 145: ASSERT failed: book of 44 out of range 0 (0) .. (int)ARRAYSZ(spellbook_templates) (43) (Elf:1)
18:01:56 <Discord|> <10P​leasingFungus> ??rebuild
18:01:57 <Discord|> <04C​erebot> rebuild[1/2]: http://crawl.akrasiac.org/rebuild/ http://underhound.eu:81/rebuild/ https://cbro.berotato.org/rebuild/ http://crawl.xtahua.com/rebuild/ https://crawl.kelbi.org/rebuild/ Bug gammafunk, advil, |amethyst, or Nap.Kin for CDO. Use your powers wisely.
18:02:07 <Kelbell> Shadowablaze (L2 SpGl) ERROR in 'random-pick.h' at line 147: bad distrib (D:2)
18:02:20 <Discord|> <10P​leasingFungus> looks like i don't have rebuild permissions on cko
18:02:52 <Discord|> <10P​leasingFungus> it should be rebuilding automatically anyway tho
18:03:47 <Kelbell> YSG (L9 DgFi) ERROR in 'random-pick.h' at line 147: bad distrib (D:8)
18:04:50 <Discord|> <10P​leasingFungus> feels like it should have rebuilt by now honestly
18:05:24 <Discord|> <10P​leasingFungus> eh, i guess it usually takes about 20 minutes and it's only been 15
18:08:22 <Discord|> <05k​ate> it looks like the spl-book assert one is definitely some kind of save compat issue, i can repro it by loading a save from before 47152c58aa1 that has some unidentified books on the floor into a0a28fc8c30f03, and then trying to X over to the unidentified books
18:08:43 <Kelbell> Effigy (L1 OpTm) ERROR in 'random-pick.h' at line 147: bad distrib (D:1)
18:08:44 <Kelbell> YSG (L9 DgFi) ERROR in 'random-pick.h' at line 147: bad distrib (D:8)
18:09:25 <Kelbell> YSG (L9 DgFi) ERROR in 'random-pick.h' at line 147: bad distrib (D:8)
18:10:03 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.27-a0-1358-ga0a28fc8c3 (34)
18:10:22 <Discord|> <05k​ate> i think due to it using NUM_BOOKS as the thing to check for what glyph to display on unidentified books? so maybe that's fixable by something in tags.cc to identify books on transfer
18:12:04 <Discord|> <10P​leasingFungus> confusing
18:12:54 <Kelbell> Shadowablaze (L1 SpGl) ERROR in 'random-pick.h' at line 147: bad distrib (D:2)
18:13:52 <Kelbell> bobnalice (L7 DrTm) ERROR in 'random-pick.h' at line 147: bad distrib (D:5)
18:15:48 <Kelbell> agentchuck (L27 OgAE) ERROR in 'spl-book.cc' at line 145: ASSERT failed: book of 44 out of range 0 (0) .. (int)ARRAYSZ(spellbook_templates) (43) (Hell)
18:15:51 <Kelbell> YSG (L9 DgFi) ERROR in 'random-pick.h' at line 147: bad distrib (D:8)
18:17:41 <Discord|> <10P​leasingFungus> !crashlog agentchuck
18:17:43 <Discord|> <04C​erebot> 5. agentchuck, XL27 OgAE, T:130242 (milestone): https://crawl.kelbi.org/crawl/morgue/agentchuck/crash-agentchuck-20210627-221508.txt
18:17:53 <Discord|> <10P​leasingFungus> good, old
18:19:22 <Discord|> <10P​leasingFungus> i'm not able to repro anything on the current (reverted) mostly version fwiw
18:19:22 <Discord|> <10P​leasingFungus> even with old books
18:20:49 <Discord|> <05k​ate> ah, it seems to specifically only happen if the old book is out of LOS
18:20:55 <Discord|> <10P​leasingFungus> oh nice
18:21:07 <Discord|> <05k​ate> i can still repro a crash on the current version as long as the unid'd book isn't directly in LOS
18:22:57 <Discord|> <10P​leasingFungus> were you thinking about fixing it?
18:23:08 <Discord|> <10P​leasingFungus> i can take a shot at it soon but my energy levels + morale are both low rn
18:24:50 <Lantell> Unstable branch on underhound.eu updated to: 0.27-a0-1358-ga0a28fc8c3 (34)
18:26:53 <Discord|> <10P​leasingFungus> so i'd need a breather first
18:26:54 <Discord|> <05k​ate> I don't know exactly what the fix would be yet, need to stop and grab some food first but I can take a look at it after
18:27:02 <Discord|> <10P​leasingFungus> that'd be extremely great
18:27:07 <Discord|> <10P​leasingFungus> i would owe you one (1) removal
18:27:32 <Discord|> <05k​ate> understandable! I'll try and poke at it in a bit then yeah
18:29:23 <Kelbell> bzbzbz (L16 OpTm) ERROR in 'spl-book.cc' at line 144: ASSERT failed: book of 47 out of range 0 (0) .. (int)ARRAYSZ(spellbook_templates) (43) (Lair:6)
19:01:31 -!- allbery_b is now known as geekosaur
20:15:55 <Discord|> <05k​ate> hmm, well it definitely seems like the issue is that unidentified books on the map have NUM_BOOKS as their subtype, but i can't fully track down how or why that happens, since they do get successfully properly identified in the stash tracker if you just ctrl+f for them
20:16:53 <Discord|> <06a​dvil> I see there has been Fun
20:16:58 <Discord|> <05k​ate> i do think this is a fix that doesn't break anything else: https://gist.github.com/semitonal/0c8657ec1b031441ec22eb1ebd0256ab
20:17:07 <Discord|> <06a​dvil> "bad distrib" is a distrib_type that is not in the enum
20:17:07 <Discord|> <05k​ate> but i don't know that it's like, the Correct fix
20:17:17 <Kelbell> bzbzbz (L16 OpTm) ERROR in 'spl-book.cc' at line 144: ASSERT failed: book of 47 out of range 0 (0) .. (int)ARRAYSZ(spellbook_templates) (43) (Lair:6)
20:18:22 <Discord|> <05k​ate> ah this is for that above crash that kelbell just repeated, the other one is a separate issue that i haven't started looking into yet, heh
20:19:45 <Discord|> <10P​leasingFungus> bad distrib has been reverted for now
20:20:19 <Discord|> <10P​leasingFungus> i got that far
20:20:19 <Discord|> <10P​leasingFungus> but i didn’t understand how i’d caused it
20:20:33 <Discord|> <06a​dvil> my first guess is an uninitialized value somewhere, my second guess is memory corruption?
20:20:59 <Discord|> <06a​dvil> not sure why code would ever be working with that field untyped
20:21:56 <Discord|> <10P​leasingFungus> huh
20:21:58 <Discord|> <10P​leasingFungus> scary
20:29:45 <geekosaur> _book_weight looks funny to me
20:29:57 <geekosaur> even before it reaches the random picker. num_spells==0?
20:30:28 <geekosaur> sorry, n_sdpells
20:30:32 <geekosaur> n_spells
20:31:18 <geekosaur> and debug and possibly other things are filled with garbage
20:31:18 <Discord|> <06a​dvil> in caca448e2213 there's a fixed length array of random_pick_entry<int>s that is iterated through in a kind of weird way in probability_at, as far as I can tell it is looking for a sentinel value with rarity 0 to stop the iteration (for (const random_pick_entry<T> *pop = weights; pop->rarity; pop++)
20:32:26 <Discord|> <06a​dvil> I think the for loop in probability_at will go off the end of that array, so it's a little of column a, a little of column b
20:33:32 <Discord|> <06a​dvil> it'll replicate differently on compilers depending on how much sanitizing they do around safe memory, I've definitely found that clang is better at stably initializing stuff; if enough memory after the array was set to 0 it'd be fine
20:39:39 <Discord|> <11n​ikheizen> !source dec_berserk_recovery_player
20:39:40 <Discord|> <04C​erebot> 1/1. https://github.com/crawl/crawl/blob/master/crawl-ref/source/player.cc#L4479
20:40:02 <Discord|> <11n​ikheizen> Why does this function use delay and baseline delay like this?
20:40:53 <Discord|> <11n​ikheizen> Doesn't it create problems with faster or slower characters? Or does BASELINE_DELAY account for that?
21:22:37 <Discord|> <05k​ate> hmm, well adding an {  0,  0,   0, FLAT, 0 } line to the end of that random_pick_entry array does seem like it fixes that distrib_type crash? but i'm getting a new instance of the other crash now when i run make test, seems like it's occurring in item_value when making a shop somehow
21:29:16 <Discord|> <10P​leasingFungus> oh
21:29:18 <Discord|> <10P​leasingFungus> i figured that one out
21:29:26 <Discord|> <10P​leasingFungus> it's because it's trying to call spellbook_template on randbooks
21:29:31 <Discord|> <10P​leasingFungus> rand_level and rand_theme
21:29:36 <Discord|> <10P​leasingFungus> it should actually be calling another function
21:29:51 <Discord|> <10P​leasingFungus> one sec...
21:32:17 <Discord|> <10P​leasingFungus> right, it needs to be calling spells_in_book instead
21:43:21 <Kelbell> bzbzbz (L16 OpTm) ERROR in 'spl-book.cc' at line 144: ASSERT failed: book of 47 out of range 0 (0) .. (int)ARRAYSZ(spellbook_templates) (43) (Lair:6)
21:43:53 <Kelbell> bzbzbz (L16 OpTm) ERROR in 'spl-book.cc' at line 144: ASSERT failed: book of 47 out of range 0 (0) .. (int)ARRAYSZ(spellbook_templates) (43) (Lair:6)
22:09:51 <Cheibriados> 03PleasingFungus02 07* 0.27-a0-1359-ga2a4dfd: Maybe fix a book crash (kate) 10(23 seconds ago, 2 files, 2+ 1-) 13https://github.com/crawl/crawl/commit/a2a4dfd6fd07
22:18:40 <Discord|> <10P​leasingFungus> would anyone like to review the new, probably maybe fixed version, before i merge it again?
22:19:48 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.27-a0-1359-ga2a4dfd6fd (34)
22:23:02 <Lantell> freidrichen (L18 DjVM) ERROR in 'spl-book.cc' at line 144: ASSERT failed: book of 47 out of range 0 (0) .. (int)ARRAYSZ(spellbook_templates) (43) (Spider:4)
22:23:23 <Lantell> freidrichen (L18 DjVM) ERROR in 'spl-book.cc' at line 144: ASSERT failed: book of 47 out of range 0 (0) .. (int)ARRAYSZ(spellbook_templates) (43) (Spider:4)
22:27:06 <Discord|> <10P​leasingFungus> !crashlog freidrichen
22:27:07 <Discord|> <04C​erebot> 2. freidrichen, XL18 DjVM, T:42293 (milestone): https://underhound.eu/crawl/morgue/freidrichen/crash-freidrichen-20210628-022321.txt
22:27:22 <Discord|> <10P​leasingFungus> pre fix!
22:27:27 <Discord|> <05k​ate> phew
22:27:36 <Discord|> <10P​leasingFungus> oh, but on cue
22:27:38 <Discord|> <10P​leasingFungus> that's inconvenient
22:28:38 <Discord|> <05k​ate> also i could take a quick look if you like, not entirely sure that i fully understand the random_picker stuff but i can at least see if i can get the proposed change to crash on my end or not if that helps
22:29:09 <Cheibriados> New branch created: unbreakify (1 commit) 13https://github.com/crawl/crawl/tree/unbreakify
22:29:09 <Cheibriados> 03PleasingFungus02 07[unbreakify] * 0.27-a0-1360-g42f5cf0: Revert "Revert "Adjustments to book generation"" 10(16 minutes ago, 11 files, 143+ 187-) 13https://github.com/crawl/crawl/commit/42f5cf0cfd70
22:29:28 <Discord|> <10P​leasingFungus> thanks! i pushed it as https://github.com/crawl/crawl/commit/42f5cf0cfd70579566883588b72ea27827c844ed
22:29:56 <Discord|> <05k​ate> good branch name
22:30:13 <Discord|> <10P​leasingFungus> tyty
22:31:18 <Discord|> <05k​ate> oh i also noticed and forgot to call out the very sad loss of "_book_visually_special" from one of the previous commits, rip to whatever that was doing
22:31:33 <Discord|> <10P​leasingFungus> very rip
22:31:58 <Discord|> <10P​leasingFungus> i assume in a year or two we'll find a pile of book tiles which are now unused because they checked the book glyph to determine what to display, or something
22:33:28 <Discord|> <05k​ate> i did poke into it some more and it looks like item_colour is still doing something mysterious to do with it
22:33:33 <Discord|> <05k​ate> !source item_colour
22:33:34 <Discord|> <04C​erebot> Can't find item_colour.
22:33:48 <Discord|> <05k​ate> !source makeitem.cc:90
22:33:49 <Discord|> <04C​erebot> https://github.com/crawl/crawl/blob/master/crawl-ref/source/makeitem.cc#L90
22:34:58 <Discord|> <10P​leasingFungus> huh
22:34:58 <Discord|> <05k​ate> i guess that's what sets up the _book_visually_special check but i have no idea what effect it actually ends up having
22:35:02 <Discord|> <10P​leasingFungus> i definitely thought i understood what it did, at some point
22:39:01 <Discord|> <05k​ate> well, make test did a lot more complaining about monsters being stuck in walls of vaults than i feel like it usually does but i think it's probably safe to assume that's unrelated to the spellbook stuff and it just wanted to worry me
22:39:20 <Discord|> <05k​ate> and i can't reproduce any of the previous crashes so it seems like hopefully it should be good!
22:41:10 <Discord|> <05k​ate> oh huh, the 0,0,0,FLAT,0 line doesn't need to be the last entry, even?
22:44:24 <Discord|> <06a​dvil> It would stop iteration on any entry with rarity 0
22:45:22 <Discord|> <06a​dvil> (Later stuff would be ignored)
22:46:04 <Discord|> <06a​dvil> That whole thing might be a lot safer as a vector or something
23:16:35 <Discord|> <10P​leasingFungus> hm?
23:49:49 <floraline> !tell PleasingFungus i added you to build rights on cko
23:49:50 <Sequell> floraline: OK, I'll let pleasingfungus know.
23:50:13 <Discord|> <10P​leasingFungus> floraline: thanks!