02:00:13 <Discord|> <10P​leasingFungus> i’m hearing big gold
02:11:03 -!- amalloy is now known as amalloy_
02:15:45 <Cbrotell> Unstable branch on cbro.berotato.org updated to: 0.27-a0-417-g317cea8a3c (34)
03:30:49 <Kelbell> Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-3944-gcf420f87c6
05:03:10 -!- wheals8 is now known as wheals
05:03:10 -!- TooLmaN_ is now known as TooLmaN
05:03:10 -!- aidanh_ is now known as aidanh
08:07:39 <Cheibriados> New branch created: pull/1776 (1 commit) 13https://github.com/crawl/crawl/pull/1776
08:07:39 <Cheibriados> 03AdamPG02 07https://github.com/crawl/crawl/pull/1776 * 0.27-a0-418-g96ecafa: Fix a typo in geoelf_rooms.lua 10(20 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/96ecafa05112
09:07:10 <advil> some day we should figure out how to build the debs in CI
10:11:54 <gammafunk> yeah, would be nice
10:12:33 <gammafunk> didn't really appreciate the tone of the person in that github issue, but figured I'd be diplomatic about it
10:16:39 <advil> yeah, that was obnoxious
10:41:02 -!- johnnyzero is now known as johnny0
11:09:02 <Discord|> <12p​atrickm> my natural inclination is to just make fat stacks but apparently there is such a thing as "too much gold"
11:11:45 <Discord|> <10P​leasingFungus> cruel world
11:13:38 <Discord|> <12p​atrickm> @gammafunk currently i've got nicolae_gozag_conspicuous_consumption without the golden dragon idea, instead i made it so you need to get past the deep water and some clear rock windows, to get to nine tiles of the usual quantities for that level (so just nine stacks of gold in regular quantities, no fiddling with levels), it's a nice amount but nothing to go wild for imo. i think i might put the
11:13:38 <Discord|> golden dragon idea into another vault.
11:19:33 -!- amalloy_ is now known as amalloy
11:24:23 -!- Vaevictu1 is now known as Vaevictus
11:35:17 <Cheibriados> 03PleasingFungus02 07* 0.27-a0-418-g5110eb7: Fix ID notes (dinky) 10(35 seconds ago, 1 file, 7+ 10-) 13https://github.com/crawl/crawl/commit/5110eb77c4cd
11:49:21 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.27-a0-418-g5110eb77c4 (34)
11:54:56 <gammafunk> patrickm: Ok, feel free to upload revised version to mantis when you have a chance
11:56:17 <gammafunk> also see if you can do some objstat runs to get data on how to nerf PleasingFungus
11:56:21 <gammafunk> important for game balance imo
12:05:55 <Discord|> <10P​leasingFungus> very important
12:05:58 <Discord|> <10P​leasingFungus> wow, i just reproduced @player_only@
12:06:10 <Discord|> <10P​leasingFungus> i think it was in 2014 that i first tried to debug this one?
12:06:16 <Discord|> <10P​leasingFungus> time flies when you're having fun
12:06:24 <Henzell> Unstable branch on crawl.akrasiac.org updated to: 0.27-a0-418-g5110eb7 (34)
12:07:38 <Discord|> <12e​bering> dang wow
12:14:14 <Discord|> <12p​atrickm> @gammafunk are there any other overflows that you think need to be revised, i figured i would submit all the fixups at once
12:22:20 -!- amalloy is now known as amalloy_
12:23:12 <Discord|> <10P​leasingFungus> oh, looks like i managed to reproduce it last time too (in 2015)
12:23:19 <Discord|> <10P​leasingFungus> wish i'd checked my notes then... would've saved me a little time
12:27:25 <Cheibriados> 03PleasingFungus02 07* 0.27-a0-419-g7a85846: Fix @player_only@ messages (#9201) 10(4 minutes ago, 3 files, 39+ 6-) 13https://github.com/crawl/crawl/commit/7a858468532a
12:34:58 <gammafunk> wow, rip to an epic bug
12:35:43 <gammafunk> however
12:35:45 <Discord|> <10P​leasingFungus> that code is so very bad and i’m not convinced i improved it
12:35:49 <gammafunk> from that commit message:
12:35:53 <gammafunk> When printing monster spell messages, we never checked to see if we
12:35:54 <gammafunk> they were valid.
12:36:03 <gammafunk> so in a way, the bug will never be fixed
12:36:21 <Discord|> <10P​leasingFungus> wow
12:36:23 <Discord|> <12p​atrickm> the eternal bug
12:36:23 <Discord|> <10P​leasingFungus> bullying
12:36:36 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.27-a0-419-g7a85846853 (34)
12:36:38 <Discord|> <10P​leasingFungus> maybe i was just trying to get into the spirit of the bug!
12:37:24 <Discord|> <12p​atrickm> in order to catch a bug, you have to think like a bug...
12:37:43 <gammafunk> yeah, every time see that sort of weird (dare I call it "old school"?) style of variable alignment, I get the intangible sense I'm looking at ancient crawlcode
12:37:55 <gammafunk> talking about
12:37:56 <gammafunk> const actor*    foe  = _get_foe(*mons);
12:37:58 <gammafunk> const monster* m_foe = foe ? foe->as_monster() : nullptr;
12:38:15 <Discord|> <10P​leasingFungus> lol
12:38:16 <gammafunk> lining up the equal signs like that? is that considered good style
12:38:30 <Discord|> <10P​leasingFungus> by some!
12:38:33 <gammafunk> or was it circa 2008
12:38:42 <Discord|> <03w​heals> yes, it's proof you have a gigantic brain and are an amazing coder
12:38:53 <Cheibriados> Another message for event out of LoS. 13https://crawl.develz.org/mantis/view.php?id=12520 by Yermak
12:39:40 <gammafunk> aha, found the whealscode
12:39:40 <Discord|> <10P​leasingFungus> golang does it automatically, in some contexts
12:39:40 <gammafunk> interesting
12:39:48 <gammafunk> oh wow
12:39:58 <gammafunk> yeah just saw the invalid_msg() you had to write
12:39:59 <gammafunk> yikes
12:58:51 <Discord|> <12p​atrickm> everything should be lined up imo
12:59:15 <Discord|> <12p​atrickm> you gotta pad out your c++ lines so the semicolons line up
13:04:24 <Discord|> <10P​leasingFungus> gammafunk: BIG yikes 😦
13:26:38 <gammafunk> patrickm: btw, on the subject of alignment, can you align future vault submissions so that DES statements are aligned after the colon, like so: https://dpaste.com/B99GV5D2B
13:27:47 <gammafunk> helps readability; not a huge deal, whenever you forget, and I'll do that for your current submissions, but nice if you can remember
13:28:57 <gammafunk> there are a lot of things about des where it's maybe too free-form and it would be neat to have a lint checker, but maybe that's too big a can of worms to open
13:35:46 <Discord|> <12p​atrickm> sure
13:36:35 <Discord|> <12p​atrickm> obviously we need to rewrite the vault definition parser so that all the DES statements have five characters
14:12:31 <Discord|> <12p​atrickm> gozag vault revision submitted to mantis
14:26:56 <gammafunk> thx
15:01:09 <Implojin> &dump zeunysos
15:01:10 <Sequell> http://crawl.akrasiac.org/rawdata/zeunysos/zeunysos.txt
15:05:50 <Implojin> yeah pretty sure that's happening cause they upgraded their save with unid equipment already in their inventory, it probably needs to run inventory through the equip-id thing once for save upgrades
15:08:35 <Implojin> floor id, even
15:37:16 -!- neunon_ is now known as neunon
15:37:16 -!- Raichvent_ is now known as Raichvent
15:37:38 -!- Epakai_ is now known as Epakai
15:38:17 <Discord|> <10P​leasingFungus> oops
15:39:31 <Discord|> <10P​leasingFungus> vaguely wonder if it should run in both places for safety
15:39:34 <Implojin> maybe but that second check would just be dead code for everything that isn't a save upgrade
15:40:16 <Implojin> unless there are other ways for items to be placed directly in player inventory?
15:40:25 <Implojin> it already handles shop purchases
15:40:47 -!- TAS-2012v is now known as TAS_2012v
15:42:43 -!- krator44-- is now known as krator44
15:45:19 <Implojin> i guess it's probably safer to run it at equip just in case
15:52:14 <Discord|> <10P​leasingFungus> yeah, that was my feeling
15:52:55 <Implojin> it doesnt need to be run at 4 places like before though, it can hook in where i was going to unset that prop, i think
15:56:55 <Implojin> i guess this way there's no need to add a tag minor if players can still equip id
15:56:55 -!- jilles_ is now known as jilles
15:59:38 <Discord|> <10P​leasingFungus> yes
16:54:38 <Cheibriados> New branch created: pull/1777 (1 commit) 13https://github.com/crawl/crawl/pull/1777
16:54:39 <Cheibriados> 03Implojin02 07https://github.com/crawl/crawl/pull/1777 * 0.27-a0-420-g3e22125: Fix equipment identification 10(6 minutes ago, 4 files, 19+ 13-) 13https://github.com/crawl/crawl/commit/3e22125798b0
17:00:27 <Cheibriados> New branch created: pull/1778 (2 commits) 13https://github.com/crawl/crawl/pull/1778
17:00:27 <Cheibriados> 03Skrybe02 {GitHub} 07https://github.com/crawl/crawl/pull/1778 * 0.27-a0-420-gf5bb142: Edit skrybe_vaults_entry_preservation 10(30 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/f5bb142bf9d3
17:00:27 <Cheibriados> 03Skrybe02 {GitHub} 07https://github.com/crawl/crawl/pull/1778 * 0.27-a0-421-g329c5cb: New Trog-themed weapon trove 10(8 minutes ago, 1 file, 49+ 2-) 13https://github.com/crawl/crawl/commit/329c5cbb37ff
17:18:08 <Implojin> @PleasingFungus i think 1777 should fix that if you have time to take a look
17:30:29 <Discord|> <10P​leasingFungus> i’ll look in a bit, thanks!
17:47:17 <Cheibriados> 03ebering02 07[ashenzaru] * 0.27-a0-420-gd661944: Reforge the Chains I: Remove old Ash actives 10(2 weeks ago, 30 files, 41+ 617-) 13https://github.com/crawl/crawl/commit/d66194450794
17:47:17 <Cheibriados> 03ebering02 07[ashenzaru] * 0.27-a0-421-g83703cd: Reforge the Chains II: Adjust Ash passives 10(2 weeks ago, 17 files, 62+ 38-) 13https://github.com/crawl/crawl/commit/83703cd2d29a
17:47:17 <Cheibriados> 03ebering02 07[ashenzaru] * 0.27-a0-422-g6f9bf22: Reforge the Chains III: Curse piety 10(12 days ago, 17 files, 92+ 247-) 13https://github.com/crawl/crawl/commit/6f9bf22f91a3
17:47:17 <Cheibriados> 03ebering02 07[ashenzaru] * 0.27-a0-423-g5a8d8b9: Reforge the Chains IV: Shatter the Chains 10(10 days ago, 14 files, 83+ 90-) 13https://github.com/crawl/crawl/commit/5a8d8b90b482
17:47:17 <Cheibriados> 03ebering02 07[ashenzaru] * 0.27-a0-424-gfa448ce: Remove an XXX; startup.cc handles the issue in question 10(5 days ago, 1 file, 0+ 1-) 13https://github.com/crawl/crawl/commit/fa448cea9ba3
17:47:17 <Cheibriados> 03ebering02 07[ashenzaru] * 0.27-a0-425-g08e83e0: Reforge the Chains V: Bind skill knowledge to curses 10(4 days ago, 12 files, 180+ 344-) 13https://github.com/crawl/crawl/commit/08e83e0723a7
17:47:17 <Cheibriados> 03ebering02 07[ashenzaru] * 0.27-a0-426-gd58801c: Save compatibility for new Ashenzari 10(4 hours ago, 1 file, 2+ 10-) 13https://github.com/crawl/crawl/commit/d58801c4305f
17:47:17 <Cheibriados> 03ebering02 07[ashenzaru] * 0.27-a0-427-g1951f1c: Code cleanup of old curse code 10(3 hours ago, 3 files, 0+ 68-) 13https://github.com/crawl/crawl/commit/1951f1cf458f
17:47:44 <Cheibriados> Branch pull/1736 updated to be equal with ashenzaru: 13https://github.com/crawl/crawl/pull/1736
17:48:02 <Discord|> <12e​bering> @PleasingFungus more to look at; I'm done crawl for the day but maybe that "tomorrow" when we chat about skill boosts should happen
17:50:04 <Discord|> <12e​bering> the other big todos are: randartification + naming; and figuring a good way to display the curse in the ability menu
17:55:07 <Discord|> <10P​leasingFungus> lmk if you want any help
17:56:09 <Discord|> <12e​bering> brainstorming curse names!
17:56:17 <Discord|> <12e​bering> also the ability menu (a working mock-up)
17:56:28 <Discord|> <12e​bering> also agree re vision_iterator
18:04:23 <Discord|> <10P​leasingFungus> i can take a look later, then
18:06:46 <Discord|> <12e​bering> no rush!
18:28:23 <Cheibriados> New branch created: pull/1779 (1 commit) 13https://github.com/crawl/crawl/pull/1779
18:28:23 <Cheibriados> 03Implojin02 07https://github.com/crawl/crawl/pull/1779 * 0.27-a0-420-g0144f5c: Add another species title 10(8 minutes ago, 1 file, 5+ 0-) 13https://github.com/crawl/crawl/commit/0144f5c2d516
18:34:27 <Lantell> Unstable branch on underhound.eu updated to: 0.27-a0-419-g7a85846853 (34)
19:03:29 <Implojin> hmm
19:03:41 <Implojin> i wonder if it's possible to call take_note from inside of _tag_read_you_items or if that would break things
19:20:55 <Discord|> <12p​atrickm> brainstorming curse names, you say. go on...
19:31:13 <Implojin> maybe it's not possible to take a note there since the note chunk isn't read in yet
19:31:21 <Implojin> making changes to this tag code is vaguely terrifying
20:13:25 <Cheibriados> 03Implojin02 {PleasingFungus} 07* 0.27-a0-420-g83025b5: Fix equipment identification 10(3 hours ago, 4 files, 19+ 13-) 13https://github.com/crawl/crawl/commit/83025b51d330
20:29:33 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.27-a0-420-g83025b51d3 (34)
20:48:16 <Cheibriados> 03PleasingFungus02 07* 0.27-a0-421-g7ddf969: New AK splash screen from E.M. Fields 10(2 minutes ago, 1 file, 0+ 0-) 13https://github.com/crawl/crawl/commit/7ddf969dea04
20:53:35 <advil> for those who don't track reddit, someone just won an (almost) headbutt-only game: https://www.reddit.com/r/dcss/comments/lsjet8/is_it_possible_to_win_the_game_by_repeatedly/
20:53:46 <advil> 2 accidental real attacks from bumping into an invisible horror
20:54:09 <Discord|> <10P​leasingFungus> reminiscent of the almost-pacifist game
20:55:36 <Implojin> pr 1779 is a commemorative species title for them
20:55:52 <Implojin> i know y'all had some issues with the mummy thing but i figure in this case, minotaur of chei is much less punishing to canonize
21:02:38 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.27-a0-421-g7ddf969dea (34)
21:03:03 <Implojin> which is not to say that the conduct doesn't sound crazy; just that for future players going for titles, SK_FIGHTING mi of chei doesn't seem unreasonable
21:32:45 <Discord|> <12p​atrickm> my vaults are only in that morgue 21 times, i gotta get my numbers up
21:43:54 <Discord|> <10P​leasingFungus> ya, i saw that pr
21:43:57 <Discord|> <10P​leasingFungus> not sure how i feel about it
21:56:46 <Implojin> could you elaborate?
21:58:43 <Cheibriados> Delver began in an attic closet 13https://crawl.develz.org/mantis/view.php?id=12521 by MainiacJoe
22:01:49 <Implojin> i think, generally speaking, i'd like to see more formalized conduct tracking as part of the game
22:02:37 <Implojin> maybe species titles are not a great fit for this, but also, players who engage in those things are generally doing so out of enjoyment of the game, and i don't see any harm in little nods to things like that either
22:10:17 <Implojin> i guess i could understand a concern about not wanting to incentivize playstyles that are, hm, heavily degenerate?
22:12:24 <Discord|> <12p​atrickm> hell yeah
22:16:55 <Discord|> <10P​leasingFungus> implojin: i mean, your proposed title doesn't really have any connection with the conduct
22:16:55 <Implojin> oh
22:16:57 <Discord|> <10P​leasingFungus> 'fighting title and worships chei'?
22:17:22 <Discord|> <10P​leasingFungus> i like fun titles, i like fun challenges for players, i like encouraging interesting conducts
22:17:28 <Discord|> <10P​leasingFungus> so i totally agree with you on all of those
22:17:35 <Discord|> <10P​leasingFungus> but i'm just not sure this title works
22:17:39 <Discord|> <10P​leasingFungus> probably i'll sleep on it
22:17:40 <Implojin> yeah, fighting was from their morgue, and chei was from their discussion of the challenge
22:20:56 <Implojin> i agree that doesn't necessarily seem the best fit to the actual conduct
22:25:23 <Discord|> <10P​leasingFungus> what you might really want is something like "mi with very low weapon & offensive spell skills", and that doesn't really fit with the skill titles system
22:29:31 <Implojin> yeah, i see your point
22:31:49 <Implojin> absence of skill is the opposite of what skill titles have been about, maybe this conduct is a particularly poor fit to that approach
23:20:47 <Discord|> <10P​leasingFungus> people have been talking about cheevos for crawl
23:20:47 <Discord|> <10P​leasingFungus> (admittedly they've been talking about that for a long time, on and off)
23:20:47 <Discord|> <10P​leasingFungus> this does feel like the sort of thing that would fit there
23:20:47 <Discord|> <10P​leasingFungus> could track action logs, etc
23:58:44 -!- misha is now known as doomsayer
23:58:46 -!- doomsayer is now known as misha