00:12:48 <02|​amethyst> last call for student projects 00:12:48 <02|​amethyst> ebering send me a bunch 00:12:48 <02|​amethyst> and I know PF mentioned it in a commit message, but I might need to be refreshed 00:13:59 <02|​amethyst> Also, I assume it's fine to give my students a Discord invite to this server/channel (hopefully some of them will use IRC, but I figured more of them probably have Discord experience) 00:16:21 <02|​amethyst> I was thinking about "make it work with TAG_MAJOR_VERSION = 35" as one of the tasks 00:16:53 <02|​amethyst> I'm dividing up tasks into "small" and "large", with each group having to select one large or two small tasks 00:18:35 <02|​amethyst> "finish up this existing PR", of which there are 3 or 4, is "small", while "add webtiles sound support" and "improve the experience for visually impaired players" is "large" 00:19:09 <02|​amethyst> also, if anyone wants to give a Zoom talk to my students on something Crawl-related, especially but not exclusively the code, hit me up yo 00:19:32 <02|​amethyst> They all have C++ experience, but might not all be that great at it 00:20:26 <02|​amethyst> probably none of them have done Lua, and only like half Python or Javascript, but they're seniors so I don't mind expecting them to learn on their own 00:20:49 <02|​amethyst> I also hope yall will be kind to them when they start to flood this channel 00:40:15 <10P​leasingFungus> i am known for my overflowing kindness 00:40:51 <10P​leasingFungus> sorry, what's "it"? 00:42:43 <02|​amethyst> building Crawl 00:43:01 <02|​amethyst> I know there was some work with that a while back 00:45:52 <10P​leasingFungus> oh, i think that's working 00:46:02 <10P​leasingFungus> at least, people were sad when i broke it earlier today 00:46:24 <10P​leasingFungus> https://github.com/crawl/crawl/commits/master see rawlins' commits from today 00:47:34 <10P​leasingFungus> https://discord.com/channels/735056636644687913/747522859361894521/810268374071509032 and the conversation starting here 00:47:48 <02|​amethyst> oh, well, that sucks, why do yall have to be on top of things 00:47:53 <10P​leasingFungus> lol 00:48:00 <10P​leasingFungus> yes, definitely not enough work to do (: 00:48:23 <10P​leasingFungus> actually those are only described as "baby steps" toward TAG_MAJOR_VERSION=35 so maybe i'm wrong about the situation. assume @advil will comment at some point 00:49:10 <10P​leasingFungus> uh, trying to make directn.cc sane would be a great code quality thing, but i'm not sure i'd point students at it 00:49:15 <10P​leasingFungus> (i do think it's much worse than beam.cc these days) 00:50:30 <10P​leasingFungus> right now monster resists are calculated in two different places - there's one that's used to get mon info and one that's used for, well, actually resisting things. this means that stuff like resists from dragon armour aren't shown on xv, which is saddening. I think unifying those two is doable 00:51:49 <02|​amethyst> maybe I'll make "break save compatibility" one of the tasks, since we're at, what, 229/256? 00:51:51 <02|​amethyst> oh cool 00:51:59 <10P​leasingFungus> someone claimed we were no longer limited on tag minor versions 00:52:02 <10P​leasingFungus> maybe 00:52:05 <10P​leasingFungus> unless i misunderstood 00:52:10 <10P​leasingFungus> possible i misunderstood 00:53:22 <10P​leasingFungus> the code for examining a square with a bunch of stuff on it (monster, item, etc) is pretty hacky - i think some people here had ideas for how it should work. it'd be nice to support examining a space with a cloud in it and always getting the option to examine that cloud, but right now iirc if there's a monster there you just examine the monster instead? 00:56:16 <10P​leasingFungus> major = unmarshallUByte(file); minor = unmarshallUByte(file); if (minor == UINT8_MAX) minor = unmarshallInt(file); i think this effectively means that TAG_MINOR has (2^8 + 2^32) possible values now? 00:57:59 -!- amalloy is now known as amalloy_ 00:59:52 <10P​leasingFungus> minor (possibly too minor?): show damage dice for orbs of destruction, ball lightning, and foxfires when you examine them (and maybe also other things that explode, like ballistomycete spores) 00:59:58 <10P​leasingFungus> (actually maybe that's a respectable project) 01:00:11 <10P​leasingFungus> (could also show it on the targeter instead of in the xv - not sure which is better) 01:02:24 <02|​amethyst> well, 2^32, since 0x01 and 0xFF<0x00000001> lead to the same runtime value 01:02:59 <10P​leasingFungus> oh, true 01:03:01 <10P​leasingFungus> yes, you're right 01:03:19 <02|​amethyst> keep in mind none of these people have seen the Crawl codebase before maybe 2 weeks ago 01:03:21 <10P​leasingFungus> sure 01:03:31 <10P​leasingFungus> which makes minor things less minor 01:03:31 <02|​amethyst> and most of them still haven't looked at it 01:03:35 <02|​amethyst> yeah 01:06:44 <10P​leasingFungus> oh, one big project i've been thinking about for a while is an in-game options editor. that's something you could work on in separate steps [not necessarily in this order]: - have an ingame struct with the set of machine-editable options (name, category, description) - add a new screen openable from the main menu - display the list of options on that screen (later: multiple tabs of options by 01:06:44 category) - load a machine-editable options file separate from the rcfile (json maybe, toml or xml could also work but we already have a json.cc) - allow changing options from the options screen - actually respect set options in-game - on conflict, prefer init.txt - display options as locked in the editor if they're set in your init.txt you'd start with bool options, then move on to int options, string options... 01:06:45 but of course within the scope of this project i'd be impressed with just getting some kind of options screen working at all, without even really interacting with the rcfile-set options in any way 01:07:01 <12e​bering> Don’t remember if this was in my list, but the ^x/xv menu is a hacked InvMenu (what PF was referring to) and it should be its own class inheriting from one of our existing Menu classes (not sure which) 01:07:08 <10P​leasingFungus> yeah that's the thing i meant 01:07:10 <10P​leasingFungus> tyty 01:09:36 <12e​bering> Oh! Make objstat and map stats output easy to combine if you run multiple runs in parallel, and either add a parallel option to the c++ or a Perl or python runner to util 01:09:50 <02|​amethyst> @PleasingFungus Yeah, in-games option editor would be awesome 01:10:43 <02|​amethyst> @ebering you seriously want me to have students look at the Makefile? 01:10:43 <10P​leasingFungus> really suspect the vast majority of players have no idea that the options exist at all and that the vast majority of our options go unused 01:10:43 <02|​amethyst> I mean, "port to CMake" is already a thing, but... 01:10:49 <10P​leasingFungus> just scrolled to a random point in options.h and found bool animate_equip_bar; // Animate colours in equip bar 01:11:02 <10P​leasingFungus> who toggles this? 01:11:28 <12e​bering> Did I suggest that in my list? Parallel objstat doesn’t require editing the make file 01:11:29 <10P​leasingFungus> oh, and that's yours, too 01:11:30 <10P​leasingFungus> relatively recent 01:11:42 <12e​bering> I toggle it! 01:12:10 <02|​amethyst> huh, never noticed that option 01:12:42 <10P​leasingFungus> it's only circa 2018 01:12:47 <02|​amethyst> @ebering CMake was on your list, yeah 01:12:58 <10P​leasingFungus> and yes, i suspect ebering added it and may be the only user 🙂 01:13:02 <02|​amethyst> I have made that a "large" task 01:13:06 <12e​bering> Oh, yeah, but that’s got a partly done PR to start from!! 01:13:18 <10P​leasingFungus> imagine how many people might use options like that if they were discoverable in-game! 01:13:23 <10P​leasingFungus> dancing equip bars everywhere 01:14:15 <02|​amethyst> hm, would 256colour support be too much for a task? 01:14:36 <02|​amethyst> Can't have brogue looking better than us 01:14:41 <10P​leasingFungus> oh, having a list of tasks like this could also be helpful for new contributors once your class is over 01:14:51 <10P​leasingFungus> think we might have a long way to go to beat brogue on looks... 🙂 01:15:26 <02|​amethyst> first we need to re-add Stalker and Fulsome Distillation 01:16:33 <02|​amethyst> !lg . won 1 01:16:33 <04C​erebot> No games for NMoore (won). 01:16:33 <10P​leasingFungus> needs a !nick 01:16:33 <02|​amethyst> !lg neil won 1 01:16:33 <04C​erebot> 1/7. Neil the Sorcerer (L27 SpSt of Kikubaaqudgha), escaped with the Orb and 3 runes on 2011-08-31 02:58:26, with 1298440 points after 120543 turns and 10:19:50. 01:16:33 <02|​amethyst> !nick neil 01:16:33 <04C​erebot> No nick mapping for neil. 01:16:33 <10P​leasingFungus> lemme look up syntax 01:16:56 <02|​amethyst> Maybe I should have students turn !lg syntax into an actual Lisp 01:17:09 <10P​leasingFungus> !nick 01:17:10 <04C​erebot> ]!nick: Maps a nick to name(s) used on the public servers. Usage: !nick ...; !nick -rm ; !nick -rm 01:17:18 <02|​amethyst> !nick NMoore neil 01:17:19 <04C​erebot> Permission nick:nmoore denied: proxying not allowed 01:17:28 <10P​leasingFungus> ircowned 01:17:57 <|amethyst> !nick NMoore neil 01:17:57 |amethyst: You have 2 messages. Use !messages to read them. 01:17:58 Mapping nmoore => neil 01:18:06 <10P​leasingFungus> oh, i bet those are great messages 01:18:51 <02|​amethyst> (1/2) |amethyst said (6w 1d 1h 36m 16s ago): Add 0.26 to CAO hopefully someone beat me to it 01:19:18 <10P​leasingFungus> think odds are good 01:19:46 <02|​amethyst> and (1/1) ebering said (1w 4d 9h 45m 40s ago): once your students settle in to projects (urgh does this collide with ferpa) could you let us know what they're up to so we don't scoop them? 01:19:49 <02|​amethyst> will do 01:20:09 <02|​amethyst> I told them, they don't have to get a patch accepted to get an A 01:21:12 <02|​amethyst> since with 50 students and teams of 4-5, there's bound to be some duplication 01:25:08 @|amethyst There's a !dcssnick command you can use to map your discord username to an account name, and it works only on the discord side 01:33:12 Weird double message upon identifying last amulet by buying it. 13https://crawl.develz.org/mantis/view.php?id=12501 by Yermak 01:34:31 Unstable branch on crawl.develz.org updated to: 0.27-a0-343-gfcad680f63 (34) 01:35:00 <02|​amethyst> !dcssnick 01:35:37 <02|​amethyst> bah 01:36:18 <02|​amethyst> yermak's bug report is probably worth a small project 01:36:59 <09g​ammafunk> !dcssnick 01:37:04 <09g​ammafunk> oh, woops 01:37:09 <09g​ammafunk> I'll have to look into that! 01:37:16 <02|​amethyst> !help dcssnick 01:37:23 <09g​ammafunk> oh 01:37:24 <09g​ammafunk> doh 01:37:31 <09g​ammafunk> cerebot is down because I was tinkering with it, sorry 01:37:52 <09g​ammafunk> !listcommands 01:37:52 <04C​erebot> Available commands: !addfaction, !addrole, !allowserver, !botdance, !bothelp, !botstatus, !dance, !dcssnick, !deal, !debugmode, !disallowserver, !firestorm, !glaciate, !glasses, !listcommands, !listfactions, !listroles, !pregen, !reactbomb, !reactstorm, !relay, !removefaction, !removemodrole, !removerole, !say, !setmodrole 01:37:55 <09g​ammafunk> should work now 01:37:58 <09g​ammafunk> !dcssnick 01:37:58 <04C​erebot> User gammafunk has dcss nick gammafunk 01:38:36 <02|​amethyst> !dcssnick 01:38:36 <04C​erebot> User NMoore has no dcss nick 01:38:51 <09g​ammafunk> no, you do 01:38:53 <02|​amethyst> !dcssnick neil 01:38:54 <04C​erebot> DCSS nick for user NMoore is set to neil 01:38:57 <09g​ammafunk> yeah that's it 01:39:51 <09g​ammafunk> obviously either approach works fine, only matters if somehow someone is using e.g. nmoore for non-discord purposes 01:39:56 <09g​ammafunk> which is probably unlikely! 01:40:18 <02|​amethyst> Maybe I should add "re-teach |amethyst how to use the bots" as one of those tasks 01:41:18 <02|​amethyst> I was hoping that having |amethyst as my alias would avoid "NMoore" being a thing, but I guess not 01:42:51 <02|​amethyst> I just got a new work laptop, but it has only USB-C (some Thunderbolt) ports 01:43:19 <02|​amethyst> so it looks like I'll need to haul around my docking station to do anything useful 01:43:46 <02|​amethyst> tempted to buy another docking station for home 01:55:12 Windows builds of master branch on crawl.develz.org updated to: 0.27-a0-343-gfcad680f63 01:55:55 <02|​amethyst> https://cdn.discordapp.com/attachments/747522859361894521/810403935935791184/4QnaZ6F.png 02:02:15 Poisonous Vapours can choose resistant enemy for its default target. 13https://crawl.develz.org/mantis/view.php?id=12502 by Yermak 02:04:47 <12e​bering> Currently 6* = fully cursed, so to get to 6* you'd have to curse the faith ammy; I guess it could be free-ish at 5*, or just work like Ru with increasing the delay on removal... creates an edge case where you wear faith until the curse is offered, remove it, curse your last slot and then don't care about the timer... 02:06:02 <10P​leasingFungus> well 02:06:09 <10P​leasingFungus> you probably want to uncurse something and curse a new thing at some point 02:06:16 <10P​leasingFungus> and it'd matter then 02:06:27 <10P​leasingFungus> swapping weapon, body armour etc 02:12:21 <02|​amethyst> Guess I need to try out new Ash 02:13:13 <12e​bering> well its not done yet! 02:13:37 <12e​bering> !pull 1736 02:13:45 <12e​bering> !pr 1736 02:13:46 <04C​erebot> https://github.com/crawl/crawl/pull/1736 02:15:11 <02|​amethyst> Some checks were not successful 02:17:36 <02|​amethyst> awesome! will add that as one of my options 02:18:02 <02|​amethyst> btw, is there anybody in Canada? 02:20:47 <12e​bering> Well, I’m working on that right now so maybe not the best plan 02:21:06 <12e​bering> Unless you don’t mind your students getting scooped 02:25:21 <02|​amethyst> Go ahead, there are still plenty of things 02:25:24 No path to Ice Cave 13https://crawl.develz.org/mantis/view.php?id=12503 by Nekoatl 02:34:12 <12e​bering> I think I miscommunicated. That PR is my current work in progress on new ash, put up for getting team feedback and running the GitHub checks, it’s not abandoned or idle! 02:46:23 Unstable branch on cbro.berotato.org updated to: 0.27-a0-343-gfcad680f63 (34) 02:53:46 Monster database of master branch on crawl.develz.org updated to: 0.27-a0-343-gfcad680f63 03:07:35 <09g​ammafunk> @|amethyst actually, you can change your discord username; does it let you change your username to |amethyst? It might; you can try from User Settings (gear wheel) -> My Account -> Edit Username 03:07:57 <09g​ammafunk> not sure if | is allowed in the username, think it is 03:08:13 <09g​ammafunk> this is a distinct thing from any per-server nickname, to be clear 03:31:01 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-3917-gc4b44ba168 03:31:48 Fork (bcadrencrawl) on crawl.kelbi.org updated to: 0.03-133-g36a636df43 04:55:20 03kate-02 07* 0.27-a0-344-gae24eb6: Fix some typos 10(49 seconds ago, 2 files, 2+ 2-) 13https://github.com/crawl/crawl/commit/ae24eb62ac7e 06:01:56 Unstable branch on crawl.kelbi.org updated to: 0.27-a0-344-gae24eb62ac (34) 06:14:43 -!- johnnyzero is now known as johnny0 09:34:34 Volrath (L27 DsFi) ASSERT(range >= 0) in 'beam.cc' at line 675 failed. (beam '', source 'player', item 'none'; has range -1) (Lair:1) 09:35:37 <12e​bering> !crashlog 09:35:38 <04C​erebot> 23367. Volrath, XL27 DsFi, T:159100 (milestone): http://crawl.akrasiac.org/rawdata/Volrath/crash-Volrath-20210214-143434.txt 09:39:41 <12e​bering> !lm Volrath DsFi begin x=vlong 09:39:41 <04C​erebot> 742. 2019-01-28 13:20:46 Volrath the Skirmisher (L1 DsFi) began the quest for the Orb on turn 0. (D:1) 09:40:02 <12e​bering> Hmmm 10:35:41 <10P​leasingFungus> i think @|amethyst was suggesting students could work on our somewhat broken CI, not on your PR? 10:35:56 <10P​leasingFungus> ^ 10:39:22 <12e​bering> oh. but our CI isn't broken 10:39:47 <12e​bering> those checks are failing because my PR doesn't successfully build after running the tag upgrade scripts 10:54:58 <10P​leasingFungus> oh, i know we had some ci issues recently 10:54:58 <10P​leasingFungus> but maybe those are resolved? 10:55:56 I think I fixed them 10:57:55 @|amethyst: I suspect there might be some good local tiles projects to be found because that is relatively neglected. One immediate (not entirely small) idea is figuring out how to implement glyphs mode for local tiles. Another includes some feature unification between local tiles <=> webtiles (either direction really). 11:00:46 fwiw I have some fairly specific plans re in-game options for 0.27 that should provide a bridge towards a larger set of in-game options and I don't know that I am going to have the energy levels to figure out how to get someone else to do this stuff the way I want 11:00:59 or to get any basics in place in time for it to be useful to them 11:01:00 I'm not sure that's inconsistent with someone working on the general problem though 11:03:25 hm a small task would be to implement @PleasingFungus' idea to highlight ally foes (I added a commit that tells you their foes); this might be a reasonable chunk because to do it you'd first look at the summoner highlighting patches and then try to do something similar to those 11:03:33 really not sure what size of task you're aiming for 11:03:59 also I suppose this will have some software dev trappings, e.g. requirements gathering and so on? 11:06:33 <10P​leasingFungus> @advil great work fixing CI! 🙂 11:06:39 <06a​dvil> >load a machine-editable options file separate from the rcfile (json maybe, toml or xml could also work but we already have a json.cc) re this, there's already a persistent rc file that is generated and read, it stores only game setup options right now 11:06:59 <10P​leasingFungus> oh neat 11:07:07 <06a​dvil> @|amethyst I'm currently in canada 12:28:43 Unstable branch on crawl.akrasiac.org updated to: 0.27-a0-344-gae24eb6 (34) 14:24:06 CMTag (L2 DrBe) Crash caused by signal #6: Aborted (D:1) 14:24:45 <12e​bering> !crashlog 14:24:46 <04C​erebot> 23369. CMTag, XL2 DrBe, T:1374 (milestone): http://crawl.akrasiac.org/rawdata/CMTag/crash-CMTag-20210214-192405.txt 14:45:59 03advil02 07* 0.27-a0-345-g7370b58: Remove an obsolete autopickup exception (12497) 10(3 minutes ago, 1 file, 0+ 3-) 13https://github.com/crawl/crawl/commit/7370b587383f 15:00:51 03PleasingFungus02 07[projected_weapon] * 0.27-a0-346-gc261a2a: New spell: Manifold Assault (L5 Translocations) 10(4 weeks ago, 14 files, 146+ 12-) 13https://github.com/crawl/crawl/commit/c261a2a12a0b 15:01:09 Branch pull/1697 updated to be equal with projected_weapon: 13https://github.com/crawl/crawl/pull/1697 15:01:56 Unstable branch on crawl.kelbi.org updated to: 0.27-a0-345-g7370b58738 (34) 15:17:00 04Build failed for 08projected_weapon @ c261a2a1 06https://github.com/crawl/crawl/actions/runs/566569796 16:42:52 -!- amalloy_ is now known as amalloy 17:08:31 New branch created: pull/1745 (1 commit) 13https://github.com/crawl/crawl/pull/1745 17:08:31 03AdamPG02 07https://github.com/crawl/crawl/pull/1745 * 0.27-a0-346-g25b3497: Make amulets of reflection actually grant monsters SH 10(7 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/25b3497b2dd1 18:23:59 Unstable branch on underhound.eu updated to: 0.27-a0-345-g7370b58738 (34) 18:56:13 <12p​atrickm> @PleasingFungus iirc, a commit went into 0.27 that gave most monsters only one set of spells, right 19:02:11 <10P​leasingFungus> @patrickm correct 19:02:18 <10P​leasingFungus> why? 19:03:19 <12p​atrickm> i was going to put a necromancer in a swamp vault but then he generated with bolt o' fire and burned down some trees, rudely imo, anyway i see in the current trunk necromancers get bolt of draining instead, so i figured it was okay to leave the necromancer in the vault definition as long as it doesn't end up in 0.26 somehow 19:03:43 !experience trains useful skills only 13https://crawl.develz.org/mantis/view.php?id=12504 by Yermak 19:05:59 <10P​leasingFungus> seems reasonable 21:20:30 <12p​atrickm> another q: what file specifies which monsters will naturally generate in a given branch 22:07:24 ziggurnaut (L4 DrFE) Crash caused by signal #6: Aborted (D:3) 22:17:04 <10P​leasingFungus> mon-pick-data.h 22:17:35 <12p​atrickm> danke! 22:25:40 <10P​leasingFungus> @|amethyst iirc you managed to get back into crawlcode? I feel like this is worth a tweet somehow: // This if statement is temporary, it should be removed when the // implementation of a more universal (and elegant) to-hit calculation // is designed. 90ccf509eb5 -- April 11, 2011 22:37:53 Extremely poor performance when band leader teleports on disjoint level 13https://crawl.develz.org/mantis/view.php?id=12505 by damerell 22:45:38 03PleasingFungus02 07* 0.27-a0-346-ga689d4a: Restore old Fedhas piety message 10(4 minutes ago, 1 file, 17+ 1-) 13https://github.com/crawl/crawl/commit/a689d4a61310 23:02:29 Unstable branch on crawl.kelbi.org updated to: 0.27-a0-346-ga689d4a613 (34)