00:11:42 <Cheibriados> 03|amethyst02 07* 0.27-a0-13-g87abb2d: Add a quote (that will rarely be seen) 10(78 seconds ago, 1 file, 13+ 0-) 13https://github.com/crawl/crawl/commit/87abb2d9eb41
00:13:08 <Discord|> <09g​ammafunk> >remove the water
00:13:16 <|amethyst> !remove
00:13:17 <Sequell> 03|amethyst ⛐ 0.26-a0-2044-g40f7322: Remove 10(in the future, 8 files, 602+ 414-) 13http://s-z.org/neil/git/commit.png?p=crawl.git;a=commitdiff;h=40f7322
00:13:25 <|amethyst> !remove water
00:13:26 <Sequell> 03|amethyst ⛐ 0.26-a0-2045-g9502bb6: Remove water 10(in the future, 26 files, 293+ 441-) 13http://s-z.org/neil/git/commit.png?p=crawl.git;a=commitdiff;h=9502bb6
00:13:42 <Discord|> <09g​ammafunk> Music to my ears
00:17:04 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.27-a0-13-g87abb2d9eb (34)
00:24:04 -!- amalloy_ is now known as amalloy
01:26:49 <ebering> |amethyst: cool!
01:26:49 <Sequell> ebering: You have 1 message. Use !messages to read it.
01:29:24 <ebering> |amethyst: if you're still about some c++ feedback on los-hex-success-chance would be appreciated
01:30:32 <ebering> in particular: the correct behavior of the targeter classes added in 8505477 relies on virtual member resolution in a constructor which I have memories of being a possible pain point/bad style
01:30:35 <ebering> %git 8505477
01:30:36 <Cheibriados> 07ebering02 * 0.27-a0-8-g8505477: Add detailed static targeters for LOS enchantments 10(7 hours ago, 4 files, 188+ 18-) 13https://github.com/crawl/crawl/commit/850547751e41
01:34:30 <Gretell> Unstable branch on crawl.develz.org updated to: 0.27-a0-13-g87abb2d9eb (34)
01:54:44 <Gretell> Windows builds of master branch on crawl.develz.org updated to: 0.27-a0-13-g87abb2d9eb
02:27:00 <Cbrotell> Unstable branch on cbro.berotato.org updated to: 0.27-a0-13-g87abb2d9eb (34)
02:53:40 <Gretell> Monster database of master branch on crawl.develz.org updated to: 0.27-a0-13-g87abb2d9eb
03:31:46 <Kelbell> Stable (0.26) branch on crawl.kelbi.org updated to: 0.26-b1-13-gc21e7409c4
03:32:58 <Kelbell> Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-3840-g9efd504fd6
03:49:10 <Kelbell> Fork (bcadrencrawl) on crawl.kelbi.org updated to: 0.03-82-gebaf79d81a
04:06:23 <Cheibriados> 03ebering02 07* 0.27-a0-14-g0db6f62: Rename a function for clarity 10(10 hours ago, 3 files, 6+ 6-) 13https://github.com/crawl/crawl/commit/0db6f627e19a
04:06:23 <Cheibriados> 03ebering02 07* 0.27-a0-15-g464169c: Refactor targeter_multiposition 10(10 hours ago, 3 files, 50+ 29-) 13https://github.com/crawl/crawl/commit/464169c878e3
04:06:23 <Cheibriados> 03ebering02 07* 0.27-a0-16-g1589ab1: Fix a targeting information leak in Absolute Zero (12415) 10(10 hours ago, 1 file, 9+ 6-) 13https://github.com/crawl/crawl/commit/1589ab133590
04:06:23 <Cheibriados> 03ebering02 07* 0.27-a0-17-gcc8eda8: Adjust Metabolic Englaciation 10(10 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/cc8eda8a4292
04:06:23 <Cheibriados> 03ebering02 07* 0.27-a0-18-g0242afd: Add detailed static targeters for LOS enchantments 10(10 hours ago, 4 files, 188+ 18-) 13https://github.com/crawl/crawl/commit/0242afd26bf9
04:06:23 <Cheibriados> 03ebering02 07* 0.27-a0-19-g3d81cda: Allow static-targeter preview of Confusing Touch 10(9 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/3d81cda75063
04:09:11 <Discord|> <12e​bering> after some poking and asking a friend I think this is ok enough. there's probably a better factorization of targeter_multiposition to avoid the virtual call in the constructor but eh
04:09:57 <Cheibriados> 03ebering02 07[stone_soup-0.26] * 0.26-b1-14-g09d327a: Rename a function for clarity 10(10 hours ago, 3 files, 6+ 6-) 13https://github.com/crawl/crawl/commit/09d327adaaa5
04:09:57 <Cheibriados> 03ebering02 07[stone_soup-0.26] * 0.26-b1-15-gb3e9228: Refactor targeter_multiposition 10(10 hours ago, 3 files, 50+ 29-) 13https://github.com/crawl/crawl/commit/b3e9228883bc
04:09:57 <Cheibriados> 03ebering02 07[stone_soup-0.26] * 0.26-b1-16-g6b3fd58: Fix a targeting information leak in Absolute Zero (12415) 10(10 hours ago, 1 file, 9+ 6-) 13https://github.com/crawl/crawl/commit/6b3fd5836164
04:09:57 <Cheibriados> 03ebering02 07[stone_soup-0.26] * 0.26-b1-17-gd561ae3: Adjust Metabolic Englaciation 10(10 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/d561ae363d1c
04:09:57 <Cheibriados> 03ebering02 07[stone_soup-0.26] * 0.26-b1-18-gcd786c9: Add detailed static targeters for LOS enchantments 10(10 hours ago, 4 files, 188+ 18-) 13https://github.com/crawl/crawl/commit/cd786c968f1b
04:09:57 <Cheibriados> 03ebering02 07[stone_soup-0.26] * 0.26-b1-19-g163dfa5: Allow static-targeter preview of Confusing Touch 10(9 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/163dfa592d85
05:46:48 -!- amalloy is now known as amalloy_
06:15:19 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.27-a0-19-g3d81cda750 (34)
08:16:07 <Cheibriados> 03ebering02 07* 0.27-a0-20-gc93d6a9: Re-refactor targeter_multiposition 10(2 hours ago, 3 files, 166+ 185-) 13https://github.com/crawl/crawl/commit/c93d6a9b7e9b
08:16:07 <Cheibriados> 03ebering02 07* 0.27-a0-21-g7e5a9cb: Add a static targeter for ignite poison 10(17 minutes ago, 5 files, 33+ 1-) 13https://github.com/crawl/crawl/commit/7e5a9cbe55bf
08:16:07 <Cheibriados> 03ebering02 07* 0.27-a0-22-gc911466: Describe dazzle chance in the Dazzling Flash targeter 10(59 seconds ago, 1 file, 12+ 0-) 13https://github.com/crawl/crawl/commit/c91146610e51
08:16:07 <Cheibriados> 03ebering02 07* 0.27-a0-23-g63decd6: Clarify a prompt message 10(35 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/63decd6869a8
08:19:20 <Cheibriados> 03ebering02 07[stone_soup-0.26] * 0.26-b1-20-g6fcc3bb: Re-refactor targeter_multiposition 10(2 hours ago, 3 files, 166+ 185-) 13https://github.com/crawl/crawl/commit/6fcc3bb8dd02
08:19:20 <Cheibriados> 03ebering02 07[stone_soup-0.26] * 0.26-b1-21-g1a46945: Add a static targeter for ignite poison 10(20 minutes ago, 5 files, 33+ 1-) 13https://github.com/crawl/crawl/commit/1a46945f8169
08:19:20 <Cheibriados> 03ebering02 07[stone_soup-0.26] * 0.26-b1-22-g1c2d5d2: Describe dazzle chance in the Dazzling Flash targeter 10(4 minutes ago, 1 file, 12+ 0-) 13https://github.com/crawl/crawl/commit/1c2d5d26f943
08:19:20 <Cheibriados> 03ebering02 07[stone_soup-0.26] * 0.26-b1-23-g9dd7f3d: Clarify a prompt message 10(4 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/9dd7f3db273b
08:37:57 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.27-a0-23-g63decd6869 (34)
09:28:47 <Cheibriados> 03ebering02 07* 0.27-a0-24-g086eb55: Tone down Ignite Poison's effect on bog 10(31 minutes ago, 1 file, 6+ 2-) 13https://github.com/crawl/crawl/commit/086eb55de836
09:28:47 <Cheibriados> 03ebering02 07* 0.27-a0-25-g087482e: Don't perform a range check for Noxious Bog 10(2 minutes ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/087482e4d503
09:28:53 <Cheibriados> 03ebering02 07[stone_soup-0.26] * 0.26-b1-24-g7f20a2a: Tone down Ignite Poison's effect on bog 10(31 minutes ago, 1 file, 6+ 2-) 13https://github.com/crawl/crawl/commit/7f20a2a1ef70
09:28:53 <Cheibriados> 03ebering02 07[stone_soup-0.26] * 0.26-b1-25-gafae2e7: Don't perform a range check for Noxious Bog 10(2 minutes ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/afae2e710bd3
09:32:10 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.27-a0-25-g087482e4d5 (34)
09:58:50 -!- ProzacElf_ is now known as ProzacElf
10:08:43 <Cbrotell> Stable (0.26) branch on cbro.berotato.org updated to: 0.26-b1-25-gafae2e710b
10:48:24 <ZureaL> @advil you around?
11:19:16 <Lantell> Unstable branch on underhound.eu updated to: 0.27-a0-25-g087482e4d5 (34)
11:55:35 <Discord|> <03w​heals> @ebering am i missing something or do the last line of 086eb55's commit message and the code itself disagree
12:06:10 <Discord|> <12e​bering> They do indeed disagree. Oops
12:06:40 <Discord|> <12e​bering> The one in three was the starting place but I tinkered with it
12:27:47 <Henzell> Unstable branch on crawl.akrasiac.org updated to: 0.27-a0-25-g087482e (34)
13:35:48 -!- krator44-- is now known as krator44
13:45:37 -!- amalloy_ is now known as amalloy
13:52:28 <Cheibriados> 03krator4402 07https://github.com/crawl/crawl/pull/1668 * 0.16.3-14-g8913625: add random name generator 10(2 minutes ago, 1 file, 30+ 3-) 13https://github.com/crawl/crawl/commit/8913625f4337
14:44:01 <Cheibriados> 03krator4402 07https://github.com/crawl/crawl/pull/1668 * 0.16.3-15-ga13dc86: add overview map describe 10(5 minutes ago, 4 files, 14+ 0-) 13https://github.com/crawl/crawl/commit/a13dc86684e0
17:16:55 <|amethyst> ebering:  the rule is that calling a virtual function in a constructor calls that class's version, but no deeper in the inheritance hierarchy
17:19:03 <|amethyst> ebering:  which might be a problem considering that the class you inherit from does call affects_monster from its own constructor
17:20:24 <|amethyst> ebering:  I see that you're getting around that by repeating the work in your own constructor
17:21:48 <|amethyst> ebering:  but it seems like you'd be adding too many things
17:25:10 <|amethyst> ebering:  i.e. targeter_multiposition's constructor fires, adds things based on its own affects_monster, then your constructor fires and adds things based on *its* override of the method
17:29:28 <|amethyst> ebering:  probably the solution would be to defer that work until something acctually needs affected_positions
17:30:34 <Discord|> <12e​bering> %git :/Re-refactor
17:30:35 <Discord|> <04C​erebot> ebering * 0.26-b1-20-g6fcc3bb: Re-refactor targeter_multiposition (11 hours ago, 3 files, 166+ 185-) https://github.com/crawl/crawl/commit/6fcc3bb8dd02
17:30:39 <|amethyst> ebering:  which you could do e.g. by having (in targeter_multiposition) a protected or private method that 1) initializes affected_positions if necessary  2) returns it (by reference)
17:31:07 <|amethyst> ebering:  and then using that everywhere that uses affected_positions except add_position
17:32:21 <Discord|> <12e​bering> I just split the class, multimonster and multiposition targeting look similar but have different purposes
17:34:15 <|amethyst> ebering: ah, I see, and targeter_multimonster doesn't do the iteration in its cto
17:34:18 <|amethyst> r
17:38:41 <Discord|> <12e​bering> yep
17:39:08 <|amethyst> ebering:  this might still be an issue if, e.g., someone inherits from targeter_drain_life
17:39:27 <|amethyst> ebering:  might be good to mark those classes as final
18:07:08 <advil> hm not sure I see why the abszero change needs to do all the checks on whether it's a tracer
18:10:39 <advil> fwiw I do think those targeter changes, while good, are extremely high-feature-content for a feature freeze
18:19:46 <Cheibriados> 03advil02 07* 0.27-a0-26-g91735a3: Improve tremorstone + summons warning checks (12409) 10(4 minutes ago, 3 files, 22+ 7-) 13https://github.com/crawl/crawl/commit/91735a3152ac
18:25:09 <dcss-ci> 04Build failed for 08master @ 91735a31 06https://github.com/crawl/crawl/actions/runs/458340939
18:26:04 <advil> hm looks like something didn't get committed
18:26:42 <Cheibriados> 03advil02 07* 0.27-a0-27-g105bc0f: Revert "Improve tremorstone + summons warning checks (12409)" 10(21 seconds ago, 3 files, 7+ 22-) 13https://github.com/crawl/crawl/commit/105bc0f7bc05
18:32:00 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.27-a0-27-g105bc0f7bc (34)
18:51:50 <advil> where do butterflies happen these days? is it just xom + a few vaults?
19:24:31 <kate-> pretty sure it's just those, yeah
20:44:47 <Cheibriados> 03advil02 07* 0.27-a0-28-g0579ed4: Fix a butterfly+charge+quiver interaction (12410) 10(27 minutes ago, 4 files, 35+ 13-) 13https://github.com/crawl/crawl/commit/0579ed41f9d6
20:44:47 <Cheibriados> 03advil02 07* 0.27-a0-29-g2d0a239: Improve tremorstone + summons warning checks (12409) 10(21 minutes ago, 3 files, 22+ 7-) 13https://github.com/crawl/crawl/commit/2d0a2396b0bb
21:02:50 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.27-a0-29-g2d0a2396b0 (34)
21:44:32 -!- aidanh_ is now known as aidanh
21:44:34 -!- TAS-2012v is now known as TAS_2012v