01:53:17 Windows builds of master branch on crawl.develz.org updated to: 0.26-a0-952-g76694b35de 02:44:55 Unstable branch on cbro.berotato.org updated to: 0.26-a0-952-g76694b35de (34) 02:53:01 Monster database of master branch on crawl.develz.org updated to: 0.26-a0-952-g76694b35de 02:57:40 advil: did that get fixed? I'm not getting a warning any more 03:30:51 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-3725-gae5fce40d8 04:41:25 Autofight throws in malee range 13https://crawl.develz.org/mantis/view.php?id=12392 by jejorda2 04:52:41 Unexpected quiver behavior 13https://crawl.develz.org/mantis/view.php?id=12393 by jejorda2 11:00:39 gammafunk yeah it got fixed very quickly, johnstein just needed to do something with DNS 11:41:14 <10PleasingFungus> assuming that there's no multithreading going on here (which seems fairly safe as assumptions go, thank goodness), you.pending_revival must have been set to false in between these calls, or there's something strange and recursive going on here 11:41:27 <10PleasingFungus> (continuing conversation from other discord about a double felid death due to inner flame) 11:41:38 <06advil> pretty sure there's no multithreading 😄 11:41:51 <10PleasingFungus> we do have multithreading in the ui code iirc 11:41:54 <10PleasingFungus> but maybe only in local tiles 11:41:59 <10PleasingFungus> anyway, not the point 11:42:03 <06advil> I think I removed that 11:42:06 <10PleasingFungus> oh good 11:42:06 <06advil> it was just for loading in data 11:42:53 <10PleasingFungus> re recursion: imagine ouch() is called due to an inner flame explosion, and then some call from that ouch causes another inner flame explosion to trigger, triggering a second ouch and the first death 11:43:12 <10PleasingFungus> in that way, you could bypass the you.pending_revival check at the top of the function 11:43:24 <06advil> oh, yeah that makes sense 11:43:29 <10PleasingFungus> the alternative is that you.pending_revival is being set to false in a weird way 11:43:41 <10PleasingFungus> that seems easier to check, so i'm gonna look around real fast 11:43:47 <10PleasingFungus> (note that i can't trivially repro this, btw) 11:43:49 <10PleasingFungus> (tried earlier) 11:44:47 <06advil> looks like that can only get done in revive() or when resetting you 11:44:52 <10PleasingFungus> yeah (in tags.cc or in player.cc) 11:45:02 <10PleasingFungus> let's tentatively rule that out. 11:45:22 <10PleasingFungus> ouch.cc is several hundred lines long. hopefully we can find something in there 11:47:14 <06advil> I can try to reproduce it in a minute 11:47:35 <10PleasingFungus> The wight explodes! The white ugly thing explodes! The fiery explosion engulfs you!! You die... The fiery explosion engulfs you! * * * LOW HITPOINT WARNING * * * You die... _You are engulfed in blazing flames. You are now level 14! reposting for reference 11:47:45 <10PleasingFungus> the low hitpoint warning here is important, actually 11:48:17 <10PleasingFungus> that shows up on line 986 of ouch.cc, and it only triggers if you.hp > 0 11:48:21 <06advil> huh 11:48:23 <09gammafunk> cpp // Okay, so you're dead. take_note(Note(NOTE_DEATH, you.hp, you.hp_max, se.death_description(scorefile_entry::DDV_NORMAL).c_str()), true); if (you.lives && !non_death) { mark_milestone("death", lowercase_first(se.long_kill_message()).c_str()); you.deaths++; you.lives--; you.pending_revival = true; ... 11:48:23 canned_msg(MSG_YOU_DIE); ... 11:48:34 ok, sorry, was just curious 11:48:38 <10PleasingFungus> that seems to rule out my recursion theory 11:49:24 <06advil> well, the messaging sequence definitely looks like recursion, I take it you tried to replicate that? 11:50:26 <10PleasingFungus> because presumably if we were just returning to an earlier ouch() call after dying, our hp would be 0 or less, and we would not print * * * LOW HITPOINT WARNING * * * before the second death (first/upper call) 11:50:26 <10PleasingFungus> hm, wonder how this reply works across the bridge 11:50:26 <10PleasingFungus> anyway what i tried to replicate was having a bunch of 1 hp inner flamed guys around a felid with 1 hp and 2 lives 11:50:26 it worked 11:51:01 <10PleasingFungus> geekosaur: looks like the bridge just doesn't display the 'reply' at all, actually 11:51:16 <10PleasingFungus> https://cdn.discordapp.com/attachments/747522859361894521/782649895936065536/unknown.png 11:51:21 hm. possible; I was looking for mangling 11:51:29 <10PleasingFungus> plenty of mangling to go around 🙂 11:52:49 "how this reply" worked, so did the message before it ("looks like recursion") 11:53:03 unless that was c&p from irc and the message in question is missing there too 11:53:31 <10PleasingFungus> did you look at the image i sent? 11:53:42 <10PleasingFungus> you should be able to open it without being in discord 11:53:44 yeah, replies just show the message but not the reply context 11:54:14 not a lot the bridge could do, I guess, save possibly display the reply like a typical irc reply-ping 11:54:28 i.e. automatically prefix Pf's message with "advil: " 11:54:30 oh, I thought the image was a user icon. (not a discord user_ 11:54:50 <10PleasingFungus> anyway, i'm even more confused after looking at this again. that * * * LOW HITPOINT WARNING * * * is very weird 11:55:23 <10PleasingFungus> it is not supposed to print if you would die from the damage (since it's quite pointless then) 11:56:29 <10PleasingFungus> that sort of implies three ouch calls: - first one kills the player. (then somehow the player gains hp and goes back up above 0?) - second one prints LOW HITPOINT WARNING but doesn't kill the player. - third one kills the player again. 11:56:52 03advil02 07* 0.26-a0-953-gf18ecd8: Support backslash notation in rc keybinds 10(2 minutes ago, 3 files, 13+ 1-) 13https://github.com/crawl/crawl/commit/f18ecd8a5bf0 11:57:21 <10PleasingFungus> does that make sense? idk 11:57:21 <10PleasingFungus> i might be adding epicycles 11:57:49 03PleasingFungus02 07* 0.26-a0-954-g1642dc5: Make evokable invisibility drain skills 10(57 minutes ago, 1 file, 8+ 2-) 13https://github.com/crawl/crawl/commit/1642dc555393 11:57:49 03PleasingFungus02 07* 0.26-a0-955-gf919d8e: Adjust worldbinder Swamp set (12391) 10(43 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/f919d8e91079 11:57:49 03PleasingFungus02 07* 0.26-a0-956-gf9a3951: Shift nrook's guardian serpents deeper 10(35 minutes ago, 2 files, 3+ 3-) 13https://github.com/crawl/crawl/commit/f9a395181680 11:58:26 that sequence is just weird, yes 11:58:38 <06advil> I wonder if replicating it depends on the positioning (impacting order in an iterator) 11:58:46 <10PleasingFungus> isn't that randomized? 11:58:58 <06advil> it might be, depends on the iterator 12:00:40 <06advil> distance_iterator supports randomization (on by default) but I don't think radius_iterator or regular adjacent_iterator do 12:00:58 <06advil> but anyways, then the positioning won't matter but the randomly chosen order will 12:02:01 <10PleasingFungus> i ran through it a bunch of times with different directions, surrounding myself with exploding orcs 12:02:05 <10PleasingFungus> cant 12:06:11 Unstable branch on crawl.kelbi.org updated to: 0.26-a0-956-gf9a3951816 (34) 12:10:26 <06advil> !lm dinky death 12:10:28 <04Cerebot> 28. [2020-11-29 13:11:24] dinky the Bewitcher (L19 FeCj of Vehumet) blasted by a smoke demon (divine providence) (Abyss:2) 12:10:37 <06advil> !lm dinky death x=hp 12:10:38 <04Cerebot> 28. 2020-11-29 13:11:24 dinky the Bewitcher (L19 FeCj of Vehumet) blasted by a smoke demon (divine providence) (Abyss:2) 12:10:49 <06advil> !lm dinky death x=hp -2 12:10:50 <04Cerebot> 27/28. 2020-11-29 10:03:41 dinky the Bewitcher (L15 FeCj of Vehumet) blasted by a white ugly thing (exploding inner flame) (D:14) 12:11:10 <06advil> !lm dinky death x=hp -3 12:11:11 <04Cerebot> 26/28. 2020-11-22 01:45:04 dinky the Frost Mage (L11 FeIE of Makhleb) blasted by Fannar (bolt of cold) (Lair:1) 12:14:30 <10PleasingFungus> hrm 12:16:07 L15? 12:16:48 <10PleasingFungus> what's the question? 12:17:56 <06advil> (there's only one milestone in the raw file too) 12:18:06 never mind, I misunderstood 12:20:51 <10PleasingFungus> it's not lair:15 yeah 12:20:51 <10PleasingFungus> that'd be powerful tho 12:20:54 <10PleasingFungus> imagine the xp... 12:22:08 no, that was xl. I missed there was a death milestone per death for felids, not just one for the final death 12:27:32 Unstable branch on crawl.akrasiac.org updated to: 0.26-a0-956-gf9a3951 (34) 12:27:36 <06advil> well, I haven't replicated what happened to dinky but when I tried the basic test with orcs I appear to have locked up the crawl process 12:28:09 <10PleasingFungus> huh 12:28:16 <10PleasingFungus> that's surprising 12:28:39 <06advil> were you doing this with a wizmode char? It might be related to the "really die" prompt 12:29:56 <06advil> the game loaded up correctly at least 12:31:26 <06advil> is there a way to manually give yourself lives? 12:32:07 <06advil> besides increasing xl 12:35:08 <06advil> this freezing behavior replicates reliably on my build, but even setting that aside I suspect that it could be something about wizmode that is interfering with replicating this; when I used ctrl-y mode it still locked up but it showed the Die? prompt twice 12:36:59 <10PleasingFungus> i was in full debug / wizmode, yeah 12:45:05 <06advil> I haven't replicated this but I think I know what is happening 12:51:26 sahdkjhfkaj (L27 OpAr) ERROR: range check error (20 / 20) (D (Sprint)) 12:54:40 good account name 13:06:15 <06advil> my ideas remain entirely theoretical 13:06:24 <06advil> pasting this here so I don't keep losing it: https://discord.com/channels/205277826788622337/205316046230388737/782547448270684180 13:16:33 Game crashes when using fsim 13https://crawl.develz.org/mantis/view.php?id=12394 by quik 13:27:46 03advil02 07* 0.26-a0-957-g201e65f: Improve flavor of explosions after death 10(33 seconds ago, 1 file, 4+ 2-) 13https://github.com/crawl/crawl/commit/201e65fd4974 13:28:36 <06advil> (I do not know what is happening) 13:32:09 Unstable branch on crawl.kelbi.org updated to: 0.26-a0-957-g201e65fd49 (34) 14:49:31 <06advil> I sort of have the feeling that if I could get this message order: The wight explodes! The white ugly thing explodes! The fiery explosion engulfs you!! i.e. where the two explodes messages are before the engulf messages, I might be getting somewhere, but I can't figure out how that would happen (I always get explodes, engulfs, explodes, engulfs) 14:49:47 <06advil> also, it seems relevant that he started things off by casting IMB (not that that has helped me 15:06:23 03advil02 07* 0.26-a0-958-gf3041fb: Show quiver for felids in webtiles 10(26 seconds ago, 1 file, 0+ 4-) 13https://github.com/crawl/crawl/commit/f3041fb45f7b 15:17:08 Unstable branch on crawl.kelbi.org updated to: 0.26-a0-958-gf3041fb45f (34) 15:23:13 03advil02 07[stone_soup-0.25] * 0.25.1-5-ga974f4b: Don't let browser eat shift-tab in webtiles 10(3 months ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/a974f4ba7dd5 15:23:13 03advil02 07[stone_soup-0.25] * 0.25.1-6-g66c6192: Support backslash notation in rc keybinds 10(3 hours ago, 3 files, 13+ 1-) 13https://github.com/crawl/crawl/commit/66c61928b3d2 15:25:44 Build failed for stone_soup-0.25 @ 66c61928 https://github.com/crawl/crawl/actions/runs/390350512 (failed: Linux Build,MacOS Build,Linux MingW Build,Catch2/codecov) 16:40:51 03advil02 07[stone_soup-0.25] * 0.25.1-7-g6c89e70: Update github actions from master 10(39 seconds ago, 2 files, 86+ 126-) 13https://github.com/crawl/crawl/commit/6c89e70221d0 16:57:29 04Build failed for 08stone_soup-0.25 @ 6c89e702 06https://github.com/crawl/crawl/actions/runs/390423809 16:59:10 03advil02 07[stone_soup-0.25] * 0.25.1-8-g42b30a8: Attempt to fix contrib zlib on mac gha builds 10(4 weeks ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/42b30a86e79c 18:24:14 Unstable branch on underhound.eu updated to: 0.26-a0-958-gf3041fb45f (34) 20:22:50 Stable (0.25) branch on underhound.eu updated to: 0.25.1-8-g42b30a86e7 21:07:41 03nikheizen02 07https://github.com/crawl/crawl/pull/1610 * 0.26-a0-959-g4634e15: Add 7 altar vaults 10(3 weeks ago, 2 files, 179+ 0-) 13https://github.com/crawl/crawl/commit/4634e15a3269 21:07:41 03nikheizen02 07https://github.com/crawl/crawl/pull/1610 * 0.26-a0-960-g65b01f5: Add two vaults based off of Greek Myth (Silurio) 10(2 weeks ago, 1 file, 25+ 2-) 13https://github.com/crawl/crawl/commit/65b01f5a6d6b 21:07:41 03nikheizen02 07https://github.com/crawl/crawl/pull/1610 * 0.26-a0-961-ga047b57: Winding Woodlands: forest-themed subvault maps 10(2 weeks ago, 1 file, 976+ 0-) 13https://github.com/crawl/crawl/commit/a047b57459f5 23:05:45 -!- Tuxedo[Qyou] is now known as your_life 23:05:49 -!- your_life is now known as Tux[Qyou] 23:23:24 -!- misha is now known as werekitten