01:54:15 <Gretell> Windows builds of master branch on crawl.develz.org updated to: 0.26-a0-752-gcff87cac9a
02:45:21 <Cbrotell> Unstable branch on cbro.berotato.org updated to: 0.26-a0-752-gcff87cac9a (34)
02:53:39 <Gretell> Monster database of master branch on crawl.develz.org updated to: 0.26-a0-752-gcff87cac9a
03:31:03 <Kelbell> Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-3624-ge566ea1ced
03:46:54 <Kelbell> Fork (bcadrencrawl) on crawl.kelbi.org updated to: 0.22.1-3102-g49c0823232
03:50:29 <Cheibriados> Function declared but never defined or used 13https://crawl.develz.org/mantis/view.php?id=12379 by bcadren
04:27:16 -!- amalloy is now known as amalloy_
10:36:18 <Cheibriados> 03PleasingFungus02 07* 0.26-a0-753-g4680b4f: util/monster brand fixes 10(42 seconds ago, 1 file, 2+ 1-) 13https://github.com/crawl/crawl/commit/4680b4fa2ed0
10:46:58 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.26-a0-753-g4680b4fa2e (34)
12:29:09 <Henzell> Unstable branch on crawl.akrasiac.org updated to: 0.26-a0-753-g4680b4f (34)
12:54:32 <Lantell> thethe (L12 DrCj) Crash caused by signal #6: Aborted (Lair:4)
18:23:10 <Lantell> Unstable branch on underhound.eu updated to: 0.26-a0-753-g4680b4fa2e (34)
19:15:12 -!- Euph0ria is now known as FelixUnger
19:19:24 -!- FelixUnger is now known as Quincy
19:48:16 <advil> how do people feel about disconnected areas with only an escape hatch out
19:48:41 <advil> which are actually possible (this was surprising to me)
19:56:44 <advil> in fact it's entirely possible the changes I've been making will make these more likely, because levels where this happens often have zone issues that are checked first and I have been fixed
19:57:12 <advil> *been fixing
20:18:29 <Cheibriados> 03PleasingFungus02 07* 0.26-a0-754-g6ee9613: Despoiler /poly (gammafunk) 10(7 minutes ago, 12 files, 198+ 38-) 13https://github.com/crawl/crawl/commit/6ee961360c27
20:18:29 <Cheibriados> 03PleasingFungus02 07* 0.26-a0-755-g9e3f510: Remove devouring swarms (again) 10(19 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/9e3f51019967
20:24:46 -!- amalloy_ is now known as amalloy
20:46:17 -!- amalloy is now known as amalloy_
20:49:15 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.26-a0-755-g9e3f510199 (34)
20:49:16 <advil> ah, the power of props
20:56:54 <advil> I may be missing something but you may want to revalidate stuff about the monster type (minimally that it hasn't been removed, previously checked in _initialise_randmons) at the point where it gets used
20:57:16 <advil> %git fc2450931f7d19
20:57:16 <Cheibriados> 07gammafunk02 * 0.26-a0-656-gfc24509: Remove some boring beasts 10(6 weeks ago, 40 files, 133+ 267-) 13https://github.com/crawl/crawl/commit/fc2450931f7d
20:58:17 <advil> otherwise a commit like this will interact with poly in fun and exciting ways (I think, just reading the code)
21:05:00 <advil> also possibly monster_inherently_flies and monster_class_flies should share some code with monster::airborne?
21:05:11 <Discord|> <10P​leasingFungus> i thought i did make those share code
21:05:13 <Discord|> <10P​leasingFungus> did i forget
21:05:24 <advil> oh oops
21:05:27 <advil> you did, I missed it
21:05:36 <Discord|> <10P​leasingFungus> sweet
21:06:41 <Discord|> <10P​leasingFungus> possibly i should make the actual polymorph check to see if the chosen monster can live in the chosen habitat, and make the poly fail if not?
21:06:50 <Discord|> <10P​leasingFungus> i feel like i probably should, but also i'm very lazy
21:07:09 <advil> I was wondering about that but I couldn't think of any cases that wouldn't be covered by class-level checks
21:07:15 <Discord|> <10P​leasingFungus> oh, i can
21:07:27 <advil> the previous poly code had like 3 different checks for that so I guess it was an issue
21:07:34 <Discord|> <10P​leasingFungus> imagine that you polymorph a human wearing an ARTP_FLY ring into a pig while it's over deep water
21:07:59 <advil> ah, fair
21:08:28 <Discord|> <10P​leasingFungus> on the other hand
21:08:34 <Discord|> <10P​leasingFungus> hm
21:09:31 <Discord|> <10P​leasingFungus> no, i think that would be banned before (a bit over-aggressively, i think - similarly polymorphing a human into an orc would be banned there, even though it'd still be flying)
21:09:48 <Discord|> <10P​leasingFungus> anyway i'm more interested in the thing you were mentioning about revalidating the monster type
21:09:51 <Discord|> <10P​leasingFungus> that's in tags.cc?
21:10:12 <advil> I meant when choosing the type at the point of polymorph
21:10:45 <Discord|> <10P​leasingFungus> oh
21:10:57 <Discord|> <10P​leasingFungus> oh, that a polymorph target has been removed
21:11:02 <advil> yeah, exactly
21:11:05 <Discord|> <10P​leasingFungus> neat
21:11:10 <advil> e.g. that commit I linked to removed porcupines
21:11:16 <advil> (I think)
21:11:43 <Discord|> <10P​leasingFungus> i guess you need a getter method that checks for removed monsters and regenerates the poly set if there are any
21:11:57 <advil> heh I was just imagining skipping them
21:12:06 <advil> but I guess there are only 3
21:12:44 <Discord|> <10P​leasingFungus> my first thought was skipping, yeah, but it seems cleaner to just regenerate
21:13:00 <Discord|> <10P​leasingFungus> sometimes there's less than three! if you try to poly seraph, you always get pearl dragon
21:13:08 <Discord|> <10P​leasingFungus> polying mangrove always turns into thorn hunter, i think?
21:13:13 <Discord|> <10P​leasingFungus> or maybe vice versa
21:13:28 <advil> I wasn't actually sure why the poly targets are generated at placement time? I know there was some discussion about seeding
21:14:00 <Discord|> <10P​leasingFungus> well, what's the alternative?
21:14:09 <Discord|> <10P​leasingFungus> i initially had them generated at time of polymorph, but you also need them in the mon-info for targeters
21:14:19 <advil> run init_poly_set if that prop is missing the first time it is needed
21:14:30 <Discord|> <10P​leasingFungus> so you'd need to generate them whenever you get a mon-info for something that doesn't yet have the poly set
21:15:08 <Discord|> <10P​leasingFungus> which is fairly close to just generation time
21:15:11 <advil> only for targeting with a poly want, right?
21:15:20 <Discord|> <10P​leasingFungus> well, how do you know that before you get the mon-info?
21:18:41 <Kelbell> slep (L11 DsGl) ASSERT(mons->props.exists(POLY_SET_KEY)) in 'mon-poly.cc' at line 512 failed. (Abyss:2)
21:18:48 <Discord|> <10P​leasingFungus> oops
21:18:57 <Discord|> <10P​leasingFungus> welp
21:20:03 <advil> rip
21:20:11 <Cheibriados> 03PleasingFungus02 07* 0.26-a0-756-g10fd84b: Remove a dubious assert 10(13 seconds ago, 1 file, 2+ 1-) 13https://github.com/crawl/crawl/commit/10fd84bd020c
21:20:40 <advil> it looks like the prop will only be used to generate a description from your_spells when casting polymorph?
21:20:55 <Discord|> <10P​leasingFungus> sure, it's only used when shooting a poly beam somewhere
21:27:04 <Kelbell> Silurio (L8 GnWn) ASSERT(mons->props.exists(POLY_SET_KEY)) in 'mon-poly.cc' at line 512 failed. (D:5)
21:32:29 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.26-a0-756-g10fd84bd02 (34)
22:17:26 <Discord|> <10P​leasingFungus> http://crawl.develz.org/wordpress/trunk-updates-6-november-2020
22:25:32 -!- Psymania_ is now known as Psymania
22:37:40 <Cheibriados> 03PleasingFungus02 07* 0.26-a0-757-g626ac9e: Update the changelog 10(38 seconds ago, 1 file, 111+ 113-) 13https://github.com/crawl/crawl/commit/626ac9e51af7
22:47:08 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.26-a0-757-g626ac9e51a (34)
23:10:15 -!- Yermak_ is now known as Yermak