00:00:03 advil: I'm in a function switch where case is calling OBJ_WANDS: 00:00:50 you would want something like `fun(static_cast(item->sub_type))` 00:00:55 wand_type is a type, not a member 00:03:30 or probably, `fun(static_cast(item.sub_type))` 00:04:09 spell_type spell = spell_in_wand(static_cast(item->sub_type)); it didn't like that or with item.sub_type 00:04:51 what was the error? 00:05:04 (that's actually a line of code you can find about 4 other places already) 00:05:09 says operand of -> has non-pointer type const item_def and invalid conversion from uint8_t for the . 00:05:54 let me try finding the other examples of it's usage 00:06:14 the closest match is in tilereg-dgn.cc 00:06:45 where there's something that might actually be string identical to what I suggested 00:07:08 spell_type spell = spell_in_wand(static_cast(item.sub_type)); 00:07:52 in tilereg-dgn.cc it's called in a function using const item_def& item 00:08:10 in the one I'm working on it's const item_def &item 00:08:22 that is the same 00:08:33 just a stylistic difference where the space goes 00:09:15 right. 00:09:27 can you pastebin the case block or something? 00:09:47 I think there's likely to be a small typo of some kind that is hard to see without the exact code 00:10:24 since uint8_t definitely should be castable to wand_type without problem 00:10:56 yeah it is, thank you. I think I'm messing up the rest of the switch statement. 00:11:12 naruni thanks for your trouble 00:11:47 https://hastebin.com/viceloteto.m 00:13:24 why is it continuing to try and think of 'spell_type spell' even though I've given a break; in the case statement 00:13:46 twelwe: no worries 00:14:01 I think there's a parse error earlier in the file 00:14:08 Naruni: you can't declare variables in case bodies 00:14:11 always work from the first error it produces 00:14:13 oh yeah 00:14:15 that 00:14:17 you need to wrap that with {}s to start a block 00:14:36 amalloy: ah ok 00:14:37 another thing is that you'll want to move the other cases down so they only break 00:14:38 thanks 00:15:05 right now, all of case OBJ_SCROLLS, OBJ_ORBS, through OBJ_WANDS trigger your code 00:15:09 advil: you mean case OBJ_SCROLLS: break; case OBJ_ORBS: break; la la 00:15:32 that would work but you could just move lines 1-4 there so they're right above what is now line 13 00:15:35 or restack OBJ_WANDS to be below the most prior break; statement 00:15:41 yeah gotcha 00:30:15 twelwe: did you open a FR on the mantis? 00:35:23 New branch created: pull/1539 (1 commit) 13https://github.com/crawl/crawl/pull/1539 00:35:23 03Naruni02 07https://github.com/crawl/crawl/pull/1539 * 0.26-a0-599-g7e53f86: Wand description shows noise level 10(54 seconds ago, 1 file, 8+ 1-) 13https://github.com/crawl/crawl/commit/7e53f863046b 00:38:04 that looks like a bit of an awkward sentence. "Silent to evoke." Maybe it could be "Noise when evoked: Silent" 00:39:35 > Sounds like a great interpretation; I like it. For a moment I was wondering if the game code actually did that by keeping track of items used by Oka followers who perished and selecting from that pool. I don't know what the statistics on deaths for Oka followers are though, so maybe if that had actually been true 90% of his gifts would be junk from followers who died shortly after leaving the temple. 00:40:06 interesting idea. Extend bones file to store Oka gifts that players were wearing/wielding when they died. Sometimes, the gift comes from this file rather than being randomly generated 00:40:17 alexjurkiewicz: none of them are silent. I tested every wand 00:41:28 but your alternative would also work. the noise string began with a capital "A" as in "A bit loud" or whatever so I didn't know how to write it correctly 00:41:50 Naruni: I meant the grammar of the sentence is a bit awkward. It's very fragmentary and is in the wrong order IMO 00:43:06 It's not hard to re-write the parsing line, but it is astronomical for me to figure out how to correct it, commit it, push it, and then re-issue the pull request without duplicating pull requests 00:43:45 I could change the file then do a commit -a "tweak the grammar" then do git push, followed by a pull request but I don't think I'm supposed to duplicate pull requests 00:55:20 Naruni: you can just commit then push. as long as you're pushing to the same branch, the PR is updated 01:01:37 amalloy: thank you 01:03:04 03Naruni02 07https://github.com/crawl/crawl/pull/1539 * 0.26-a0-600-g832988a: Tweak the grammar 10(in the future, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/832988adb273 01:14:08 New branch created: pull/1540 (1 commit) 13https://github.com/crawl/crawl/pull/1540 01:14:08 03ukdong9902 07https://github.com/crawl/crawl/pull/1540 * 0.26-a0-599-ga22fdad: DonaldSpeak_Wujian bugfix 10(6 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/a22fdad21e15 01:34:26 Unstable branch on crawl.develz.org updated to: 0.26-a0-598-g61e6210cf4 (34) 01:39:01 03ukdong9902 {GitHub} 07* 0.26-a0-599-gc8f6553: Unmute Donald for WJC followers (#1540) 10(15 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/c8f6553d2c94 01:47:08 Unstable branch on crawl.kelbi.org updated to: 0.26-a0-599-gc8f6553d2c (34) 01:51:58 Naruni: if you have some pending changes you can also "amend" the most recent commit, which smushes your new changes in with the previous commit and creates a new commit: git commit -a --amend 01:53:05 alexjurkiewicz: yeah, but for someone who is not very familiar with git i wouldn't worry about that. whoever merges can squash 01:55:03 Windows builds of master branch on crawl.develz.org updated to: 0.26-a0-599-gc8f6553d2c 02:33:15 amalloy: does it take a lot of effort for someone to squash? I'd rather devote learning to do things which prevent other people from having to put in more effort 02:36:47 no, there's a button for it in github, if you want to squash to a single commit 02:39:11 nice! thanks 03:11:49 Unstable branch on crawl.beRotato.org updated to: 0.26-a0-599-gc8f6553 (34) 03:30:54 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-3545-g7c84a495e7 03:47:12 Fork (bcadrencrawl) on crawl.kelbi.org updated to: 0.22.1-2931-g8b9ac52104 03:48:26 -!- amalloy is now known as amalloy_ 05:26:12 New branch created: pull/1541 (2 commits) 13https://github.com/crawl/crawl/pull/1541 05:26:12 03Nikolai Lavsky02 07https://github.com/crawl/crawl/pull/1541 * 0.26-a0-599-ga8dcf00: Actually let randarts generate with the spectral brand 10(14 minutes ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/a8dcf00d63c5 05:26:12 03Nikolai Lavsky02 07https://github.com/crawl/crawl/pull/1541 * 0.26-a0-600-g949f4cb: Fix quarterstaves and lajatangs not spawning with the protection brand 10(7 minutes ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/949f4cbe0f4c 09:29:46 New branch created: pull/1542 (1 commit) 13https://github.com/crawl/crawl/pull/1542 09:29:46 03amcnicky02 07https://github.com/crawl/crawl/pull/1542 * 0.26-a0-599-g6602fd6: Following PR#1258, resubmit new arrival vaults 10(22 hours ago, 2 files, 204+ 0-) 13https://github.com/crawl/crawl/commit/6602fd6d573a 09:39:01 <09g​ammafunk> hrm, really would be good to hack some display functionality into the discord side of this bridge for bot output 09:39:28 <09g​ammafunk> but I think the simplest fix for now is disabling link previews, which is probably already an option (or if not should be easy enough to add) 09:40:27 <09g​ammafunk> the PR and the commit link of chei output together generating over a page of screen with every PR update is pretty bad 09:51:54 New branch created: pull/1543 (1 commit) 13https://github.com/crawl/crawl/pull/1543 09:51:54 03amcnicky02 07https://github.com/crawl/crawl/pull/1543 * 0.26-a0-599-ga4711f1: Following PR#1258, resubmit new floating vaults 10(22 hours ago, 1 file, 162+ 0-) 13https://github.com/crawl/crawl/commit/a4711f1a3c67 09:57:26 03amcnicky02 07https://github.com/crawl/crawl/pull/1543 * 0.26-a0-599-g8196712: Following PR#1258, resubmit new floating vaults 10(22 hours ago, 1 file, 162+ 0-) 13https://github.com/crawl/crawl/commit/819671215c5c 10:08:30 New branch created: pull/1544 (1 commit) 13https://github.com/crawl/crawl/pull/1544 10:08:30 03amcnicky02 07https://github.com/crawl/crawl/pull/1544 * 0.26-a0-599-g8a7b29b: Following PR#1258, resubmit new mini vaults 10(22 hours ago, 2 files, 78+ 0-) 13https://github.com/crawl/crawl/commit/8a7b29b46b50 10:14:02 03amcnicky02 07https://github.com/crawl/crawl/pull/1544 * 0.26-a0-599-gad653b1: Following PR#1258, resubmit new mini vaults 10(22 hours ago, 2 files, 78+ 0-) 13https://github.com/crawl/crawl/commit/ad653b140d74 12:33:43 naruni no i didn't make a FR request on mantis 12:34:00 fr request lol 12:34:16 no i didn't make a FR on mantis 12:54:05 ok thanks. I put in the patch last night, someone will eventually take a look and decide if it's ok to apply. 12:56:03 i appreciate the work. you know how to code with computers? i will send bitcoin if you finish the work chequers started on this https://crawl.develz.org/tavern/viewtopic.php?f=8&t=22158 12:56:24 Have you got any real money? 12:56:52 yes. i have to change it into bitcoin to send online with websites 12:57:37 its time for the tloc god now that cblink is kaput 13:04:02 -!- Discord|1 is now known as Discord| 13:04:43 hello discord| 13:06:16 Unstable branch on crawl.akrasiac.org updated to: 0.26-a0-599-gc8f6553 (34) 13:14:36 twelwe: I will not take bitcoin, thank you though. I will take a look into it if it hasn't been rejected. 13:18:58 <09g​ammafunk> hi hello it's me discord| 13:22:32 twelwe: I can't find anything related to that post in the source. Maybe it got discontinued / rejected? 13:24:09 it was never developed beyond what was listed in blue text at the bottom of the post. chequers got busy with other things i believe 13:24:41 maybe the ghost of gammafunk can speak on whether or not it was rejected though 13:25:58 it was live briefly on CPO 13:32:04 <09g​ammafunk> oh I remember that god 13:37:32 gamma you can make it happen with two wrist flicks of computer codes. people will name their grandchildren after you and openly weep and offer you their shoes 13:39:18 <09g​ammafunk> oh, if you could see my discord avatar you'd understand I'd have no need for shoes 13:40:56 hooves 3 mut? 15:18:00 -!- Tiobot is now known as Guest6650 15:57:27 New branch created: pull/1545 (1 commit) 13https://github.com/crawl/crawl/pull/1545 15:57:27 03Roderick Schertler02 07https://github.com/crawl/crawl/pull/1545 * 0.26-a0-598-ga15926d: Add missing "info" command to --edit-save help 10(9 minutes ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/a15926d77dc7 17:50:31 I'd really dig it if reflected projectiles that hit monsters other than the originator ended up getting beat up by the ones who got hit 17:56:21 <10P​leasingFungus> that sentence went a bit awry midway through 17:57:14 <10P​leasingFungus> i get the idea but it doesn’t really make sense 18:24:05 Unstable branch on underhound.eu updated to: 0.26-a0-599-gc8f6553d2c (34) 18:33:30 yeah I meant if a yaktaur shoots a bolt at me, it refelcts off my shield, misses the yaktaur, hits the fire giant behind it, the fire giant should get pissed at the yaktaur 18:33:52 or maybe not should but it would be really funny 19:54:24 gregwegmann (L8 TrFi) Crash caused by signal #6: Aborted (D:5) 19:59:11 what if there was a chance the stone giant would get mad at the yaktaur? 20:01:04 New branch created: pull/1546 (1 commit) 13https://github.com/crawl/crawl/pull/1546 20:01:04 03amcnicky02 07https://github.com/crawl/crawl/pull/1546 * 0.26-a0-520-g8e7e8b2: Add Mlioglotl, a new Lugonu-themed unique. 10(2 weeks ago, 18 files, 339+ 37-) 13https://github.com/crawl/crawl/commit/8e7e8b2040ce 20:06:36 03amcnicky02 07https://github.com/crawl/crawl/pull/1546 * 0.26-a0-520-g0ab1019: Add Mlioglotl, a new Lugonu-themed unique. 10(2 weeks ago, 18 files, 339+ 37-) 13https://github.com/crawl/crawl/commit/0ab101920a1a 21:41:55 -!- cjm_ is now known as cjm 21:59:20 -!- amalloy_ is now known as amalloy