01:06:17 A tourney styling PR: https://github.com/crawl/dcss_tourney/pull/11 01:07:14 nice 01:07:28 I'll let alexjurkiewicz and/or ebering weigh in on that 01:39:29 Unstable branch on crawl.develz.org updated to: 0.26-a0-67-g850bfe61e3 (34) 03:33:08 Stable (0.25) branch on crawl.kelbi.org updated to: 0.25-b1-50-g7b83aa72e5 03:33:38 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-3222-g5327be9f7f 03:44:42 03gammafunk02 07* 0.26-a0-68-g35acc81: Changelog updates for 0.25 release 10(2 minutes ago, 2 files, 11+ 2-) 13https://github.com/crawl/crawl/commit/35acc811ca79 03:45:20 03gammafunk02 07[stone_soup-0.25] * 0.25-b1-51-g8acddc3: Changelog updates for 0.25 release 10(2 minutes ago, 2 files, 11+ 2-) 13https://github.com/crawl/crawl/commit/8acddc3725aa 03:45:47 I haven't tagged the release since we need a release title (which I couldn't come up with on the spot) and since people might want to modify those highlights 03:46:09 will be able to tag and announce the final release tomorrow morning 03:46:29 I'm also reseting the CDO tournament DB and readying it for start of tournament 03:47:06 hrm, we have a real problem actually 03:47:13 I can't get the updated set of nem choice combos 03:48:24 oof, hadn't thought about this issue 03:48:32 didn't expect sequell to be down still, I guess 03:52:55 so I think for now I'm just going to have to use the exact same set of eligible combos; if I filter out the 37 won last tourney, there won't be all that many left 03:53:30 well, maybe said filtering is the best idea and we can update the file eligible combos if we can figure out a way to do the query 03:53:45 possibly using CAO scoring db, but I might need some help from advil for that 03:54:13 so I guess I'll remove those 37 combos from last tourney since there are still ~80 combos left 04:31:24 -!- amalloy is now known as amalloy_ 04:37:06 DCSS 0.25: I'm A Fan of Spell Changes 04:39:11 wow, this is a big release 04:39:53 had to fix an issue with nem choice crashing Overview when no choice had been made 04:40:37 and to use subdirs in non-test logfile/milestones paths 04:40:37 but those commits are pushed, and database is reset with taildb running for the live tournament config 04:41:19 so everything is set to start tomorrow at the right time; can of course fetch any final commits and restart if need be 04:41:52 I will be around a few hours before tournament begins 04:42:52 advil: ebering: feel free to tag final release if you want to get to that before I'm around and have made any final commits and/or changelog updates 04:43:20 the github actions presumably will build most releases, and I (or advil) just have to make the debian packages 04:43:36 then we'd need the wordpress announcement 04:44:22 oh, and before that, an update to the download page in dcss-website repo with new version number and download URLs, which has to be fetched on CDO and put into place 04:58:36 alexjurkiewicz: not sure why, but the clans page is empty now 04:58:52 alexjurkiewicz: does it need some game data before it populates somehow? 04:59:17 ..doh 04:59:18 never mind 05:04:18 ok, that's fixed 06:01:22 Unstable branch on crawl.kelbi.org updated to: 0.26-a0-68-g35acc811ca (34) 06:35:23 Stable branch on crawl.develz.org updated to: 0.25-b1-51-g8acddc3725 (34) 08:59:56 It's a throwback but how about DCSS 0.25: Circling back to Squares 09:16:58 idgi 09:18:18 dcss 0.25: Magic surges out from thin air 09:18:55 actually basically all of these miscast msgs would make for hilarious release titles, that one is just relevant to some other stuff too 09:19:19 hm! 09:20:06 I particularly like the sound of dcss 0.xx: desparate hands claw out at random 09:20:25 very 2020 09:21:18 good title for a version with a summoning overhaul 09:34:10 still hoping to do some more visual work on the tourney pages today, we'll see 09:36:01 !time 09:36:30 ah, right, no sequell 09:36:37 I wonder if anyone has checked in with greensnark lately about that? 09:42:09 did team names used to not allow spaces? 09:42:23 or convert underscores to spaces? 09:44:00 they used to do some mangling w/ underscores and spaces 09:44:10 I really like Magic Surges Out from Thin Air 09:44:23 advil: want to go ahead and tag then? 09:44:49 I noticed a lot of teams are using underscores, maybe we should try to restore the mangling 09:45:09 "Clan names can contain letters, numbers, underscores, and hyphens." maybe actually this should include "spaces" since they seem to work 09:48:37 uh I think I still had alexjurkiewicz's test tags kicking around 09:48:37 I swear I deleted those 09:49:12 well, we'll see what it does! 09:49:12 %git 0.50.1 09:49:12 07kate-02 * 0.25-a0-701-gb30f108: Add a missing TAG_MAJOR_VERSION check 10(2 months ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/b30f108f014a 09:49:12 %git 09:49:12 07gammafunk02 * 0.26-a0-68-g35acc81: Changelog updates for 0.25 release 10(6 hours ago, 2 files, 11+ 2-) 13https://github.com/crawl/crawl/commit/35acc811ca79 09:49:12 yes, we changed spaces 09:49:31 %git stone_soup-0.25 09:49:31 07gammafunk02 * 0.25.0: Changelog updates for 0.25 release 10(6 hours ago, 2 files, 11+ 2-) 13https://github.com/crawl/crawl/commit/8acddc3725aa 09:51:11 %git 0.50.1 09:51:11 07kate-02 * 0.25-a0-701-gb30f108: Add a missing TAG_MAJOR_VERSION check 10(2 months ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/b30f108f014a 09:51:11 I think I have deleted that now 09:51:46 well, maybe chei still hasn't pulled 09:51:46 someone would have been surprised 20 years from now 09:51:46 hah 09:55:10 https://github.com/crawl/crawl/releases/tag/0.25.0 09:55:19 I just pasted the changelog content in there 09:58:12 is there a git workflow where a tag moves around? I've always wondered if there's a way to have a tag "stable" that always points to the current stable branch 09:58:42 the fact that I was able to delete those tags without some kind of force push makes me wonder if it might be a thing 10:04:12 Stable (0.25) branch on crawl.kelbi.org updated to: 0.25.0-0-g8acddc3725 10:05:33 The build has errored. (0.50.4 - b30f108 #13606 : Kate): https://travis-ci.org/crawl/crawl/builds/697618898 10:05:35 hm I guess dgl install-scripts or whatever doesn't automatically update the rebuild trigger 10:08:14 or, I had to also update a regex 10:09:53 ??rebuild 10:09:56 oh right 10:10:09 The build has errored. (0.50.1 - b30f108 #13607 : Kate): https://travis-ci.org/crawl/crawl/builds/697619134 10:12:29 weird permission errors on cao stable rebuild 10:12:52 fixed, but I wonder how it happened in the first place; `.git/logs/refs/heads/stone_soup-0.25` was owned by root 10:28:24 ok, I pushed kramin's style tweaks 10:29:03 the db wasn't changed, so advil if you're around and can pull and restart taildb it should pick up the changes 10:32:19 ok, done 10:33:00 must say I'm not 100% sure on these but I guess it looks less default now :-) 10:34:34 btw do you know what it is that we need for nemelex's choice that cao scoring would have? 10:34:43 I have never been entirely clear on how those are chosen 10:34:57 would still be nice to change the datatables default to 25 or 50 and enable the 'all' option 10:35:03 yeah, that's on my list 10:35:10 but I have let y'all blackbox datatables for me so I don't have to think about it 10:41:14 Stable (0.25) branch on crawl.akrasiac.org updated to: 0.25.0-0-g8acddc3 10:43:21 cue rebuild gives an ssl error for me and cxc rebuild shows me the perl file 10:45:56 cue rebuilds have been broken for a while 10:50:02 ah you already pinged tzer0 10:50:07 yep 10:56:59 The build passed. (0.25.0 - 8acddc3 #13608 : gammafunk): https://travis-ci.org/crawl/crawl/builds/697619462 10:57:45 Having a weird issue where some water tiles forget their color (and therefore alternate tile) on reload if they were part of a vault and their glyph in the end is different than their starting glyph (both via prepare water and via (N)SUBST). I can't trace why it would be correctly green before save and lose it on reload. I've "fixed" it just by 10:57:45 having it check adjacent tiles and match color with them, but that's more a "treat the symptom" than fix the disease. (again this is an issue I have no clue if happens at all in mainline; it could easily happen since i haven't changed how vaults are read; but I don't know if what if any vaults are affected). 11:04:47 Bcadren: if you're not a) asking a specific question about the codebase or b) making a specific bug report these vague messages about your fork struggles are off topic for crawl-dev 11:09:56 feat_colour() is sometimes lost on area reload? It kinda is a specific bug; it's just affecting what I'm up to more heavily than it usually affects mainline. 11:24:45 advil: from the 0.24 tourney rules: "The species/background combinations are chosen by Nemelex from those with at most 39 online wins and which weren't Nemelex Choices in the previous tournament." 11:25:16 (39 has been gradually increased over the years) 11:25:51 in other words, what we need is a list of combos sorted by number of online wins 11:27:04 but I think just doing what gammafunk described is fine if there are still ~80 11:55:36 If I understand right, all wins should be recorded in the 'score' file on each server, right? 11:55:58 So I could plausibly write a quick and dirty parser to count number of wins per combo? 11:57:30 I'm looking at his file as an example: https://crawl.kelbi.org/crawl/meta/0.24/scores 11:57:40 s/his/this 11:57:43 that's basically what scoring does 11:58:16 advil: should be able to run a sql query against the scoring database 11:58:18 Oh, that's way easier than cobbling together a parser to get nchoices 11:58:25 yes 12:37:36 Stable (0.25) branch on underhound.eu updated to: 0.25.0-0-g8acddc3725 12:42:29 03ebering02 07* 0.26-a0-69-g0742823: More credits for 0.25 (oops) 10(60 seconds ago, 1 file, 3+ 1-) 13https://github.com/crawl/crawl/commit/0742823d3978 12:42:33 03ebering02 07[stone_soup-0.25] * 0.25.0-1-g7eea58d: More credits for 0.25 (oops) 10(64 seconds ago, 1 file, 3+ 1-) 13https://github.com/crawl/crawl/commit/7eea58d2a3ac 12:43:48 ok, I have a wordpress post ready to go 12:44:03 Just need to update the downloads page 12:44:21 it looked like all the artifacts generated, haven't had a chance to test any of them though 12:46:27 Unstable branch on crawl.kelbi.org updated to: 0.26-a0-69-g0742823d39 (34) 12:47:25 the tiles zip works 12:47:30 though it's not mac-signed 12:47:37 erm, the mac tiles zip 12:47:40 we haven't signed for a while 12:48:22 yah 12:49:41 advil: thanks for making the release, anything else left to do? 12:50:24 I haven't done the deb stuff 12:50:33 I didn't want to finalize it last night since we had sort of already missed the "day before" thing and it wasn't clear if changelog etc needed more changes 12:50:37 I can do those 12:50:58 can you test the windows builds in wine? 12:51:21 I can do them in a vm later today but I've got a bunch of work tasks pulling my attention for a while 12:51:28 yeah 12:56:25 advil: tiles and console from the installer both work fine in wine 12:56:30 great, thanks 12:56:32 btw you're probably getting asked this as much as me, but any word on sequell? 12:56:58 not since we last saw snark working on it; my guess is he does some more work this weekend 12:57:02 getting the nem choice combos from scoring should be easy 12:57:08 ok, that's great 12:57:16 um, we need to use a new cutoff I guess 12:57:29 but maybe that part is not so critical; not sure how easy for you to query that 12:58:07 I usually just add a kw to filter out last tourney nchoice and look for a set of ~120 playable 12:58:39 but it's 37 we could just remove from the results manually if need be 12:59:23 so I guess we could just look for whatever cutoff gives ~150 combos 13:01:19 Stable (0.25) branch on crawl.akrasiac.org updated to: 0.25.0-1-g7eea58d 13:02:07 %git stone_soup-0.25 13:02:07 07ebering02 * 0.25.0-1-g7eea58d: More credits for 0.25 (oops) 10(21 minutes ago, 1 file, 3+ 1-) 13https://github.com/crawl/crawl/commit/7eea58d2a3ac 13:04:53 an oops commit as our release commit?! these are dark days 13:05:19 otoh maybe he was crediting the user named 'oops' 13:08:03 We didn't update the credits before tagging 13:08:28 actually I wanted to see what the release commit was, now that I think about it 13:08:32 %git 0.25.0 13:08:32 07gammafunk02 * 0.25.0: Changelog updates for 0.25 release 10(9 hours ago, 2 files, 11+ 2-) 13https://github.com/crawl/crawl/commit/8acddc3725aa 13:08:37 makes sense 13:10:24 Unstable branch on crawl.akrasiac.org updated to: 0.26-a0-69-g0742823 (34) 13:10:37 hm not sure if I have a convenient way to filter obsolete combos at the sql level 13:11:17 advil: well, if you just get ~150, I can remove the 37 manually 13:11:40 I think advil means the playable keyword 13:11:41 so whatever cutoff gives you that; also the combos have to be playable; not sure if that likewise causes complications 13:11:45 right 13:12:07 yeah, it's the playable issue, with a threshold of 40 I get 479 results but most of them are not playable 13:12:07 could do that post-hoc potentially 13:12:33 advil: add this to your where clause 13:12:59 just sort of put all the unwanted combos (playable + from last t) in a file and filter after query, see what you get 13:13:14 er s/playable/unplayable/ 13:13:16 AND NOT MID(charabbrev, 1, 2) IN (removed species codes) AND NOT MID(charabbrev,3,2) IN (removed background codess) 13:13:48 that will miss a few things 13:13:49 scoring doesn't handle removed combos in the db 13:13:58 like FeFi or w/e 13:14:13 oh you're giving me a string matching recipe 13:14:20 yes 13:15:07 its not perfect but 13:15:54 yeah, manual filtering of the unplayable ones 13:18:54 ok, <50 gives me 198 rows, is that enough? 13:19:58 advil: yeah, will probably have a bit more than we usually do, but that's ok 13:20:21 not sure how many unplayable ones left in that, probably a couple dozen 13:20:33 only looks like a few that are very obvious (from count) 13:20:42 hrm, in that case, can you try a lower cutoff? 13:21:24 we want ~110-120, so more like 150? 13:21:24 I'll sort it by count so you can just drop the higher ones if you want 13:21:24 great, thanks 13:22:14 I'll also remove any combos that ebering is good at 13:23:53 napkin also got 0.25 installed on CDO, so we'll have all servers ready 13:24:36 ~// 13:24:46 sweet 13:24:49 http://crawl.akrasiac.org/scoring/nemelex_2020.txt 13:24:52 also dang I guess no nnemelex choices this t then 13:25:29 thanks advil 13:25:42 query was: SELECT DISTINCT charabbr, COUNT(*) AS `num` FROM wins WHERE NOT MID(charabbr, 1, 2) IN ("Bu", "Dj", "El", "GE", "Gm", "HD", "HE", "Ke", "LO", "MD", "OM", "SE") AND NOT MID(charabbr, 3, 2) in ("Cr", "DK", "He", "Jr", "Pa", "Pr", "Re", "St", "Th") GROUP BY charabbr HAVING num<50 ORDER BY num; 13:25:54 Nemelex 2020 is also one of my bumper stickers 13:26:10 figure he has to be better than the current administration 13:26:54 poor CeCj 13:26:59 I'm going to go ahead and post the release announcement, with a note that the download page will update soon, if that's ok 13:27:11 surprised bacj is so low, I would have thought that would be strong 13:27:22 ebering: that's fine, please do 13:27:46 ebering you could also point to the github release? not sure if that confuses things too much 13:27:57 I'll pointn there too 13:28:13 advil: Ba is the newest species that's not overpowered gnoll 13:28:18 true 13:28:43 Nemelex Choice is a MDCr 13:28:49 get good punks 13:28:58 I will abandon TSO on turn 1 13:29:11 Well, we're halfway there 13:29:58 gammafunk: already confusing Cr and Pa??? 13:30:11 damn! I admit it was a guess 13:51:39 gammafunk: btw, you might want to purge the player/clan pages since there is test stuff left over, e.g. https://crawl.develz.org/tournament/0.25/players/elliptic.html 13:52:03 oh, yeah good call 14:03:14 oh, did anyone clear out old templates? It's conceivable that there could be a few being generated still 14:03:37 oh, no I did not 14:03:43 let me check git status, I guess 14:23:40 advil: when you get a chance maybe replace the delay but page now available pin with a link to the tourney? 14:47:08 ebering: hrm, any reason why the script wouldn't create the index page if it didn't already exist? 14:47:40 or do we have to create that separately still? 14:48:37 guess so 15:01:44 didn't I change it to create the index page? 15:02:00 maybe I only did that for loaddb though 15:06:15 advil: yeah, that must be it then; I used taildb 15:07:56 there's a separate py script that will create the index, though I'm not sure if db locks will interfere 15:10:09 advil: I did use that, yeah, and it ran successfully despite taildb being active 15:10:43 I can add the create index step to taildb later if you don't get to that 15:11:27 we use innodb tables, locking is row-wise 15:11:57 http://dpaste.com/1C5PZ98 15:12:18 tentative final list of nem choice candidates with (hopefully) all 0.24 choices and unplayable combos removed 15:12:24 cutoff of 43 gives us exactly 110 15:19:58 apparently demigod used to be abbreviated as DG at one point 15:21:16 heh yeah scoring takes its cues from the earliest games or something 15:21:53 iirc I did a few custom things involving that but not DG 15:22:37 I wonder if I need to fix that in the nem eligible file 15:23:00 case shouldn't really matter for sql at least 15:37:40 for some reason the left table edge (the line) is not showing for me on any tourney tables right now 15:41:59 also the clan page (now that we can see all the data) only shows the first two columns, with the clan name column being half the table width :D 15:42:20 thanks to "I Listen to Deep Dwarf House Acid Splash Jazz and Dub Shadow Step" 15:43:26 oof 15:43:46 there are some other less dire table column width bugs 15:44:25 like on the home page, various tables have way too much width for their # columns 15:44:25 yeah, I know about the home page one 15:44:25 s 15:44:25 and possibly the other columns as well 15:47:15 -!- spicycat is now known as splicycash 15:53:04 OAOB 15:53:10 oops 15:53:37 I might enable container-fluid for the clans and players page 15:53:42 any objections? 15:53:46 none here 15:53:56 I'm mostly just biting my nails hoping this stuff really does work 15:54:05 it has been working but 15:54:09 the actual live run 15:54:10 gonna start taildb right at t start so we get a nem choice 15:54:11 this can be tweaked but it at least lets someone with a big enough screen (which included my laptop screen in testing) resize it so the current clan table is usable 15:54:23 yeah it has been quite stable during tests 15:54:26 I think it ran overnight? 15:54:33 well, there have been various changes 15:55:27 is there anything to have it force an 'overall' update (including nem choice) if tournament has started after script was started? 15:55:35 meaning running taildb and it seeing that t just started, so it does an overall update? 15:55:40 hm not sure 15:55:46 not sure either 15:55:48 can you pull and restart taildb anyways? 15:55:55 yep, that's what I'm going to do 15:55:59 I just committed a tweak to paging, and the container-fluid thing 15:56:06 oh, yeah can pull as well 15:56:11 gammafunk: I think elliptic will know the answer to that 15:56:13 25 might be too big a default for paging, but 10 seemed too small 15:56:19 that part of the control flow didn't change from old t 15:56:23 I also added "all" 15:56:30 25 is probably good 15:56:42 yeah got that change 15:56:56 will just start taildb right at 8pm utc 15:57:14 (in 3 minutes, get ready!) 16:01:23 have you started it? 16:01:38 yep 16:01:42 took a bit to fetch 16:01:48 it's running through team stuff 16:01:52 so just 20 seconds or so 16:01:59 I think what I did was try to time the update cycle (of 7 mins or whatever it was at the time) to have it happen right after tourney start time to choose nchoice then 16:02:15 but if that didn't seem to be working, manually starting it then worked too 16:02:39 I see nchoice is BaEn, exciting 16:05:25 heh vt leading with win rate category with 0.00% wins 16:05:30 I guess 0 > no games? 16:05:44 which does actually make sense 16:06:27 it does seem to all be working! 16:06:27 time to play crawl 16:07:19 we need to do the tourney banner 16:07:31 it might be a good idea to do that for seeded 0.25 games, since they can be played on CAO 16:07:42 tourney banner? 16:07:50 oh, the trunk warning? 16:07:51 "are you sure you want to play this version" 16:07:52 yeah 16:07:55 gotcha 16:07:57 I can do that real quick 16:08:07 unless you wanted to add the seeded games part 16:08:20 since I'm not sure what has to be done there 16:08:25 go ahead and do it for trunk, I guess the seeded one needs another 0.25 push anyways 16:08:31 will do 16:10:49 03gammafunk02 07* 0.26-a0-70-g31f1466: Add a trunk reminder for the 0.25 tournament 10(22 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/31f1466007b3 16:16:42 hrm, now how often does the overview update 16:16:44 because it last did at 2 minutes after 16:16:49 oh there it goes 16:16:52 must be 14 minutes 16:16:57 Unstable branch on crawl.kelbi.org updated to: 0.26-a0-70-g31f1466007 (34) 16:18:35 ok here's a bug 16:18:45 cao definitely struggling 16:18:52 I reniced scoring, maybe will help a bit 16:18:56 oh wait 16:21:30 oof 16:21:33 ok we have an exception 16:22:12 advil: ebering: http://dpaste.com/19WTQ38 16:22:20 player update stage seemed to fail 16:23:47 2020-06-12 22:18:32,957 [INFO] Updating all player pages 16:23:55 was last message in taildb log 16:24:04 looking 16:24:58 I think that could happen if someone has set a captain who hasn't set their captain line? 16:26:33 I'm guessing you don't know what player triggered that exception from the logs 16:27:42 Build failed for master @ 31f14660 https://github.com/crawl/crawl/actions/runs/133713534 (failed: Linux Build) 16:27:42 advil: yeah, can't tell unfortunately 16:29:00 I will push a fix but I'm not 100% sure why the query didn't already filter that case out 16:30:46 that code looks weird, it doesn't actually even use clan_page? 16:31:19 I did a sort of blind quick fix to deal with the exception case (get_clan_info returning None) but maybe there's still something off with that code 16:32:01 ok pulled and restarted, so we'll see 16:35:47 not sure what it's doing now 16:36:09 messages indicate that it finished all fetches of logfiles/milestones but it's not printing anything further for a few minutes now 16:36:36 oh, there it goes 16:36:37 it was extremely slow to process anything in my testing 16:36:42 on cdo 16:36:59 it might just be that there's a lot of milestones because of tourney start 16:37:32 yeah, had ~1.8k lines from that period where taildb had crashed 16:37:42 takes like 5 minutes to handle 3k lines I guess 16:38:06 advil: looks like all updates succeeded this time 16:38:42 we're back to the fetch cycle 16:38:47 boy the font on the player's name on their player page 16:38:49 a bit large 16:41:58 ok maybe I should finally update the download page 16:53:00 download page updated 16:53:25 will make the debs a bit later 17:46:53 nice, looks like the release builds automatically updated? 17:47:40 anyway, i'm still not very around for today but I'll be back tomorrow with some dev time 17:47:47 they did, yeah 17:47:57 not further exceptions from taildb 17:52:16 btw, congrats on the release! 17:54:26 wow. the banner display is very very cool! nice work 17:56:58 ebering: scoring issue. This person has 1 floor complete of a ziggurat but didn't get xom banner tier 1 (enter a zig) https://crawl.develz.org/tournament/0.25/players/vidiiot.html 18:03:08 is it possible that it won't get assigned until they descend? 18:04:53 yeah, I think that probably did it 18:04:54 or exit 18:07:48 alexjurkiewicz do you have any guesses why the left border line of tables is not drawing? 18:07:53 possibly the bottom line also 18:08:32 I'm not sure whether this is new or just more noticeable with kramin's theme 18:09:26 -!- jfcaron_ is now known as jfcaron 18:17:49 hm 18:18:05 I think most likely datatables is responsible somehow 18:18:25 that thing really works, with minimal effort, but the resulting DOM is hard to figure out 18:20:03 100% 18:20:11 i think it's related to the fixed columns plugin I enabled for wide tables 18:20:43 oh, it's not working on non-fixed-column tables too 18:21:28 the reason why is because it's explicitly disabled for dark tables in bootstrap 18:21:35 .table-dark.table-bordered { border: 0; } 18:21:43 ah hm 18:21:56 btw just to flag it for your attention, with the full clan name + member list, having single line columns for the teams page is maybe too much 18:22:01 not sure what to do about that though 18:22:32 setting it to fluid helped a bit 18:23:14 ah, hm yeah. And you can't horizontally scroll while your mouse is over the fixed column 18:23:14 that's nearly impossible to use on smaller sreens 18:23:14 yeah was just about to check my phone 18:23:21 there's one extremely long team name 18:23:21 I think the correct fix would be to set a max width on the clan and player columns 18:24:10 if the max width of the columns was set to like 10rem, and they could wrap to next line, it should hekp 18:24:18 oof yeah on an iphone you can't get out of the clan column 18:24:23 but, i gotta go for now 18:26:15 Unstable branch on underhound.eu updated to: 0.26-a0-70-g31f1466007 (34) 19:42:01 why was the default number of entries shown on https://crawl.develz.org/tournament/0.25/all-players-ranks.html changed from 10 to 25? now the horizontal slider is never visible the first time I go to the page 19:42:28 and you'd need a pretty large monitor for all 25 rows to be visible at once 19:51:19 elliptic: yeah, I see that advil felt 10 was way too small, but did mention that 25 could be too many 19:52:12 on my laptop, 10 seems like the right number 19:52:25 but I could see it being quite a bit too small on a typical setup 19:56:00 hrm, is the win rate percentage wrong? 19:56:45 ah, that's calculating it based on an assumption that their current game is a loss? 20:04:14 -!- amalloy_ is now known as amalloy 20:11:56 yeah, so that 6/6 is better than 5/5 and such 20:12:00 for people with 0 losses 20:13:16 (15 rows is about the max that is reasonable on my laptop) 20:13:19 about the number of entries on the large table, I assumed everyone would be scrolling by just using their mouse wheel 20:13:35 huh? 20:14:06 can people with mouse wheels scroll both vertically and horizontally? 20:16:25 afaik the only possible way for me to scroll the table horizontally is to find the slider at the bottom and drag it 20:16:43 and I'm not currently using a mouse but I'm not sure how that would help 20:18:44 on macos, with a trackpad or mouse, I can scroll horizontally and vertically 20:18:44 the mouse middle button supports both directions 20:19:00 on windows, I'm pretty sure if you click the middle mouse button you get a free drag sort of thingy 20:19:09 did the t scripts stall again? 20:19:11 i'm not sure about linux mouse or trackpad support 20:19:20 no they did not 20:19:22 but i'm happy with showing only 10, if that's better 20:19:25 I'm just impatient 20:23:34 Stable (0.25) branch on underhound.eu updated to: 0.25.0-1-g7eea58d2a3 20:44:03 I can change it back to 10, that seemed much too small to me even on my laptop 20:44:11 but yes, I can scroll L-R both with my mouse and trackpad 20:45:24 I wonder if there's something better that could be done with the page title, it's consuming a lot of vertical space 20:47:15 advil: does updating the lobby template require restarting webtiles? 20:47:44 cbro still points to 0.24 tournament, but didn't want to ask if that requires a restart to update 20:51:45 hm, I did figure out how to make my touchpad scroll horizontally in linux, though it's a bit finnicky 20:52:16 it used to need a restart for the non-logged in lobby but shouldn't any more 20:53:38 ok, good to know 20:55:27 maybe 25 is fine then, it just felt weird to me since even on desktops I don't have resolution that substantially larger than this laptop 20:57:38 no, I agree it's a bit tall, and I was forgetting that I have magic mouse privilege 21:01:09 alexjurkiewicz: advil: a datatables thing I just now noticed 21:01:24 "-" rates better than 1 for sort order 21:01:36 which makes it really hard to use the all player ranks column to see subranks quickly 21:08:13 elliptic: a lot of modern scroll wheels (e.g. mine) have a horizontal tilt feature. but also, in at least chrome and firefox, holding shift modifies the ordinary vertical scroll wheel to move horizontally 21:09:18 i do a lot of horizontal scrolling since i have to use large fonts for accessibility reasons 21:35:44 ebering yeah sort order needs some work 21:35:46 it's on my list 21:35:58 same issue if "-" becomes "" 21:47:25 oh, the shift thing is neat 21:49:42 would it be hard to add the duration of the win to the win listing tables? 21:50:00 maybe there's too much information that way 22:29:57 atrodo (L12 FeCj) ASSERT(m) in 'mon-util.cc' at line 1978 failed. (Zot (ZotDef)) 22:33:46 ah yes 22:33:50 good old zot defense 22:33:55 -!- misha is now known as werekitten 22:53:12 freshwaterlynx (L9 VSIE) Crash caused by signal #6: Aborted (D:10) 22:56:58 ok, got another template error 22:57:26 http://dpaste.com/3SNBTV6 22:57:33 same error we had seen before during testing 22:58:09 yeah taildb crashed 22:58:35 the issue where we're attempting to format a number as a string 22:59:50 advil: ebering: alexjurkiewicz: ^ if you have any input on that 23:01:30 would be helpful to know what exactly it's choking on 23:03:39 yeah I'm inserting a try/except to get that 23:03:50 thankfully it crashes from loaddb as well so should be easy to get 23:06:08 val is 1994 23:06:13 ok, so player name again 23:06:31 I notice that in another case alexjurkiewicz ended up using `val = '{:,}'.format(isinstance(val, str) and int(val) or val)` 23:06:46 yeah 23:07:09 just do same there? 23:07:28 maybe? I didn't look very closely at how he ended up solving this overall problem 23:08:29 I don't think we want numeric formatting to apply to player names 23:09:10 since 01994 would render as 1994 for example 23:09:26 actually as 1,994 23:10:58 ok, with that change it does get through the rendering 23:11:04 so, is there a player 1994? 23:11:11 yeah 23:11:19 http://crawl.akrasiac.org/scoring/players/1994 23:11:36 I haven't made absolutely sure they are playing now but they have played recently 23:11:38 indeed 23:11:45 ah and after tourney 23:12:13 and the link to their player page is wrong with the formatting you mention 23:12:31 https://crawl.develz.org/tournament/0.25/players/1994.html 23:12:54 it sort of looks like in other cases the "Player" col is handled differently (as a PseudoCol), but not for the combo scoreboard? 23:13:35 without testing, I would be inclined to try something like `if c[0] != "Plahyer" and numeric_col:` as a quick fix 23:13:58 er, with Player spelled right 23:14:39 but I don't have a local data set with this case in it so that is sort of a guess 23:14:39 I can try it 23:14:50 if I did try that, would I also want to change the other fix? 23:14:54 hm, not sure that "Player" is the correct match 23:15:12 one sec 23:16:38 maybe "player" 23:16:51 can just do .lower() 23:17:03 yeah 23:21:39 interesting 23:21:48 TypeError: 'int' object has no attribute '__getitem__' 23:21:59 from if c[0].lower() != "player" and numeric_col: 23:22:35 oh 23:23:09 c means something different in the other place with that conditional 23:23:13 looks like you changed both 23:23:16 ah, yep 23:23:20 `for c in range(len(headers)):` 23:23:43 I would leave the one that didn't trigger an exception as is? 23:23:49 ok 23:24:53 here we go, third time's charm 23:25:39 though I bet this will need fixing too, that one has a cast and is probably inserting the comma. The right variable there looks to be `header` instead of `c[0]` 23:26:17 maybe that check is better instead at `numeric_col = _is_numeric_table_value(val) and header.lower() != "player"` (or similar with c[0]), instead of on the conditional 23:26:38 I'll let you make a follow-up commit if this goes through 23:26:51 ok 23:27:29 right now at the always-nerveracking Drop Teams 23:27:36 heh 23:27:41 ok loaddb went through that time 23:27:45 let me see about that user page 23:28:14 ah yep I can see 1994 on the combo scoreboard with the wrong formatting 23:28:20 their user page is still messed up 23:28:31 yeah, now why wouldn't that have fixed 23:28:36 is that outputed from another template 23:28:38 that's the one that has the cast 23:28:57 oh I see 23:29:54 this might come up if anyone makes an all-numeric team 23:31:09 should I commit something? 23:31:09 I've restarted taildb for now with that local hot fix 23:31:09 please do 23:34:34 ok I've committed and pulled on cdo, but I'll let you do the restart since it sounds like you've been monitoring the script 23:35:10 +ebering | "-" rates better than 1 for sort order <-- we need to add a `data-order="0"` to those rows 23:35:18 s/rows/tds/ 23:35:31 curious line popped up in taildb 23:35:31 2020-06-13 05:35:05,882 [DEBUG] HunfridMar win (NaFi), runes: 3 23:35:45 does it do that any time a new win is detected 23:35:51 maybe just didn't see it previously 23:35:53 I think the cdo-specific commit might turn on those messages? 23:35:58 yeah, I've seen it on cdo before 23:37:17 oh, ok; maybe I shouldn't have that on 23:37:20 restarted taildb 23:37:44 heh yeah I see what you mean, the drop teams step is agonizingly slow on cdo 23:38:43 looks like taildb made it through entire update with your changes 23:38:53 and 1994 seems to be fixed 23:38:58 yep, nice; thanks 23:39:09 that commit should handle numeric clan names too 23:39:32 alexjurkiewicz what would you think of putting page titles in the upper right corner? 23:42:21 another idea for players/clans would be to move the "show X entries" thing over by the search box and put a table caption in its place instead of a page title 23:42:26 advil: you can add the text-right class to a heading or p to do this. First impression is it looks sort of funkier but is harder to read. But how much harder depends on the page width 23:42:40 ah did you try it? 23:42:45 I haven't actually tried it :D 23:43:34 just locally editing a page 23:43:43 i added that class to the player name on a player page 23:44:08 you can also try float-right if you want it non-inline 23:44:24 also there is a vertical responsive datatables plugin that adjusts paging based on window size but I couldn't get it to work 23:44:42 hm. Putting the player name in a column to the left of "Overall Rank" and "Clan" data looks alright 23:45:04 ah that could be good 23:45:13 I was wondering also about the all-players/teams page for this 23:46:41 I think the benefits of this idea is breaking up a monotonous page, eg if everything was half width left aligned content. So for 'all players' I don't think there's much benefit at all 23:47:39 well, my goal here is to fill as much space with the table on default settings on a reasonable window size as possible 23:47:39 here is what I prototyped for the player page: https://imgur.com/a/88wA8Ml 23:47:47 (that's from adding the classes float-left and pr-5) 23:48:17 oh. you mean upper right as in inside the nav bar 23:48:27 yes, sorry 23:49:56 I guess it would have to go somewhere else at phone width, not sure where 23:50:15 not quite sure how nav bar logic works about aligning things to the right 23:50:24 so can't figure out an easy prototype 23:50:35 well, I can think about it tomorrow 23:50:42 I guess my worry is "how many pages on the internet have the title in the top right as part of the menu bar?" 23:51:44 i'll also bb