01:07:11 ebering: are you around to explain query.update_rank / query.update_all_player_ranks ? 01:38:56 Unstable branch on crawl.develz.org updated to: 0.26-a0-58-g79b31b8662 (34) 02:09:59 ebering: ok, I got it, look out for a big refactor to how those functions work and how the relevant metadata is stored in scoring_data.py 03:15:47 ebering: advil: please see this branch with my new work. It's a relatively large change so didn't want to push without giving a chance to review: https://github.com/crawl/dcss_tourney/pull/new/new-scoring-typed-tables 03:18:45 better link: https://github.com/crawl/dcss_tourney/compare/new-scoring...new-scoring-typed-tables 03:30:40 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-3205-gb897bc9fbb 04:02:24 this branch has a couple of bugs. I ripped out the hacks I did to rename clan pages from {team_captain} to {clan_name}-{team_captain} 04:03:06 several places need updates to revert their clan page links (and to use the crawl_utils.clan_link in future which I discovered) 04:04:13 beyond that, I need to replace all places using the old table logic with new table logic. Only a couple of places remain. Places showing games list (overview, player & clan pages), and top players/clans on overview 04:04:29 will get on it in the next day or so 06:43:51 -!- amalloy is now known as amalloy_ 06:59:04 -!- amalloy_ is now known as amalloy 07:00:20 -!- amalloy is now known as amalloy_ 08:10:22 03Elliot Dronebarger02 07https://github.com/crawl/crawl/pull/1427 * 0.26-a0-45-gdcfaf3d: Some cleanups 10(3 minutes ago, 5 files, 26+ 26-) 13https://github.com/crawl/crawl/commit/dcfaf3ddd825 08:10:22 03Elliot Dronebarger02 07https://github.com/crawl/crawl/pull/1427 * 0.26-a0-46-g4065d8b: Forgot to check linter 10(2 minutes ago, 2 files, 2+ 2-) 13https://github.com/crawl/crawl/commit/4065d8b54ea3 09:44:09 alexjurkiewicz: probably don't want to blanket enable datatables on e.g. the overview page 09:44:53 I also am not sure about how well its paging mode works for us, though maybe you just hadn't gotten to adding any config 09:49:06 code-wise I'm fine with you going ahead and merging this 10:09:28 New branch created: remove-habitat-real-amphibiousness (1 commit) 13https://github.com/crawl/crawl/tree/remove-habitat-real-amphibiousness 10:09:28 03Aidan Holm02 07[remove-habitat-real-amphibiousness] * 0.26-a0-59-g2a36f74: Move real_amphibious mons_habitat hack to separate method 10(26 minutes ago, 5 files, 80+ 23-) 13https://github.com/crawl/crawl/commit/2a36f74b56e0 10:20:08 alexjurkiewicz: I'll review and merge that today 10:20:15 I think I have energy to work normally 11:17:34 well, if you mean the branch he just posted, give him some more time to work out some ui stuff maybe 11:17:54 doesn't look like the table formatting is done to me 11:43:18 ok 11:43:33 it's backend refactor makes adding the transform functions to display additional data in the rankings easy to implement 11:43:40 vv nice factorization 11:44:01 I'll try to add as many of those as I can 11:45:17 alexjurkiewicz: one nit to pick: you re-added displaying the Winning category in the overview! per advil and I's discussion we think it's best to just leave that off in the overview and have it appear in rules and individual/clan pages 11:45:29 since it isn't a "ranked category" in the usual sense 11:58:18 maybe it's still more expedient to merge even if some of the rendering is wip 11:58:58 I guess sequell is currently dead dead :-/ 12:16:04 New branch created: pull/1447 (1 commit) 13https://github.com/crawl/crawl/pull/1447 12:16:04 03Elliot Dronebarger02 07https://github.com/crawl/crawl/pull/1447 * 0.26-a0-59-g8a062cd: Added SDL_image to dependency requirements in INSTALL.md 10(5 minutes ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/8a062cd4b47c 13:06:00 Unstable branch on crawl.akrasiac.org updated to: 0.26-a0-58-g79b31b8 (34) 13:19:14 AFAICT the use of fake_noisy for orb pickup and apportation and Xom doesn't work (and never has); noisy() lets it go off at a silenced square but it still can't propagate into (through?) silenced squares. Just mentioning it here in case I'm missing something because slapping in a Mantis issue 13:19:38 s/because/before/; 13:40:05 Pinkbeast yeah, doesn't seem like it propagates, there's noise only at the orb location 13:43:20 advil: running it with local test there are still some things to be done with the ui 13:44:16 but I think I'm going to merge it to main so I can start building on the "additional display info" using the column tables 13:44:16 that seems reasonable (do you mean new_scoring?) 13:44:16 yes 13:44:23 I guess we could merge all this into master some day 13:48:33 03advil02 07* 0.26-a0-59-gd69c119: Tweak how seed games are displayed in ?v and chardump 10(2 minutes ago, 3 files, 13+ 8-) 13https://github.com/crawl/crawl/commit/d69c119aaa7d 13:49:12 03advil02 07[stone_soup-0.25] * 0.25-b1-42-gfa7c8ce: Tweak how seed games are displayed in ?v and chardump 10(3 minutes ago, 3 files, 13+ 8-) 13https://github.com/crawl/crawl/commit/fa7c8ce0536d 13:58:03 03advil02 07* 0.26-a0-60-g00fb324: Show seed for seeded play with welcome message 10(63 seconds ago, 2 files, 5+ 2-) 13https://github.com/crawl/crawl/commit/00fb324cd09f 13:58:41 03advil02 07[stone_soup-0.25] * 0.25-b1-43-g9cfca56: Show seed for seeded play with welcome message 10(2 minutes ago, 2 files, 5+ 2-) 13https://github.com/crawl/crawl/commit/9cfca5693d92 14:03:35 Unstable branch on crawl.kelbi.org updated to: 0.26-a0-60-g00fb324cd0 (34) 14:21:46 Build failed for stone_soup-0.25 @ fa7c8ce0 https://github.com/crawl/crawl/actions/runs/128885483 (failed: Catch2/codecov) 14:36:52 Build failed for stone_soup-0.25 @ 9cfca569 https://github.com/crawl/crawl/actions/runs/128892089 (failed: Catch2/codecov) 15:01:41 03advil02 07[stone_soup-0.25] * 0.25-b1-44-gc3591d3: Fix catch2 tests for map panning / clamping 10(26 hours ago, 3 files, 34+ 1-) 13https://github.com/crawl/crawl/commit/c3591d366c2b 15:01:41 03advil02 07[stone_soup-0.25] * 0.25-b1-45-g73d902b: Fix viewmap catch2 even more 10(26 hours ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/73d902bd6c5a 15:37:23 alexjurkiewicz: check out 4ae2c62e269 in new-scoring 15:56:53 New branch created: pull/1448 (1 commit) 13https://github.com/crawl/crawl/pull/1448 15:56:53 03shummie02 {GitHub} 07https://github.com/crawl/crawl/pull/1448 * 0.26-a0-61-g36a7bbd: Change = to == in checking crawl_state.type 10(3 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/36a7bbd71978 15:58:31 03shummie02 {advil} 07* 0.26-a0-61-g6c07f0e: Change = to == in checking crawl_state.type 10(5 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/6c07f0ee8d46 15:58:54 uh oh 16:00:00 03shummie02 {advil} 07[stone_soup-0.25] * 0.25-b1-46-gb8a1ec0: Change = to == in checking crawl_state.type 10(6 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/b8a1ec05dff4 16:01:32 Unstable branch on crawl.kelbi.org updated to: 0.26-a0-61-g6c07f0ee8d (34) 16:13:11 The build passed. (stone_soup-0.25 - 73d902b #13587 : advil): https://travis-ci.org/crawl/crawl/builds/696168034 16:16:48 fastest merge in the west 16:33:19 Anyone know whether or not the bug that set the crawl_state.type would cause it to not show up on the scoreboard or if it's unaffected by it? 16:33:19 The game still shows up as a "Custom game" when I do ?V and when i log back in 17:00:50 actually, I ran into one issue with how my refactoring works 17:00:50 you can only format a cell based on its own data 17:01:00 which is a problem in the case you want to add a game link to the score column, because that requires the name, src and end date 17:01:35 i have a few options for fixing this, I thought about it a lot last night but couldn't pick the better approach 17:01:40 will chat more soon 17:03:09 alexjurkiewicz: mysql's json functions to the rescue here 17:03:37 I've been adding columns to the relevant views that package all the needed info 17:04:05 The only tricky one is streaks 17:20:26 shummie I'm afraid it will mess up which scoreboard it shows up in 17:20:30 is it on cko? 17:20:37 Yes 17:20:57 trunk or 0.25? 17:21:03 I hadn't decided if I should quit the game or not. Playing Op's aren't exactly my favorite thing but i don't want to go through w/ it if it's not going to show up 17:21:06 trunk 17:21:11 let me check something re quitting 17:21:32 ok thanks! 17:26:28 shummie: I'm pretty certain that no milestones ever showed up in the regular milestones file so there are no repercussions in terms of score or sequell for quitting 17:26:45 if there had been I could have tried to fix the game, but maybe that's not needed 17:27:29 well, eventually there may be a scoreboard for seeded games, so you would have a quit on that in that hypothetical future 17:28:31 so that means there's no reason to continue the game since it won't show up in the scoreboard right? 17:28:36 yeah 17:28:38 -!- jfcaron_ is now known as jfcaron 17:28:39 or sequell 17:28:57 milestones from now on definitely won't but I was worried there would have been a game start milestone 17:29:14 well, i was playing on shummie007 17:29:20 yeah, I found 17:29:22 and the game got upgraded to that one 17:29:22 ok 17:29:29 hm 17:29:36 ok let me double check then... 17:29:50 actually can you just link to your morgue so I make sure I am checking the right game? 17:30:00 https://crawl.kelbi.org/crawl/morgue/shummie007/shummie007.txt 17:30:19 This is Dungeon Crawl Stone Soup 0.26-a0-61-g6c07f0ee8d 17:30:23 * Milestones 17:30:24 That's the ?V shows as well 17:31:17 ok yeah I should try to fix that game 17:32:04 should i quit the game first so that there's no milestone for that either? 17:34:53 oh I'm looking at the wrong milestones file, no wonder I didn't see it 17:34:58 don't quit 17:35:04 do you know how to do a save backup? 17:35:18 i saw the instructions somewhere... let me see if ic an find it again 17:35:21 I can probably try to get it from floraline if not 17:36:07 https://crawl.develz.org/wiki/doku.php?id=mantis:savebackup 17:37:31 well, to be clear, the consequences for quitting are that you will have some milestones for the game whenever sequell comes back up, and it will show (by some ways of accounting) as an incomplete game forever. Quitting will not show up in any of the regular scoreboards, won't break streaks. Though the existence of milestones could cause problems with a streak in progress if you have one (looks like not?) 17:38:21 what I will do with a save backup is edit it so that its game type is not seeded, and request that floraline replace your save with the fixed one, and then you can continue the game as-is 17:39:22 http://crawl.kelbi.org/saves/shummie007-crawl-git-6c07f0ee8d-200608-2139.tar.bz2 17:39:22 I'm happy to do that 17:39:22 hopefully i did it right 17:39:22 Thank you very much :) 17:39:34 of course, watch me kill the guy 2 minutes after you fix it, but that's dcss for ya =D 17:40:52 yes, that worked 17:43:05 thanks again, i know that's the risk of playing on trunk, just usually not completely game ending =D 17:54:24 lol I kept editing this and being like why isn't it working???? but I'd actually forgotten to pull and recompile after your bugfix 17:58:57 floraline: when you have a sec could you replace a trunk save for shummie007 on which I've fixed a bad trunk bug? 17:59:40 ??bad bugs 17:59:40 thanks again! 17:59:49 oh right, no sequell 18:00:03 I guess I can escape having my first(?) entry in bad/epic bugs :D 18:00:14 we do already have the xom one which was similar 18:00:17 lol 18:00:43 shummie may take a bit for floraline to be around 18:00:51 No worries, I won't be playing for a few hrs anyway 18:01:20 I only noticed it because i was like, why am i able to see my game seed when i logged in 18:01:20 and saw the commit on github 18:01:20 yeah...thanks again for spotting it so quickly 18:01:41 luckily it only rolled out to cko, that would have been ...unfortunate if it had been wider 18:01:44 my only code contribution to dcss =) 18:01:54 heh 18:01:59 you probably will get a credits entry for that 18:02:11 lol 18:19:45 ok alexjurkiewicz advil I've ordered the remaining todo cards in a "rough priority to make sure we can launch friday" order 18:20:14 imo everything down to the "whereis table" entry is "should do", and everything down to updating the blacklist is "must do" 18:23:35 Unstable branch on underhound.eu updated to: 0.26-a0-61-g6c07f0ee8d (34) 18:39:57 advil: sure, where's the file? it is a trunk game right? 18:56:21 ebering: great, thanks 18:57:19 ebering: one question from reddit: are banner scores cumulative? (eg do you get 4+2+1 for tier 3)? The rules are ambiguous 18:57:55 or perhaps the rules standard allows for undefined behaviour by the tourney implementation :) 19:19:31 ebering: the clan name conduct rules could be construed as forbidding BLACK LIVES MATTER clan names, which is arguably an advertisement for unrelated content 19:20:05 just saw the second half of that commit :) :) 19:22:25 alexjurkiewicz: re banners, they are not currently cumulative, the wording neeeds disambiguation 19:23:02 alexjurkiewicz: re conduct I guess a deftly applied "commercial" or similar is needed 19:24:55 ok, I'll add. I expect there to be some attempts to game this rule regardless of its wording 19:25:16 I'm pretty sick of people who bad faith rules lawyer to advance icky causes 19:25:35 I have no problem telling them "you're awful get stuffed" 19:25:49 about clan names. After the refactor, I think it's best to stick with the legacy approach of using team captain name in most places. Using team name consistently is a little too big a project for this tourney, I think 19:26:26 it's just in the columns in the ranking table right? 19:26:37 that's ez.pz. within your current framework 19:26:52 by just making the query return a json object or array specifyingn name/owner pairs 19:27:00 so the link can work w/a transform function 19:27:20 hm! I saw you mention that before but I didn't think much about it. It sounds plausible. I'll see what I can do 19:27:45 look at what I did with adding morgue links and displaying combo high scores /nemelex combos on the ranking pages 19:29:34 I'm going to use some similar trickery with streaks 19:29:58 which I thought was a headache but just caching the full streak data as a json object in the streak cache table is easy 20:12:52 shummie: save file was copied 20:15:24 Thank you! 20:22:12 Stable (0.25) branch on underhound.eu updated to: 0.25-b1-46-gb8a1ec05df 20:24:26 Err: 1994, type: 20:24:29 getting a lot of these from taildb 20:24:43 er, ah! 20:24:47 that's my debugging code on that error 20:25:01 seems I am still getting that string conversion error 20:25:06 perhaps latest code will fix this? 20:31:34 the one you posted about a couple of days ago? it should be fixed with the merge of my big rewrite I posted overnight (it's merged to new-scoring) 20:44:57 I got an interesting new exception just now about AttributeError: 'module' object has no attribute 'category_table' 20:45:05 but let me just fetch the latest code and rerun 20:46:27 nothing like big refactors three days out 20:57:45 ebering: idea for wu jian banner: collect a rune within N turns of entering its run branch 20:58:16 Tier 1: 66% of recent games would do it, Tier 2: 20% of recent games, Tier 3: 5% of recent games 20:59:29 unfortunately that's a bit too lock-step with just low turncount 20:59:59 you might be able to get at something slightly different if you did 21:00:09 well 21:00:29 it's still quite similar but if you really want to amp up the "get this thing fast" thing in a way that's slightly more distinctive 21:00:40 get a rune within N turns of entering the rune branch level 21:00:47 it's also a little cheesable, with both entering an S branch at XL 27 and going for the abyssal rune 21:00:48 some ways to differentiate it a bit: be specific 21:01:16 N turns of entering any rune branch level, N turns of entering vaults:5, N turns of entering zot:5 (for the orb) 21:01:28 last one was a bit of a cheevo some people tracked 21:02:15 that sort of matches Uskayaw's banners about getting to certain places within N turns 21:02:57 er 21:02:57 to be clear 21:02:57 that should be "get Foo within N turns of arrive at the branch end level containing Foo" 21:03:03 so you don't care about the trip down to the branch end 21:03:06 just what you do at branch end 21:03:14 so how fast can you get the orb upon entering zot:5 21:03:20 oh, interesting 21:03:24 or how fast get silver rune upon entering V:5 21:03:45 could just use specific places, like Tier 1: wherever, Tier 2: Vaults:%, Tier 3: Zot:5 21:03:48 using same cutoff if you like 21:03:59 a few ways you could do it 21:04:05 s/%/5/ 21:04:17 -!- amalloy_ is now known as amalloy 21:04:52 it's going to end up being fairly redundant no matter what you pick, but some specificity for the more interesting places could help 21:05:03 basically asking people to orb ninja 21:05:04 that's a nice idea. You could even use the same number for each tier for aesthetic reasons 21:05:15 yeah, same cutoff 21:05:56 so to make sure I understand you correctly, the tiers are: Collect the {rune,orb} within 1000 turns of entering {any rune branch,Vaults:5,Zot:5}. 21:07:01 well I think 1k is just too generous by far 21:07:33 and for tier 1, I was more envisioning s/any rune branch/any rune branch end level/, but this does overlap with V:5 21:07:35 this mostly overlaps with Okawaru (get score X), and Uskayaw (reach X in Y turns) 21:07:51 yeah always going to be a lot of overlap 21:08:27 oh yes, Tier 1 should only start from the branch end since it's meant to be the easiest 21:09:49 a more reasonable turn cutoff for this might be 270 if you want the cutoff to actually be difficult; the scaling with this is a bit weird though, since tier 1 and 2 and 3 are actually close in terms of difficulty 21:09:58 perhaps different cutoffs for different tiers would be good 21:10:18 so you increase depth of the challenge and decrease available turns simultaneously 21:10:33 Another approach, based on your suggestions: Get 2 runes within 1000 turns of entering either rune branch's final level. 21:11:35 that doesn't seem to offer any new gameplay above just asking for a fast dive 21:12:25 I was thinking it lets you scale the tiers better. Change 2 -> 3 -> 4 for each tier 21:12:57 travel between branches sort of ruins it though... 21:13:23 sort of, but as you scale it you're just getting closer to "play for good turncount" 21:13:58 yeah. That's true. OK, I'm done brainstorming this. Detritus for ebering to sift through! 21:14:10 we tried, it's his fault 21:17:58 "Wu Jian Council is still bikeshedding their banner, and thus it is not ready in time for this tournament." 21:18:30 just have a blank and let people write in their own points they feel they deserve 21:23:15 you get one point per friend referred to DCSS 22:23:32 ebering: what do you think about this view for combo high score details: https://imgur.com/a/upbo4yy 22:23:43 (one per line) 22:24:17 (I also wonder about removing the numeric columns entirely) 22:40:59 I'll commit it. You can back out if you prefer 22:48:47 alexjurkiewicz: let me know when you do as I'm about to do another restart of scripts after recent changes 22:49:00 unless this is in a branch 22:49:08 *another branch 22:50:24 hmm, i'll do a big push later today, in my evening 22:51:15 no problem 22:52:16 running now so we can see latest changes and if those errors go away 22:53:03 of course I have to keep moving the test tournament dates forward so it doesn't have so much data that it takes hours to process the first time 22:53:03 which can make catching these bugs a bit of a problem in the first place 22:55:09 fair enough, pushed now 22:56:07 I think either combo scoring is wrong or I don't understand it. In my test data, someone has a single eligible game: `HOFi (HO high score)` (it's not a win) and they have 4 points total 22:56:35 my counting is: 1 point for combo high score, 5 points for HO high score = 6 22:57:02 https://crawl.develz.org/tournament/0.25/overview.html is updated 22:57:22 ah. Possibly it's "1 point for getting a combo high score, +1 point if it's a win, +3 points if it's a species high score" 22:58:39 alexjurkiewicz: where's the original image for https://crawl.develz.org/tournament/0.25/images/clan/winning.png ? 22:58:42 haven't seen that one 22:59:47 that's a newish one from dcss-kimchi fork 22:59:54 https://github.com/kimjoy2002/crawl/pull/109 23:00:06 COUNT(*) + SUM(c.killertype='winning') 23:00:08 + 3 * COUNT(sp.raceabbr) + 3 * COUNT(cl.class) AS total, 23:00:08 alexjurkiewicz: not sure if you've fixed this, but the numeric column alignment for Recent Games is still off; looks like 0 is correctly right-aligned, but non-zero values are left-aligned? 23:00:36 The Score column is what I'm talking about 23:01:11 alexjurkiewicz: oh, heh, you should probably use the scarf-free version of that image! 23:01:22 I can make that change 23:04:04 ha ok thanks 23:04:04 before you commit it, please crush the image 23:04:04 pngcrush -ow -brute in.png && advpng -z4 in.png 23:04:24 if it's large (>100kb) I also used `pngquant 64 in.png` before these steps 23:04:46 (pngquant will create in-fs8.png, which I would compare with the original to make sure the degradation was not too bad) 23:15:04 gammafunk: i see the issue about score alignment 23:15:17 i will make sure it's fixed as part of the transition to datatables 23:15:28 gotta fix that fugly all-players page first 23:57:52 thanks floraline!