00:48:23 alexjurkiewicz: Some changes I had to make to loaddb.py on CDO to get to the connection stage; seems certain args and exceptions you're using with MySQLdb are not current or somehow different http://dpaste.com/2Y9WD38 00:48:33 we have v1.2.3 of the module fwiw 00:49:07 shows username, password, and socket path are fake, but just to show you that we need different versions of those keys/values 00:49:50 specifically the password args is 'passwd', we have a different username that has to be accounted for (probably as a new argument), and a path to a unix socket that likewise should probably be a new argument 00:52:22 and for the password, I don't like specifying it on the command-line given the user configuration on CDO 00:59:30 whmm 01:00:54 not sure what's up with that. There are about four different mysql modules for python2, all with their own pros and cons but basically compatible 01:01:15 after this tourney, we can move to py3 for th enext one which has an official module provided by mysql 01:09:01 alexjurkiewicz: do those modifications break things for your testing? 01:09:14 the exceptions being in a different location doesn't jive with the current documentation for that module 01:09:34 so I wasn't sure where you were getting those locations; normally I'd assume you're using a more current version of the module than CDO 01:09:40 maybe in the current one they're in both locations? 01:09:49 likewise with the args being different 01:21:38 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-3177-gbaa60938a7 01:38:42 Unstable branch on crawl.develz.org updated to: 0.26-a0-42-g4f279345d9 (34) 01:43:38 i suspect the module on cdo is not mysqlclient 01:44:11 it's MySQLdb or pymysql or something else 01:46:20 it looks like in mysqlclient, both MySQLdb._exceptions.OperationalError and MySQLdb.OperationalError exist 01:46:43 alexjurkiewicz: well the docs for mysqlclient don't refer to the former, only the latter 01:47:49 in mysqlclient's ./connections.py, it mentions `:param str passwd: alias of password, for backward compatibility` 01:48:26 yeah, that confused me; the docs for mysqlclient don't even say what those standard args are 01:48:32 so I think it's fine to commit your tweaks. I'm not sure about specifying both host and unix_socket in the connection args, it seems easier to always specify a host and never a socket path. But I'm not sure how cdo is set up 01:48:57 right. It's a poorly documented mish mash of the Python PEP that specifies a standard DB interface and "what MySQLdb does" 01:49:23 welp, there's another problem 01:49:35 I'll paste it here in case you have any ideas, but I've also shown it to Napkin 01:50:30 i'm starting to think it might be easier to run the tourney by spinning up a new server somewhere 01:51:04 _mysql_exceptions.OperationalError: (2059, "Authentication plugin 'caching_sha2_password' cannot be loaded: /usr/lib/mysql/plugin/caching_sha2_passwor 01:51:07 d.so: cannot open shared object file: No such file or directory") 01:51:51 well, if it's a simple fix, then we're probably good to go 01:51:51 aha. That's because the client wasn't built for mysql 8. You can either use a client compiled against mysql 8, or change the options mysqld runs with 01:51:58 hrm, well this was the client installed from mysql 8 I think 01:52:04 In docker-compose.yml, I chose to run mysqld with --default-authentication-plugin=mysql_native_password 01:52:21 /home/services/crawl/mysql/mysql-8.0.20-linux-glibc2.12-x86_64//bin/mysql Ver 8.0.20 for Linux on x86_64 (MySQL Community Server - GPL) 01:52:45 oh 01:52:51 hrm, I think I can even restart it 01:53:02 since it's running as my login, I'll give that a shot 01:53:22 from memory there is some way to set the password of an account to use a non-default auth method. But I'm not sure if that will prevent the client trying to load the default plugin 01:56:14 alexjurkiewicz: if I restart mysqld that way do I need to change the client connection code in any way? 01:56:42 nope 02:01:59 napkin has this set up so we can easilly restart this 02:10:13 good commit to make the config variable logic saner 02:11:19 Windows builds of master branch on crawl.develz.org updated to: 0.26-a0-42-g4f279345d9 02:12:35 yeah wish I could have done something more; had a grand scheme for config reform, and saw that doing so would probably cause more trouble than we want this close to t 02:12:40 but post t can work on that 02:12:44 or at very least before next one 02:21:28 hrm, having a hard time getting this authentication plugin thing to work 02:23:20 not liking the command line option? 02:23:33 you can also add to the my.cnf file somewhere. Probably in a section called [mysqld] 02:26:12 I tried to add it to the mysqld config, maybe that was my mistake 02:26:28 I just altered the user table to update the password type though, seems to be working 02:27:23 it has fetched and seeked the cpo test data 02:27:31 now nothing which is a bit unusual 02:32:03 yeah, it's printed nothing past seeking to those offsets 02:32:55 might have to have another look at this tomorrow 02:38:30 guess I'll leave it running in tmux, but not sure what it's doing right now 02:41:23 you might want to peek at the mysql processlist 02:46:55 | 16 | root | localhost | tournament | Query | 0 | waiting for handler commit | COMMIT | 02:47:41 when I ^C-ed it before, seemed it was in the middle of processing a line, since the traceback showed it 02:47:51 but not getting those "processed N lines" messages at all 02:51:09 seems ok 02:51:14 maybe it's just very slow 02:51:51 I guess I'll let it run overnight 02:58:35 oh, there it goes, processing 3000 lines 02:58:48 how many lines in total? 02:59:35 hrm, this does not look good 03:00:16 10 minutes for 3k lines maybe? 86k lines total 03:00:43 !calc 10.0 * 86.0 / 3.0 / 60.0 03:00:44 4.78 03:00:52 about 5 hours to run through this 03:01:16 maybe it will be less when it gets done with lines not in the tournament range 03:01:40 this might be about the speed of the old scripts anyhow 03:32:13 Unstable branch on crawl.kelbi.org updated to: 0.26-a0-42-g4f279345d9 (34) 03:48:22 Fork (bcadrencrawl) on crawl.kelbi.org updated to: 0.22.1-2768-gde6bd13a31 04:11:40 oh, that test run just finished! (some time ago, not sure when) 04:15:11 alexjurkiewicz: advil: ebering: Test page on CDO with ebering's test data set: https://crawl.develz.org/tournament/0.25/ 05:59:49 -!- amalloy is now known as amalloy_ 06:00:09 it will skip a lot of lines that aren't in the valid time period 06:05:29 hm. Dang. Looks like there's a visual bug in Chrome for banner images 06:13:41 -!- amalloy_ is now known as amalloy 06:27:18 pushed a fix 07:00:54 mkonji (L21 MfIE) Crash caused by signal #6: Aborted (Vaults:2) 09:43:19 fwiw I'm not mainly testing in docker (it's v slow) 09:43:28 but I guess I can handle setting an environment variable 09:59:31 ok, i haven't played in a handful of days, so kelbi's doing "the thing" again 10:00:36 which is? :-) 10:00:40 (the thing, for folks just tuning in, is staying on a Loading... splash screen indefinitely.) 10:01:21 i assume browser cache troubles? using firefox 76.0.1, with ublock origin but it's disabled on kelbi 10:02:17 are you loading a save or starting a new game? 10:02:20 loading a save 10:02:31 and i went directly to https://crawl.kelbi.org/#play-dcss-git , no lobby 10:02:52 did you transfer versions? 10:03:03 if i refresh the page, it'll load lickety-split, but it seems likely that it'll stay here forever if i don't 10:03:07 haven't gotten the option yet 10:03:17 hm that happens before the splash screen 10:03:34 does your browser console say anything suspicious? 10:04:20 https://imgur.com/X3KmoQC.png 10:05:11 lol 10:05:15 there appear to be problems 10:05:21 those aren't crawl though fwiw 10:06:48 * cebolla shrugs 10:07:01 well, if it's only affecting me, at least i know a fix 10:07:11 are you sure that that was console from the right browser window? 10:07:48 there should be some GET messages for cko 10:07:48 here's what it should look like for firefox: https://www.dropbox.com/s/6pqkw0uf39pjc77/Screenshot%202020-06-01%2010.07.33.png?dl=0 10:08:09 all of those look browser-dependent 10:08:57 oh, there's two different consoles 10:09:06 yeah, it's specific to the tab 10:09:21 it does look like from those messages like you have one or more broken extensions 10:09:45 this, perhaps, is the console you meant https://imgur.com/6s6XXpW.png 10:11:13 that looks more like it 10:13:30 03Aidan Holm02 07[main-prev-cmd] * 0.26-a0-41-gdca7373: Fix anti-reckless-fighting command 10(2 days ago, 2 files, 11+ 5-) 13https://github.com/crawl/crawl/commit/dca73732ef39 10:13:54 it does appear likely to be some sort of caching issue, not something I've seen before 10:14:17 floraline any ideas? ^ 10:14:20 cebolla: any corresponding 404 entries in the network tab? 10:14:25 oh, maybe since it's mentioning cookies, i don't think i accept 3rd party cookies 10:14:40 the cookie warning is expected, more or less 10:15:19 aidanh: • Perform a request orthe page to see detailed information about network activity. (but i'm pretty sure if i refresh the page, the problem will go away, so...) 10:15:49 ah; can you reproduce the issue by restarting the browser or something? 10:16:48 what happens if you open this url: https://crawl.kelbi.org/gamedata/4607be7d96ffc7e6dd3e485ae21e5491846fff39/tileinfo-player.js 10:17:22 there could also be an observer effect with having the dev console open, that will disable caching by default 10:18:30 it shouldn't by default, unless you've previously fiddled with your cache settings 10:19:47 is it a huge deal if webtiles shows single-tile flashes as full-screen flashes? 10:22:31 ah, restarted the whole browser and it loaded fine 10:22:35 well, it's a persistent setting so it's possible I did disable it at some point 10:23:06 re flash which flash effects do you have in mind? 10:24:43 New branch created: pull/1441 (1 commit) 13https://github.com/crawl/crawl/pull/1441 10:24:43 03RojjaCebolla02 {GitHub} 07https://github.com/crawl/crawl/pull/1441 * 0.26-a0-43-g5297785: Make necro a major sac, and charm a moderate sac 10(4 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/52977857722d 10:29:00 !source flash_monster_colour 10:29:06 1/1. https://github.com/crawl/crawl/blob/master/crawl-ref/source/view.cc#L944 10:29:34 there's a bunch of (weirdly inconsistent) places that's used 10:30:25 Build failed for main-prev-cmd @ dca73732 https://github.com/crawl/crawl/actions/runs/121527033 (failed: Catch2/codecov) 10:30:50 e.g. death knights will flash red when something else attacks you and they mirror the injury (i think) but not when they mirror your attack against them 10:31:12 that one seems reasonable, I guess it is already a full screen flash in console since I recognize the cases 10:32:15 huh, i didn't test it in console at all; so it's busted on all three platforms 10:33:42 going by memory at least 10:34:40 can't swear that I'm correct 10:39:59 if it doesn't work at all i'd probably prefer to just remove it entirely 10:40:15 er, replace it with full-screen flashes on all platforms 10:42:15 03Aidan Holm02 07[main-prev-cmd] * 0.26-a0-41-ga8ad25f: Fix anti-reckless-fighting command 10(2 days ago, 3 files, 12+ 6-) 13https://github.com/crawl/crawl/commit/a8ad25f1d618 10:50:59 The build is still failing. (main-prev-cmd - dca7373 #13553 : Aidan Holm): https://travis-ci.org/crawl/crawl/builds/693472084 10:55:15 advil: are you sure it works at all? I just tried and it doesn't seem to flash anything 10:55:46 er, well, you did say going by memory, so disregard that question :) 10:56:11 did you try a webtiles build? 10:58:18 well, I just tested and fannar definitely causes a flash in regular local console 10:59:11 I'm not sure exactly what the animation is without doing something to slow it down but it causes a change of color in los at least 10:59:48 this was on console; webtiles only supports full-screen flash, but i'll give it a go anyway 11:00:10 from a quick grep, i'd guess fannar's flash happens via _cast_los_attack_spell 11:00:21 !source spl-damage.cc:623 11:00:22 https://github.com/crawl/crawl/blob/master/crawl-ref/source/spl-damage.cc#L623 11:01:45 ah 11:02:07 ok, so I'm probably mixing up different flashes 11:02:18 er, make that line 635 11:02:35 yeah; the one i mean is a single tile flash that only affects the monster glyph 11:03:55 death knights change color with injury mirror up 11:04:42 they do; that's not the flash effect i mean though 11:05:55 i reckon i'll just remove it for now, and leave my fix in a branch if anyone wants to add it back once webtiles works 11:06:28 oh I wasn't testing the correct case 11:06:54 this is when the player has injury mirror 11:08:37 still no flash for me 11:10:14 yeah, I set the delay to 1s and it definitely does the delay, but with no visual effect 11:10:53 this probably did work at one time so I assume there was a regression 11:11:16 heh, well, it never worked on local tiles, so as far as i'm concerned it never worked at all :) 11:11:54 i didn't go spelunking too deeply but i think it was probably broken from the start 11:19:52 <|amethyst> hm, view_update_at looks kind of like it explicitly doesn't use the flash colour when drawing non-firewood monsters 11:22:51 i want to remove that function 11:26:06 <|amethyst> hm, though testing in wizmode (console on a webtiles build), I don't see the flash even when damaging a "plant perm_ench:mirror_dam" 11:28:56 New branch created: remove-flash-monster (1 commit) 13https://github.com/crawl/crawl/tree/remove-flash-monster 11:28:56 03Aidan Holm02 07[remove-flash-monster] * 0.26-a0-41-g1c92bf4: Remove broken flash_monster_colour() function 10(7 minutes ago, 5 files, 0+ 43-) 13https://github.com/crawl/crawl/commit/1c92bf4d5308 11:29:27 <|amethyst> oh, I see now, it's supposed to be the player (or the thing that took the reflected damage, anyway) that flashes in this case 11:29:53 <|amethyst> but it's still not working, even with use_fake_cursor and use_fake_player_cursor turned off 11:34:51 |amethyst: it only ever flashes if the player is the defender, not the attacker 11:35:38 <|amethyst> oh, I see 11:35:55 <|amethyst> when I first read that if I was confused about att vs def 11:36:55 <|amethyst> and then once I figured out my confusion I didn't re-read the condition 11:37:13 it doesn't work on master, but it does work on view-flash-tile for console builds if you want to try it 11:37:22 changing the delay to 1000ms was useful for seeing when it was supposed to be flashing 11:38:00 i also patched flash_monster_colour(reflector, RED, 200); in for when the attacker is the player 11:43:26 The build was fixed. (main-prev-cmd - a8ad25f #13555 : Aidan Holm): https://travis-ci.org/crawl/crawl/builds/693481442 11:46:01 03Aidan Holm02 07* 0.26-a0-43-g20b394c: Fix anti-reckless-fighting command 10(2 days ago, 3 files, 12+ 6-) 13https://github.com/crawl/crawl/commit/20b394cb32af 12:20:06 The build passed. (remove-flash-monster - 1c92bf4 #13556 : Aidan Holm): https://travis-ci.org/crawl/crawl/builds/693498788 12:49:15 advil: oh, sorry about flipping the env variable if you're using LOCAL_TEST, after ebering said he wasn't using it I assumed no one was 13:08:48 Unstable branch on crawl.akrasiac.org updated to: 0.26-a0-43-g20b394c (34) 13:14:48 it's not a big deal 13:16:48 having some trouble getting my head around the things I would need to understand to make substantive changes 13:31:03 -!- amalloy is now known as amalloy_ 13:42:00 hm, just out of curiosity, does every crawl bundle on CAO et al include a 16mb changelog? 13:43:53 they're using up around 35% of disk space on one of my test servers 13:46:03 i guess these may possibly be for in-game changelog viewing 13:50:15 aidanh: I think so, since you can read the changelog in-game via ? 14:03:10 right; I guess I didn't expect them to be that large 14:19:03 yes, but this is still fractional compared to the overall disk size 14:22:18 all crawl version (348 trunk versions, 15 stable versions) take up 36G, morgue/ttyrec data takes up around 900G 14:22:33 er, 16 stable versions 14:23:20 ugh, it's back at 99% so I am going to have to do some cleanup some time this week 14:24:20 exit 14:24:20 clear 14:24:20 oh crap 14:24:20 this isn't a terminal 14:24:20 :) 14:25:56 whoa there's a 1G core file on here 14:26:09 several actually 14:26:19 I wonder if that's that weird out of memory crash we were seeing 14:26:52 so that got back 1% of disk spade :D 14:26:55 *space 14:33:49 actually here's another way of putting it into perspective: each crawl binary on CAO is >200M 14:33:52 (is that normal?) 14:39:26 -rwxr-xr-x 1 root root 186M May 29 23:04 usr/games/crawl-git-3b0944aac6 14:39:29 So it would seem 14:39:39 if it has symbols, then yes 14:40:03 stripping them does a fair amount, down to 12M, so I may do that on older trunk binaries 15:18:42 they're not important? (the symbols) 15:19:24 they're important for looking at crashlogs 15:19:24 but most old trunk versions have something like 1-5 games parked on them 15:19:30 some of these are form 0.23 :D 15:19:33 *from 15:33:20 huh, rcfiles are as much as 1.1G per version? 15:33:40 looks like it's mostly old versions that are bad 15:43:17 so it looks like if I just delete all the stock rc files, the server will handle recreating them just fine on starting a game 16:12:52 !tell floraline Delete Agramon's BcadrenCrawl save. Not sure what happened to it; it may even be (a/an old) mainline error, but I can't fix it (at least not quickly). Crashes on load due to corrupt monster data and it's not going across versions with monster changes so it's not a save compat issue thus; no clue. 16:13:17 Bcadren: OK, I'll let floraline know. 17:10:10 Bcadren: done 17:10:10 floraline: You have 1 message. Use !messages to read it. 18:05:23 -!- krator44-- is now known as krator44 18:22:55 Unstable branch on underhound.eu updated to: 0.26-a0-43-g20b394cb32 (34) 19:08:13 cebolla: btw I have seen the loading... issue you describe and worked around it the same way. It seems like there is some race condition in how assets are loaded 19:08:22 but I couldn't really find it 19:09:35 advil: you can also upx pack old binaries to get them down to 7-8mb 19:17:47 NeAGen181 (L25 HOFi) ERROR in 'mon-util.cc' at line 675: bogus mc (no monster data): invalid monster_type 1000 (1000) (Depths:3) 19:19:29 should the tournament website be announced so people can see the new rules? 19:19:38 maybe a sticky post on /r/dcss 20:11:05 people don't use marquee enough anymore 20:11:43 the 0.25 tournament page says 0.24 in the top left corner 20:41:00 -!- amalloy_ is now known as amalloy 21:27:48 is there any reason why trunk saves aren't force-transferred? 22:13:58 the dgamelaunch-config system is setup to gracefull handle a case where save transfer to a newer trunk version fails 22:14:06 aidanh: I'm not sure about the historical decision for implementing transfer choice, but CPO and CKO both force transfer, I believe 22:14:16 I've railed against it for years because it a) never happens and b) results in heaps of old versions sticking around 22:14:28 I think the intent was to allow choice 22:14:50 and yeah, CPO force upgrades everyone. If trunk ever breaks save compat, I'll delete all existing save games at that boundary 22:14:50 like if graceful fallback was a concern, they'd have just done that and not implemented the sort of CGI thing that presents the prompt 22:15:12 probably to allow trunk players to not transfer into a somewhat broken game when big changes drop 22:15:38 because big changes do happen reasonably often that makes your in-progress game a lot less playable 22:15:42 e.g. new new new nemelex 22:15:48 suddenly all your decks poof 22:16:37 it seems to me that the dgamelaunch people generally liked the challenge of extending functionality of those scripts, so if they could implement it, they did 22:17:08 I'm not a server admin, but force transfers certainly make a lot of sense to me from a maintenance perspective 22:17:24 from a player perspective of one who closely follows trunk, transfer choice is nice though 22:18:26 not sure if the commit history of dgamelaunch-config reveals the motivation for that 22:18:26 it might be in the commit history 22:50:20 is there anything I can do to help with running the tourney? I would love to help get the rules page published and announced today 23:01:11 alexjurkiewicz: did you not see the link I posted earlier? 23:01:25 https://crawl.develz.org/tournament/0.25/ 23:01:35 I set it up and was published yesterday 23:02:33 I am going to push some fixes for CDO and restart it using current 0.25 sources so we can monitor how it performs with live games 23:02:33 and I will make a wordpress post after that 23:03:08 oh looks like we missed a 0.24 reference in the config somewhere but I can fix that; maybe that one is dynamically loaded from the data (which still has 0.24 for the test) 23:12:45 the 0.24 is in scoring_data.py i think. Although it should be 0.25 23:13:36 yeah, I'll be updating that locally for cdo 23:14:43 also, if you're not aware, the final date for the tournament was announced in the last wordpress post I made 23:15:20 ??tournament 23:15:20 tournament[1/3]: The 0.24 tournament will run from 20:00 UTC Friday 25 October through 20:00 UTC Sunday 10 November. Tournament page: https://crawl.develz.org/tournament/0.24/ 23:15:25 ??tournament[2 23:15:25 tournament[2/3]: See {past tournaments} for links to previous tournaments. 23:16:09 !learn add past_tournaments[1] The 0.24 tournament will ran from 20:00 UTC Friday 25 October through 20:00 UTC Sunday 10 November. Tournament page: https://crawl.develz.org/tournament/0.24/ 23:16:15 oops 23:16:17 past tournaments[1/9]: The 0.24 tournament will ran from 20:00 UTC Friday 25 October through 20:00 UTC Sunday 10 November. Tournament page: https://crawl.develz.org/tournament/0.24/ 23:16:27 !learn edit past_tournaments[1] s/will ran/ran/ 23:16:27 past tournaments[1/9]: The 0.24 tournament ran from 20:00 UTC Friday 25 October through 20:00 UTC Sunday 10 November. Tournament page: https://crawl.develz.org/tournament/0.24/ 23:18:00 !learn set tournament[1] The 0.25 tournament will run from 20:00 UTC Friday 5 June through 20:00 UTC Sunday 21 June. Tournament page: https://crawl.develz.org/tournament/0.25/ 23:18:06 tournament[1/3]: The 0.25 tournament will run from 20:00 UTC Friday 5 June through 20:00 UTC Sunday 21 June. Tournament page: https://crawl.develz.org/tournament/0.25/ 23:32:06 I think the template is building that header at the top of the page from the data, since yeah it's already 0.25 23:32:32 but I'm updating CDO's test to just use 0.25 games from today until the 4th for 0.25 for servers that have it 23:41:29 gammafunk: thanks for the explanation; I guess I won't be supporting it in my fancy schmancy crawl server docker image then 23:41:29 alexjurkiewicz: did you forget to check in script.js? getting a warning about that file being missing 23:42:02 aidanh: yeah, it's probably not functionality we should retain, I guess, but maybe you'd also want to hear from advil about it 23:42:31 gammafunk: i did! pushed now sorry 23:42:44 pushed now* 23:42:54 ok, will pull and rerun; doing a test run of loaddb.py with the 0.25 test data, which looks like it's proceeding 23:43:02 and will just start up taildb if that goes successfully 23:50:08 nice 23:57:53 alexjurkiewicz: ok, current page with test data that will be updated continuously from now (once I fix some connection args for taildb.py) https://crawl.develz.org/tournament/0.25/overview.html 23:58:02 might have to refresh the pages if you've looked at this, of course 23:58:13 looks like that recent games table has some alignment issues 23:59:43 hrm, taildb seems to be missing the args handling thest loaddb.py has