01:21:17 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-3001-g9d8a61a446 02:45:04 Monster database of master branch on crawl.develz.org updated to: 0.25-a0-651-g8c222c7a2b 03:11:48 Unstable branch on crawl.beRotato.org updated to: 0.25-a0-843-g6944ee3 (34) 07:56:21 03Aidan Holm02 07[remove-old-spells] * 0.25-a0-843-g46eba73: Move SUMMON_SWARM out of removed spells 10(25 hours ago, 4 files, 2+ 7-) 13https://github.com/crawl/crawl/commit/46eba735cd96 07:56:21 03Aidan Holm02 07[remove-old-spells] * 0.25-a0-844-g14d85e1: Extract unmarshall_vehumet_spells() function 10(2 days ago, 3 files, 83+ 23-) 13https://github.com/crawl/crawl/commit/14d85e1ec7f7 07:56:21 03Aidan Holm02 07[remove-old-spells] * 0.25-a0-845-g1717f60: Add removed spells to removed_spells() list. 10(2 days ago, 1 file, 53+ 13-) 13https://github.com/crawl/crawl/commit/1717f6091b9d 07:56:21 03Aidan Holm02 07[remove-old-spells] * 0.25-a0-846-g55f3c40: Remove removed spells from Vehumet's gifts on load 10(2 days ago, 2 files, 38+ 3-) 13https://github.com/crawl/crawl/commit/55f3c40ea06e 07:56:21 03Aidan Holm02 07[remove-old-spells] * 0.25-a0-847-ge0b8bf3: Remove removed spells from monster spellsets 10(27 minutes ago, 1 file, 13+ 27-) 13https://github.com/crawl/crawl/commit/e0b8bf316ac0 07:56:21 03Aidan Holm02 07[remove-old-spells] * 0.25-a0-848-g9a4588a: Extract unmarshall_player_spells() function 10(2 days ago, 2 files, 66+ 30-) 13https://github.com/crawl/crawl/commit/9a4588aa4c11 07:56:21 03Aidan Holm02 07[remove-old-spells] * 0.25-a0-849-gdb56c26: Remove player's removed spells on load 10(2 days ago, 2 files, 63+ 0-) 13https://github.com/crawl/crawl/commit/db56c26990b4 07:56:21 03Aidan Holm02 07[remove-old-spells] * 0.25-a0-850-gfb9d792: Remove dead spell code 10(26 hours ago, 5 files, 11+ 852-) 13https://github.com/crawl/crawl/commit/fb9d792df28b 07:56:21 03Aidan Holm02 07[remove-old-spells] * 0.25-a0-851-g507cc92: Add test cases for unmarshallSpells() 10(2 minutes ago, 2 files, 46+ 2-) 13https://github.com/crawl/crawl/commit/507cc92d2d51 07:56:21 03Aidan Holm02 07[remove-old-spells] * 0.25-a0-852-ge98b40d: Reindent code 10(83 seconds ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/e98b40db8683 07:58:12 :O 08:00:32 hopefully travis is merciful this time 09:01:25 sad, can no longer replicate any unlinked item crashes with hep 09:08:57 03Aidan Holm02 07[remove-old-spells] * 0.25-a0-847-g83d9f5b: Remove removed spells from monster spellsets 10(2 hours ago, 4 files, 29+ 32-) 13https://github.com/crawl/crawl/commit/83d9f5b0c559 09:08:57 03Aidan Holm02 07[remove-old-spells] * 0.25-a0-848-ga45f35d: Extract unmarshall_player_spells() function 10(2 days ago, 2 files, 66+ 30-) 13https://github.com/crawl/crawl/commit/a45f35dec81f 09:08:57 03Aidan Holm02 07[remove-old-spells] * 0.25-a0-849-gd626a7f: Remove player's removed spells on load 10(2 days ago, 2 files, 63+ 0-) 13https://github.com/crawl/crawl/commit/d626a7fd6f1c 09:08:57 03Aidan Holm02 07[remove-old-spells] * 0.25-a0-850-gc85260a: Remove dead spell code 10(28 hours ago, 5 files, 11+ 852-) 13https://github.com/crawl/crawl/commit/c85260a61cdd 09:08:57 03Aidan Holm02 07[remove-old-spells] * 0.25-a0-851-gcdecaf7: Add test cases for unmarshallSpells() 10(74 minutes ago, 2 files, 46+ 2-) 13https://github.com/crawl/crawl/commit/cdecaf71a820 09:08:57 03Aidan Holm02 07[remove-old-spells] * 0.25-a0-852-ge99f43d: Reindent code 10(74 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/e99f43d98c12 09:09:15 i have a patch that stores the minor version in an int instead of a single byte 09:09:35 trouble is, newer games won't be listed at all in older crawl versions 09:10:01 but I think that's probably worth it 09:12:05 what I was considering at one point was keeping the byte, designating 254 or something to mean, "the header has an extra int at the end for the real minor version" 09:13:15 that's exactly what I did 09:13:26 shouldn't that work with the older save browsers then? 09:13:42 !source _read_char_chunk 09:13:43 1/1. https://github.com/crawl/crawl/blob/master/crawl-ref/source/files.cc#L123 09:14:02 uh, not the best line number choice 09:14:54 anyway, old crawl binaries will read the minor int as the len variable, leading to a truncated read 09:15:19 so far that's just resulted in entries not being shown, although I haven't actually checked if other behaviour is possible 09:18:08 if you put it after the length (and then adjust tag_read_char accordingly), that might work better 09:18:54 or after the format 09:19:33 it's a bit tricky but probably doable 09:20:24 I'm not 100% sure if this is worth it tbh 09:21:32 since a byte is apparently something like 8 years 09:22:46 if we break save compat we could just change the format in a more transparent way, and more reasonably ignore older versions (esp. if all that happens is that the save doesn't show up) 09:23:29 * aidanh mutters something about protobufs 09:24:12 i did consider trying to put the minor somewhere else, but it's actually at the start of each chunk 09:24:22 (which seems pretty weird..) 09:24:27 ah right 09:25:35 I think loading a save doesn't necessarily trigger upgrading every chunk immediately 09:25:35 forgot about that 09:28:21 bones files are also handled slightly differently 09:31:02 oh, bones files should probably get a four-byte minor as well 09:31:35 by "I'm not 100% sure if this is worth it tbh", you mean squeezing in the minor after the length somewhere? or widening the minor field at all? 09:32:16 widening the minor field while preserving some form of compatibility 09:33:13 there is another alternative 09:33:23 basically my take when I had that idea was: having it be restricted to a byte is a bit silly so if there's a clean way to widen it it may be worth it, 1 byte is enough for 8-10 years of regular save compat fixes so a byte is enough, breaking save compat may be better 09:37:24 for the chr chunk, we could continue to write a single-byte minor, as long as tag_read_char() does not add any new version-specific changes for minor >= 256 09:40:09 of course, once we run out of minors that prevents updating that function if we absolutely need to 09:40:26 https://xkcd.com/2261/ 09:41:00 maybe we should just break save compat with the 0.26 alpha tag though 09:41:56 i mean... it'd definitely be the easiest solution, but it's not very elegant 09:42:09 breaking save compat? 09:42:22 yeah 09:42:53 I think there's a fundamental problem with long-running save compat in that a game from 0.11 can technically upgrade but is unlikely to be highly playable 09:43:12 so IMO breaking save compat something like every 4-6 releases is ideal 09:43:20 or having something closer to rolling save compat 09:43:25 i'd prefer a rolling model, yeah 09:43:49 which is why it'd be nice to have int minors 09:44:15 ah, so the minors persist but the code goes away after a certain window? 09:45:02 right; you'd probably have TAG_MINOR_FIRST = n, and bump n whenever you remove support for the earliest minor 09:45:02 if that's the goal then IMO we should just upgrade the header format cleanly, it's ok if newer saves don't show in older browsers 09:45:34 yeah that's what I was thinking 09:45:35 we could backport header compatibility code for a few versions even 09:46:04 possible, but is that really necessary? it's not like the games could be opened 09:46:25 well, you seemed worried about it earlier :-) 09:46:45 heh, fair point 09:47:23 windows doesn't usually even have a shared save folder (though maybe people do copy over their saves) 09:47:23 another alternative is to add the code now but set it to start writing minors as ints once we reach minor 255 09:48:13 that would mean that old save browsers would still show new saves 09:48:54 huh, i wonder how windows works then 09:49:12 maybe I don't know exactly how the installer does things 09:49:29 but the zip versions just give you self-contained directories including the save dir 09:50:36 oh i see 10:11:33 why is frenzy implemented with a permanent attitude change? 10:12:34 (probably a rhetorical question) 10:19:49 03Peter Gerlagh02 07https://github.com/crawl/crawl/pull/1369 * 0.25-a0-785-gc9ce714: Finished implementing the new annotation function 10(22 minutes ago, 5 files, 49+ 44-) 13https://github.com/crawl/crawl/commit/c9ce7145742a 10:19:49 03Peter Gerlagh02 07https://github.com/crawl/crawl/pull/1369 * 0.25-a0-786-ga1fc030: Tidying up 10(6 minutes ago, 7 files, 181+ 271-) 13https://github.com/crawl/crawl/commit/a1fc0308f157 10:30:23 I've finished the level annotations pull request, in the sense that I'm happy with the code in it's current state 10:30:42 03Peter Gerlagh02 07https://github.com/crawl/crawl/pull/1369 * 0.25-a0-787-ge6dc51b: Tidying up whitespace 10(2 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/e6dc51bfe172 10:30:53 awesome! i will have a look in a bit 10:31:46 should I tidy it up by merging the commits, and dealing with any merge conflicts with master? 10:32:56 merging commits is preferred, since otherwise you have intermediate commits which won't pass the tests (e.g. whitespace tests) 10:33:17 although it's something we can do ourselves when merging 10:33:48 it's generally a good idea to periodically rebase your branch onto the master branch and resolve merge conflicts as you go 10:57:33 New branch created: wide-minor-tag (1 commit) 13https://github.com/crawl/crawl/tree/wide-minor-tag 10:57:33 03Aidan Holm02 07[wide-minor-tag] * 0.25-a0-843-g4223f9c: Add support for minor tags > 255 10(50 minutes ago, 7 files, 48+ 48-) 13https://github.com/crawl/crawl/commit/4223f9c2549b 11:04:27 03Aidan Holm02 07[wide-minor-tag] * 0.25-a0-843-ga5d6c47: Add support for minor tags > 255 10(57 minutes ago, 7 files, 44+ 43-) 13https://github.com/crawl/crawl/commit/a5d6c47b5812 11:06:16 -!- bh is now known as Guest67469 11:13:30 03Aidan Holm02 07* 0.25-a0-844-ge9745dc: Move SUMMON_SWARM out of removed spells 10(28 hours ago, 4 files, 2+ 7-) 13https://github.com/crawl/crawl/commit/e9745dcf7e48 11:13:30 03Aidan Holm02 07* 0.25-a0-845-g970948c: Extract unmarshall_vehumet_spells() function 10(2 days ago, 3 files, 83+ 23-) 13https://github.com/crawl/crawl/commit/970948ccd0a8 11:13:30 03Aidan Holm02 07* 0.25-a0-846-g3e2dadc: Add removed spells to removed_spells() list. 10(2 days ago, 1 file, 53+ 13-) 13https://github.com/crawl/crawl/commit/3e2dadc45009 11:13:30 03Aidan Holm02 07* 0.25-a0-847-gaa01332: Remove removed spells from Vehumet's gifts on load 10(2 days ago, 2 files, 38+ 3-) 13https://github.com/crawl/crawl/commit/aa01332a3611 11:13:30 03Aidan Holm02 07* 0.25-a0-848-g5c9e5b7: Remove removed spells from monster spellsets 10(4 hours ago, 4 files, 29+ 32-) 13https://github.com/crawl/crawl/commit/5c9e5b7a16e5 11:13:30 03Aidan Holm02 07* 0.25-a0-849-g9d46793: Extract unmarshall_player_spells() function 10(2 days ago, 2 files, 66+ 30-) 13https://github.com/crawl/crawl/commit/9d4679374f88 11:13:30 03Aidan Holm02 07* 0.25-a0-850-g3557bf3: Remove player's removed spells on load 10(2 days ago, 2 files, 63+ 0-) 13https://github.com/crawl/crawl/commit/3557bf33da78 11:13:30 03Aidan Holm02 07* 0.25-a0-851-g4838036: Remove dead spell code 10(30 hours ago, 5 files, 11+ 852-) 13https://github.com/crawl/crawl/commit/4838036f5305 11:13:30 03Aidan Holm02 07* 0.25-a0-852-g97ffa46: Add test cases for unmarshallSpells() 10(3 hours ago, 2 files, 46+ 2-) 13https://github.com/crawl/crawl/commit/97ffa46023db 11:13:30 03Aidan Holm02 07* 0.25-a0-853-g1f535e2: Reindent code 10(3 hours ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/1f535e2ddcf1 11:36:12 03Peter Gerlagh02 07https://github.com/crawl/crawl/pull/1369 * 0.25-a0-788-g55e1b7d: Fix whitespace 10(4 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/55e1b7d4e9bf 11:41:21 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-853-g1f535e2ddc (34) 11:53:34 03advil02 07* 0.25-a0-854-gc06b4bd: Refactor frenzy to use a temporary attitude change 10(46 minutes ago, 3 files, 12+ 6-) 13https://github.com/crawl/crawl/commit/c06b4bd658db 12:03:14 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-854-gc06b4bd658 (34) 12:16:37 Sanddman (L16 DsWz) ASSERT(index != -1) in 'spl-util.cc' at line 892 failed. (D:12) 12:33:36 !crashlog 12:34:02 21891. nano, XL24 SpAs, T:79243 (milestone): https://underhound.eu/crawl/morgue/nano/crash-nano-20200422-223146.txt 12:34:11 !crashlog Sanddman 12:34:17 4. Sanddman, XL17 OgBe, T:24688 (milestone): http://dobrazupa.org/morgue/Sanddman/crash-Sanddman-20140714-105442.txt 12:34:24 The build passed. (wide-minor-tag - a5d6c47 #13118 : Aidan Holm): https://travis-ci.org/crawl/crawl/builds/679428362 12:35:03 https://crawl.kelbi.org/crawl/morgue/Sanddman/crash-Sanddman-20200425-161627.txt 12:35:16 thanks 12:35:55 looks like regen is there somehow 12:36:47 in their spell usage 12:38:11 i wonder what the best solution to this is 12:38:41 logically, it'd be nice if the game recorded that you'd cast regen even if it were removed partway through, but it's still a little weird 12:57:10 perhaps as long as the spell enum is there its name should be kept around as well? 13:00:43 I guess you could do something like print the enum name using macros 13:01:08 i think keeping the spell name around is reasonabble 13:02:34 although i guess this is another thing that makes sense to tie to the minor version 13:04:08 it may be worth temporarily relaxing that ASSERT (and printing "removed" or something) for the time being since this will probably crash on any save or game end for many ongoing characters 13:04:41 since the actions table is default in the morgue 13:05:47 03Aidan Holm02 07* 0.25-a0-855-g681bda5: Add stub entries for removed spells 10(6 minutes ago, 1 file, 59+ 0-) 13https://github.com/crawl/crawl/commit/681bda5bb4d7 13:06:07 no worries, it was easy enough to add back 13:06:19 ah ok 13:07:06 ??rearrange the pieces 13:07:06 rearrange the pieces[1/1]: Xom effect: shuffles positions of you and monsters in LOS randomly. Chance of confusion on any or all of the victims. 13:08:19 rip chaos champions 13:09:19 there's actually a bunch of spell enums that are still missing entries, but I only added back the ones I removed 13:09:44 probably this doesn't come up so much for monster-only spells 13:14:36 true 13:17:54 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-855-g681bda5bb4 (34) 13:29:44 Unstable branch on crawl.akrasiac.org updated to: 0.25-a0-854-gc06b4bd (34) 13:35:15 cao might need a manual rebuild 13:41:55 oh, it must have been in progress 13:42:15 aidanh: do you not have cao rebuild access? 13:43:42 not as far as i know 13:44:13 is your account name there aidanh? 13:45:28 Unstable branch on crawl.akrasiac.org updated to: 0.25-a0-855-g681bda5 (34) 13:46:39 yep 13:47:06 ok, now you have it 13:47:12 that will also let you use wizmode on cao 13:47:56 sweet, thanks 13:48:04 next problem; not sure what the rebuild url is 13:48:28 oh, nvm, it's just the same but without the port 13:48:34 ??rebuild 13:48:34 rebuild[1/2]: http://crawl.akrasiac.org/rebuild/ http://underhound.eu:81/rebuild/ http://crawl.berotato.org/crawl/rebuild/ http://crawl.xtahua.com/rebuild/ https://crawl.kelbi.org/rebuild/ Bug gammafunk, advil, |amethyst, or Nap.Kin for CDO. Use your powers wisely. 13:48:40 I already did a rebuild though 13:49:11 ok, thanks 13:49:40 it uses the same password as your regular account 13:51:43 truncated to 20 chars 14:21:55 Eldritch tentacle timer does not update when player is off level 13https://crawl.develz.org/mantis/view.php?id=12244 by amaril 14:39:43 The build passed. (master - 681bda5 #13122 : Aidan Holm): https://travis-ci.org/crawl/crawl/builds/679462512 18:01:35 -!- aidanh_ is now known as aidanh 18:23:05 Unstable branch on underhound.eu updated to: 0.25-a0-855-g681bda5bb4 (34) 18:56:18 -!- Tuxedo[Qyou] is now known as Tux[Qyou] 19:39:15 hello crawl-dev, is there a particular process for reporting security related bugs/issues? 20:01:26 wow, two in the past few months 20:01:47 best thing would be to message one of the devs, anyone with + before their name 20:07:13 well, probably not anyone, some of the + people are fairly absent 20:11:54 I just created security@dcss.io (may take a few minutes before it even works) 20:12:04 currently just forwards to my own email 20:23:36 cool cool :>, is it alright to send you a report to that email unencrypted? or do you have an RSA public key i should encrypt it first with 20:23:56 unencrypted is fine with me 20:24:02 let met test that email and make sure it works :D 20:24:44 yeah, it seems to 20:32:57 03advil02 {GitHub} 07* 0.25-a0-856-g25f8dcc: Create SECURITY.md 10(11 seconds ago, 1 file, 32+ 0-) 13https://github.com/crawl/crawl/commit/25f8dcc119dc 20:33:45 wonder how much spam I'll get through that 20:35:24 anyone else want to get those emails? 20:35:55 I'd be happy to; not sure if I'd be of much use though! 20:36:14 gammafunk @ gmail? 20:36:18 yep, thanks 20:37:09 perhaps I'll learn vulnerability analysis by reading the security@dcss.io mailing list, much like how I learned C++ by reading the crawl codebase 20:37:22 haha 20:37:28 right now it's just a forward, not a mailing list 20:37:43 my plan is basically to just copy any emails there to some other place where everyone can see it 20:38:48 but that is still private, like the developers team page maybe 20:39:09 it's sort of annoying that github has (afaik) no private issue system even for security reports 20:40:28 does seem like reasonable functionality to have 20:48:00 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-856-g25f8dcc119 (34) 20:51:47 email sent, ty for your time :-) 20:54:14 got it, thanks 20:55:04 (and thanks for the detailed writeup) 20:56:42 hm am I remembering right that we can have private repos now for free? 21:04:14 ok the private issue (visible to people in the developers and serverowners team if I've done it right) is here: https://github.com/crawl/dcss-security/issues/1 21:13:47 i just got an email from this repo, is there any action needed from server ops right now? 21:14:11 no, sorry for any alarm 21:14:20 ok np 21:14:22 I wonder to what degree I just spammed like 30 people by setting that up 21:14:42 i just didn't recognize this lol wasn't sure what it was 21:15:02 basically I just wanted somewhere to post private issues like that 21:15:38 yeah sounds cool, and yeah when microsoft acquired them private repos are just free now for everyone 21:15:43 yep 21:23:21 cool report; I understood a bunch of it, but not all 21:25:35 I finally hit the publish button for https://github.com/crawl/crawl/security/advisories/GHSA-vjrj-g7gf-rgjv while I was at it 21:28:22 boy that list of affected versions does not render properly in my browser 21:28:28 haha nope 21:59:56 !source cluautil.h 21:59:56 https://github.com/crawl/crawl/blob/master/crawl-ref/source/cluautil.h 22:05:49 this stuff is some serious crawlcode 22:17:48 03advil02 {GitHub} 07* 0.25-a0-857-g60a0bcd: Update SECURITY.md 10(10 seconds ago, 1 file, 4+ 0-) 13https://github.com/crawl/crawl/commit/60a0bcd8b506 22:31:43 oh maybe I see 22:31:52 the userdata is just the pointer right now 22:32:59 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-857-g60a0bcd8b5 (34) 23:00:32 New branch created: lua-gc-fix (1 commit) 13https://github.com/crawl/crawl/tree/lua-gc-fix 23:00:32 03advil02 07[lua-gc-fix] * 0.25-a0-857-gec37dad: Guard against repeated calls to lua_object_gc (ruderubik) 10(7 minutes ago, 1 file, 4+ 1-) 13https://github.com/crawl/crawl/commit/ec37dadf1453 23:30:41 ever since catalina, my c++ development life has involved mostly reinstalling xcode and its developer tools 23:30:56 it's enough to make a man dual boot ubuntu 23:45:40 The build passed. (lua-gc-fix - ec37dad #13125 : advil): https://travis-ci.org/crawl/crawl/builds/679590326