00:00:11 <gammafunk> but yeah, this is what dgl servers are using as the basis for their server config, which includes the webtiles config.py
00:00:39 <alexjurkiewicz> it looks like the files for cao aren't up to date, the config.py references 0.21 as latest version
00:01:01 <gammafunk> yes, they make local commits to their checkout of it for tracking purposes, publish those changes into chroot with scripts in that repo
00:01:13 <gammafunk> so right, the public repo doesn't reflect each server's configuration
00:01:22 <gammafunk> since remember each server can have slightly different configurations
00:01:26 <gammafunk> menu-wise, installed version-wise
00:01:54 <gammafunk> but like core changes/improvements to the config.py structure need to go in here somehow
00:01:58 <alexjurkiewicz> tbh, I don't think any changes should be made. Most of the updates to game definitions are to support forks, which aren't supported
00:02:41 <alexjurkiewicz> I'm not sure how banner files are managed now. Clearly CAO has custom banners but they aren't in this repo
00:02:48 <gammafunk> well, like I said, probably doesn't need changing now, but I think it should be updated actually
00:03:06 <gammafunk> dgl would support forks fine, for instance
00:03:10 <gammafunk> cbro cko both have forks
00:03:24 <gammafunk> they are just like custom branches
00:03:50 <gammafunk> maybe we can look at updating this once new changes are rolled out
00:04:30 <gammafunk> and I'm not sure how much aidanh's chroot stuff depends on dgamelaunch-config
00:04:34 <gammafunk> I should check that writeup he made
00:05:03 <gammafunk> man, also need to better organize github wiki
00:05:39 <gammafunk> https://github.com/crawl/crawl/wiki/CPP-17-Upgrade
00:07:36 <alexjurkiewicz> aidanh: how should I run pytest for webserver?
00:08:12 <alexjurkiewicz> oh, just pytest does it
00:10:27 <gammafunk> so his patch changes to config.py in dgamelaunch-config with a diff
00:11:01 <aidanh> the chroot stuff is mostly independent to dgamelaunch-config
00:11:01 <gammafunk> hence yeah, if we merge any changes to config.py there, his upgrade scripts will need updating
00:11:29 <aidanh> alexjurkiewicz: iirc I added a small makefile for that
00:11:37 <alexjurkiewicz> just flake8 & isort
00:12:07 <aidanh> probably tox then
00:12:53 <gammafunk> aidanh: but that's correct that we shouldn't change config.py and other files in that repo?
00:14:39 <aidanh> for the chroot stuff you will need to change a few things in dgamelaunch-config
00:15:05 <aidanh> config.py and the init script, so that python starts in the chroot to begin with
00:15:07 <alexjurkiewicz> i see coverage is enabled in tox -- how do I get coverage data?
00:15:37 <aidanh> and there's also a patch to the build script which runs make in a separate build chroot
00:15:49 <aidanh> iirc those three changes are the only ones
00:16:27 <aidanh> alexjurkiewicz: coverage -m pytest; coverage html
00:16:27 <aidanh> I think
00:18:30 <alexjurkiewicz> coverage run -m pytest && coverage report
00:18:32 <gammafunk> oof
01:03:26 <gammafunk> !source edit_vault
01:03:26 <Sequell> https://github.com/crawl/crawl/blob/master/crawl-ref/source/util/edit_vault
01:03:39 <gammafunk> 1) didn't know someone made this sort of weird hack
01:03:43 <gammafunk> and 2) wow, throwing some shade:
01:03:54 <gammafunk> # You need to define $EDITOR as well; on Debian there's some weak-ass
01:03:54 <gammafunk> # autodetection but that's unlikely to match _your_ preferences. And it
01:03:55 <gammafunk> # may start something as vile as vi.
01:13:41 <alexjurkiewicz> coVId
01:18:11 <gammafunk> no coincidence that the dgl rc editor is called virus
02:10:42 <Gretell> Windows builds of master branch on crawl.develz.org updated to: 0.25-a0-701-gb30f108f01
02:45:06 <Gretell> Monster database of master branch on crawl.develz.org updated to: 0.25-a0-651-g8c222c7a2b
03:11:58 <Rotatell> Unstable branch on crawl.beRotato.org updated to: 0.25-a0-701-gb30f108 (34)
03:30:50 <Kelbell> Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-2999-g24818c1c7b
04:26:30 <Cheibriados> 03Alex Jurkiewicz02 07https://github.com/crawl/crawl/pull/1253 * 0.25-a0-702-g4726372: Fix returning user auto-login 10(47 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/472637230825
04:26:30 <Cheibriados> 03Alex Jurkiewicz02 07https://github.com/crawl/crawl/pull/1253 * 0.25-a0-703-g3245ba2: Simplfy 10(45 minutes ago, 1 file, 3+ 6-) 13https://github.com/crawl/crawl/commit/3245ba2a1c6e
04:26:30 <Cheibriados> 03Alex Jurkiewicz02 07https://github.com/crawl/crawl/pull/1253 * 0.25-a0-704-g1511a29: Improve test coverage of auth.py 10(44 minutes ago, 1 file, 20+ 1-) 13https://github.com/crawl/crawl/commit/1511a296c19d
04:26:30 <Cheibriados> 03Alex Jurkiewicz02 07https://github.com/crawl/crawl/pull/1253 * 0.25-a0-705-g076656d: Add option to disable webtiles access logs 10(41 minutes ago, 2 files, 8+ 2-) 13https://github.com/crawl/crawl/commit/076656d2771f
04:26:30 <Cheibriados> 03Alex Jurkiewicz02 07https://github.com/crawl/crawl/pull/1253 * 0.25-a0-706-g96a638c: Enhancements to webtiles game definitions 10(38 minutes ago, 6 files, 366+ 53-) 13https://github.com/crawl/crawl/commit/96a638c051bc
04:26:30 <Cheibriados> 03Alex Jurkiewicz02 07https://github.com/crawl/crawl/pull/1253 * 0.25-a0-707-g6b134aa: Reduce log spam 10(33 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/6b134aad0ec3
04:26:30 <Cheibriados> 03Alex Jurkiewicz02 07https://github.com/crawl/crawl/pull/1253 * 0.25-a0-708-gab426ef: Convert README to markdown and update 10(33 minutes ago, 2 files, 85+ 49-) 13https://github.com/crawl/crawl/commit/ab426ef2d575
04:26:30 <Cheibriados> 03Alex Jurkiewicz02 07https://github.com/crawl/crawl/pull/1253 * 0.25-a0-709-g9857940: Allow overriding HTML templates 10(30 minutes ago, 11 files, 336+ 336-) 13https://github.com/crawl/crawl/commit/9857940ff050
04:26:30 <Cheibriados> 03Alex Jurkiewicz02 07https://github.com/crawl/crawl/pull/1253 * 0.25-a0-710-ge3ffe06: Remove version pin from Tornado dependency (advil) 10(28 minutes ago, 5 files, 21+ 18-) 13https://github.com/crawl/crawl/commit/e3ffe06f70fb
04:26:30 <Cheibriados> 03Alex Jurkiewicz02 07https://github.com/crawl/crawl/pull/1253 * 0.25-a0-711-gdc16cf4: Improve some webtiles log messages 10(26 minutes ago, 3 files, 16+ 3-) 13https://github.com/crawl/crawl/commit/dc16cf4e355a
04:26:30 <Cheibriados> ... and 5 more commits
04:33:42 <alexjurkiewicz> ❯ make lint
04:33:44 <alexjurkiewicz> flake8 --mypy-config=mypy.ini *.py
04:33:46 <alexjurkiewicz> auth.py:1:1: T499 Success: no issues found in 1 source file
04:33:48 <alexjurkiewicz> userdb.py:1:1: T499 Success: no issues found in 1 source file
04:33:50 <alexjurkiewicz> make: *** [lint] Error 1
04:33:52 <alexjurkiewicz> ❯ echo $?
04:33:54 <alexjurkiewicz> 2
04:33:56 <alexjurkiewicz> aidanh: any idea why exit code is non-zero ^
04:34:49 <aidanh> ugh, yeah, that's some weird bug with that flake8-mypy plugin
04:35:50 <aidanh> is that the powerlevel10k zsh prompt I see?
04:39:16 <aidanh> btw there are a ton of lint errors but I've ignored most of the files, so that we can incrementally fix them
05:09:05 -!- Tiobot is now known as Guest83930
06:59:05 <alexjurkiewicz> yup it is :)
07:23:37 <alexjurkiewicz> should we just switch to running mypy directly?
07:23:43 <alexjurkiewicz> and not include it in flake8 config
07:37:00 <Cheibriados> New branch created: pull/1338 (3 commits) 13https://github.com/crawl/crawl/pull/1338
07:37:00 <Cheibriados> 03Alex Jurkiewicz02 07https://github.com/crawl/crawl/pull/1338 * 0.25-a0-702-g7ecbe29: Add CI for webserver 10(3 hours ago, 1 file, 37+ 0-) 13https://github.com/crawl/crawl/commit/7ecbe2913a77
07:37:00 <Cheibriados> 03Alex Jurkiewicz02 07https://github.com/crawl/crawl/pull/1338 * 0.25-a0-703-g65b6d6d: Fix isort arguments 10(12 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/65b6d6dceffe
07:37:00 <Cheibriados> 03Alex Jurkiewicz02 07https://github.com/crawl/crawl/pull/1338 * 0.25-a0-704-gc62db38: Fix import sorting 10(9 minutes ago, 10 files, 92+ 55-) 13https://github.com/crawl/crawl/commit/c62db387a051
07:37:28 <alexjurkiewicz> I rewrote my original PR to simplify it and pulled out the import sorting to this new PR ^
07:37:36 <alexjurkiewicz> added CI as a bonus
12:05:38 -!- Amnesiac_ is now known as Amnesiac
12:11:20 <Cheibriados> 03ebering02 07* 0.25-a0-702-g2b5350a: Prevent torpor snails from slowing conjurations (12190) 10(6 days ago, 1 file, 2+ 1-) 13https://github.com/crawl/crawl/commit/2b5350a25b66
12:11:20 <Cheibriados> 03ebering02 07* 0.25-a0-703-g3851f72: Refactor and revise monster target acquisition 10(2 hours ago, 1 file, 16+ 20-) 13https://github.com/crawl/crawl/commit/3851f72b99a7
12:11:20 <Cheibriados> 03ebering02 07* 0.25-a0-704-g54349f4: Add attack strength punctuation to Vamp Drain (12183) 10(52 minutes ago, 1 file, 2+ 1-) 13https://github.com/crawl/crawl/commit/54349f45608b
12:11:20 <Cheibriados> 03ebering02 07* 0.25-a0-705-ge9988fc: Allow autotravel to snuff foxfires (12188) 10(47 minutes ago, 1 file, 1+ 2-) 13https://github.com/crawl/crawl/commit/e9988fc0fb00
12:18:18 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.25-a0-705-ge9988fc0fb (34)
12:26:34 -!- fiddlerwoaroof_ is now known as fiddlerwoaroof
13:07:56 <Henzell> Unstable branch on crawl.akrasiac.org updated to: 0.25-a0-705-ge9988fc (34)
13:26:35 <advil> amalloy: I would prefer to delete this apparent rape meme that is on the front page of r/dcss (and is being upvoted) as off topic, do you object?
13:27:48 <Pinkbeast> "Apparent" it ain't. :-/
13:27:56 <advil> I just don't know the context which is apparently familiar to many people
13:28:23 <advil> but yeah, I'm understating perhaps
13:28:44 <advil> it's pretty gross for someone who doesn't know the context
13:28:48 <advil> at least
16:23:50 <advil> amalloy thanks for deleting it
17:08:00 -!- jfcaron_ is now known as jfcaron
18:23:10 <Lantell> Unstable branch on underhound.eu updated to: 0.25-a0-705-ge9988fc0fb (34)