00:02:37 reaverb: I think the coverage stuff can be improved. Might need two separate paths for OSX and Linux. I'll play a bit over the next week 00:04:50 Sure. 00:07:40 03Alex Jurkiewicz02 {reaverb} 07[catch2-integration] * 0.25-a0-315-g1d56166: Fix macOS OS detection with catch2 10(17 hours ago, 1 file, 7+ 7-) 13https://github.com/crawl/crawl/commit/1d5616665a69 00:07:40 03Alex Jurkiewicz02 {reaverb} 07[catch2-integration] * 0.25-a0-316-g150c77e: Add code coverage tracking 10(17 hours ago, 3 files, 17+ 1-) 13https://github.com/crawl/crawl/commit/150c77ef0791 00:17:45 Only comment I have on your commits is that you mention gcovr under the Debian prerequisites but not under the rest of linux prerequisites. I'll probably lightly edit INSTALL.txt so gcovr isn't tucked away in a platform-specific list of prereqs 00:37:28 I can't get gcovr working under msys2 right now. I'll probably be able to get it work if debugged it for a couple hours, but I don't have a couples hours. Because of this, I'm going to wait to push the catch2-coverage commit to master until I get back from the holidays. I'll push the OS X fix to master, however. Thanks again for both commits! 00:50:07 03reaverb02 07* 0.25-a0-311-ga901c2c: Integrate catch2 testing framework into crawl. 10(25 hours ago, 11 files, 17804+ 65-) 13https://github.com/crawl/crawl/commit/a901c2c2c741 00:50:07 03reaverb02 07* 0.25-a0-312-g5769b18: Add automatic catch2 tests to travis-ci builds 10(25 hours ago, 2 files, 8+ 0-) 13https://github.com/crawl/crawl/commit/5769b184a261 00:50:07 03reaverb02 07* 0.25-a0-313-g9aa3435: Test whether travis-ci can detect failing catch2 tests 10(23 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/9aa3435fcc3c 00:50:07 03reaverb02 07* 0.25-a0-314-ge4868ce: Revert "Test whether travis-ci can detect failing catch2 tests" 10(13 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/e4868ce5c1a4 00:50:07 03Alex Jurkiewicz02 {reaverb} 07* 0.25-a0-315-g1d56166: Fix macOS OS detection with catch2 10(18 hours ago, 1 file, 7+ 7-) 13https://github.com/crawl/crawl/commit/1d5616665a69 00:50:07 03reaverb02 07* 0.25-a0-316-gd28d56f: Mention catch2 macro problems in platform.h comment 10(6 minutes ago, 1 file, 5+ 0-) 13https://github.com/crawl/crawl/commit/d28d56f9c5eb 01:03:13 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-316-gd28d56f9c5 (34) 01:22:05 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-2824-g6a88ae04c9 03:11:42 Unstable branch on crawl.beRotato.org updated to: 0.25-a0-316-gd28d56f (34) 03:56:35 Fork (bcadrencrawl) on crawl.kelbi.org updated to: 0.22.1-1867-g92d5cff543 07:26:53 -!- amalloy is now known as amalloy_ 07:32:22 !messages 07:32:22 (1/2) alexjurkiewicz said (1d 9h 9m 27s ago): how much do I have to worry about 2019-12-23 03:17:27,604 WARN: #6957 Didn't know how to handle msg: ui_state_sync 07:32:26 !messages 07:32:26 (1/1) reaverb said (1d 5h 56m 5s ago): catch2 integration is up on the branch "catch2-integration". Only large remaining problem is an annoying bug that breaks compilation if the .cc files with tests have hyphens in their name (???). See the first commit in the catch2-integration branch for a bit more detail. 07:36:14 !tell alexjurkiewicz i think i've seen that before occasionally when stopping the server; i wouldn't worry too much, but it'd be good to know more about why that happens 07:36:14 aidanh: OK, I'll let alexjurkiewicz know. 07:44:41 !tell reaverb sweet! i get that issue too, I'll take a look 07:44:41 aidanh: OK, I'll let reaverb know. 07:47:28 !git Makefile:1906 07:47:29 %git Makefile:1906 07:47:29 Could not find commit Makefile:1906 (git returned 128) 07:48:59 !tell reaver that would probably be because of this makefile rule: https://github.com/crawl/crawl/blob/d28d56f9c5ebdea346323d502b84f9b713a84da1/crawl-ref/source/Makefile#L1897 07:48:59 Sorry aidanh, I don't know who reaver is. 07:49:09 !tell reaverb that would probably be because of this makefile rule: https://github.com/crawl/crawl/blob/d28d56f9c5ebdea346323d502b84f9b713a84da1/crawl-ref/source/Makefile#L1897 07:49:10 aidanh: OK, I'll let reaverb know. 09:23:34 Stable (0.22) branch on underhound.eu updated to: 0.22.1-59-ge965b3aba3 09:51:26 New branch created: pull/1241 (1 commit) 13https://github.com/crawl/crawl/pull/1241 09:51:26 03sdynet02 07https://github.com/crawl/crawl/pull/1241 * 0.25-a0-317-g3dd5bf0: Change USK Line Pass's cost 10(7 minutes ago, 1 file, 8+ 1-) 13https://github.com/crawl/crawl/commit/3dd5bf04de40 09:59:21 should we bring back santa hats for elves? 10:00:06 reverting 1d3b463666d87237ef3dab843e9c4e0833c67810 might be sufficient 10:01:43 !tell alexjurkiewicz (also aidanh) re ui_state_sync, one last state sync messageis sent by the js client once after the crawl socket is closed when exiting a session, the error is because there is no game anymore; I spent a while trying to get rid of the sync message on the js side and failed, but it is harmless 10:01:43 advil: OK, I'll let alexjurkiewicz know. 10:02:19 we should fix it because it is cluttering up server logfiles in an annoying way, if one deals with those 10:02:34 it could be suppressed from the python side, but it'd be nice to know why it is even being sent 10:03:27 heh, https://github.com/crawl/crawl/blob/2cf3f37ed60092db996a7fd81bc94c1ed9be69f5/crawl-ref/source/rltiles/mon/unique/antaeus.png is pretty nice 10:03:48 advil: hm, I guess i'll look into that one of these days 10:04:12 yeah, it'd be faster for you but iirc I was trying to figure it out while you were off 10:04:50 re yak removal crashes, turns out that's because map lua is executed during startup as some sort of validity check, instead of just being parsed 10:05:18 and it turns out there are a lot of maps that access you, especially you.species 10:13:32 for the map code, parsing = execution 10:14:29 well, to be clear there is a step that generates lua code from a des file that you might call parsing 10:14:50 right, yeah, just saw https://crawl.develz.org/wiki/doku.php?id=dcss:help:maps:lua 10:15:13 that makes this somewhat tricky 11:22:43 Stable (0.23) branch on underhound.eu updated to: 0.23.1-91-gf373564dc4 18:01:44 -!- amalloy_ is now known as amalloy 18:22:55 Unstable branch on underhound.eu updated to: 0.25-a0-316-gd28d56f9c5 (34) 20:13:31 why did I turn Coc into the north pole. that's a dumb commit 20:17:10 03Brendan Hickey02 07* 0.25-a0-317-g5f8687b: Changing 'slaying song' to 'sleighing song' 10(2 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/5f8687bca5ed 20:22:27 Altar interface issues. 13https://crawl.develz.org/mantis/view.php?id=12160 by Yermak 20:32:57 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-317-g5f8687bca5 (34) 20:54:17 merry christmas nerds 20:54:17 alexjurkiewicz: You have 4 messages. Use !messages to read them. 21:15:03 have a happy new year, dork.... 22:15:11 03sdynet02 07https://github.com/crawl/crawl/pull/1235 * 0.25-a0-297-g7733bdf: Raise Exile's chance 10(5 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/7733bdf32919