00:01:32 <ebering> whelp
00:01:44 <ebering> time to do it all sneaky like I guess
00:01:54 <ebering> oh worms has a tile
00:03:34 <ebering> advil: you can unpin the thread; I'm going to merge soon (tonight even!)
00:06:44 <gammafunk> not if I push my stationary-magic branch first
00:06:54 <ebering> oh its a push war you want is it
00:07:00 <ebering> well just you watch out
00:07:09 <ebering> because once positional-magic is ready
00:07:15 <ebering> push-magic is next!!!
00:07:43 <gammafunk> every time a player casts a spell, a commit is procedurally generated and pushed to the repo
00:08:10 <alexjurkiewicz> yes please
00:08:33 <Henzell> mdonais (L16 MfCK) Crash caused by signal #11: Segmentation fault (Lair:3)
00:09:10 <ebering> !crashlog mdonais
00:09:46 <ebering> fedhas bug eh
00:09:46 <Sequell> 5. mdonais, XL16 MfCK, T:19228 (milestone): http://crawl.akrasiac.org/rawdata/mdonais/crash-mdonais-20191202-050831.txt
00:09:48 <gammafunk> says he used phial of floods
00:09:58 <Henzell> mdonais (L16 MfCK) Crash caused by signal #11: Segmentation fault (Lair:3)
00:11:24 <gammafunk> hrm, mike says it may be due to
00:11:36 <ebering> its in ignite poison for monster in the stack trace
00:11:40 <ebering> which would be the ghost's spell
00:45:23 <Cheibriados> 03ebering02 07* 0.25-a0-201-g0bb11ae: Don't crash in the ignite poison cloud tracer 10(2 minutes ago, 1 file, 4+ 1-) 13https://github.com/crawl/crawl/commit/0bb11aece907
00:54:51 <Cheibriados> 03ebering02 07[positional-magic] * 0.25-a0-202-g8bd92b5: Generalize and rename targeter_los 10(6 days ago, 10 files, 26+ 26-) 13https://github.com/crawl/crawl/commit/8bd92b5b8569
00:54:51 <Cheibriados> 03ebering02 07[positional-magic] * 0.25-a0-203-gabb5cbb: Use targeter_radius hitfuncs for friendly fire checks 10(6 days ago, 1 file, 9+ 26-) 13https://github.com/crawl/crawl/commit/abb5cbb05e13
00:54:51 <Cheibriados> 03ebering02 07[positional-magic] * 0.25-a0-204-g1b0f4d3: Positional magic 🌪: Airstrike 10(8 weeks ago, 3 files, 21+ 3-) 13https://github.com/crawl/crawl/commit/1b0f4d352a03
00:54:51 <Cheibriados> 03ebering02 07[positional-magic] * 0.25-a0-205-gf302f3d: Positional magic 🔥: Fire removals 10(8 weeks ago, 2 files, 2+ 5-) 13https://github.com/crawl/crawl/commit/f302f3d7ce68
00:54:51 <Cheibriados> 03ebering02 07[positional-magic] * 0.25-a0-206-g7758758: Positional magic 🔥: Nerf conjure flame (minmay, tealizard) 10(8 weeks ago, 8 files, 69+ 155-) 13https://github.com/crawl/crawl/commit/7758758a4e1d
00:54:51 <Cheibriados> 03ebering02 07[positional-magic] * 0.25-a0-207-ge3d4451: Positional magic 🔥: New Fire spell: Starburst 10(8 weeks ago, 8 files, 87+ 0-) 13https://github.com/crawl/crawl/commit/e3d4451385cb
00:54:51 <Cheibriados> 03ebering02 07[positional-magic] * 0.25-a0-208-g0d78dbb: Positional magic tiles: Starburst icon (ontoclasm) 10(3 hours ago, 3 files, 2+ 1-) 13https://github.com/crawl/crawl/commit/0d78dbbffee9
00:54:51 <Cheibriados> 03ebering02 07[positional-magic] * 0.25-a0-209-ge44d55d: Positional magic 🔥: Modify inner flame 10(8 weeks ago, 2 files, 12+ 2-) 13https://github.com/crawl/crawl/commit/e44d55d700de
00:54:51 <Cheibriados> 03ebering02 07[positional-magic] * 0.25-a0-210-g48bd468: Positional magic 🔥: New spell Foxfire 10(3 weeks ago, 25 files, 252+ 18-) 13https://github.com/crawl/crawl/commit/48bd468c4c36
00:54:51 <Cheibriados> 03ebering02 07[positional-magic] * 0.25-a0-211-gdaefaf0: Positional magic tiles: Foxfire monster, icon, and trails (ontoclasm) 10(3 hours ago, 10 files, 8+ 2-) 13https://github.com/crawl/crawl/commit/daefaf095a36
00:54:51 <Cheibriados> ... and 26 more commits
00:54:56 <Cheibriados> Branch pull/1200 updated to be equal with positional-magic: 13https://github.com/crawl/crawl/pull/1200
00:55:05 <alexjurkiewicz> aidanh: the commented out dprf in OuterMenu::add_label should read dprf("Adding %s at %d,%d", label->get_text().tostring().c_str(), x, y);
00:56:18 <ebering> I guess that last push was excessive
00:56:48 <ebering> let's go
00:58:14 <alexjurkiewicz> :O
00:58:30 <alexjurkiewicz> i'll kill the experimental then shall i
00:59:00 <ebering> I'm doing one more build at home
00:59:07 <ebering> I'd appreciate it if you rebuilt it first
00:59:13 <alexjurkiewicz> ok
00:59:26 <ebering> thanks!
01:07:02 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.25-a0-201-g0bb11aece9 (34)
01:10:28 <ebering> well
01:10:33 <ebering> kelbi says its ok
01:11:07 <ebering> floraline: thank you for hosting the positional magic experimental
01:11:08 <ebering> alexjurkiewicz: thanks!
01:11:44 <Cheibriados> 03ebering02 07* 0.25-a0-202-g8bd92b5: Generalize and rename targeter_los 10(6 days ago, 10 files, 26+ 26-) 13https://github.com/crawl/crawl/commit/8bd92b5b8569
01:11:44 <Cheibriados> 03ebering02 07* 0.25-a0-203-gabb5cbb: Use targeter_radius hitfuncs for friendly fire checks 10(6 days ago, 1 file, 9+ 26-) 13https://github.com/crawl/crawl/commit/abb5cbb05e13
01:11:44 <Cheibriados> 03ebering02 07* 0.25-a0-204-g1b0f4d3: Positional magic 🌪: Airstrike 10(8 weeks ago, 3 files, 21+ 3-) 13https://github.com/crawl/crawl/commit/1b0f4d352a03
01:11:44 <Cheibriados> 03ebering02 07* 0.25-a0-205-gf302f3d: Positional magic 🔥: Fire removals 10(8 weeks ago, 2 files, 2+ 5-) 13https://github.com/crawl/crawl/commit/f302f3d7ce68
01:11:44 <Cheibriados> 03ebering02 07* 0.25-a0-206-g7758758: Positional magic 🔥: Nerf conjure flame (minmay, tealizard) 10(8 weeks ago, 8 files, 69+ 155-) 13https://github.com/crawl/crawl/commit/7758758a4e1d
01:11:44 <Cheibriados> 03ebering02 07* 0.25-a0-207-ge3d4451: Positional magic 🔥: New Fire spell: Starburst 10(8 weeks ago, 8 files, 87+ 0-) 13https://github.com/crawl/crawl/commit/e3d4451385cb
01:11:44 <Cheibriados> 03ebering02 07* 0.25-a0-208-g0d78dbb: Positional magic tiles: Starburst icon (ontoclasm) 10(3 hours ago, 3 files, 2+ 1-) 13https://github.com/crawl/crawl/commit/0d78dbbffee9
01:11:44 <Cheibriados> 03ebering02 07* 0.25-a0-209-ge44d55d: Positional magic 🔥: Modify inner flame 10(8 weeks ago, 2 files, 12+ 2-) 13https://github.com/crawl/crawl/commit/e44d55d700de
01:11:44 <Cheibriados> 03ebering02 07* 0.25-a0-210-g48bd468: Positional magic 🔥: New spell Foxfire 10(3 weeks ago, 25 files, 252+ 18-) 13https://github.com/crawl/crawl/commit/48bd468c4c36
01:11:44 <Cheibriados> 03ebering02 07* 0.25-a0-211-gdaefaf0: Positional magic tiles: Foxfire monster, icon, and trails (ontoclasm) 10(3 hours ago, 10 files, 8+ 2-) 13https://github.com/crawl/crawl/commit/daefaf095a36
01:11:44 <Cheibriados> ... and 26 more commits
01:22:03 <Kelbell> Experimental (positional-magic) branch on crawl.kelbi.org updated to: 0.25-a0-237-g0889b22a1b
01:32:43 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.25-a0-237-g0889b22a1b (34)
01:38:40 <Gretell> Unstable branch on crawl.develz.org updated to: 0.25-a0-237-g0889b22 (34)
01:42:37 <ebering> it begins
02:03:23 <alexjurkiewicz> ebering: worked fine for the final rebuild
02:09:04 <Gretell> Windows builds of master branch on crawl.develz.org updated to: 0.25-a0-237-g0889b22
02:59:51 <Gretell> Monster database of master branch on crawl.develz.org updated to: 0.24-a0-443-g80245de
03:12:40 -!- amalloy is now known as amalloy_
03:22:24 <Rotatell> Unstable branch on crawl.beRotato.org updated to: 0.25-a0-237-g0889b22 (34)
03:44:13 <Kelbell> Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-2777-g6b872f2bae
04:08:28 <Kelbell> Fork (bcadrencrawl) on crawl.kelbi.org updated to: 0.22.1-1733-gf8153d18df
05:28:34 <aidanh> alexjurkiewicz: good thinking
06:53:07 <kitchen_ace> Foxfire is back to showing ? for a tile now that it's in trunk
07:49:15 <Cheibriados> 03ebering02 07* 0.25-a0-238-g716fc43: Actually use the new foxfire tile 10(7 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/716fc43bfc76
07:49:15 <Cheibriados> 03ebering02 07* 0.25-a0-239-ge017589: Actually use the foxfire monster tile 10(2 minutes ago, 2 files, 2+ 1-) 13https://github.com/crawl/crawl/commit/e0175898a288
07:49:15 <Cheibriados> 03ebering02 07* 0.25-a0-240-g216da55: Remove a vestigal line 10(70 seconds ago, 1 file, 0+ 1-) 13https://github.com/crawl/crawl/commit/216da5515099
07:49:15 <Cheibriados> 03ebering02 07* 0.25-a0-241-g5bc340a: Replace Flame Tongue with Foxfire in the FE description 10(51 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/5bc340afbfbd
07:54:51 <aidanh> congrats on the big merge ebering !
07:55:06 <ebering> thanks!
07:55:22 <aidanh> heh, no big crawl feature would be complete without a few quickly-pushed fixes
07:57:36 <aidanh> btw everyone unfortunately I'll be unable to work on crawl for the time being, as I've just started a new job with an assignments of invention clause
07:57:58 <ebering> R I P
07:58:05 <aidanh> I should be able to get an exemption for that, but it'll take a while for me to sort out the details
07:58:10 <aidanh> s/that/crawl/
07:58:29 <ebering> I guess we'll have to assign over the crawl ui and make our users pay royalties!
07:58:43 <aidanh> brilliant idea
07:58:59 <aidanh> micropayments on every popup window close
08:16:12 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.25-a0-241-g5bc340afbf (34)
09:28:02 <Henzell> adviltest (L1 HOFi) Crash caused by signal #15: Terminated (Vaults:5)
09:29:29 <Henzell> adviltest (L1 HOFi) Crash caused by signal #15: Terminated (Vaults:5)
09:30:14 <advil> !crashlog
09:30:16 <Sequell> 21451. adviltest, XL1 HOFi, T:7 (milestone): http://crawl.akrasiac.org/rawdata/adviltest/crash-adviltest-20191202-142929.txt
09:32:17 <advil> well, that's an extremely exploitable crash bug
09:32:30 <advil> (#1218)
10:02:55 <Cheibriados> 03kitchen-ace02 07https://github.com/crawl/crawl/pull/1189 * 0.25-a0-242-g2ca764d: Make fire spells better at burning trees 10(6 weeks ago, 2 files, 8+ 2-) 13https://github.com/crawl/crawl/commit/2ca764da23c6
10:20:33 <Henzell> adviltest (L1 HOFi) Crash caused by signal #15: Terminated (Vaults:5)
10:22:41 <Henzell> adviltest (L1 HOFi) Crash caused by signal #15: Terminated (D:1)
10:22:45 <advil> !crashlog
10:22:47 <Sequell> 21453. adviltest, XL1 HOFi, T:0 (milestone): http://crawl.akrasiac.org/rawdata/adviltest/crash-adviltest-20191202-152240.txt
10:26:12 <advil> looking at this code I'm a little surprised we even allow the lua interpreted online
10:27:27 <advil> *interpreter
10:33:19 <kitchen_ace> Hi, I'm working on fixing up my "fire spells burn trees" PR. The only thing left is to make sure Ignition doesn't burn trees from Summon Forest.
10:33:29 <kitchen_ace> This is easy to do, but I wonder if there's a better way to generalize it
10:33:46 <kitchen_ace> because there are actually a few edge cases where you can destroy summoned forest tiles
10:34:28 <kitchen_ace> I'm not really sure where to start with that, though
11:08:32 <kitchen_ace> OK I think I have it, make the trees created by Summon Forest a different type of dungeon feature than normal trees
11:08:57 <kitchen_ace> anything that needs to check both can do so, and then not checking for both will be the default behaviour
11:09:52 <advil> can you check for a temporary terrain change?
11:10:01 <advil> that might be better than adding a new feature
11:10:11 <kitchen_ace> you can and that is what happens currently
11:10:21 <kitchen_ace> but it means a lot of edge cases don't check for it
11:10:33 <kitchen_ace> if you think it's preferable to just checking the temp change, I can try that
11:10:46 <kitchen_ace> *to just check the temp change
11:10:51 <advil> what edge cases do you have in mind?
11:11:04 <kitchen_ace> tornado destroys trees, including ones from summon forest
11:11:12 <kitchen_ace> forest fires can spread from real trees to temp ones
11:11:25 <kitchen_ace> maybe others that I can't think of
11:12:40 <kitchen_ace> Ge0ff figured out that tornado destroying temp trees can actually cause a crash, though you have to really go out of your way to make it happen
11:12:51 <advil> hm, maybe having trees from summon forest be destroyable isn't so bad now that I think about it
11:13:08 <kitchen_ace> I would be 100% onboard with that
11:13:11 <advil> given the recent changes to timeout in summons
11:13:27 <kitchen_ace> but ebering thought it would be bad to let you dig through terrain with summon forest + fire spells
11:13:38 <kitchen_ace> according to the comment he left in my PR anyhow
11:14:19 <advil> oh, I guess the issue is that trees replace other terrain
11:14:24 <kitchen_ace> yeah
11:14:36 <kitchen_ace> including undiggable walls
11:14:58 <geekosaur> that sounds like the bug is allowing it to do that
11:15:36 <kitchen_ace> by itself, the undiggable wall becoming a tree isn't a problem I think, and is definitely intended
11:17:50 <geekosaur> and I can think of other corner cases potentially triggerable by monsters, hm
11:19:02 <advil> %git 0a4d0e945a
11:19:02 <Cheibriados> 07Chris Campbell02 * 0.19-a0-1649-g0a4d0e9: Let Summon Forest work on non-rock walls 10(3 years, 2 months ago, 4 files, 23+ 16-) 13https://github.com/crawl/crawl/commit/0a4d0e945ab5
11:19:19 <advil> (do australians really write "smoulder"?)
11:19:59 <geekosaur> yes
11:20:49 <advil> I think what ought to happen is that summoned trees can burn iff they are converted from a diggable feature
11:20:53 <advil> whether that is practical, not sure
11:21:33 <Lantell> Stable (0.23) branch on underhound.eu updated to: 0.23.1-91-gf373564dc4
11:22:00 <Cheibriados> 03advil02 07* 0.25-a0-242-g28950d1: Handle HUPs better in lua interpreter 10(39 minutes ago, 1 file, 4+ 3-) 13https://github.com/crawl/crawl/commit/28950d1e3277
11:22:00 <Cheibriados> 03advil02 07* 0.25-a0-243-gce69c89: Improve beforeunload future compatibility 10(19 minutes ago, 1 file, 3+ 0-) 13https://github.com/crawl/crawl/commit/ce69c89b7465
11:22:06 <Cheibriados> 03kitchen-ace02 07https://github.com/crawl/crawl/pull/1189 * 0.25-a0-242-gf9aca8f: Make fire spells better at burning trees 10(6 weeks ago, 2 files, 10+ 2-) 13https://github.com/crawl/crawl/commit/f9aca8f7921c
11:22:29 <kitchen_ace> that should be relatively straightforward if I went with my idea of adding a new dngn_feature
11:22:32 <kitchen_ace> if not, not sure
11:23:45 <advil> adding a new feature may lead to creating a whole new set of corner cases
11:25:43 <kitchen_ace> how so?
11:28:27 <advil> for example, now everything that would check for DNGN_TREE has to check for DNGN_TREE or DNGN_TEMP_TREE
11:29:56 <advil> which is probably tractable, but it's not nothing
11:30:01 <kitchen_ace> right, that's kind of the idea: I don't think there are too many instances when you actually *want* to interact with DNGN_TEMP_TREE
11:30:26 <kitchen_ace> but maybe I'm wrong about that
11:30:58 <advil> !source _feat_is_mangrove
11:30:59 <Sequell> 1/1. https://github.com/crawl/crawl/blob/master/crawl-ref/source/tilecell.cc#L350
11:31:02 <advil> random small example
11:31:53 <advil> I think it would be easy-ish to catch all the places that explicitly mention DNGN_TREE, there's only 45 shown by git grep, but I think correctly detecting the temp feature is still a better approach
11:32:56 <advil> even if for now that means that no summoned trees are destructable
11:32:56 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.25-a0-243-gce69c89b74 (34)
11:33:53 <kitchen_ace> OK, sure
11:34:44 <kitchen_ace> I'll just add the check in my PR for now for ignition specifically, and then take a look at changing some of the other problems in another PR
11:54:09 <Cheibriados> 03kitchen-ace02 07https://github.com/crawl/crawl/pull/1189 * 0.25-a0-242-geb4b4e1: Make fire spells better at burning trees 10(6 weeks ago, 2 files, 11+ 2-) 13https://github.com/crawl/crawl/commit/eb4b4e1f94b5
11:55:51 <kitchen_ace> thanks
11:58:02 <advil> kitchen_ace: what would happen if you did the temp terrain check in bolt::can_affect_wall, where the feat_is_tree(dngn_feat) && !can_burn_trees() check is now?
11:59:42 <kitchen_ace> do you mean for Ignition? that would be cleaner, yeah
12:01:05 <advil> it might handle some of the other spells too
12:01:18 <advil> if it works, it might depend on spell implementation (which I haven't checked)
12:13:15 <kitchen_ace> seems to work fine, since Ignition uses beams for damage
12:13:17 <kitchen_ace> thanks
12:15:30 <Cheibriados> 03kitchen-ace02 07https://github.com/crawl/crawl/pull/1189 * 0.25-a0-242-gf712c76: Make fire spells better at burning trees 10(6 weeks ago, 2 files, 11+ 2-) 13https://github.com/crawl/crawl/commit/f712c76830fc
12:21:37 <ebering> kitchen_ace: when I made my review remark about firestorme and fedhas
12:21:41 <ebering> I didn't mean that you got docked piety
12:21:55 <ebering> I meant that if you firestorm some trees when I tested it doesn't prompt "Are you sure you want to burn these plants"
12:26:29 <kitchen_ace> Ah, I misread your comment. I haven't fixed that, will do shortly
12:37:41 <Rotatell> pigah (L13 DrWn) ERROR in 'mon-cast.cc' at line 1693: Unknown monster spell 'Dazzling Flash' cast by Zonian's ghost (Lair:4)
12:38:24 <Rotatell> pigah (L13 DrWn) ERROR in 'mon-cast.cc' at line 1693: Unknown monster spell 'Dazzling Flash' cast by Zonian's ghost (Lair:4)
12:39:22 <advil> uh oh
12:50:08 <kitchen_ace> ebering: Firestorm is prompting me about burning trees with Fedhas
12:50:24 <kitchen_ace> Ignition isn't an issue any more
12:52:22 <Cheibriados> 03advil02 07* 0.25-a0-244-g618c0ec: Mark dazzling flash as unusable for saved ghosts 10(68 seconds ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/618c0ec23420
12:53:39 <advil> ebering do you know if there are other spells that will need similar changes to ^?
12:54:53 <advil> oh it looks like chei got updated? thanks |amethyst, sorry about that
12:57:05 <advil> not sure if that commit will lead to ghosts still appearing to the player ot be able to cast that spell
12:57:20 <advil> but it should prevent the crash
12:57:48 <Cheibriados> New branch created: pull/1219 (1 commit) 13https://github.com/crawl/crawl/pull/1219
12:57:48 <Cheibriados> 03James Buck02 07https://github.com/crawl/crawl/pull/1219 * 0.25-a0-195-gcfbb66d: Fix initial god ability slot assignment in local tiles 10(36 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/cfbb66d2f171
13:03:17 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.25-a0-244-g618c0ec234 (34)
13:25:20 <ebering> advil: I think I had put something in save compat to remove bad spells when loading ghosts
13:28:10 <ebering> argh, I did it for monsters but not for ghostdemons
13:43:34 <Pinkbeast> Oh, no, ghost changes again :-(
13:58:55 -!- amalloy_ is now known as amalloy
14:02:26 <ebering> Pinkbeast: just removing removed monster spells from them
14:02:33 <Henzell> MuffinSoup (L21 FoFi) ERROR in 'mon-cast.cc' at line 1693: Unknown monster spell 'Conjure Flame' cast by Sippynaf's ghost (Elf:2)
14:02:57 <Pinkbeast> ebering: Yeah, it's just basically all ghost changes now have merge conflicts, yes I know that's our fault
14:03:11 <ebering> this change is only in tags.cc
14:03:20 <ebering> afaict unmarshallGhost is basically the same?
14:03:38 <Pinkbeast> One change there to know its slayer but perhaps this won't be a problem
14:03:50 <Rotatell> zbzbzb (L19 DEFE) ERROR in 'mon-cast.cc' at line 1693: Unknown monster spell 'Conjure Flame' cast by minmay's ghost (Elf:2)
14:05:08 <Cheibriados> 03ebering02 07* 0.25-a0-245-gd0e028f: Correctly fixup ghost spells 10(7 minutes ago, 2 files, 14+ 0-) 13https://github.com/crawl/crawl/commit/d0e028f13a9c
14:05:24 <ebering> ??rebuild
14:05:24 <Sequell> rebuild[1/2]: http://crawl.akrasiac.org/rebuild/ http://underhound.eu:81/rebuild/ http://crawl.berotato.org/crawl/rebuild/ http://crawl.xtahua.com/rebuild/ https://crawl.kelbi.org/rebuild/ Bug gammafunk, advil, |amethyst, or Nap.Kin for CDO. Use your powers wisely.
14:05:24 <ebering> &versions
14:05:39 <Sequell> CAO: 0.25-a0-243-gce69c89, CBRO: 0.25-a0-237-g0889b22, CDO: 0.25-a0-237-g0889b22, CKO: 0.25-a0-244-g618c0ec234, CPO: 0.25-a0-244-g618c0ec, CUE: 0.25-a0-200-g5ba96148f3, CWZ: 0.25-a0-57-ga0c9b72, CXC: 0.25-a0-201-g0bb11aece9, LLD: 0.25-a0-190-g27fffb8c76
14:06:51 <ebering> johnstein: it looks like I'm still not a dgl admin on cbro? or at least I can't kick off a rebuild
14:07:12 <ebering> advil: could you trip cbro and cdo rebuilds please
14:08:41 <kitchen_ace> while you're talking player ghost spells, is there any reason that ghosts can have portal projectile as a spell?
14:09:10 <ebering> over zealous player monster symmetry from days gone by
14:10:21 <kitchen_ace> OK so it doesn't actually do anything
14:11:59 <Henzell> MuffinSoup (L21 FoFi) ERROR in 'mon-cast.cc' at line 1693: Unknown monster spell 'Conjure Flame' cast by Sippynaf's ghost (Elf:2)
14:12:06 <ebering> !crashlog
14:12:07 <Sequell> 21458. MuffinSoup, XL21 FoFi, T:42142 (milestone): http://crawl.akrasiac.org/rawdata/MuffinSoup/crash-MuffinSoup-20191202-191159.txt
14:12:15 <advil> I wonder if that save compat could do something more general, like check a non-static version of _ms_waste_of_time
14:14:45 <ebering> I'd worry that starts injecting an actual gameplay change into tags.cc
14:15:34 <advil> well, probably just want the removed spell part of that function
14:16:34 <ebering> ya
14:17:40 <ebering> did you start the rebuilds on cbro and cdo?
14:21:46 <advil> on cbro
14:22:23 <advil> cdo has a custom process that I have to remember how to do each time
14:23:31 <ebering> ah rip
14:23:45 <ebering> %git 0889b22
14:23:45 <Cheibriados> 07ebering02 * 0.25-a0-237-g0889b22: Monster save compatibility for positional magic 10(3 days ago, 1 file, 28+ 1-) 13https://github.com/crawl/crawl/commit/0889b22a1b91
14:24:00 <ebering> thankfully cdo's use rate is low
14:25:04 <Rotatell> Unstable branch on crawl.beRotato.org updated to: 0.25-a0-245-gd0e028f (34)
14:33:58 <Gretell> Unstable branch on crawl.develz.org updated to: 0.25-a0-245-gd0e028f (34)
14:36:19 <Cheibriados> 03advil02 07* 0.25-a0-246-g58704a1: Fix some shadow warnings for older compilers 10(65 seconds ago, 1 file, 4+ 4-) 13https://github.com/crawl/crawl/commit/58704a1ebd56
14:49:35 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.25-a0-245-gd0e028f13a (34)
14:56:27 -!- binaryatrocity is now known as Guest50246
15:02:23 -!- jfcaron_ is now known as jfcaron
15:14:22 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.25-a0-246-g58704a1ebd (34)
15:42:04 <alexjurkiewicz> aidanh: congrats
16:06:14 <kitchen_ace> is there any reason the Wucad Mu wizlab is indestructable?
16:07:03 <kitchen_ace> Can't break walls with shatter, can't burn trees
16:10:54 <kitchen_ace> It's been like that for a while but I can't find a record of why
16:10:58 <kitchen_ace> %git 4cf3d6dbbf4
16:10:58 <Cheibriados> 07due02 * 0.6.0-a1-3047-g4cf3d6d: veto_fire, rebranding for Wucad Mu map. 10(10 years ago, 4 files, 76+ 15-) 13https://github.com/crawl/crawl/commit/4cf3d6dbbf4c
16:29:40 -!- Tiobot is now known as Guest81967
16:50:02 <Cheibriados> New branch created: pull/1220 (1 commit) 13https://github.com/crawl/crawl/pull/1220
16:50:02 <Cheibriados> 03kitchen-ace02 07https://github.com/crawl/crawl/pull/1220 * 0.25-a0-247-ga8beaaf: Fix edge cases for destroying Summon Forest's trees 10(39 minutes ago, 2 files, 6+ 2-) 13https://github.com/crawl/crawl/commit/a8beaaf020e8
16:55:13 <Cheibriados> Tornado can destroy trees that should be indestructable in vaults 13https://crawl.develz.org/mantis/view.php?id=12141 by kitchen_ace
17:02:47 <alexjurkiewicz> ebering: btw, big congrats on landing positional magic
17:03:40 <alexjurkiewicz> it wasn't the biggest change in terms of lines added/removed, but I think in raw creativity it's up there as one of the biggest pieces of work for the past few years
17:10:02 <ebering> thanks! and thanks for your help hosting the experimental
17:10:14 <ebering> now on to magic part ii
17:10:19 <ebering> miscast boogaloo
17:41:07 <Bcadren> Weird "bug" report: I accidentally typed make tiles=y instead of make TILES=y once; it made a weird half-console/half-tiles build that wouldn't run properly. (Probably not worth addressing beyond noting that capitalization matters in INSTALL.txt).
17:45:18 <amalloy> seems to make a totally normal console build, for me. could be a windows-specific issue, or something you've broken in your fork
17:46:12 <Pinkbeast> amalloy: Crikey, how fast can you build it?
17:48:39 <Cheibriados> Warlock's mirror doesn't reflect javelins 13https://crawl.develz.org/mantis/view.php?id=12142 by kitchen_ace
17:49:02 <amalloy> well, ccache made most of the compilation a no-op
17:49:34 <amalloy> but `ccache -C; make clean; time make -sj16` shows: real 1m19.596s   user 13m21.168s
17:49:54 <amalloy> so, a bit over a minute for a clean build
17:50:21 <Pinkbeast> Ah, yes, I suppose if it doesn't actually change then ccache can do all the heavy lifting. (Also, -j 16, I wish :-)
17:50:50 <amalloy> i technically only have 12 cores i guess
17:51:04 <alexjurkiewicz> old and busted: -j 8 new hotness: -j 16
17:51:14 <Pinkbeast> My 10yo MacBook... does not have 16 or 12 :-)
18:01:36 <Bcadren> yea maybe it's a cacheing issue then if you'd done a tiles build before then do it without capitalization?
18:01:57 <Pinkbeast> Bcadren: I infer amalloy did just that
18:05:00 <amalloy> yeah, `make TILES=y; make tiles=y` is still fine
18:05:00 <amalloy> it generates a normal console build
18:06:24 <advil> the general principle is that you could supply whatever variable assignment args you want to make, and they'll be ignored unless they're explicitly supposed to do something
18:06:27 <advil> where case does matter
18:06:50 <advil> so `make tiles=y` is functionally identical to just `make` because the variable `tiles` is ignored
18:08:05 <amalloy> right, it's certainly supposed to be. but i could certainly believe something weird happens with case on windows
18:08:38 <advil> it's also occasionally possible to get a build in a state where make clean is needed to reset things
18:08:49 <advil> at least, I've had that happen from time to time
18:09:23 <advil> I'd guess that the 'tiles=y' part was just a coincidence and the same thing would've happened with plain `make`
18:23:22 <Lantell> Unstable branch on underhound.eu updated to: 0.25-a0-246-g58704a1ebd (34)
19:14:38 -!- Bahhumbug_ is now known as Bahhumbug
19:41:04 <Cheibriados> New branch created: pull/1221 (1 commit) 13https://github.com/crawl/crawl/pull/1221
19:41:04 <Cheibriados> 03kitchen-ace02 07https://github.com/crawl/crawl/pull/1221 * 0.25-a0-247-gd3617ba: Make Death Cobs and Deathcaps friendly under Fedhas 10(22 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/d3617ba75640
19:53:49 <advil> gammafunk: fwiw right now curse toes summon a mix of friendly and unfriendly creatures, it's actually kind of confusing at first. When I xv'd the death caps it was clear enough from the description why though
19:54:27 <gammafunk> curse toes only summon death caps, no?
19:54:34 <advil> no
19:54:41 <gammafunk> ah right, wandering mushrooms
19:55:08 <gammafunk> yeah, I think they shouldn't do that, but good catch, I was mistaken there
19:55:09 <advil> yeah
19:55:31 <gammafunk> I do think we don't want to go making multi-holiness monsters
19:55:41 <advil> iirc there was also a weird thing where the wandering mushrooms took a turn to go friendly
19:55:58 <gammafunk> ah yeah, that was a seperate issue that I believe ebering fixed?
19:56:06 <gammafunk> in terms of making a proper fineff
19:56:35 <advil> maybe, I think this precedes the ally thing (I saw this in my t game), but I haven't paid attention since t
19:56:54 <advil> anyways, it's possible that *some* cleanup of curse toes under fedhas would be useful
19:57:22 <gammafunk> yeah, certainly having a special case would be wise
19:57:55 <gammafunk> however what I still mentioned does still apply; if we had them all be friendly, the spell would still behave badly, in fact worse since it'd be less useful still
19:58:59 <advil> maybe, I'd almost say just remove wandering mushrooms but it's a 2/3 chance for them and I'm not sure curse toes need a buff
20:00:07 <advil> could just have them summon death caps at 1/3 the quantity
20:00:47 <amalloy> are deathcaps the scary part of curse toes? i always thought the wandering mushrooms were rougher because it's tougher to blink out of the torment if you're confuse-locked
20:00:56 <gammafunk> yes, actually just having them summon death caps would be ok certainly
20:01:08 <gammafunk> you really can't get confuse-locked by those monsters
20:01:34 <gammafunk> it's not like golden eyes where the band spamming is hard to overcome
20:01:38 <advil> I'm not sure I've ever been confused by them at that xl more than once or twice
20:01:45 <gammafunk> yeah
20:05:33 <advil> actually death caps have af_confuse in any case
20:05:58 <advil> maybe what they need is undead thorn hunters
20:06:49 <kitchen_ace> summons do still take a turn to become friendly for fedhas/jiyva
20:06:59 <kitchen_ace> non-summoned monsters are fine
20:07:57 <gammafunk> advil: yeah I would just make them 100% death caps; it really wouldn't be much of a buff, and curse toes don't dominate the kills anyhow
20:08:00 <gammafunk> !lg * zot kmap= recent s=cikiller%
20:08:41 <gammafunk> they do get assists reasonably often, which doesn't show up in the kill counts, but their having such slow movement makes them easy to deal with
20:09:30 <Sequell> 90s limit exceeded: killed !lg * zot kmap= recent s=cikiller%
20:10:05 <gammafunk> !lg * zot kmap= recent s=cikiller%
20:10:15 <gammafunk> odd that this one would timeout
20:11:36 <Sequell> 90s limit exceeded: killed !lg * zot kmap= recent s=cikiller%
20:11:54 <gammafunk> yeah, if summons take a while to become friendly for fedhas/jiyva, maybe there's a fineff that could be made for that, too
20:16:11 <floraline> the experimental was merged, right?
20:16:11 <Sequell> floraline: You have 1 message. Use !messages to read it.
20:26:36 <alexjurkiewicz> floraline: yep
20:26:45 <gammafunk> !kw pmagic
20:26:46 <Sequell> Keyword: pmagic => file=~positional-magic
20:27:15 <gammafunk> !kw positional-magic file=~positional-magic
20:27:16 <Sequell> Defined keyword: positional-magic => file=~positional-magic
20:27:18 <gammafunk> !lg * positional-magic
20:27:19 <Sequell> 728. Potronius the Conjurer (L7 DECj of Sif Muna), slain by Edmund (a +5 flail of protection) on D:5 on 2019-12-03 01:06:25, with 665 points after 5399 turns and 0:10:34.
20:27:36 <gammafunk> hrm
20:29:20 <gammafunk> %git 0889b22a1b
20:29:20 <Cheibriados> 07ebering02 * 0.25-a0-237-g0889b22: Monster save compatibility for positional magic 10(3 days ago, 1 file, 28+ 1-) 13https://github.com/crawl/crawl/commit/0889b22a1b91
20:29:30 <gammafunk> !kw positional-magic vlong>=0.25-a0-237-g0889b22
20:29:32 <Sequell> Defined keyword: positional-magic => vlong>=0.25-a0-237-g0889b22
20:29:38 <gammafunk> !kw pmagic positional-magic
20:29:39 <Sequell> Defined keyword: pmagic => positional-magic
20:30:34 <advil> hm, apparently it is possible for cao to get a logfile with an incomplete logline at the end, and if it does, that logline gets discarded on the next wget
20:33:18 <advil> maybe only if the daemon restarts in between, that would explain why this doesn't come up much
20:52:19 -!- amalloy is now known as amalloy_
20:58:09 -!- cjm_ is now known as cjm
21:17:36 -!- amalloy_ is now known as amalloy
22:16:17 <Bcadren> how do you do a clean build clear the cache and all?
22:27:46 <Bcadren> oh it's just make clean isn't it?
22:44:13 <alexjurkiewicz> it seems weird for there to be a partial logline
22:44:22 <alexjurkiewicz> the writing should be preeeeetttty much atomic
22:44:54 <alexjurkiewicz> I guess with the volume of games, eventually it will read the last bytes of a logfile just as they are being written?
23:13:33 <advil> alexjurkiewicz that's what I assumed too, I'm a bit surprised it could happen
23:14:26 <advil> but I have pretty concrete evidence that it did happen, because I know what the seek point was from the scoresd log, and I have the logfile
23:51:23 <alexjurkiewicz> now that you have done some amazing work with the cao scoring. How would you feel about supporting a different mechanism of pulling data from some servers? What I mean is I'm thinking about a way to escape from the "one logfile for trunk forever" model by letting scoring say "give me all new logfile entries since game id xyz" as an API action, rather than a HTTP range request on a text file
23:51:40 <alexjurkiewicz> and I'm happy to implement the CPO side of this experiment