01:02:14 well, it's not possible to fix that in the general case with crawlrc's current format 01:02:54 but I'm surprised that all lua lines are apparently ignored when initially loading the crawlrc 01:09:09 lua can't be executed before a game loads, so I'd guess that simply filtering the lines and fully reloading the settings on game start was done as a simpler alternative to parsing the lua and ignoring rcfile lines selectively 01:30:36 Hey Everyone! I have a really strange error while compiling stable 0.23 for my server. 01:30:36 ‘CMD_ZOOM_IN’ was not declared in this scope 01:30:40 I cannot find anything about this problem. So I think I'm doing something wrong 01:32:50 Namanix: try make clean 01:32:58 I seem to remember that helping with tha tissue 01:33:35 In what directory? I just do /home/crawl-dev/dgamelaunch-config/bin/dgl update-stable 0.23 01:33:57 For building 01:37:15 I did a make clean in the source directory for the downloaded crawl. We'll see how this goes. Thanks for the tip :) 01:38:07 How can I fix this issue in the future? I'm pretty sure it's not the correct way to always clean when doing a stable build for multiple versions right? 01:38:11 Unstable branch on crawl.develz.org updated to: 0.24-a0-693-g39a19ac (34) 01:47:16 Make clean seems to have helped! Thank you! :D 01:47:50 you're welcome 01:48:31 I can't remember exactly what caused that issue, but yeah in general it should not be necessary to clean build 01:48:58 Maybe it was because the first build I did was a .17 01:49:29 Maybe there were too many differences. In the end when everything is finished I think it will only rebuild trunk and stable 01:49:41 But I'll test this out soon :) 02:07:34 03Aidan Holm02 07* 0.24-a0-694-gbbc8897: More dead code removal 10(11 hours ago, 2 files, 2+ 38-) 13https://github.com/crawl/crawl/commit/bbc889713799 02:07:34 03Aidan Holm02 07* 0.24-a0-695-g53c33f0: Fix webtiles newgame menu background colour 10(3 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/53c33f0441d6 02:07:34 03Aidan Holm02 07* 0.24-a0-696-gd18775d: Reduce webtiles newgame menu height (12074, kitchen_ace) 10(3 minutes ago, 1 file, 13+ 0-) 13https://github.com/crawl/crawl/commit/d18775d16a6a 02:07:50 ah, yeah that's likely 02:09:10 Windows builds of master branch on crawl.develz.org updated to: 0.24-a0-693-g39a19ac 02:20:16 Unstable branch on crawl.kelbi.org updated to: 0.24-a0-696-gd18775d16a (34) 02:59:13 Monster database of master branch on crawl.develz.org updated to: 0.24-a0-443-g80245de 03:20:49 -!- joemaro- is now known as joemaro 03:31:04 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-2457-gf0d5a3770a 06:00:23 -!- Tiobot is now known as Guest71020 08:28:35 Player name in new game screen disappears 13https://crawl.develz.org/mantis/view.php?id=12075 by Goratrix 10:50:41 hm the current windows trunk build crashes on starting a new character 10:50:48 it being windows the crashlog is kind of useless 10:50:53 this is tiles (haven't checked console) 10:51:37 also in tiles the window's horizontal size for the main menu seems to be getting made very wide by the rc file path that's shown there 10:53:56 console is ok 10:54:43 http://xtahua.montres.org.uk/ seems to be a go 10:56:30 the crash is before the weapon display screen, and starting a char that doesn't pick a weapon is fine, so I guess it might be to do with that menu 10:56:42 also, I notice that in console there's no highlighting on the weapon selection menu 10:57:08 Pinkbeast looks great!! 10:57:29 Hi. Recently the console version (trunk) of dcss stopped correctly showing menu highlights (when choosing species/background). Has something changed? 10:58:25 Mandevil ^ :-) 10:58:37 though I do see highlights on everything besides weapon selection 10:58:45 things did change, though 10:59:16 oh are you talking about online? 10:59:18 Yes, I only play online. 10:59:30 0.23 shows blue highlights. 10:59:40 In current trunk, the species/bg shows no hilites. 10:59:42 yeah, can confirm it's broken 11:00:02 Also the choices below the species/bg have white highlights. 11:00:09 Which make the yellow text unreadable. 11:00:30 various things recently changed about that menu so I'm not sure all the bugs have been found yet 11:13:20 the highlighting issue is replicable on a local webtiles build too 11:26:51 Stable (0.23) branch on underhound.eu updated to: 0.23.1-89-g277498a001 11:29:11 advil: Do I need to create a mantis issue? 11:32:45 may be useful 11:33:35 aidanh: it doesn't actually look like highlight_colour is used at all on console in outer-menu.cc? it's sent to the webtiles client and something happens with it for local tiles, but I can't find any use of it otherwise 11:34:01 I'm not sure why that plays out differently on webtiles console vs local console, but maybe just something about some default value 11:39:47 aidanh: I'm guessing some of the hardcoded colors in OuterMenu::add_button should refer to the button highlight values, but I'm not sure of this code enough to change it myself 11:40:17 !source outer-menu.cc:233 11:40:18 https://github.com/crawl/crawl/blob/master/crawl-ref/source/outer-menu.cc#L233 11:40:36 also the indent is wrong after that line in a way that looks suspicious 11:44:25 Created a mantis issue for the problem: https://crawl.develz.org/mantis/view.php?id=12076 11:44:30 just blindly changing those values doesn't do anything on webtiles, so there's more going on there 11:44:38 It contains comparison screenshots. 11:44:52 thanks 11:45:25 I like the 0.23 layout better. 11:45:40 (it's very close, but the spacing is nicer). 11:46:36 PS Mantis 12008 while we're on menu stuff :-) # yeah, not actually very urgent at all 11:47:14 On character creation screen selection highlights are not visible 13https://crawl.develz.org/mantis/view.php?id=12076 by Mandevil 12:14:35 03advil02 07* 0.24-a0-697-g8e49684: Use MenuButton highlight color in local console 10(84 seconds ago, 1 file, 4+ 1-) 13https://github.com/crawl/crawl/commit/8e49684493dd 12:15:14 aidanh: ok, now my guess for 12076 is that for `auto tw = dynamic_cast(btn2->get_child().get())` the child is not a Text on webtiles, so the background color doesn't get set -- still not confident of the code enough to fix this part myself though 12:17:46 Unstable branch on crawl.kelbi.org updated to: 0.24-a0-697-g8e49684493 (34) 12:25:15 Victory screen doesn't show the list of best players 13https://crawl.develz.org/mantis/view.php?id=12077 by Ge0ff 12:29:39 -!- krator44-- is now known as krator44 12:40:29 advil: re the indent issue, if you mean the two if statements aligned then iirc that's intended 12:40:48 er, is it? 12:40:55 that's not consistent with our style guide 12:41:42 why not indent the second if? 12:41:56 yeah, I'll have to clean that up 12:42:40 it would be more readable that way, yeah 12:43:10 re highlight_colour, I believe that's set by the set_bg_colour call 12:43:41 oh, I see your later message 12:44:36 I think I fixed one case in 8e49684 but not webtiles console 12:44:52 hopefully the change I made doesn't have other weird effects 12:47:04 https://github.com/crawl/crawl/blob/8e49684493dd1e23c8c1895dc7ea41949897b6d1/crawl-ref/source/newgame.cc#L1213 12:47:24 that looks like it'd be a hbox on webtiles 12:50:43 if that were changed to USE_TILE_LOCAL, I believe it'd work, although it might break the menu serialization in outer-menu.cc for webtiles 12:50:59 sorry, away from my computer at the moment 13:02:04 no problem 13:02:05 ah I see 13:03:11 that would also prevent displaying an icon for webtiles browser, though, right? 13:06:45 seems like maybe webtiles just needs a more complicated dynamic cast 13:07:09 sort of ugly, but it is what it is 13:08:33 Unstable branch on crawl.akrasiac.org updated to: 0.24-a0-697-g8e49684 (34) 13:10:43 03advil02 07* 0.24-a0-698-g60d090b: Fix a shadowed variable warning in webtiles 10(21 seconds ago, 1 file, 3+ 3-) 13https://github.com/crawl/crawl/commit/60d090ba07fc 13:17:35 Unstable branch on crawl.kelbi.org updated to: 0.24-a0-698-g60d090ba07 (34) 13:31:19 Hi there. I hope someone here can help me. I'm trying to setup bcrawl on my server. I got it to compile and install into the correct directories. But when I try to run it I get this error: 13:31:21 https://pastebin.com/ADmDNMxk 13:31:43 Do I still need to change the /bin/crawl-git-launcher.sh file for this to work? 13:37:14 that makes it look like your script is running something like `/path/to/crawl bcrawl` 13:37:52 This is what it's actually running: 13:37:53 ("dcss-bcrawl", dict( 13:37:54 morgue_url = "http://dobrazupa.org/morgue/%n/", 13:38:18 I got these options from another server owner. But Discord is down currently haha 13:39:02 that looks like the branch selection from the python file, it's not what's actually getting run at the command line 13:39:51 Yeah sorry I said it wrong. That is indeed the setting for webtiles to show the game on the page 13:40:04 But that's usually the only thing that is needed to setup a game 13:41:51 well, I don't know much about setting up forks, but the error there is the message you'd get by running crawl with "bcrawl" as an argument 13:42:15 Maybe I'll just remove the pre_option. Maybe it will run 13:42:21 I'll give it a try 13:46:01 No that did not solve it. I could have known that haha. 13:46:12 That just started trunk dcss 13:46:21 Namanix: I think more edifying would be the configuration file(s) you have edited to produce this 13:46:46 Pinkbeast Sorry what do you mean? :) 13:47:21 Namanix: Can you be more clear about which bit of that is confusing? 13:47:37 e.g. what's the rest of the dict that you started pasting above...though for anything more than a few lines pastebin > pasting in this channel 13:50:04 This is my config.py file: https://pastebin.com/phtkvQgn 13:50:24 Please note: I have removed the binding addresses from the file for uploading to pastebin 13:50:49 Well, yeah, pre_options is bogus 13:51:25 ok, yes, I would guess that whatever server owner you got this from has modified crawl-git-launcher.sh to handle `bcrawl` in pre_options 13:52:04 Yeah I thought so. I will try to contact him again when discord is back up 13:52:39 Another option would be to create and edit a copy of it as bcrawl-launcher.sh and do a bit of fettling to make it get copied into the chroot 13:52:54 I dunno what the preferred approach is 13:55:06 I can also try that indeed. Good suggestion. I will see if I can make it work. Thanks :) 13:55:42 I guess your interlocutor on Discord is "alex"; if so, floraline who runs CKO is sometimes found here and must have addressed the same issue 13:59:20 Oh damn that was a dumb mistake 13:59:28 Fixed it already. 13:59:30 crawl_binary = "/bin/crawl-git-launcher.sh", 13:59:33 needs to be 13:59:37 crawl_binary = "/bin/crawl-stable-launcher.sh", 14:00:05 I'm glad you said that because I'd never have guessed _that_ :-/ 14:00:58 Namanix: I'm guessing you're looking at floraline's configs, you might want to look at the whole repository 14:01:06 if you're not already 14:01:23 I'm not. Can you send me a link? 14:01:30 e.g. here is the commit that first added forks to CKO: https://github.com/floraline/dgamelaunch-config/commit/e30a19a739dca144e4ea9bc6e59ad68f5ab7fbcd#diff-3604750e9fffc71418e0900ee1c50390 14:01:50 https://github.com/floraline/dgamelaunch-config/tree/cko 14:01:54 Pinkbeast It almost felt like a lucky find haha. 14:02:06 need to be looking at the cko branch in particular (which that link goes to) 14:02:54 Well this would have been helpful at the beginning of the day haha. 14:03:03 But I can still get some nice things from here. Thank you! 14:03:44 It took us longer than we expected and we didn't have this particular hurdle 14:06:51 What server do you run Pinkbeast? 14:07:09 crawl.montres.org.uk - Stoat Soup. Not one of the real servers. :-) 14:07:43 We started with vanilla 0.20 but just started building that out of our repository so the server doesn't have any forks from its POV 16:27:53 huh 16:27:56 sizzell still exists 16:27:59 %dump 16:27:59 No where information for gammafunk. 16:28:33 |amethyst: not sure if you care, but you can probably take Sizzell offline, unless that's still serving some purpose 16:29:04 |amethyst: also, I don't know if you saw, but the newfedhas branch gives ballistomycetes a spell called Sporulate, which I hope you appreciate 17:09:36 Unstable branch on crawl.s-z.org updated to: 0.24-a0-698-g60d090ba07 (34) 17:10:40 Experimental (bcrawl) branch on crawl.s-z.org updated to: 0.23-a0-2457-gf0d5a3770a 17:13:32 03advil02 07* 0.24-a0-699-g5a66b1a: Fix(ish) for menu highlighting issues in webtiles console 10(4 minutes ago, 1 file, 15+ 0-) 13https://github.com/crawl/crawl/commit/5a66b1aa3b36 17:14:10 aidanh: feel free to do something better than ^ if you know what the right thing is 17:18:35 Unstable branch on crawl.kelbi.org updated to: 0.24-a0-699-g5a66b1aa3b (34) 17:59:05 oh heh I bet that commit will accidentally fix the weapon selection case too 17:59:45 ok no 18:01:22 though it's the same problem 18:04:53 The build was broken. (master - 5a66b1a #11937 : advil): https://travis-ci.org/crawl/crawl/builds/590913598 18:10:22 that's apparently an internal link error?? 18:11:06 03advil02 07* 0.24-a0-700-g7b85b32: Slightly improve console MenuButton highlighting code 10(3 minutes ago, 1 file, 12+ 9-) 13https://github.com/crawl/crawl/commit/7b85b324446e 18:14:58 aidanh: odd glitch: in webtiles console, in the weapon selection menu, unarmed is somewhere strange. If you scroll down to it the rest of the menu scrolls and it doesn't display, you can get it to display at the bottom by itself by then hitting down then up 18:15:04 looks fine via a browser client 18:17:42 Unstable branch on crawl.kelbi.org updated to: 0.24-a0-700-g7b85b32444 (34) 18:23:44 Unstable branch on underhound.eu updated to: 0.24-a0-699-g5a66b1aa3b (34) 18:28:24 03advil02 07* 0.24-a0-701-g6234c29: Address an uninitialized variable 10(79 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/6234c29d7a08 18:29:35 did that generate a compiler warning even? 18:30:15 no 18:30:35 I don't think cases like that usually do 18:31:28 at least, other ones I've found haven't, like 18:31:30 %git 6074511092ad 18:31:30 07advil02 * 0.24-a0-250-g6074511: Initialize `you.trapped` to false 10(6 months ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/6074511092ad 18:31:48 I'm not 100% sure it was even a problem 18:32:52 Unstable branch on crawl.kelbi.org updated to: 0.24-a0-701-g6234c29d7a (34) 18:33:29 but it's something that popped out when looking at the weapon menu code 18:41:36 ok, I think I figured out the unarmed thing 18:42:45 03advil02 07* 0.24-a0-702-gaeb99fb: Fix another webtiles console menu glitch 10(51 seconds ago, 1 file, 13+ 1-) 13https://github.com/crawl/crawl/commit/aeb99fb3f2b4 18:43:11 aidanh also you probably want to double check aeb99fb 18:47:50 Unstable branch on crawl.kelbi.org updated to: 0.24-a0-702-gaeb99fb3f2 (34) 19:01:38 The build is still failing. (master - 7b85b32 #11938 : advil): https://travis-ci.org/crawl/crawl/builds/590926940 19:10:33 -!- amalloy is now known as amalloy_ 19:28:23 The build is still failing. (master - 6234c29 #11939 : advil): https://travis-ci.org/crawl/crawl/builds/590931075 19:38:43 still failing 😱 19:50:36 The build is still failing. (master - aeb99fb #11940 : advil): https://travis-ci.org/crawl/crawl/builds/590934309 20:14:17 -!- Gruppert is now known as YayItsMe 23:12:05 anyone have any ideas? 23:12:14 it's not even failing on crawl, that's an internal link error on monster 23:12:56 consistently on gcc fulldebug