01:21:19 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-2448-g480fa8fc68 02:48:25 Monster database of master branch on crawl.develz.org updated to: 0.24-a0-443-g80245de 03:41:55 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-2449-g696c4cd9b6 09:23:20 Stable (0.22) branch on underhound.eu updated to: 0.22.1-59-ge965b3aba3 09:33:18 -!- amalloy is now known as amalloy_ 11:04:29 Johnny (L21 DgGl) ASSERT(defender->alive()) in 'fight.cc' at line 121 failed. (Depths:1) 11:13:29 !crashlog 11:13:48 21192. Johnny, XL21 DgGl, T:50625 (milestone): https://underhound.eu/crawl/morgue/Johnny/crash-Johnny-20190922-150428.txt 11:15:35 that's two so far. something about rakshasa illusions? 11:25:00 Stable (0.23) branch on underhound.eu updated to: 0.23.1-89-g277498a001 16:05:22 -!- zoid is now known as zoxo 16:05:29 -!- zoxo is now known as zoid 16:24:17 -!- amalloy_ is now known as amalloy 16:49:50 -!- zoid is now known as ihateyouall 16:50:06 -!- ihateyouall is now known as zoid 19:28:16 I am trying to write a fix to issue #891 that Arena exits when you have a typo in the name of your monsters 19:28:46 I think I have succeeded, should I proceed with a pull request? Do I need to clone to my branch before I do, or is master okay? (git noob) 19:29:09 PR from master is fine 19:29:28 okay thank you for clarifying 19:30:15 New branch created: pull/1153 (6 commits) 13https://github.com/crawl/crawl/pull/1153 19:30:16 03John Stilley02 {GitHub} 07https://github.com/crawl/crawl/pull/1153 * 0.24-a0-585-gddfcd3f: #984 making text more clear for mutation 10(3 weeks ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/ddfcd3f28af4 19:30:16 03John Stilley02 {GitHub} 07https://github.com/crawl/crawl/pull/1153 * 0.24-a0-586-ga1d924b: #984 make it seem more positive 10(2 weeks ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/a1d924bc89e8 19:30:16 03theJollySin02 07https://github.com/crawl/crawl/pull/1153 * 0.24-a0-587-g9fe8710: adding some good quotes 10(3 days ago, 1 file, 14+ 5-) 13https://github.com/crawl/crawl/commit/9fe871038474 19:30:16 03John Stilley02 {GitHub} 07https://github.com/crawl/crawl/pull/1153 * 0.24-a0-588-g9df8b30: some good quotes, I think 10(29 hours ago, 1 file, 11+ 5-) 13https://github.com/crawl/crawl/commit/9df8b303d5ba 19:30:16 03theJollySin02 07https://github.com/crawl/crawl/pull/1153 * 0.24-a0-589-ga7913f4: cleaning up all these Paradise Lost quotes 10(27 hours ago, 1 file, 5+ 5-) 13https://github.com/crawl/crawl/commit/a7913f4c0ac0 19:30:16 03theJollySin02 07https://github.com/crawl/crawl/pull/1153 * 0.24-a0-590-g537b346: quoting the buddah 10(34 minutes ago, 1 file, 3+ 1-) 13https://github.com/crawl/crawl/commit/537b346b6f74 19:34:58 those quotes all seem cool to me but i'm not sure what i need to know in order to merge. do we have to worry about IP rights at all for this stuff? these are all pretty old quotes so probably fine but as a non-lawyer i'm a little hesitant to just dive in 19:36:47 amalloy: you need to research the works copyrights 19:39:27 nethack does this too so I wonder how they do it 19:41:43 "No permission is needed for any material in the public domain;". So if you can find it in projectgutenberg.com you should be fine as I understand it 19:41:54 it's .org* 19:44:45 p0a: you seemed to have pulled in some commits from PR 984 into your PR 1153 19:46:58 I haven't done anything yet 19:47:07 I am not Stilley or JollySin 19:47:38 I still can't figure out what to do on github.com to be honest. I'm a bit confused, since my master is local. reading the docs to figure out how to use github 19:49:43 ah, thought you were the author, given your response 19:50:03 guess I'll have to leave some notes about that and their commit message style 19:50:28 looks like for both the PR and the one that PR accidentally copied as well 19:59:04 ah there's a git.txt in the docs that explains how to do it 20:02:27 New branch created: pull/1154 (1 commit) 13https://github.com/crawl/crawl/pull/1154 20:02:27 03Nikolai Lavsky02 07https://github.com/crawl/crawl/pull/1154 * 0.24-a0-640-gfd6cd4e: Fix a crash when cloning an almost dead monster (geekosaur) 10(11 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/fd6cd4e06c71 20:28:11 I suppose if I'm so incompetent I can't even do a PR maybe I shouldn't, but I persist: Does anyone know why I get a 403? I uploaded my SSH key on github.com and commit'ed and then $ git push 20:29:31 Quote the output verbatim 20:29:45 remote: Permission to crawl/crawl.git denied to createyourpersonalaccount. 20:29:45 fatal: unable to access 'https://github.com/crawl/crawl.git/': The requested URL returned error: 403 20:29:45 20:30:12 You're trying to push changes directly to the Crawl developers' repository. 20:30:42 You want instead to use github's facility to "fork" a repository, making a repository of your own, and push changes to that. 20:30:57 how do I propose a bugfix after that is done? 20:31:19 Once you have a change there, there's a facility to propose it as a PR to upstream. 20:32:43 ok got it thank you 20:32:44 415202 20:32:47 Whoops 20:33:13 https://guides.github.com/activities/hello-world/ covers this. This isn't the only way projects take PRs, but it is the githubby way, and it's how vanilla does it. 20:34:25 Actually https://guides.github.com/activities/forking/ might be more help here. 20:34:53 thank you 20:45:23 New branch created: pull/1155 (1 commit) 13https://github.com/crawl/crawl/pull/1155 20:45:23 03John Doe02 07https://github.com/crawl/crawl/pull/1155 * 0.24-a0-640-g47e2a0e: Fixes Issue #891 where Arena crashed if the monster name had a typo in it. Now it just informs the user of the error and asks again. 10(6 minutes ago, 1 file, 4+ 1-) 13https://github.com/crawl/crawl/commit/47e2a0eddea7 20:46:02 There that's mine :D 20:55:43 ah forgot to remove whitespace I think 20:59:19 anyway I will wait to see what happens to this first ever PR 20:59:22 thanks for the help 23:27:27 Forgeling (L25 GnMo) ASSERT(defender->alive()) in 'fight.cc' at line 121 failed. (Depths:5) 23:37:41 03Nikolai Lavsky02 {Aidan Holm} 07* 0.24-a0-640-ge7cd8ce: Fix a crash when cloning an almost dead monster (geekosaur) 10(4 hours ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/e7cd8ce796b2 23:47:57 Unstable branch on crawl.kelbi.org updated to: 0.24-a0-640-ge7cd8ce796 (34)