00:37:41 <Eksell> Unstable branch on CRAWL.XTAHUA.COM updated to: 0.24-a0-520-g8fd06ad0bc (34)
00:39:14 <Eksell> Stable (0.23) branch on CRAWL.XTAHUA.COM updated to: 0.23.1-82-g5129a83184
01:42:33 <floraline> crawl user is running gdb on my system for a long time
01:42:47 <floraline> does anyone know why / what it's doing?
01:45:41 <floraline> it appears to be attached to a player's game session
01:49:45 <alexjurkiewicz> crawl crashed
01:49:57 <alexjurkiewicz> gdb gets run with a short little script to generate the crashlogs you might have seen posted in here
01:50:06 <alexjurkiewicz> sometimes it seems to get stuck / take a really long time
01:50:41 <alexjurkiewicz> if it's been like, more than 15 mins, you should probably just kill -9 gdb and crawl will produce some sort of truncated / broken crash log, but at least it won't be spinning infinitely any more
01:51:54 <floraline> it's been 34 hours
01:52:13 <floraline> i just got a high cpu alert about it
01:52:26 <floraline> it's running on a fork so i guess maybe something went wrong there
01:52:34 <alexjurkiewicz> lol
01:52:42 <alexjurkiewicz> yeah. I saw it with dcss-ca lots
01:54:06 <Pinkbeast> ... when you say _a_ fork, tell me it's not us
01:54:36 <floraline> not you :P
01:54:44 <Pinkbeast> phew
01:56:23 <floraline> i've had to restart for updates for .. a long time, have yet to do it
02:09:59 <alexjurkiewicz> Q: what is the difference between holiness and undead type?
02:10:30 <alexjurkiewicz> I mean, I can see that they affect slightly different parts of the codebase. But why are they separate concepts?
02:15:49 <alexjurkiewicz> there is also species_flags, which again is similar
02:19:03 <amalloy> what would you do instead?
02:19:21 <amalloy> i don't mean this as dismissive or something, like the way it is is the only thing that makes sense
02:53:28 <amalloy> but rather just, i don't see an immediately-obvious best way
03:00:52 <alexjurkiewicz> me either. I noticed this problem when I converted mummy/zombie/vampire to modifiers that can be applied to any species in bloatcrawl
03:01:41 <alexjurkiewicz> in vanilla right now the undead state of the player doesn't actually control a bunch of things which you'd think. For example torment resistance for undead species comes from a specific mutation they have, rather than an innate property of being != US_ALIVE
03:02:32 <alexjurkiewicz> but there is also the state of "non-living", for statueform and gargoyle. Which isn't an undead type, but it *is* a holiness.
03:05:20 <alexjurkiewicz> I think probably it's a matter of sitting down, figuring out what all three of those things do individually, then looking at a better way to put all those properties in one place, preferably explicitly tied to species in the species.yaml files. But it is a big project, so I don't just want to dive in and end up with another year-long PR
03:19:55 <alexjurkiewicz> funny if true https://www.reddit.com/r/dcss/comments/cgm155/whats_up_with_lamp_of_fire_and_being_invisible/
03:25:42 <amalloy> alexjurkiewicz: looks like the problem is lamp of fire uses cell_see_cell, which afaict cares about the actor in the cell
03:25:42 <amalloy> like i haven't debugged it in detail but that is the suspicious thing
03:25:58 <Rotatell> Unstable branch on crawl.beRotato.org updated to: 0.24-a0-520-g8fd06ad (34)
04:04:57 -!- amalloy is now known as amalloy_
05:54:08 <Cheibriados> New branch created: pull/1119 (1 commit) 13https://github.com/crawl/crawl/pull/1119
05:54:08 <Cheibriados> 03giann02 07https://github.com/crawl/crawl/pull/1119 * 0.24-a0-480-gecb1320: New morgue section `screenshots` 10(17 minutes ago, 4 files, 33+ 3-) 13https://github.com/crawl/crawl/commit/ecb1320b27e7
05:54:19 <bgiannan> advil, here's a PR for the snapshot feature i suggested earlier: https://github.com/crawl/crawl/pull/1119
05:54:27 <bgiannan> for now i only take screenshots when the user takes a note
05:54:44 <bgiannan> ultimately i think that's the best case for it
06:04:47 <Cheibriados> 03giann02 07https://github.com/crawl/crawl/pull/1119 * 0.24-a0-480-ga13f1a6: New morgue section `screenshots` 10(28 minutes ago, 5 files, 34+ 4-) 13https://github.com/crawl/crawl/commit/a13f1a6dfa72
09:09:50 <bgiannan> alexjurkiewicz, is https://github.com/zxc23/dcss-scoreboard abandoned?
11:21:48 <Lantell> Stable (0.23) branch on underhound.eu updated to: 0.23.1-82-g5129a83184
12:46:38 -!- amalloy_ is now known as amalloy
13:12:09 <aidanh> amalloy: would you mind if I privmsg you briefly?
13:27:21 <Henzell> Unstable branch on crawl.akrasiac.org updated to: 0.24-a0-520-g8fd06ad (34)
18:22:18 <Lantell> Unstable branch on underhound.eu updated to: 0.24-a0-520-g8fd06ad0bc (34)
18:37:21 <alexjurkiewicz> bgiannan: yeah basically
18:37:42 <alexjurkiewicz> bgiannan: it's not in use, and I dont develop it
18:47:06 -!- amalloy is now known as amalloy_
19:31:14 <Psymania> Hello, I am preparing to submit a pull request for the feature I was working on a while back. I need a small amount of help with the process. I've created a local branch named after the feature and committed my changes (with a verbose commit message) into the branch. Would I do a "push" next, and if so, can someone confirm the proper syntax for the push command? I've never used git before, so please pardon my n00bhood :)
19:32:25 <alexjurkiewicz> have you forked the repo on github?
19:32:58 <alexjurkiewicz> https://github.com/firstcontributions/first-contributions
19:33:13 <Psymania> No. I just checked out the master tree to my machine and created a branch locally
19:34:05 <Psymania> Oh, I see, so I fork a repository on my GitHub account, and push my changes to that repository?
19:50:06 <Psymania> https://github.com/GnarledBeach/crawl
19:50:42 <Psymania> ^ alexjurkiewicz, I forked the repository here (sorry my username on Github is different than it is here and on the Crawl forum, I hope that won't cause any issues), and pushed my changes into a "threat_indicators" branch -- would submitting the PR be the next step?
19:55:46 <alexjurkiewicz> Psymania: yep!
19:56:25 <Psymania> Great, ty :)
19:56:25 <alexjurkiewicz> you can drag and drop screenshots directly into the pull request textbox, btw
19:56:33 <Psymania> Oh okay, cool :)
19:59:51 <Psymania> alexjurkiewicz, Should I be creating the pull request on the official repository? If so, I'm not sure how to select my branch, since it's only pushed to my repository, and not the official repository
20:38:38 <alexjurkiewicz> Psymania: you should. A pull request can be from a source branch in one fork to a destination branch in another repository from the same family tree
20:39:01 <alexjurkiewicz> in your case, you want to pull request from your branch to crawl/crawl's master branch
20:39:36 <alexjurkiewicz> it will appear in the list at github.com/crawl/crawl/pulls if you've done it right. If it appears at github.com/GnarledBeach/crawl/pulls, you've done it wrong :)
20:44:51 <Psymania> Okay great, thank you. Whee! I submitted it.
20:49:29 <Cheibriados> New branch created: pull/1120 (1 commit) 13https://github.com/crawl/crawl/pull/1120
20:49:29 <Cheibriados> 03Psymania02 07https://github.com/crawl/crawl/pull/1120 * 0.24-a0-521-g8ed18f8: Add threat level indicators for monsters in offline tiles 10(64 minutes ago, 11 files, 52+ 0-) 13https://github.com/crawl/crawl/commit/8ed18f86d5a2
20:50:00 <Psymania> :0
20:53:51 <alexjurkiewicz> :D
21:16:47 -!- amalloy_ is now known as amalloy
21:38:37 <crusius> anyone with experience building dfdgsdfg's crawl-docker image? i had 0.23.0 running, but am getting an error trying to build 0.23.2.
21:38:49 <crusius> compiling initfile.o
21:39:05 <crusius> https://github.com/dfdgsdfg/crawl-docker
22:25:38 <alexjurkiewicz> never tried it, but looking now
22:28:45 <crusius> thanks, i also tried to build https://bitbucket.org/TZer0/crawl-docker/src/master/ but that fails to build almost immediately
22:29:12 <crusius> and now i'm playing with https://hub.docker.com/r/echo35/crawl. haha, if anyone has a docker image they recommend i'm game to try it out
22:29:24 <crusius> the second link supposedly supports multiple versions which would be cool, but not strictly necessary
22:35:53 <alexjurkiewicz> could a developer please create releases in Github for 0.23.2 and 0.22.2 https://github.com/crawl/crawl/releases ?
22:36:17 <alexjurkiewicz> It will let you download a zip of the source directly from Github for those tags
22:36:22 <alexjurkiewicz> crusius: i'll have a play, but will take a few hours
23:14:06 <gammafunk> someone made something more elaborate some time ago
23:14:24 <gammafunk> I forget the tech they used, but it was more comprehensive than just docker
23:14:43 <crusius> those releases exist btw, but they're collapsed at the top. it doesn't look like they were tagged with latest release
23:15:17 <gammafunk> yeah I think github makes tgz of all annotated tags
23:16:00 <gammafunk> oh
23:16:02 <gammafunk> just click tags
23:16:23 <gammafunk> alexjurkiewicz: click tags and you can get those zips
23:16:54 <gammafunk> but those didn't used to compile directly
23:17:03 <gammafunk> since our compilation process requires a git repo
23:17:07 <gammafunk> not sure if that's been fixed
23:26:32 <bgiannan> alexjurkiewicz, too bad, was looking good
23:44:35 <alexjurkiewicz> The problem I had was that scoring *all* crawl games is a real PITA in a bunch of corner case ways. Lots of old servers don't have logfile accessible anywhere but the hard drive of Sequell, weird old formats, etc etc. We solved most of those but it was a slog
23:45:03 <alexjurkiewicz> If you take that codebase and score just the last year of games or something, it would pretty much work fine
23:46:19 <alexjurkiewicz> crusius: the build worked for me with 0.23.2 and the following change: +RUN pip install PyYAML tornado==3.2.2
23:49:07 <crusius> weird, yeah i had already added the pyyaml but i've bombed out twice on initfile
23:49:33 <bgiannan> alexjurkiewicz, i can't seem to find the sources.py file mentionned in the README
23:49:55 <crusius> {standard input}:73984: Error: invalid operands (*UND* and .gcc_except_table sections) for `-'
23:53:15 <alexjurkiewicz> crusius: the build command i used was `docker build --build-arg CRAWL_VERSION=0.23.2 -t crawl .`
23:53:47 <alexjurkiewicz> the python source image I used was 3edf9092825f (10 days ago)
23:53:52 <alexjurkiewicz> Docker version 18.09.2, build 6247962
23:54:24 <alexjurkiewicz> bgiannan: ah. That might be out of date. We pulled a part of the scoreboard out into its own service. The part that downloads games and parses them into a dictionary
23:54:41 <alexjurkiewicz> bgiannan: that part is now handled by https://github.com/Kramin42/Crawl-Log-Api
23:54:58 <alexjurkiewicz> bgiannan: dcss-scoreboard just makes http requests to that service to get new games
23:55:15 <alexjurkiewicz> Kramin runs an instance of that API you can point your scoreboard to
23:55:32 <alexjurkiewicz> you can contact him on the roguelikes general discord or crawl-anz's
23:57:16 <Eksell> Stable (0.23) branch on CRAWL.XTAHUA.COM updated to: 0.23.1-82-g5129a83184