00:00:01 <Eksell> Unstable branch on CRAWL.XTAHUA.COM updated to: 0.24-a0-500-g46574c2197 (34)
00:01:32 <Eksell> Stable (0.23) branch on CRAWL.XTAHUA.COM updated to: 0.23.1-82-g5129a83184
00:21:36 <alexjurkiewicz> whoops
00:23:18 <alexjurkiewicz> !tell gammafunk can you check my des pr https://github.com/crawl/crawl/pull/1112
00:23:19 <Sequell> alexjurkiewicz: OK, I'll let gammafunk know.
00:24:42 <Cheibriados> New branch created: pull/1112 (1 commit) 13https://github.com/crawl/crawl/pull/1112
00:24:42 <Cheibriados> 03alexjurkiewicz02 {GitHub} 07https://github.com/crawl/crawl/pull/1112 * 0.24-a0-501-gb5bb29d: Mark two unrand vaults no_tele_into 10(3 minutes ago, 1 file, 15+ 12-) 13https://github.com/crawl/crawl/commit/b5bb29d5d200
01:26:28 <Cheibriados> 03alexjurkiewicz02 {Aidan Holm} 07* 0.24-a0-501-gc560d0b: Mark two unrand vaults no_tele_into 10(64 minutes ago, 1 file, 15+ 12-) 13https://github.com/crawl/crawl/commit/c560d0b20cfb
01:27:55 <alexjurkiewicz> that ccaching is great
01:28:21 <alexjurkiewicz> does the morgue show game time in auts anywhere
01:32:16 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.24-a0-501-gc560d0b20c (34)
01:37:10 <Cheibriados> New branch created: pull/1113 (1 commit) 13https://github.com/crawl/crawl/pull/1113
01:37:10 <Cheibriados> 03EC2 Default User02 07https://github.com/crawl/crawl/pull/1113 * 0.24-a0-501-g9aaae79: Fix wizdump loading when rotted or Gozag follower. 10(7 minutes ago, 1 file, 4+ 2-) 13https://github.com/crawl/crawl/commit/9aaae79b2308
02:09:31 <Gretell> Windows builds of master branch on crawl.develz.org updated to: 0.24-a0-501-gc560d0b
02:43:36 <aidanh> gmarks: re losglobal, you might try looking at the git log / git blame for that file
02:43:46 <aidanh> er, those files
02:48:28 <Gretell> Monster database of master branch on crawl.develz.org updated to: 0.24-a0-443-g80245de
03:12:48 <Rotatell> Unstable branch on crawl.beRotato.org updated to: 0.24-a0-501-gc560d0b (34)
03:18:45 <Cheibriados> 03Aidan Holm02 07* 0.24-a0-502-ge6e1909: Fix visual jump when toggling floor / inv items 10(10 minutes ago, 1 file, 3+ 1-) 13https://github.com/crawl/crawl/commit/e6e1909c8648
03:19:44 <Cheibriados> 03Aidan Holm02 07* 0.24-a0-503-gb815cdf: Fix spurious key events when adjusting map zoom 10(4 days ago, 1 file, 9+ 1-) 13https://github.com/crawl/crawl/commit/b815cdf0ff89
03:32:27 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.24-a0-503-gb815cdf0ff (34)
03:32:59 <Kelbell> Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-2169-g9c35b9724a
05:39:59 -!- amalloy is now known as amalloy_
07:25:25 <gammafunk> %git
07:25:25 <Cheibriados> 07Aidan Holm02 * 0.24-a0-503-gb815cdf: Fix spurious key events when adjusting map zoom 10(4 days ago, 1 file, 9+ 1-) 13https://github.com/crawl/crawl/commit/b815cdf0ff89
07:25:26 <Sequell> gammafunk: You have 1 message. Use !messages to read it.
07:25:49 <gammafunk> %git HEAD~1
07:25:49 <Cheibriados> 07Aidan Holm02 * 0.24-a0-502-ge6e1909: Fix visual jump when toggling floor / inv items 10(4 hours ago, 1 file, 3+ 1-) 13https://github.com/crawl/crawl/commit/e6e1909c8648
07:26:00 <gammafunk> !gitgrep no_tele_into
07:26:01 <Sequell> %git HEAD^{/}
07:26:01 <Cheibriados> 07Aidan Holm02 * 0.24-a0-503-gb815cdf: Fix spurious key events when adjusting map zoom 10(4 days ago, 1 file, 9+ 1-) 13https://github.com/crawl/crawl/commit/b815cdf0ff89
07:26:10 <gammafunk> !gitgrep 1 no_tele_into
07:26:11 <Sequell> %git HEAD^{/no_tele_into}
07:26:11 <Cheibriados> 07alexjurkiewicz02 {Aidan Holm} * 0.24-a0-501-gc560d0b: Mark two unrand vaults no_tele_into 10(7 hours ago, 1 file, 15+ 12-) 13https://github.com/crawl/crawl/commit/c560d0b20cfb
07:27:14 <gammafunk> What's in this commit message is incorrect: that we mark vaults no_tele_into simply because they have transporters or have runed doors
07:27:48 <gammafunk> generally there should be mitigating circumstances for us to add spoilers like that, and runed doors/transporters aren't by themselves enough of a reason
07:29:11 <gammafunk> I wouldn't really say either vault quite warrants the addition of no_tele_into since they don't employ anything particularly nasty for their depth
07:42:35 <gammafunk> an example of where we did add no_tele_into: tedronai's silence transporter vault, since teleporting into a silence field is something players wouldn't otherwise ever experience in Dungeon/Depths
07:44:14 <aidanh> hrm, guess I should have left that one then :A/
07:47:07 <gammafunk> I guess you could sort of argue it for the orange statue vault since 4 ocs in los is kind of extreme, but the zot one is just some dragons and moths of wrath; certainly nasty, but nasty things from random teleports in zot are supposed to be a thing
07:47:41 <gammafunk> more my concern was people thinking that runed door or transporter = no_tele_into
07:48:18 <gammafunk> which is something we could actually do, but it would need to done automatically when those features place, and I'm not sure it's a very good idea
07:48:48 <gammafunk> it's hard to communicate it to the player, although I guess we could indicate it in the feature description
07:52:29 <aidanh> I must confess I'd always assumed runed doors / transporters meant no_tele_into
07:52:31 <aidanh> TIL
10:18:22 <Cheibriados> 03advil02 07[incremental_pregen] * 0.24-a0-516-g699d97c: Handle certain random attack specs differently 10(14 minutes ago, 9 files, 55+ 16-) 13https://github.com/crawl/crawl/commit/699d97ca28ba
10:18:25 <Cheibriados> 03advil02 07https://github.com/crawl/crawl/pull/1094 * 0.24-a0-516-g699d97c: Handle certain random attack specs differently 10(14 minutes ago, 9 files, 55+ 16-) 13https://github.com/crawl/crawl/commit/699d97ca28ba
11:20:56 <Lantell> Stable (0.23) branch on underhound.eu updated to: 0.23.1-82-g5129a83184
11:21:34 <advil> lol of an 18 min qw run, according to my profiler, crawl spent 7.3 minuts in CrawlHashTable::assert_validity()
11:30:36 <ebering> clearly we need a define to skip hashtable validity checks
11:30:36 <Sequell> ebering: You have 1 message. Use !messages to read it.
11:31:03 <ebering> %git 1074bba3cf7
11:31:03 <Cheibriados> 07reaverb02 * 0.24-a0-499-g1074bba: Ensure Bat Form warns about Stat Zero (Mantis #12006) 10(2 days ago, 1 file, 92+ 4-) 13https://github.com/crawl/crawl/commit/1074bba3cf70
11:35:55 <advil> ebering it is already skippe don non-debug builds
11:35:59 <advil> *skipped on
11:36:10 <ebering> dang
11:36:30 <advil> mostly what is happening, I think, is that qw checks artifact props *constantly* if it has any
12:10:14 <Cheibriados> 03wjchen02 07https://github.com/crawl/crawl/pull/1091 * 0.24-a0-462-g983b59b: Making requested changes (PR #1091) 10(11 hours ago, 5 files, 95+ 88-) 13https://github.com/crawl/crawl/commit/983b59b62ac4
12:10:14 <Cheibriados> 03wjchen02 07https://github.com/crawl/crawl/pull/1091 * 0.24-a0-463-g7d74556: Checkwhite (PR #1091) 10(6 minutes ago, 2 files, 0+ 2-) 13https://github.com/crawl/crawl/commit/7d745568b19f
13:05:30 <Henzell> Unstable branch on crawl.akrasiac.org updated to: 0.24-a0-503-gb815cdf (34)
13:19:30 <Cheibriados> New branch created: pull/1114 (1 commit) 13https://github.com/crawl/crawl/pull/1114
13:19:30 <Cheibriados> 03Nikolai Lavsky02 07https://github.com/crawl/crawl/pull/1114 * 0.24-a0-504-g8bde97e: Update scroll of brand weapon description 10(6 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/8bde97ea48e2
14:28:02 -!- amalloy_ is now known as amalloy
15:03:14 -!- Tiobot is now known as Guest84137
15:46:35 <Cheibriados> 03nlavsky02 {amalloy} 07* 0.24-a0-504-gcfb02b9: Update scroll of brand weapon description (#1114) 10(12 seconds ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/cfb02b9d073a
16:02:19 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.24-a0-504-gcfb02b9d07 (34)
16:55:49 <Cheibriados> 03advil02 07[incremental_pregen] * 0.24-a0-517-gfae6558: Isolate trove portal generation from levelgen rng 10(6 minutes ago, 4 files, 54+ 3-) 13https://github.com/crawl/crawl/commit/fae65583897c
16:55:51 <Cheibriados> 03advil02 07https://github.com/crawl/crawl/pull/1094 * 0.24-a0-517-gfae6558: Isolate trove portal generation from levelgen rng 10(6 minutes ago, 4 files, 54+ 3-) 13https://github.com/crawl/crawl/commit/fae65583897c
16:58:30 <gammafunk> advil: reading that trove rng isolation commit  made me wonder if there's some kind of enum system for lua that people use; I've used that same approach of checking a string argument to determine state a lot, but it feels bad
16:59:48 <advil> I don't think so, not as part of standard lua at least
17:00:54 <gammafunk> maybe a lua expert would tell me that if your program is so complex that the use of strings there is a problem, you shouldn't be using lua...
17:03:06 <advil> I think it's relatively normal in scripting land to not use formalized enums like c does
17:03:50 <advil> python only added any kind of enum support in python 3 (iirc) and you can tell it's still not really a good fit for the language
17:04:43 <advil> if it were all lua code you could define an enum manually, you see that sometimes in builder code (just a sequence of THING = 0, THING2 = 1, etc)
17:05:24 <advil> but given that this is crossing the boundary even that is more trouble than it's worth
17:06:22 <advil> another things one could do is define a const static map between the rng_type enum and some strings, and use that to do the conversion instead of a hand-rolled if sequence, but that also seems more trouble than it's worth
17:06:55 <Pinkbeast> There's no equivalent to Perl's "map" ?
17:08:40 <Pinkbeast> (with which one can do $index = 0; map {$$_ = $index; $index++} qw(THING THING2 THING3);
17:10:04 <advil> I don't think so
17:10:18 <advil> I mean, there's probably shorter ways to define a sequence like that than what I gave
17:11:06 <Pinkbeast> Pity. It's particularly handy for powers-of-two flags, where it's easy to balls up writing it manually
18:21:41 <Lantell> Unstable branch on underhound.eu updated to: 0.24-a0-504-gcfb02b9d07 (34)
20:55:26 <Cheibriados> qazlal storm clouds generating noise even when no clouds present 13https://crawl.develz.org/mantis/view.php?id=12025 by Ketziah
21:12:22 <amalloy> that sounds expected to me, yeah? qazlal makes clouds as an upside, and noise as a downside; qazlal doesn't make clouds that make noise
21:12:54 -!- amalloy is now known as amalloy_
21:28:32 <alexjurkiewicz> it's intentional in the code, but I would argue it's very confusing that Q makes the player just passively radiate noise.
21:28:59 <|amethyst> the divine powers screen does say "surrounded by a loud storm"
21:34:27 <|amethyst> originally the noise was just from the clouds
21:34:40 <|amethyst> until
21:34:41 <|amethyst> %git cc951abea
21:34:41 <Cheibriados> 07Grunt02 * 0.15-a0-595-gcc951ab: Make Q's GONNNNG conduct more of an official thing. 10(5 years ago, 1 file, 4+ 0-) 13https://github.com/crawl/crawl/commit/cc951abeae67
21:36:04 <|amethyst> (but that was before "loud" was added to the powers description)
22:08:08 -!- amalloy_ is now known as amalloy
22:59:25 <Cheibriados> 03Aidan Holm02 07[newgame-menus] * 0.24-a0-505-gef6b13b: Fix invalid read during program shutdown 10(11 months ago, 1 file, 4+ 1-) 13https://github.com/crawl/crawl/commit/ef6b13b9908c
22:59:25 <Cheibriados> 03Aidan Holm02 07[newgame-menus] * 0.24-a0-506-g0ca8970: Add UIGrid stretch_h, stretch_v 10(1 year, 1 month ago, 2 files, 19+ 4-) 13https://github.com/crawl/crawl/commit/0ca89707ee66
22:59:25 <Cheibriados> 03Aidan Holm02 07[newgame-menus] * 0.24-a0-507-gdf0f49f: Remove black background from high scores tile 10(1 year ago, 1 file, 0+ 0-) 13https://github.com/crawl/crawl/commit/df0f49ff71de
22:59:25 <Cheibriados> 03Aidan Holm02 07[newgame-menus] * 0.24-a0-508-gc6ec463: Add text widget background colour (console-only) 10(1 year ago, 2 files, 19+ 4-) 13https://github.com/crawl/crawl/commit/c6ec463d65d9
22:59:25 <Cheibriados> 03Aidan Holm02 07[newgame-menus] * 0.24-a0-509-gf43a7c5: Add UI widget input focus 10(1 year, 1 month ago, 8 files, 139+ 81-) 13https://github.com/crawl/crawl/commit/f43a7c513488
22:59:25 <Cheibriados> 03Aidan Holm02 07[newgame-menus] * 0.24-a0-510-g907ffcc: Add add_event_filter() 10(11 months ago, 2 files, 41+ 6-) 13https://github.com/crawl/crawl/commit/907ffcce3f3a
22:59:25 <Cheibriados> 03Aidan Holm02 07[newgame-menus] * 0.24-a0-511-g7218f3f: Add per-layer focus 10(11 months ago, 1 file, 18+ 23-) 13https://github.com/crawl/crawl/commit/7218f3ff2afd
22:59:25 <Cheibriados> 03Aidan Holm02 07[newgame-menus] * 0.24-a0-512-g171cb7f: Add debug drawing 10(1 year, 1 month ago, 1 file, 33+ 0-) 13https://github.com/crawl/crawl/commit/171cb7f7a49f
22:59:25 <Cheibriados> 03Aidan Holm02 07[newgame-menus] * 0.24-a0-513-g003b4a9: Add OuterMenu, MenuButton widgets 10(1 year ago, 4 files, 372+ 0-) 13https://github.com/crawl/crawl/commit/003b4a91a254
22:59:25 <Cheibriados> 03Aidan Holm02 07[newgame-menus] * 0.24-a0-514-gcb377af: Add descriptions to outer menu buttons 10(11 months ago, 2 files, 14+ 0-) 13https://github.com/crawl/crawl/commit/cb377aff0034
22:59:25 <Cheibriados> ... and 21 more commits
22:59:50 <wjchen> aidanh: that check (i.e., travel.cc:2272 in my PR) is necessary because the faded altar (GOD_ECUMENICAL) is also recorded in altars_present. it caught me by surprise yesterday
23:00:44 <aidanh> wjchen: ah, that makes sense; might be a good idea to add a comment to that effect
23:02:52 <wjchen> aidanh: Sure, I'll make the changes and then adjust the commits later today, thanks.
23:51:57 <alexjurkiewicz> aidanh: what's that branch? are you rebasing an unmerged branch to revive it?