00:29:04 <Eksell> Unstable branch on CRAWL.XTAHUA.COM updated to: 0.24-a0-493-g7e4ddcd485 (34)
00:30:35 <Eksell> Stable (0.23) branch on CRAWL.XTAHUA.COM updated to: 0.23.1-82-g5129a83184
00:40:51 <Cheibriados> 03reaverb02 07* 0.24-a0-494-g17ce2c7: Correct alphabetization in Makefile.obj 10(24 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/17ce2c7205cc
00:47:26 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.24-a0-494-g17ce2c7205 (34)
01:38:08 <Gretell> Unstable branch on crawl.develz.org updated to: 0.24-a0-494-g17ce2c7 (34)
02:09:17 <Gretell> Windows builds of master branch on crawl.develz.org updated to: 0.24-a0-494-g17ce2c7
02:58:56 <Gretell> Monster database of master branch on crawl.develz.org updated to: 0.24-a0-443-g80245de
03:25:43 <Rotatell> Unstable branch on crawl.beRotato.org updated to: 0.24-a0-494-g17ce2c7 (34)
04:15:14 -!- amalloy is now known as amalloy_
07:57:27 <Cheibriados> 03wjchen02 07https://github.com/crawl/crawl/pull/1091 * 0.24-a0-459-gee6ba6b: Allow predefined keyword for search_stashes() 10(2 hours ago, 2 files, 30+ 26-) 13https://github.com/crawl/crawl/commit/ee6ba6ba02af
07:57:27 <Cheibriados> 03wjchen02 07https://github.com/crawl/crawl/pull/1091 * 0.24-a0-460-gb38b242: Allow using G_ to select altar for travel 10(2 hours ago, 5 files, 144+ 6-) 13https://github.com/crawl/crawl/commit/b38b24254566
07:57:27 <Cheibriados> 03wjchen02 07https://github.com/crawl/crawl/pull/1091 * 0.24-a0-461-ga4f8694: Allow traveling to branches, shops and altars in ^O 10(2 hours ago, 1 file, 41+ 5-) 13https://github.com/crawl/crawl/commit/a4f86943e91f
10:35:10 -!- gmarks_ is now known as gmarks
11:14:39 <advil> sry in advance
11:14:50 <Cheibriados> 03advil02 07[incremental_pregen] * 0.24-a0-494-g033f6b6: Initial implementation for incremental pregeneration 10(3 months ago, 3 files, 143+ 87-) 13https://github.com/crawl/crawl/commit/033f6b6f8fd7
11:14:50 <Cheibriados> 03advil02 07[incremental_pregen] * 0.24-a0-495-g047adb1: Add an option to disable incremental pregen, use it for fireworks 10(3 months ago, 5 files, 33+ 3-) 13https://github.com/crawl/crawl/commit/047adb14211b
11:14:50 <Cheibriados> 03advil02 07[incremental_pregen] * 0.24-a0-496-g0f50f44: Cosmetic refactoring of the rng interface 10(3 months ago, 21 files, 257+ 235-) 13https://github.com/crawl/crawl/commit/0f50f443f270
11:14:50 <Cheibriados> 03advil02 07[incremental_pregen] * 0.24-a0-497-g9cb4c75: Change PCG initialization to something more standard 10(3 months ago, 6 files, 65+ 45-) 13https://github.com/crawl/crawl/commit/9cb4c75dabef
11:14:50 <Cheibriados> 03advil02 07[incremental_pregen] * 0.24-a0-498-g0ee883c: Update the bounded random implementation 10(3 months ago, 5 files, 88+ 25-) 13https://github.com/crawl/crawl/commit/0ee883cd9192
11:14:50 <Cheibriados> 03advil02 07[incremental_pregen] * 0.24-a0-499-gd8dc482: Improve the rng subgenerator API 10(3 months ago, 7 files, 89+ 44-) 13https://github.com/crawl/crawl/commit/d8dc482e7fa7
11:14:50 <Cheibriados> 03advil02 07[incremental_pregen] * 0.24-a0-500-g4ec22ad: Remove almost all instances of you.unrands 10(2 months ago, 18 files, 284+ 170-) 13https://github.com/crawl/crawl/commit/4ec22ad74387
11:14:50 <Cheibriados> 03advil02 07[incremental_pregen] * 0.24-a0-501-g1f07497: Add back ident:type for some cases 10(2 months ago, 2 files, 10+ 10-) 13https://github.com/crawl/crawl/commit/1f07497c6cc9
11:14:50 <Cheibriados> 03advil02 07[incremental_pregen] * 0.24-a0-502-g38c3e93: Re-place robe of folly 10(2 months ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/38c3e932c512
11:14:50 <Cheibriados> 03advil02 07[incremental_pregen] * 0.24-a0-503-gf93b58f: Update seed menu for incremental pregen 10(10 weeks ago, 4 files, 56+ 40-) 13https://github.com/crawl/crawl/commit/f93b58f07359
11:14:50 <Cheibriados> ... and 12 more commits
11:14:53 <Cheibriados> 03advil02 07https://github.com/crawl/crawl/pull/1094 * 0.24-a0-494-g033f6b6: Initial implementation for incremental pregeneration 10(3 months ago, 3 files, 143+ 87-) 13https://github.com/crawl/crawl/commit/033f6b6f8fd7
11:14:53 <Cheibriados> 03advil02 07https://github.com/crawl/crawl/pull/1094 * 0.24-a0-495-g047adb1: Add an option to disable incremental pregen, use it for fireworks 10(3 months ago, 5 files, 33+ 3-) 13https://github.com/crawl/crawl/commit/047adb14211b
11:14:53 <Cheibriados> 03advil02 07https://github.com/crawl/crawl/pull/1094 * 0.24-a0-496-g0f50f44: Cosmetic refactoring of the rng interface 10(3 months ago, 21 files, 257+ 235-) 13https://github.com/crawl/crawl/commit/0f50f443f270
11:14:53 <Cheibriados> 03advil02 07https://github.com/crawl/crawl/pull/1094 * 0.24-a0-497-g9cb4c75: Change PCG initialization to something more standard 10(3 months ago, 6 files, 65+ 45-) 13https://github.com/crawl/crawl/commit/9cb4c75dabef
11:14:53 <Cheibriados> 03advil02 07https://github.com/crawl/crawl/pull/1094 * 0.24-a0-498-g0ee883c: Update the bounded random implementation 10(3 months ago, 5 files, 88+ 25-) 13https://github.com/crawl/crawl/commit/0ee883cd9192
11:14:53 <Cheibriados> 03advil02 07https://github.com/crawl/crawl/pull/1094 * 0.24-a0-499-gd8dc482: Improve the rng subgenerator API 10(3 months ago, 7 files, 89+ 44-) 13https://github.com/crawl/crawl/commit/d8dc482e7fa7
11:14:53 <Cheibriados> 03advil02 07https://github.com/crawl/crawl/pull/1094 * 0.24-a0-500-g4ec22ad: Remove almost all instances of you.unrands 10(2 months ago, 18 files, 284+ 170-) 13https://github.com/crawl/crawl/commit/4ec22ad74387
11:14:53 <Cheibriados> 03advil02 07https://github.com/crawl/crawl/pull/1094 * 0.24-a0-501-g1f07497: Add back ident:type for some cases 10(2 months ago, 2 files, 10+ 10-) 13https://github.com/crawl/crawl/commit/1f07497c6cc9
11:14:53 <Cheibriados> 03advil02 07https://github.com/crawl/crawl/pull/1094 * 0.24-a0-502-g38c3e93: Re-place robe of folly 10(2 months ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/38c3e932c512
11:14:53 <Cheibriados> 03advil02 07https://github.com/crawl/crawl/pull/1094 * 0.24-a0-503-gf93b58f: Update seed menu for incremental pregen 10(10 weeks ago, 4 files, 56+ 40-) 13https://github.com/crawl/crawl/commit/f93b58f07359
11:14:53 <Cheibriados> ... and 12 more commits
11:22:11 <Lantell> Stable (0.23) branch on underhound.eu updated to: 0.23.1-82-g5129a83184
11:52:10 <Cheibriados> New branch created: pull/1106 (1 commit) 13https://github.com/crawl/crawl/pull/1106
11:52:10 <Cheibriados> 03argonaut02 07https://github.com/crawl/crawl/pull/1106 * 0.24-a0-490-g59dc060: Remove blood from Gozag shop description 10(4 minutes ago, 1 file, 1+ 3-) 13https://github.com/crawl/crawl/commit/59dc0601247e
12:03:55 <Cheibriados> 03argonaut02 {ebering} 07* 0.24-a0-495-gd30f2f1: Remove blood from Gozag shop description 10(16 minutes ago, 1 file, 1+ 3-) 13https://github.com/crawl/crawl/commit/d30f2f123c34
12:17:28 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.24-a0-495-gd30f2f123c (34)
12:52:03 <MarvinPA> thanks chanserv
12:52:08 <gmarks> Lol
12:56:50 <MarvinPA> i guess that requires an op to change the topic now but we don't need to do that much so it's probably fine
12:57:24 <gmarks> Last time it was changed was 2015
13:21:50 <Henzell> Unstable branch on crawl.akrasiac.org updated to: 0.24-a0-495-gd30f2f1 (34)
14:02:23 -!- amalloy_ is now known as amalloy
14:36:28 <gmarks> Whoops, I created an exploit :)
14:36:35 <gmarks> Will fix when I get home.
15:00:19 -!- Tiobot is now known as Guest72022
15:46:10 <gmarks_> I think PR 1103 should be reverted; it adds a bunch of new code paths because previously all the Lua code assumed that the player was on the current level, so we have things like the grid of the level above being accessed using the player's current coordinates
15:46:29 <gmarks_> all in all this could maybe be something that happens but it will need a lot more testing
15:52:55 <Cheibriados> New branch created: pull/1107 (1 commit) 13https://github.com/crawl/crawl/pull/1107
15:52:55 <Cheibriados> 03gmarks02 {GitHub} 07https://github.com/crawl/crawl/pull/1107 * 0.24-a0-496-g0f1055a: Revert "Allow running clua from map viewing mode (#1103)" 10(6 minutes ago, 4 files, 3+ 73-) 13https://github.com/crawl/crawl/commit/0f1055a643f3
16:25:34 <reaverb> Do you know of a specific bug, gmarks?
16:42:37 <amalloy> reaverb: the PR mentions one specific exploit
16:43:39 <Cheibriados> 03gmarks02 {amalloy} 07* 0.24-a0-496-gbe733cd: Revert "Allow running clua from map viewing mode (#1103)" (#1107) 10(8 seconds ago, 4 files, 3+ 73-) 13https://github.com/crawl/crawl/commit/be733cd003b0
16:44:11 <amalloy> gmarks_: thanks for noticing. i am a big fan of "revert first, ask question later"
17:01:36 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.24-a0-496-gbe733cd003 (34)
17:07:24 <reaverb> Apologizes for missing that. Thanks for the contribution, gmarks.
17:14:23 <advil> haha lua during a level excursion sounds wild
17:17:05 <advil> is the problem that all that clua stuff uses player centered coordinates? a solution is probably to use some absolute center during a level excursion
17:17:15 <advil> well, I guess that reveals the map bounds
17:17:23 <advil> maybe pick a staircase
17:17:29 <gmarks> I think that if 'you' and the actual player character were 1:1 there would be no problems
17:17:48 <advil> during a level excursion the level the player is on is just *gone*
17:17:55 <advil> crawl only loads one level at a time
17:17:56 <Pinkbeast> advil: Incidentally your Desolation patch applies OK and seems to work in 0.22; IDK if you think the server CPU issues are bad enough to backport it.
17:18:17 <advil> ah right, probably worth at least backporting to 0.23
17:18:32 <Pinkbeast> We did but then we're running CMOU on a comedy device, viz, a Pi
17:18:35 <gmarks> Advil, that wouldn't be (as much of) a problem if we didn't maintain the player's original position
17:19:01 <gmarks> The problem is we are using player.pos in conjunction with level_id::current and assuming that those match up
17:19:55 <gmarks> If the player pos followed the excursion too I think some problems with the clua would be ameliorated, but that would undoubtedly break other code
17:20:45 <advil> yes, this is often a problem with level excursions
17:21:44 <advil> classic bug:
17:21:45 <advil> %git b80bb099385
17:21:46 <Cheibriados> 07|amethyst02 * 0.14-a0-1705-gb80bb09: Don't check monster validity when loading a level. 10(6 years ago, 3 files, 7+ 4-) 13https://github.com/crawl/crawl/commit/b80bb099385e
17:22:46 <advil> someone should do a best bug retrospective
17:23:14 <reaverb> ??epic_bugs
17:23:14 <Sequell> epic bugs[1/28]: if (you.religion = GOD_XOM)
17:23:21 <advil> yeah, I guess that does exist
17:23:39 <gmarks> ??epic_bugs[28
17:23:40 <Sequell> epic bugs[28/28]: Dying and reincarnating as a felid while you had Wu Jian's Heaven on Earth ability active would leave the effect active forever, letting you accumulate infinite amounts of slaying bonus.
17:25:19 <reaverb> I've been considering integrating a real unit testing framework into Crawl - either doctest or Catch2
17:25:35 <reaverb> Bringing us up to circa 2006 software engineering practices.
18:21:44 <Lantell> Unstable branch on underhound.eu updated to: 0.24-a0-496-gbe733cd003 (34)
20:27:29 -!- gmarks_ is now known as gmarks
20:49:27 -!- amalloy is now known as amalloy_
21:18:51 -!- amalloy_ is now known as amalloy
21:40:13 <Cheibriados> 03reaverb02 07* 0.24-a0-497-g5a03d68: Ensure train targets turn off once reached with !experience (#11993) 10(3 hours ago, 2 files, 5+ 2-) 13https://github.com/crawl/crawl/commit/5a03d68f5965
21:47:49 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.24-a0-497-g5a03d68f59 (34)
22:17:47 * Pinkbeast spends ages looking into an odd problem only to find advil fixed it in late 2018, sigh
22:19:14 <reaverb> If there's an open mantis issue, I can close the issue.
22:23:28 <Pinkbeast> Not AFAIK - I spotted just in some random code diving. The commit ( b44a8d19cf35644f8f28e5f9169c5cb9edb0b1e2 ) references #854 but that was closed in 2011 and pertains to something else altogether.
22:39:04 <|amethyst> Pinkbeast:  that's github issue #854, not Mantis
22:39:19 <|amethyst> https://github.com/crawl/crawl/issues/854   PVS-Studio static analysis report
22:42:19 <Pinkbeast> Ah, that explains it.