00:48:43 <Eksell> Unstable branch on CRAWL.XTAHUA.COM updated to: 0.24-a0-433-gbe6fa4f6cc (34)
00:50:05 <Eksell> Stable (0.23) branch on CRAWL.XTAHUA.COM updated to: 0.23.1-79-g0e89c35649
01:19:17 <aidanh> !tell gammafunk hrm, well I'm guessing you'd have to change the column headers, and probably the bottom text, and have different pages as well?
01:19:17 <Sequell> aidanh: OK, I'll let gammafunk know.
01:22:02 <aidanh> !tell gammafunk If you want to keep the memorize/describe/hide/show structure, you'd only need to override calc_title, update_entries and the on_single_selection call, which seems feasible
01:22:03 <Sequell> aidanh: OK, I'll let gammafunk know.
01:22:59 <aidanh> I'd probably start with a copy-pasted class, get the implementation working, and then see what can be unified via inheritance afterwards
01:38:41 <Gretell> Unstable branch on crawl.develz.org updated to: 0.24-a0-433-gbe6fa4f (34)
02:11:27 <Gretell> Windows builds of master branch on crawl.develz.org updated to: 0.24-a0-433-gbe6fa4f
02:41:09 <alexjurkiewicz> spam is starting to get smart enough to nearly contribute useful posts https://crawl.develz.org/tavern/viewtopic.php?f=8&t=26257&view=unread#unread
02:45:32 -!- ProzacElf_ is now known as ProzacElf
02:47:25 <Pinkbeast> I saw one of those earlier in a signature, again, surely a human must have written the reply?
03:00:42 <Gretell> Monster database of master branch on crawl.develz.org updated to: 0.24-a0-433-gbe6fa4f
03:23:53 <Rotatell> Unstable branch on crawl.beRotato.org updated to: 0.24-a0-433-gbe6fa4f (34)
07:25:15 <Cheibriados> New branch created: pull/1086 (1 commit) 13https://github.com/crawl/crawl/pull/1086
07:25:15 <Cheibriados> 03Nikolai Lavsky02 07https://github.com/crawl/crawl/pull/1086 * 0.24-a0-434-g4aae919: Fix display of detected gold on the minimap (11950) 10(16 minutes ago, 1 file, 7+ 1-) 13https://github.com/crawl/crawl/commit/4aae9199e5e0
08:56:42 <Cheibriados> Dungeon Overview overlay window doesnt close for spectators 13https://crawl.develz.org/mantis/view.php?id=12009 by Octopode-monk-of-XOM
11:23:22 <Lantell> Stable (0.23) branch on underhound.eu updated to: 0.23.1-79-g0e89c35649
12:17:40 -!- amalloy is now known as amalloy_
13:26:30 <Henzell> Unstable branch on crawl.akrasiac.org updated to: 0.24-a0-433-gbe6fa4f (34)
14:03:51 <Cheibriados> No drowning warning changing from dragon form to statue form 13https://crawl.develz.org/mantis/view.php?id=12010 by soadsod
14:03:58 <Cheibriados> New branch created: pull/1087 (1 commit) 13https://github.com/crawl/crawl/pull/1087
14:03:58 <Cheibriados> 03Umer Shaikh02 07https://github.com/crawl/crawl/pull/1087 * 0.24-a0-434-g18ba8cf: Remove possible placement of blowgun from vault 10(32 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/18ba8cf384e2
14:11:59 -!- amalloy_ is now known as amalloy
14:12:50 <amalloy> that's amazing. i didn't know there were still ways to drown
14:14:02 <MarvinPA> wow, also good that statues fall apart like mummies i guess?
14:16:36 <amalloy> hah, i hadn't read that part
14:17:29 <amalloy> apparently this is controlled by you.is_nonliving()
14:22:31 <amalloy> weird. i can't actually repro this: _transformation_is_safe prevents you from activating statue form
14:23:23 <amalloy> (and has for years; it's not like they're on some old version before that happened)
14:28:52 <amalloy> and i can't see anything in their morgue that's even a candidate for the kind of weirdness that might let them accidentally drown
14:29:38 <amalloy> do we intend for drowning to ever be possible at all? we could change fall_into_a_pool to activate emergency flight instead
14:34:18 <MarvinPA> i did think the intention was for it to just be impossible yeah, so it might be better to just fully remove the code for it
14:36:03 <eviltwin_b> how about stuff like the tides in shoals?
14:36:32 <eviltwin_b> (and similar stuff e.g. robe of clouds or whatever)
14:36:47 <MarvinPA> iirc tides movement is only shallow water now, but also those effects have never been able to place deep water under you
14:37:26 <eviltwin_b> ok. never checked whether they could tbh ut seemed like a possible corner case
14:38:37 <eviltwin_b> in unrelated news, built crawl on an old netbook I used to use in ancient days (pre-dcss)
14:39:01 <eviltwin_b> almost unplayably slow with gcc; clang6+lto is considerably faster
14:39:15 <eviltwin_b> (1.6GHz CPU)
14:39:57 <eviltwin_b> ...ancient atom though, so not 100% comparable
14:47:18 <MarvinPA> hmm, very confused as to how this drowning actually happened
14:47:47 <MarvinPA> if you have a potion of flight active at the same time as dragon form, and then you try to transform into statue form right as the !flight expires, that does let you cast it
14:47:51 <MarvinPA> but even then you just get emergency flight
14:50:54 <Cheibriados> 03ufshaikh02 {MarvinPA} 07* 0.24-a0-434-gd57e52f: Remove possible placement of blowgun from vault (#1087) 10(12 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/d57e52fea871
15:02:20 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.24-a0-434-gd57e52fea8 (34)
15:34:02 <Cheibriados> 03crystalsolenoid02 07https://github.com/crawl/crawl/pull/1080 * 0.24-a0-432-gdfc328d: Wounds description sentence conjugates correctly 10(4 minutes ago, 1 file, 5+ 1-) 13https://github.com/crawl/crawl/commit/dfc328de665e
15:47:33 <amalloy> MarvinPA: maybe better than my suggestion: change fall_into_a_pool to ASSERT(false), so we get a stacktrace explaining how we got there
16:11:45 <Cheibriados> 03crystalsolenoid02 07https://github.com/crawl/crawl/pull/1080 * 0.24-a0-433-g80ff734: Fixed line-length 10(36 minutes ago, 1 file, 6+ 3-) 13https://github.com/crawl/crawl/commit/80ff734baddb
16:11:45 <Cheibriados> 03crystalsolenoid02 07https://github.com/crawl/crawl/pull/1080 * 0.24-a0-434-g5637068: Revert "Refactored monster::conj_verb" 10(35 minutes ago, 1 file, 8+ 1-) 13https://github.com/crawl/crawl/commit/56370689e503
16:11:45 <Cheibriados> 03crystalsolenoid02 07https://github.com/crawl/crawl/pull/1080 * 0.24-a0-435-g37cd612: Revert "monster::conj_verb accounts for singular they" 10(32 minutes ago, 1 file, 1+ 9-) 13https://github.com/crawl/crawl/commit/37cd6121c3a9
16:11:45 <Cheibriados> 03crystalsolenoid02 07https://github.com/crawl/crawl/pull/1080 * 0.24-a0-436-gccd98d4: New wording to avoid "don't / doesn't" exception 10(4 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/ccd98d470310
16:14:21 -!- Tiobot is now known as Guest99131
18:22:52 <Lantell> Unstable branch on underhound.eu updated to: 0.24-a0-434-gd57e52fea8 (34)
22:15:04 <gammafunk> I assume if I modify a variable that's passed to unwind_var<>, this doesn't cause any problems and the var will be reset to the pre-unwind-var state after the unwind var goes out of scope?
22:18:35 <gammafunk> hrm, I wonder what this MemoriseMenu is actually returning via it's ::show() method when someone uses the (M)emorise option from the spell desc
22:18:56 <gammafunk> perhaps it's returning SPELL_NO_SPELL
22:53:40 <amalloy> gammafunk: i think that's the main purpose of unwind_var
23:02:19 <gammafunk> well, you set an initial changed state when you call the template, remember
23:02:36 <gammafunk> so I'm talking about changing it subsequent to that one
23:10:52 <amalloy> gammafunk: as implemented it certainly will not mind if you modify it within the unwind. it's often used that way, as like "i'm about to call a function that i know will mutate the var v, but i don't know what mutations it will apply, and i want the old value back"
23:13:28 <gammafunk> right, just wanted to clarify whether it cared about other modifications
23:14:22 <gammafunk> looking at the implementation, it's just using a ref to modify the original variable and storing the original in a copy
23:14:50 <gammafunk> *storing the original value