00:26:41 Unstable branch on CRAWL.XTAHUA.COM updated to: 0.23-a0-860-g8ff03fb (34) 01:27:53 Unstable branch on crawl.develz.org updated to: 0.23-a0-860-g8ff03fb (34) 01:37:30 EthnicCake (L12 DDNe) Crash caused by signal #15: Terminated (Gauntlet) 01:58:33 Windows builds of master branch on crawl.develz.org updated to: 0.23-a0-860-g8ff03fb 02:59:41 Monster database of master branch on crawl.develz.org updated to: 0.23-a0-860-g8ff03fb 05:51:14 New branch created: pull/965 (1 commit) 13https://github.com/crawl/crawl/pull/965 05:51:14 03NormalPerson702 07https://github.com/crawl/crawl/pull/965 * 0.23-a0-839-g51e95df: Make yellow draconians' rAcid a true mutation (11381) 10(11 minutes ago, 6 files, 24+ 8-) 13https://github.com/crawl/crawl/commit/51e95df46084 06:07:09 03NormalPerson702 07https://github.com/crawl/crawl/pull/965 * 0.23-a0-840-g20d891b: fixup! Make yellow draconians' rAcid a true mutation (11381) 10(5 minutes ago, 2 files, 7+ 1-) 13https://github.com/crawl/crawl/commit/20d891b76101 07:13:52 -!- muffindrake1 is now known as muffindrake 07:37:19 New branch created: pull/966 (1 commit) 13https://github.com/crawl/crawl/pull/966 07:37:19 03NormalPerson702 07https://github.com/crawl/crawl/pull/966 * 0.23-a0-839-g2473426: Include petrification information in death messages (11374) 10(6 minutes ago, 3 files, 13+ 0-) 13https://github.com/crawl/crawl/commit/2473426cc4a0 08:23:16 Finguili (L17 MuFE) ERROR in 'tags.cc' at line 4370: Invalid item: (quantity: 0) gold piece (Shoals:1) 10:57:24 !crash Finguili 10:57:26 1. Finguili, XL17 MuFE, T:61323 (milestone): https://underhound.eu/crawl/morgue/Finguili/crash-Finguili-20190127-132315.txt 12:22:41 Unstable branch on crawl.akrasiac.org updated to: 0.23-a0-860-g8ff03fb (34) 13:22:06 03NormalPerson702 07https://github.com/crawl/crawl/pull/965 * 0.23-a0-839-gd800a63: Make yellow draconians' rAcid a true mutation (11381) 10(8 hours ago, 7 files, 31+ 9-) 13https://github.com/crawl/crawl/commit/d800a634ffc9 13:43:21 was the spawn rate of rations changed in some way? i just almost starved on a spriggan 13:44:37 when food was simplified it was made so that rations only gave 56% of the normal nutrition to spriggans 13:44:55 but I think that was supposed to be equivalent to how it was before 13:45:17 i mean more like, i'm on d5 right now on this spriggan, i've eaten two rations, and have no more in my inventory 13:45:34 oh that's just unlucky 13:45:40 mmk, just making sure 13:45:50 never happened to me before 13:45:51 similar thing happened to uv4 on a merfolk where he found nearly no rations 13:46:12 i feel like it shouldn't be possible to starve like that 13:46:18 even if it happens once every 4k games 13:46:22 I very much agree with that statement 13:46:57 it's funny because when i first started playing this class i decided i'd get spellcasting to 8 first 13:47:04 and that's what i did on this character, despite knowing it's bad 13:47:09 so i'm not even dying from spell hunger or bad play 13:47:14 i'm actually just starving to death for no reason 13:47:15 it's not bad on spriggans for this reason 13:47:27 it's like the one time where spell hunger is an actually relevant issue imo 13:47:28 it's not *great*, since usually this doesn't happen lol 14:04:16 Dying as a felid can place you earlier on in a gauntlet 13https://crawl.develz.org/mantis/view.php?id=11842 by NormalPerson7 14:36:21 New branch created: pull/967 (1 commit) 13https://github.com/crawl/crawl/pull/967 14:36:21 03NormalPerson702 07https://github.com/crawl/crawl/pull/967 * 0.23-a0-839-gc959d29: Fix AC calculation in item description with deformed body (Monsterracer) 10(14 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/c959d29e828e 14:59:49 -!- Euph0ria is now known as TabMasher 16:25:34 testing 11701 made me realize you can't inner flame your summons, but can inner flame sticks to snakes pets 16:26:45 you're probably more likely to get yourself killed than anything else trying to do it, though 16:29:44 I'm not sure if that's intended or not 16:29:49 it probably shouldn't be a thing 16:30:18 and it does have good uses... I've seen uv4 use it to create a "snakebomb" to send at a monster, and when they kill the snakes they get wrecked by the explosions 16:31:00 *when the monster kills the snakes 16:31:18 it's a side effect of the difference between DUR_ABJ and DUR_FAKE_ABJ and probably a bug 16:34:30 that's the only use, yeah 16:34:44 and it's probably either OP or going to kill you when you try to do it :P 16:35:42 is feature freeze happening tonight btw? 16:46:53 that's the plan, but I'm waiting till gammafunk or advil is around to check in 16:47:42 time to FREEZE 16:51:21 I would still like to merge rng improvements tonight if possible 16:51:39 almost there 16:51:48 in fact maybe I'll activate the PR 16:59:36 New branch created: pull/968 (22 commits) 13https://github.com/crawl/crawl/pull/968 16:59:37 03advil02 07https://github.com/crawl/crawl/pull/968 * 0.23-a0-848-g484ce73: Improve behavior of seeding 10(6 days ago, 16 files, 174+ 18-) 13https://github.com/crawl/crawl/commit/484ce73e119c 16:59:37 03advil02 07https://github.com/crawl/crawl/pull/968 * 0.23-a0-849-gb6bc5ef: Up the seed size to uint64_t 10(5 days ago, 8 files, 24+ 18-) 13https://github.com/crawl/crawl/commit/b6bc5efdb804 16:59:37 03advil02 07https://github.com/crawl/crawl/pull/968 * 0.23-a0-850-g89c080e: Move seed / version history out of ?V title 10(5 days ago, 1 file, 13+ 9-) 13https://github.com/crawl/crawl/commit/89c080e0ba19 16:59:37 03advil02 07https://github.com/crawl/crawl/pull/968 * 0.23-a0-851-g62ff25f: Use dungeon RNG for initial dungeon setup 10(4 days ago, 1 file, 7+ 3-) 13https://github.com/crawl/crawl/commit/62ff25f0cc62 16:59:37 03advil02 07https://github.com/crawl/crawl/pull/968 * 0.23-a0-852-gbbcc163: Implement dungeon pregeneration (bel) 10(4 days ago, 11 files, 203+ 14-) 13https://github.com/crawl/crawl/commit/bbcc163f199f 16:59:37 03advil02 07https://github.com/crawl/crawl/pull/968 * 0.23-a0-853-g7d82b49: Allow saving ghosts when a seed is set 10(4 days ago, 1 file, 0+ 1-) 13https://github.com/crawl/crawl/commit/7d82b4949b0d 16:59:37 03advil02 07https://github.com/crawl/crawl/pull/968 * 0.23-a0-854-g4649906: Document seeding options better, allow rc file seeds 10(4 days ago, 5 files, 35+ 2-) 13https://github.com/crawl/crawl/commit/46499062dea4 16:59:37 03advil02 07https://github.com/crawl/crawl/pull/968 * 0.23-a0-855-g04cf3ab: Add some spare RNGs before the branch ones 10(4 days ago, 1 file, 3+ 0-) 13https://github.com/crawl/crawl/commit/04cf3ab7905c 16:59:37 03advil02 07https://github.com/crawl/crawl/pull/968 * 0.23-a0-856-gb61ae26: Fix a build error 10(3 days ago, 1 file, 0+ 4-) 13https://github.com/crawl/crawl/commit/b61ae26b79cb 16:59:37 03advil02 07https://github.com/crawl/crawl/pull/968 * 0.23-a0-857-g2f605e5: Add a rudimentary progress popup to run during pregeneration 10(3 days ago, 3 files, 107+ 12-) 13https://github.com/crawl/crawl/commit/2f605e5d4cbd 16:59:37 ... and 12 more commits 17:03:27 I think this is basically ok to merge, there's a few things missing that could be added after a freeze, but I wasn't going to actually merge it until later tonight 17:04:57 I guess if anyone has reservations I could be talked out of merging, since this hasn't seen a lot of review, but it would really benefit from being in a release, where the effect of seed choice should be stable 17:30:06 oh did you get it working for webtiles? 17:30:20 and does it work cross-system? 17:45:56 03NormalPerson702 {ebering} 07* 0.23-a0-861-g0c83f0c: Fix AC calculation in item description with deformed body (Monsterracer) 10(3 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/0c83f0cefa03 18:02:52 Unstable branch on crawl.kelbi.org updated to: 0.23-a0-861-g0c83f0cefa (34) 18:43:05 alexjurkiewicz as far as I know, it's stable across systems, but I haven't really tested it on that many devices 18:44:05 alexjurkiewicz I have not implemented a webtiles progress bar yet, but it's not too hard...for challenge modes I think the best thing to do might be to maintain a separate branch that enables pregeneration for DGL 19:01:34 advil: you think merging this is unlikely to break online or offline games not using pregeneration in any way? 19:01:53 it shouldn't impact them at all 19:02:17 it's obviously just squeaking in release-wise, but it would have at least some time for testing even before that 19:02:27 turning on pregeneration in its current incarnation only impacts game start, and any upgraded game is marked in the save as "not seeded" 19:04:18 new games will switch to using the new split rng but this is basically meaningless, because they weren't initialized with it 19:40:37 apparently there are vast edits to the plan and some kind of project coordination thing where I wasn't informed that it exists 19:40:56 not too helpful for coordinating things among people when said people don't know that it exists :p 19:41:54 I think ebering only did that like 6 hours ago 19:41:55 I've moved some stuff that's clearly not necessary TODO for the next release to a long-term section 19:42:33 yeah, but it's listing some stuff that's just really fluid right now and I'm not sure it's really helpful to put it on a formal page like that 19:43:11 this is also illustrating the problems of having a plan doc when basically only one person is changing it 19:43:22 is there even a way to get notifications when the doc changes? 19:43:42 gammafunk: I set up that project board partly as an expierment 19:45:00 wasn't sure the best way to let people know about it; but I didn't make major edits to the plan I don't think 19:45:16 well I only learned about it by you telling someone not on the project in another discord, and it has stuff I've been coordinating, hence my shock 19:45:42 I'm sorry 19:46:01 in fairness, he did mention it here, pretty recently (and the whole thing is recent) 19:46:42 sure, I just think we're going a *little* overboard with introducing all of this stuff all at once 19:47:09 the aim according to the plan is "de-kudzing" yet now the developers themselves are kuduzed :) 19:47:19 I don't actually know how that word is spelled 19:47:29 the second one :) 19:47:45 I don't really know if we can make that plan work in a way so that all of us can actually see what's changing 19:47:51 I think that's probably one missing aspect of it? 19:48:10 since I see entries on here that have just been added, not all of which I agree with and it would be good for me to comment 19:48:10 if you click on the menu it has an activity log 19:48:20 well, notifications would really go a long way here I thin 19:48:22 k 19:48:41 because some of this has probably been on that page for some time 19:48:50 which page? 19:48:55 the development plain 19:48:59 *plan 19:49:12 oh yeah; sorry I think we're crossing paths 19:49:21 are you talking about the wiki? 19:49:29 I was talking about the project board for the 0.23 release, which is mostly a list of bugs 19:49:36 yeah, me too 19:49:42 that I made earlier today and then went to do chores before talking about more 19:50:11 right, the project thing is probably not going to work too well for me personally; but I'm talking about the plan itself 19:52:49 what I'm saying is that it sort of needs a way so that other devs can see when it changes so that it doesn't have the same issue that the previous plans did, where it's basically just one person making changes to it and it's sort of that person's todo 19:53:01 Yes, I agree 19:54:06 the GH dashboard has a newsfeed type thing that includes wiki edits as well as commits, but I'm not sure how to filter it in a useful way 19:54:27 I wanted to try out the project board because I was under the impression you could get notifications for boards in the same way as for PRs but it seems I'm mistaken 19:54:43 hrm, where is that? 19:54:54 https://github.com/crawl/crawl/projects/2 19:55:36 oh, that's the project thing you've made though right? 19:55:46 yes 19:56:04 well you said it includes wiki edits and commits? 19:56:24 oh, no; that's just what I see on https://github.com when logged in 19:56:39 ah, yeah that's what I was asking about, the dashboard 19:56:46 oh, yeah 19:56:50 this is like github-wide 19:56:58 the dash includes the wiki edits but you can't filter it which is :< 19:58:46 yall need like a secretary or one of those secretary services 19:59:17 hm. GH wikis are just repositories and you can get an atom feed of a repo's commits 19:59:39 I wonder if we could hack keeping track of the wiki updates into Chei... 19:59:45 heh 20:01:42 it probably is. i have it set up on my phone for alerts to ariana grande edits on wikipedia so i can make reversions 20:02:36 I can make a pizza tornado page full of misleading statements and there's nothing you can do about it 20:04:27 ebering: yeah, maybe something simple like "wiki updated" but if there's a feed that's probably a good start for those of us who are following this 20:05:09 another related issue is how it's actually a kind of poor format for discussion. In the past when multiple people have been contributing to the plan wiki page, we've kind of just left comments on entries 20:05:20 like just in italic 20:05:53 so there's kind of this weird aspect of whether it's more a definitive statement about each item or an ongoing discussion 20:08:18 https://github.com/crawl/crawl/wiki.atom 20:09:23 it's not well advertised but it appears to be a supported feature 20:09:28 agree re: the issues with discussion and wikis not being a good format for that 20:23:05 how on earth is google's RSS extension supposed to work 20:24:20 oh I see 20:35:23 Napkin: Not sure if you're around, but we need a new host for the tournament scripts/DB, and I see that CDO has mysql and of course we have a log shared with a few developers there 20:36:47 Napkin: https://github.com/crawl/dcss_tourney/blob/master/README gives a bit more details on what the scripts need, but it's basically just a mysql database that the crawl CDO user would need to have access to modify, crontab entries for fetching RCs, a python script that has to run continuously 20:37:14 Napkin: and public web pages that said script generates, example of which you can see here: http://dobrazupa.org/tournament/0.22/ 20:46:33 I'll try to ping Napkin again tomorrow, but if we can't get CDO figured out by Wednesday, we should probably take up alex's offer of a temporary amazon server 20:49:32 I should include in that pinging |amethyst about using CSZO again, but I haven't heard back from him about that either 21:09:32 forgot to say last week how ownage it was when my ru game had a piety locked trove show up at *****. 21:11:27 another good idea would be a trove that determines your current highest skill, and forces it to zero when you enter 21:12:02 locks it in so you don`t, say, get it as formicid then skillup stealth to get in for free 21:13:07 twelwe: Wouldn't that typically just be a terrible deal? 21:13:39 i think troves are way too cheap as is since that happened 21:14:07 its usually go find & kill a swamp dragon or something stupid like that with zero cost 21:28:19 gammafunk you should spectate me on akrasiac right now if you`re there, i have a weird message in the abyss 21:28:37 ``The angel is wielding a +2 whip of holy wrath. There is.`` 21:29:54 nice 21:30:05 !lm twelwe x=cv 21:30:06 11287. [2019-01-28 02:26:32] [cv=0.23-a] twelwe the Skirmisher (L1 BaAK of Lugonu) began the quest for the Orb on turn 0. (Abyss:1) 21:30:26 twelwe: is there a dancing weapon accompanying this? 21:30:37 anyhow, you might file a bug about that one if you have time 21:30:38 yep there is 21:30:46 yeah, ok, so that's not fully fixed then 21:31:08 i was actually hoping you`d just credit my account with some kind of extra piety or something instead of the whole bug report process 21:31:23 not like this guy is gonna live anyway 21:31:58 Giving a player a nice thing? Not on my watch. 21:32:19 for more details see ??nice things 21:36:09 i feel like a narcotics officer when i write these things 21:39:16 Incomplete message with dancing weapon in abyss 13https://crawl.develz.org/mantis/view.php?id=11843 by twelwe 21:39:54 jesus it gets broadcast on the police scanner too 21:40:18 all available units please respond 21:42:58 lul, advil's todo "why is this redraw_all() here?" goes back to the initial commit from linley's crawl 21:42:59 good luck with that 21:47:03 just_created_level looks whacky 22:21:57 New branch created: pull/969 (1 commit) 13https://github.com/crawl/crawl/pull/969 22:21:57 03GenericPseudonym02 07https://github.com/crawl/crawl/pull/969 * 0.23-a0-862-g6b2184a: Fix 0011738: Setting a confirm_action for an ability generates a Y/N prompt every time the ability menu is opened 10(3 minutes ago, 1 file, 13+ 10-) 13https://github.com/crawl/crawl/commit/6b2184ac828a 22:27:45 sweet other people are fixing bugs on my bug list 22:53:46 03advil02 07https://github.com/crawl/crawl/pull/968 * 0.23-a0-870-g3f9d0d4: More documentation for seeding 10(4 hours ago, 2 files, 30+ 4-) 13https://github.com/crawl/crawl/commit/3f9d0d46d7e4 22:53:46 03advil02 07https://github.com/crawl/crawl/pull/968 * 0.23-a0-871-gf634674: Two sanity-check fixes 10(12 minutes ago, 2 files, 2+ 1-) 13https://github.com/crawl/crawl/commit/f6346742ab57 22:53:46 03advil02 07https://github.com/crawl/crawl/pull/968 * 0.23-a0-872-g152759d: checkwhite 10(4 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/152759dd851b 22:53:46 03advil02 07https://github.com/crawl/crawl/pull/968 * 0.23-a0-873-g5583dbd: Webtiles implementation for the progress bar 10(3 minutes ago, 5 files, 94+ 6-) 13https://github.com/crawl/crawl/commit/5583dbd9ffb2 22:54:51 advil's secret plan to reach top of the commit list comes to fruition 22:55:01 the other devs never even saw it coming... 22:55:08 haha 22:55:19 yes, this project has been way more under the radar than other things I've done 22:55:33 it's a really cool project, will be neat to see what comes out of it 22:56:04 "may lead to" crawl_manual.rst 22:56:48 i'm really hoping this project makes replays look slightly more possible, that'd be dope 22:58:31 in principle it could, though I think there's still something not fully deterministic going on in non-levelgen stuff 22:58:48 qw hasn't been doing exactly the same thing every time 22:59:10 it'll definitely be a lot easier to decouple that if this PR slides in cleanly 22:59:42 you wouldn't even need to figure out the pregeneration stuff, since in theory a replay should hit the same level order every time 23:00:38 is qazlal rmsl flavor just `its windy?` 23:00:56 if so i want to write a new desc for him 23:01:14 debugging via replays for crashes would probably weed out a lot of the impossible-to-find bugs, too 23:01:29 twelwe: I think also "its hard to see through crowds" 23:01:32 *clouds 23:01:46 ebering thats the yred desc 23:02:26 replays like that seem like a poor choice for viewing past games 23:02:38 in what sense? 23:02:49 it's completely tied to the game version and even more so than something like a json client would be 23:03:10 where would i put a desc edit submission? 23:03:11 which that already is and the trick to making client playback of json work would be to make it backwards compatible 23:03:19 we've used the foo-tv thing in the past and it's been pretty useless, other than pointing out that I, in fact, did try to fight that guy at 40hp 23:03:28 pretty much anything would be better 23:03:38 no, that's literally the opposite of true 23:03:40 twelwe: if you have git working a github pr; if you just want to do it quick do it on mantis 23:03:48 footv has always been very useful for finding bugs 23:04:02 or watching ttyrecs in general has, at least 23:04:22 03advil02 07https://github.com/crawl/crawl/pull/968 * 0.23-a0-874-gc6f2435: Finish sentence (switch__) 10(5 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/c6f2435b02b0 23:04:25 i haven't used it for debugging, i'm sure it's helpful for that 23:04:25 though i dunno if you'd be able to step through and actually see game state; i imagine not 23:04:36 and it's very useful for just watching games as well 23:05:21 in principle a json replay system should be easy to implement 23:05:34 yeah, the basics of it would be, but there are definitely some major issues 23:05:41 wish you guys would just use youtube like every other sane person does 23:05:52 the real dream would be actually having the game state at any given time, particularily for things like games that end in crashes 23:06:00 which you could do if it's all deterministic just by saving the input 23:06:27 I think having a client that can play back json from past games is one of the major challenges 23:06:51 switch__: the input, and also every previous version of the crawl binary, and knowledge of when the player switched versions 23:07:02 yikes 23:07:04 unless you want to have a per-version client to play back a given json file 23:07:22 league of legends does this pretty well: "replays expire after the current version changes, too bad" 23:07:39 sure, so we could expire replays after every commit 23:07:43 too bad 23:07:45 seeds will be super sensitive to version 23:08:18 switch__: ttyrecs don't let you see internal state but they are still very good for seeing exactly what the player was doing 23:08:21 well, for debugging, that isn't that much of a problem, just a bit of a pain, which is where the use of what i describe would really shine 23:08:28 and there are steppers for ttyrecs, such as ipbt 23:08:35 for other purposes something less reliant on version can probably be used instead 23:08:52 if that can be figured out 23:09:18 switch__: totally disagree. for debugging you need something that's not reliant on version, because real bugs very often come from trunk 23:09:43 and trunk changes all the time 23:09:43 i just mean like, for example, yermak's ancestor dropping his weapon on the floor and bugging out the game 23:09:57 re-creating it is really difficult, and doing so while having debugging breakpoints enabled is basically impossible 23:10:12 but with replays, even if getting the replay to work is a chore, you'd be able to find and solve that bug within that single instance (hopefully) 23:11:50 amalloy, everything you've said is true and i agree completely 23:12:41 however what i'm describing seems to be possible with what we currently have, maybe, while working out versioning and decoupling that sounds... very hard 23:13:43 i agree native replays would be cool, and dungeon seeding is one step in that direction, but i think we are much further away than you think. i'd be happy to be proven wrong 23:13:53 probably but hopefully not 23:14:04 The concept of "replay" has different meanings depending on what you're interesed in. If you think footv is useless, then you don't care about just watching people pay past games 23:14:15 assuming the nondeterminism that advil found isn't too entrenched 23:14:27 I do suspect that seed #s will be basically useless for trunk, but we'll see how it goes in practice 23:14:37 but just allowing people to watch past games is useful, and footv does a reasonable job of that; we'd just like to have the same thing for webtiles 23:14:42 gamma i don't have too much experience with footv, and i've always used tiles, so having to watch in console was a bit of a culture shock to me, so my opinion on it can probably be discarded 23:14:49 03advil02 07* 0.23-a0-862-gcb93d8a: Improve behavior of seeding 10(6 days ago, 16 files, 174+ 18-) 13https://github.com/crawl/crawl/commit/cb93d8aa06b1 23:14:49 03advil02 07* 0.23-a0-863-g7a91997: Up the seed size to uint64_t 10(6 days ago, 8 files, 24+ 18-) 13https://github.com/crawl/crawl/commit/7a919973b426 23:14:49 03advil02 07* 0.23-a0-864-g236e7cc: Move seed / version history out of ?V title 10(6 days ago, 1 file, 13+ 9-) 13https://github.com/crawl/crawl/commit/236e7cc7cb07 23:14:49 03advil02 07* 0.23-a0-865-g2dd0f10: Use dungeon RNG for initial dungeon setup 10(4 days ago, 1 file, 7+ 3-) 13https://github.com/crawl/crawl/commit/2dd0f10ffbf4 23:14:49 03advil02 07* 0.23-a0-866-gd59c169: Implement dungeon pregeneration (bel) 10(4 days ago, 11 files, 203+ 14-) 13https://github.com/crawl/crawl/commit/d59c169ec49a 23:14:49 03advil02 07* 0.23-a0-867-g443bbbd: Allow saving ghosts when a seed is set 10(4 days ago, 1 file, 0+ 1-) 13https://github.com/crawl/crawl/commit/443bbbdced45 23:14:49 03advil02 07* 0.23-a0-868-gde1184c: Document seeding options better, allow rc file seeds 10(4 days ago, 5 files, 35+ 2-) 13https://github.com/crawl/crawl/commit/de1184c64761 23:14:49 03advil02 07* 0.23-a0-869-g40d72c2: Add some spare RNGs before the branch ones 10(4 days ago, 1 file, 3+ 0-) 13https://github.com/crawl/crawl/commit/40d72c257c56 23:14:49 03advil02 07* 0.23-a0-870-g8f561c4: Fix a build error 10(3 days ago, 1 file, 0+ 4-) 13https://github.com/crawl/crawl/commit/8f561c41ad3a 23:14:49 03advil02 07* 0.23-a0-871-gb90a470: Add a rudimentary progress popup to run during pregeneration 10(3 days ago, 3 files, 107+ 12-) 13https://github.com/crawl/crawl/commit/b90a470cf9c9 23:14:49 ... and 18 more commits 23:15:00 03advil02 07https://github.com/crawl/crawl/pull/968 * 0.23-a0-875-gc22ec7a: Actually use a function added earlier 10(4 minutes ago, 1 file, 1+ 7-) 13https://github.com/crawl/crawl/commit/c22ec7afc011 23:15:14 dang 23:15:33 the madman went and did it wtf 23:15:55 yo but really, just_created_level in files.cc I think is *nuts* 23:16:17 switch__: what do you mean by "nuts"? 23:16:25 gonna have to explain yourself a bit better 23:16:55 the variable is all over the place, and doesn't really describe what it is. it's defined as false, then you set it to true after it's used a few times 23:17:54 well, I didn't name it 23:17:58 i know 23:17:59 by used all over the place I think you mean used in one file 23:18:04 but I do think the name is basically accurate for what that function does 23:18:15 it's just some global level state 23:18:18 has the level just been created? 23:18:21 hell is it even global? 23:18:27 no 23:18:38 all I've done is altered the meaning of "just" 23:18:51 sorry, let me make my whining a bit more refined: as someone not familiar with files.cc, reading the section between 1433 and 1483 where the variable is defined/redefined confused the hell out of me 23:18:55 the real problem is that that function smashes together a bunch of stuff that shouldn't have been done at the same time 23:19:18 yeah, load_level() is....long 23:20:21 i sorta got the idea that the function was called at different points, and that makes "just_created_level" being either true or false and hitting those various conditions make a bit more sense, but if you know exactly how that function works, it would help a lot if you could document it 23:20:21 by "function" i mean those 50 lines 23:20:21 it does some (but not all) things related to removing the player from a previous level, some (but not all) things about placing the player on a new level, loading for level excursions, and level generation 23:20:29 I'm not going to waste my time documenting load_level, I'd rather rewrite it 23:20:50 that'd work :P 23:22:03 yeah and it's not being defined/redefined 23:22:09 its value is being changed, that's it 23:22:24 it's a state variable whose value is changing depending on what load_level() is actually up to 23:22:24 that's what i meant to say, my mistake 23:22:56 well so much for topping the commit author list for 0.23 23:23:07 just rebase his commits lol 23:23:18 rebasing preserves the author field 23:23:20 heh I don't have much aside from this little commitstorm 23:23:29 i mean like, put them all together 23:24:21 squashing preserves the author field too 23:24:32 but then it'd just be one commit instead of 28 23:24:41 that wouldn't be helpful 23:24:44 oh 23:25:13 you're still about 20 behind me ebering (considering the local commits I have) 23:25:40 but it's neat how we have three people basically equally active this time 23:25:51 and this is still going to be the release where I have the most commits (breaking my PB in 0.21) 23:26:29 too bad commit counts don't really tell the full story about dev activity 23:26:37 you gotta look at %cN 23:26:57 now I look at author 23:27:00 *no 23:27:04 you don't get credit for merges, sorry 23:27:09 pwned 23:27:14 now he'll never look at my PR 23:27:16 just like what github does! 23:27:56 but yeah, counts like this don't really mean all that much; I wonder if anyone has come up with a good objective measure of "developer activity" 23:28:01 seems like it's pretty impossible 23:28:23 commits are like RBIs right? 23:28:32 you can get a decent idea just from this chat and the cheibriados messages 23:28:37 ebering: git --no-pager log --use-mailmap --no-merges --pretty="%aN" ${2-$tag..HEAD} | sort | uniq -c | sort -nr 23:28:44 for a bash function 23:29:09 so that one arg is default of 0.23-a0..HEAD 23:29:21 twelwe: commits where you're not the author are like RBIs ya 23:29:52 they're not RBIs 23:30:03 they're like you're the plate umpire and you told the runner to run 23:30:11 er the plate coach guy 23:30:19 i dunno, there were a few times where ebering took my code and fixed it before committing it 23:30:25 so i'd say that counts 23:30:58 it's a hit if you wrote some code or changed a line 23:31:34 but you can't tell that without something more sophisticated than just git log 23:32:52 that command is giving me weird results 23:33:18 how so? I assume you're changing the argument I have as a bash variable 23:33:36 top-crawl-commits () 23:33:36 { 23:33:36 tag=$(expr $(git describe origin/master) : '\(.*-a0\)'); 23:33:36 git --no-pager log --use-mailmap --no-merges --pretty="%aN" ${2-$tag..HEAD} | sort | uniq -c | sort -nr 23:33:39 } 23:33:42 is my full function 23:34:44 maybe it's just stuff that was merged much later than it was written 23:35:56 oh, I see, I think it's because ebering merged an aidanh pr 23:38:21 Unstable branch on crawl.kelbi.org updated to: 0.23-a0-889-g6b46e92f49 (34) 23:41:08 FR tree form gives huge reaching like that ownage new polearm 23:42:37 too much fun 23:42:39 not allowed 23:42:50 ebering: if aidanh used %cN, that would mean you got credit for his PR and he didn't! Could you sleep at night? 23:43:33 someone needs to make an ELO for crawl commits 23:43:57 like, the rating system? 23:44:04 someone already has 23:44:07 it's the millimarvin 23:44:11 dang 23:44:14 you want to see my notes gammafunk? 23:44:17 what about millisnarks 23:44:28 the millimarvin to millisnark ratio 23:44:33 you`re all rated pretty harshly 23:44:41 I know that your note would just read "hey..." 23:45:04 it is true they are short but thats because you have much room for improvement 23:45:13 slammed 23:50:03 advil: under Seeded play, the "Without dungeon pregeneration" and "With dungeon pregeneration" sections have inverted logic for the pregen_dungeon variable, right? 23:50:08 in the manual 23:50:27 03advil02 07* 0.23-a0-890-gc183402: swap true and false (vt) 10(36 seconds ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/c1834021d887 23:50:44 nice 23:50:45 lol 23:51:17 why are we getting political 23:52:34 ?1 list of character species, under intermediate species, how does that desc fit humans? 23:52:37 are seeds and dungeon pregen working now in webtiles? 23:52:49 `Species classified as *Intermediate* require a broader understanding of the mechanics of Crawl, have some weakness(es) that must be actively compensated for, and/or add a relatively complex mechanic (or change in mechanic) to gameplay.` 23:53:48 floraline pregen works in webtiles but is still disabled in dgl builds, because as it stands it'd be pretty rough on server cpu to turn them on. Seeds are fairly hidden in webtiles so there's not much point to pregen without them 23:54:01 I'm still thinking about how best to support a special seeded mode 23:54:35 the issue is that for regular play, I would imagine people won't want games where the seed is chosen or known to be in sequell 23:54:56 well, I don't really know what people will want, it's an interesting cultural experiment, but that seemed the most likely one to me 23:55:07 twelwe: i think it's reasonabel to say humans "require a broader understanding of the mechanics" because you have to be willing to play whatever kind of character the dungeon suggests 23:55:37 that was my intent with that at least 23:56:00 it was more a case of me trying to post hoc rationalize humans as intermediate when I drafted that paragraph 23:58:02 i want to find and correct a desc that empowers and inspires. not one that already does that of course, maybe later in life, right now i want to empower and inspire but later we`ll talk about alternatives