00:05:21 03gammafunk02 07* 0.23-a0-396-g5214e5f: A new Ijyb splash screen from ploomutoo 10(2 minutes ago, 1 file, 0+ 0-) 13https://github.com/crawl/crawl/commit/5214e5fee515 01:00:00 Unstable branch on CRAWL.XTAHUA.COM updated to: 0.23-a0-396-g5214e5f (34) 01:10:53 Unstable branch on crawl.jorgrun.rocks updated to: 0.23-a0-396-g5214e5fee5 (34) 01:11:49 The build was fixed. (master - 5214e5f #10545 : gammafunk): https://travis-ci.org/crawl/crawl/builds/449672103 02:27:31 Unstable branch on crawl.develz.org updated to: 0.23-a0-396-g5214e5f (34) 02:58:57 Windows builds of master branch on crawl.develz.org updated to: 0.23-a0-396-g5214e5f 03:11:40 Unstable branch on crawl.beRotato.org updated to: 0.23-a0-396-g5214e5f (34) 03:35:27 -!- amalloy is now known as amalloy_ 03:58:55 Monster database of master branch on crawl.develz.org updated to: 0.23-a0-396-g5214e5f 05:11:27 Hi ! I can't remember my password (new laptop at work) any way to reset it ? on akrasiac.org 05:12:03 03wheals02 07* 0.23-a0-397-g98fffd3: Allow seeing the memorise menu while confused (#11517). 10(2 minutes ago, 1 file, 0+ 3-) 13https://github.com/crawl/crawl/commit/98fffd3787d6 05:12:03 03wheals02 07* 0.23-a0-398-g8eab93f: Don't print god warnings about a spell you can't memorise anyway. 10(89 seconds ago, 1 file, 3+ 3-) 13https://github.com/crawl/crawl/commit/8eab93fbe22c 05:17:41 my contribution for this release cycle is done 06:10:43 Unstable branch on crawl.jorgrun.rocks updated to: 0.23-a0-398-g8eab93fbe2 (34) 06:46:51 <|amethyst> rabbit: email me at neil@s-z.org with your account name, preferably from the same email address that's registered with the account 06:55:31 |amethyst: sent 07:00:37 |amethyst: there must be a least 3 accounts linked to that email, the right one is on the french server 07:01:10 <|amethyst> rabbit: I thought you said akrasiac 07:01:23 <|amethyst> rabbit: CAO is the only one I can do anything about 07:01:42 <|amethyst> rabbit: CXC is medar 07:01:45 <|amethyst> !seen medar 07:01:46 I last saw Medar at Wed Oct 24 18:48:52 2018 UTC (1w 1d 16h 12m 54s ago) quitting, saying '*.net *.split'. 07:01:58 sorry it is xtahua 07:02:13 <|amethyst> rabbit: no problem, sorry I can't help :( 07:02:20 <|amethyst> ??medar 07:02:21 I don't have a page labeled medar in my learndb. 07:02:22 <|amethyst> ??cxc 07:02:22 cXc[1/2]: Server in France: CRAWL.XTAHUA.COM -- ssh port 22, username crawl, uses CAO key (available at http://CRAWL.XTAHUA.COM/crawl/keys/). Webtiles address: http://CRAWL.XTAHUA.COM Discord server https://discord.gg/SzXGZNS 07:02:29 <|amethyst> ??cxc[2 07:02:30 cXc[2/2]: Announced by Eksell, which uses | as a prefix. Morgues, ttyrecs etc. are at http://CRAWL.XTAHUA.COM/crawl/. Maintained by Medar and zkyp. 07:02:34 <|amethyst> hm 07:02:37 <|amethyst> !seen zkyp 07:02:38 I last saw zkyp at Fri Oct 26 05:55:52 2018 UTC (1w 5h 6m 46s ago) quitting, saying '*.net *.split'. 07:02:53 <|amethyst> looks like either Medar or zkyp can help, if they show up here 07:03:05 ok, thank you 07:03:25 <|amethyst> you can !tell zkyp need a password reset for account XYZ 07:03:33 <|amethyst> and likewise with Medar; then they'll see it when they next say something in IRC 07:04:15 i'm still logged in at home, the password must be written somewhere... 08:18:02 rabbit: to get in touch with medar (or I think there's another CXC admin?) the CXC discord might be faster 08:18:12 ??cxc 08:18:13 cXc[1/2]: Server in France: CRAWL.XTAHUA.COM -- ssh port 22, username crawl, uses CAO key (available at http://CRAWL.XTAHUA.COM/crawl/keys/). Webtiles address: http://CRAWL.XTAHUA.COM Discord server https://discord.gg/SzXGZNS 08:18:55 last link there is an invite 08:25:08 oh zkyp is the other admin, I get it 08:25:19 well the discord is going to be faster for them too, I think 08:45:47 advil: thanks 11:27:40 Crash during use of Brooding to swap ancestor (Hepliaklqana) located on another level with monster 13https://crawl.develz.org/mantis/view.php?id=11744 by mwcat 13:05:34 Unstable branch on crawl.akrasiac.org updated to: 0.23-a0-398-g8eab93f (34) 14:20:49 -!- amalloy_ is now known as amalloy 14:27:51 03stenella02 07https://github.com/crawl/crawl/pull/882 * 0.23-a0-390-gde9419b: Leave Dual-Wielders Alone 10(4 days ago, 1 file, 7+ 1-) 13https://github.com/crawl/crawl/commit/de9419bda126 14:37:11 wait 14:37:22 LRD doesn't break stuff anymore, huh 14:38:26 03stenella02 07https://github.com/crawl/crawl/pull/888 * 0.23-a0-396-ge779dae: Check for stat_zero slow before telling player they're good to go 10(5 minutes ago, 2 files, 4+ 1-) 13https://github.com/crawl/crawl/commit/e779daee52d1 14:38:29 how do you get broken doors? 14:43:01 shatter can destroy doors 14:43:12 is that what you mean? 14:44:57 it probably just removes the feature, I'm not sure there's a notion of broken door per se. Though corruption/abyss effects turn some features to arches, maybe including doors 14:54:20 03stenella02 07https://github.com/crawl/crawl/pull/883 * 0.23-a0-390-g34154a4: Change LRD flavour text for doors 10(4 minutes ago, 1 file, 3+ 3-) 13https://github.com/crawl/crawl/commit/34154a4612ba 15:04:34 i swear to god there are tiles of broken-to-pieces doors 15:04:36 are there not? 15:04:54 03stenella02 07https://github.com/crawl/crawl/pull/886 * 0.23-a0-394-g2127111: Disable met targets after quaffing a potion of experience 10(2 days ago, 2 files, 4+ 0-) 13https://github.com/crawl/crawl/commit/21271119b1ac 15:04:57 i just tried shatter in my local game and it made the doors straight up disappear 15:07:37 re the style guide, i'm pretty sure i saw some post reaming Realz about his use of curly brackets for single-line if statements 15:08:10 oh, only when the conditionals are single-line as well. i see 15:20:46 03stenella02 07https://github.com/crawl/crawl/pull/884 * 0.23-a0-395-gd9d9f99: Change conditionals for easier sanity checking 10(50 seconds ago, 1 file, 8+ 9-) 13https://github.com/crawl/crawl/commit/d9d9f990c2b3 15:21:12 advil: all changes made 15:31:22 03stenella02 07https://github.com/crawl/crawl/pull/886 * 0.23-a0-394-ge9cb12e: Disable met targets after quaffing a potion of experience 10(2 days ago, 2 files, 4+ 0-) 13https://github.com/crawl/crawl/commit/e9cb12e60611 15:35:38 hi 15:35:56 I was watching my availables spells, 15:36:24 and after pressing enter to describe an entry, 15:36:39 03stenella02 07https://github.com/crawl/crawl/pull/883 * 0.23-a0-390-g7979af3: Change LRD flavour text for doors 10(47 minutes ago, 1 file, 3+ 3-) 13https://github.com/crawl/crawl/commit/7979af31f351 15:37:20 Portal Projectile disappeared from the list 15:37:37 on latest trunk 15:37:53 is it possible you hid it? 15:38:32 ah perhaps 15:38:45 you're right ! 15:38:49 thank you 15:38:50 :) 15:43:22 %git 15:43:22 07wheals02 * 0.23-a0-398-g8eab93f: Don't print god warnings about a spell you can't memorise anyway. 10(11 hours ago, 1 file, 3+ 3-) 13https://github.com/crawl/crawl/commit/8eab93fbe22c 15:44:35 !bug 11517 15:44:36 https://crawl.develz.org/mantis/view.php?id=11517 15:52:14 sort of an interesting question raised by this lab rework 15:52:34 how do we TAG_MAJOR an entire source file 15:52:45 lol 15:53:51 what compat is that for? i saw the message in the code saying "don't remove this. no, seriously, don't touch this" 15:54:02 and that it would require a bit refactor 15:54:07 but i don't actually know what it means 16:22:40 gammafunk: what lab rework? 16:22:59 amalloy: I have a preliminary wiki page about it, but it's not fully completed 16:23:16 amalloy: https://github.com/crawl/crawl/wiki/Labyrinth-Rework 16:23:31 second section gives you a rough sketch of the new portal 16:23:51 switch__: TAG_MAJOR is what we change when we break save compat. so, wrapping a section in TAG_MAJOR == 34 means "this code would be removed, but is left in for save compatibility until we upgrade the major version" 16:24:00 I'm getting a working prototype going with a first map, hope to have at least a few ready 16:24:19 related question, if I put a TAG_MAJOR_VERSION in defines.h, that should be fine, right? 16:24:33 that define is at the macro level so there's no scoping or anything? 16:24:44 I see aptitudes.h using that despite not including tag-version.h 16:24:50 or any head that includes that 16:25:24 sure, but that tag is *years* old 16:25:32 i meant more like, what does it *actually* mean 16:25:57 switch__: yes, it's been a long time since we broke save compat. someone (advil i think?) wrote up a cool article about the history of save compat 16:26:55 https://github.com/crawl/crawl/blob/master/crawl-ref/docs/develop/history/major-tag-history.md 16:27:03 Minor bug; I don't think it's possible to animate skeleton in deep water. 16:27:21 My octopode is getting a "no room" message. 16:27:22 i don't know how to answer what it "actually" means. it means that we're keeping save compatibility 16:27:54 On corpses that will produce deep-water compatible skeletons 16:29:37 pblur: this is a known issue that's been reported a number of times; the canonical bug seems to be https://crawl.develz.org/mantis/view.php?id=9716 16:30:13 Ah, I see. I should probably have searched for it before mentioning it. 16:50:30 door missing in due_jungle_book vault 13https://crawl.develz.org/mantis/view.php?id=11745 by NormalPerson7 16:55:47 Punk's acid splash damage appears to ignore enemy acid resistance 13https://crawl.develz.org/mantis/view.php?id=11746 by NormalPerson7 17:22:42 btw thank you all for this great game 18:05:33 advil: I won't be around super much but will try to keep an eye on irc 18:06:44 gammafunk: the lab rework sounds like vaults that i think minmay made? 18:07:22 or maybe it was r-i 18:07:55 actually I think it was r-i's and it was called the gauntlet? 18:08:23 there was a playable model of it. Set in pandemonium with cheering crowds of demons watching on 18:27:10 https://i.imgur.com/7iWQnGW.png why is claws an override? 18:29:02 https://github.com/crawl/crawl/commit/dc8eb4eb1912dbc546a8ca76ed896dd06d0dfc33 18:29:05 uhh, sure, but why? 18:29:24 <|amethyst> switch__: because unlike the others that one implements a pure virtual method from actor 18:29:40 <|amethyst> switch__: because unlike the others, it's defined for monsters too 18:30:31 ahh, gotcha 18:31:37 https://i.imgur.com/e7hh0GT.png no shit 18:31:49 <|amethyst> hah 18:32:50 <|amethyst> honestly we should probably get rid of the bool version of get_mutation_level 18:33:21 <|amethyst> and default minact = mutation_activity_type::PARTIAL 18:33:52 <|amethyst> since it's more informative at the call site to see an enum and not a bool 18:34:23 <|amethyst> s/enum/&erator/ 18:34:28 https://i.imgur.com/0Hihm9k.png 18:34:30 jesus 18:39:58 |amethyst: any recommendations for me if I essentially want to tag major dgn-labyrinths.cc ? 18:40:13 what's left of it that I don't just remove, that is 18:40:23 actually I should really confirm that there will be any left 18:40:42 the level creaton code I can remove, just not anything required for the portal to work for saves already existing there 18:41:03 *creation 18:41:31 the new portal shouldn't need any special support on the C++ side of things, I think 18:42:40 holy crap 18:42:47 player minotaurs have map rot resistance? 18:43:02 TIL 18:43:31 in labs only, that is 18:49:49 <|amethyst> gammafunk: could merge it into some other file 18:49:58 <|amethyst> then literally ifdef it out 18:50:00 ah, good thinking 18:51:07 -!- neunon_ is now known as neunon 18:52:00 the changes i'm making right now will probably never even see a commit 18:52:00 but 18:52:11 the person that left "life protection" everywhere 18:52:28 instead of negative energy 18:52:28 are they still here? 18:58:02 well, it used to be called that 18:58:09 there was a ring of life protection, etc 18:58:18 so don't be too hard on them 18:58:23 ??life protection 18:58:24 life protection[1/1]: Resistance to draining attacks, shown on artifact inscriptions as rN+. Three levels makes you completely immune. As in, it turns shadow dragons into mostly harmless kittens. Also gives partial resistance to torment (5% per level, so at rN+++, torment will make you lose 35% hp, instead of 50%). 18:59:13 it looks like it was mostly removed from player-facing flavor by 0.16 or so 19:02:08 these player_s 19:02:18 are these just relics? 19:04:18 the ideal would be to use the inhereted functions, right? 19:10:47 just looking at one (poison), they're not relics as a practical matter because the player:: versions are not used very much, and are only there for the rare times where e.g. actor::res_poison is called 19:11:13 the fire one is called directly quite a bit 19:11:33 I think the answer to your question from my perspective is something like, if I were designing all this from scratch I would absolutely not do it that way 19:12:00 that way = the way that it currently is 19:12:16 well, the question is more like 19:12:18 how should I do it 19:12:20 lol 19:12:40 probably the derived classes, right? 19:12:51 are you asking if you should reorganize them? 19:13:07 no, i'm asking HOW I should reorganize them 19:15:03 ok, if you are organizing them, use the class based ones 19:15:37 heh, the player::res_fire() literally just exists, it isn't used anywhere 19:15:42 it seems like someone went and made all these classes 19:15:44 -!- CaptainFruitcake is now known as CanOfWorms 19:15:45 but didn't actually implement them 19:15:55 err, functions, not classes 19:16:02 I've done many tedious cleanup projects in crawl, and personally wouldn't choose that one, fwiw 19:16:43 well, this part of the code doesn't feel foreign to me 19:17:16 plus i like doing stuff that other people don't ._. 19:22:56 Unstable branch on underhound.eu updated to: 0.23-a0-398-g8eab93fbe2 (34) 19:24:54 -!- Bloaxzorro was kicked from ##crawl-dev by MarvinPA_ [Bloaxzorro] 19:30:40 gottem 19:31:28 https://i.imgur.com/o0ZMVML.png advil i've run into this problem like 4 times now 19:31:43 i'm pretty sure there's a gap in my knowledge of how computers work 19:32:07 does actor actually have that function? 19:32:36 ah, okay 19:32:40 so that's the problem? 19:32:56 well, you can't override something that's not there :) 19:33:09 so the monster and actor functions don't have any of the variables passed to them 19:33:22 ah, yes, that's another issue 19:33:30 oh boy 19:33:33 i see why this is how it is now 19:33:34 that monster / player resists don't necessarily work identically 19:40:20 -!- MarvinPA_ is now known as MarvinPA 19:53:14 -!- neunon_ is now known as neunon 20:13:17 -!- amalloy is now known as amalloy_ 20:35:20 switch__: in general its strongly preferred to post pastebins or links to line numbers in the github repo over pictures of text 20:35:40 referring to what? 20:37:03 switch__: all of the imgur links you've sent today with pictures of the text of crawlcode 20:37:52 -!- amalloy_ is now known as amalloy 20:38:20 oh, i see. i did do that, didn't i. 20:38:20 noted 20:38:36 though in at least one of those cases the code was modified, so it wouldn't have done much good 20:39:18 in that case use a paste service like github's gist 20:40:19 I have remarkably poor eyesight, being able to set the font size is very helpful to me 21:13:56 what do you think about implementing a parameter object? 21:14:04 or rather, what would be the least ugly way to do it 21:16:10 a parameter object? 21:16:40 right. instead of having calc_unid, temp, items, spells (in one case), transformations, etc. 21:16:43 have a single object 21:16:55 that has all that information 21:17:57 sorry, to be more clear, rather than have a bunch of boolean parameters of questionble origin and consistency, have an object 21:19:06 switch__: a parameter object is fine if there are a lot of functions taking the same parameters, or something like that. it doesn't really help the box-of-bools problem though imo 21:19:29 we have some things like that for certain cases, but if you mean something general, I'm not sure that would be better 21:19:38 practically everything that implements player functions takes some random assortment of the same paramewters 21:19:39 <|amethyst> an enum for each particular yes/no question wouldn't be terrible 21:19:57 i prefer to split up such cases into separate functions, or define a new enum 21:20:14 i don't, it's unnecessarily complicated to split it up 21:20:20 and difficult to read 21:20:40 <|amethyst> e.g. for the "temp"(orary effects) parameter of various monster and player queries 21:20:43 "temp" is the biggest reason to do it, actually 21:20:53 because "temp" is actually spells, transformations, potions, gods, etc. 21:21:03 and we can't just put 10 more booleans in each function 21:21:09 or at least nobody has been able to convince you to thus far 21:21:22 and if it was up to me i wouldn't do it that way either 21:21:55 a parameter object with 10 more booleans is no better 21:22:12 it's infinitely better 21:22:16 or, well, not a lot better 21:22:34 it doesn't shit up each function, while allowing you to actually customize each call properly 21:22:54 is this being driven by some specific need? 21:23:36 it's been part of almost every problem i've looked at thus far 21:23:45 and is a problem in the one i'm looking at now 21:24:12 I'm still not exactly sure what "it" is :) 21:24:43 boolean parameters moving between functions with questionable consistency and origin 21:25:20 I think it might be better to focus on a specific problem 21:26:07 i could give you a number of them that it would solve 21:26:16 ok, like what? 21:26:33 uselessness for rings of poison resistance being affected by potions 21:27:11 i could actually literally make a list, it really wouldn't be that hard 21:27:14 but it's dinner time, brb 21:27:17 seriously, it's a good idea 21:27:37 you haven't very clearly explained either the idea or the problem :) 21:40:13 the bug with rpois appears to just be that one of the temp parameters is inverted 21:40:57 and rcorr just doesn't have a temp parameter 21:42:36 though I'm not entirely sure I think it's a bug for item graying to be based on temporary changes? 21:42:41 the problem that's arisen from the incremental improvement on the codebase is that you have a bunch of functions that do similiar things in different ways 21:42:55 well, you'd never want to throw away your rpois ring just because you quaffed a resistance potion 21:43:04 or not pick one up if you came across one 21:43:06 you might want to take it off though 21:43:19 in lichform you definitely would 21:43:48 sure, but that's not one of the cases 21:44:05 there are no affects on already equipped items, only items on the ground 21:44:08 effects* 21:44:28 the gray color shows in your inventory 21:44:53 but the problem isn't even that there's something wrong with the function, it's that the function has no way to tell the difference between a potion of resistance and gargoyle 21:45:03 because parameters have been passed to these functions as they've been needed to 21:47:22 all of the poison related functions have a temp parameter, and player_res_poison already correctly respects resistance pot as a temporary effect 21:48:11 sure, but it also considers mutations temporary effects 21:49:28 which... they are, but the limit of the implementation is clearly being shown here 21:49:48 I think you're misunderstanding what the get_mutation_call does; the bool arg there is about forms 21:50:23 what? 21:50:46 mutations aren't treated as temporary unless they come from a form 21:50:55 or are suppressed by a form 21:51:22 oh, you're right 21:51:25 wait so why is this a bug 21:51:38 is it being called with temp set to true? 22:21:13 I think it ends up being because `item_prefix` (which is what is used to determine color in my testing in InvEntry::highlight_colour) has a default temp argugment of true 22:21:44 for whatever reason KnownEntry::highlight_colour isn't being used 22:22:06 !source invent.h:138 22:22:07 https://github.com/crawl/crawl/blob/master/crawl-ref/source/invent.h#L138 22:23:21 that's the call 22:25:07 I'm guessing it has this default so that things like potions show up as useless relative to forms 22:34:44 ground color is done somewhere else though 22:37:06 same issue, though, it still uses `item_prefix` for ground colors 22:37:13 !source menu_colour_item_name 22:37:14 1/1. https://github.com/crawl/crawl/blob/master/crawl-ref/source/item-name.cc#L3928 22:37:49 and the default temp parameter there is true 22:38:39 anyways, I'm still not really convinced that it is a problem to show things as temporarily useless, and it seems like what you'd want for some kinds of items 22:38:45 e.g. potions 22:39:19 maybe ground colour should be non-temp, inventory colour should be temp, but then that's a bit confusing 22:40:38 that sounds like it would work 22:40:41 but yes, that is confusing 22:42:23 i think it's safer to assume that the player knows what's going on with themselves, temporarily 22:42:29 and that they can make decisions based on that 22:42:41 i.e. it's probably better not to recolor based on it 22:43:26 but honestly that's something that, ideally, could be left up to the player 22:43:31 in an options menu, for example 22:43:40 the one that doesn't exist 22:45:25 -!- neunon_ is now known as neunon