00:00:23 Unstable branch on CRAWL.XTAHUA.COM updated to: 0.23-a0-373-g305c090 (34) 01:47:34 -!- amalloy_ is now known as amalloy 01:50:32 switch__: the bug is easily reproduced prior to that commit. wear some HP+9 item, damage yourself to half-health, and then cast dragon form 01:50:41 you go up to like 80% health 01:51:06 or anyway you do if your base hp is very low (i was testing on an XL1 dude) 02:17:40 autosquash is amazing ebering, thanks for the tip 02:21:02 -!- ProzacElf_ is now known as ProzacElf 02:25:25 flotson (L20 DsSk) ASSERT(you.attribute[ATTR_EXCRUCIATING_WOUNDS] || you.duration[DUR_EXCRUCIATING_WOUNDS]) in 'spl-wpnench.cc' at line 28 failed. (Depths:2) 02:26:25 flotson (L20 DsSk) ASSERT(you.attribute[ATTR_EXCRUCIATING_WOUNDS] || you.duration[DUR_EXCRUCIATING_WOUNDS]) in 'spl-wpnench.cc' at line 28 failed. (Depths:2) 02:40:09 i wonder if that's a bug from the weapon melding commit 02:40:33 !crashlog 02:40:42 20332. 11111, XL1 HOFi, T:36 (milestone): https://crawl.jorgrun.rocks/morgue/11111/crash-11111-20181024-224017.txt 02:41:00 !source spl-wpnench.cc 02:41:01 https://github.com/crawl/crawl/blob/master/crawl-ref/source/spl-wpnench.cc 03:12:07 Unstable branch on crawl.beRotato.org updated to: 0.23-a0-373-g305c090 (34) 03:15:22 can the finalmsg for portal vaults appear a bit earlier? currently it's not even long enough to walk to a portal that's in LOS 03:19:47 minmay: do you know already where the code for that is? 05:17:57 -!- broquain1 is now known as broquaint 06:45:40 -!- OICU812 is now known as MyFoot 09:30:31 Do we have a signal we can send to a stuck DCSS-proc to gracefully shut it down? 10:11:25 03ebering02 07https://github.com/crawl/crawl/pull/872 * 0.23-a0-380-g0784a30: Derandomise num_traps_for_place 10(3 minutes ago, 3 files, 13+ 15-) 13https://github.com/crawl/crawl/commit/0784a30043fd 10:32:56 TZer0 I *think* that regular SIGHUP tries to be graceful, but if that's not working (which it probably won't for a really stuck process), you'll need to use SIGKILL which will not be graceful 10:41:02 -!- MyFoot is now known as WhoAteMyToe 11:04:33 -!- WhoAteMyToe is now known as MeatyToeBBQ 11:17:02 Yermak: the formula there was somewhat unclear. I've updated the branch to derandomise some things to make the trapping rate easier to understand. 11:17:30 It currently assumes the player steps on 1/4 of tiles which is probably too high but might still "feel" ok 11:20:12 as for the probability of being trapped being greater while moving in open space (as well as being anisotropic) well it does. 11:21:37 making the trap rate constant per move that reveals tiles is also possible, but doesn't solve the problem of anisotropy of trap chance when you look at two-move sequences 12:34:57 -!- amalloy is now known as amalloy_ 12:55:54 -!- Euph0ria is now known as TabMasher 13:05:04 -!- amalloy_ is now known as amalloy 13:05:56 Unstable branch on crawl.akrasiac.org updated to: 0.23-a0-373-g305c090 (34) 13:21:51 hey who wants to rewrite hp :) 13:31:59 get_real_hp is a bit of a mess 13:32:21 it's kind of what's causing the issues with PR 870 13:33:09 crawlcode is a complicated maze of features, where each subsystem tricks other subsystems into doing things they don't expect 13:41:04 making it little different from commercial code bases >.>] 13:46:19 %git 3a533adeb52d2e3d23018019ff49f8708f91c7ce 13:46:19 07kilobyte02 * 0.10-a0-683-g3a533ad: Add another overpowered fixedart, a ring this time. 10(7 years ago, 7 files, 42+ 3-) 13https://github.com/crawl/crawl/commit/3a533adeb52d 13:55:49 03NormalPerson702 {MarvinPA} 07* 0.23-a0-374-g7e0f0f3: Announce the starting items and spells for wanderers (11725) 10(2 days ago, 1 file, 41+ 4-) 13https://github.com/crawl/crawl/commit/7e0f0f394430 13:55:49 03NormalPerson702 {MarvinPA} 07* 0.23-a0-375-g66a18ee: Start Wn with a spell memorised if they have only one level 1 spell 10(2 days ago, 4 files, 27+ 3-) 13https://github.com/crawl/crawl/commit/66a18ee0fb38 13:59:26 uhm 13:59:38 I hope they intended to merge only two of those commits 13:59:50 because the fix commit was pretty important I thought 14:00:17 ah nevermind he rebased it, I see 14:00:29 yeah i squashed the fixes into the second commit 14:03:20 thanks for the pr, the spell memorisation thing was something i thought had always already existed but apparently not! 14:03:27 -!- MarvinPA_ is now known as MarvinPA 14:04:52 it existed at some point 14:06:01 ebering: btw, objstat can count features now, including traps, although it lables random traps as floor rather incorrectly 14:06:41 oh, cool 14:06:43 ebering: I need to clean up how it does that counting, but if you want to see data on random as well as revealed trap gen on a per-level/branch/dungeon basis, it's there 14:06:59 I think it may need fixing to break down trap type, though 14:07:08 for random ones, that is 14:10:48 Unstable branch on crawl.jorgrun.rocks updated to: 0.23-a0-375-g66a18ee0fb (34) 15:57:33 New branch created: pull/875 (1 commit) 13https://github.com/crawl/crawl/pull/875 15:57:34 03NormalPerson702 07https://github.com/crawl/crawl/pull/875 * 0.23-a0-351-g4ca7f8e: Fix transformation HP scaling with HP+ artefacts (11728) (take 2) 10(31 minutes ago, 4 files, 44+ 34-) 13https://github.com/crawl/crawl/commit/4ca7f8ebdf4b 16:02:51 03NormalPerson702 07https://github.com/crawl/crawl/pull/875 * 0.23-a0-351-gde16c58: Fix transformation HP scaling with HP+ artefacts (11728) (take 2) 10(36 minutes ago, 4 files, 43+ 34-) 13https://github.com/crawl/crawl/commit/de16c58318fc 16:05:27 just force-pushed twice, sorry about the spam :) 16:08:08 03NormalPerson702 07https://github.com/crawl/crawl/pull/875 * 0.23-a0-351-ged5ecf3: Fix transformation HP scaling with HP+ artefacts (11728) (take 2) 10(41 minutes ago, 4 files, 44+ 34-) 13https://github.com/crawl/crawl/commit/ed5ecf33523b 16:09:44 looks like I can do better still 16:13:25 03NormalPerson702 07https://github.com/crawl/crawl/pull/875 * 0.23-a0-351-gb49ccaa: Fix transformation HP scaling with HP+ artefacts (11728) (take 2) 10(47 minutes ago, 4 files, 44+ 34-) 13https://github.com/crawl/crawl/commit/b49ccaa70fcd 16:16:41 that's the last time I promise 17:43:17 03Stenella02 {GitHub} 07https://github.com/crawl/crawl/pull/871 * 0.23-a0-382-g8672d71: Merge pull request #2 from crawl/master 10(3 minutes ago, 0 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/8672d7143414 17:53:00 a merge commit in a pull request that's merging another pull request? 17:53:12 something didn't go right there 17:53:51 New branch created: pull/876 (7 commits) 13https://github.com/crawl/crawl/pull/876 17:53:51 03stenella02 07https://github.com/crawl/crawl/pull/876 * 0.23-a0-370-gf5a67bd: MSVC2017 Changes 10(2 days ago, 33 files, 2688+ 920-) 13https://github.com/crawl/crawl/commit/f5a67bd2bd45 17:53:51 03stenella02 07https://github.com/crawl/crawl/pull/876 * 0.23-a0-371-gf4b2429: Update crawl-ref/source/libutil.h 10(2 days ago, 1 file, 7+ 6-) 13https://github.com/crawl/crawl/commit/f4b242999176 17:53:51 03stenella02 07https://github.com/crawl/crawl/pull/876 * 0.23-a0-372-g8c11ec0: Reverted accidental indentation changes, added comments for unicode characters 10(28 hours ago, 2 files, 162+ 139-) 13https://github.com/crawl/crawl/commit/8c11ec0dd316 17:53:51 03stenella02 07https://github.com/crawl/crawl/pull/876 * 0.23-a0-373-g2de947b: Update crawl-ref/INSTALL.txt 10(26 hours ago, 1 file, 48+ 7-) 13https://github.com/crawl/crawl/commit/2de947bf75bb 17:53:51 03stenella02 07https://github.com/crawl/crawl/pull/876 * 0.23-a0-374-gbbfd2ea: Update crawl-ref/source/shopping.cc 10(26 hours ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/bbfd2eae1b37 17:53:51 03Stenella02 {GitHub} 07https://github.com/crawl/crawl/pull/876 * 0.23-a0-375-g1732f49: use proper fix 10(26 hours ago, 1 file, 9+ 8-) 13https://github.com/crawl/crawl/commit/1732f49720c3 17:53:51 03Stenella02 {GitHub} 07https://github.com/crawl/crawl/pull/876 * 0.23-a0-376-g61c779a: Merge pull request #1 from stenellad/master 10(16 minutes ago, 0 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/61c779a746e7 17:54:05 oh god 17:54:16 listen, i'm learning 17:54:18 .____. 17:55:01 basically i made a PR from my fork's master branch 17:55:06 but now i want to make another PR 17:55:11 so i have to unfuck everything 18:22:13 Unstable branch on underhound.eu updated to: 0.23-a0-375-g66a18ee0fb (34) 18:30:52 New branch created: pull/877 (22 commits) 13https://github.com/crawl/crawl/pull/877 18:30:53 03stenella02 07https://github.com/crawl/crawl/pull/877 * 0.23-a0-370-gf5a67bd: MSVC2017 Changes 10(2 days ago, 33 files, 2688+ 920-) 13https://github.com/crawl/crawl/commit/f5a67bd2bd45 18:30:53 03stenella02 07https://github.com/crawl/crawl/pull/877 * 0.23-a0-371-gf4b2429: Update crawl-ref/source/libutil.h 10(2 days ago, 1 file, 7+ 6-) 13https://github.com/crawl/crawl/commit/f4b242999176 18:30:53 03stenella02 07https://github.com/crawl/crawl/pull/877 * 0.23-a0-372-g8c11ec0: Reverted accidental indentation changes, added comments for unicode characters 10(29 hours ago, 2 files, 162+ 139-) 13https://github.com/crawl/crawl/commit/8c11ec0dd316 18:30:53 03stenella02 07https://github.com/crawl/crawl/pull/877 * 0.23-a0-373-g2de947b: Update crawl-ref/INSTALL.txt 10(27 hours ago, 1 file, 48+ 7-) 13https://github.com/crawl/crawl/commit/2de947bf75bb 18:30:53 03stenella02 07https://github.com/crawl/crawl/pull/877 * 0.23-a0-374-gbbfd2ea: Update crawl-ref/source/shopping.cc 10(27 hours ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/bbfd2eae1b37 18:30:53 03stenella02 07https://github.com/crawl/crawl/pull/877 * 0.23-a0-375-ga80bcff: HP simplification 10(70 minutes ago, 9 files, 41+ 96-) 13https://github.com/crawl/crawl/commit/a80bcff05e5c 18:30:53 03stenella02 07https://github.com/crawl/crawl/pull/877 * 0.23-a0-376-g13ab699: Update crawl-ref/source/player.cc 10(65 minutes ago, 1 file, 41+ 0-) 13https://github.com/crawl/crawl/commit/13ab69993fd3 18:30:53 03stenella02 07https://github.com/crawl/crawl/pull/877 * 0.23-a0-377-g53e4f06: Update crawl-ref/source/transform.cc 10(29 minutes ago, 1 file, 24+ 6-) 13https://github.com/crawl/crawl/commit/53e4f06e9ce4 18:30:53 03Stenella02 {GitHub} 07https://github.com/crawl/crawl/pull/877 * 0.23-a0-384-g43f4f67: Merge pull request #3 from crawl/master 10(29 minutes ago, 0 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/43f4f675a559 18:30:53 03stenella02 07https://github.com/crawl/crawl/pull/877 * 0.23-a0-378-g800073c: Update crawl-ref/source/transform.cc 10(28 minutes ago, 1 file, 5+ 23-) 13https://github.com/crawl/crawl/commit/800073c3b7c7 18:30:53 ... and 12 more commits 18:31:59 yikes 18:32:34 this is more or less normal when people are revising big prs :) 18:35:50 it's more that i didn't use git properly in the first place 18:35:51 :D 18:38:08 that's also not so uncommon :) 18:41:27 03stenella02 07https://github.com/crawl/crawl/pull/871 * 0.23-a0-383-g95040f0: Revert "Update crawl-ref/source/shopping.cc" 10(2 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/95040f0d0742 18:41:27 03stenella02 07https://github.com/crawl/crawl/pull/871 * 0.23-a0-384-gb275214: Revert "Update crawl-ref/INSTALL.txt" 10(2 minutes ago, 1 file, 7+ 48-) 13https://github.com/crawl/crawl/commit/b275214a6a44 18:41:27 03stenella02 07https://github.com/crawl/crawl/pull/871 * 0.23-a0-385-gc46c3ba: Revert "Reverted accidental indentation changes, added comments for unicode characters" 10(2 minutes ago, 2 files, 139+ 162-) 13https://github.com/crawl/crawl/commit/c46c3ba65123 18:41:27 03stenella02 07https://github.com/crawl/crawl/pull/871 * 0.23-a0-386-g6f7fe2b: Revert "Update crawl-ref/source/libutil.h" 10(80 seconds ago, 1 file, 6+ 7-) 13https://github.com/crawl/crawl/commit/6f7fe2bb1455 18:41:27 03stenella02 07https://github.com/crawl/crawl/pull/871 * 0.23-a0-387-g301b201: Revert "MSVC2017 Changes" 10(73 seconds ago, 32 files, 919+ 2687-) 13https://github.com/crawl/crawl/commit/301b20183e3f 18:42:12 can someone close that PR 18:42:13 please 18:42:14 lol 18:43:51 oh, i can 18:53:47 switch__: I suggest you learn about git rebase --interactive. It will allow you to revise the branch stenellad:hp to be a single commit (the one that addresses the transform bug). It also allows you to re-write history (so small fixup commits can be squashed into meaningful ones). 18:54:09 i'll look into that right now 18:54:09 thanks 18:55:27 once you've done so you can force-push to your branches and github will clean it up 18:55:50 also, while you're revising there's some od whitespacing in your get_real_hp comment that you can edit out :) 18:57:36 i saw that :P 18:58:13 was kinda scared to change it lest I make another 15 bot messages 18:58:16 thanks for the help :D 20:11:20 03stenella02 07https://github.com/crawl/crawl/pull/876 * 0.23-a0-370-g96e3f81: MSVC2017 Changes 10(2 days ago, 43 files, 2685+ 865-) 13https://github.com/crawl/crawl/commit/96e3f81cc08c 20:11:20 03advil02 {stenella} 07https://github.com/crawl/crawl/pull/877 * 0.23-a0-370-g8372b0f: Improve (?) filtered_vector_select 10(2 days ago, 1 file, 8+ 7-) 13https://github.com/crawl/crawl/commit/8372b0f034f6 20:11:20 03Doesnt02 {stenella} 07https://github.com/crawl/crawl/pull/877 * 0.23-a0-371-g4ba7a0c: Spelling 10(33 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/4ba7a0c25536 20:11:20 03advil02 {stenella} 07https://github.com/crawl/crawl/pull/877 * 0.23-a0-372-g1d12c4d: Try again to avoid recursive crashes when loading level/save data 10(29 hours ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/1d12c4dd41e0 20:11:20 03NormalPerson702 {stenella} 07https://github.com/crawl/crawl/pull/877 * 0.23-a0-373-gc8987cb: Announce the starting items and spells for wanderers (11725) 10(2 days ago, 1 file, 41+ 4-) 13https://github.com/crawl/crawl/commit/c8987cbd2c84 20:11:20 03NormalPerson702 {stenella} 07https://github.com/crawl/crawl/pull/877 * 0.23-a0-374-g8b84c43: Start Wn with a spell memorised if they have only one level 1 spell 10(2 days ago, 4 files, 27+ 3-) 13https://github.com/crawl/crawl/commit/8b84c432d756 20:11:20 03stenella02 07https://github.com/crawl/crawl/pull/877 * 0.23-a0-375-gfbf3ec3: HP Changes/Transformation Bugfix 10(6 minutes ago, 9 files, 78+ 91-) 13https://github.com/crawl/crawl/commit/fbf3ec379c65 20:11:22 uhh 20:21:54 03stenella02 07https://github.com/crawl/crawl/pull/877 * 0.23-a0-370-g75e690a: HP Changes/Transformation Bugfix 10(17 minutes ago, 9 files, 41+ 57-) 13https://github.com/crawl/crawl/commit/75e690af5690 20:22:36 i fixed it, and it only took 50 bot messages to let everyone know :) 20:23:59 "Since deflate_hp()'s second parameter is always false, make it default." 20:24:25 it that param is literally false in every call, it should be removed 20:26:02 there's technically a use for it 20:26:07 it just hasn't been used yet 20:26:24 otherwise i'd have removed the function entirely 20:26:49 since it's essentially if (hp > max_hp) hp = max_hp 20:27:11 03stenella02 07https://github.com/crawl/crawl/pull/877 * 0.23-a0-370-g870e352: HP Changes/Transformation Bugfix 10(22 minutes ago, 9 files, 39+ 55-) 13https://github.com/crawl/crawl/commit/870e352d3f86 20:28:47 not sure why there's a branch conflict there 20:28:48 ._. 20:29:49 Webtiles server restarted. 20:31:14 oh, because it thinks the changes were never reverted 20:36:25 -!- amalloy is now known as amalloy_ 20:53:37 03stenella02 07https://github.com/crawl/crawl/pull/877 * 0.23-a0-376-ge6b1ce0: HP Simplification & Transform Bugfix 10(8 minutes ago, 9 files, 33+ 46-) 13https://github.com/crawl/crawl/commit/e6b1ce0af0dd 20:55:56 k for real this time, you can totally merge that shit 20:58:53 03stenella02 07https://github.com/crawl/crawl/pull/877 * 0.23-a0-376-g69d6242: HP Simplification & Transform Bugfix 10(13 minutes ago, 9 files, 31+ 44-) 13https://github.com/crawl/crawl/commit/69d62423398f 21:07:35 gammafunk, would you prefer i removed it? 21:08:17 generally it's better to remove code that's unused with no plan for it becoming used, yeah; but I haven't looked at the code in question, just saw your comment 21:08:45 maybe advil or amalloy can take a look about that, but I can't right now, sorry 21:14:50 it isn't really a source of confusion, especially after removing the need to specify that parameter 21:51:43 New branch created: pull/878 (1 commit) 13https://github.com/crawl/crawl/pull/878 21:51:43 03stenella02 07https://github.com/crawl/crawl/pull/878 * 0.23-a0-376-g75e67a6: MSVC 2017 Compatability 10(8 minutes ago, 33 files, 2588+ 796-) 13https://github.com/crawl/crawl/commit/75e67a687169 21:55:41 is there an easy way to lose HP in wizard mode? 22:12:15 summon a monster I guess 22:15:09 you can do x then , on yourself 22:15:13 to take yourself to 1hp 22:15:30 also works on monsters 22:27:27 alexjurkiewicz: I'm guessing the experimentaal doesn't automatically re-build? 22:27:40 (I haven't checked, but I pushed one more change public) 22:28:16 ebering: it does not, i'll rebuild now 22:28:26 just @ me if you want a rebuild 22:32:53 maybe too early for this feedback, but in do_trap_effects the logic seems sort of backwards. I would have thought it should first check if a trap is triggered and then determine the type of trap. Currently it is sort of inverted 22:34:03 built 23:11:00 03stenella02 07https://github.com/crawl/crawl/pull/877 * 0.23-a0-377-gd8542ff: Combined calc_hp() and recalc_and_scale_hp() 10(4 minutes ago, 14 files, 49+ 52-) 13https://github.com/crawl/crawl/commit/d8542ffa279e 23:14:41 comments are in the PR 23:21:31 03alexjurkiewicz02 07https://github.com/crawl/crawl/pull/581 * 0.21-a0-152-gc36084b: Rework multiplier (advil) 10(17 minutes ago, 1 file, 5+ 2-) 13https://github.com/crawl/crawl/commit/c36084b51bc9 23:32:08 03stenella02 07https://github.com/crawl/crawl/pull/877 * 0.23-a0-377-gccf8fb6: Combined calc_hp() and recalc_and_scale_hp() 10(25 minutes ago, 14 files, 49+ 52-) 13https://github.com/crawl/crawl/commit/ccf8fb61f313 23:50:42 -!- amalloy_ is now known as amalloy