00:03:40 !crashlog 00:03:41 20182. TheMeInTeam, XL19 MuHu, T:60835 (milestone): http://crawl.berotato.org/crawl/morgue/TheMeInTeam/crash-TheMeInTeam-20181018-035422.txt 00:06:44 Unstable branch on CRAWL.XTAHUA.COM updated to: 0.23-a0-338-g8ff0b24 (34) 00:10:43 Unstable branch on crawl.jorgrun.rocks updated to: 0.23-a0-338-g8ff0b24cde (34) 01:03:24 https://imgur.com/a/HWtBIVI 01:03:29 eveningstar of torment tiles 01:04:05 jesus 01:27:13 03gammafunk02 07* 0.23-a0-339-gbd7f2c8: New tiles for the Sceptre of Torment (CanOfWorms) 10(5 minutes ago, 4 files, 2+ 1-) 13https://github.com/crawl/crawl/commit/bd7f2c837c05 02:10:43 Unstable branch on crawl.jorgrun.rocks updated to: 0.23-a0-339-gbd7f2c837c (34) 02:57:20 -!- amalloy is now known as amalloy_ 03:19:28 Unstable branch on crawl.beRotato.org updated to: 0.23-a0-339-gbd7f2c8 (34) 04:32:30 03gammafunk02 {aegolden} 07https://github.com/crawl/crawl/pull/865 * 0.23-a0-335-gd0eab90: Fix a crash when death curses torment (geekosaur) 10(15 hours ago, 1 file, 8+ 6-) 13https://github.com/crawl/crawl/commit/d0eab9014706 04:32:30 03gammafunk02 {aegolden} 07https://github.com/crawl/crawl/pull/865 * 0.23-a0-336-gbbd9a8c: Don't give a prompt for the Singing Sword's spell effect 10(15 hours ago, 1 file, 5+ 1-) 13https://github.com/crawl/crawl/commit/bbd9a8ce5daa 04:32:30 03gammafunk02 {aegolden} 07https://github.com/crawl/crawl/pull/865 * 0.23-a0-337-geeaf82f: Mark test statues as harmless monsters and clean up spacing 10(13 hours ago, 1 file, 2+ 4-) 13https://github.com/crawl/crawl/commit/eeaf82f4f826 04:32:30 03gammafunk02 {aegolden} 07https://github.com/crawl/crawl/pull/865 * 0.23-a0-338-gb1fcda3: Fix attack prompts for some unrand weapons 10(8 hours ago, 3 files, 33+ 17-) 13https://github.com/crawl/crawl/commit/b1fcda386816 04:32:30 03gammafunk02 {aegolden} 07https://github.com/crawl/crawl/pull/865 * 0.23-a0-339-g72fe373: Fix crashes for melee attacks without a weapon 10(5 hours ago, 1 file, 4+ 4-) 13https://github.com/crawl/crawl/commit/72fe373208c7 04:32:30 03gammafunk02 {aegolden} 07https://github.com/crawl/crawl/pull/865 * 0.23-a0-340-g6d1ddf1: New tiles for the Sceptre of Torment (CanOfWorms) 10(3 hours ago, 4 files, 2+ 1-) 13https://github.com/crawl/crawl/commit/6d1ddf188913 04:37:47 03gammafunk02 {aegolden} 07https://github.com/crawl/crawl/pull/865 * 0.23-a0-334-gc54d7aa: Fix a crash when death curses torment (geekosaur) 10(15 hours ago, 1 file, 8+ 6-) 13https://github.com/crawl/crawl/commit/c54d7aa0cd19 04:37:47 03gammafunk02 {aegolden} 07https://github.com/crawl/crawl/pull/865 * 0.23-a0-335-g3d32a59: Don't give a prompt for the Singing Sword's spell effect 10(15 hours ago, 1 file, 5+ 1-) 13https://github.com/crawl/crawl/commit/3d32a595cd06 04:37:47 03gammafunk02 {aegolden} 07https://github.com/crawl/crawl/pull/865 * 0.23-a0-336-gf44c51c: Mark test statues as harmless monsters and clean up spacing 10(13 hours ago, 1 file, 2+ 4-) 13https://github.com/crawl/crawl/commit/f44c51cd681b 04:37:47 03gammafunk02 {aegolden} 07https://github.com/crawl/crawl/pull/865 * 0.23-a0-337-g6b7c0ff: Fix attack prompts for some unrand weapons 10(8 hours ago, 3 files, 33+ 17-) 13https://github.com/crawl/crawl/commit/6b7c0ffc335e 04:37:47 03gammafunk02 {aegolden} 07https://github.com/crawl/crawl/pull/865 * 0.23-a0-338-gac077518: Fix crashes for melee attacks without a weapon 10(5 hours ago, 1 file, 4+ 4-) 13https://github.com/crawl/crawl/commit/ac077518e345 04:37:47 03gammafunk02 {aegolden} 07https://github.com/crawl/crawl/pull/865 * 0.23-a0-339-g9a4746b: New tiles for the Sceptre of Torment (CanOfWorms) 10(3 hours ago, 4 files, 2+ 1-) 13https://github.com/crawl/crawl/commit/9a4746b7f11f 04:37:47 03aegolden02 07https://github.com/crawl/crawl/pull/865 * 0.23-a0-340-gfdb5780: Hell branch ends should occur at :$ not :7. 10(28 hours ago, 4 files, 4+ 4-) 13https://github.com/crawl/crawl/commit/fdb578081a02 04:43:04 03aegolden02 07https://github.com/crawl/crawl/pull/865 * 0.23-a0-340-g3f98cd9: Hell branch ends should occur at :$ not :7. 10(28 hours ago, 4 files, 4+ 4-) 13https://github.com/crawl/crawl/commit/3f98cd9d5ad3 06:03:46 all by aegolden? 07:15:14 looks like some rebase missteps 07:32:07 Search function handles exits/gates inconsistently (in Pan) 13https://crawl.develz.org/mantis/view.php?id=11714 by TAS2012 07:37:23 pressing Enter does nothing on initialization error screen 13https://crawl.develz.org/mantis/view.php?id=11715 by TAS2012 08:40:44 Ctrl+G / auto-explore combination has inconsistent/confusing functionality (in Pan) 13https://crawl.develz.org/mantis/view.php?id=11716 by TAS2012 09:40:58 heatzeker (L17 GrMo) Crash caused by signal #11: Segmentation fault (D (Sprint)) 09:42:08 heatzeker (L17 GrMo) Crash caused by signal #11: Segmentation fault (D (Sprint)) 09:43:05 heatzeker (L17 GrMo) Crash caused by signal #11: Segmentation fault (D (Sprint)) 09:44:07 force_more_message interacts confusingly with targeting 13https://crawl.develz.org/mantis/view.php?id=11717 by TAS2012 09:45:22 heatzeker (L18 GrMo) Crash caused by signal #11: Segmentation fault (D (Sprint)) 09:54:57 !crashlog heatzeker sprint 09:54:57 8. heatzeker, XL18 GrMo, T:1709 (milestone): http://crawl.berotato.org/crawl/morgue/heatzeker/crash-heatzeker-20181018-134512.txt 09:57:58 hm, that is related to that hitfunc thing 10:15:23 !crashlog heatzeker sprint -2 10:15:24 7/8. heatzeker, XL17 GrMo, T:1590 (milestone): http://crawl.berotato.org/crawl/morgue/heatzeker/crash-heatzeker-20181018-134255.txt 10:19:02 ah 10:19:09 I'm surprised this isn't crashing more 10:20:24 ok, that ah was preemptive 10:21:22 it looks like *something* is going weird in the cast to std::function in calling stop_attack_prompt though 10:26:43 I know the chroot got updated but I wonder if this is still some c++11 versioning thing 10:37:14 garrulousMonolith (L2 FoFi) Crash caused by signal #11: Segmentation fault (D (Sprint)) 10:37:23 !crashlog 10:37:29 20278. paraanoi, XL27 VSFi, T:77947 (milestone): https://webzook.net/soup/morgue/trunk/paraanoi/crash-paraanoi-20181018-143328.txt 10:37:49 !crashlog garrulousMonolith sprint 10:37:51 1. garrulousMonolith, XL2 FoFi, T:84 (milestone): http://crawl.berotato.org/crawl/morgue/garrulousMonolith/crash-garrulousMonolith-20181018-143703.txt 10:38:03 same thing 10:38:47 wonder if this is somehow sprint specific 10:38:48 garrulousMonolith (L2 FoFi) Crash caused by signal #11: Segmentation fault (D (Sprint)) 10:38:58 my only guess right now is not to rely on std::function's implicit cast to bool? 10:40:13 03minmay02 {ebering} 07* 0.23-a0-340-gfd02fb7: Add the "transparent" tag to more vaults, eliminate some islands 10(2 days ago, 17 files, 509+ 336-) 13https://github.com/crawl/crawl/commit/fd02fb7a9ae5 10:40:13 03ebering02 07* 0.23-a0-341-g9f293ae: Return disablers to disabler_island 10(2 hours ago, 1 file, 3+ 2-) 13https://github.com/crawl/crawl/commit/9f293ae83a72 10:40:13 03ebering02 07* 0.23-a0-342-g2b29b68: Tweak nagdon_arrival_double_spiral 10(2 hours ago, 1 file, 19+ 19-) 13https://github.com/crawl/crawl/commit/2b29b687b696 10:40:13 03aegolden02 {ebering} 07* 0.23-a0-343-g69db12b: Correctly tag branch ends in Hell vaults 10(34 hours ago, 4 files, 4+ 4-) 13https://github.com/crawl/crawl/commit/69db12baef89 10:40:24 !source fight.cc:1040 10:40:24 https://github.com/crawl/crawl/blob/master/crawl-ref/source/fight.cc#L1040 11:10:44 Unstable branch on crawl.jorgrun.rocks updated to: 0.23-a0-343-g69db12baef (34) 11:18:00 Bob (L11 BaHu) Crash caused by signal #11: Segmentation fault (D:10) 11:18:34 !crash bob 11:18:37 1. Bob, XL11 BaHu, T:13600 (milestone): http://crawl.berotato.org/crawl/morgue/Bob/crash-Bob-20181018-151750.txt 11:20:57 hrm, crash with singing sword 11:21:09 Bob (L11 BaHu) Crash caused by signal #11: Segmentation fault (D:10) 11:23:09 Bob (L11 BaHu) Crash caused by signal #11: Segmentation fault (D:11) 11:24:20 well, that vulnerable pointer isn't necessary any more 11:24:31 since I removed the vulnerable function for sceptre of torment 11:24:36 but no idea why this would cause a crash 11:24:58 it should see that it's nullptr 11:25:36 advil: did you have any idea why my changes to the unrand prompting is causing this singing sword crash on cbro? 11:25:51 I see one unecessary variable that I could remove but it's not clear why there would be a crash here 11:26:16 I see that something is happening in functional.h, which seems odd 11:26:59 I'll go ahead and remove that variable at least 11:34:22 03gammafunk02 07* 0.23-a0-344-ge122d05: Remove an unused variable 10(3 minutes ago, 1 file, 1+ 2-) 13https://github.com/crawl/crawl/commit/e122d056520d 11:34:34 gonna rebuild cbro in case that will help 11:34:40 ??rebuild 11:34:40 rebuild[1/2]: http://crawl.akrasiac.org/rebuild/ http://underhound.eu:81/rebuild/ http://crawl.berotato.org/crawl/rebuild/ http://crawl.xtahua.com/rebuild/ https://crawl.jorgrun.rocks/rebuild/ Bug gammafunk, |amethyst, or Nap.Kin for CDO. Use your powers wisely. 11:44:52 Weird visual updates and redraw problems 13https://crawl.develz.org/mantis/view.php?id=11718 by kitchen_ace 11:49:48 Unstable branch on crawl.beRotato.org updated to: 0.23-a0-344-ge122d05 (34) 11:52:27 gammafunk: I'm really not sure. The crash apparently involves the validity check on the function (which isn't exactly a nullptr check, because the function pointer is wrapped in std:function) coming out true, then crashing when it tries to call the function 11:53:37 std::function allows implicit casts to bool for exactly this reason, though, so that should work 12:03:58 that is, the cast to bool (according to c++11 spec) will do a nullptr check when std::function is wrapping a pointer like that 12:10:44 Unstable branch on crawl.jorgrun.rocks updated to: 0.23-a0-344-ge122d05652 (34) 12:15:09 <|amethyst> advil: hm, I seem to remember seeing a related problem with older libstdc++ 12:15:32 yeah, I was wondering if this could be a dodgy older libstdc++ issue again 12:18:16 <|amethyst> hm, I can't find the relevant commit, but IIRC there was something where operator bool was only yielding false for an empty std::function, not one that had a null function pointer 12:18:33 ah 12:18:48 I think it is possible to explicitly check against nullptr too 12:19:22 %git 68761ecbe1e4e5b 12:19:22 07|amethyst02 * 0.17-a0-2001-g68761ec: Fix compilation on g++ 4.7 and 4.8. 10(3 years ago, 1 file, 16+ 6-) 13https://github.com/crawl/crawl/commit/68761ecbe1e4 12:19:23 ? 12:20:01 <|amethyst> I don't think it was that one 12:20:45 <|amethyst> but I can't find it now 12:45:34 |amethyst: you mentioned this bug as a gcc 4.7 issue in ##crawl-dev-20151130.lg but maybe there wasn't a specific crawl bug invoking it? 12:45:42 20:41:00 <|amethyst> in particular, it seems that initializing a std::function<> from a null function pointer (as opposed to a nullptr_t) does not mark it as empty 12:46:22 if that's right I think gammafunk's change should prevent the crash 12:51:12 and I guess if we had a problem where that function template needed to be conditionally null 12:51:27 we could probably just make a dummy function that always returned true/false (whatever the case may be) 13:07:01 -!- amalloy_ is now known as amalloy 13:13:17 gammafunk: that would have been my preference, rather than using nullptr. i wasn't sure how that would work with the default argument, though 13:18:52 Unstable branch on crawl.akrasiac.org updated to: 0.23-a0-344-ge122d05 (34) 13:21:48 amalloy: how do you mean the default argument, the default value for stop_attack_prompt of nullptr for the function template? 13:21:58 yeah 13:22:34 what would be the problem? 13:22:51 that is, if it were up to me this thing would not accept nulls of any kind and would always require a correct function pointer. but i don't think you can do that as a default argument 13:22:52 we'd just be passing a non-nullptr value every time for that code path 13:23:03 ah, yeah 13:23:19 you could require it certainly 13:23:46 but if there are use cases where we want a function that does nothing, it does sort of suggest that nullptr is the appropriate value to expect 13:23:58 either that or that hat function needs a refactoring or something 13:24:12 s/that hat/that/ 13:24:20 there are no hat functions 13:25:29 the two signatures for stop_attack_prompt are kind of different and they have some different logic; this is not really related to the current problem, but I'm not actually sure it's a good use of function signatures 13:26:17 But I'm never super clear when making two of the same functions but with different signatures is actually a good idea 14:59:59 riellis (L27 FoFi) ASSERT(foe) in 'mon-cast.cc' at line 775 failed. (Zot:2) 15:06:24 !crashlog 15:06:27 20313. CryingNoob, XL27 FeFE, T:80987 (milestone): https://webzook.net/soup/morgue/trunk/CryingNoob/crash-CryingNoob-20181018-190328.txt 15:06:37 !crashlog riellis 15:06:40 1. riellis, XL27 FoFi, T:74568 (milestone): http://crawl.berotato.org/crawl/morgue/riellis/crash-riellis-20181018-185949.txt 15:08:39 that crash is because cwz updated 15:08:50 unfortunately they updated to 333 15:08:58 the commit before the torment fix 15:09:11 oops 15:09:23 I guess they don't have a bot that reports crashes? 15:09:31 nope 15:09:44 the riellis one is a bit confusing, there also is maybe a message order problem 15:10:07 !lm * cwz current alpha x=vlong 15:10:10 The balrug stares, then turns away, jangling a coin purse. 15:10:10 A balrug comes into view. It is wielding a +2 demon whip of draining. 15:10:10 The balrug gestures at you. 15:10:24 well, I guess given the crash it's not *just* message order 15:11:34 %git 15:11:34 07gammafunk02 * 0.23-a0-344-ge122d05: Remove an unused variable 10(4 hours ago, 1 file, 1+ 2-) 13https://github.com/crawl/crawl/commit/e122d056520d 15:11:38 90s limit exceeded: killed !lm * cwz current alpha x=vlong 15:11:46 !lm * cwz current alpha x=vlong 15:12:21 odd that that query would be slow 15:12:31 yeah, milestone queries can be quite slow, even simple ones 15:12:37 seems to vary depending on what sequell is up to 15:12:53 386733. [2018-10-18 19:10:00] [vlong=0.23-a0-333-g006994f] CryingNoob the Sorcerer (L27 FeFE of Vehumet) Crash caused by signal #11: Segmentation fault (Tomb:3) 15:14:05 yep, good luck getting through tomb without crashes with that bug 16:08:41 -!- Tiobot is now known as Guest15320 18:02:17 -!- culcube is now known as phyphor 18:16:54 -!- Euph0ria is now known as TabMasher 18:21:48 Unstable branch on underhound.eu updated to: 0.23-a0-344-ge122d05652 (34) 18:27:25 foggy (L15 HOFi) ERROR in 'mon-util.cc' at line 1568: bogus mc (no monster data): invalid monster_type 1000 (1000) (Orc:2) 20:39:16 -!- amalloy is now known as amalloy_ 20:56:37 !crashlog 20:56:45 20320. foggy, XL15 HOFi, T:18616 (milestone): http://crawl.berotato.org/crawl/morgue/foggy/crash-foggy-20181018-222716.txt 20:58:28 gammafunk, do you mean lots of games gonna crash in Tomb now? 20:58:45 well only if the server hadn't updated 20:58:47 but most have 20:58:52 in fact maybe all have 20:58:58 I've heard that cwz is getting updated 20:59:13 &versions 20:59:35 commit 334 has the relevant fix I think 20:59:37 !gitgrep 2 torment 20:59:38 %git HEAD^{/torment}^^{/torment} 20:59:38 07gammafunk02 * 0.23-a0-334-g0f038ff: Fix a crash when death curses torment (geekosaur) 10(31 hours ago, 1 file, 8+ 6-) 13https://github.com/crawl/crawl/commit/0f038ff52e9e 20:59:41 CAO: 0.23-a0-344-ge122d05, CBRO: 0.23-a0-344-ge122d05, CDO: 0.23-a0-178-g440b721, CJR: 0.23-a0-344-ge122d05652, CPO: 0.23-a0-344-ge122d05, CUE: 0.23-a0-344-ge122d05652, CWZ: 0.23-a0-344-ge122d05, CXC: 0.23-a0-338-g8ff0b24, LLD: 0.23-a0-344-ge122d05652 20:59:53 looks like cwz updated just now 21:00:11 so there shouldn't be any crashes unless you don't transfer your game, Yermak 21:00:41 How old was the bug? 21:00:55 it was introduced in the previous commit 21:01:06 scepter one? 21:01:11 yes 21:01:24 commit 333 21:04:21 ok, thanks. It seems I can't abuse the bug ): 21:06:37 I should have known... 21:10:12 Ah, don't worry, it would've been very light abuse - getting Tomb:1 layout for free. 22:05:25 -!- amalloy_ is now known as amalloy 22:21:13 pan lord descriptions are kind of cool 22:21:19 I'd never really noticed them before 22:40:23 have you noticed they also match the visual appearance? 22:40:47 I submitted a PR to add more descriptions and then realised I would also have to draw a million more tile pieces :O 22:54:52 no, but I'm a console player 23:17:03 -!- culcube is now known as phyphor 23:26:26 New branch created: panlord-info (2 commits) 13https://github.com/crawl/crawl/tree/panlord-info 23:26:26 03advil02 07[panlord-info] * 0.23-a0-340-g65d806f: Show pan lord spells in xv unconditionally 10(6 hours ago, 4 files, 11+ 28-) 13https://github.com/crawl/crawl/commit/65d806fadf20 23:26:26 03advil02 07[panlord-info] * 0.23-a0-341-gb064aab: Show pan lord brand information 10(15 minutes ago, 5 files, 87+ 25-) 13https://github.com/crawl/crawl/commit/b064aab31eef