00:35:14 <dontgetcocky> There is an issue with shift+movement
00:35:37 <dontgetcocky> With the numpad it only works with numlock off, and the diagonal keys on the numpad do not work with shift+direction with numlock on or off
00:36:44 <dontgetcocky> If somebody could forward this to the devs that would be cool
00:37:33 <Kramin> I dont know if that is really a bug
00:37:54 <Kramin> without numlock the diagonal numpad keys are home/end/pgup/pgdn
00:38:19 <dontgetcocky> Well it's probably not intended. It should just work. It works with up/down/left/right as well as all of the diagonal letter-keys
00:38:44 <dontgetcocky> I'm saying it doesn't work with numpad on either
00:39:06 <Kramin> yeah maybe they can add a mapping to those keys
00:39:13 <dontgetcocky> yeah I'm thinking it was just overlooked. Maybe not a bug
00:39:23 <dontgetcocky> I don't have github or anything and have no idea how to report it
00:42:29 <geekosaur> I don't know if you need an account to file an issue on github currently. There's also mantis, but you need an account there as well (or on tavern, I think)
00:42:32 <geekosaur> ??bug
00:42:32 <Sequell> mantis[1/2]: To report bugs or submit new content like vaults, patches or tiles, go to: http://crawl.develz.org/mantis/main_page.php
00:47:01 <dontgetcocky> thanks
00:54:25 <geekosaur> one reason forlack ofmaping there is that it's proabbly hard to egt right orall combinations of {console, tiles, webtiles}
00:55:02 <geekosaur> especially console: different terminal emulators do different things with the numpad, and it occasionally gets Weird
00:55:27 <dontgetcocky> With numlock off yeah
00:55:33 <geekosaur> vt2xx "gold key" mode, etc.
00:55:59 <dontgetcocky> But with numlock on which most people have, there is no reason for the diagonal numbers to not be mapped
00:56:17 <dontgetcocky> Better than nothing
00:57:04 <geekosaur> you said with shift. that acts like numlock off, and it's precisely where terminals do weirdshit
00:57:28 <dontgetcocky> I don't know anything about that, but good point
00:57:40 <geekosaur> ESC O something instead of ESC [ soemthing, soemtimes completely different seqences with ~s in them, etc.
00:58:03 <alexjurkiewicz> non-webtiles unreasons
00:58:07 <geekosaur> I spent years fighting this kind of crap before real terminals went away, btu terminale mulators brng it all back when you start mucking with the numpad
00:58:18 -!- amalloy_ is now known as amalloy
00:58:23 <dontgetcocky> You are probably right. It's pretty hard to imagine they'd overlook this for so long without a good reason
00:58:58 <dontgetcocky> The real question is why diagonal keys are not a thing
00:59:17 <dontgetcocky> In general. There is no such thing
00:59:42 <dontgetcocky> You've got the 4 directions but no diagonal keys programmed into the OS
00:59:54 <dontgetcocky> AFAIK
01:00:28 <geekosaur> there used to be terminals with diagonal keys. vtx00 didn't have them, and that's what everyone standardized on
01:01:30 <geekosaur> ...and to be honest, back then just having everyone using the same keys and cursor movement commands was sucha  big step up that nobody worried about it
01:02:06 <alexjurkiewicz> man, diagonal keys... throwback
01:02:35 <geekosaur> "oops someoen pluged a wy50 in wherea vt100 used to be and it went into restricted mode while printing the login prompt"
01:03:34 <dontgetcocky> and even if they were a thing in the OS, keyboard have already standardized it not being a thing
01:04:11 <dontgetcocky> So I guess RIP diagonal keys
01:29:12 <dontgetcocky> Trying so hard to help this guy set macros for diagonal exploring >_>
01:30:07 <dontgetcocky> I got it to work on mine by setting the trigger key to shift+number and setting it to shift+letter
01:30:26 <alexjurkiewicz> learn vim keys :P
01:30:29 <dontgetcocky> He's saying shift doesn't even register with his numpad
01:30:54 <dontgetcocky> what does vim have to do with it?
01:31:50 <dontgetcocky> a pain in the ass?
01:32:59 <dontgetcocky> I think his keyboard is just retarded because he says with numlock off the math keys don't even register
01:44:14 <alexjurkiewicz> crawl has two sets of movement keys
01:44:33 <alexjurkiewicz> one is the numpad, the other is called "vim keys" because it's based on the keys vim uses for navigation
01:45:01 <alexjurkiewicz> hjkl = left down up right yubn = diagonals
01:45:44 <dontgetcocky> oh, yeah
01:45:48 <alexjurkiewicz> because vim keys don't use numpad, they would get around this issue
01:45:57 <dontgetcocky> That's what I was trying to do, was bind the numpad to the vim keys
01:46:07 <dontgetcocky> Which worked for me but not the other guy
01:46:21 <alexjurkiewicz> hm, well they should already be bound by default, unless you have completely replaced the default key commands
01:46:25 <dontgetcocky> yeah I know I should just learn them but numpad feels so natural
01:46:51 <dontgetcocky> they're different keys. Shift+movement does not work with them
01:47:09 <dontgetcocky> Only with numpad turned off, which then becomes the regular direction keys and still doesn't support diagonal
01:47:36 <alexjurkiewicz> sorry are you saying eg shift-h doesn't work?
01:47:47 <dontgetcocky> and he needs numpad on as well because he binds keys to "-" and stuff and for whatever reason they don't work with it off
01:48:05 <dontgetcocky> shift-h works. I'm saying shift-4 doesn't work
01:48:20 <dontgetcocky> (unless you have numpad off, but again diagonals still dont' work)
01:48:57 <alexjurkiewicz> gotcha
02:08:12 <gammafunk> ??yaml
02:08:12 <Sequell> yaml[1/1]: Servers with pyyaml installed as reported by admins: CAO, CXC, LLD, CPO, CJR
02:08:23 <gammafunk> !learn edit yaml s/$/, CUE/
02:08:23 <Sequell> yaml[1/1]: Servers with pyyaml installed as reported by admins: CAO, CXC, LLD, CPO, CJR, CUE
02:08:54 <gammafunk> just CBRO, CWZ, and CDO left
03:00:36 <buppy> I wrote you a message gammafunk but it said I need a freenode account to send pms to you
03:04:24 <gammafunk> buppy: well, you could register (it's easy to do) or you can PM me on discord
03:04:28 <gammafunk> ??roguelikes
03:04:28 <Sequell> roguelikes[1/2]: Fighting letters to collect punctuation.
03:04:36 <gammafunk> there's a link to the discord on the reddit
03:10:34 <alexjurkiewicz> !learn add discord The Reddit /r/roguelikes Discord server has a #dcss channel. You can join here: https://discord.gg/9uVbTYH
03:10:35 <Sequell> discord[3/3]: The Reddit /r/roguelikes Discord server has a #dcss channel. You can join here: https://discord.gg/9uVbTYH
03:11:27 <gammafunk> ??discord
03:11:27 <Sequell> discord[1/3]: Level 8 Hexes spell. Has a chance to cause enemies in LOS to go into {frenzy}. Checks MR. Does not work on monsters with plant int.
03:11:30 <gammafunk> ??discord[2
03:11:30 <Sequell> discord[2/3]: !lm SGrunt feck br.end=vaults 2 -tv:<0
03:11:56 <gammafunk> that's probably not going to help, that entry
03:11:56 <gammafunk> ??roguelikes[2
03:11:56 <Sequell> roguelikes[2/2]: Utter rubbish, and a waste of time.
03:11:56 <alexjurkiewicz> !learn del discord[2
03:11:57 <Sequell> Deleted discord[2/3]: !lm SGrunt feck br.end=vaults 2 -tv:<0
03:12:12 <gammafunk> why did you delete that?
03:12:22 <alexjurkiewicz> !leanr add discord !lm SGrunt feck br.end=vaults 2 -tv:<0
03:12:26 <alexjurkiewicz> oops
03:12:29 <alexjurkiewicz> !learn add discord !lm SGrunt feck br.end=vaults 2 -tv:<0
03:12:30 <Sequell> discord[3/3]: !lm SGrunt feck br.end=vaults 2 -tv:<0
03:12:36 <gammafunk> that's not the way you want to set this up
03:13:00 <gammafunk> !learn swap discord[2] discord[3]
03:13:00 <Sequell> Swapped discord[2] with discord[3].
03:13:06 <gammafunk> ??discord[3
03:13:06 <Sequell> discord[3/3]: The Reddit /r/roguelikes Discord server has a #dcss channel. You can join here: https://discord.gg/9uVbTYH
03:13:17 <gammafunk> !learn mv discord[3] roguelikes_discord
03:13:18 <Sequell> discord[3] -> roguelikes discord[1/1]: The Reddit /r/roguelikes Discord server has a #dcss channel. You can join here: https://discord.gg/9uVbTYH
03:13:20 <gammafunk> ??discord
03:13:20 <Sequell> discord[1/2]: Level 8 Hexes spell. Has a chance to cause enemies in LOS to go into {frenzy}. Checks MR. Does not work on monsters with plant int.
03:14:08 <gammafunk> !learn edit discord[1] s/$/ See {roguelikes discord} if you want the roguelikes discord chat server./
03:14:09 <Sequell> discord[1/2]: Level 8 Hexes spell. Has a chance to cause enemies in LOS to go into {frenzy}. Checks MR. Does not work on monsters with plant int. See {roguelikes discord} if you want the roguelikes discord chat server.
03:17:32 <gammafunk> !learn add roguelikes see {roguelikes discord}
03:17:33 <Sequell> roguelikes[3/3]: see {roguelikes discord}
04:24:32 -!- amalloy is now known as amalloy_
06:57:28 <hayenne> hey guys, do you think it might be better to compact amulet of reflection stats to a single line? ("It shields you (SH +2) and reflects attacks.")
07:20:57 <alexjurkiewicz> i believe the relevant code to display that stuff is in describe.cc
07:21:14 <alexjurkiewicz> you might want to look at how the code is structured to see if that change would be easy
07:22:04 <alexjurkiewicz> I think if every source of reflection also provided +SH, it would be a reasonable change. But you might need to leave some code behind so that objects with Reflect but no +SH still describe properly
07:41:02 <ebering> if I remember right there's some oddness with how reflect is implemented as an artp so the brooch of shielding and other artefacts behave correctly
07:41:33 <ebering> in particular, reflect and +SH are separate properties
07:42:05 <ebering> so making the amulet of reflection's description consise would require a special case in the code, not just a textfile tweak
07:47:23 <alexjurkiewicz> !tell Napkin can you please delete the DNS record for scoreboard.crawl.develz.org
07:47:23 <Sequell> alexjurkiewicz: OK, I'll let napkin know.
07:51:02 <Cheibriados> Closing a door with a large skeleton in the way produces the same message as with a living creature 13https://crawl.develz.org/mantis/view.php?id=11694 by hayenne
07:52:10 <hayenne> thanks ebering
07:52:20 <hayenne> and alexjurkiewicz :)
07:52:57 <hayenne> also, 0.23 is still laid down as long-term development on Mantis
08:01:47 <Cheibriados> 03ebering02 07https://github.com/crawl/crawl/pull/768 * 0.23-a0-209-g3f5feba: Remove an unused include 10(4 months ago, 1 file, 0+ 1-) 13https://github.com/crawl/crawl/commit/3f5febab18e3
08:01:47 <Cheibriados> 03ebering02 07https://github.com/crawl/crawl/pull/768 * 0.23-a0-210-g61a8160: Have butchering always leave a skeleton. 10(4 months ago, 3 files, 11+ 21-) 13https://github.com/crawl/crawl/commit/61a8160c73b7
08:01:47 <Cheibriados> 03ebering02 07https://github.com/crawl/crawl/pull/781 * 0.23-a0-209-gb9ec7f8: Don't accept elemental colours by default (11468) 10(4 months ago, 6 files, 13+ 13-) 13https://github.com/crawl/crawl/commit/b9ec7f8dd253
08:07:03 <Cheibriados> 03ebering02 07https://github.com/crawl/crawl/pull/808 * 0.23-a0-209-g2b3084f: Attempt God conversions on sight. 10(3 months ago, 4 files, 20+ 4-) 13https://github.com/crawl/crawl/commit/2b3084f5b632
08:07:03 <Cheibriados> 03ebering02 07https://github.com/crawl/crawl/pull/808 * 0.23-a0-210-gbbc11d4: Simplify Beogh conversion rules 10(9 weeks ago, 2 files, 1+ 13-) 13https://github.com/crawl/crawl/commit/bbc11d489c06
08:12:20 <Cheibriados> 03ebering02 07https://github.com/crawl/crawl/pull/828 * 0.23-a0-209-g544e9b4: Allow SH specification for unrands. 10(9 weeks ago, 1 file, 2+ 1-) 13https://github.com/crawl/crawl/commit/544e9b4f8362
08:12:20 <Cheibriados> 03ebering02 07https://github.com/crawl/crawl/pull/828 * 0.23-a0-210-gcac1551: Allow tweaking more artps in wizmode 10(9 weeks ago, 1 file, 11+ 7-) 13https://github.com/crawl/crawl/commit/cac1551bf2aa
08:12:20 <Cheibriados> 03ebering02 07https://github.com/crawl/crawl/pull/828 * 0.23-a0-211-gf183d48: Revise Morg (mikee) 10(9 weeks ago, 4 files, 16+ 6-) 13https://github.com/crawl/crawl/commit/f183d48f0cf8
08:12:20 <Cheibriados> 03ebering02 07https://github.com/crawl/crawl/pull/828 * 0.23-a0-212-gdbde09c: Revise the Spriggan's Knife (mikee) 10(9 weeks ago, 3 files, 12+ 6-) 13https://github.com/crawl/crawl/commit/dbde09cf611a
08:12:20 <Cheibriados> 03ebering02 07https://github.com/crawl/crawl/pull/828 * 0.23-a0-213-gc26b62f: Revise the Singing Sword 10(9 weeks ago, 2 files, 32+ 24-) 13https://github.com/crawl/crawl/commit/c26b62f4f851
08:14:40 <ebering> I've rebased all of my outstanding pull requests for 0.23
08:17:35 <Cheibriados> 03ebering02 07https://github.com/crawl/crawl/pull/805 * 0.23-a0-209-gf7b432b: Add elemental colour support to the equip bar 10(3 months ago, 4 files, 13+ 6-) 13https://github.com/crawl/crawl/commit/f7b432b09811
08:18:19 <ebering> I talked with |amethyst about 768 and 781 when I made them who seemed on board so those two should be ready to go
08:18:48 <ebering> 808 could use a look because it puts this annoying minigame into playing gozag and beogh
08:19:02 <ebering> and I know gammafunk is already looking at 828 (or planning to for 0.23)
08:26:30 <gammafunk> ebering: yeah for 828, I'm implementing it in a completely different way, using los damage spells (and am rewriting part of los damage spell code too)
08:27:08 <gammafunk> for Morg, I'm considering either sometimes generating death scarabs or miasma (along with the usual pain); not sure which of those I like more
08:27:29 <gammafunk> for spriggan's knife your PR is the best plan we have so far, so that one I might merge
08:28:13 <gammafunk> some of those other commits in 828 might be good to merge
08:28:57 <gammafunk> the other PRs are probably good (768 and 781) but I'll have to get to those after the unrand PRs are done
08:30:59 <gammafunk> and if anyone else wants to look at 768 or 781 feel free, of course
09:02:24 <Napkin> gammafunk: python-yaml was already install on cdo, additionally added python3-yaml
09:02:24 <Sequell> Napkin: You have 16 messages. Use !messages to read them.
09:08:43 <hayenne> Guys, I am unsure whether this is an intended behaviour, I always thought Crawl doors are made of wood, yet the explosion message is the same as for rock (The door shatters! The blast of rock fragments hits the deep elf knight.)
09:09:21 <hayenne> on the other hand doors can be made of stone. wondering if it is the intended case
09:11:13 <hayenne> oh wait. the description does say it's wooden
09:15:23 <Cheibriados> Wooden door explosion message is the same as rock explosion 13https://crawl.develz.org/mantis/view.php?id=11695 by hayenne
09:20:20 <gammafunk> Napkin: great, thanks
09:20:22 <gammafunk> ??yaml
09:20:22 <Sequell> yaml[1/1]: Servers with pyyaml installed as reported by admins: CAO, CXC, LLD, CPO, CJR, CUE
09:20:54 <gammafunk> !learn edit yaml s/$/, CDO/
09:20:54 <Sequell> yaml[1/1]: Servers with pyyaml installed as reported by admins: CAO, CXC, LLD, CPO, CJR, CUE, CDO
09:21:17 <gammafunk> if we get CBRO I imagine we can go from there since CWZ has to merge manually anyhow
09:57:08 <Gretell> Karagy (L11 MuWz) Crash caused by signal #6: Aborted (Orc:1)
09:57:29 <Gretell> Karagy (L11 MuWz) Crash caused by signal #6: Aborted (Orc:1)
11:02:35 <gammafunk> Napkin: Seems CDO webpages are down, doing some maintenance?
11:02:52 <Napkin> what?
11:03:18 <gammafunk> tavern giving SQL errors
11:03:34 <gammafunk> and so is the wordpress site
11:04:10 <Napkin> worse..
11:12:53 <Napkin> well, that wasn't so healthy for mysqld
11:12:59 <Napkin> disk full :-$
11:16:12 <gammafunk> dang, rip
11:17:03 <Napkin> nah, it managed to repair itself
11:24:02 <Napkin> thank you for pinging me, gammafunk :-)
11:27:08 <Cheibriados> 03floraline02 07* 0.22-a0-461-g4c2974a: Added Forgot Password link to allow users to request an email to reset their password. This is the first half of this implementation, still needs email config and reset link. 10(4 months ago, 5 files, 121+ 0-) 13https://github.com/crawl/crawl/commit/4c2974a1c635
11:27:08 <Cheibriados> 03floraline02 07* 0.22-a0-462-g552bd0d: Adds config values for password reset feature. Admin can turn this feature on or off, SMTP config is required for this to be used. 10(4 months ago, 4 files, 25+ 8-) 13https://github.com/crawl/crawl/commit/552bd0d42d6b
11:27:08 <Cheibriados> 03floraline02 07* 0.22-a0-463-g98963a9: Adds password reset token which allows a user to enter a new password for their account. The password reset email will now include this token. This commit adds another required config item for the password reset feature. 10(4 months ago, 7 files, 165+ 15-) 13https://github.com/crawl/crawl/commit/98963a99e527
11:27:08 <Cheibriados> 03floraline02 07* 0.22-a0-464-gc2a7574: Adds DB changes required for password reset feature 10(4 months ago, 2 files, 4+ 1-) 13https://github.com/crawl/crawl/commit/c2a757475273
11:27:08 <Cheibriados> 03floraline02 07* 0.22-a0-471-gb7c2d6f: Merged master into working branch 10(4 months ago, 0 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/b7c2d6f06842
11:27:08 <Cheibriados> 03floraline02 07* 0.22-a0-472-gcd0a981: Use CSPRNG urandom to generate the password reset token 10(4 months ago, 1 file, 10+ 1-) 13https://github.com/crawl/crawl/commit/cd0a9817aaf3
11:27:08 <Cheibriados> 03floraline02 07* 0.22-a0-473-gfe6c23a: Enhance emails sent for password recovery 10(4 months ago, 1 file, 43+ 12-) 13https://github.com/crawl/crawl/commit/fe6c23a32d19
11:27:08 <Cheibriados> 03floraline02 07* 0.22-a0-474-gdf0964f: Move boilerplate SMTP code into helper function 10(4 months ago, 2 files, 47+ 32-) 13https://github.com/crawl/crawl/commit/df0964f77a37
11:27:08 <Cheibriados> 03floraline02 07* 0.22-a0-475-gd338dc9: Hide recovery dialog if recovery is not enabled 10(4 months ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/d338dc9835d7
11:27:08 <Cheibriados> 03floraline02 07* 0.22-a0-476-g06be723: Automatically upgrade user db on startup 10(4 months ago, 2 files, 21+ 0-) 13https://github.com/crawl/crawl/commit/06be723832eb
11:27:08 <Cheibriados> ... and 16 more commits
11:27:20 <gammafunk> np Napkin, and thanks for fixing
12:10:51 <Jorgrell> Unstable branch on crawl.jorgrun.rocks updated to: 0.23-a0-234-gdb1f849363 (34)
13:02:12 -!- amalloy_ is now known as amalloy
13:05:23 <Henzell> Unstable branch on crawl.akrasiac.org updated to: 0.23-a0-234-gdb1f849 (34)
13:31:57 <gammafunk> advil: oh nice, you merged the password reset
13:32:08 <gammafunk> for some reason I thought the PR was just updated
13:40:33 <Ge0ff> It looks like there's a problem with WebTiles on CAO & CJR. I get "500: Internal Server Error" on the lobby page and if I try to spectate any game
13:41:45 <advil> well, that's almost certainly my fault
13:41:45 <Sequell> advil: You have 3 messages. Use !messages to read them.
13:41:52 <gammafunk> oops
13:42:17 <gammafunk> hrm, may be hard to diagnose if we can't see the webtiles errors
13:43:57 <advil> I guess I'll try selectively reverting some things
13:44:31 <advil> oh, I have an idea about what it could be
13:44:41 <advil> it might be because they haven't restarted the servers
13:48:27 <Cheibriados> 03advil02 07* 0.23-a0-235-gf47f433: Temporarily revert html side of forget password commits 10(73 seconds ago, 1 file, 0+ 50-) 13https://github.com/crawl/crawl/commit/f47f43309fcf
13:48:44 <advil> ??rebuild
13:48:44 <Sequell> rebuild[1/2]: http://crawl.akrasiac.org/rebuild/ http://underhound.eu:81/rebuild/ http://crawl.berotato.org/crawl/rebuild/ http://crawl.xtahua.com/rebuild/ https://crawl.jorgrun.rocks/rebuild/ Bug |amethyst or Nap.Kin for CDO. Use your powers wisely.
13:49:09 <gammafunk> I think cjr rebuild might not work
13:49:15 <advil> yeah, but it updates quickly
13:49:16 <gammafunk> but it rebuilds hourly, at least
13:49:24 <advil> this way I can at least see if that's the issue
13:50:03 <advil> the code in the template will probably crash if the server hasn't restarted to get some config-related code and it is used dynamically
13:50:10 <advil> is my theory
13:50:46 <gammafunk> looking at that code, it might be able to do e.g. config.get("allow_password_reset", False) instead
13:51:19 <gammafunk> so that it won't raise an exception when the config variable isn't defined
13:51:54 <Henzell> Unstable branch on crawl.akrasiac.org updated to: 0.23-a0-235-gf47f433 (34)
13:52:49 <gammafunk> CAO is back up, so that's good
13:53:58 <advil> that's the kind of thing that we *should* have, but are you sure that would work?
13:54:33 <advil> I was think of checking dir for the module, but I'm in a meeting now so can't do much on it right away
13:57:18 <gammafunk> ah, right, webtiles loads the data right into the module as a variable
13:59:11 <gammafunk> usually this would be in an object that had a dict interface, which I think webtiles-changes does as well
13:59:11 <advil> yeah
13:59:11 <gammafunk> but I guess we'd have to use something like dir
13:59:31 <advil> I worked around it specifically for this value, but you'd need to restart the server for the workaround to take effect
14:10:39 <Jorgrell> Unstable branch on crawl.jorgrun.rocks updated to: 0.23-a0-235-gf47f43309f (34)
14:20:32 <floraline> i'm seeing this on my server now
14:23:12 <floraline> if config.allow_password_reset:  # client.html:30
14:23:13 <floraline> AttributeError: 'module' object has no attribute 'allow_password_reset'
14:26:23 <floraline> webtiles restart is also failing
14:27:16 <amalloy> floraline: in the backlog, advil says "the code in the template will probably crash if the server hasn't restarted to get some config-related code and it is used dynamically". he also pushed https://github.com/crawl/crawl/commit/f47f43309fcf which is supposed to disable this feature - try rebuilding with that commit?
14:28:06 <advil> hm, what is happening when you restart?
14:28:56 <floraline> Sep 25 14:24:38 crawl.kelbi.org webtiles[4275]: ImportError: cannot import name lobby_url
14:28:57 <floraline> Sep 25 14:24:38 crawl.kelbi.org webtiles[4275]:   File "/home/crawl/DGL/crawl-master/webserver/userdb.py", line 11, in <module>
14:29:25 <advil> is there another line?
14:29:34 <floraline> Sep 25 14:24:38 crawl.kelbi.org webtiles[4275]:     from config import (max_passwd_length, nick_regex, password_db,
14:29:45 <floraline> sorry there are a lot of lines i'm not sure how to paste it here properly
14:29:49 <floraline> i think that's the relevant line
14:29:59 <floraline> userdb.py is trying to import some thing from config file which is not defined
14:30:01 <advil> yeah, that's usually caused by a recursive import
14:30:10 <floraline> oh ok
14:31:14 <floraline> i defined lobby_url = None in my config.py and the server can now start
14:31:43 <floraline> and now that it's restarted i'm not seeing the 500 error either
14:31:56 <advil> ah good
14:32:10 <advil> do you remember if you added lobby_url as a parameter? I thought it was already there but didn't check
14:32:30 <floraline> a parameter for what?
14:33:03 <advil> config...looks like you did add it, so I'll need to make a change for that too
14:33:41 <floraline> oh yes it's in there after allow_password_reset and before the smtp settings
14:34:04 <advil> basically the way config.py works is really dumb and makes it hard to add new config parameters
14:34:11 <advil> %git 33f0de1038b87b5ab
14:34:11 <Cheibriados> 07advil02 * 0.23-a0-208-g33f0de1: Handle the case where config.py lacks allow_password_reset 10(3 hours ago, 2 files, 18+ 4-) 13https://github.com/crawl/crawl/commit/33f0de1038b8
14:34:23 <advil> I tried to deal with it in that commit but didn't ake enough into account
14:34:39 <floraline> oh i see
14:36:06 <floraline> lobby_url is referenced in server.py line 211 and userdb.py line 11 in the import statement
14:37:23 <advil> those all look ok except for the import
14:46:38 <advil> in that they're already conditionalized with allow_password_reset()
14:47:09 <floraline> right the other one should only be a problem if you turned this thing on already
14:47:18 <floraline> in which case you should have the proper config already set
14:47:44 <floraline> what's the right thing to do for that import besides changing it to a generic "import config"?
14:48:22 <advil> that's what I did -- annoyingly, it seems that this code partly uses explicit imports from config to validate config
14:48:49 <advil> I'd rather it be using config.x for any config parameter, but then you don't get validation until it hits that code
14:49:17 <advil> but this one you already are validating elsewhere so it makes sense to just use config.lobby_url
14:49:58 <floraline> but we can't change it to config.lobby_url without changing the other five options in that whole document
14:50:27 <advil> oh, I just mixed the two styles
14:50:31 <advil> they're compatible
14:51:09 <advil> (actually first I did change them all, then realized why someone had done it that way, and went back)
14:51:54 <floraline> are you talking about server.py or userdb.py?
14:51:54 <advil> userdb.py
14:58:40 <advil> aha!
14:58:51 <advil> getattr works on modules like gammafunk wanted get to
14:59:14 <advil> there's also hasattr
15:18:03 <Cheibriados> 03advil02 07* 0.23-a0-236-g5abb548: Handle config.pys that lack lobby_url 10(32 minutes ago, 1 file, 5+ 5-) 13https://github.com/crawl/crawl/commit/5abb54889cc5
15:18:03 <Cheibriados> 03advil02 07* 0.23-a0-237-g8cfa994: Revert "Temporarily revert html side of forget password commits" 10(30 minutes ago, 1 file, 50+ 0-) 13https://github.com/crawl/crawl/commit/8cfa994ab4d8
15:18:03 <Cheibriados> 03advil02 07* 0.23-a0-238-g34886a9: Fix client.html 10(16 minutes ago, 1 file, 3+ 3-) 13https://github.com/crawl/crawl/commit/34886a98812a
15:18:03 <Cheibriados> 03advil02 07* 0.23-a0-239-g84a5ed2: Replace hacky allow_password_reset() with getattr calls 10(5 minutes ago, 3 files, 20+ 16-) 13https://github.com/crawl/crawl/commit/84a5ed292d52
15:19:12 <advil> those should fix every issue that I know about
15:21:18 <advil> I also started a rebuild on CAO (which should immediately trigger any issues, I think it just needs the git pull for client.html to be used) and no more internal server errors
15:23:10 <Henzell> Unstable branch on crawl.akrasiac.org updated to: 0.23-a0-239-g84a5ed2 (34)
15:26:17 <advil> floraline ^, also thanks for your help
15:32:57 <floraline> thank you, i'm happy this was finally able to be merged
15:33:13 <floraline> hopefully this will allow server admins to not have to manually intervene on every password request
15:33:32 <floraline> i'm rebuilding now
16:10:57 <Jorgrell> Unstable branch on crawl.jorgrun.rocks updated to: 0.23-a0-239-g84a5ed292d (34)
16:26:45 <floraline> advil: i have synced up with your latest changes and successfully tested password reset on my server, thanks for the fixes!
16:27:04 <advil> ok great, thanks for the update!
17:48:02 <floraline> is dgl remove-trunks supposed to remove the cached source folders under crawl-build?
18:22:06 <Lantell> Unstable branch on underhound.eu updated to: 0.23-a0-239-g84a5ed292d (34)
19:23:34 <alexjurkiewicz> as a server admin who recently did a bunch of manual password resets, colour me happy
19:23:39 <alexjurkiewicz> I will try and port to webtiles-changes
19:29:33 <floraline> cool :) i hope you are able to use it
19:29:53 <floraline> i started working on this after i needed my password reset and had to bother somebody to do it for me
19:36:34 <aidanh> floraline: glad to see password resets merged! sorry I never got around to that review I promised :(
19:38:59 <floraline> not a problem, i'm just glad it was worth merging
19:39:53 <floraline> it's all about saving admins time
20:57:03 -!- amalloy is now known as amalloy_
23:14:55 <Cheibriados> 03CanOfWorms02 {GitHub} 07* 0.23-a0-240-g563e2a7: Update Dithmenos's power description (Angani) 10(14 seconds ago, 1 file, 4+ 5-) 13https://github.com/crawl/crawl/commit/563e2a740691
23:24:02 <Cheibriados> 03CanOfWorms02 {GitHub} 07* 0.23-a0-241-g3b46b07: Remove a runed door subvault from the_grid 10(14 seconds ago, 1 file, 0+ 11-) 13https://github.com/crawl/crawl/commit/3b46b076a4cb
23:31:11 -!- amalloy_ is now known as amalloy
23:31:30 <minmay> oh god thank you
23:59:41 <Eksell> Unstable branch on CRAWL.XTAHUA.COM updated to: 0.23-a0-241-g3b46b07 (34)