00:13:24 noooo 00:14:47 Unstable branch on CRAWL.XTAHUA.COM updated to: 0.22-a0-803-gd6d8abe (34) 01:04:45 03Aidan Holm02 07* 0.22-a0-804-ge82d12a: Fix webtiles menu always handling scroll keys 10(23 hours ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/e82d12a2c277 01:04:45 03Aidan Holm02 07* 0.22-a0-805-ga2e7eb6: Fix incorrect JS event propagation handling 10(13 hours ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/a2e7eb6d91b0 01:04:45 03Aidan Holm02 07* 0.22-a0-806-gfba9ade: Improve webtiles scroller line-height detection 10(52 minutes ago, 3 files, 8+ 8-) 13https://github.com/crawl/crawl/commit/fba9adeb1935 01:04:45 03Aidan Holm02 07* 0.22-a0-807-g6ffe099: Add server -> client scroller synchronization 10(40 minutes ago, 2 files, 61+ 31-) 13https://github.com/crawl/crawl/commit/6ffe099ff9f3 01:04:45 03Aidan Holm02 07* 0.22-a0-808-g7fc7157: Add webtiles client-side scrolling 10(30 minutes ago, 1 file, 117+ 10-) 13https://github.com/crawl/crawl/commit/7fc7157da69e 01:06:49 gammafunk: that _should_ fix the scrolling issues, but I haven't actually tested console-->webtiles scroller synchronization 01:08:44 I can test it myself in a sec 01:12:58 aidanh: I can scroll in x-v properly now at least 01:13:12 I'd need to make a full on local dgl setup to test console->webtiles sync 01:13:56 aidanh: I've noticed that when viewing text UI in console, it seems to show nothing in webtiles; this is something that happened before your UI changes 01:15:40 You can see it happening here when I go into a subsection of the manual: https://youtu.be/50l1ueKG7Xw?list=PLFA1TrTf1UtX2GpP-JBHBjbEthgq_aHEa&t=114 01:16:18 it just shows rows of "..." ellipses in the webtiles view 01:16:23 but my console display is fine 01:16:40 I should get a proper local dgl setup so I can set this stuff more easilly 01:17:00 maybe I can just set it up on my build server if it doesn't take too much disk space 01:17:10 actually I think it would since I'd need the chroot, I guess 01:18:02 oh maybe that commit 0.22-a0-807-g6ffe099 is fixing the exact issue I'm talking about 01:18:37 thankfully I was yet again lazy about streaming, and I'm super planning (for real) to stream tomorrow (I hope) 01:18:51 so maybe I'll get to test all this and will be on the lookout for any bugs 01:26:23 gammafunk: the ... lines are placeholders from the old menu implementation; it loaded menu data in chunks 01:26:51 I replaced most of that implementation though 01:27:02 ok, great 01:27:28 I'll have to remember to peek over at the webtiles output every now and again my next stream to see if there's any weird sync problems 01:27:33 Unstable branch on crawl.develz.org updated to: 0.22-a0-808-g7fc7157 (34) 01:28:07 thanks as always to you and advil for all of these various fixes 01:29:28 when you stream, you play console and spectate yourself with webtiles, yeah? 01:29:56 %git 01:29:56 07Aidan Holm02 * 0.22-a0-808-g7fc7157: Add webtiles client-side scrolling 10(55 minutes ago, 1 file, 117+ 10-) 13https://github.com/crawl/crawl/commit/7fc7157da69e 01:31:44 yeah 01:32:05 I play console, spectate myself twice, one for obs capture, one to just have in the background 01:32:24 then I do an obs capture of the los area of the terminal where I play so people can see that in the upper-right 01:35:28 gotcha 01:57:21 Windows builds of master branch on crawl.develz.org updated to: 0.22-a0-808-g7fc7157 02:08:12 03Aidan Holm02 07* 0.22-a0-809-gcdea453: Revert "Remove most remaining CRT control code" 10(11 minutes ago, 15 files, 92+ 14-) 13https://github.com/crawl/crawl/commit/cdea45354bec 02:09:24 aidanh may be the new king of self-reverts 02:09:40 goodbye, Yak the Skirmisher :/ 02:09:52 rip advil's favorite new feature 02:10:05 yeah, you'll have to deduct 2*#reverts from my commit total 02:10:16 Unstable branch on crawl.jorgrun.rocks updated to: 0.22-a0-808-g7fc7157da6 (34) 02:10:47 unfortunately haven't had nearly enough free time this week, hence all the frantic (and somewhat sloppy) fixes 02:11:28 well we still have some weeks before release at least, so it's all good 02:56:02 -!- Euph0ria is now known as TabMasher 02:58:35 Monster database of master branch on crawl.develz.org updated to: 0.22-a0-809-gcdea453 03:06:37 Inventory scrolling speed is now hyper-sensitive or somehow difficult to control 13https://crawl.develz.org/mantis/view.php?id=11550 by stoneychips 03:10:13 Unstable branch on crawl.jorgrun.rocks updated to: 0.22-a0-809-gcdea45354b (34) 03:23:45 Unstable branch on crawl.beRotato.org updated to: 0.22-a0-809-gcdea453 (34) 03:25:39 yak the skirmisher? 03:56:22 ProzacElf: https://crawl.develz.org/mantis/view.php?id=11544 04:06:52 -!- amalloy is now known as amalloy_ 04:10:08 the Yak is back 05:01:31 Heads up on the AM build in trunk (v22 latest) . It’s virtually unplayable. The UI for the inventory, you cannot scroll with keyboard or mouse cause the highlight appears to disappear. I’m on a PC playing tiles. 05:02:09 gammafunk: or other dev ^. CBRO. 05:03:01 So you can’t see your inventory. 05:15:44 !lm robotcentaur x=src 05:15:45 2654. [2018-07-22 00:53:37] [src=cbro] robotcentaur the Eclecticist (L21 GnWn of Vehumet) left the Elven Halls on turn 55000. (Elf:1) 05:15:51 &version cbro trunk 05:15:56 cbro trunk: 0.22-a0-809-gcdea453 05:15:58 !lm robotcentaur x=src,vlong 05:15:59 2654. [2018-07-22 00:53:37] [src=cbro;vlong=0.22-a0-800-g058c00f] robotcentaur the Eclecticist (L21 GnWn of Vehumet) left the Elven Halls on turn 55000. (Elf:1) 05:16:03 %git 05:16:03 07Aidan Holm02 * 0.22-a0-809-gcdea453: Revert "Remove most remaining CRT control code" 10(3 hours ago, 15 files, 92+ 14-) 13https://github.com/crawl/crawl/commit/cdea45354bec 05:16:25 robotcentaur: your last milestone shows you have a version before 9 or so bugfix commits aidanh just made 05:16:45 looks like cbro is rebuilt, so if you transfer your current game when you resume your save, hopefully that will fix things 05:17:46 oh 05:17:57 looks like there are indeed some scrolling problems 05:18:54 Inventory not scrollable 13https://crawl.develz.org/mantis/view.php?id=11551 by robotcentaur 05:18:58 %git 05:18:58 07Aidan Holm02 * 0.22-a0-809-gcdea453: Revert "Remove most remaining CRT control code" 10(3 hours ago, 15 files, 92+ 14-) 13https://github.com/crawl/crawl/commit/cdea45354bec 05:19:45 !tell aidanh I just loaded up latest trunk webtiles in cbro and it appears inventory scrolling is broken; it automatically scrolls back up if you use any form of scrolling (also reported in bug 11551) 05:19:45 gammafunk: OK, I'll let aidanh know. 05:20:04 aw man 05:20:04 aidanh: You have 1 message. Use !messages to read it. 05:20:29 ok , I'll have time to fix that in a few hours, if noone gets there first 05:20:59 Also, must say, you all support this game better than any other game I have played or worked on. Much appreciated! 05:21:28 Night and day. Best community and devs. 05:23:13 ah, I know what the bug is, but im out now and can't fix it 05:24:24 if anyone else wants to, recv_ui_scroll() in ui-layouts.js needs an early return for menus, like it has for formatted scrollers 05:24:37 I'll see what I can do 05:30:16 aidanh: something like if (!menu) return; 05:30:24 but added into that condition? 05:30:32 I'm not sure how one checks for a menu 05:30:52 looks like that's the case 05:31:35 if (!$popup.hasClass("menu")) return; I believe 05:31:50 cool, I'll try that 05:37:02 ok scrolling seems to work with that change, but let me try with it stashed to make sure I'me even seeing the problem 05:39:17 looks good 05:42:43 Should I be seeing the fix ? 05:43:05 Or is it building? 05:44:45 gammafunk: ? 05:46:36 Cause it’s still wonky in my end. I can test when you tell me to. 05:48:36 03gammafunk02 07* 0.22-a0-810-g93d1441: Hopefully fix menu scrolling in WebTiles (aidanh, robotcentaur, 11551) 10(9 minutes ago, 1 file, 4+ 1-) 13https://github.com/crawl/crawl/commit/93d14410fa19 05:49:02 robotcentaur: you'll need to wait for cbro to rebuild, which can take like 20 minutes 05:49:11 since I'm just starting one 05:49:20 I've tested it locally so it should work 05:49:53 Cool. Figured it would take a rebuild after your commit / fix. Thanks! 05:51:16 after that commit I'm going to put "Javascript and UI expert" on my resume 05:51:31 the proof is in the pudding, I fixed a critical bug 06:01:41 Nice! And add “Supported Live game with hot fixes and patches” ! 06:02:28 Unstable branch on crawl.beRotato.org updated to: 0.22-a0-810-g93d1441 (34) 06:02:57 robotcentaur: cbro just finished rebuild, so you can try 06:03:21 robotcentaur: you probably want ot make sure you reload the page so that you see the new javascript ifles 06:03:24 *files 06:03:47 not sure how browsers handle caching of those these days 06:04:20 Yup, that works perfect. Nice! 06:05:33 03gammafunk02 07* 0.22-a0-811-gbf23809: Adjust Harold's attack, armour, spells, and depth (mikee) 10(2 days ago, 4 files, 5+ 9-) 13https://github.com/crawl/crawl/commit/bf238096ae25 06:06:02 gammafunk: F5 always refresh. Good work. 06:06:27 well thanks to aidanh for telling me what to fix 06:06:40 oh and thanks for reporting so we could fix 06:07:42 No worries! Playing games and breaking things is what I do. Good community. Looking forward to your next stream on Twitch. 06:10:12 Unstable branch on crawl.jorgrun.rocks updated to: 0.22-a0-810-g93d14410fa (34) 07:10:10 Unstable branch on crawl.jorgrun.rocks updated to: 0.22-a0-811-gbf238096ae (34) 08:44:28 The last screen after death (local high scores) doesn't show up 13https://crawl.develz.org/mantis/view.php?id=11552 by Leszczynek 09:29:55 !rc Anglot 09:29:56 http://crawl.akrasiac.org/rcfiles/crawl-git/Anglot.rc 09:30:44 &rc anglot 09:30:45 No milestones for anglot. 09:33:03 I can't reproduce the crash in https://crawl.develz.org/mantis/view.php?id=11549; does the "clua stack" indicate that their rc lua might be responsible? 09:42:44 nvm, valgrind is showing a use-after-free, so that's probably it 11:56:39 aidanh: I think Gorice has figured out that bug in https://crawl.develz.org/mantis/view.php?id=11527&nbn=1#bugnotes 11:57:15 it's yet more issues with SkillMenu's way of not using standard c++ design 11:58:00 I don't replicate the crash either, but from fixing the other related bugs with that same code the other day, this sounds totally plausible 11:59:24 I had a version of it that actually used the constructor and would've avoided this problem (by accident), but I think it probably messed up the standard menu memory management stuff 12:31:15 03advil02 07* 0.22-a0-812-g4c1e2d5: Fix further issues with extra init/exits in SkillMenu (Gorice) 10(3 minutes ago, 2 files, 27+ 14-) 13https://github.com/crawl/crawl/commit/4c1e2d547123 12:47:54 aidanh: idea, what about adding a name field to Widget and providing an informative name to menus that can then be exported to clua? It would be super useful to find out where in the UI you are for lua scripts that send keys, and this seems like an easy addition now 12:49:26 I have a specific application in mind (working on some unit tests for the skill menu), but probably useful for all sorts of unit tests, bots 12:51:15 advil: there is some existing functionality for this 12:51:18 http://csclub.uwaterloo.ca/~ebering/crawl/lua/modules/Hooks.html 12:51:37 oh, I see a typo in my ldoc 12:52:00 right, but there's no way to find out what the current ui is actually showing 12:52:01 but, stat gain, prompts, and targeters work via callback hooks 12:52:04 yes 12:52:05 auto_experience is an attempt to work around that 12:52:10 I'm not talking about callbacks 12:52:37 a lot of scripts just send keystrokes, which is extremely brittle, because it's generally hard to figure out what input crawl is expecting 12:52:44 most of the stress tests for example 12:52:48 oh I see 12:53:08 something where you could say call ui.currentmenu() and get a string name or even a metatable for interaction 12:53:11 qw also uses a lot of key stuff, I think 12:53:13 yeah 12:54:20 of course it's even better if you can do everything with lua code rather than keystrokes, but even then some ui info will be useful 12:54:22 skill menu is particularly relevant because there are game states where you can't exit it, that's probably why someone wrote auto_experience 12:58:25 actually, even if there were enough callbacks (which we want), it'd still be helpful for writing tests for ui things 13:02:37 even just exporting the UI depth (which is easy in the new framework) will be pretty informative 13:10:17 Unstable branch on crawl.jorgrun.rocks updated to: 0.22-a0-812-g4c1e2d5471 (34) 13:16:11 Unstable branch on crawl.akrasiac.org updated to: 0.22-a0-812-g4c1e2d5 (34) 14:00:48 although I may have yet again misunderstood control flow with crawl.sendkeys 14:22:33 Segfault when hitting escape after viewing help from menu 13https://crawl.develz.org/mantis/view.php?id=11553 by josh 14:49:20 that last one is actually a crash on release_shared triggered by ~Widget() 14:51:30 -!- mclemens_ is now known as mclemens 14:52:31 -!- amalloy_ is now known as amalloy 14:56:37 looks like an accidental double release, maybe there were multiple distinct shared_ptrs for the help menu somehow 18:21:15 Unstable branch on underhound.eu updated to: 0.22-a0-812-g4c1e2d5471 (34) 18:40:24 gammafunk: I was thinking about how to improve the vampire's tooth 18:40:43 !haunt ebering 18:40:43 gammafunk gestures at ebering while chanting. Insubstantial figures form in the air. The wraith hits ebering! x3 The shadow wraith hits ebering! x3 18:40:46 oh? 18:40:46 and uh, I came up with this: make it ignore ac and make it a qb 18:41:32 ignore AC is a bad mechanic probably; sounds like you're just trying to make a higher base damage vamp weapon with speed ego 18:42:27 what I would say about itroducing a new unrand mechanic is try to make it not some kind of tweak that does the same thing as some other fundamental aspect, just in a more obtuse way 18:42:36 that's my gut reaction to that, at least 18:42:39 ok 18:43:01 I could be wrong, but I can't see how ignoring AC would actually be interesting in particular compared to just making it a better weapon type 18:43:20 well, the tooth's other gimmick is that you get 100% of damage for healing when the vamp triggers 18:43:38 ignoring ac on a small base damage type (and I'm less sure of the qb now that I look at the numbers again) 18:43:56 means you do a consistent amount of smaller damage but get good healing when you attack vulnerable monsters 18:44:17 versus if you made it a stronger base type it'd be swingy but the healing against a low ac monster would be huge 18:45:05 well it's not especially swingy though; just a demon blade or something ends up feeling like very consistent damage 18:45:45 there's already a fancy vamp longblade though 18:46:13 yeah, so that's probably more suggesting thinking of a new idea altogether for a vamp shortblade 18:47:53 it has the one idea of 100% heal so it probably shouldn't get a second thing that's samey to more base damage 18:48:19 but yeah I'm not really sure how to make vampirism excting on a short blade 18:48:30 one way to get at the same idea is just give it a lot of slaying 18:48:38 I like that because it's much more straightforward 18:49:25 hmm ya. like an unnaturally high plus like 12 18:49:43 maybe, yeah 18:50:00 you could make it a qb as you say and give it good slaying 18:50:48 there's also Morg, which is another unrand which is kind of just defined by flavor; it's better as melee weapon but not an exciting weapon 18:51:17 but I guess part of the point of vampire's tooth is that it's an unrand dagger; if it's a qb it's no longer a dagger and that's that 18:51:28 we do already have an unrand qb that has quite the gimmick 18:55:38 singing sword is another one that would be good to look at 18:56:00 simplify the sonic damage and make the weapon actually good compared to just an enchanted double sword 18:56:15 for thermic engine I think I'm just going to remove the rF- and rC- with no other adjust 18:56:48 yeah, that probably would fix the thermic engine 18:57:01 well, G&G are the only unrand qb 18:57:42 right, it's not a problem to have a second one, but we do have one and we'd be losing an unrand dagger if we made the tooth a qb 18:57:55 which isn't any huge deal, but the ones we have left are also not very exciting 18:58:04 morg and spriggan's knife? 18:58:10 ??spriggan's knife 18:58:10 spriggan's knife[1/1]: The +7 Spriggan's Knife {MR+ EV+4 Dex+4 Stlth+}. This knife was made by Spriggans, or for Spriggans, or possibly from Spriggans. Anyway, it's in some way associated with those fey folk. Actually a dagger. 18:58:29 we have a second unrand qb, gimble 18:58:34 ya, morg and the spriggan's knife 18:58:43 wheals no 18:58:45 you're retired! 18:59:01 you can't just come back and make a joke like that 18:59:17 the dunk before the commitstorm 19:02:13 Morg should be a necro enhancer 19:02:30 i'm sure that's been suggested many times before 19:02:39 hexes enhancer imo 19:02:59 and it should become a spear 19:02:59 and then turn boris into a lich ninja 19:03:16 then there are even fewer unrand daggers!! 19:03:31 morg gives you evokable orb of destruction 19:03:32 advil: widget/ui layout names? analogous to DOM ids? i was planning to do something like that, yeah 19:03:58 evokable lcs 19:04:07 @?boris 19:04:07 Boris (05L) | Spd: 10 | HD: 22 | HP: 129-184 | AC/EV: 15/10 | Dam: 25, 1513(drain) | 07undead, 10weapons, 10items, 10doors, evil, spellcaster, see invisible, unbreathing | Res: 13magic(immune), 02cold++, 10elec, 09poison+++, 12drown, 04rot+++, 13neg+++, 13torm | Vul: 08holy | XP: 5775 | Sp: b.cold (3d32), iron shot (3d37), o.destruction (9d18), invisibility | Sz: Medium | Int: human. 19:04:12 sorry, no can do 19:04:14 or I guess iron shot 19:04:17 unless we want to give boris lcs 19:04:27 oh I know 19:04:31 *evocable necromutation* 19:04:31 morg +Inv +Orb 19:04:54 advil: for scroller widgets at the very least, since they need to be synchronized with webtiles clients, and giving them names helps nullify race conditions 19:05:15 but it'd also be good for ui scripting 19:05:19 My extended guide (self.dcss) Scum abyss for Morg for necromutation so you can get it w/o spell hunger 19:11:02 idea for zhor: monsters sometimes get distracted by your smell, sort of a weaker gozag/ru style distraction 19:35:24 so the fsim with +12 instead of ignoring AC lands in a similar AvEffDam range 19:38:10 which is less than a +4 elec qb (14.2 vs 19.1 against a death yak) 19:38:17 (similar to ignoring AC) 19:38:27 gammafunk: could copy foul stench Ds mutation 19:50:53 ebering: right, but you're only looking at aveeffdamn, not the fact that the player is getting healed 20:16:13 -!- gammafunk is now known as MagnusCarlsen 20:16:44 -!- MagnusCarlsen is now known as gammafunk 20:47:27 gammafunk: yea, I mention that not as a shortcoming but as a "these numbers still feel about right" 20:47:49 it seems to be similar in healing power to casting vamp. draining at ~100 spellpower without haste 20:47:52 on average 20:48:29 I forget, does the slaying count as part of the heal effect? 20:48:49 yes 20:49:01 nice, that's helpful 20:49:32 yea, since the vamp effect is 100% of the damage on 3/5 hits the AvEffHeal is 3/5 the damage 21:15:15 New branch created: pull/825 (2 commits) 13https://github.com/crawl/crawl/pull/825 21:15:15 03ebering02 07https://github.com/crawl/crawl/pull/825 * 0.22-a0-813-g05730a2: Constify attack::using_weapon() 10(8 hours ago, 5 files, 5+ 5-) 13https://github.com/crawl/crawl/commit/05730a2c8f03 21:15:15 03ebering02 07https://github.com/crawl/crawl/pull/825 * 0.22-a0-814-gd566d43: Buff Vampire's tooth (gammafunk) 10(2 hours ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/d566d43e5fca 21:26:45 big 21:28:17 if true 21:29:42 03Aidan Holm02 07* 0.22-a0-813-gf2cf4e3: Fix use of uninitialized memory in help (josh) 10(14 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/f2cf4e3eaee4 21:29:42 03Aidan Holm02 07* 0.22-a0-814-g8125a50: Fix segfault after viewing help from menu (josh, #11553) 10(13 minutes ago, 1 file, 4+ 8-) 13https://github.com/crawl/crawl/commit/8125a501902a 21:41:03 aidanh: really loving the new menus 21:41:18 player dolls on species select screen when 21:41:25 woohoo! 21:42:29 well, that'll take a while, since redoing the newgame/startup menus requires the ability to focus input widgets 21:43:02 and the menus have to be implemented in html/js as well 21:43:46 aidanh: small bug. when you're in a help from a dialog (say x?) you can't press a key and have that action happen, you used to be able to 21:43:47 plus, we need some player background tiles to match the species tiles, and I'm not too happy with the current selection 21:44:35 ebering: never even knew that was a thing, but shouldn't be hard to add back in 21:44:54 I only use it in wizmode so I didn't notice until today 21:46:49 aidanh: well, the current improvements are amazing enough 21:47:51 :D music to my ears 21:48:58 maybe I should play webtiles and see what the hype is all aobut 21:49:08 console is just chugging along per usual 21:51:04 console, just the same? you didn't notice the letters are a little crisper? :O 21:53:23 𓀾 is now monospaced correctly ;) 22:06:23 03ebering02 {Aidan Holm} 07* 0.22-a0-815-gb582571: Don't re-check forgotten map squares (10461) 10(6 weeks ago, 1 file, 8+ 1-) 13https://github.com/crawl/crawl/commit/b582571b5a0e 22:10:19 Unstable branch on crawl.jorgrun.rocks updated to: 0.22-a0-814-g8125a50190 (34) 22:33:04 yeah I think the biggest place I've noticed keys not working in a help menu is in the & screen 22:33:16 iirc it was otherwise pretty inconsistent about whether it worked 23:10:16 Unstable branch on crawl.jorgrun.rocks updated to: 0.22-a0-815-gb582571b5a (34) 23:52:25 Player can be trapped in aerie_lemuel vault 13https://crawl.develz.org/mantis/view.php?id=11554 by Pekkekke