01:39:33 03CanOfWorms02 {GitHub} 07* 0.22-a0-363-g29407c6: Fix some manual acquirement logic 10(10 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/29407c6de42c 02:09:53 Unstable branch on crawl.jorgrun.rocks updated to: 0.22-a0-363-g29407c6de4 (34) 02:46:22 Monster database of master branch on crawl.develz.org updated to: 0.22-a0-363-g29407c6 03:11:45 Unstable branch on crawl.beRotato.org updated to: 0.22-a0-363-g29407c6 (34) 03:47:44 Spells are visible in M screen after sacrificing the spell school to Ru 13https://crawl.develz.org/mantis/view.php?id=11451 by Surr 05:14:59 -!- amalloy is now known as amalloy_ 09:21:04 /? 09:55:37 03advil02 07* 0.22-a0-364-g646ff71: Fog spread rate simplification 10(27 minutes ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/646ff71b4c43 10:02:20 anyone know what fluffy clouds were used for? 10:02:26 the seem to be unused now? 10:02:47 *they 10:09:24 !tell elliptic any thoughts on the overall approach in https://github.com/crawl/crawl/pull/729 ? I figure you would have some opinions on this, and the basic problem is something I'd like to deal with, because otherwise bots can't use skill targets 10:09:25 advil: OK, I'll let elliptic know. 10:09:54 Unstable branch on crawl.jorgrun.rocks updated to: 0.22-a0-364-g646ff71b4c (34) 10:11:49 !learn del advil_todo[1 10:11:49 Deleted advil todo[1/2]: eliminate or change bad fogs 11:02:15 advil: fluffy clouds are (were?) used in the cloud mage wizlab i think 11:04:11 -!- MarvinPA_ is now known as MarvinPA 11:06:40 advil: this skill_training_needed callback should work for situations other than skill targets, right? e.g. if the only skill being trained reaches 27? 11:06:41 elliptic: You have 1 message. Use !messages to read it. 11:07:41 if so it sounds pretty good, though I agree with you that it would be better to avoid unnecessary recursion in the implementation 11:10:27 fwiw I don't really see why you would want to use the skill target stuff if you are controlling it via lua anyway, but regardless the callback seems useful to avoid getting stuck in the skill menu 11:37:08 ok thanks...re whether to use it in lua, when I looked at what qw is doing it seemed to be more or less something that could be simplified by setting very incremental short term skill targets, but I guess there's probably various ways still in which you have more control if it's all implemented in lua 11:37:47 MarvinPA: aha...it still is, it's just triggered via lua by the string "white fluffiness" so get grep for variants of "fluffy" wasn't finding it 11:38:31 *git grep 13:05:27 Unstable branch on crawl.akrasiac.org updated to: 0.22-a0-364-g646ff71 (34) 13:13:04 advil: I don't think that cloud type is used to any particularly good effect other than just for visuals maybe 13:13:10 yeah, I think it's just a different tile of los-blocking cloud 13:26:18 03Dominic Kempf02 {advil} 07* 0.22-a0-365-gb03524a: Add player LUA callback skill_training_needed 10(4 weeks ago, 1 file, 8+ 0-) 13https://github.com/crawl/crawl/commit/b03524a33725 13:26:18 03advil02 07* 0.22-a0-366-gae935ca: Check the results of the skill_training_needed callback 10(7 minutes ago, 4 files, 60+ 60-) 13https://github.com/crawl/crawl/commit/ae935ca1a00f 13:26:18 03advil02 07* 0.22-a0-367-gb72a975: Merge branch 'dokempf_skill_callback' 10(3 minutes ago, 0 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/b72a97570147 13:27:10 merge commit :o 13:27:30 yeah, it was sort of by accident (there's no actual merge involved) 13:27:41 was that through the github UI? 13:27:49 aka the purple button 13:27:50 no, I just spaced out and did --no-ff 13:27:56 ah I see 13:28:07 I don't mind so much having a merge commit for cases where a PR is partially merged like this 13:28:48 yeah, no biggie at all 13:29:22 funny story from back when I was less familiar with git but I rebased a lot to keep my branch in good order when I was working on it over time 13:29:48 I was talking about how much work it was to make "rebase branches" so I could cherry pick commits in the "right order" 13:30:01 grunt was very confused about my description of the workflow and was asking me some questions 13:30:12 he eventually realized that I didn't understand how 13:30:28 you can reorder commits in the rebase -i screen by moving the lines around :D 13:30:53 when he told me that I realized how much time I had wasted making weird branches to order my commits 13:30:59 hahaha 13:31:52 yeah, it's not very obvious that cherry-pick is an interface over rebase, not v.v. 13:32:49 in this case everything was nicely rebased, I just did the merge into master with --no-ff 14:01:55 -!- amalloy_ is now known as amalloy 14:09:52 Unstable branch on crawl.jorgrun.rocks updated to: 0.22-a0-367-gb72a975701 (34) 17:56:06 advil: you have a new reddit fan: https://www.reddit.com/r/dcss/comments/8dyq73/this_is_long_overdue_but_thanks_for_allowing/ 18:19:21 Unstable branch on underhound.eu updated to: 0.22-a0-367-gb72a975701 (34)