00:30:39 -!- andre is now known as Guest49450 00:34:41 -!- tat is now known as Guest79841 00:42:01 hey |amethyst, can I use your pic as an emote: https://snag.gy/TghG2w.jpg 00:42:13 cropped around it and everything! 00:58:19 <|amethyst> as long as you don't try to connect it to any theatre shootings 00:58:29 ty :) 01:08:59 gammafunk, you need this on your twitch 01:10:30 I'm more partial meleebug baghead guy 01:10:46 he represents the spirit of all developers who have introduced a software-breaking bug 01:10:58 heh 02:09:18 wow 02:09:18 that's a hell of a pic 03:26:07 -!- mikee__ is now known as mikee_ 04:05:44 -!- amalloy is now known as amalloy_ 04:33:29 -!- amalloy_ is now known as amalloy 04:49:41 -!- Dracunos_ is now known as Dracunos 04:59:17 is this still the best server setup guide: 04:59:18 https://crawl.develz.org/wiki/doku.php?id=dcss:server:setting_up_dgamelaunch_and_webtiles 05:06:11 -!- amalloy is now known as amalloy_ 06:58:43 Is there possibly a useful guide to debugging mis-offset tiles from the tilesheet? I am getting compilation nausea. 06:59:59 Some tiles in-game are displaying roughly 40px further right on the tilesheet than they should, while others are fine 09:15:51 til that cgotoxy without a region argument at the wrong time can just mysteriously blank out the webtiles display for a little bit 09:38:20 03advil02 07https://github.com/crawl/crawl/pull/585 * 0.21-a0-287-g9746fca: Fix a fairly nasty bug leading to blank webtiles sometimes 10(21 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/9746fca572f9 09:38:20 03advil02 07https://github.com/crawl/crawl/pull/585 * 0.21-a0-288-g192c7fe: Generalize webtiles text input code and use it for skill targets 10(6 minutes ago, 9 files, 345+ 157-) 13https://github.com/crawl/crawl/commit/192c7fe3075d 09:40:09 I think I spent on the order of 3 hours on that stupid blank webtiles bug 09:48:46 03advil02 07https://github.com/crawl/crawl/pull/585 * 0.21-a0-288-g6b39a30: Generalize webtiles text input code and use it for skill targets 10(17 minutes ago, 9 files, 344+ 157-) 13https://github.com/crawl/crawl/commit/6b39a30364d8 09:52:47 hm, why do people think eveningstars are going to get removed? 10:31:25 I was under the impression were removed in hellcrawl? 10:33:11 hmm, maybe, but that was months ago 10:33:33 also, now I wonder of that blank UI commit is why I could never get webtiles working on an OS X webtiles build 10:33:48 yes, but I have seen recent confusion about that 10:34:31 that bug could be elsewhere in the codebase too, that specific one is something I introduced in that branch 10:34:38 it is possible that thinsg olike discussion of food removal have caused some people to think hellcrawl is a testbed for major changes 10:34:52 OS X webtiles should work, I use it without problems 10:35:30 the problem I had, admittedly this was a few years ago, was that new games would dislay but loading a saved game got a blank display 10:35:50 so maybe this bug also exists in some form in the welcome messages 10:35:53 huh 10:36:23 well that's exactly the symptom of using cgotoxy with crt as the region (which is the default) at the wrong time 10:37:33 though in my scenario it timed out with some keypresses, I think whenever a redraw was next forced 10:39:16 it's also the kind of bug that could get accidentally fixed, so it's plausible it has been a problem before 10:41:25 there's a ton of 2-arg calls to cgotoxy, wonder if it would be better to not have region be a default arg 10:45:41 hmm I have no idea when webtiles even uses the crt div 10:59:20 if this is never actually used any more, it might be nice to remove, but I wonder if I'm missing some obscure case 11:19:00 can anyone spot any obvious problems that this will lead to? https://pastebin.com/Ty7VAPHj 11:19:11 |amethyst maybe? 12:22:30 -!- amalloy_ is now known as amalloy 12:31:08 what is CRT here supposed to mean? surely it is not referring to a kind of monitor 12:54:01 <|amethyst> advil: CRT mode is used when we do something "full-screen", though I'm not cure how often that happens in webtiles 12:54:48 <|amethyst> s/cure/sure/ 12:56:23 <|amethyst> advil: usually you'd make a tiles_crt_control crt(false); to avoid that (which restores the previous state once you leave its scope) 12:57:31 <|amethyst> advil: though in this case I think passing the region is better 12:58:57 <|amethyst> advil: alternatively, you could use cursorxy(), which also handles use_fake_cursor (and automatically disables CRT mode) 12:59:49 <|amethyst> advil: but I'm not sure if that would be appropriate here, since you are probably in GOTO_MSG here rather than GOTO_CRT? 13:01:44 <|amethyst> advil: my concerns with just changing the CRT mode to disabled by default are 1) I'm not sure whether we rely on switching modes (other than CRT_MENU) anywhere in webtiles 2) local tiles could have similar problems, maybe? 13:25:07 opinions on changing the display name of unrands with "owners" from stuff like "the +2 Maxwell's thermic engine" to "Maxwell's +2 thermic engine"? the existing "the" seems out of place and weird 13:28:04 the second one seems a bit awkward to me because of +2 being after "Maxwell's" 13:28:18 did Maxwell also own a +3 thermic engine and he's not sharing?! 13:40:37 i mean, it was a +2 thermic engine owned by maxwell 13:41:24 I'd just like to think that the great Maxwell would be a little more attentive about enchanting up his main weapon 13:41:33 just like when you get a chai tea it becomes gammafunk's chai tea, when maxwell gets a +2 thermic engine it becomes maxwell's +2 thermic engine 13:42:23 you may have won this round, amalloy 13:42:28 but I will return 13:43:02 tbh i should have looked up the most ridiculously froofy starbucks order and used that as the example instead of a chai tea, to make you look like a froofy coffee drinker 13:43:15 true, missed opportunity 13:43:27 I only ever order cappuccinos 13:43:31 btw https://github.com/crawl/crawl/wiki/0.21-Development-and-Release-Plan 13:43:44 if you see anything wrong or something you'd like to add 13:44:08 There are some areas not complete and a couple more possible things I'd like to add 13:54:11 good work on that release plan, gammafunk. it's nice to have a Plan 13:54:57 ty 13:55:34 !learn add plan[1] https://github.com/crawl/crawl/wiki/0.21-Development-and-Release-Plan 13:55:35 plan[1/2]: https://github.com/crawl/crawl/wiki/0.21-Development-and-Release-Plan 13:55:38 ??plan[2 13:55:39 plan[2/2]: https://crawl.develz.org/wiki/doku.php?id=dcss:planning:release_plans 13:55:55 allegedly "Peppermint Mocha Frappuccino Blended Coffee" is the most sugary drink you can get at starbucks btw. i could not find a list sorted by froofiness 13:57:06 A peppermint mocha I could probably drink but the 3 words after that do nothing but raise alarming questions 13:57:33 i had a peppermint mocha once and it tasted exactly like mint chocolate chip ice cream 13:58:17 did you get cream on it? 13:58:25 *whip cream 13:58:32 if so, big mistake 13:59:24 but that said, I just like cappuccinos and don't really drink things like mochas 14:04:11 is that what we're replacing rations with 15:59:29 options_guide.txt has "Haste" spell in an example 13https://crawl.develz.org/mantis/view.php?id=11233 by crate 16:01:35 rip 16:01:35 rip 16:40:27 |amethyst: here's a slightly unpacked rationale for that pastebin, I think I was too elliptical. (i) I don't *think* that webtiles ever uses CRT_NORMAL, any more, but it probably did in the past. Everything that I could find is done with CRT_MENU. 16:41:43 (ii) if you accidentally use cgotoxy without a region with CRT_NORMAL as the default mode, it will blank the screen in webtiles (that is the only case where the crt div is enabled) 16:42:32 <|amethyst> Is (ii) only webtiles? 16:42:34 (iii) that change only affects webtiles, those CRT modes are not used at all outside of webtiles 16:42:40 yeah 16:42:43 <|amethyst> hm 16:43:05 <|amethyst> in that case, I would remove CRT_NORMAL entirely instead of just changing the default 16:43:09 so really what I was wondering is if I'd missed some reason for CRT_NORMAL mode to still exist 16:43:31 yeah, I guess in principle someone might still want it? I think it still works 16:43:46 advil: did you intend to make that announcement btw? 16:43:50 er 16:43:52 or however that's actually called 16:43:56 what did I do? 16:44:09 you did what travis does when it joins to announce build results 16:44:16 huh 16:44:16 your first message did, rather 16:44:19 after that they were normal 16:44:24 it shows up gray on my screen, I was wondering why 16:44:34 I do not know how or why that happened :) 16:44:43 test 16:44:48 <|amethyst> advil: so one concern is: what would it mean in webtiles if you said cgotoxy(1,1) then printed something? 16:44:58 I guess that's how, but I still don't know why 16:45:19 advil: I have that rigged to play a sound so if you ever want to get back at me 16:45:24 just spam a bunch of messages like that 16:45:25 lol 16:45:37 How did you do that? 16:45:38 |amethyst: hmm, good question, I think nothing? 16:45:47 <|amethyst> advil: is that what we want? 16:46:07 it might also print something in the messages pane, I'd have to check 16:46:49 <|amethyst> hm 16:46:59 neizenel: if you mean the announcement thing, in the client I'm currently using (LimeChat), apparently C-Enter does it 16:47:29 How horribly abusable! 16:47:47 <|amethyst> advil: I'm trying to see if I find any uses of cgotoxy(...) without a region that aren't protected by tiles_crt_control ...(CRT_MENU) 16:48:07 yeah, I couldn't find any 16:48:44 I guess the other thing to double check would be that it doesn't affect console on webtiles builds somehow 16:48:47 <|amethyst> hm, there's some some stuff in describe-god.cc 16:48:56 I think that's secretly protected somehow 16:49:06 I didn't try to track it down, but it all works in non-crt mode in webtiles 16:49:32 <|amethyst> hm, what about hints.cc 16:49:42 maybe this isn't worth trying to change, I was just salty that I had to spend so long figuring out why webtiles went blank in this one specific case 16:49:49 ah right I saw the hints stuff but didn't test it 16:49:52 <|amethyst> I had a similar bug earlier 16:50:02 <|amethyst> s/had/spent a bunch of time tracking down/ 16:50:28 <|amethyst> %git fcb472390 16:50:28 07|amethyst02 * 0.20-a0-840-gfcb4723: Fix use_fake_cursor = false webtiles targeting (#7201, #10965) 10(7 months ago, 1 file, 3+ 0-) 13https://github.com/crawl/crawl/commit/fcb47239012d 16:50:39 <|amethyst> this one only affected use_fake_cursor 16:50:47 I think I remember that one 16:50:53 <|amethyst> but broke targeting in webtiles if you had that option on 17:02:14 <|amethyst> advil: anyway, I think it's reasonable to try (do test hints mode though) 17:02:22 <|amethyst> advil: if there's a problem, it can be reverted 17:02:44 <|amethyst> advil: but I do think it's cleaner to remove the enumerator entirely just to be sure nothing weird is going on 17:03:03 <|amethyst> then you can maybe rename CRT_DISABLED to CRT_NORMAL 17:03:30 <|amethyst> and also remove calls to tiles_cursor_control::tiles_cursor_control(bool) since those are just to switch to CRT_DISABLED 17:04:13 <|amethyst> (and then you can remove that constructor too, leaving just the one that takes a CRT_* mode for the menu stuff... one could envision other cleanups there too) 17:04:29 yeah, with CRT_DISABLED I think it does nothing, though intuitively that might be the right outcome for any old cprintf to GOTO_CRT in webtiles? 17:04:37 CRT_NORMAL does still work, ish 17:05:06 I might also do some code archeology to figure out why the mode existed, before doing anything 17:05:15 <|amethyst> but CRT_NORMAL won't be used anywhere anymore 17:05:29 <|amethyst> advil: it might have predated CRT_MENU, or at least the consistent use of CRT_MENU 17:05:34 right 17:05:38 <|amethyst> advil: hm, what does ctrl-o use? 17:05:47 <|amethyst> advil: because unlike menus, it blanks the whole screen 17:05:51 <|amethyst> (in webtiles) 17:05:57 I tested it earlier and it doesn't use the crt div 17:06:10 I just get a dimmed background for ctrl-o, not blank 17:06:17 <|amethyst> hm 17:07:32 <|amethyst> it definitely clears the screen for me 17:07:49 can you look in an inspector and see what div is visible? 17:09:07 I guess another piece of the confusingness is the use of GOTO_CRT as the default region for cgotoxy, which maybe does make sense for the other 2 versions, but not at all for webtiles 17:09:11 <|amethyst>
but nothing is showing through 17:09:22 overlay is the one that dims the screen 17:09:43 there should be a