00:33:23 <gammafunk> Napkin: Looks like the windows builds of trunk stopped on CDO, do you remember what I have to check to restart those?
00:33:36 <gammafunk> Napkin: I recall you fixed an issue recently for rebuilds
01:12:18 <Gretell> Windows builds of master branch on crawl.develz.org updated to: 0.21-a0-278-ga722497
01:45:35 -!- amalloy is now known as amalloy_
02:53:43 <Gretell> Monster database of master branch on crawl.develz.org updated to: 0.21-a0-278-ga722497
04:06:11 -!- yesno_ is now known as yesno
04:18:05 <Napkin> gammafunk: checking
04:18:06 <Napkin> something weird
04:18:25 <gammafunk> Napkin: I ran the build directly from shell and it went ok
04:18:31 <gammafunk> but not sure why the cron job was not working
04:18:43 <Napkin> exactly
04:19:03 <Napkin> my cronjob email says "nothing new to install" for weeks already
04:19:25 <gammafunk> did it fail to pull?
04:19:32 <Napkin> maybe
04:19:34 <Napkin> checking
04:19:49 <Napkin> but ~crawl has no agent-forwarding on
04:20:03 <Napkin> so it should always happen, even when manually triggering it
04:20:58 <Napkin> when did you run it manually, gammafunk?
04:21:08 <gammafunk> hrm, just a few hours ago
04:21:16 <Napkin> hmm.. no commit since then
04:21:21 <Napkin> need to wait then
07:02:51 <ai4life> is anyone familiar with the map data in the 'cells' field that is sent from the webserver to the javascript code that renders the game in webtiles?
07:03:18 <ai4life> i'm trying to decode it and build my own internal map
07:03:40 <ai4life> the main problem is that some cell data isn't associated with a particular x,y coordinate
07:04:19 <ai4life> particularly, some cells are clearly walls, because they have 'g':'#'
07:04:30 <ai4life> but there is no x,y coordinates for them
08:19:08 <|amethyst> !tell ai4life Re your question aboult cells.x and cells.y:  To reduce bandwidth, the coordinates are omitted if the cell is directly to the right of the previously-sent cell
08:19:08 <Sequell> |amethyst: OK, I'll let ai4life know.
08:20:23 <|amethyst> !tell ai4life see TilesFramework::_send_map in tileweb.cc, and function merge() in webserver/game_data/static/map_knowledge.js
08:20:24 <Sequell> |amethyst: OK, I'll let ai4life know.
08:21:51 -!- amalloy_ is now known as amalloy
09:14:49 -!- amalloy is now known as amalloy_
09:29:04 -!- amalloy_ is now known as amalloy
09:40:37 -!- amalloy is now known as amalloy_
11:34:48 <G-Flex> is it intended that reflection doesn't give XP for kills?
12:25:54 <elliptic> G-Flex: I don't think so, that sounds bad to me
12:36:01 <G-Flex> elliptic: I can't guarantee there's no XP gain, but there's definitely no oka piety
12:36:06 <G-Flex> so I'm not sure how it's working
12:51:26 <|amethyst> piety and XP are handled separately there
12:51:50 <|amethyst> the reason it doesn't give XP gain is that the code that prevents you from getting penance for reflected attacks cuts both ways
12:51:55 <|amethyst> err
12:52:03 <|amethyst> the reason it doesn't give piety gain, rather
12:52:07 <|amethyst> it should give XP
12:53:05 <|amethyst> probably that could be fixed, by somewhere converting YOU_FAULTLESS into YOU if we're asking about god likes rather than dislikes
12:53:09 <|amethyst> but I don't know where
12:54:46 <|amethyst> hm
12:55:05 <|amethyst> _fire_kill_conducts looks like it's supposed to handle that, so maybe something's going wrong on the way there
12:55:51 <|amethyst> hm
12:57:13 <|amethyst> hm, no, it must be something else, because that one specifically looks for god_hates_killing
12:57:28 <|amethyst> so probably it's that it isn't being converted somewhere
13:00:46 <|amethyst> oh hmm
13:06:55 <|amethyst> it looks like even in the kills table it counts as a monster kill
13:06:59 <|amethyst> it's just that you get XP for it
13:07:22 <|amethyst> (because exp_rate handles YOU_FAULTLESS)
13:08:20 <|amethyst> so only blame_damage (used for XP allocation) and monster behaviour considers it to be damage "from the player", everything else treats it as a monster kill
13:09:32 <|amethyst> hm, but in _fire_kill_conducts I'm getting killer_index being the monster's index, not YOU_FAULTLESS
13:13:18 <|amethyst> hmm
13:14:54 <|amethyst> it looks like in attack::handle_phase_killed, which is where monster_die is ultimately called, we use the attacker (which is the monster who shot) rather than the "responsible" attacker
13:15:48 <|amethyst> we *do* pass the responsible attacker when assigning damage in attack::inflict_damage, but we specifically ask for monster::hurt not to kill the monster yet, so it can be handled later in handle_phase_killed
13:16:09 <|amethyst> a fix might be to pass responsible rather than attacker in handle_phase_killed
13:16:53 <|amethyst> but you'd also have to make sure you still don't award penance for reflecting a prohibited attack (or killing a prohibited monster with reflection)
13:47:01 <|amethyst> (I wouldn't be surprised if it worked before, then stopped working because of some tweak to attack.cc)
13:52:41 <|amethyst> G-Flex:  mind filing a bug? :)
13:52:57 <|amethyst> G-Flex:  (I didn't find a relevant one when I searched for "reflect")
15:09:04 -!- sqwishy1 is now known as sqwishy
16:44:35 -!- amalloy_ is now known as amalloy
17:03:43 <gammafunk> |amethyst: btw, I noticed that dobrazupa is still having trouble serving morgues/ttyrecs
17:05:34 <G-Flex> |amethyst: I'll take a look when I'm at home
17:05:36 <G-Flex> thanks
17:06:01 <G-Flex> btw is it intended that killing abyss monsters can spawn a down stair even if you're standing on an abyss exit you've already spawned by killing things, thus changing the exit to a stair?
17:10:55 <gammafunk> hard to say of PF intended that or not
17:12:31 <G-Flex> PF?
17:13:10 <gammafunk> pleasingfungus, the dev who made that change
17:16:42 <amalloy> i'd guess that was unintended but not a huge problem. if you're tabbing stuff while standing on the exit you probably aren't desperate to leave
17:18:37 <gammafunk> yeah, I asked PF, and he said it was probably just oversight, not anything he intented (or anyone else involved in the change, that he knows of)
17:18:53 <gammafunk> *intended
17:25:57 <G-Flex> oh, sorry
17:26:06 <G-Flex> amalloy: in this case I didn't realize it would happen
17:26:12 <G-Flex> but yeah not the biggest deal
17:26:18 <G-Flex> more funny than anything else
17:49:54 <advil> %git 7a2edd755c9597b4c6e7a40646a2a93b138ab0ab
17:49:54 <Cheibriados> 07PleasingFungus02 * 0.19-a0-93-g7a2edd7: Give piety for reflection kills (10362) 10(1 year, 4 months ago, 1 file, 5+ 4-) 13https://github.com/crawl/crawl/commit/7a2edd755c95
17:50:12 <advil> I think that was supposed to be fixed
17:50:12 <advil> but reflection has a lot of corner cases
17:51:27 <advil> it's possible that some later fix for a reflection crash reverted this effect
17:51:45 <advil> I've fixed ~2 bugs like that and I have a vague memory of discussing this with someone
17:51:55 <advil> since PF's commit there, that is
18:13:59 -!- amalloy is now known as amalloy_
19:47:09 -!- Fixer_ is now known as Fixer
19:51:55 -!- Grammu is now known as Gramm
20:09:02 <Cheibriados> 03gammafunk02 07* 0.21-a0-279-g6037ffb: Tweak monsters in a crab-themed vault (mikee) 10(10 minutes ago, 1 file, 32+ 20-) 13https://github.com/crawl/crawl/commit/6037ffb4b7bf
21:09:19 <Jorgrell> Unstable branch on crawl.jorgrun.rocks updated to: 0.21-a0-279-g6037ffb (34)
22:00:03 -!- tat is now known as Guest23858
22:36:41 -!- mikee__ is now known as mikee_
23:38:00 -!- n1 is now known as Guest78291
23:38:11 -!- Guest78291 is now known as n1
23:59:19 <Eksell> Unstable branch on CRAWL.XTAHUA.COM updated to: 0.21-a0-279-g6037ffb (34)