01:49:40 -!- Rast-- is now known as rast
01:57:57 -!- amalloy_ is now known as amalloy
03:11:39 <Rotatell> Unstable branch on crawl.beRotato.org updated to: 0.21-a0-155-gb8a8bae (34)
03:25:52 -!- Dracunos_ is now known as Dracunos
04:11:22 <Cheibriados> Natasha zapped wand of digging but it was not dropped with her corpse 13https://crawl.develz.org/mantis/view.php?id=11170 by Gorice
04:21:05 -!- amalloy is now known as amalloy_
04:30:46 <gammafunk> !apt ho
04:30:46 <Sequell> HO: Fighting: 2, Short: 0, Long: 1, Axes: 3!, Maces: 1, Polearms: 1, Staves: -1, Slings: -1, Bows: -1, Xbows: -1, Throw: -1, Armour: 1, Dodge: -2, Stealth: -1, Shields: 1, UC: 1, Splcast: -3, Conj: 0, Hexes: 0, Charms: -1, Summ: 0, Nec: 0, Tloc: -2, Tmut: -3, Fire: 1, Ice: -1, Air: -2, Earth: 0, Poison: -1, Inv: 3!, Evo: 0, Exp: 0, HP: 1, MP: 0
05:17:40 -!- Reverie is now known as Catiua
09:02:22 <advil> %git 7e33cd4c7c797b23f4f09426d7b1887f7b235871
09:02:22 <Cheibriados> 07wheals02 * 0.14-a0-2775-g7e33cd4: Let Natasha start with a wand, and have her keep her items through death. 10(3 years, 5 months ago, 3 files, 15+ 1-) 13https://github.com/crawl/crawl/commit/7e33cd4c7c79
09:46:43 <wheals_> heh
10:27:17 <shmup> >
10:27:21 <shmup> > There's no longer any need to FeAr that she can't use wands.
11:24:32 <Cheibriados> 03gammafunk02 07* 0.21-a0-156-g77413b7: Fix autoexplore not starting properly under some conditions (#11159) 10(45 minutes ago, 1 file, 21+ 27-) 13https://github.com/crawl/crawl/commit/77413b7de0dc
11:27:05 <gammafunk> ??rebuild
11:27:05 <Sequell> rebuild[1/2]: http://crawl.akrasiac.org/rebuild/ http://underhound.eu:81/rebuild/ http://crawl.berotato.org/crawl/rebuild/ http://crawl.xtahua.com/rebuild/ https://crawl.jorgrun.rocks/rebuild/ Bug |amethyst or Nap.Kin for CDO. Use your powers wisely.
11:27:08 <gammafunk> ??rebuild[2
11:27:09 <Sequell> rebuild[2/2]: Trunk update start times in UTC (second number during summer time): CAO: 1700; CDO: 0600/0500; CUE: 2300/2200; CBRO: 0800/0700; CXC: 0500/0400; CPO: every 15 minutes; CJR: every hour
11:31:17 <Henzell> Unstable branch on crawl.akrasiac.org updated to: 0.21-a0-156-g77413b7 (34)
11:31:30 <Lantell> Unstable branch on underhound.eu updated to: 0.21-a0-156-g77413b7 (34)
11:32:50 <Eksell> Unstable branch on CRAWL.XTAHUA.COM updated to: 0.21-a0-156-g77413b7 (34)
11:33:01 <gammafunk> Yermak: not sure if you get notified from mantis, but that autoexplore/pickup bug should be fixed now (and on CXC)
11:33:42 <Yermak> Cool, thanks!
11:39:44 <Rotatell> Unstable branch on crawl.beRotato.org updated to: 0.21-a0-156-g77413b7 (34)
11:49:58 <gammafunk> MarvinPA: by the way, did you see 11168?
11:50:14 <gammafunk> was brought on by your changes to have wands use your_spells()
11:50:41 <gammafunk> the spell range function doesn't know how to check for whether the thing was actually a spell
11:52:13 <MarvinPA> aha, i hadn't seen that
11:52:37 <gammafunk> finally, vehumet no longer weak!
11:52:48 <MarvinPA> probably just needs an evoked bool to be passed a bit further along, will try and take a look later
12:09:31 <Jorgrell> Unstable branch on crawl.jorgrun.rocks updated to: 0.21-a0-156-g77413b7 (34)
13:11:27 -!- amalloy_ is now known as amalloy
14:40:11 -!- Reverie is now known as Reverie|Away
17:22:10 -!- Amnesiac_ is now known as Amnesiac
17:45:43 -!- Amnesiac_ is now known as Amnesiac
17:59:25 -!- Reverie|Away is now known as Reverie
18:31:15 <Cheibriados> Friendly OCS creates travel exclusion. 13https://crawl.develz.org/mantis/view.php?id=11171 by damerell
18:51:40 -!- Amnesiac_ is now known as Amnesiac
19:19:34 -!- Amnesiac_ is now known as Amnesiac
19:19:34 <gammafunk> alexjurkiewicz: your math is slightly wrong in your str PR calculations, for the modified values
19:20:17 <gammafunk> you try to use the max value from the argument to random2() but the max value is one less than that value, since random2 is [a, b)
19:20:23 <gammafunk> you do this correctly in the original modifier
19:21:47 <gammafunk> by your PR calculations I mean the ones in the spreadsheet
19:24:19 -!- mikee__ is now known as mikee_
20:19:20 -!- amalloy is now known as amalloy_
20:40:40 -!- amalloy_ is now known as amalloy
21:03:53 -!- ProzacElf_ is now known as ProzacElf
21:09:31 <|amethyst> why does removing or wearing a cloak of invis give me a warning prompt?
21:10:47 <gammafunk> that's a bug from lasty's change to unequiping/wearing invis granting items
21:10:48 <gammafunk> while invis
21:10:59 <gammafunk> I think he fixed one issue from that but not all of them?
21:11:07 <|amethyst> I think the fix had another bug
21:11:08 <Lasty> god damn it
21:11:13 <|amethyst> +        if (ego == SPARM_INVISIBILITY || ego == SPARM_FLYING)
21:11:13 <|amethyst> +            return true;
21:11:13 <Lasty> I thought I had it covered
21:11:46 <|amethyst> it's also badly indented
21:11:52 <Lasty> :(
21:12:31 <|amethyst> hm
21:12:35 <|amethyst> also, I just got a randart scarf of rF+
21:12:36 <gammafunk> wow, bad indention?
21:12:47 <gammafunk> That's the final straw, Lasty
21:12:50 <|amethyst> I kind of feel like randart scarves should get at least two properties
21:13:07 <Lasty> |amethyst: makes sense to me
21:14:56 <Lasty> what's wrong with the indents?
21:15:05 <Lasty> oh, crap, those are 4 space indents
21:15:08 <Lasty> curse you, work
21:15:19 <gammafunk> 4 space indents ;_;
21:15:22 <Lasty> hey wait, everything here is 4 space indents
21:15:25 <|amethyst> it's supposed to be four space
21:15:34 <|amethyst> but it's indented one more level than the surrounding code
21:15:38 <Lasty> :pppppppp
21:15:53 <Lasty> are we looking at the same thing? I'm not seeing it here
21:15:54 <gammafunk> I mean, over-indentation ;_;
21:15:57 <Lasty> item-prop.cc?
21:16:01 <|amethyst> Lasty: invent.cc line 1678
21:16:10 <Lasty> oh, huh
21:16:14 <Lasty> it sure enough is
21:16:18 <Lasty> That's
21:16:19 <Lasty> just
21:16:20 <Lasty> not
21:16:21 <|amethyst> oh
21:16:22 <Lasty> good
21:16:30 <|amethyst> I bet you accidentally pasted those lines from item-prop to invent
21:16:34 <Lasty> lol
21:16:35 <Lasty> yeah
21:16:39 <Lasty> those shouldn't be there
21:16:53 <Lasty> whee, good job me
21:17:07 <Lasty> I can remove them if you haven't already done it
21:17:17 <|amethyst> go ahead, I'm playing :)
21:17:19 <Lasty> haha
21:18:26 <Cheibriados> 03Lasty02 07* 0.21-a0-157-gb89e0e2: Remove a mistaken copy-paste (|amethyst) 10(34 seconds ago, 1 file, 0+ 3-) 13https://github.com/crawl/crawl/commit/b89e0e2f948d
21:19:04 <gammafunk> fixin' bugs
21:19:16 <gammafunk> fixin' bugs that we made!
21:19:23 <gammafunk> %git HEAD~1
21:19:23 <Cheibriados> 07gammafunk02 * 0.21-a0-156-g77413b7: Fix autoexplore not starting properly under some conditions (#11159) 10(11 hours ago, 1 file, 21+ 27-) 13https://github.com/crawl/crawl/commit/77413b7de0dc
21:19:28 <gammafunk> case in point
21:19:58 <gammafunk> at this point the bugs we fix are probably mostly ones introduced in the last few years anyhow
21:20:02 <Lasty> woo
21:53:04 -!- fiyawerx_ is now known as fiyawerx
22:09:25 <Jorgrell> Unstable branch on crawl.jorgrun.rocks updated to: 0.21-a0-157-gb89e0e2 (34)
22:21:48 -!- MadCoyote is now known as FunkyBomb
23:33:07 <gammafunk> MarvinPA: I think your new enslave soul allowed an enslaved mara to exist, which illusioned a hostile ocs and made a friendly ocs
23:33:20 <gammafunk> in bug 11171
23:33:32 <gammafunk> that itself is perhaps not a bug, but it's kind of cool regardless
23:33:52 <gammafunk> but the bug is that an exclusion still gets made over the friendly one
23:33:59 <gammafunk> classic emergent gameplay at work
23:39:23 <|amethyst> hm
23:39:37 <|amethyst> _need_auto_exclude specifically checks mon->attitude == ATT_HOSTILE
23:40:18 <|amethyst> making a friendly one doesn't create an exclusion for me
23:40:25 <gammafunk> uh oh
23:40:31 <gammafunk> were they wrong about it being friendly?
23:41:28 <|amethyst> well
23:41:42 <|amethyst> just tested with a hostile one and an att:friendly mara
23:42:05 <|amethyst> when mara clones the OCS it produces a friendly OCS, and gives the "Marking area around..." message
23:42:13 <gammafunk> ah
23:42:28 <|amethyst> but when the hostile one is destroyed, the exclusion goes away
23:45:57 <|amethyst> hmm
23:46:34 <|amethyst> odd
23:46:43 <|amethyst> the message is actually about the hostile one
23:46:55 <|amethyst> so why is it getting repeated when the monster didn't just come into view
23:47:00 <gammafunk> oh, it's rescanning los or something?
23:48:01 <|amethyst> yeah, that happens every turn
23:48:17 <|amethyst> but it's not supposed to give the message if the monster is already an exclude root
23:48:20 <|amethyst> oh
23:48:33 <|amethyst> the exclusion went away when the monster was cloned
23:48:37 <|amethyst> why did that happen?
23:50:18 <|amethyst> the only calls to remove_auto_exclude either 1. require the monster to have been asleep, or 2. are in monster_die
23:50:43 <|amethyst> let me try this again with a breakpoint
23:51:50 <|amethyst> hm, it's maybe_remove_autoexclusion
23:52:07 <|amethyst> oh, I bet I know what it is
23:52:35 <|amethyst> hah
23:52:51 <|amethyst> !source mon-clone.cc:99
23:52:51 <Sequell> https://github.com/crawl/crawl/blob/master/crawl-ref/source/mon-clone.cc#L99
23:53:17 <|amethyst> the exclusion is removed because the monster is temporarily not hostile
23:53:20 <|amethyst> so it can be cloned
23:53:30 <|amethyst> s/so it.*/as part of cloning/
23:54:19 <|amethyst> and because we call viewwindow() from clone_mons, we take the time to remove the exclusion
23:55:55 <gammafunk> oh weird
23:56:06 <|amethyst> good news
23:56:11 <|amethyst> it doesn't happen with phantom mirror
23:56:32 <|amethyst> so probably some copy-pasting can be done
23:56:38 <|amethyst> (or better yet some merging)
23:58:22 <Eksell> Unstable branch on CRAWL.XTAHUA.COM updated to: 0.21-a0-157-gb89e0e2 (34)
23:58:44 <|amethyst> phantom mirror just does mon->attitude = ...
23:58:56 <|amethyst> on the new monster
23:59:11 <|amethyst> I'm pretty sure there's some reason we weren't doing that in the mara case
23:59:30 <|amethyst> in fact, I'm sure I touched the Mara code, let me see what git blame says