00:00:21 03advil02 07[mutation_cleanup] * 0.20-a0-946-ged8219e: Fix lua formatting, tabs 10(41 seconds ago, 1 file, 65+ 52-) 13https://github.com/crawl/crawl/commit/ed8219e3fc77 00:01:14 $ wc -l *.cc *.h | grep total 00:01:14 418524 total 00:01:14 $ find dat -name '*.lua' | xargs wc -l | grep total 00:01:14 17113 total 00:01:14 $ find dat -name '*.des' | xargs wc -l | grep total 00:01:16 133091 total 00:01:24 how many lines we have currently of the various "source" files 00:01:56 excluding things like util and monster etc 00:02:40 heh, nearly half of that lua is qw 00:02:43 er 00:02:45 1/3 00:02:55 is qw saved as qw.lua? 00:02:56 or qw.rc 00:03:00 qw.rc 00:03:02 in test/stress 00:03:03 if latter it's not counted 00:03:06 ah 00:03:06 1/3 is nearly 1/2 00:03:33 looks only for ".lua" files; but yeah some data probably should be included in that data (just now qw) 00:03:41 also some of des is actually lua 00:04:03 but this is a little harder to count accurately 00:04:32 jesus, advil 00:04:36 this is beyond what I could even conceive to do 00:04:40 good work 00:04:51 it's definitely beyond what I planned to do originally, that's for sure 00:05:09 really good work 00:05:38 well, let me do more testing before you say that too strongly :-) 00:06:03 Brannock: one thing that might interest you is that there's code in the lua to simulate mut potions, which you can run with many iterations and see what it tends to produce 00:06:10 oh good 00:06:19 I was looking onto hacking with mutation further and that might be nice 00:06:28 but we do need more mutations, overall, before I think we can get to an ideal state 00:06:31 I need to return to transporters soon; I think I'm going to make a dozen or so little loot/encounter vaults, since I can imagine how to make those not too bad 00:07:07 but I'd like to do a larger "layoutized" encompass that also works as D:15 and Depths (like how a few encompass work) 00:07:32 there are a few issues about transporters; I think it might actually be better if monsters didn't path through them/uses them 00:08:09 except when adjacent to the player; this would make them have a similar logic to stairs, where monsters can only use them if they're adjacent to you 00:08:48 and I don't think there's too much benefit from having monsters track through them; it would make it trickier to use them for the kinds of encounters I'm going to do anyhow 00:15:58 sounds interesting 00:16:09 I guess because you stay on the same level, monsters won't necessarily be waiting in the way they are for stairs 00:17:00 well, that is true, but the transporter is one-way 00:17:25 the idea for many of these vaults is that you will transport in and there'll be a transporter out 00:17:31 but not at the same location you arrived 00:17:44 either that or stairs to another level 00:18:15 my concern is more that for vaults with a transporter out, monsters waking up will leave through the transporter 00:18:35 and I can't imagine too many interesting things happening by them just using them as they wander 00:18:40 ah, didn't realize they were one way 00:18:46 this is the more permanent golubria thing 00:19:01 yeah, more because two-way isn't really too interesting 00:19:12 yeah, that makes total sense not to have monsters using them 00:19:48 nothing says you can't make two one-way transporters that feed into each other to make a two-way, but generally that wouldn't do much gameplay-wise 00:20:38 one thing I need to figure out 00:20:53 for autoexplore, how does it know when it's safe to explore with a monster in LOS but behind a wall 00:21:37 it seems to be using the pathfinder to see, based on travel cache, if the player knows for sure that there's no path to monster 00:22:17 not really directly related but I noticed I can explore past some encased monsters in decor vaults 00:22:28 but not in others, and I think it's due to map knowledge 00:23:20 also, sad news 00:23:32 I tried to do a playthrough of linley crawl 1.04f 00:23:49 it crashes sometimes when kobolds throw darts at me (presumeably due to linley code?) 00:23:59 you should submit a PR 00:24:04 not sure how stable this version was 00:24:13 how did you even get it to compile? 00:24:18 I didn't! 00:24:43 for behold, the ~*~*~ Linley Crawl FTP SITE ~*~*~ ftp://ftp.dungeoncrawl.org/ 00:24:52 has binaries for various linley crawl versions 00:24:54 oh heh, yeah I saw that linked on reddit 00:25:28 had to run some dos protected mode exe before running crawl 00:26:02 did you know that the Priest role apparently just gets spells granted to it as it levels? 00:26:25 it worships "the gods", you see (gods not implemented yet) 00:26:39 also you can't train specific skills at all 00:26:59 at least I can't see a way to, but Dodging as a skill does exist (and increase as you gain XP) 00:28:36 The build failed. (mutation_cleanup - 63338c2 #8170 : advil): https://travis-ci.org/crawl/crawl/builds/218317867 00:29:37 huh, wonder what that's about 00:32:05 Unstable branch on CRAWL.XTAHUA.COM updated to: 0.20-a0-949-g916514f (34) 00:32:34 failed on one of the stress tests? 00:32:38 advil: looks like the last thing it tried to do was abyss_short_run 00:32:41 yeah 00:32:44 maybe got mutated in there 00:32:50 and found some exciting bug? 00:32:59 must be 00:34:23 looking at that file now, i am amused it starts with a comment explaining why it's testing a MuBe instead of MuCK. it's just taken for granted that the reader will expect that we would be testing MuCK instead 00:36:38 yeah I can get it to crash with a wretched star 00:38:55 huh, that's what I get for adding asserts 00:39:07 I think it does reveal that bookkeeping for wretched stars wasn't done right 00:40:04 which might explain one of the weird saves I have 00:42:57 advil: the player's level in a mutation can never be negative, is i'm guessing the assert you triggered? 00:43:04 no 00:43:34 wretched stars use RANDOM_CORRUPT_MUTATION to add multiple temporary mutation levels at a time 00:43:50 I had an assert that assumed that only 1 temp level at a time was ever added 00:44:02 based on the way the bookkeeping was done 00:53:12 03advil02 07[mutation_cleanup] * 0.20-a0-947-g5ea7d72: Fix bookkeeping for corruption 10(58 seconds ago, 2 files, 20+ 5-) 13https://github.com/crawl/crawl/commit/5ea7d72ba31a 01:14:31 -!- amalloy_ is now known as amalloy 01:14:35 -!- tcsc_ is now known as tcsc 01:26:55 !tell hellmonk I'd still like temple to appear in hellcrawl given how cool the maps are 01:26:56 alexjurkiewicz: OK, I'll let hellmonk know. 01:29:58 advil: i left a bunch of comments on https://github.com/crawl/crawl/commit/63338c279b70 01:30:26 not sure if that notifies you or what 01:41:58 The build was fixed. (mutation_cleanup - 5ea7d72 #8171 : advil): https://travis-ci.org/crawl/crawl/builds/218328052 01:42:13 heh, in fact it sends me a distinct email for every one 01:42:27 wonder if there's a digest mode or something 01:42:30 thanks for the review 01:43:09 advil: if you'd created a PR you could have gotten a digest 01:43:19 but for drive-by comments on a commit, you get them all 01:46:23 !tell Brannock do you happen to know why the ratskin cloak rats appear to be durably summoned? 01:46:24 rumflump: OK, I'll let brannock know. 01:54:27 rumflump: what do you think they should be? 01:58:31 well, they don't stick around... 01:58:33 they are durably summoned because they shouldn't give xp (obviously), and Brannock evidently thought they shouldn't be abjured 01:58:34 so normal summons? 01:58:49 that's the difference between durable summon and normal summon 01:59:01 abjuration immunity 01:59:23 ah, wild. I've gotten durably summoned things from god wrath, and the sum effect *appeared* to be "this summon doesn't go away" 01:59:31 well 01:59:33 I never checked though, it just seemed obvious and true 01:59:51 technically it is possible to separate those two effects, but most durable summons are also permanent 02:00:00 maybe it is incorrect for ratskin to separate them 02:00:29 i can't think of anything else that does 02:00:58 yeah, me and the player that I'm spectating both thought the rats would be permanent. maybe enough to mention in the cloak and/or abil description that the summons are non permanent? 02:01:01 maybe durably summoned shouldn't have any icon, or it should just say "no xp" rather than calling itself a summon type 02:03:54 rumflump: i think the idea that anything in the game could summon an unlimited number of permanent allies is implicitly impossible. calling it out specifically is silly. if there's confusion, it should be resolved by not explicitly saying "durable", not by explicitly saying "not durable" 02:05:03 true. it seemed plausible since they're only rats - but admittedly I didn't give it much thought, I just saw the little icon and assumed 02:06:30 <|amethyst> IMO ratskin rats should be displayed the same as S2S snakes 02:06:53 <|amethyst> those don't say "durably summoned", do they? 02:07:10 |amethyst: good comparison 02:12:13 |amethyst: how do we flavour the rats' departure, then? returning to the shadows of the dungeon or something? 02:19:36 imo instead of being the ratskin cloak it should be a cloak literally made of rats, like a rat king except in the shape of a cloak 02:19:52 and when you evoke +rats youre grabbing a ball of rats off the cloak and throwing it 02:20:21 <|amethyst> but fortunately they continue to breed so it doesn't run out 02:20:32 03amalloy02 07* 0.20-a0-950-g92a50c4: Mark ratskin cloak's summons correctly (rumflump, |amethyst) 10(62 seconds ago, 2 files, 6+ 2-) 13https://github.com/crawl/crawl/commit/92a50c4e500a 02:29:27 incidentally, the "monkeys on a keyboard can produce intelligent results" thing? I just made a username, expecting it to come out as awiofket or the like, but I mashed the keyboard as usual and got "waned" 02:40:03 |amethyst: can you think of any cases that would trigger https://github.com/crawl/crawl/blob/master/crawl-ref/source/mon-death.cc#L1887-L1888 ? i'd like to make monster_die just take a monster& instead of a monster* but it's called so often i don't know how to prove it's actually safe 02:40:39 the monkeys win again! 02:41:33 minmay: like the rat king in discworld that is a bunch of rats with their tails tied together that gain some weird psychic power via that? 02:41:44 and have some sort of descriptor that is escaping me 02:42:48 also, i think ratskin cloak is cool, even if the rats are largely useless by the time you have the evo to reliably summon a lot of decent ones 02:42:58 cranium rats 02:43:23 oh, what were the rats in torment called? 02:43:38 no that's from torment 02:43:51 I was just hoping to get lucky and they were named the same in discworld 02:43:51 ah 02:43:52 haha 02:44:01 might be why i thought of torment then 02:44:10 but no, they weren't cranium rats in discworld 02:44:35 they were just rats 02:45:31 oh 02:45:38 "rat king" is actually the term 02:45:41 apparently 02:45:45 https://en.wikipedia.org/wiki/Rat_king 03:10:13 Unstable branch on crawl.jorgrun.rocks updated to: 0.20-a0-950-g92a50c4 (34) 03:24:54 Unstable branch on crawl.beRotato.org updated to: 0.20-a0-950-g92a50c4 (34) 03:28:24 03amalloy02 07* 0.20-a0-951-ga19df7c: Add some parens around a macro argument 10(68 seconds ago, 1 file, 5+ 5-) 13https://github.com/crawl/crawl/commit/a19df7c6b35d 03:33:38 New branch created: pull/507 (1 commit) 13https://github.com/crawl/crawl/pull/507 03:33:38 03amalloy02 07https://github.com/crawl/crawl/pull/507 * 0.20-a0-952-g866c464: Make monster_die take a monster& instead of a monster* 10(39 minutes ago, 32 files, 310+ 311-) 13https://github.com/crawl/crawl/commit/866c464a52a4 04:10:07 Unstable branch on crawl.jorgrun.rocks updated to: 0.20-a0-951-ga19df7c (34) 04:10:26 "Die &monster, you don't const in this world!" 04:10:34 ^ credit me if you use this 05:01:02 -!- amalloy is now known as amalloy_ 07:09:18 -!- dexap is now known as paxed 10:00:45 -!- Palyth_ is now known as Palyth 10:21:59 Ash Scrying detects monsters outside LOS 13https://crawl.develz.org/mantis/view.php?id=10996 by Le_Nerd 10:31:09 do summoning staves still abjure on hit? 10:40:06 !source player::max_stat 10:40:06 1/1. https://github.com/crawl/crawl/blob/master/crawl-ref/source/player-stats.cc#L70 10:40:30 the docstring here implies it should consider all mutations with base=true, but _stat_modifier looks only at innate mutations 10:40:34 wonder which is correct 10:41:32 seems like the docstring should be, but I really have no idae 10:41:38 rumflump: no 10:41:44 *idea 10:42:27 !learn edit staff of summoning[1 s/ and.*skill// 10:42:28 staff of summoning[1/1]: Enhances Summoning spells. Also provides a level of warding. 10:43:13 in fact, are there even any innate stat mutations? 10:44:14 advil: like species ones? ni 10:44:15 no 10:44:25 yeah, that's what I mean 10:44:33 do you know if there were at some point? 10:45:09 maybe MUT_STRONG_STIFF 10:47:37 not that I know of. Maybe demonspawn could get some? 10:47:56 stats don't make sense as racials 10:48:09 since they already have settings for that 10:52:48 hmm MUT_THIN_SKELETAL_STRUCTURE increases dex actually 10:53:00 looks like there are a few obsolete ones as well 10:53:34 rough black scales 10:54:09 I did mean to include ds muts in "innate" (since they're all lumped together with species muts) 10:55:51 ah! 10:57:13 if thin skel is the final remaining one, are you thinking of a change? perhaps you can score some millimarvins 10:57:32 no, I'm just trying to clean up mutation stuff 10:57:52 though I don't know if thing skeletal structure is the greatest ds mut 10:58:14 I'm still running off millimarvins from the LO deletion thing :-) 10:58:27 ??thing skeletal structure 10:58:27 thing skeletal structure ~ thin skeletal structure[1/1]: Dex +2/4/6 Stealth +25/50/75 10:58:52 -!- zkyp_ is now known as zkyp 11:01:55 that's a "scales" mut right? 11:02:24 yes 11:10:11 advil: it's not, but the stealth+ is kinda nice 11:10:34 It's not the worst, I'd say 11:10:52 probably the best has to be the +EV one, since it also gives rMsl at the top end 11:11:46 yeah, it's not terrible, iirc once I had nightstalker + thin skeleton which was great 11:14:27 think a PR to make thinskel give EV instead of dex would go anywhere? 11:16:35 my guess is it would probably be too (i.e. slightly more) similar to repulsion field 11:17:33 ??scales facet 11:17:33 I don't have a page labeled scales_facet in my learndb. 11:29:41 is there any sort of crawlcode convention for when something is an instance method vs a global function? I ask b/c it seems like this is done a lot less than I might have expected, but this might just be history 11:53:49 advil: I have not been able to discerne a pattern. My preference would be for instance methods where they make sense 12:00:20 yeah, that's what I prefer too 12:17:51 ^dc DrunkenThon 12:17:58 ^rc DrunkenThon 12:17:59 http://crawl.berotato.org/crawl/rcfiles/crawl-git/DrunkenThon.rc 12:18:12 !rc DrunkenThon 12:18:13 http://crawl.akrasiac.org/rcfiles/crawl-git/DrunkenThon.rc 12:43:04 huh i wonder if that scrying bug is barachi-related 12:45:34 probably 12:50:00 looks like it was already broken for nightstalker characters before the existence of barachi, maybe 12:50:23 in that you can see stuff out past range 4 while scrying too 12:53:05 ah it's just get_nearby_monsters that does it wrong by the look of it, so only the monster list leaks info and everything else is handled correctly 12:56:42 MarvinPA: it looks to me like for nightstalker chars ash lets you detect (not scry) items/monster outside of radius 4 12:56:51 not sure if that is a surprise 12:57:27 er 12:57:34 yeah, i think that's fine 12:57:46 what i mean is, before barachim that was true. now, of course, as you say it's broken for scry too 12:58:58 i guess it'd maybe be fine to let scrying go out to radius 7 if you have <7 los but at the moment it's buggy and inconsistent (and it'd make it even harder to tell whether things are in "real" vision) 13:03:51 i guess barachi made a bunch of things work differently in weird ways? 13:04:40 like being abyssed brings an 8x8 area into the abyss for all species now instead of 7x7, monsters get distracted by gold that's out at range 8 under gozag 13:06:20 MarvinPA: yes, there are a number of uses of LOS_RADIUS that should be fixed 13:06:58 i disagree with the comment on that saying some brave soul should find/replace with LOS_MAX_RADIUS or whatever; all uses should be audited to determine what they should actually check 13:09:43 03amalloy02 07* 0.20-a0-952-gd383355: Add a getter for los_radius 10(44 seconds ago, 5 files, 11+ 4-) 13https://github.com/crawl/crawl/commit/d383355ad0cb 13:10:51 seems like a pain yeah 13:15:13 MarvinPA: another example: it looks like qazlal's ab works on clouds at distance 8? but i can't quite figure out how to place a friendly cloud at that distance, since you generally can't reach out of LOS and clouds out there dissipate fast anyway 13:15:32 yeah, i was looking at that one too briefly 13:16:04 and it only works at all on friendly clouds now right? instead of placing hostiles from monster clouds 13:16:17 yeah 13:18:37 i guess it's just an ash buff generally, letting everyone detect monsters passively up to range 8 13:22:22 passively? i thought this only worked for scrying 13:22:49 it's broken separately for passive detection :P 13:22:55 !source player_monster_detect_radius 13:22:56 1/1. https://github.com/crawl/crawl/blob/master/crawl-ref/source/player.cc#L7595 13:22:57 it is? it seems okay for me 13:23:08 you need 160 piety 13:23:17 i have 200 13:23:43 oh, i bet i know 13:24:15 MarvinPA: monster detection doesn't work when time is stopped for wizmode 13:24:16 apparently 13:24:21 aha 13:24:51 i was trying to ensure monsters wouldn't disrupt my LOS measurements by moving around... 13:25:36 detecting monsters at range 8 seems like a pretty strong buff 13:25:55 since it enables you to avoid entering their LOS at all, if you are trying to minimize conflict 13:25:57 amalloy: use stationary monsters? 13:26:17 Lasty: how would you place a stationary monster that's not yet in LOS 13:26:33 couldn't you place one then leave los? 13:26:43 the goal was testing ash monster detection 13:27:03 this is a rhetorical question; i know it's possible but it's not worth the trouble 13:27:08 ah 13:28:02 Unstable branch on crawl.akrasiac.org updated to: 0.20-a0-951-ga19df7c (34) 13:28:08 MarvinPA: are you planning to do the LOS_RADIUS audit? 13:28:23 i'm just fixing these two ash things right now 13:28:43 might come back to the rest of it later but if you'd like to fix some, go for it :P 13:30:36 MarvinPA: okay. at least edit the comment on LOS_RADIUS so that if neither of us gets to it, anyone who sees the todo will do the right thing instead of the wrong thing? 13:31:13 sure 13:37:39 03MarvinPA02 07* 0.20-a0-953-g5e11c12: Fix Ashenzari passive monster detection range 10(12 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/5e11c120209b 13:37:39 03MarvinPA02 07* 0.20-a0-954-g2ca7e2b: Unbrace 10(11 minutes ago, 1 file, 0+ 2-) 13https://github.com/crawl/crawl/commit/2ca7e2b0430d 13:37:39 03MarvinPA02 07* 0.20-a0-955-g7bb5b86: Fix a monster list info leak when scrying 10(11 minutes ago, 3 files, 4+ 3-) 13https://github.com/crawl/crawl/commit/7bb5b86b04cb 13:38:36 i like the doubly-out-of-date comment on species vision range 13:39:00 firstly that all species have the same vision range, and secondly that it's default 8 13:58:59 03MarvinPA02 07* 0.20-a0-956-gcdeeb85: Don't flash the screen when out-of-LOS monsters cast LOS spells (#10995) 10(4 minutes ago, 1 file, 2+ 1-) 13https://github.com/crawl/crawl/commit/cdeeb85f274f 14:09:27 Unstable branch on crawl.jorgrun.rocks updated to: 0.20-a0-956-gcdeeb85 (34) 14:19:46 Sticky flames works on ghosts created by lost souls 13https://crawl.develz.org/mantis/view.php?id=10997 by Lavandula 14:39:20 ziggurnaut (L13 DgCj) (Lair:4) 14:59:10 03Lasty02 07* 0.20-a0-957-g47ad1fd: Remove the ability to cancel evoked invis prematurely. 10(7 minutes ago, 4 files, 37+ 25-) 13https://github.com/crawl/crawl/commit/47ad1fdc51cf 15:09:21 Unstable branch on crawl.jorgrun.rocks updated to: 0.20-a0-957-g47ad1fd (34) 16:24:43 ziggurnaut (L13 HOSu) (Lair:5) 18:15:46 Unstable branch on underhound.eu updated to: 0.20-a0-957-g47ad1fd (34) 18:48:11 -!- mikee__ is now known as mikee 18:59:32 // There's probably a reason for this. I don't know it. 18:59:32 if (going_up) 18:59:32 seen_monsters_react(); 18:59:52 // Dunno why this is on going down only. 18:59:52 if (!going_up) 18:59:52 { 18:59:52 moveto_location_effects(whence); 18:59:52 // Clear list of beholding and constricting/constricted monsters. 18:59:53 you.clear_beholders(); 18:59:53 you.stop_constricting_all(); 18:59:54 you.stop_being_constricted(); 18:59:54 trackers_init_new_level(true); 18:59:55 } 18:59:56 good comments 19:00:30 <|amethyst> Lasty: do you have the crawlcode password? 19:00:59 -!- n1k is now known as n1 19:02:17 |amethyst: nope 19:02:19 <|amethyst> Do you want it? :) 19:02:23 haha, sure 19:06:15 aaaand tweeter 19:06:18 *tweeted 19:13:42 -!- MIBE is now known as mibe 20:10:26 -!- amalloy is now known as amalloy_ 20:48:19 -!- GiantOwl is now known as Kalir 21:27:02 -!- amalloy_ is now known as amalloy 21:47:50 03advil02 07[mutation_cleanup] * 0.20-a0-948-gee82781: Incorporate amalloy's feedback 10(4 minutes ago, 64 files, 634+ 630-) 13https://github.com/crawl/crawl/commit/ee82781f6cc6 22:09:19 03Lasty02 07[dpegs_dynamic_monsters] * 0.20-a0-967-gdcb5b96: Merge master 10(6 hours ago, 0 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/dcb5b9619323 22:09:19 03Lasty02 07[dpegs_dynamic_monsters] * 0.20-a0-968-g38af03e: Add multiple levels of bezotting 10(43 minutes ago, 5 files, 64+ 19-) 13https://github.com/crawl/crawl/commit/38af03eb2369 22:09:19 03Lasty02 07[dpegs_dynamic_monsters] * 0.20-a0-969-g5a5da1e: Bezot monsters when you take stairs 10(2 minutes ago, 1 file, 9+ 0-) 13https://github.com/crawl/crawl/commit/5a5da1e99219 22:10:35 !tell dpeg check out my latest commits 22:10:35 Lasty: OK, I'll let dpeg know. 22:10:47 !tell dpeg in the dynamic monsters branch 22:10:47 Lasty: OK, I'll let dpeg know. 22:12:28 -!- amalloy is now known as amalloy_ 22:22:21 I hope someone stair dances V:5 and reports back 22:25:09 I bet people would still do it 22:25:20 stairdancing V:5 has been a bad idea for about 10 years and it's still the most popular strategy 22:25:34 Experimental (dpegs_dynamic_monsters) branch on crawl.beRotato.org updated to: 0.20-a0-969-g5a5da1e 22:26:46 that answers the question I was going to ask this week on whether that was an active experimental still