00:22:44 <gammafunk> commit 034ecfb8ba6db63ec7b484594fc94d1ccee6eed2
00:22:44 <gammafunk> Author: gammafunk <gammafunk@gmail.com>
00:22:44 <gammafunk> Date:   Sun Apr 2 23:21:32 2017 -0500
00:22:44 <gammafunk> --no-edit
00:22:49 <gammafunk> some days you just don't got it
02:45:38 <Gretell> Monster database of master branch on crawl.develz.org updated to: 0.20-a0-947-g2784f4f
02:46:05 -!- amalloy_ is now known as amalloy
03:48:44 -!- amalloy is now known as amalloy_
05:48:41 <Cheibriados> New branch created: tombhatch (3 commits) 13https://github.com/crawl/crawl/tree/tombhatch
05:48:41 <Cheibriados> 03gammafunk02 07[tombhatch] * 0.20-a0-948-g7dde927: Implement escape hatches with fixed destinations 10(81 minutes ago, 5 files, 116+ 15-) 13https://github.com/crawl/crawl/commit/7dde927ddfbb
05:48:41 <Cheibriados> 03gammafunk02 07[tombhatch] * 0.20-a0-949-g1998959: Turn some stairs in Tomb into escape hatches with fixed destinations 10(52 minutes ago, 1 file, 50+ 28-) 13https://github.com/crawl/crawl/commit/19989597caab
05:48:41 <Cheibriados> 03gammafunk02 07[tombhatch] * 0.20-a0-950-g62ac7e3: Save compatability for the change of stone stairs into hatches in Tomb 10(50 minutes ago, 5 files, 223+ 0-) 13https://github.com/crawl/crawl/commit/62ac7e3c57ba
05:49:32 <gammafunk> !tell MarvinPA The tombhatch branch has an implementation of Tomb with fixed-destination hatches instead of stone stairs (except I left the gauntlet ones in place; probably shouldn't have, but that can be changed).
05:49:33 <Sequell> gammafunk: OK, I'll let marvinpa know.
05:50:29 <gammafunk> !tell marvinpa It has working save compat that just loads a stone stairs tomb through a save compat vault, which is pretty simple and works
05:50:30 <Sequell> gammafunk: OK, I'll let marvinpa know.
05:51:17 <gammafunk> !tell MarvinPA But I didn't think much about where to actually put the hatches, since I wanted to just get it working; feel free to make any follow-up commits as you see fit
05:51:18 <Sequell> gammafunk: OK, I'll let marvinpa know.
05:52:07 <gammafunk> oh, oops, *compatibility in that commit, but I can rebase that later
06:35:48 <travis-ci> The build passed. (tombhatch - 62ac7e3 #8166 : gammafunk): https://travis-ci.org/crawl/crawl/builds/218005670
08:13:02 <Rotatell> ziggurnaut (L13 HOSu)  (Lair:5)
09:28:34 <johnstein> !crash
09:28:35 <Sequell> 16820. ziggurnaut, XL13 HOSu, T:22394 (milestone): http://crawl.berotato.org/crawl/morgue/ziggurnaut/crash-ziggurnaut-20170403-121302.txt
09:55:16 <advil> it's rc related, timeout/hup at a prompt in rc lua (or something like that)
10:13:23 <advil> !source _disallow_mutate
10:13:23 <Sequell> 1/1. https://github.com/crawl/crawl/blob/master/crawl-ref/source/potion.cc#L675
10:13:46 <advil> this seems problematic on a bunch of levels
10:19:54 <advil> maybe it's just the docstring that's wrong
10:19:58 <advil> I guess the pointer stuff must be ok for some c++ reason I don't appreciate since it's done everywhere
10:31:15 <|amethyst> advil:  it's being used as an outparameter
10:31:21 <advil> yeah
10:31:24 <advil> I sort of worked it out
10:31:43 <advil> it's just the @return docstring that's wrong for that function
10:31:49 <|amethyst> ?
10:31:55 <|amethyst> oh
10:32:21 <advil> it returns false if the player can mutate
10:32:28 <advil> it's used correctly in places where it's used
10:32:48 <advil> but I thought the reason was being generated in the wrong case
10:33:00 <|amethyst> yeah
10:33:00 <advil> stupid c++ question: what happens when reason is nullptr?
10:33:31 <|amethyst> advil:  if (reason)  is false
10:33:36 <|amethyst> so it doesn't store a reason
10:33:52 <advil> oh, right
10:34:14 <|amethyst> btw, I'd consider changing !undead_mutation_rot() to  you.can_safely_mutate()
10:36:04 <|amethyst> as an advantage, you can then change that  !you.undead_state(false) to you.can_safely_mutate(false)
10:36:28 <advil> undead_mutation_rot is in fact just !you.can_safely_mutate()
10:36:30 <|amethyst> thus keeping more of the "who can mutate when" logic in can_safely_mutate rather than here
10:36:33 <|amethyst> yeah :)
10:36:36 <advil> could remove it entirely
10:36:48 <advil> as usual, this project of mine has spiraled out of control
10:37:12 <|amethyst> remove it entirely?
10:37:17 <|amethyst> as in, allow mummies and liches to mutate?
10:37:26 <advil> no, remove the function undead_mutation_rot
10:37:37 <|amethyst> ah, possibly
10:37:40 <advil> well, I guess it has a different semantics
10:37:48 <advil> since maybe some future undead wouldn't rot
10:37:55 <|amethyst> I guess there could be some future race that can't mutate but doesn't get ... yeah
10:37:59 <advil> same extensional semantics right now
10:46:38 <advil> |amethyst: "you can then change that  !you.undead_state(false) to you.can_safely_mutate(false)" do you mean you.can_safely_mutate(true)? (for lichform)
10:47:33 <advil> oh nm
10:47:38 <advil> didn't read the full string
10:47:42 <advil> I'm not very with it this morning
10:58:04 <advil> wow "If I am playing to win all the [Ds] mutation options"
11:30:52 -!- amalloy_ is now known as amalloy
11:32:25 <amalloy> i could believe "win at least one Ds game with each Ds mutation"
11:32:43 <amalloy> "win a game with every possible set of 5 muts" would be harder to swallow
12:11:47 <MarvinPA> !tell gammafunk nice! i'd had some vague ideas on how they'd be placed when thinking about it in the past but it's probably something that'd really need to be played with to see what works anyway, will take a look later
12:11:47 <Sequell> MarvinPA: You have 3 messages. Use !messages to read them.
12:11:48 <Sequell> MarvinPA: OK, I'll let gammafunk know.
12:13:36 <MarvinPA> also i keep looking for the point where i disconnected in the logs and getting confused (although it's definitely much more readable without joins/parts)
12:42:16 -!- bannakaf_ is now known as bannakaffalatta
13:11:38 <Cheibriados> 03Floodkiller02 {Brannock} 07* 0.20-a0-948-g2d876bd: Remove contamination from Haste. 10(24 hours ago, 3 files, 4+ 9-) 13https://github.com/crawl/crawl/commit/2d876bdc7741
13:45:03 <Brannock_> !seen SteelNeuron
13:45:03 <Sequell> I last saw SteelNeuron at Mon Apr  3 10:01:15 2017 UTC (7h 43m 48s ago) quitting, saying 'Client Quit'.
13:45:18 -!- Brannock_ is now known as Brannock
14:09:27 <Jorgrell> Unstable branch on crawl.jorgrun.rocks updated to: 0.20-a0-948-g2d876bd (34)
15:43:51 <Cheibriados> 03Brannock02 07* 0.20-a0-949-g916514f: Catch a few Barachian remnants 10(15 seconds ago, 9 files, 11+ 11-) 13https://github.com/crawl/crawl/commit/916514fd7d7c
16:09:17 <Jorgrell> Unstable branch on crawl.jorgrun.rocks updated to: 0.20-a0-949-g916514f (34)
17:04:22 -!- gressup_ is now known as gressup
18:03:28 <Cheibriados> 03Floodkiller02 07https://github.com/crawl/crawl/pull/487 * 0.20-a0-958-g5cf61c2: Merge remote-tracking branch 'upstream/master' into cynos 10(3 minutes ago, 0 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/5cf61c2be6bd
18:16:01 <Lantell> Unstable branch on underhound.eu updated to: 0.20-a0-949-g916514f (34)
18:53:24 -!- Pacra_ is now known as Pacra
19:58:03 <minmay> j
20:13:51 -!- 5EXAARWAD is now known as adelrune
20:56:17 -!- amalloy is now known as amalloy_
21:51:54 <Yermak> Your phial of floods has recharged. This wand has 1 charge left.
21:51:59 <Yermak> This message is weird.
21:52:20 <Yermak> nvm, my bad, all ok
21:53:11 <advil> weird message ordering?
22:01:39 <gammafunk> ^vps
22:07:25 <geekosaur> ^status
22:07:26 <Rotatell> 49 Crawlers. CBRO disk usage=80% (135GB) | RAM usage=38% (4GB)| uptime/CPU= 22:07:25 up 32 days,  2:45,  6 users,  load average: 0.73, 0.94, 0.98 (4 Cores) http://status.berotato.org
22:07:34 <geekosaur> eventually you might even remember that...
22:10:32 <advil> I think he changed it at some point
22:11:07 <geekosaur> yes, from ^vps to ^status
22:11:41 <geekosaur> (I'm noodging because I've corrected it before :)
22:12:38 <gammafunk> I'm just using my geekosaur-based autocorrect
22:14:00 * geekosaur is sooo tempted to suggest you'll get crabs }:>
22:33:20 <Brannock> ??crab rule
22:33:21 <Sequell> crab rule[1/2]: no more crabs.
22:55:49 <minmay> ??crab rule[2
22:55:49 <Sequell> crab rule[2/2]: http://s16.postimg.org/citg7e7n9/image.png
22:56:23 <minmay> !learn add crab_rule There is only one rule and it IS crab
22:56:23 <Sequell> crab rule[3/3]: There is only one rule and it IS crab
23:04:02 <gammafunk> should link to the image imo
23:22:26 -!- amalloy_ is now known as amalloy
23:37:46 <Cheibriados> New branch created: mutation_cleanup (1 commit) 13https://github.com/crawl/crawl/tree/mutation_cleanup
23:37:46 <Cheibriados> 03advil02 07[mutation_cleanup] * 0.20-a0-945-g63338c2: Rework the mutation api and add lua bindings 10(16 minutes ago, 41 files, 668+ 239-) 13https://github.com/crawl/crawl/commit/63338c279b70
23:38:15 <advil> it's unclear why I'm doing this to myself
23:40:34 <advil> that's still a wip, but done enough to push somewhere
23:45:32 <gammafunk> nice, some lua tests
23:45:44 <gammafunk> but wow, rip line length
23:46:08 <gammafunk> advil: you know lua is pretty free about letting you wrap lines
23:46:17 <gammafunk> so you can end long strings with ..
23:46:27 <gammafunk> and resume on the next line with indent
23:46:58 <advil> good to know
23:47:08 <advil> this is literally the first lua code I have written in my life
23:47:12 <gammafunk> looks like a nice refactor though
23:47:55 <advil> good to hear :-) at some point I was starting to wonder what the point was
23:48:01 <advil> changes kept cascading
23:48:52 <gammafunk> heh, yeah, and to be clear I've not read it carefully, I'm just offering moral support
23:49:03 <advil> yeah
23:49:20 <advil> it's a bit long
23:49:24 <gammafunk> I do remember saying nearly exactly what you said after that commit when I did my last refactor project
23:49:30 <advil> heh
23:49:55 <advil> I need to add some more tests before I'll be confident it's doing everything it's supposed to, but luckily adding tests isn't too hard now
23:50:10 <amalloy> another thing making your lua lines rather long: you're using tabs to indent rather than the two-space indent used elsewhere in the codebase
23:50:42 <advil> well, it should be 4 spaces rather than tabs, but that's true
23:50:52 <advil> is 2 space indent for lua a requirement? :-)
23:51:02 <amalloy> what do you mean, "should"?
23:51:21 <amalloy> i guess we're not consistent
23:51:32 <amalloy> i looked at autofight.lua first, arbitrarily, and saw 2
23:51:34 <rumflump> will util/checkwhite fix all the tabs for advil, or will it turn them into 4space?
23:51:39 <advil> ugh you're right, there are literal tabs there
23:51:44 <advil> that's annoying
23:52:04 <amalloy> but delays.lua has 4-space indents
23:52:30 <advil> and checkwhite -a turned it into 8 spaces?
23:58:02 <gammafunk> I think 2-spaces is a kind of standard
23:59:08 <advil> I'm not very into the aesthetics of 2-space indents
23:59:23 <gammafunk> yeah, not sure how it became so common