00:00:02 -!- omarax has quit [Remote host closed the connection] 00:01:45 -!- Blazinghand has joined ##crawl-dev 00:03:10 -!- bonghitz has quit [Ping timeout: 256 seconds] 00:04:26 -!- debo_ has quit [Ping timeout: 258 seconds] 00:04:50 -!- simmarine has quit [Read error: Connection reset by peer] 00:06:08 -!- destroythecore has quit [Read error: Connection reset by peer] 00:13:26 -!- ffefefafa has quit [Quit: Konversation terminated!] 00:45:49 -!- KurzedMetal has quit [Ping timeout: 240 seconds] 00:51:55 -!- nikheizen has joined ##crawl-dev 01:00:02 -!- omarax has quit [Remote host closed the connection] 01:05:19 -!- hellmonk has quit [Quit: Page closed] 01:06:49 -!- bencryption has quit [Ping timeout: 240 seconds] 01:12:16 -!- Menche_ is now known as Menche 01:13:33 -!- Kalir has quit [Quit: I'M OUT SON. PEACE, LOVE, EXPLOSIONS.] 01:15:47 -!- Laraso has quit [Ping timeout: 246 seconds] 01:20:21 -!- Furril has quit [Ping timeout: 260 seconds] 01:26:49 -!- ByronJohnson has quit [Ping timeout: 240 seconds] 01:28:46 -!- ByronJohnson has joined ##crawl-dev 01:29:29 -!- Avack has quit [Quit: Leaving.] 01:31:41 Unstable branch on CRAWL.XTAHUA.COM updated to: 0.20-a0-893-g832831a (34) 01:32:43 -!- LordSloth has quit [Quit: Going offline, see ya! (www.adiirc.com)] 01:40:04 -!- iFurril has quit [Ping timeout: 256 seconds] 01:46:57 -!- Krakhan has quit [Ping timeout: 260 seconds] 01:47:57 -!- orbisvicis has quit [Ping timeout: 260 seconds] 01:49:35 -!- Shukka has quit [Quit: Leaving] 01:59:32 -!- Smello has quit [Ping timeout: 246 seconds] 02:00:02 -!- omarax has quit [Remote host closed the connection] 02:02:59 -!- Lasty has quit [Read error: Connection reset by peer] 02:04:40 -!- Pacra has quit [Read error: Connection reset by peer] 02:51:04 -!- ZiBuDo has quit [Ping timeout: 268 seconds] 02:52:27 -!- ontoclasm has quit [Quit: Leaving.] 02:56:51 -!- CanOfWorms has quit [Quit: ChatZilla 0.9.92 [Firefox 3.6.28/20120306064154]] 03:00:09 -!- omarax has quit [Remote host closed the connection] 03:12:20 -!- GauHelldragon has quit [Ping timeout: 246 seconds] 03:20:46 -!- VoidFox has quit [Quit: PanicBNC account has been auto selected for removal due to login inactivity.] 03:21:35 -!- Amnesiac has quit [Ping timeout: 260 seconds] 03:27:11 Unstable branch on crawl.beRotato.org updated to: 0.20-a0-893-g832831a (34) 03:36:50 -!- Smello has quit [Ping timeout: 246 seconds] 03:38:16 -!- bgiannan_ has joined ##crawl-dev 03:41:30 -!- Amnesiac_ is now known as Amnesiac 03:41:36 -!- MarvinPA_ has quit [Read error: Connection reset by peer] 03:43:02 -!- bgiannan_ has quit [Ping timeout: 256 seconds] 03:56:18 -!- ontoclasm has joined ##crawl-dev 04:00:03 -!- omarax has quit [Remote host closed the connection] 04:17:07 -!- Doesnty has quit [Read error: Connection reset by peer] 04:20:43 -!- zxc has quit [Read error: Connection reset by peer] 04:36:58 -!- amalloy_ is now known as amalloy 04:40:49 -!- glaas has quit [Ping timeout: 258 seconds] 04:49:04 -!- ZiBuDo has joined ##crawl-dev 04:52:35 -!- scummos| has quit [Ping timeout: 264 seconds] 04:53:53 -!- ZiBuDo has quit [Ping timeout: 256 seconds] 05:00:03 -!- omarax has quit [Remote host closed the connection] 05:10:36 -!- elliptic has quit [Quit: Leaving] 05:29:32 -!- Smello has quit [Ping timeout: 246 seconds] 05:31:39 -!- adibis has quit [Ping timeout: 260 seconds] 05:38:58 -!- bgiannan_ has joined ##crawl-dev 05:39:13 -!- Ge0ff has quit [Quit: Leaving] 05:39:49 -!- hyperbolic has quit [Ping timeout: 260 seconds] 05:43:32 -!- bgiannan_ has quit [Ping timeout: 246 seconds] 05:43:55 -!- mibe has quit [Ping timeout: 260 seconds] 05:44:01 -!- rossi has quit [Ping timeout: 260 seconds] 05:56:41 -!- Insomniak` has quit [Quit: I like to rock] 05:59:04 -!- Blazinghand has quit [Quit: Leaving] 06:00:02 -!- omarax has quit [Remote host closed the connection] 06:19:56 -!- Dom_ has joined ##crawl-dev 06:27:37 -!- ProzacElf has quit [Ping timeout: 260 seconds] 06:44:32 -!- geekosaur has quit [Excess Flood] 06:45:17 -!- geekosaur has joined ##crawl-dev 06:50:59 -!- ZiBuDo has joined ##crawl-dev 06:51:50 -!- jefus- has joined ##crawl-dev 06:55:41 -!- ZiBuDo has quit [Ping timeout: 256 seconds] 06:55:52 -!- jeefus has quit [Ping timeout: 260 seconds] 06:59:47 -!- chenzfroff has quit [Remote host closed the connection] 07:00:02 -!- omarax has quit [Remote host closed the connection] 07:08:49 -!- hittemvvvmobile has quit [Ping timeout: 268 seconds] 07:10:10 -!- schistosomatic has quit [Quit: Page closed] 07:12:49 -!- bonghitz has quit [Remote host closed the connection] 07:15:13 -!- crate has quit [Ping timeout: 246 seconds] 07:25:26 -!- rj54x has quit [Quit: Page closed] 07:30:24 -!- eb has quit [Ping timeout: 260 seconds] 07:30:30 -!- geekosaur has quit [Excess Flood] 07:31:18 -!- geekosaur has joined ##crawl-dev 07:33:27 -!- geekosaur has quit [Excess Flood] 07:34:49 -!- geekosaur has joined ##crawl-dev 07:39:41 -!- bgiannan_ has joined ##crawl-dev 07:44:45 -!- bgiannan_ has quit [Ping timeout: 264 seconds] 07:47:45 -!- rossi has quit [Ping timeout: 264 seconds] 07:52:11 -!- zxc has joined ##crawl-dev 08:00:02 -!- omarax has quit [Remote host closed the connection] 08:04:48 -!- eb_mobile has quit [Ping timeout: 240 seconds] 08:09:00 -!- eb_mobile has quit [Read error: Connection reset by peer] 08:11:10 -!- Fixer has joined ##crawl-dev 08:22:48 -!- hittemvvvhard has quit [Ping timeout: 240 seconds] 08:31:34 -!- Shimatora has quit [Ping timeout: 264 seconds] 08:31:38 -!- Shimatora_ is now known as Shimatora 08:50:16 -!- bannakaf_ has quit [Read error: Connection reset by peer] 08:52:17 -!- waat has quit [Ping timeout: 260 seconds] 08:56:00 -!- ZiBuDo has joined ##crawl-dev 09:00:02 -!- omarax has quit [Remote host closed the connection] 09:00:21 -!- ZiBuDo has quit [Ping timeout: 256 seconds] 09:01:34 -!- Shimatora has quit [Ping timeout: 264 seconds] 09:01:44 -!- Shimatora_ is now known as Shimatora 09:06:22 -!- Shimatora has quit [Ping timeout: 264 seconds] 09:06:31 -!- Shimatora__ is now known as Shimatora 09:06:35 -!- Shimatora has quit [Client Quit] 09:06:58 -!- Shimatora_ has quit [Ping timeout: 264 seconds] 09:07:34 -!- bannakaffalatta has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 09:09:58 -!- iFurril has quit [Ping timeout: 264 seconds] 09:20:14 -!- Amnesiac has quit [Quit: Page closed] 09:39:12 -!- TZer0 has quit [Ping timeout: 260 seconds] 09:41:08 -!- nikheizen has quit [Quit: leaving] 09:44:48 -!- rossi has quit [Ping timeout: 260 seconds] 09:48:43 -!- TZer0 has joined ##crawl-dev 10:00:02 -!- omarax has quit [Remote host closed the connection] 10:17:00 -!- rumflump has quit [Ping timeout: 260 seconds] 10:54:31 New branch created: pull/496 (1 commit) 13https://github.com/crawl/crawl/pull/496 10:54:31 03advil02 07https://github.com/crawl/crawl/pull/496 * 0.20-a0-894-gd5b8bf2: Filter distant duplicates in stash search (Siegurt) 10(13 minutes ago, 2 files, 47+ 6-) 13https://github.com/crawl/crawl/commit/d5b8bf27b722 10:55:03 that's in PR form because it's still fairly first-draft-y, so feedback would be helpful if anyone has time 10:56:07 possibly it should be toggle-able 10:56:26 <|amethyst> advil: haven't tested it, but the sorting you do there 10:56:42 <|amethyst> advil: does that mean results will always be sorted by name, or do they get re-sorted later? 10:56:47 they get resorted 10:56:58 that's why I did it in place (although maybe I just shouldn't do that) 10:57:29 <|amethyst> and why doesn't it apply to missiles? 10:58:10 there were two issues: the stacking was a bit tricky to collapse, and I realized that it's a much more normal use case to see where all the missiles of a certain type are 10:58:27 <|amethyst> but scrolls, potions, etc? 10:58:31 hm 10:58:36 right, yeah 10:58:40 should be the same case 10:58:55 perhaps it should collapse only weapons & armour 10:58:57 <|amethyst> also, nothing to do with your code, but 10:59:09 <|amethyst> I think that copy constructor can be removed so we get the default 10:59:30 <|amethyst> and the operator= 10:59:43 ah good point 11:00:02 -!- omarax has quit [Remote host closed the connection] 11:00:05 that would actually have saved me a bug 11:00:16 in my first version 11:00:42 <|amethyst> I would definitely like to see a toggle, but we already have a lot of toggles on that screen 11:00:50 yeah 11:01:08 there's visual space for one more 11:01:27 I wonder if it should really collapse un-id'd ego items, also 11:03:56 yeah, potions are weird right now 11:04:01 ok, I'll work on this later 11:04:25 hopefully I can finish something before I go on vacation (!) next week 11:04:36 -!- LordSloth has joined ##crawl-dev 11:10:27 <|amethyst> advil: oh, also it's fine now to just return the vector of results instead of having an outparameter 11:10:48 <|amethyst> advil: ("now" = as of C++11) 11:10:55 ah 11:11:59 it'll get cleaned up properly? 11:12:16 <|amethyst> cleaned up? 11:13:38 -!- Tux[Qyou] has joined ##crawl-dev 11:13:43 copied/destroyed w.r.t. whatever happens to the return value outside the function, I guess I mean? 11:14:26 <|amethyst> that has always been the case; what C++11 changes is that the result doesn't have to be copied, just moved 11:14:32 oh I see 11:14:34 <|amethyst> so just switching around a couple of pointers 11:14:51 <|amethyst> hm 11:14:54 -!- adelrune has joined ##crawl-dev 11:15:12 <|amethyst> you don't use full_results after computing results, do you? 11:15:19 no 11:15:28 if I add a toggle this will need to be moved into the display function 11:15:34 so it'll end up a little different 11:15:43 <|amethyst> hmn 11:15:57 <|amethyst> as it currently stands you could use std::unique after sorting 11:16:30 <|amethyst> but if you did need to keep the original that might not work for you 11:16:56 yeah, that would be better 11:17:26 <|amethyst> hm, but I guess that would make it a pain to handle the inventory, shop, missiles, etc. cases 11:17:47 looks like you can give unique a range 11:18:03 but maybe it's more straightforward just to iterate 11:19:20 I could use remove_if maybe 11:19:26 -!- Pleasingfungus has joined ##crawl-dev 11:21:44 <|amethyst> remove_if doesn't really have a way to look at other elements... I don't think the standard guarantees that they are evaluated in any particular order 11:22:00 ah 11:24:19 hm, the shop check isn't working right 11:25:08 <|amethyst> that isn't for items in shops, it's for the shops themselves 11:25:14 heh 11:25:18 ok 11:26:59 -!- ProzacElf has joined ##crawl-dev 11:27:27 -!- Syrcrax has quit [Quit: Page closed] 11:39:22 -!- jbenedetto has quit [Ping timeout: 264 seconds] 11:41:08 -!- Shimatora has quit [Ping timeout: 240 seconds] 11:41:12 -!- bgiannan_ has joined ##crawl-dev 11:45:48 -!- rossi has quit [Ping timeout: 240 seconds] 11:45:50 -!- bgiannan_ has quit [Ping timeout: 256 seconds] 11:47:58 -!- ZiBuDo has joined ##crawl-dev 11:56:38 -!- Cryp71c has joined ##crawl-dev 11:56:48 -!- Kalir has quit [Changing host] 11:59:10 -!- Shimatora has quit [Ping timeout: 264 seconds] 11:59:19 -!- Shimatora_ is now known as Shimatora 12:00:02 -!- omarax has quit [Remote host closed the connection] 12:03:10 -!- Perryman has quit [Read error: Connection reset by peer] 12:04:20 -!- Boatshow has quit [Ping timeout: 260 seconds] 12:05:53 -!- SteelNeuron has joined ##crawl-dev 12:05:55 !messages 12:05:56 No messages for SteelNeuron. 12:06:04 -!- Pleasingfungus has quit [Quit: ChatZilla 0.9.93 [Firefox 52.0/20170302120751]] 12:06:14 -!- ZiBuDo has quit [Ping timeout: 256 seconds] 12:09:58 -!- Shimatora has quit [Ping timeout: 264 seconds] 12:12:41 -!- flappity_ has quit [Read error: Connection reset by peer] 12:14:00 -!- Perryman has quit [Read error: Connection reset by peer] 12:22:25 -!- Yxhvd has quit [Remote host closed the connection] 12:29:15 -!- Blazinghand has joined ##crawl-dev 12:32:01 -!- Yxhuvud has quit [Read error: Connection reset by peer] 12:32:18 -!- ProzacElf has quit [Ping timeout: 256 seconds] 12:32:33 -!- scummos__ has quit [Ping timeout: 240 seconds] 12:38:20 -!- Basil has quit [Quit: WeeChat 0.4.2] 12:45:11 -!- GetYeFlask has quit [Quit: Leaving] 12:47:35 -!- Cryp71c has quit [Quit: Leaving] 12:51:58 -!- Shimatora has quit [Ping timeout: 264 seconds] 12:52:07 -!- Shimatora_ is now known as Shimatora 12:54:55 -!- rj54x has quit [Client Quit] 12:59:48 -!- elliptic has joined ##crawl-dev 13:00:02 -!- omarax has quit [Remote host closed the connection] 13:06:40 -!- MarvinPA has joined ##crawl-dev 13:06:53 petzl (L27 BaWn) ASSERT(you.see_cell(p)) in 'directn.cc' at line 1184 failed. (Pan) 13:10:39 <|amethyst> that's the crash fixed in 13:10:46 <|amethyst> %git c3a52372 13:10:46 07advil02 * 0.20-a0-846-gc3a5237: Consider opacity of old clouds when recalculating los 10(8 days ago, 1 file, 23+ 13-) 13https://github.com/crawl/crawl/commit/c3a52372af2a 13:12:34 -!- GauHelldragon has quit [Ping timeout: 246 seconds] 13:24:09 Unstable branch on crawl.akrasiac.org updated to: 0.20-a0-893-g832831a (34) 13:31:38 did advil's fix also fix the weird non-opaque cloud issues? 13:31:46 that were seen when reading scrolls of fog for some cloud types 13:32:08 at least visually sometimes monsters where rendered as in LOS when they shouldn't have been 13:33:44 <|amethyst> %git 73d9be0 13:33:44 07advil02 * 0.20-a0-848-g73d9be0: Update los when clouds spread 10(8 days ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/73d9be086362 13:34:25 cool 13:36:01 -!- horst-koehler has quit [Ping timeout: 246 seconds] 13:36:37 "OOD condensation clouds" 13:36:44 I was reading that as "out-of-depth" 13:36:49 then I thought about it for a sec 13:37:10 out-of-depth clouds are called fog irl 13:40:38 A Deep Fog comes into view. 13:40:55 fr: sentient acid cloud monsters 13:41:06 try to cover you themselves, speed 30 movement 13:41:12 *with themselves 13:41:22 gammafunk: maybe reflavour them as birds 13:41:36 no, birds have such low EV 13:41:42 this should have 50 ev 13:41:51 it's hard to hit a cloud, that's just realism 13:42:18 imo it's easy to hit a cloud, but they have such high AC it's hard to make any impact 13:43:05 obviously amalloy has never spent any time practicing with his katana in a sauna 13:43:32 i just didn't wanna 13:44:46 -!- rossi has quit [Ping timeout: 264 seconds] 13:53:10 -!- Shimatora has quit [Ping timeout: 264 seconds] 13:53:11 -!- Shimatora__ is now known as Shimatora 13:55:03 -!- Shimatora_ has quit [Ping timeout: 264 seconds] 13:59:46 -!- Shimatora has quit [Ping timeout: 264 seconds] 13:59:49 -!- Shimatora_ is now known as Shimatora 14:00:02 -!- omarax has quit [Remote host closed the connection] 14:01:34 -!- Tux[Qyou] has quit [Ping timeout: 246 seconds] 14:02:05 -!- ZiBuDo has joined ##crawl-dev 14:05:39 -!- Mu_ has joined ##crawl-dev 14:06:58 -!- Shimatora has quit [Ping timeout: 264 seconds] 14:06:59 -!- Shimatora_ is now known as Shimatora 14:09:02 -!- Amadiro- has quit [Excess Flood] 14:09:39 advil: why keep track of `last` yourself? vector.back() is constant-time; it seems simpler and less error-prone to just ask the vector directly when you want to modify its last item 14:11:56 <|amethyst> amalloy: it's not always the last element 14:11:58 -!- Ququman has joined ##crawl-dev 14:12:05 <|amethyst> amalloy: see the first branch of the if 14:12:35 -!- stickyfingers has quit [Ping timeout: 260 seconds] 14:14:10 -!- Shimatora has quit [Ping timeout: 264 seconds] 14:14:23 |amethyst: but the items in this list are sorted by name, right? so if we ever *do* find an item we want to mark as a duplicate of the current one, it will be last element 14:14:33 it's not like the list will be: +0 dagger, staircase to Lair, +0 dagger 14:15:42 <|amethyst> hm, I guess "(carried)" is part of res.match? 14:17:06 <|amethyst> ah, it is, since it's initialised from stash_item_name(item) 14:17:13 <|amethyst> s/from/from a copy of/ 14:19:27 -!- yesno has quit [Ping timeout: 240 seconds] 14:23:14 -!- zxc has quit [Read error: Connection reset by peer] 14:27:25 is feat_defs[] is not order-sensitive, is it? 14:27:33 in terms of other data depending on its order 14:28:17 <|amethyst> it is not 14:28:25 <|amethyst> !source get_feature_def 14:28:25 1/2. https://github.com/crawl/crawl/blob/master/crawl-ref/source/feature.cc#L224 14:28:32 <|amethyst> !source _init_feature_index 14:28:33 1/1. https://github.com/crawl/crawl/blob/master/crawl-ref/source/feature.cc#L134 14:28:35 gammafunk: it shouldn't be. see _init_feature_index which goes to some trouble to find out what order it is in (implying we don't just assume it implicitly) 14:28:46 ok, thanks 14:31:13 although, how are maps serialized, then? do we actually serialize a feature name, rather than just enum values? 14:31:39 <|amethyst> we serialise the enum value 14:32:03 <|amethyst> you can't change the order of the enums... just of the feat_defs array 14:32:11 oh, right 14:32:13 right 14:32:30 -!- simmarine has joined ##crawl-dev 14:36:19 -!- Tux[Qyou] has joined ##crawl-dev 14:37:24 hrm, what is the emphasized colour used for 14:39:00 <|amethyst> unknown stairs 14:40:13 !source emphasise 14:40:13 1/1. https://github.com/crawl/crawl/blob/master/crawl-ref/source/viewmap.cc#L1299 14:41:59 I see 14:42:27 that's interesting, actually 14:42:44 we don't seem ot use this for hatches? 14:43:29 hrm, I do seem to recall the asterisk thing in tiles though 14:43:30 for hatches 14:43:42 I'm not sure if I recall that going away after I've taken the hatch once 14:44:17 good to know about that all the same 14:49:18 -!- flappity_ has quit [Quit: Leaving] 14:49:56 <|amethyst> yeah, looks like escape hatches always use the emphasised colour 14:52:23 <|amethyst> and X] on an escape hatch does not know where it leads, even if you have taken it already 14:59:50 -!- Kalir has quit [Ping timeout: 240 seconds] 15:00:02 -!- omarax has quit [Remote host closed the connection] 15:00:21 oh, that explains why my attempt to recolour escape hatches in my rcfile didn't work 15:00:56 <|amethyst> probably they should use the non-emphasised colours instead 15:04:44 -!- Insomniak` has quit [Ping timeout: 256 seconds] 15:08:08 -!- Kalir has quit [Changing host] 15:16:04 -!- exant has quit [Quit: Page closed] 15:17:04 -!- CanOfWorms has joined ##crawl-dev 15:18:55 -!- namad7 has quit [Ping timeout: 246 seconds] 15:20:25 -!- ProzacElf has joined ##crawl-dev 15:21:47 -!- rumflump has joined ##crawl-dev 15:27:03 -!- ErskaConti has quit [Quit: ChatZilla 0.9.92 [Pale Moon 27.1.2/20170302152623]] 15:28:48 -!- scummos__ has quit [Ping timeout: 240 seconds] 15:29:27 -!- Lawman0 has quit [Quit: Page closed] 15:34:20 -!- Insomniak` has quit [Ping timeout: 240 seconds] 15:34:51 -!- bannakaffalatta has quit [Quit: Textual IRC Client: www.textualapp.com] 15:35:45 what happens to cbro experimental morgues when the experimental race branch is done? 15:38:56 they sit on the server... foreveeeeeerrrrrr.... 15:42:40 -!- bgiannan_ has joined ##crawl-dev 15:47:14 -!- bgiannan_ has quit [Ping timeout: 256 seconds] 15:48:39 -!- LexAckson has joined ##crawl-dev 15:50:13 -!- Insomniak` has quit [Ping timeout: 260 seconds] 15:53:19 -!- glaas has quit [Quit: WeeChat 1.7] 15:54:28 I seeeee 15:58:23 HAWKINGL3623 (L13 DsWz) ASSERT(you.see_cell(target())) in 'directn.cc' at line 1161 failed. (Orc:2) 16:00:02 -!- omarax has quit [Remote host closed the connection] 16:01:24 <|amethyst> !lm HAWKINGL3623 crash -log 16:01:25 1. HAWKINGL3623, XL13 DsWz, T:21798 (milestone): http://crawl.berotato.org/crawl/morgue/HAWKINGL3623/crash-HAWKINGL3623-20170316-195814.txt 16:01:32 -!- bgiannan_ has joined ##crawl-dev 16:02:46 <|amethyst> probably the same crash? This one is 0.19 16:10:39 -!- SteelNeuron has quit [Quit: Page closed] 16:27:22 -!- Shimatora has quit [Ping timeout: 264 seconds] 16:31:34 -!- Shimatora_ has quit [Ping timeout: 264 seconds] 16:31:55 !source version::short 16:31:55 Can't find version::short. 16:32:04 !source Version::Short 16:32:04 1/1. https://github.com/crawl/crawl/blob/master/crawl-ref/source/version.cc#L16 16:32:27 !source CRAWL_VERSION_SHORT 16:32:28 Can't find CRAWL_VERSION_SHORT. 16:32:46 !source Version 16:32:47 1/2. https://github.com/crawl/crawl/blob/master/crawl-ref/source/version.cc#L13 16:32:54 !source Version[2 16:32:54 Can't find Version[2. 16:33:00 !source Version 2 16:33:00 2/2. https://github.com/crawl/crawl/blob/master/crawl-ref/source/version.h#L17 16:33:16 <|amethyst> rumflump: CRAWL_VERSION_SHORT is in build.h, generated by util/gen_ver.pl 16:33:23 -!- THERetroGamerNY has quit [Quit: Be Blessed!] 16:33:32 ah, thanks 16:33:42 -!- LexAckson has quit [Ping timeout: 268 seconds] 16:33:58 trying to get "yiuf" to appear in it for the purposes of using Kramell more easily 16:37:35 -!- Fixer has quit [Read error: Connection reset by peer] 16:39:17 -!- Fixer has joined ##crawl-dev 16:41:05 -!- yesno has quit [Ping timeout: 240 seconds] 16:42:54 <|amethyst> not sure how much stuff assumes those versions are numeric 16:43:23 yeah, might cause chaos, crashes, and despair 16:43:27 we'll soon find out :D 16:47:52 -!- Ystah has joined ##crawl-dev 16:49:23 do you guys have a public repository or something? 16:49:36 <|amethyst> yes 16:49:37 <|amethyst> ??repo 16:49:37 github[1/1]: The site that hosts the crawl git repository at https://github.com/crawl/crawl 16:53:05 -!- eb has quit [Ping timeout: 240 seconds] 16:53:35 thanks 16:54:53 -!- Krakhan has quit [Changing host] 17:00:02 -!- omarax has quit [Remote host closed the connection] 17:01:43 -!- ProzacElf_ has joined ##crawl-dev 17:02:49 -!- MarvinPA_ has joined ##crawl-dev 17:03:40 -!- CanOfWorms has quit [Quit: ChatZilla 0.9.92 [Firefox 3.6.28/20120306064154]] 17:05:13 -!- ProzacElf has quit [Ping timeout: 260 seconds] 17:08:21 -!- Patashu has joined ##crawl-dev 17:08:51 -!- Patashu__ has quit [Ping timeout: 268 seconds] 17:18:37 -!- Tux[Qyou] has quit [Read error: Connection reset by peer] 17:25:05 -!- KamiKatze has quit [Ping timeout: 260 seconds] 17:31:26 -!- Avack has quit [Read error: Connection reset by peer] 17:37:50 -!- bgiannan_ has quit [Ping timeout: 258 seconds] 17:51:54 -!- rossi has quit [Ping timeout: 256 seconds] 17:52:50 -!- eb has quit [Ping timeout: 240 seconds] 17:57:43 -!- eb_mobile has quit [Ping timeout: 260 seconds] 17:59:55 -!- eb has quit [Ping timeout: 246 seconds] 18:00:02 -!- omarax has quit [Remote host closed the connection] 18:25:39 -!- eb_mobile has quit [Quit: I quit] 18:32:46 -!- eb has quit [Ping timeout: 264 seconds] 18:34:38 -!- dextur has quit [Quit: Page closed] 18:39:59 -!- Kalir has quit [Quit: I'M OUT SON. PEACE, LOVE, EXPLOSIONS.] 18:42:48 -!- Ragnor has quit [Ping timeout: 240 seconds] 18:51:49 -!- jeefus has joined ##crawl-dev 18:55:57 -!- jefus- has quit [Ping timeout: 260 seconds] 19:00:03 -!- omarax has quit [Remote host closed the connection] 19:04:55 Unstable branch on underhound.eu updated to: 0.20-a0-893-g832831a (34) 19:08:11 -!- endou_ has quit [Read error: Connection reset by peer] 19:11:25 what's a good term for reducing damage by a percentage? blunt the damage? ablate it? diminish it? 19:12:00 -!- frd has quit [Quit: und weg...] 19:15:34 !source do_shave_damage 19:15:35 1/1. https://github.com/crawl/crawl/blob/master/crawl-ref/source/ouch.cc#L754 19:15:39 what's wrong with reduction 19:16:10 hi mu 19:16:21 how goes it 19:16:24 hello. 19:16:31 I saw you had been playing some crawl recently 19:16:50 -!- knu has quit [Quit: Reboot...] 19:17:12 ye. 19:18:49 i don't understand wu jian but everything is dying around me so i think i am doing it correctly. 19:18:50 it's just nice to have a name that you can search for without turning up every other instance of the word reduce 19:21:01 wu jian is pretty out there, yeah, probably will get some changes over time 19:21:07 -!- adelrune has quit [Ping timeout: 246 seconds] 19:21:31 then we an refer to newnewnewwujian in the same loving way that we refer to nemelex 19:21:33 mb diminishment then if it's external protection or inurement if it's from within. 19:21:37 -!- Wah has quit [Ping timeout: 260 seconds] 19:23:18 in "int do_blunt_damage(int dam)", the part in parentheses, is that just telling the compiler what other functions this function is going to need access to? 19:24:04 er sorry 19:24:09 do_shave_damage 19:25:57 huh? 19:26:14 !source do_shave_damage 19:26:14 1/1. https://github.com/crawl/crawl/blob/master/crawl-ref/source/ouch.cc#L754 19:27:14 the part in parentheses is the parameter 19:27:37 it specifies the original damage; the function then returns a possibly modified damage 19:28:29 ... I'm not understanding where you got "telling the compiler what other functions... 19:28:56 if I wanted to make a different kind of damage shaving that is based on damage_fraction_of_hp, would I add that as another parameter inside the parentheses? 19:29:25 you could add a flag specifying to use a different shaving calculation, yes 19:29:36 -!- gressup has quit [Read error: Connection reset by peer] 19:29:53 you could also add a default value so existing uses wouldn't have to change (although that has its own overhead) 19:30:16 oh, hm, actually 19:30:46 if you mean replacing the damage to be shaved with damage specified as fraction of hp, you likely want a separate function entirely 19:30:56 oh actually 19:30:58 hold on 19:31:13 I've been mis-thinking about this, I don't care what the player's max hp is at all 19:31:39 I will try to write this and ask you if it looks right, if you don't mind! 19:33:46 I think I was vastly overthinking this and all I needed was div_rand_round. http://dpaste.com/0TDDRBM 19:35:46 -!- dextur has quit [Quit: Page closed] 19:37:27 seems reasonable if I understand what you're doing, yes 19:38:21 mis-commented I guess, since that's the pre-AC damage 19:42:47 I should look up parameters though, thanks for telling me what the term is 19:47:58 -!- mizu_no_oto has quit [Quit: Computer has gone to sleep.] 19:52:53 -!- GauHelldragon has quit [Ping timeout: 260 seconds] 19:53:10 -!- rossi has quit [Ping timeout: 256 seconds] 19:53:23 -!- Pacra has joined ##crawl-dev 19:54:10 -!- Ququman has quit [Read error: Connection reset by peer] 20:00:03 -!- omarax has quit [Remote host closed the connection] 20:01:55 -!- scummos__ has quit [Remote host closed the connection] 20:02:13 -!- ffffaadwddd has quit [Quit: Konversation terminated!] 20:03:17 -!- veid has quit [Quit: This computer has gone to sleep] 20:08:53 -!- hellmonk has joined ##crawl-dev 20:11:09 -!- Tungsten has quit [Quit: Page closed] 20:12:34 -!- Menche has quit [Quit: Leaving] 20:18:36 -!- scummos| has quit [Ping timeout: 240 seconds] 20:27:28 -!- Mu_ has quit [Ping timeout: 240 seconds] 20:27:58 -!- _yeeve has quit [Ping timeout: 240 seconds] 20:37:06 -!- CanOfWorms has joined ##crawl-dev 20:41:24 -!- amalloy is now known as amalloy_ 20:42:52 nemelex xobeh 20:43:01 memelex xoobie 20:43:14 nemelex xobeh doo 20:44:26 -!- Fixer has quit [Ping timeout: 246 seconds] 20:49:35 but seriously is the needle pointing more in the direction of "remove" or "change" 20:50:42 -!- yesno has quit [Quit: Leaving] 20:59:16 I have no idea. (my personal vote is "remove" just because, with all the changes nem's got, if it still doesn't work then what else is left?) 20:59:30 direct card drawing instead of fiddling with decks, for one 21:00:03 -!- omarax has quit [Remote host closed the connection] 21:00:03 anyway as far as I know no one's actively working on NX. no urgent pressing need to remove the god though 21:01:46 -!- zxc has joined ##crawl-dev 21:02:18 -!- eb_mobile has quit [Ping timeout: 256 seconds] 21:04:52 yeah I doubt the god will get removed 21:05:06 too entrenched in crawl history 21:05:07 what minmay recently proposed is similar to what |amethyst had proposed, based on my cursory glance 21:05:33 or at least the "cards through invocations only without inventory" aspect was present in both 21:07:35 amalloy_: when you made map-cell.h , I think you may have brought back a define that only existed for Lava Orc (HOT), and advil had that all removed at this point 21:09:22 -!- eb_mobile has quit [Ping timeout: 264 seconds] 21:11:10 -!- Shimatora has quit [Ping timeout: 264 seconds] 21:11:21 -!- Shimatora_ is now known as Shimatora 21:14:37 -!- nikheizen has joined ##crawl-dev 21:15:51 uh oh 21:17:48 dibs on the millimarvins :D 21:18:38 I'm pretty rich in millimarvins 21:18:51 though I feel like I got them by cheating 21:22:28 I don't think I removed that 21:22:45 so if that's lava-orc related I missed it 21:23:05 MAP_HOT is never set in master, so it probably should be removed 21:23:33 heat_aura is all over the place too 21:23:34 -!- Shimatora has quit [Quit: z] 21:23:41 New branch created: pull/497 (4 commits) 13https://github.com/crawl/crawl/pull/497 21:23:41 03yrmvgh02 {GitHub} 07https://github.com/crawl/crawl/pull/497 * 0.20-a0-894-gc04bb10: re-remove area_hot 10(5 minutes ago, 1 file, 0+ 3-) 13https://github.com/crawl/crawl/commit/c04bb108f130 21:23:41 03yrmvgh02 {GitHub} 07https://github.com/crawl/crawl/pull/497 * 0.20-a0-895-g91ee343: more hot removal 10(4 minutes ago, 1 file, 0+ 3-) 13https://github.com/crawl/crawl/commit/91ee343db157 21:23:41 03yrmvgh02 {GitHub} 07https://github.com/crawl/crawl/pull/497 * 0.20-a0-896-g2617b58: this removal is hot 10(3 minutes ago, 1 file, 0+ 4-) 13https://github.com/crawl/crawl/commit/2617b588572c 21:23:41 03yrmvgh02 {GitHub} 07https://github.com/crawl/crawl/pull/497 * 0.20-a0-897-gd111a79: remove all heat 10(2 minutes ago, 1 file, 0+ 5-) 13https://github.com/crawl/crawl/commit/d111a79c2518 21:23:46 -!- travis-ci has joined ##crawl-dev 21:23:46 The build has errored. (patch-10 - c04bb10 #125 : Yer mivvaggah): https://travis-ci.org/yrmvgh/yiufcrawl/builds/211972341 21:23:47 -!- travis-ci has left ##crawl-dev 21:24:48 I think you could squash those :-) 21:25:23 but the git manual says atomic commits are better, in case they need to be reverted individually :o 21:27:07 I can take down the patch and put it up again squashed if you like, I don't really know how to squash it in its present state 21:27:18 I'm a little worried about save compat, I'd want someone else to squint at the MAP_HOT stuff before merging it 21:27:25 interactive rebase 21:28:10 I could do it if I were merging it, but as I said I'm not going to do it myself immediately 21:28:22 -!- rossi has quit [Ping timeout: 256 seconds] 21:30:35 I just don't really know how saving works for maps 21:30:57 I see 21:31:11 <|amethyst> rumflump: except you can't revert, for example, d111a79c2518, without also reverting 91ee343db157 21:31:19 <|amethyst> rumflump: so it's not really atomic 21:31:36 <|amethyst> rumflump: for thaty matter, if you try builing one of those middle commits, it will fail 21:31:53 <|amethyst> since you removed the definition before removing the use of that definition 21:32:04 dang 21:32:12 good to know 21:32:47 -!- travis-ci has joined ##crawl-dev 21:32:48 The build has errored. (patch-10 - 2617b58 #127 : Yer mivvaggah): https://travis-ci.org/yrmvgh/yiufcrawl/builds/211972811 21:32:48 -!- travis-ci has left ##crawl-dev 21:33:18 <|amethyst> probably just removing it is fine for now, but the problem arises if we introduce a new flag and give it the same numeric value 21:33:28 -!- Boatshow_ has quit [Ping timeout: 240 seconds] 21:34:08 maybe leave MAP_HOT as a #define but remove everything else? 21:34:26 <|amethyst> I'd at least rename it to MAP_UNUSED 21:34:31 I'm pretty sure I have a LO save with a heat aura up that one could use for testing (iirc they just get that when hot enough?) 21:34:44 <|amethyst> but I was thinking to clear that out in unmarshallMapCell 21:34:47 -!- bgiannan_ has joined ##crawl-dev 21:34:59 rumflump: if you "git grep heat_aura" you'll see a bunch of related stuff that should go too, I think 21:35:41 while you're at it, there's even more in rltiles if you're ambitious :D 21:35:46 <|amethyst> wow 21:35:48 I only noticed the HOT thing because I was merging in trunk changes 21:36:03 I just didn't really understand what goes on rltiles 21:36:04 <|amethyst> this "serialise the flags as 8, 16, or 32 bits depending on how many bits are set" 21:36:08 -!- travis-ci has joined ##crawl-dev 21:36:09 The build has errored. (patch-10 - d111a79 #128 : Yer mivvaggah): https://travis-ci.org/yrmvgh/yiufcrawl/builds/211973034 21:36:10 -!- travis-ci has left ##crawl-dev 21:36:10 lol 21:36:23 <|amethyst> I don't remember disk space ever being that expensive 21:36:39 <|amethyst> I mean, not for as long as Crawl has been around 21:36:43 <|amethyst> let alone DCSS 21:37:19 <|amethyst> I guess there's a reason Adam uses the nick "kilobyte" 21:37:58 'megabyte' or 'gigabyte' might have been presumptuous 21:38:06 "but I want it to fit on my old 16mb thumb drive!" 21:38:24 yeah, megabyte's a very powerful villain 21:38:30 don't want to go stealing his name 21:38:52 <|amethyst> the weird thing is, I think marshallUnsigned would do something very similar already 21:39:12 -!- bgiannan_ has quit [Ping timeout: 240 seconds] 21:39:44 <|amethyst> not quite the same, but possibly more efficient in most cases, since it uses 1 bit per byte rather than a whole extra byte regardless 21:41:45 the comment about that above MAP_HOT is part of what made me nervous about save compat 21:45:10 I thought I remembered having to write map_hot back in after you did your big thing, but it must have been merely removeing the ifdef 21:46:14 I might have got some of it 21:46:24 I have no doubt that there will be lingering bits of LO for some time to come 21:46:52 you know what they say about lava, it gets everywhere 21:46:58 -!- Boatshow has quit [Ping timeout: 268 seconds] 22:00:02 -!- omarax has quit [Remote host closed the connection] 22:01:35 no you've got it mixed up 22:01:38 that's what they say about orc 22:01:42 it's why you shouldn't lick orcs 22:02:14 -!- mizu_no_oto has quit [Quit: Computer has gone to sleep.] 22:19:12 -!- adibis has quit [Ping timeout: 258 seconds] 22:20:10 -!- ProzacElf_ is now known as ProzacElf 22:29:45 -!- amalloy_ is now known as amalloy 22:41:15 -!- mibe has quit [Ping timeout: 260 seconds] 22:45:46 -!- bonghitz has quit [Remote host closed the connection] 22:45:56 ok come to think of it you probably shouldnt lick lava either 22:46:57 https://scontent-lax3-2.xx.fbcdn.net/v/t1.0-9/15941171_1296862910357586_7535362490776228506_n.jpg?oh=6ec15689ebaa3fdcfb1872d0333fed7c&oe=590FAACF 22:51:51 that reminds me do you ever get the desire to chug a lava lamp 22:52:01 like just pick it up and gulp down the entire contents 22:53:59 -!- greenangel has quit [Quit: Page closed] 22:54:33 -!- Blazinghand has quit [Quit: Leaving] 22:54:37 I have enough GI tract problems as it is... 23:00:03 -!- omarax has quit [Read error: Connection reset by peer] 23:08:19 Brannock: archmagi on scarves? 23:08:27 probably not 23:08:42 one thing about archmagi is that it locks you into the lightest armor in the game 23:08:51 putting it on scarves doesn't really have that tradeoff 23:09:14 scarves need new egos, not moved egos 23:09:28 are you comparing scarf to 3 ac, or are you comparing scarf to 3 ac and evocable invisibility? 23:09:54 -!- amalloy is now known as amalloy_ 23:11:23 scarf of air enhancer 23:12:00 -!- bonghitz has quit [Remote host closed the connection] 23:12:54 54999 commits 23:13:12 meanwhile resistance, cold resistance, and spirit are scarf egos 23:21:35 I always find the use of the word "ego" to be funny 23:21:42 I feel funny when calling those things egos 23:22:09 heh 23:22:32 funny ha-ha or funny strange? 23:22:35 <|amethyst> http://angband-dev.blogspot.com/2011/09/so-what-exactly-is-ego-item-anyway.html 23:24:33 heh 23:24:43 i remember ego items in d&d actually being sentient 23:24:54 references crawl's singing sword even 23:25:24 but yeah, that trivia about the origin makes sense 23:26:02 they were also exceptionally rare 23:26:23 hence we should probably call them something else 23:26:25 compared to magical weapons with more standard sorts of "brands" or enchantments 23:26:35 I guess it'd be a lot of work to do renaming 23:26:41 lol 23:26:50 and you'd probably still want to leave it as a search term anyway 23:26:58 that I wouldn't really mind 23:27:00 just because it has inertia on its side 23:27:19 tbh we don't even need to allow searching by that term in-game 23:27:26 03advil02 07https://github.com/crawl/crawl/pull/496 * 0.20-a0-895-gd1c9da4: Filter search results for duplicates take 2 10(6 minutes ago, 2 files, 61+ 52-) 13https://github.com/crawl/crawl/commit/d1c9da44384f 23:27:28 <|amethyst> do we use "ego" in-game outside UI things like ctrl-f? 23:27:36 i don't know? i've never really noticed it 23:27:41 ?/ego 23:27:41 Matching terms (2): ego, san_diego; entries (38): !fight[2] | ammo_acquirement[1] | ancestor[3] | artefact[2] | call_of_chaos[4] | centaur[1] | cling[1] | cloud_mage[1] | ctrl+f[1] | dancing_weapon[1] | ego[1] | elliott[1] | epic_bugs[20] | erocrawl[5] | f[2] | gammafunkrc[1] | hangedman[3] | hangedman[12] | helpless[1] | hyperelynae[2] | implementables[1] | kryft[4] | nomi[5] | patacrawl[1] | pon... 23:27:52 oh that sounds super hot, advil 23:28:04 super. hot. super. hot. 23:28:06 but it could be one of those things that gets listed in an item description that i just never pay attention to 23:28:13 https://boardgamegeek.com/thread/657276/board-game-songs-filks 23:28:17 hot like lava orcs 23:28:33 :-) 23:29:43 -!- Pacra has quit [Read error: Connection reset by peer] 23:29:52 -!- Blazinghand has joined ##crawl-dev 23:30:30 -!- Pacra has joined ##crawl-dev 23:30:41 yeah will be cool to see that stash filtering come together 23:31:50 it does seem to make a lot of simpler searches more viable 23:32:09 in this test game I'm using it reduces the results for just "sword" from 147 matches to 29 23:36:40 <|amethyst> advil: hm, re the sorting... if you copy the whole thing first then use std::sort and std::unique on out, you could keep in const 23:37:32 oh 23:37:33 haha 23:37:47 so like it won't show me every single instance of a long sword 23:37:47 if i do that? 23:37:57 just like all the plain long swords 23:38:03 then the different branded ones 23:38:06 or whatever? 23:38:15 that's the idea 23:38:26 -!- knu has quit [Quit: Reboot...] 23:38:31 if you look in the PR there's a screenshot (though I've fixed some issues you can see there) 23:39:52 |amethyst: can I only uniqueify for things that match a property? (`_is_potentially_boring`) 23:40:34 <|amethyst> advil: yes, check that in your predicate 23:40:45 <|amethyst> hm 23:40:55 <|amethyst> I guess you might need to be slightly more careful 23:41:20 ah 23:41:28 <|amethyst> hm 23:41:38 so []{return x == y && !_is_potentially_boring()} 23:42:10 with the right arguments 23:42:17 <|amethyst> return x.match == y.match && !_is_potentially_boring(x), sure 23:43:32 <|amethyst> I'm looking for more details 23:43:41 -!- exant_ has quit [Quit: Page closed] 23:43:47 <|amethyst> cppreference says "The behavior is undefined if it is not an equivalence relation." 23:43:54 -!- mizu_no_oto has quit [Quit: Computer has gone to sleep.] 23:44:11 haha nice 23:44:21 <|amethyst> but then has an example using [](char l, char r) { return std::isspace(l) && std::isspace(r) && l == r; } 23:44:25 it should be an equivalence relation if I checking boringness on both x and y 23:44:37 <|amethyst> no, because it's not reflexive 23:44:43 ah 23:45:02 <|amethyst> let me see what the standard says 23:45:33 <|amethyst> also remember that you have to erase 23:46:02 <|amethyst> unique(), like remove_if(), doesn't actually change the size of the container 23:47:55 return &x == &y || (x.match == y.match && !_is_potentially_boring(x) && !_is_potentially_boring(y)) 23:48:10 but I need to go to sleep so I might have to return to this later 23:48:12 <|amethyst> heh 23:48:29 <|amethyst> IMO better to just write it without the &x == &y 23:48:37 <|amethyst> and file a defect on the standard 23:48:44 they are probably just ignoring the reflexive case 23:48:52 I can't think why that would come up in any sane implementation 23:48:59 <|amethyst> right :) 23:49:27 and if it came up, why they'd rely on the predicate to check that case 23:50:13 <|amethyst> also 23:50:33 <|amethyst> "Complexity: For nonempty ranges, exactly (last - first) - 1 applications of the corresponding 23:50:36 <|amethyst> predicate." 23:51:02 <|amethyst> that doesn't give implementations much room to actually compare an element against itself :) 23:51:08 heh 23:51:22 that is also exactly the amount of calls to predicate my non-fancy version has :-) 23:51:52 though it presumably has more overhead 23:52:54 <|amethyst> there is also a unique_copy btw, that does closer to what you're doing 23:53:26 <|amethyst> but I think it makes more sense to sort the copy than the original 23:55:29 <|amethyst> hm, C++11 standard also says this of std::reverse 23:55:32 <|amethyst> Complexity: Exactly (last - first)/2 swaps. 23:55:34 -!- Avack has quit [Quit: Leaving.] 23:56:12 <|amethyst> exactly 2.5 swaps for a five-element range 23:56:28 <|amethyst> oh, I guess that formula is written in C++ 23:56:34 <|amethyst> fair enough