00:00:03 -!- omarax has quit [Remote host closed the connection] 00:00:35 oh, they do, but 00:00:43 it's likea little picture of a skill tree 00:00:51 so no dice there 00:01:08 i don't remember the skill tree icon, but i remember the plus icon you'd click on when you needed to assign a skill point 00:02:17 well, yeah, i guess i could just make it a plus sign 00:02:17 that sort of suggests 'progress,' at least 00:03:17 this game's terrible ui has a skill icon that is "silhouette of a dude with a + sign behind him" 00:05:47 maybe "skills" is the wrong base word to try to conceive an image off 00:05:53 "training" "education" "practice" 00:07:54 * ontoclasm shrugs 00:07:54 -!- Brickman has quit [Quit: Page closed] 00:07:54 i dunno how to draw those either really, haha 00:07:58 except maybe like a pencil or similar for education 00:08:09 which doesn't work here 00:08:15 -!- DDFi has quit [Ping timeout: 264 seconds] 00:08:38 a little brown combat dummy with a graduation cap on 00:08:44 (this may or may not be the worst idea ever) 00:09:30 ontoclasm: what about like, an icon showing the various kinds of things you can train? a weapon, a spell, a wand, and...armour? 00:09:31 draw a manual, the patron item of skilling 00:09:54 Unstable branch on crawl.jorgrun.rocks updated to: 0.19-a0-1442-g3b32ff5 (34) 00:10:00 amalloy: i've got 12x12 pixels, max 00:10:05 rip 00:10:09 i'm good, but not THAT good 00:10:14 heh heh 00:11:21 that reminds me of working in embedded devices 10 years ago. "we've got like 8MB for code, and 32MB for everything else you might need" 00:12:06 wtf kind of embedded device has that much space 00:12:25 well it was a router. so not like, a washing machine 00:12:53 !messages 00:12:53 No messages for minmay. 00:13:31 i think a simple + sign looks okay 00:13:31 it's not embedded unless you're using QNX and powered by 1.5v solar! 00:13:31 ontoclasm: so, any interest in the elf thing 00:13:31 elf thing? 00:13:31 minmay needs photos of spiderelf 00:13:45 minus the spider part 00:14:29 i'm... still lost 00:15:24 I'm gonna need like, 5 faux-sprites of an elf doing things, about 32x32 pixels. no animation needed 00:15:52 i can probably do that; what for? 00:15:55 they're all things like speaking to a crowd and leading an angry mob, except for one which is kissing another elf, so you need to be comfortable with that 00:16:13 i will bite back my aversion to elf PDAs 00:16:40 also, incidentally 00:16:43 i can pay real money for this but this is only going to happen a few months ago, not right now 00:16:46 why in the default loacl tiles gui 00:16:46 er 00:16:48 a few months later 00:16:50 local* 00:16:55 is metacommands not last 00:16:57 i assume you would charge me a lot for time travel 00:17:19 50$ per day^(-1) 00:17:20 ...also, sorry about doing this in ##crawl-dev, I totally spaced out and thought I was in ##crawl lol 00:17:49 what do you have against elven pearl dragon armours, ontoclasm 00:18:30 CanOfWorms: died to an old mimic once 00:19:08 i d-don't like to talk about it 00:19:09 https://dl.dropboxusercontent.com/u/1000017/crawl/tabs.png 00:19:12 (note: ontoclasm did not actually die to an old mimic online, apparently) 00:19:51 nice 00:19:59 -!- bcadren has quit [Ping timeout: 265 seconds] 00:20:05 a little cleaner, i guess 00:21:04 -!- Nomi has quit [Read error: Connection reset by peer] 00:21:26 i made an effort to have the monster icon be ambiguously an elf with long hair, an orc wearing a helmet, or some beast with long teeth 00:22:15 -!- Brannock_ has joined ##crawl-dev 00:23:33 03ontoclasm02 07* 0.19-a0-1443-g9b58ed8: Simpler Skill tab icon 10(26 seconds ago, 1 file, 0+ 0-) 13https://github.com/crawl/crawl/commit/9b58ed87b548 00:24:26 -!- Franz__ has quit [Read error: Connection reset by peer] 00:25:25 -!- Brannock has quit [Ping timeout: 258 seconds] 00:27:47 i thought it was an angry ghost 00:28:02 with stubby arms 00:28:05 it looks like dota2's mask of madness 00:28:20 -!- nikheizen has quit [Quit: leaving] 00:28:44 -!- mibert has joined ##crawl-dev 00:29:37 new warnings 13https://crawl.develz.org/mantis/view.php?id=10650 by geekosaur 00:30:22 Unstable branch on CRAWL.XTAHUA.COM updated to: 0.19-a0-1442-g3b32ff5 (34) 00:30:42 both of those are also acceptable 00:31:58 -!- destroythecore has quit [Read error: Connection reset by peer] 00:35:14 the icon for the character status screen 00:35:14 is a mirror with a literal @ symbol reflected in it 00:35:39 03amalloy02 07* 0.19-a0-1444-gba94727: Fix some silly code left by my refactoring script 10(34 seconds ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/ba947273d404 00:36:05 i don't know how to handle this emotionally 00:36:54 make it a mirror reflecting smooching elves, two birds with one stone 00:37:35 (aaaand now I'm installing clang 3.9 on the mac to see if it finds any more warnings :) 00:39:33 well, except this is going to fail because my notwork is being not and aborting downloads :/ 00:40:55 -!- Alcopop has quit [Quit: Page closed] 00:46:32 -!- mibert has quit [Remote host closed the connection] 00:47:19 -!- MaxFrost has quit [Quit: Going offline, see ya! (www.adiirc.com)] 00:47:38 -!- mizu_no_oto has quit [Quit: Computer has gone to sleep.] 00:49:19 -!- wheals has joined ##crawl-dev 00:51:42 -!- eki has quit [Quit: leaving] 00:53:52 -!- Implojin has quit [Quit: Page closed] 00:55:42 03gammafunk02 07* 0.19-a0-1445-ge808afc: Fix a compilation warning 10(32 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/e808afc3bccd 00:56:50 -!- Tarara has quit [Ping timeout: 252 seconds] 00:57:17 !remove compilation 00:57:18 03gammafunk ⛐ 0.19-a0-1204-gddba5f5: Remove compilation 10(in the future, 1 files, 476+ 870-) 13http://s-z.org/neil/git/commit.png?p=crawl.git;a=commitdiff;h=ddba5f5 00:57:56 at least removing compilation gave me millimarvins 00:58:31 interestingly, clang on os x didn't see that one either 00:58:38 maybe if I can get 3.9 installed... 01:00:03 -!- omarax has quit [Remote host closed the connection] 01:06:10 anyone in here speak SQL? 01:06:35 I'm writing a query to find the number of per-species wins per player. It looks like this: 01:06:38 -!- zxc has joined ##crawl-dev 01:06:42 select species_id,count(*) from games join species on games.species_id = species.id where account_id=55685 and ktyp_id=6 and species.playable=1 group by species_id; 01:07:24 however, this doesn't return species with no wins 01:07:40 right join 01:07:53 something sqlite sadly doesn't support :) 01:08:07 Error: RIGHT and FULL OUTER JOINs are not currently supported 01:08:35 then you need to rephrase it as a query on species with a left join on games 01:08:55 fr: sql_lang 01:09:40 Unstable branch on crawl.jorgrun.rocks updated to: 0.19-a0-1445-ge808afc (34) 01:09:55 DELETE from monsters where name='goblin' and mid=5567!!! 01:11:34 -!- Harudoku has quit [Ping timeout: 240 seconds] 01:11:40 apparently you can emulate this sort of join with a triple union: https://en.wikipedia.org/wiki/Join_%28SQL%29#Full%5Fouter%5Fjoin 01:11:58 I might just do it in application code and increase the priority of moving to postgresql 01:13:01 !learn set merch[1] see {koboldina[1]} 01:13:01 merch[1/1]: see {koboldina[1]} 01:13:17 -!- Articusice has quit [Quit: Leaving] 01:16:34 -!- omnirizon has quit [Ping timeout: 250 seconds] 01:19:23 -!- mong has quit [Quit: Leaving] 01:19:47 Unstable branch on crawl.develz.org updated to: 0.19-a0-1445-ge808afc (34) 01:27:53 -!- dtsund has quit [Quit: Reality is an illusion, the universe is a hologram, buy gold, BYE] 01:28:03 -!- DarkwingDuck has quit [Ping timeout: 264 seconds] 01:28:22 -!- koboldina has quit [Quit: Page closed] 01:31:35 -!- Implojin has joined ##crawl-dev 01:33:24 -!- CanOfWorms has quit [Quit: ChatZilla 0.9.92 [Firefox 3.6.28/20120306064154]] 01:33:58 -!- fr3d_ has quit [Quit: leaving] 01:37:24 gammafunk: one of those shirts has a thing i personally drew on it 01:37:30 life is weird 01:37:51 you mean a crawl tile? 01:37:57 yes 01:38:01 the zigfig 01:38:09 i have that shirt 01:38:15 -!- DDFi has quit [Ping timeout: 264 seconds] 01:38:27 yeah, I mean if someone said I have a shirt with crawl tiles on it, I'd naturally think of ontoclasm! 01:38:36 then I'd think of the worm guy 01:38:43 hah 01:38:56 RIP denzi 01:39:05 thank goodness you do what you do, ontoclasm, otherwise wheals would be naked 01:39:26 mmm 01:40:08 ugh, fr remove traps 01:40:16 so i don't have to draw a tile for "find traps" 01:43:23 -!- muravey has joined ##crawl-dev 01:43:31 i've drawn myself into a corner; crawl traps don't look anything like traps anymore 01:43:48 because they're like... magical regions of space that do weird magic stuff to you 01:43:51 instead of like 01:44:00 a thing that shoots darts out of the floor 01:45:29 wait, why would you need to draw a tile for that? 01:45:44 because local tiles has a button for it 01:45:51 i don't know why 01:45:58 has anyone ever pressed that button 01:46:06 this sounds like a button that should have been removed like 5 years ago 01:46:45 be my guest 01:46:45 if that button does anything it's a bug 01:46:45 alternatively, it's a button that does nothing, also a bug 01:46:51 there's also a "find stash" button 01:47:08 which... i guess cycles through all items on the current floor? 01:48:03 i'm not sure how to differentiate that from "stash search" 01:48:59 oh, "find traps" might be the thing on X^ ? 01:49:36 amalloy: if X^ actually does something then probably yes 01:50:18 and find stash is probably XI 01:54:09 i mean, if people are still making stashes you would think they would use the waypoint system for them 01:54:24 which i do to satisfy my ocd 01:54:30 No 01:54:33 I use ctrl F 01:54:34 for scroll 01:54:42 and all the scrolls together are my stash 01:54:55 all the big stacks of enchant scrolls I'm saving up 01:55:09 ProzacElf: even if you do want to use it for a stash 01:55:21 it just finds ANY items 01:55:27 heh 01:55:35 that sounds awfully useless 01:55:37 and it's not a search, it cycles through them 01:56:51 -!- Amnesiac has quit [Ping timeout: 264 seconds] 01:56:56 Windows builds of master branch on crawl.develz.org updated to: 0.19-a0-1445-ge808afc 02:00:02 -!- omarax has quit [Remote host closed the connection] 02:00:20 -!- Furril has quit [Ping timeout: 255 seconds] 02:03:36 -!- DDFi has quit [Ping timeout: 264 seconds] 02:03:36 -!- royiv has quit [Ping timeout: 276 seconds] 02:11:08 -!- VoxSomniator has quit [Quit: Leaving] 02:11:50 -!- hellmonk has quit [Quit: Page closed] 02:18:27 -!- squidcat has quit [Ping timeout: 264 seconds] 02:21:30 -!- flameaway has quit [Quit: Page closed] 02:38:09 -!- jeefus has joined ##crawl-dev 02:38:18 whoops, missed 3.9 is still a devel-ish build (assertions enabled/slow) 02:38:38 -!- iFurril has quit [Ping timeout: 250 seconds] 02:40:29 oh my. it's moderately unhappy about some things 02:40:33 ./random.h:145:20: warning: passing an object that undergoes default argument promotion to 'va_start' has 02:40:33 undefined behavior [-Wvarargs] 02:40:33 va_start(args, first); 02:41:21 actually so far it's just that. just repeated a lot 02:41:30 -!- jefus has quit [Ping timeout: 250 seconds] 02:41:55 every use of random_choose_weighted 02:47:56 huh. const char* shouldn't undergo default argument promotion, should it? 02:48:40 https://www.securecoding.cert.org/confluence/display/cplusplus/EXP58-CPP.+Pass+an+object+of+the+correct+type+to+va_start even uses char* as an example of something legal to do 02:49:49 then maybe it's not all of them. but it's used with all sorts of things 02:50:28 monster_type, deck_rarity_type, misc_item_type, special_missile_type, ... 02:50:57 oh, this is the templated version in the header file 02:51:08 i was looking at the char* version in random.cc 02:51:15 yes 02:52:15 yeah, i can see how this is not allowed when T is an enum that promotes to int or somthing 02:52:23 * geekosaur is mantising but waiting for build to finish 02:52:38 looks like that;s the only thing it's annoyed with 02:52:47 perhaps I should have skipped LTO for this build... (zzzzz) 02:54:11 Monster database of master branch on crawl.develz.org updated to: 0.19-a0-1445-ge808afc 02:55:24 hm. is random_choose_weighted used for anything with different size than int? it seems like the T can be anything, but it gets treated as an int regardless at random.h:155, which doesn't seem right to me 02:56:01 -!- ontoclasm has quit [Quit: Leaving.] 02:57:28 it probably *is* an int regardless at that point, since varargs always gets default promotion and you're not going to be able to tell it what type to use 02:57:41 which is likely why the (char *) one remains as a non-template function 02:59:49 another warning found by clang-3.9 13https://crawl.develz.org/mantis/view.php?id=10651 by geekosaur 02:59:53 -!- Dracunos has quit [Ping timeout: 264 seconds] 03:00:03 -!- omarax has quit [Remote host closed the connection] 03:03:03 -!- Cimanyd has quit [Quit: Page closed] 03:09:56 -!- scummos__ has quit [Ping timeout: 252 seconds] 03:17:00 geekosaur: we should be able to replace the va_arg stuff with a recursive tempalte, right? i have a proof of concept locally that seems to work but can't test it against modern clang warnings 03:20:32 geekosaur: if you want to try it out, it's at https://github.com/amalloy/crawl/commit/65231a8f9289fa992784aae0bcc98b881820de37 03:25:03 actually i guess i should just say that on mantis 03:25:38 Unstable branch on crawl.beRotato.org updated to: 0.19-a0-1445-ge808afc (34) 03:35:19 -!- DDFi has quit [Quit: Page closed] 03:39:09 -!- Blazinghand has joined ##crawl-dev 03:57:54 -!- muravey has quit [Quit: My Mac has gone to sleep. ZZZzzz…] 03:59:12 -!- muravey has joined ##crawl-dev 04:00:03 -!- omarax has quit [Remote host closed the connection] 04:12:41 New branch created: pull/348 (3 commits) 13https://github.com/crawl/crawl/pull/348 04:12:41 03amalloy02 07https://github.com/crawl/crawl/pull/348 * 0.19-a0-1445-g19b6a4a: Modernize random_choose_weighted 10(53 minutes ago, 1 file, 16+ 19-) 13https://github.com/crawl/crawl/commit/19b6a4a6907f 04:12:41 03amalloy02 07https://github.com/crawl/crawl/pull/348 * 0.19-a0-1446-ga4ea578: Remove char* overload for r_c_w now that it's templated right 10(48 minutes ago, 2 files, 0+ 26-) 13https://github.com/crawl/crawl/commit/a4ea57892953 04:12:41 03amalloy02 07https://github.com/crawl/crawl/pull/348 * 0.19-a0-1447-g3595572: Remove now-unnecessary 0 sentinel in random_choose_weighted 10(14 minutes ago, 26 files, 91+ 175-) 13https://github.com/crawl/crawl/commit/35955721b51a 04:18:51 amalloy: PR instead of a branch for commentary? 04:19:03 yes 04:19:11 -!- GauHelldragon has quit [Ping timeout: 250 seconds] 04:19:16 I can try on my gccs 04:21:28 dangit you made my ccache worthless 04:21:36 welcome to my weekend 04:21:44 dozens of from-scratch recompiles 04:22:30 when will someone donate a compilation farm to dcss 04:23:55 03amalloy02 07https://github.com/crawl/crawl/pull/348 * 0.19-a0-1447-g81c5ed4: Remove now-unnecessary 0 sentinel in random_choose_weighted 10(25 minutes ago, 27 files, 91+ 183-) 13https://github.com/crawl/crawl/commit/81c5ed4a6bcb 04:35:22 well it compiled in 5.4 04:35:24 travis will cover 4.7 04:35:53 assuming it's able to install packages 04:36:39 good enough for me i guess 04:36:53 -!- Patashu has joined ##crawl-dev 04:37:33 03amalloy02 07* 0.19-a0-1446-ga8315b2: Modernize random_choose_weighted 10(78 minutes ago, 1 file, 16+ 19-) 13https://github.com/crawl/crawl/commit/a8315b2fc92d 04:37:33 03amalloy02 07* 0.19-a0-1447-g7db0936: Remove char* overload for r_c_w now that it's templated right 10(73 minutes ago, 2 files, 0+ 26-) 13https://github.com/crawl/crawl/commit/7db0936f4ece 04:37:33 03amalloy02 07* 0.19-a0-1448-g1485906: Remove now-unnecessary 0 sentinel in random_choose_weighted 10(39 minutes ago, 27 files, 91+ 183-) 13https://github.com/crawl/crawl/commit/1485906a677b 04:38:47 wow, this person: https://www.reddit.com/r/dcss/comments/513xgj/any_way_to_import_online_ghosts_offline/ 04:39:22 brave soul, yeah 04:39:39 clearly has never met the likes ot logicninja, tstbtto, silensnack, ... 04:48:21 got worried since you merged it and tried 4.7, which also worked 04:48:30 -!- kmckee24 has quit [Quit: Page closed] 04:50:01 tbh i would never write code that doesn't work 04:50:35 -!- ilyak has quit [Ping timeout: 240 seconds] 04:52:42 the flexibility of that template syntax is interesting 04:53:34 what about it? 04:54:51 I just guess how it handles the var_arg-like syntax 04:54:51 -!- Blazinghand has quit [Quit: This computer has gone to sleep] 04:55:13 repeating those arguments to the template<> itself 04:55:34 yeah the parameter pack stuff is weird 04:56:17 one thing about that, why are there two different typenames, A and B? 04:56:37 aren't all callers using the same types for all the non-weight arguments to the macro? 04:57:04 no, they're not. notably, there are calls with both colours and element_types 04:57:24 (why those are in separate enums i don't know, but they are) 04:57:38 ah, interesting 04:58:07 my first revision just used T for all args, but it breaks for that use case 04:58:24 hrm, but I see you do do a cast 04:58:46 and this is fine? turning e.g. element_types into colours? 04:59:14 yes, because they're both basically ints. the old random_choose_weighted included a static_cast 04:59:31 but if you make a mistake and pass random_choose_weighted both an int and a string, the static_cast refuses to compile 05:00:29 -!- omarax has quit [Remote host closed the connection] 05:00:29 ok, and if e.g. element_types has more enum values than colours, that's not going to matter? 05:00:29 hm, it might 05:00:53 though it's not about "more" enum values, since they in fact don't overlap 05:01:49 ah, you mean elemental_types just starts at higher values 05:01:59 yeah 05:02:33 gammafunk: see _roll_abyss_rock_colour for an example 05:03:07 it chooses between colours and elemental_types, and then automatically converts that into colour_t (typedef for unisgned short) 05:03:11 -!- chan20 has quit [Read error: Connection reset by peer] 05:03:14 which seems like it must be breaking some kind of rule 05:03:53 hrm, what color are hellions 05:04:10 if someone who knows the spec better objects, i think we can just static_cast to int instead of to whatever other type 05:06:06 !source _roll_abyss_rock_colour 05:06:06 1/1. https://github.com/crawl/crawl/blob/master/crawl-ref/source/abyss.cc#L1477 05:08:57 well, abyss rock can still roll etc_fire and work properly, it seems 05:09:05 Unstable branch on crawl.jorgrun.rocks updated to: 0.19-a0-1448-g1485906 (34) 05:09:14 I modified it to choose only either blue and etc_fire in that function 05:09:18 it's rolled both 05:09:42 oh sure, it works; the question is whether it's guaranteed to work 05:10:06 or if we are just seeing particularly benevolent nasal demons at the moment 05:10:16 well, I was wondering if those values would just get clobbered down to something in the other enum 05:10:35 which wouldn't maybe generate a compiler warning since it's an explicit cast 05:10:38 but not what we want 05:10:57 what value is etc_fire anyhow 05:11:45 -!- kmckee24 has quit [Client Quit] 05:13:21 I should have run the compilations with full debug so I could run test 05:13:40 but my ccache has been abused enough! 05:14:14 well, reading http://en.cppreference.com/w/cpp/language/enum it looks like it's undefined behaviour depending on the possible values of the smaller enum 05:14:52 "The result is unspecified undefined behavior if the value, converted to the enumeration's underlying type, is out of this enumeration's range. [...] If the underlying type is not fixed, the range is all values possible for the smallest bit field large enough to hold all enumerators of the target enumeration." 05:15:27 since colour goes up to 16, and element_type starts at 32, i think any possible attempt to cast an element_type to a colour would be undefined behaviour, but vice versa would be fine 05:20:43 is it ok to simply cast to int? 05:21:14 it woudl be if we knew A and B were int-ish types 05:21:32 ah, I guess I assumed we only ever used that with enums/ints 05:21:33 we could do that if we brought back the specialization for const char* 05:21:54 yeah 05:22:15 otoh we have to cast back to T to return it anyway 05:22:59 well how did the old macro handle that anyhow? 05:23:06 it cast everything to int and silently promoted to T, where T was...i'm not sure, but i think the type of the first argument? 05:24:29 yeah, so it seems even the old version would have had a problem 05:24:32 or, no. it got args out of the va_list as T, and then cast them to int, and then returned int. but the function's return value was of type T, so i guess that silently promoted. but i'm not sure what T was inferred to be 05:24:36 yes 05:25:32 -!- muravey has quit [Quit: My Mac has gone to sleep. ZZZzzz…] 05:25:40 maybe |amethyst knows more about what can and can't be done there 05:25:59 it's hard to imagine he knows less 05:26:28 no it's fine, in 20 years or so I'll be proficient in C++ 05:26:37 then I can finally write some programs using the language 05:27:38 for c++ they should could it h-h-hello w-world??? 05:27:57 !tell |amethyst gammafunk and i couldn't tell if https://github.com/crawl/crawl/pull/348 was less spec-compliant than the old version or the same; i don't *think* it's more compliant, but who knows 05:27:57 amalloy: OK, I'll let |amethyst know. 05:28:36 Game crashes on loadup 13https://crawl.develz.org/mantis/view.php?id=10652 by kmckee24 05:28:55 or well, i guess it is more compliant because it doesn't auto-promote vararg lists 05:29:04 but then it has the issue with enums 05:30:29 I suspect it's actually fine for our usage 05:30:43 !tell |amethyst specifically in something like https://github.com/crawl/crawl/blob/master/crawl-ref/source/abyss.cc#L1477 it seems like both versions have an issue with converting element_type to colour, a smaller enum 05:30:43 amalloy: OK, I'll let |amethyst know. 05:34:13 -!- muravey has joined ##crawl-dev 05:34:13 you can't statically check that all values are valid for the specified type, but you're not going to catch that anyway 05:34:13 -!- Implojin has quit [Quit: Page closed] 05:34:26 except by an assert that the chosen item is within the appropriate range, after the call 05:34:41 (or passing limits to it for sanity checking) 05:40:03 -!- mibe has quit [Ping timeout: 264 seconds] 05:45:17 New branch created: pull/349 (2 commits) 13https://github.com/crawl/crawl/pull/349 05:45:17 03Catherine Ball02 07https://github.com/crawl/crawl/pull/349 * 0.19-a0-1449-g9c2bd4f: Clarified ctrl+click casting in tutorial. 10(16 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/9c2bd4f57f7f 05:45:17 03Catherine Ball02 07https://github.com/crawl/crawl/pull/349 * 0.19-a0-1450-g00ef413: Clarified ctrl+click casting in tutorial. 10(7 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/00ef413639f4 05:45:28 Clarify tutorial text regarding ctrl+click spellcasting 13https://crawl.develz.org/mantis/view.php?id=10654 by catleeball 05:45:28 Tutorial text for ctrl+click casting unclear 13https://crawl.develz.org/mantis/view.php?id=10653 by catleeball 05:54:38 -!- muravey has quit [Quit: My Mac has gone to sleep. ZZZzzz…] 06:00:01 -!- omarax has quit [Remote host closed the connection] 06:02:19 -!- muravey has joined ##crawl-dev 06:08:05 -!- djinni has quit [Ping timeout: 244 seconds] 06:08:24 -!- djinni has joined ##crawl-dev 06:19:37 -!- amalloy is now known as amalloy_ 06:21:29 -!- muravey has quit [Quit: My Mac has gone to sleep. ZZZzzz…] 06:28:00 -!- ProzacElf has quit [Ping timeout: 276 seconds] 06:30:51 -!- Furril has quit [Ping timeout: 240 seconds] 06:47:16 -!- jeefus is now known as jefus 06:51:21 -!- Implojin has joined ##crawl-dev 06:58:41 -!- Implojin has quit [Quit: Page closed] 07:00:02 -!- omarax has quit [Remote host closed the connection] 07:17:50 -!- muravey has joined ##crawl-dev 07:19:25 -!- pikaro has quit [Ping timeout: 250 seconds] 07:23:20 -!- debo_ has joined ##crawl-dev 07:24:37 -!- debo has quit [Read error: Connection reset by peer] 07:28:01 -!- muravey has quit [Quit: My Mac has gone to sleep. ZZZzzz…] 07:29:03 -!- muravey has joined ##crawl-dev 07:46:02 -!- mopl has quit [Ping timeout: 264 seconds] 07:55:26 -!- Yermak has quit [Quit: Page closed] 08:00:08 -!- omarax has quit [Remote host closed the connection] 08:05:46 <|amethyst> amalloy_: easiest way to make it not UB would be to specify the underlying type of enum COLOURS.. maybe int8_t for both that and element_type, since it needs to hold -1 08:12:44 -!- DrKe has quit [Read error: Connection reset by peer] 08:13:07 -!- DrKe has joined ##crawl-dev 08:14:11 <|amethyst> amalloy_: having the cast worries me a bit, because it seems like that would make it easy to do bad things like random_choose_weighted(10, "foo", 90, 0xba) 08:15:48 you can anyway; it's varargs, no type after the second parameter is checked 08:15:56 <|amethyst> it's not varargs anymore 08:16:03 <|amethyst> it's a vararg template 08:23:21 <|amethyst> oh, I guess you do get "invalid static_cast" 08:24:30 <|amethyst> amalloy_: still, it would be nice if it were willing to perform implicit (enum to integer) but not explicit (enum to other enum) conversions 08:26:48 -!- debo has joined ##crawl-dev 08:40:14 -!- } has quit [] 08:52:04 03|amethyst02 07* 0.19-a0-1449-g4a69e28: Perform only implicit conversions in random_choose_weighted. 10(20 minutes ago, 2 files, 8+ 8-) 13https://github.com/crawl/crawl/commit/4a69e283b570 08:57:57 -!- Lasty has joined ##crawl-dev 08:58:09 -!- debo has quit [Ping timeout: 276 seconds] 08:58:57 -!- mizu_no_oto has quit [Client Quit] 09:00:02 -!- omarax has quit [Remote host closed the connection] 09:01:39 -!- debo has joined ##crawl-dev 09:09:00 Unstable branch on crawl.jorgrun.rocks updated to: 0.19-a0-1449-g4a69e28 (34) 09:11:30 -!- Patashu has quit [Ping timeout: 244 seconds] 09:14:50 -!- Xenobreeder has quit [Ping timeout: 264 seconds] 09:32:36 -!- Daekdroom has quit [Quit: Leaving] 09:33:49 -!- MaxFrost has quit [Client Quit] 09:39:40 -!- PsyMar has quit [Ping timeout: 265 seconds] 09:39:45 -!- debo has quit [Ping timeout: 255 seconds] 09:42:40 -!- pottsy has quit [Ping timeout: 250 seconds] 09:48:13 -!- elliptic has quit [Quit: Leaving] 09:52:21 -!- Shard1697 has joined ##crawl-dev 09:55:41 -!- Dracunos has joined ##crawl-dev 10:00:24 -!- omarax has quit [Remote host closed the connection] 10:04:03 -!- Dracunos7 has quit [Ping timeout: 240 seconds] 10:08:00 -!- Dracunos7 has quit [Read error: Connection reset by peer] 10:10:08 -!- Dracunos-m has quit [Ping timeout: 250 seconds] 10:10:47 "Long stuff" 10:17:02 New branch created: pull/350 (1 commit) 13https://github.com/crawl/crawl/pull/350 10:17:02 03argonaut02 07https://github.com/crawl/crawl/pull/350 * 0.19-a0-1449-gd030218: Ring of Woe. The companion to Robustness/Shaolin/Shielding. 10(15 minutes ago, 3 files, 11+ 0-) 13https://github.com/crawl/crawl/commit/d03021840a5f 10:20:00 -!- debo has joined ##crawl-dev 10:21:29 03wheals02 {GitHub} 07* 0.19-a0-1450-g5eeaafc: Simplify weights. 10(13 seconds ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/5eeaafcf08ba 10:22:15 there was a comment "// 1/30" removed in the sentinel-removing commit 10:22:27 but i figured this was better than bringing back the comment 10:28:30 -!- sgun__ has quit [Ping timeout: 276 seconds] 10:28:46 -!- Smashy has quit [Ping timeout: 250 seconds] 10:39:09 -!- debo has quit [Quit: orb spiders :(] 10:39:24 -!- Patashu has joined ##crawl-dev 10:41:35 -!- mibert has joined ##crawl-dev 10:42:12 -!- elliptic has joined ##crawl-dev 10:42:56 -!- sgun_ has quit [Ping timeout: 244 seconds] 10:43:27 -!- VoxSomniator has quit [Read error: Connection reset by peer] 10:43:39 -!- hpm___ has quit [Ping timeout: 255 seconds] 10:51:02 -!- hpm_ has quit [Ping timeout: 244 seconds] 10:53:28 -!- PleasingFungus has joined ##crawl-dev 10:54:16 !tell amalloy recent simplifications to shout volumes were for monster shouts, not player shouts, which (naturally) work completely differently. the noise entry you were looking at is talking about player shouts 10:54:16 PleasingFungus: OK, I'll let amalloy know. 10:54:19 -!- NeremWorld has quit [Ping timeout: 244 seconds] 10:55:54 !tell amalloy player dragon-form shouts* 10:55:55 PleasingFungus: OK, I'll let amalloy know. 10:58:32 -!- Nerem has quit [Ping timeout: 265 seconds] 11:00:02 -!- omarax has quit [Remote host closed the connection] 11:05:13 -!- Shard1697 has quit [Ping timeout: 265 seconds] 11:07:34 -!- NeremWorld has quit [Ping timeout: 260 seconds] 11:08:04 -!- elliptic has quit [Quit: Leaving] 11:09:01 Unstable branch on crawl.jorgrun.rocks updated to: 0.19-a0-1450-g5eeaafc (34) 11:10:33 -!- Shard1697 has joined ##crawl-dev 11:11:09 -!- hpm_ has quit [Client Quit] 11:11:56 03Catherine Ball02 {PleasingFungus} 07* 0.19-a0-1451-g21b5904: Clarify ctrl+click casting in tutorial (10653) 10(6 hours ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/21b590487dc3 11:12:21 -!- amalloy_ is now known as amalloy 11:12:35 -!- MarvinPA has joined ##crawl-dev 11:12:40 PleasingFungus: i hate crawl 11:12:40 amalloy: You have 2 messages. Use !messages to read them. 11:12:54 lol 11:12:56 sad! 11:14:06 for the record, monster dragons are noise 12, player dragons are noise 18; unless you have berserkitis, in which case you can go up to noise 22 from shouting, louder than a fireball! 11:14:17 -!- minqmay has quit [Ping timeout: 244 seconds] 11:14:41 iirc player shouting has even been through a simplification pass in the not-too-distant past 11:14:41 MarvinPA: You have 1 message. Use !messages to read it. 11:14:43 -!- ontoclasm has joined ##crawl-dev 11:14:46 ah, i like that change, |amethyst. i didn't know you could explicitly specify T 11:14:51 -!- minmay has quit [Ping timeout: 264 seconds] 11:16:01 i know i poked at it, but i don't recall simplifying so much as refactoring 11:16:03 hm 11:16:10 i feel like we should respond to pr #345 in some way 11:16:30 -!- hpm_ has quit [Ping timeout: 255 seconds] 11:21:36 autoexploring to corpses is definitely a thing that'd be nice to have, which i think it does 11:23:34 i'd imagined that as a greedy_pickup-ish autoexplore option but rolling into autobutcher is probably fine too? 11:23:34 rolling it* 11:24:36 -!- hpm___ has quit [Ping timeout: 255 seconds] 11:26:22 what does this PR do when you worship fedhas? 11:26:46 probably the same thing 11:27:02 ditto if you have simulac or animate dead memorized 11:27:18 ps bring back chunk simulac 11:27:56 -!- hpm_ has quit [Ping timeout: 265 seconds] 11:35:40 -!- debo_ is now known as debo 11:35:57 oh, hm 11:36:04 someone probably needs to poke credits.txt 11:36:45 -!- hpm___ has quit [Ping timeout: 255 seconds] 11:36:54 -!- Brannock_ is now known as Brannock 11:43:03 -!- hpm_ has quit [Ping timeout: 255 seconds] 11:43:40 -!- wheals_ has joined ##crawl-dev 11:45:59 -!- TAS-2012v has joined ##crawl-dev 11:47:56 -!- ebering_ has joined ##crawl-dev 11:48:50 -!- shmup_ has joined ##crawl-dev 11:48:53 -!- mibert_ has joined ##crawl-dev 11:48:58 -!- qguv has quit [Ping timeout: 260 seconds] 11:48:59 -!- iFurril has quit [Ping timeout: 260 seconds] 11:48:59 -!- wheals has quit [Ping timeout: 260 seconds] 11:49:00 -!- Rjs has quit [Ping timeout: 260 seconds] 11:49:00 -!- whig has quit [Ping timeout: 260 seconds] 11:49:00 -!- TAS_2012v has quit [Ping timeout: 260 seconds] 11:49:01 -!- geekosaur has quit [Ping timeout: 260 seconds] 11:49:02 -!- voker57 has quit [Ping timeout: 260 seconds] 11:49:02 -!- paulr has quit [Ping timeout: 260 seconds] 11:49:03 -!- DashNine has quit [Ping timeout: 260 seconds] 11:49:03 -!- buki has quit [Ping timeout: 260 seconds] 11:49:03 -!- ebering has quit [Ping timeout: 260 seconds] 11:49:03 -!- cmcbot has quit [Excess Flood] 11:49:03 -!- squimmy has quit [Remote host closed the connection] 11:49:04 -!- mibert has quit [Ping timeout: 260 seconds] 11:49:04 -!- jooles has quit [Ping timeout: 260 seconds] 11:49:04 -!- shmup has quit [Ping timeout: 260 seconds] 11:49:16 -!- TAS-2012v is now known as TAS_2012v 11:49:47 -!- whig has joined ##crawl-dev 11:51:35 -!- edgefigaro has quit [Client Quit] 11:51:35 -!- Netmonmatt has quit [Quit: Going offline, see ya! (www.adiirc.com)] 11:53:23 -!- geekosaur has joined ##crawl-dev 11:54:30 03Michael Del Monte02 {PleasingFungus} 07* 0.19-a0-1452-g7e858c2: Add an auto_butcher option 10(2 days ago, 4 files, 24+ 1-) 13https://github.com/crawl/crawl/commit/7e858c24e4ba 11:54:57 -!- ebering_ is now known as ebering 11:54:57 -!- hpm___ has quit [Ping timeout: 255 seconds] 12:00:33 -!- omarax has quit [Remote host closed the connection] 12:01:30 -!- hpm_ has quit [Ping timeout: 255 seconds] 12:07:34 -!- elliptic has joined ##crawl-dev 12:07:46 -!- muravey has quit [Quit: My Mac has gone to sleep. ZZZzzz…] 12:08:58 Unstable branch on crawl.jorgrun.rocks updated to: 0.19-a0-1452-g7e858c2 (34) 12:09:34 -!- hpm___ has quit [Ping timeout: 258 seconds] 12:11:47 -!- hpm_ has quit [Ping timeout: 255 seconds] 12:13:41 -!- Blazinghand has joined ##crawl-dev 12:14:52 -!- hpm___ has quit [Ping timeout: 240 seconds] 12:17:23 Game crashes after traveling to Elf:1, crashes on loading save 13https://crawl.develz.org/mantis/view.php?id=10655 by Brannock 12:17:56 someone else needs to download that one, i still don't have access to saves on cjr 12:18:05 I hope that one's fixable :x 12:18:11 I'm in the middle of another winstreak! 12:18:18 haha 12:18:24 it's probably the salt thing 12:18:28 Yeah I figured 12:18:32 Not sure what'd be causing it though 12:18:34 Specifically, I mean 12:19:16 03amalloy02 07* 0.19-a0-1453-gcd7e1ee: Use the reference instead of array indexing over and over 10(23 seconds ago, 1 file, 9+ 11-) 13https://github.com/crawl/crawl/commit/cd7e1eef16ed 12:19:41 -!- Bammboo has quit [Read error: Connection reset by peer] 12:21:13 nice 12:21:57 i imagine the compiler was doing that optimization already anyway, but it's also more readable 12:23:07 it's unwise to overestimate compilers, but i wouldn't worry about the optimization anyway 12:23:18 readability & de-duplication is a good enough reason for the change 12:27:56 -!- hpm_ has quit [Ping timeout: 250 seconds] 12:32:14 another crash, this one on CBRO 12:32:22 this one after using explore to go down a floor 12:33:10 and it's a double panic, apparently (that is, crashes again trying to report the crash, probably while doing the backtrace) 12:33:32 -!- hpm___ has quit [Ping timeout: 240 seconds] 12:33:41 is that why Jorgrell didn't report my crash from yesterday? 12:34:25 ya 12:34:31 the common thread between both crashes is using 'G' to travel 12:34:44 i wonder if it has something to do with that zigzag crash 12:34:46 hm 12:35:03 %git 85929694eb70c9abb635910de6f7ca2746e8ee04 12:35:04 07Brannock02 * 0.19-a0-1355-g8592969: Allow waterwalkers to autoexplore deep water (10503) 10(4 days ago, 1 file, 5+ 2-) 13https://github.com/crawl/crawl/commit/85929694eb70 12:35:18 probably not this. 12:38:00 no playing crawl for me on labor day I guess! 12:38:07 I guess I'll get back to working on my todos 12:38:30 -!- hpm_ has quit [Ping timeout: 244 seconds] 12:44:31 !seen amalloy 12:44:31 I last saw amalloy at Mon Sep 5 16:21:57 2016 UTC (22m 34s ago) saying 'i imagine the compiler was doing that optimization already anyway, but it's also more readable' on ##crawl-dev. 12:44:40 sorry PleasingFungus, that person is dead 12:44:48 ! 12:44:52 -!- hpm___ has quit [Ping timeout: 265 seconds] 12:45:01 >mfw armour of the dragon king dropped 5 floors ago and I only just now happened to find it while ctrl+Fing artifacts 12:45:03 hm, got the save from cbro, so amalloy may be redundant and deprecated 12:45:16 mfw rast meant to send that in ##crawl 12:45:34 No, I mean to say that crawl by default should do a better job of highlighting good wearables 12:45:53 so you dont just autoexplore past them 12:46:18 we should color code them 12:46:23 the best ones can be purple, or gold 12:46:27 or white, right 12:46:46 but if they are in a big pile of gear you can easily miss them 12:46:49 no, whites are the boring vanilla ones. obviously 12:46:58 !source can_convert_to_beogh 12:46:59 1/1. https://github.com/crawl/crawl/blob/master/crawl-ref/source/godabil.cc#L3871 12:47:42 Brannock: what race is your other character? 12:47:42 both are Hill Orc 12:47:54 the plot thickens 12:47:55 =dump 12:47:55 https://crawl.jorgrun.rocks/morgue/brannock/brannock.txt 12:48:46 -!- Kellhus has quit [Quit: Page closed] 12:48:52 oh 12:48:55 it's amalloy's fault 12:49:00 ! 12:49:00 that's good. simple 12:49:06 constify changes? 12:49:08 yep 12:49:21 if only we had code review... 12:49:32 so 3878 should be constified I'm guessing 12:49:53 ??? it is constified? 12:49:53 I don't have a page labeled ?_it_is_constified? in my learndb. 12:50:04 * to & I mean 12:50:08 no 12:50:20 think about what monster_at() produces 12:50:22 Brannock: that's not really the same thing as constifying 12:50:51 if you ask "what monster is at a given location", what possible results can you get? 12:51:14 the type of the monster, or nothing? 12:51:20 don't we have a monster_near_iterator, or something? 12:51:23 so this nonsense can't happen 12:51:36 we do 12:51:52 hm, this is set up so you can convert even if the priest is invisible 12:51:53 cool 12:52:18 You hear a voice exhorting you to follow Beogh! 12:52:29 amalloy: i'm fixing it, btw 12:52:32 thx 12:53:17 what was the answer to the monster_at() thing? 12:53:17 Brannock: the point is that it might be nothing 12:53:17 so you shouldn't just dereference it without looking 12:53:25 where is it dereferenced? 12:53:31 on the following line 12:53:51 so it returns nothing, then sends nothing to mons_allows_beogh_now()? 12:53:58 if (mons_allows_beogh_now(*mon)) 12:54:10 *mon is a bad plan if mon is nullptr 12:55:28 03PleasingFungus02 07* 0.19-a0-1454-g889e34b: Fix HO/orc priest crash (Brannock) 10(2 minutes ago, 1 file, 2+ 5-) 13https://github.com/crawl/crawl/commit/889e34bb27c2 12:55:53 we never get to mons_allows_beogh_now because we dereference a null pointer first 12:56:04 very surprised we haven't had a wave of bug reports from that 12:56:07 I think today or tomorrow I'm going to sit down and study C++ pointers/references because I keep running into this and getting confused by it 12:56:16 PleasingFungus, on the first crash I had cleared out Orc entirely without problems 12:56:20 bizarre 12:56:24 dang, you didn't name names in the commit message. should be "amalloy's crash" imo 12:56:26 I only had problems once I began using 'G' 12:56:32 -!- hpm_ has quit [Ping timeout: 240 seconds] 12:56:35 lol 12:56:39 so narcissistic! 12:57:14 !source areas.cc:336 12:57:15 https://github.com/crawl/crawl/blob/master/crawl-ref/source/areas.cc#L336 12:57:17 this has **mi 12:57:21 can you double reference something 12:57:24 how's that work? 12:57:29 if it's a double pointer, then ues 12:57:31 you can have pointers to pointers 12:57:32 *yes 12:57:37 to pointers to pointers to pointers... 12:58:05 int x = 5, *y = &x, **z = &y; 12:58:15 then **z evaluates to 5 12:58:33 in what way is that differen than 'int x = 5, y = x, z = y'? 12:59:06