00:00:03 -!- omarax has quit [Remote host closed the connection] 00:01:38 -!- Pacra has joined ##crawl-dev 00:07:55 -!- vfoley has quit [Ping timeout: 260 seconds] 00:10:42 -!- xnavy_ is now known as xnavy 00:14:07 -!- ussdefiant_Lappy has joined ##crawl-dev 00:17:14 -!- Pacra has quit [Read error: Connection reset by peer] 00:17:29 -!- Pacra has joined ##crawl-dev 00:21:30 -!- Pacra has quit [Read error: Connection reset by peer] 00:21:45 -!- Pacra has joined ##crawl-dev 00:27:10 -!- mizu_no_oto has quit [Quit: Computer has gone to sleep.] 00:29:13 -!- Grivan has quit [Ping timeout: 276 seconds] 00:29:20 Unstable branch on CRAWL.XTAHUA.COM updated to: 0.18-a0-1677-g2bdad6c (34) 00:32:51 -!- FireSight has quit [] 00:33:22 -!- ProzacElf has joined ##crawl-dev 00:35:24 -!- FunkyBomb has quit [Read error: Connection reset by peer] 00:45:45 -!- Kalir has quit [Changing host] 00:50:18 -!- debo_ has joined ##crawl-dev 00:50:42 -!- debo_ is now known as Guest74764 00:54:41 -!- mibe has quit [Ping timeout: 250 seconds] 01:00:03 -!- omarax has quit [Read error: Connection reset by peer] 01:01:11 -!- mibe has quit [Ping timeout: 250 seconds] 01:08:51 -!- Rast- has joined ##crawl-dev 01:11:32 Unstable branch on crawl.s-z.org updated to: 0.18-a0-1677-g2bdad6c (34) 01:12:03 -!- Athaboros has quit [Ping timeout: 244 seconds] 01:12:13 -!- Rast has quit [Ping timeout: 250 seconds] 01:14:37 -!- sysice has quit [Ping timeout: 250 seconds] 01:19:46 Unstable branch on crawl.develz.org updated to: 0.18-a0-1677-g2bdad6c (34) 01:32:17 is it intended that if I cast LRD with death channel activated, the LRD fragments can actually destroy the spectral creatures formed during that action? 01:32:34 A glowing mist starts to gather... 01:32:34 The blast of petrified fragments hits your spectral crocodile. 01:32:34 You destroy your spectral crocodile! 01:33:22 -!- simmarine has quit [Read error: Connection reset by peer] 01:37:07 -!- geekosaur has quit [Excess Flood] 01:38:20 -!- geekosaur has joined ##crawl-dev 01:42:33 -!- Guest74764 has quit [Ping timeout: 250 seconds] 01:46:23 -!- Pacra has quit [Ping timeout: 268 seconds] 01:48:17 -!- Blade- has joined ##crawl-dev 01:54:44 Windows builds of master branch on crawl.develz.org updated to: 0.18-a0-1677-g2bdad6c 01:55:02 -!- Harudoku has quit [Ping timeout: 268 seconds] 01:56:11 -!- sysice_ has quit [Quit: Page closed] 01:58:59 -!- amalloy_ is now known as amalloy 02:00:03 -!- omarax has quit [Remote host closed the connection] 02:00:04 -!- ystael has quit [Ping timeout: 240 seconds] 02:02:15 -!- KurzedMetal has quit [Read error: Connection reset by peer] 02:05:44 -!- bgiannan_ has joined ##crawl-dev 02:18:56 -!- amalloy is now known as amalloy_ 02:21:24 -!- Zeor has quit [Quit: Leaving.] 02:21:49 -!- sorlin has quit [Quit: Leaving.] 02:31:13 G-Flex: same problem is present with giant spores, you get weird message ordering and hurt the created ballistomycetes 02:31:25 ah 02:31:53 giant spores are mostly gone now though 02:32:57 -!- elliptic has quit [Ping timeout: 264 seconds] 02:34:05 just fedhas? 02:46:03 -!- Datul has quit [Ping timeout: 250 seconds] 02:51:57 -!- Twiggytwiggytwig has quit [Quit: See ya guys later ;)] 02:53:03 -!- Kalir has quit [Quit: I'M OUT SON. PEACE, LOVE, EXPLOSIONS.] 02:53:26 -!- elliptic has joined ##crawl-dev 02:53:42 Monster database of master branch on crawl.develz.org updated to: 0.18-a0-1677-g2bdad6c 02:55:22 -!- PigBenis has quit [Quit: Page closed] 03:00:03 -!- omarax has quit [Remote host closed the connection] 03:11:49 -!- ProzacElf has quit [Ping timeout: 250 seconds] 03:24:28 Unstable branch on crawl.beRotato.org updated to: 0.18-a0-1677-g2bdad6c (34) 03:26:57 -!- Blade- has quit [Ping timeout: 244 seconds] 03:35:11 -!- Adeon has quit [Ping timeout: 244 seconds] 03:35:55 -!- Adeon has joined ##crawl-dev 03:38:25 -!- Insomniak` has quit [Quit: I like to rock] 03:43:53 rip april fools 03:47:06 -!- GauHelldragon has quit [Ping timeout: 244 seconds] 03:47:45 -!- Marvin is now known as Guest51937 03:50:16 -!- koboldina has quit [Quit: Page closed] 03:51:03 -!- namelastname112 has quit [Ping timeout: 250 seconds] 03:55:21 -!- rossi has quit [Ping timeout: 244 seconds] 04:00:04 -!- omarax has quit [Remote host closed the connection] 04:11:25 -!- svendre has quit [Ping timeout: 250 seconds] 04:12:23 -!- ystael has quit [Ping timeout: 244 seconds] 04:19:08 -!- ussdefiant_Lappy has quit [Ping timeout: 244 seconds] 04:21:21 -!- NotKat has quit [Quit: I think 0.12 is for everyone] 04:22:59 -!- NotK is now known as NotKat 04:27:34 -!- pikaro has quit [Ping timeout: 240 seconds] 04:35:16 -!- Guest51937 has quit [Remote host closed the connection] 04:38:15 -!- chequers_ has quit [Ping timeout: 244 seconds] 04:39:08 -!- chequers has joined ##crawl-dev 04:43:38 -!- Bcadren has quit [Ping timeout: 252 seconds] 04:44:02 -!- Marvin is now known as Guest90617 04:48:45 -!- Elitist has quit [Quit: Page closed] 04:56:02 -!- Ququman has joined ##crawl-dev 04:59:07 -!- Idolo has quit [] 05:00:02 -!- omarax has quit [Remote host closed the connection] 05:01:37 -!- ontoclasm has quit [Quit: Leaving.] 05:04:28 -!- sorlin has quit [Ping timeout: 260 seconds] 05:08:43 -!- edsrzf has quit [Ping timeout: 276 seconds] 05:31:34 -!- Blazinghand has joined ##crawl-dev 05:53:11 -!- Tiltorax has joined ##crawl-dev 05:53:54 -!- Tiltorax has quit [Client Quit] 05:54:27 -!- Tiltorax has joined ##crawl-dev 06:00:02 -!- omarax has quit [Remote host closed the connection] 06:02:41 -!- eb has quit [] 06:04:36 -!- sorlin1 has quit [Ping timeout: 276 seconds] 06:09:17 -!- sorlin has quit [Read error: Connection reset by peer] 06:10:56 -!- NotKat has quit [Quit: Change "Mephitic Cloud" to "Mephitic Fart"] 06:16:55 -!- Torax_ has joined ##crawl-dev 06:18:48 -!- Tiltorax has quit [Ping timeout: 250 seconds] 06:21:53 -!- Leszczynek has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/] 06:22:30 -!- Torax_ is now known as Tiltorax 06:24:03 -!- ystael has quit [Ping timeout: 248 seconds] 06:31:54 -!- vale_ has quit [Remote host closed the connection] 06:46:58 -!- jj12 has quit [Ping timeout: 250 seconds] 06:51:57 -!- sorlin has quit [Read error: Connection reset by peer] 06:55:06 -!- Hellmonk has quit [Quit: Page closed] 06:56:40 -!- HellTiger_NB has quit [Read error: Connection reset by peer] 07:00:01 -!- omarax has quit [Remote host closed the connection] 07:03:30 -!- MarvinPA has joined ##crawl-dev 07:04:22 Tree & Conf & Reach (with V-key) = "You're too confused to attack without stumbling around" 13https://crawl.develz.org/mantis/view.php?id=10339 by RoGGa 07:06:33 i was so sure i'd handled all the silly treeform/confusion interactions 07:06:45 what a fool i was 07:08:43 although maybe that's actually the correct behaviour, i forget how reaching + confusion normally works now 07:09:31 -!- bgiannan_ has quit [Ping timeout: 268 seconds] 07:12:35 -!- spring_break_08 has quit [Ping timeout: 248 seconds] 07:13:58 -!- Guest90617 has quit [Remote host closed the connection] 07:15:57 -!- CKyle has joined ##crawl-dev 07:16:52 -!- mibe has quit [Ping timeout: 250 seconds] 07:20:32 -!- bgiannan_ has joined ##crawl-dev 07:21:56 i guess it is correct behaviour and just needs a better message 07:33:12 -!- Tux[Qyou] has joined ##crawl-dev 07:37:00 -!- vale_ has quit [Ping timeout: 244 seconds] 07:37:41 -!- CKyle has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 07:40:12 -!- Tiltorax has quit [Quit: Page closed] 07:40:12 -!- n1 has quit [Read error: Connection reset by peer] 07:40:37 -!- n1 has joined ##crawl-dev 07:43:09 03MarvinPA02 07* 0.18-a0-1678-gfbe1ab0: Use a canned message for reaching while confused (#10339) 10(7 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/fbe1ab039f67 07:48:30 -!- Blazinghand has quit [Read error: Connection reset by peer] 07:52:35 -!- siepu has quit [Read error: Connection reset by peer] 07:58:54 -!- Jessika has quit [Ping timeout: 250 seconds] 08:00:02 -!- omarax has quit [Remote host closed the connection] 08:15:55 -!- tripout has quit [Ping timeout: 252 seconds] 08:19:04 -!- bgiannan_ has quit [Ping timeout: 260 seconds] 08:19:07 -!- Patashu_ has joined ##crawl-dev 08:21:37 -!- Patashu has quit [Ping timeout: 260 seconds] 08:30:55 -!- MarvinPA has quit [Ping timeout: 268 seconds] 08:33:19 -!- Twiggytwiggytwig has quit [Quit: See ya guys later ;)] 08:37:33 -!- vale_ has quit [Ping timeout: 240 seconds] 08:51:36 -!- Marvin is now known as Guest87988 08:51:55 -!- Zxpr1jk has quit [Quit: Leaving] 08:56:12 -!- Guest87988 has quit [Ping timeout: 268 seconds] 09:00:02 -!- omarax has quit [Remote host closed the connection] 09:03:13 -!- insecticide has quit [Ping timeout: 252 seconds] 09:06:30 -!- Aurelian has quit [Ping timeout: 250 seconds] 09:40:22 -!- vale_ has quit [Ping timeout: 260 seconds] 09:48:19 -!- Daekdroom has quit [Remote host closed the connection] 09:50:48 -!- Patashu_ has quit [Ping timeout: 244 seconds] 09:57:20 -!- njorth has quit [Quit: leaving] 10:00:02 -!- omarax has quit [Remote host closed the connection] 10:04:19 -!- G-Flex has quit [Ping timeout: 248 seconds] 10:06:52 -!- Lasty has joined ##crawl-dev 10:27:35 -!- rkd has quit [Quit: Page closed] 10:29:18 -!- NotKat has quit [Quit: Page closed] 10:31:21 -!- G-Flex has joined ##crawl-dev 10:33:52 -!- CKyle has joined ##crawl-dev 10:34:00 -!- CKyle has quit [Client Quit] 10:39:06 -!- stanzstanz has quit [Changing host] 10:40:30 -!- toot has quit [Client Quit] 10:42:13 -!- stanzwas has quit [Ping timeout: 252 seconds] 10:56:05 -!- Tux[Qyou] has quit [Read error: Connection reset by peer] 11:00:02 -!- omarax has quit [Remote host closed the connection] 11:00:34 -!- sneakynesss has quit [Ping timeout: 240 seconds] 11:04:40 -!- Kalir has quit [Changing host] 11:08:35 -!- ussdefiant_Lappy has joined ##crawl-dev 11:10:55 -!- ystael has quit [Ping timeout: 244 seconds] 11:14:20 -!- mibe has quit [Ping timeout: 250 seconds] 11:16:46 -!- sneakyness has joined ##crawl-dev 11:19:12 -!- advil has joined ##crawl-dev 11:19:32 -!- Xenobreeder has quit [Ping timeout: 250 seconds] 11:19:37 -!- Twiggytwiggytwig has quit [Ping timeout: 252 seconds] 11:21:14 anyone around who knows about how qazlal was historically supposed to work? 11:21:31 I'm trying to fix 10293 since no one fixed it for me and I ran into some questions 11:22:43 (the quick fix was easy enough unless it leads to weird sequencing stuff in beam.cc, which it could) 11:23:09 -!- simmarine has joined ##crawl-dev 11:24:12 -!- Bcadren has quit [Ping timeout: 268 seconds] 11:25:03 -!- KurzedMetal has quit [Ping timeout: 276 seconds] 11:26:32 -!- sneakyness has quit [Ping timeout: 260 seconds] 11:26:50 -!- sneakyness has joined ##crawl-dev 11:34:32 -!- graymark has quit [Quit: Page closed] 11:39:30 -!- scummos__ has quit [Ping timeout: 246 seconds] 11:44:58 well so main question #1: was qazlal elemental adaptation supposed to scale with damage? Right now for the cases where it works at all it is mostly constant chance 2 / piety_rank 11:45:06 with some special casing for a few spells 11:45:12 e.g. refrigerate is 5 chances in piety rank 11:46:01 -!- pocketmulch is now known as cromulent 11:46:25 (part of the issue may be that the number that supplies the numerator for that is apparently used in a somewhat different way by the rest of expose_to_element) 11:46:45 (the comments describe it as being a number of turns, but that seems to be very very old?) 11:47:15 the other complication is that expose_to_element is double-called for brand damage 11:47:18 I'm still tracking that down 11:51:20 -!- tealeaves has quit [Quit: Bye] 11:53:09 -!- Marvin is now known as Guest87540 11:57:27 -!- Guest87540 has quit [Ping timeout: 260 seconds] 11:58:14 -!- Kellhus has quit [Quit: Page closed] 12:00:02 -!- omarax has quit [Remote host closed the connection] 12:00:13 -!- Blade- has joined ##crawl-dev 12:02:54 ah ok, it's called twice with different flavours, so not really double-called 12:04:27 -!- KurzedMetal has quit [Ping timeout: 260 seconds] 12:10:13 -!- ussdefiant_Lappy has quit [Ping timeout: 252 seconds] 12:16:46 sorry, that should have read constant chance 2 / (11-piety_rank) 12:16:51 so 2/5 at max piety 12:18:59 -!- mamgar has quit [Quit: Exit Stage Left] 12:22:13 also a random unrelated question: why do the web-based logs for ##crawl-dev on s-z report leaving messages for ##crawl? (at least I think that's what it is.) 12:23:29 -!- ProzacElf has joined ##crawl-dev 12:25:01 -!- Ququman has quit [Read error: Connection reset by peer] 12:32:34 -!- KurzedMetal has quit [Ping timeout: 240 seconds] 12:38:26 -!- dtsund has joined ##crawl-dev 12:38:59 -!- tealeaves has quit [Quit: Bye] 12:41:20 -!- nikheizen has joined ##crawl-dev 12:42:46 -!- siepu has quit [Read error: Connection reset by peer] 12:44:09 -!- jehoesefat has quit [Quit: Page closed] 12:46:17 -!- Ratboiler has quit [Quit: Page closed] 12:47:04 -!- CcS has quit [Ping timeout: 252 seconds] 12:47:40 -!- bgiannan_ has joined ##crawl-dev 12:54:48 -!- amalloy_ is now known as amalloy 12:58:07 -!- bgiannan_ has quit [Ping timeout: 260 seconds] 13:00:03 -!- omarax has quit [Remote host closed the connection] 13:00:55 -!- Kalir has quit [Quit: I'M OUT SON. PEACE, LOVE, EXPLOSIONS.] 13:01:04 -!- insecticide has quit [Ping timeout: 264 seconds] 13:01:16 -!- amalloy is now known as amalloy_ 13:05:06 -!- Leszczynek has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/] 13:06:35 -!- amalloy_ is now known as amalloy 13:06:44 -!- tsujin has quit [Ping timeout: 248 seconds] 13:08:22 -!- MarvinPA has joined ##crawl-dev 13:10:25 -!- debo has quit [Read error: Connection reset by peer] 13:12:41 -!- tealeaves has quit [Quit: Bye] 13:15:53 -!- debo has joined ##crawl-dev 13:16:46 -!- amalloy is now known as amalloy_ 13:20:45 -!- Twiggytwiggytwi_ has quit [Quit: See ya guys later ;)] 13:23:54 -!- Marvin is now known as Guest8975 13:24:27 -!- ystael has quit [Ping timeout: 268 seconds] 13:25:17 Unstable branch on crawl.akrasiac.org updated to: 0.18-a0-1678-gfbe1ab0 (34) 13:26:28 -!- pikaro has quit [Ping timeout: 248 seconds] 13:28:10 hm duration of the qaz adaptations is also scaled by the same strength parameter that is used for probability, which is going to lead to weird results in some of the special casing 13:28:33 -!- Guest8975 has quit [Ping timeout: 276 seconds] 13:30:25 <|amethyst> advil: another thing to keep in mind 13:30:59 <|amethyst> advil: if you change what things call expose_to_element, that will also change which kinds of effects cause cold-blooded slowing, Ozo's armour melting, etc 13:31:12 yeah, I'm testing some of that 13:31:18 it seems like a bunch of that is currently not working too 13:31:29 <|amethyst> oh, I guess slow_cold_blood is a parameter that can be turned off 13:31:35 I haven't tested ozo's yet but for example I don't think bolt of cold currently slows draconians 13:32:27 <|amethyst> ah, so it seems 13:32:36 there is really just one missing call to expose_to_element, which needs to be called in beam 13:32:36 at least that I've found 13:33:30 so this fix will buff qaz (a lot I think, for example he does nothing for OOFs right now) but is actually a noticeable nerf for dracs in my testing 13:33:49 frost giants are quite effective against them with the fix 13:34:29 Q: should damnation trigger physical protection? 13:34:56 <|amethyst> I would imagine not 13:35:04 <|amethyst> since AC doesn't help against damnation 13:35:48 ah duh 13:36:09 there is actually a call to expose_to_element for damnation which is why I was asking, but it doesn't seem to do anything 13:36:21 -!- Blade- has quit [Ping timeout: 276 seconds] 13:36:42 <|amethyst> advil: that can probably go 13:36:52 <|amethyst> advil: I imagine it came from when hellfire melted ozo's armour 13:37:01 ok yeah that makes sense 13:37:11 <|amethyst> alternatively, it can stay, and expose_player_to_element can just ignore it 13:37:55 hmm I wonder if it does anything for monsters 13:38:09 -!- Blade- has joined ##crawl-dev 13:38:16 in general expose_to_element is somewhat different for monsters, I haven't looked at it closely 13:38:17 <|amethyst> monster::expose_to_element(BEAM_DAMNATION, ...) does not currently 13:38:21 <|amethyst> oh, here's something 13:38:33 a lot of calls use the strength parameter quite differently for monsters 13:38:50 <|amethyst> it looks like qazlal_element_adapt uses DUR_QAZLAL_AC for BEAM_MISSILE and BEAM_FRAG 13:38:56 yeah 13:39:02 it is missing MMISSILE incidentally 13:39:06 <|amethyst> but zap-data.h shows that Iron Shot uses 13:39:07 <|amethyst> yeah, that 13:39:13 yeah found that one :) 13:39:15 LCS also 13:39:24 <|amethyst> and IMB and stone arrow and magic dart 13:39:33 <|amethyst> and a few others 13:39:42 <|amethyst> s/a few/several/ 13:39:56 another question is what to do about magma / poison arrow. 13:40:27 <|amethyst> hm 13:40:38 right now magma checks only fire, parrow does nothing 13:40:48 <|amethyst> magma checking only fire is fine I think 13:41:12 <|amethyst> just like throw icicle only counts as cold despite being partially irresistible 13:41:26 ah right icicle too 13:41:26 <|amethyst> for Qaz purposes 13:41:55 ok 13:42:02 that's easy, since it doesn't involve doing anything 13:43:13 do you know the answer to the question about scaling? 13:43:22 <|amethyst> not sure about parrow... maybe it should count as physical here, but maybe not 13:43:34 the easiest solution is just to keep it constant, that seems ok (though maybe a little weak) in testing 13:44:01 the other option would be to ensure something like at maxhp damage qaz always triggers the resist 13:44:20 at max piety 13:44:30 -!- PleasingFungus has joined ##crawl-dev 13:44:33 which is in line with what refrigerate does (always triggers at max piety) 13:44:46 <|amethyst> I don't think it's supposed to scale with damage 13:44:50 ok 13:45:00 <|amethyst> ? 13:45:06 <|amethyst> what do you mean about refrig? 13:45:17 <|amethyst> oh, I guess it has high strength 13:45:19 refrigerate is called with a different strength parameter for some reason 13:45:32 strength is used in different ways by almost everything that this function does 13:45:42 so it's kind of a weird thing 13:46:36 <|amethyst> yeah, that strength parameter is silly 13:46:48 -!- ontoclasm has joined ##crawl-dev 13:47:07 I've also changed the scaling of adaptation duration to be constant, not dependent on strength, for that reason 13:47:56 <|amethyst> what constant? 13:48:02 <|amethyst> I would be concerned about buffing too much 13:48:04 -!- amalloy_ is now known as amalloy 13:48:13 2, which is the "normal" value for strength 13:48:24 nothing calls it with 1 13:48:29 and with 0 qaz won't trigger 13:48:31 <|amethyst> that sounds reasonable 13:48:35 so that is basically the floor of what can happen now 13:49:20 so you.increase_duration(dur, 10 * strength, 80); => you.increase_duration(dur, 20, 80); 13:49:42 it might actually be a little bit long? but adaptation still only triggers 2/5 times in most cases 13:53:31 -!- CKyle has joined ##crawl-dev 13:57:11 -!- BlatancyHS has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client] 14:00:04 -!- omarax has quit [Remote host closed the connection] 14:00:21 <|amethyst> advil: btw, Grunt, whenever he's around, is probably the person to talk to about the intent 14:00:38 ok, thanks 14:01:00 maybe_melt_player_enchantments is also called from check_your_resists, which leads to weird things 14:02:40 <|amethyst> oh, wow 14:02:51 <|amethyst> and passes the full amount of damage 14:02:58 yeah 14:03:08 whereas expose will pass strength or 10 if str is 0 14:03:10 <|amethyst> so the 2 or 4 or whatever in expose_player_to_element probably has little effect here 14:03:33 except to lead to weird message ordering 14:04:04 <|amethyst> imo set it all on fire and start over 14:04:15 -!- amalloy is now known as amalloy_ 14:04:26 <|amethyst> the whole codebase or the whole expose_to_element system, whichever is more convenient :) 14:04:43 heh that is also my instinct but this is my first time dealing with crawlcode so I'm not sure I'm ready to take that on 14:04:51 -!- dtsund has quit [Ping timeout: 250 seconds] 14:04:54 expose_to_element is clearly vestigial 14:05:00 <|amethyst> yeah 14:05:16 <|amethyst> it exists because of item destruction 14:05:37 <|amethyst> and then whatever got layered on top of that 14:06:09 I've added a detailed comment documenting (as far as I can tell) what exactly it currently does, so that is the first step at least 14:06:18 <|amethyst> yay 14:06:33 I'd say that melt_ should be removed from expose_to_element, but also it isn't getting triggered for magma for some reason 14:06:38 presumably other spells given that 14:07:16 oh I'm wrong about that 14:07:23 I think it just can be removed from expose_to_element 14:07:51 <|amethyst> oh, err 14:07:54 <|amethyst> also I wonder about 14:08:04 <|amethyst> the call to check_your_resists in _print_resist_message 14:08:10 -!- KurzedMetal has quit [Quit: Leaving.] 14:08:20 I can see why no one went after this bug when I posted it ;) 14:08:24 <|amethyst> that might be the cause of some of the double stuff on brands 14:08:46 I was wrong about the doubling on brands at least the way I stated it: 14:09:00 <|amethyst> IMO check_your_resists is a terrible name for a function that does what this one does 14:09:05 first it calls expose_to_element with BEAM_MISSILE to simulate physical damage for qaz purposes 14:09:15 and then it calls with the brand flavour 14:09:18 03PleasingFungus02 07* 0.18-a0-1679-g1593aa5: Fix Sniper inscription 10(30 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/1593aa571c91 14:09:35 if adaptation files for the first call it is prevented for the second one 14:09:40 *fires 14:11:17 <|amethyst> oh, I see 14:11:41 <|amethyst> because the expose_to_element(missile, 2) comes from the attack flavour code, which is different from melee brand 14:11:49 <|amethyst> s/melee brand/melee weapon brand/ 14:12:17 intuitively it seems like expose_player_to_element should be merged with check_your_resists, but I don't know enough to do that myself right now 14:12:43 basically in the way someone already did for melting 14:12:57 then the qaz thing would need to be called directly in few cases 14:14:30 although the sequencing may be wrong 14:14:37 I'm just going to PR a conservative fix 14:18:27 03PleasingFungus02 07* 0.18-a0-1680-g7c4da81: Fix spectral weapon pluralisation 10(23 seconds ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/7c4da8119b0d 14:19:27 -!- Bcadren has quit [Ping timeout: 244 seconds] 14:20:31 -!- CacoS_ is now known as CcS 14:20:39 hrm 14:20:42 this gozag wrath code is 14:20:43 dubious 14:21:15 hrmmm 14:21:37 <|amethyst> PleasingFungus: oh, I guess the problem with pluralization is that we're merging all the spectrals in mpr_monster_list, but then picking a single one as an exemplar 14:21:52 -!- ontoclasm has quit [Quit: Leaving.] 14:22:05 the code specifically notes that we assume everything from [start, end) is identical 14:22:11 and we do want to merge them into one entry - ditto for ugly things etc 14:22:20 but they aren't actually identical 14:22:21 hm 14:22:22 <|amethyst> yeah 14:22:23 i wonder 14:22:41 <|amethyst> though if they *are* identical in those ways, it would be nice to be more specific 14:22:43 we don't merge hydras at all 14:22:53 inconsistent 14:23:03 er, we don't merge hydras with different head counts, anyway 14:23:24 <|amethyst> what would be nice is if we had a function that takes a bunch of monster_infos, and gives you back a monster_info that has been suitably genericised 14:23:39 <|amethyst> OTOH, that means we'd need a way to represent those genericised things 14:23:54 are there cases where we'd need more than a string? 14:24:01 a colourized string, mabye 14:24:36 <|amethyst> tiles maybe 14:24:54 -!- PleasingFungus has left ##crawl-dev 14:24:58 <|amethyst> I guess we show icons for each monster though, not just the row? 14:24:58 -!- PleasingFungus has joined ##crawl-dev 14:25:00 <|amethyst> I don't remember 14:25:04 what can we do in tiles *but* use an exemplar? 14:25:14 <|amethyst> true 14:25:25 <|amethyst> generic TILE_MONS_GENERIC_UGLY_THING 14:25:30 <|amethyst> but yeah 14:25:32 -!- breaking has quit [Quit: Page closed] 14:26:00 <|amethyst> maybe _get_monster_name could then take a range of monster_infos from an array, rather than a count 14:26:12 <|amethyst> s/than a count/than a single monster_info and a count/ 14:26:36 -!- Marvin is now known as Guest41323 14:26:55 <|amethyst> then describe.push_back(_get_monster_name(mons + i - count], mons + i - 1, true)) 14:26:58 <|amethyst> ohh 14:27:04 <|amethyst> btw 14:27:23 <|amethyst> there are two worse-than-pointless.c_str()s there in mpr_monster_list 14:28:00 <|amethyst> it's converting from the string that _get_monster_name returns to the raw C string pointer, then constructing a new string object 14:28:51 <|amethyst> granted, there has to be a copy anyway, but this potentially has one more copy that it should, and anyway it's needless complexity 14:29:01 nice 14:29:17 <|amethyst> at least it's not as bad as I thought on first glance 14:29:22 oh? 14:29:25 -!- Lasty has quit [Quit: Leaving.] 14:29:36 <|amethyst> at first I thought maybe describe was a vector or such 14:29:45 <|amethyst> in which case this would be a dangling pointer 14:29:52 <|amethyst> since we're taking .c_str() of a temporary 14:30:11 <|amethyst> but it does live long enough to be converted back to a string in the same full-expression here 14:31:32 <|amethyst> oh actually, I guess C++11 *doesn't* need a copy if you do this the right way without the conversion 14:31:55 <|amethyst> since it has vector::push_back(string &&) 14:32:15 <|amethyst> so it would just be a move, with no copy, if you pass the temp string directly to describe 14:33:14 <|amethyst> in any event, that's silly micro-optimisation, but I prefer to think of it as removing pessimisation :) 14:37:25 :) 14:42:18 string warning_msg = uppercase_first(god_name(you.religion)) + " warns you: "; 14:42:19 warning_msg += " "; 14:43:14 ...ah, the first line is actually ..." warns you:", but that's not really the point. 14:43:20 <|amethyst> :) 14:44:04 New branch created: pull/251 (1 commit) 13https://github.com/crawl/crawl/pull/251 14:44:04 03Kyle Rawlins02 07https://github.com/crawl/crawl/pull/251 * 0.18-a0-1681-g4a82252: first try at a fix for expose_to_element not being called properly (10293) This will have two main effects: (i) cause Qazlal elemental adaptations to trigg er (hopefully properly) on spells, and (ii) cause cold-blooded players to be slo wed properly on spells. Neither of these were working correctly. 10(14 minutes ago, 4 files, 46+ 4-) 13https://github.com/crawl/crawl/commit/4a822529ff4d 14:44:31 <|amethyst> PleasingFungus: also, further down, it has code to add a space before each entry except the first 14:44:33 heh is there a way to not have my real name on that? 14:44:35 <|amethyst> PleasingFungus: if (warning) 14:44:38 not that it's that big a deal 14:44:38 lmao 14:44:51 <|amethyst> advil: in IRC, or on the commit 14:44:57 on the commit 14:45:17 advil: minor thing: you probably want the first line of the commit description to be relatively terse 14:45:33 ok 14:45:36 format is: commit title, newline newline, full commit description 14:45:42 you can look at our other commits to see examples 14:45:44 e.g. 14:45:45 %git 14:45:45 07PleasingFungus02 * 0.18-a0-1680-g7c4da81: Fix spectral weapon pluralisation 10(28 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/7c4da8119b0d 14:45:47 <|amethyst> well 14:46:04 -!- ontoclasm has joined ##crawl-dev 14:46:07 <|amethyst> looking at the commit on github it looks like there is a blank line? 14:46:13 <|amethyst> maybe github is inserting that 14:46:13 -!- stanzstanz is now known as stanzill 14:46:24 <|amethyst> as for name 14:46:49 <|amethyst> git config user.name "advil" 14:46:54 there's something very odd going on with that commit description - i'd need to poke at it 14:47:38 <|amethyst> probably for this commit you'll have to git commit --amend --author "advil " and force push 14:47:51 <|amethyst> ah 14:47:51 -!- kaiza has quit [Ping timeout: 276 seconds] 14:47:55 <|amethyst> advil: re the commit message 14:48:05 <|amethyst> advil: you need a blank line after that first title line 14:48:15 <|amethyst> advil: also, try to keep it word-wrapped to ~72 characters 14:48:24 ok ok 14:48:27 <|amethyst> 76 at the very most 14:48:37 I'm just using whatever vim defaults there were :) 14:48:39 my editor colorizes it if i fuck up 14:48:42 <|amethyst> it looks like github added the blank line itself 14:48:54 i keep going until i lose text color 14:49:14 <|amethyst> :set tw=72 14:49:14 <|amethyst> gqap 14:49:39 emacs thinks that the first line of a git commit message needs to be shortish (65 ch, I think?) and second line blank, fwiw 14:49:41 <|amethyst> gqap = reflow (gq) a paragraph (ap) 14:50:23 -!- Tux[Qyou] has joined ##crawl-dev 14:50:31 |amethyst: user.name is global, right? Do you know if there's a way to set that per repo? 14:50:32 <|amethyst> I am not so hung up on the first line being that short, but yeah, it's conventionally even shorter than the main text 14:51:21 oh maybe that is per repo 14:51:33 <|amethyst> it can be either 14:51:39 -!- dtsund has joined ##crawl-dev 14:51:43 <|amethyst> I think the command I gave sets it on just this repo 14:51:53 yeah looks like 14:58:25 -!- NotKat has quit [Quit: Put it on a fighting, duh] 14:59:25 03advil02 07https://github.com/crawl/crawl/pull/251 * 0.18-a0-1681-g9990500: fix expose_to_element not being called properly (10293) 10(29 minutes ago, 4 files, 46+ 4-) 13https://github.com/crawl/crawl/commit/99905009537b 14:59:25 03advil02 07https://github.com/crawl/crawl/pull/251 * 0.18-a0-1683-gafe6aca: Merge branch 'qazlal_fixes' of https://github.com/rawlins/crawl into qazlal_fixes 10(5 minutes ago, 0 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/afe6aca6f29f 15:00:02 -!- omarax has quit [Remote host closed the connection] 15:00:31 it gave me a chance to rewrite when I changed my name, so I fixed the formatting to specification 15:00:37 nice! 15:00:43 except... 15:01:06 that was a merge, not a force push 15:01:09 your old commit is still there 15:01:18 er, a merge not a rebase, i suppose 15:01:28 hmm 15:02:53 my approach would be: git rebase origin/master -i, change the latter two commits to "squash" instead of "pick", cleanup the commit message, and then git push -f once you've got it all working nicely 15:03:02 others would probably recommend a different appraoch 15:03:07 *approach 15:03:23 this is the kind of git stuff that I just never do on my own projects 15:03:33 <|amethyst> the two commits have identical trees it appears 15:03:52 sad to say, it's considerably more 'professional' than my last work was 15:04:00 <|amethyst> so I think you can rebase -i and just delete all but the fixed commit 15:04:07 ah, reasonable 15:04:10 <|amethyst> then push --force 15:04:12 -!- Daekdroom has quit [Read error: Connection reset by peer] 15:05:44 <|amethyst> (force push of something you shared is usually not a great idea, but IMO it's better than closing the PR and opening a brand new one) 15:07:22 ok I think I did it right 15:08:41 so the main concern with that PR I think is that there might be unintended consequences of calling expose_to_element in the middle of bolt::affect_player 15:09:09 I did a bunch of testing and didn't find any, but I don't think that means much 15:09:34 and affect_player is quite complicated 15:31:17 03PleasingFungus02 07* 0.18-a0-1681-gef25089: Refactor update_monsters_in_view() 10(13 seconds ago, 1 file, 156+ 118-) 13https://github.com/crawl/crawl/commit/ef25089bd5bc 15:31:37 -!- ontoclasm has quit [Quit: Leaving.] 15:32:49 -!- pikaro has quit [Ping timeout: 244 seconds] 15:32:59 -!- Tux[Qyou] has quit [Read error: Connection reset by peer] 15:34:39 -!- CKyle has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 15:34:47 -!- Tux[Qyou] has joined ##crawl-dev 15:35:34 -!- ystael has quit [Ping timeout: 240 seconds] 15:41:48 03PleasingFungus02 07* 0.18-a0-1682-g23343eb: Fix a rare error message 10(12 seconds ago, 1 file, 3+ 3-) 13https://github.com/crawl/crawl/commit/23343eba8c3a 15:42:40 -!- serQ has quit [Changing host] 15:43:38 -!- tealeaves has quit [Quit: Bye] 15:43:45 <|amethyst> PleasingFungus: FR: simple_god_message looks at whether the first character is ' or space and adds the space itself if necessary 15:44:06 <|amethyst> PleasingFungus: (there's at least somewhere else we do that, trying to remember where) 15:44:24 i'm nervous about making functions too 'clever' 15:44:43 god ability gain messages do something similar i think? 15:44:44 predictability is nice. 15:45:02 <|amethyst> the current version is extremely easy to use incorrectly though 15:45:46 they either automatically add the "godname now lets you do foo" bit or the message is just "foo" 15:46:59 <|amethyst> melee_attack::announce_hit 15:47:32 <|amethyst> and place_delayed_monsters with a different list of characters 15:47:59 <|amethyst> oh, the latter is something slightly different 15:48:44 in this case we'd be saving literally one character, though 15:48:51 as opposed to a full phrase 15:49:41 <|amethyst> my suggestion is not intended to make code shorter, it's intended to make the "obvious" way of calling the function do what people expect 15:49:56 <|amethyst> alternatively, could add a check for that in checkwhite 15:50:11 <|amethyst> /simple_god_message\("[^' ]/ 15:50:24 !shrug 15:50:24 ¯\_(ツ)_/¯ 15:50:26 it's a not uncommon mistake, yeah 15:50:27 I give in. do as you will. 15:50:47 <|amethyst> I do sympathise with the concern about making the function too smart though 15:50:55 <|amethyst> maybe the checkwhite approach is better 15:51:14 -!- mibe has quit [Ping timeout: 250 seconds] 15:51:57 <|amethyst> or maybe it should be simple_god_message and possessive_god_message 15:52:15 <|amethyst> with the former adding space and the latter adding "'s " 15:52:44 <|amethyst> or apostrophise(god_name(..)) if we want "Fedhas'" instead of "Fedhas's" 15:52:58 <|amethyst> oh, nm 15:52:59 do we? 15:53:04 <|amethyst> it doesn't actually change that anyway 15:53:25 <|amethyst> return name + /*(lastc == 's' ? "'" :*/ "'s" /*)*/; 15:53:36 <|amethyst> almost one for crawlcode there 15:54:14 <|amethyst> I guess the rule I usually go by is to use ' for "classical" names, whatever that means, and 's for modern ones 15:54:20 <|amethyst> so Jesus' but Davis's 15:54:50 I would absolutely add that to crawlcode. 15:54:54 <|amethyst> so either is fine for me 15:54:58 <|amethyst> fine then :) 15:56:32 -!- tealeaves has quit [Quit: Bye] 15:57:02 <|amethyst> hmm 15:57:21 <|amethyst> I want to write "#ifdef" but not have that hashtaggified 15:57:24 <|amethyst> is there a way? 15:57:51 hm 15:57:57 i wonder if there's good results for hastag ifdef 15:58:05 -!- amalloy_ is now known as amalloy 15:58:13 just plenty of other people using it 15:58:30 "Sooo now do my bash scripts need #IFDEF WIN64?" 15:59:15 -!- HellTiger has quit [Ping timeout: 250 seconds] 15:59:29 nice 16:00:02 -!- omarax has quit [Remote host closed the connection] 16:00:47 <|amethyst> aww 16:00:55 <|amethyst> looks like sticking zwnj in between does not work 16:02:22 ? 16:02:31 zero width non ? 16:02:37 <|amethyst> joiner 16:02:40 ahh 16:02:46 imo just roll with it 16:02:55 join the #ifdef community on twitter 16:02:58 <|amethyst> :) 16:03:32 <|amethyst> btw, I wonder just how much this confuses advertisers 16:03:47 <|amethyst> I don't usually remember to log out of twitter 16:03:48 -!- bgiannan_ has joined ##crawl-dev 16:04:22 <|amethyst> so I'm sure I'm being tracked by the crawlcode twitter account and that's being associated with my other identities 16:04:31 <|amethyst> but I'm probably not the only one 16:04:40 -!- Daekdroom has quit [Quit: Leaving] 16:05:09 <|amethyst> ps I hate the internet 16:05:39 it's important not to overestimate the competence of people working with 'big data'. 16:06:41 <|amethyst> I just wonder if using crawlcode and not logging out means I'm getting ads on e.g. Amazon that are intended for you 16:06:56 <|amethyst> I shall in the future just assume that whenever it's something questionable :) 16:09:23 -!- Lasty has joined ##crawl-dev 16:09:38 |amethyst: well, i'll feel free to blame you! 16:11:55 * |amethyst makes some purchases 16:13:53 <|amethyst> that's how the internet should work, you should have to spend money if you want to troll people 16:15:35 -!- Lasty has left ##crawl-dev 16:15:41 -!- Lasty has joined ##crawl-dev 16:18:29 that's not very FOSS. 16:19:17 hm. the true open source approach would be to somehow stake your public key on the trolling 16:22:23 -!- FiftyNine has quit [] 16:32:52 -!- Leafsnail has quit [Ping timeout: 264 seconds] 16:40:37 -!- edsrzf has joined ##crawl-dev 16:42:29 -!- tealeaves has quit [Quit: Bye] 16:48:07 -!- Surgo has quit [Ping timeout: 276 seconds] 16:51:25 -!- Nomi has quit [Read error: Connection reset by peer] 16:54:36 -!- Guest41323 has quit [Remote host closed the connection] 16:59:24 -!- sorlin has quit [Ping timeout: 246 seconds] 16:59:28 -!- Insomniak` has quit [Quit: I like to rock] 17:00:02 -!- omarax has quit [Remote host closed the connection] 17:04:35 -!- Blazinghand has joined ##crawl-dev 17:08:00 -!- CKyle has joined ##crawl-dev 17:13:08 -!- mibe has quit [Ping timeout: 250 seconds] 17:25:04 -!- mibert has quit [Ping timeout: 264 seconds] 17:25:54 -!- vfoley has joined ##crawl-dev 17:27:06 -!- Surgo has quit [Ping timeout: 276 seconds] 17:28:49 -!- MarvinPA has quit [Read error: Connection reset by peer] 17:30:31 -!- MarvinPA has joined ##crawl-dev 17:32:30 -!- CKyle has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 17:36:18 -!- PleasingFungus has quit [Remote host closed the connection] 17:38:16 -!- amalloy is now known as amalloy_ 17:40:00 -!- mibe has quit [Ping timeout: 250 seconds] 17:40:51 -!- Daekdroom has quit [Quit: Leaving] 17:41:25 -!- regret-index has joined ##crawl-dev 17:42:01 -!- Tux[Qyou] has quit [Read error: Connection reset by peer] 17:47:35 -!- ystael has quit [Ping timeout: 250 seconds] 17:56:53 -!- CKyle has joined ##crawl-dev 17:58:31 -!- Coronel has quit [Ping timeout: 244 seconds] 18:00:03 -!- omarax has quit [Remote host closed the connection] 18:02:19 Unstable branch on underhound.eu updated to: 0.18-a0-1682-g23343eb (34) 18:06:27 -!- CcS has quit [Read error: Connection reset by peer] 18:09:25 -!- sorlin has quit [Ping timeout: 260 seconds] 18:09:25 -!- dustinm` has quit [Ping timeout: 260 seconds] 18:12:28 -!- Ladykiller69 has quit [Read error: Connection reset by peer] 18:12:47 -!- dustinm` has joined ##crawl-dev 18:25:48 -!- Cerpin has quit [Quit: leaving] 18:26:13 -!- Cerpin has joined ##crawl-dev 18:27:34 -!- yesno has quit [Read error: Connection reset by peer] 18:29:13 -!- vasya_ has joined ##crawl-dev 18:29:31 -!- serQ has quit [Ping timeout: 276 seconds] 18:31:27 -!- ProzacElf has quit [Ping timeout: 246 seconds] 18:39:33 -!- gammafunk has joined ##crawl-dev 19:00:03 -!- omarax has quit [Remote host closed the connection] 19:00:17 -!- Patashu has joined ##crawl-dev 19:01:02 -!- jefus_ has joined ##crawl-dev 19:01:48 -!- jefus_ has quit [Read error: Connection reset by peer] 19:04:34 -!- jefus has quit [Ping timeout: 240 seconds] 19:05:05 -!- siepu has quit [Read error: Connection reset by peer] 19:07:18 -!- vasya_ has quit [] 19:08:22 -!- stanzill has quit [Quit: au rev] 19:11:34 -!- Xenobreeder has joined ##crawl-dev 19:13:39 -!- simples has quit [Quit: Page closed] 19:14:52 -!- Blade- has quit [Ping timeout: 246 seconds] 19:18:22 -!- scummos__ has quit [Ping timeout: 246 seconds] 19:21:04 -!- tripout has quit [Quit: Leaving] 19:21:14 augh 19:21:24 code paths that call resist_adjust_damage don't call check_your_resists 19:28:04 -!- Daekdroom has quit [Quit: Leaving] 19:29:39 -!- Jessika has quit [Ping timeout: 250 seconds] 19:29:52 so confused 19:30:03 but I need to work on my PR more to get melting to happen properly in all cases 19:31:23 -!- kaiza has quit [Remote host closed the connection] 19:34:30 -!- duralumin has quit [Read error: Connection reset by peer] 19:34:40 also |amethyst I see what you mean about check_your_resists in _print_resist_messages 19:35:16 I guess it doesn't matter that it calculates the damage reduction? 19:43:12 -!- travis-ci has joined ##crawl-dev 19:43:13 The build was broken. (master - 23343eb #5194 : Nicholas Feinberg): https://travis-ci.org/crawl/crawl/builds/120325932 19:43:13 -!- travis-ci has left ##crawl-dev 19:50:32 fun fact: flame arrows shot with a flaming longbow call extra elemental stuff (ranged_attack::apply_missile_brand) that regular arrows shot with a flaming longbow don't 19:50:45 wonder if this impacts damage claculation? 19:51:19 -!- Kellhus has quit [Ping timeout: 250 seconds] 19:52:07 -!- CanOfWorms has joined ##crawl-dev 19:57:34 -!- regret-index has quit [Ping timeout: 246 seconds] 19:59:34 -!- ystael has quit [Ping timeout: 240 seconds] 20:00:02 -!- omarax has quit [Remote host closed the connection] 20:03:10 -!- rockit_ has quit [Ping timeout: 260 seconds] 20:07:18 -!- PleasingFungus has joined ##crawl-dev 20:09:17 -!- graymark has quit [Quit: Page closed] 20:13:14 -!- Cerpin has quit [Remote host closed the connection] 20:14:58 -!- pikaro has quit [Ping timeout: 244 seconds] 20:17:19 -!- n1 has quit [Read error: Connection reset by peer] 20:17:51 -!- n1 has joined ##crawl-dev 20:18:14 -!- Cerpin has joined ##crawl-dev 20:27:35 -!- vale_ has quit [Remote host closed the connection] 20:29:52 -!- wheals has joined ##crawl-dev 20:30:40 -!- regret-index has joined ##crawl-dev 20:30:46 -!- serQ has quit [Quit: leaving] 20:31:27 -!- PleasingFungus has quit [Ping timeout: 244 seconds] 20:33:33 03advil02 07https://github.com/crawl/crawl/pull/251 * 0.18-a0-1682-g565d6e1: Regularize an expose_player_to_element call 10(2 hours ago, 1 file, 1+ 2-) 13https://github.com/crawl/crawl/commit/565d6e12d773 20:33:33 03advil02 07https://github.com/crawl/crawl/pull/251 * 0.18-a0-1683-g2556ecc: Fix cases where expose_to_element melted 10(80 minutes ago, 2 files, 3+ 2-) 13https://github.com/crawl/crawl/commit/2556eccf26fa 20:33:33 03advil02 07https://github.com/crawl/crawl/pull/251 * 0.18-a0-1684-gf1cd68c: Fix some more elemental exposure cases 10(3 minutes ago, 3 files, 19+ 20-) 13https://github.com/crawl/crawl/commit/f1cd68ca769c 20:37:55 -!- amalloy_ is now known as amalloy 20:39:58 -!- bitcoinbastard has quit [Ping timeout: 248 seconds] 20:48:04 -!- Cerpin has quit [Quit: leaving] 20:48:23 -!- Cerpin has joined ##crawl-dev 20:50:41 murphyslaw (L19 HuAr) ASSERT(in_non_diamond_int(r.start)) in 'ray.cc' at line 217 failed. (Shoals:1) 20:51:38 -!- PleasingFungus has joined ##crawl-dev 20:51:49 advil: don't worry very much about lava orcs 20:51:52 they essentially don't exist 20:51:57 this is wrt https://github.com/crawl/crawl/commit/2556eccf26fa 20:52:12 heh 20:52:19 I had assumed that that also applies if you fly over lava 20:52:29 temperature is a lava-orc-only thing 20:52:31 have to admit I didn't test it though 20:52:32 ohh 20:52:36 the second change 20:52:47 the first one is modern, albeit astonishingly silly 20:52:51 yeah I see 20:52:53 ...though the comment is out of date 20:52:57 since condensation shield is gone 20:53:07 (also icemail is gone I assume) 20:53:15 -!- Cerpin has quit [Client Quit] 20:53:17 it's true I did wonder to myself who changes temperature 20:53:27 I think I vaguely thought it was some Ds thing I'd never experienced 20:53:32 -!- Cerpin has joined ##crawl-dev 20:54:18 fr god of temperature and ep and player af_fire and whatever cherufes had 20:54:32 -!- Cerpin has quit [Client Quit] 20:54:36 do we also give it igni ipthes' stuff? 20:54:45 is that player af_fire? 20:54:48 -!- Cerpin has joined ##crawl-dev 20:54:48 // Handles condensation shield, ozo's armour, icemail. 20:55:02 first of those is gone and not likely to come back soon 20:55:03 sadly 20:55:24 player af_fire is salamanders 20:56:02 ahh, right! 20:56:04 i remember those 20:56:07 i'd forgotten.. 20:57:31 advil: are you planning to do something with the commented-out maybe_melt_player_enchantments(), https://github.com/crawl/crawl/commit/f1cd68ca769c#diff-1dd5dd63f3b4fd126ffcf5a7f14daa2fR365 ? 20:58:11 !lm * explbr sa-- alive 20:58:12 No milestones for * (explbr sa-- alive). 20:58:29 !lm * explbr dj-- alive 20:58:32 No milestones for * (explbr dj-- alive). 20:58:33 whoops 20:58:56 well I was vacillating on whether to try to bring it back, and wasn't fully convinced I'd caught every case where it would have applied 20:59:24 but I think it should be removed 21:00:04 -!- omarax has quit [Remote host closed the connection] 21:00:04 -!- amalloy is now known as amalloy_ 21:00:40 PleasingFungus: I should just remove it I guess you are suggesting? 21:01:52 !kw sa-- 21:01:52 Keyword: sa-- => crace=salamander 21:02:00 !lm * sa-- ktyp= 21:02:01 240. [2015-10-27 13:59:14] Xenophilius the Firebug (L7 SaFE) killed Prince Ribbit on turn 4477. (D:4) 21:02:05 advil: one or the other 21:02:18 -!- amalloy_ is now known as amalloy 21:02:18 leaving code commented out is a MAJOR faux pas. embarassing! what will your guests think? 21:02:49 that you have no idea what any of this was intended to do? :) 21:04:00 that's implicit in the repo. 21:04:04 -!- insecticide has quit [Ping timeout: 264 seconds] 21:04:40 -!- Cerpin has quit [Quit: leaving] 21:04:59 -!- Cerpin has joined ##crawl-dev 21:05:26 fair enough 21:06:13 -!- Cerpin_ has joined ##crawl-dev 21:07:13 -!- Cerpin_ has quit [Client Quit] 21:07:19 -!- Cerpin has quit [Client Quit] 21:07:40 -!- Cerpin has joined ##crawl-dev 21:09:22 03advil02 07https://github.com/crawl/crawl/pull/251 * 0.18-a0-1685-ga7b2ca2: Remove commented code (PleasingFungus) 10(4 minutes ago, 1 file, 4+ 7-) 13https://github.com/crawl/crawl/commit/a7b2ca2f59e5 21:09:36 !remove PleasingFungus 21:09:36 03PleasingFungus * 0.18-a0-2574-g8c62fc1: Remove PleasingFungus 10(in the future, 19 files, 873+ 912-) 13http://s-z.org/neil/git/commit.png?p=crawl.git;a=commitdiff;h=8c62fc1 21:09:51 :-P 21:09:56 thanks for looking at it 21:10:08 i haven't looked at the full pr, just the last batch of commits 21:10:18 ok 21:10:42 it turned it to interact with a lot more stuff than I would have guessed from the bug report, so it does need some eyes 21:15:13 -!- spriseris has quit [Quit: Leaving.] 21:17:59 -!- mibe has quit [Ping timeout: 250 seconds] 21:20:12 namelastname112 (L27 DrGl) ERROR in 'mon-util.cc' at line 2520: Invalid draconian subrace: 489 (Crypt:3) 21:20:27 !crashlog namelastname112 21:20:28 7. namelastname112, XL27 DrGl, T:72928 (milestone): http://crawl.xtahua.com/crawl/morgue/namelastname112/crash-namelastname112-20160403-011947.txt 21:20:51 oh dear 21:21:46 -!- bencryption has quit [Quit: WeeChat 1.0.1] 21:21:46 trivial to repro 21:21:47 hrm 21:26:13 -!- debo has quit [Ping timeout: 244 seconds] 21:29:41 -!- mibe has quit [Ping timeout: 250 seconds] 21:29:54 -!- Cerpin has quit [Quit: leaving] 21:30:11 -!- Cerpin has joined ##crawl-dev 21:30:23 -!- Cerpin has quit [Client Quit] 21:30:51 -!- Cerpin has joined ##crawl-dev 21:31:22 -!- Cerpin has quit [Client Quit] 21:31:55 -!- Cerpin has joined ##crawl-dev 21:31:58 -!- Cerpin has quit [Client Quit] 21:32:52 -!- Cerpin has joined ##crawl-dev 21:33:36 -!- Cerpin has quit [Client Quit] 21:34:38 -!- Cerpin has joined ##crawl-dev 21:35:34 -!- Cerpin has quit [Client Quit] 21:37:20 -!- Cerpin has joined ##crawl-dev 21:37:40 -!- Cerpin has quit [Client Quit] 21:37:40 -!- cmcbot has quit [Ping timeout: 260 seconds] 21:46:23 -!- CKyle has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 21:48:46 -!- PleasingFungus has quit [Quit: ChatZilla 0.9.92 [Firefox 45.0.1/20160315153207]] 21:48:53 03PleasingFungus02 07* 0.18-a0-1683-gf9322e6: Don't crash when examining drac pghosts 10(42 seconds ago, 2 files, 8+ 4-) 13https://github.com/crawl/crawl/commit/f9322e60d176 21:50:34 -!- Patashu has quit [Ping timeout: 240 seconds] 21:52:31 -!- debo has joined ##crawl-dev 21:57:44 do ghosts also have the same problem? 22:00:03 -!- omarax has quit [Remote host closed the connection] 22:07:06 -!- Daekdroom has quit [Remote host closed the connection] 22:11:23 -!- ystael has quit [Ping timeout: 252 seconds] 22:25:41 -!- Jamo has quit [Quit: Page closed] 22:29:27 -!- wheals_ has joined ##crawl-dev 22:31:08 -!- Blade- has joined ##crawl-dev 22:32:31 -!- amalloy is now known as amalloy_ 22:33:04 -!- wheals has quit [Ping timeout: 240 seconds] 22:34:54 -!- amalloy_ is now known as amalloy 22:36:24 -!- wieners has quit [Client Quit] 22:43:14 -!- Floodkiller has quit [Client Quit] 22:45:49 -!- amalloy is now known as amalloy_ 22:51:54 -!- Lasty has quit [Quit: Leaving.] 22:57:00 -!- Lasty has joined ##crawl-dev 22:58:39 -!- Pacra has joined ##crawl-dev 23:00:04 -!- omarax has quit [Remote host closed the connection] 23:00:08 -!- raskol has quit [Ping timeout: 260 seconds] 23:00:35 -!- travis-ci has joined ##crawl-dev 23:00:35 The build was fixed. (master - f9322e6 #5197 : Nicholas Feinberg): https://travis-ci.org/crawl/crawl/builds/120366919 23:00:35 -!- travis-ci has left ##crawl-dev 23:03:50 -!- Patashu has joined ##crawl-dev 23:09:54 -!- eyebrow has quit [Quit: Page closed] 23:13:04 -!- Daekdroom has quit [Quit: Leaving] 23:18:16 -!- Pacra_ has joined ##crawl-dev 23:19:47 -!- Pacra has quit [Read error: Connection reset by peer] 23:20:51 -!- Twinge has quit [Read error: Connection reset by peer] 23:23:02 -!- Twinge has joined ##crawl-dev 23:23:59 -!- Leafsnail has quit [Quit: Give a man a fish and he will eat for a day. Teach him how to fish, and he will sit in a boat and drink beer all day] 23:24:23 -!- Twinge has quit [Client Quit] 23:28:46 -!- raskol has quit [Quit: Konversation terminated!] 23:30:49 -!- ProzacElf has joined ##crawl-dev 23:33:19 -!- friendfixit has quit [Ping timeout: 248 seconds] 23:35:33 -!- PleasingFungus has joined ##crawl-dev 23:36:11 wheals_: ? 23:38:16 how do I call a lua function from a macro? define the macro as ===lua_function? 23:38:16 -!- NilsBloodaxe has quit [Quit: Page closed] 23:41:51 -!- mizu_no_oto has quit [Quit: ["Textual IRC Client: www.textualapp.com"]] 23:42:32 oh it looks like that's what I should be doing. How does one define lua in a .rc? I see Lua{} and : before each line 23:42:50 &RandomTiles.rc 23:42:52 hm 23:42:56 &rc RandomTiels 23:42:56 No milestones for RandomTiels. 23:42:58 &rc RandomTiles 23:42:58 No milestones for RandomTiles. 23:43:03 &rc gammafunk 23:43:04 http://dobrazupa.org/rcfiles/crawl-0.17/gammafunk.rc 23:43:24 ^ lots of lua in here 23:43:46 !lm alatreon 23:43:47 3889. [2016-04-03 03:42:48] Alatreon the Wrestler (L22 TrBe of Trog) killed the ghost of RumpyFlump the Fencer, an adept FoHu of Fedhas on turn 52698. (Spider:4) 23:43:54 !lg RumpyFlump spider:4 -log 23:43:55 1. RumpyFlump, XL19 FoHu, T:51346: http://dobrazupa.org/morgue/RumpyFlump/morgue-RumpyFlump-20160403-004828.txt 23:46:53 God bless you Pleasing Fungus. You are very pleasing 23:48:35 i do my best :) 23:56:09 -!- nikheizen has quit [Quit: leaving] 23:58:05 -!- Elitist has quit [Quit: Page closed]