00:01:28 Stable (0.14) branch on crawl.s-z.org updated to: 0.14.0-24-gfb45beb 00:03:43 Unstable branch on crawl.s-z.org updated to: 0.15-a0-195-g844f214 (34) 00:07:03 -!- GummyVite has quit [Quit: Page closed] 00:08:08 -!- yogaFLAME has quit [Quit: Page closed] 00:09:26 -!- Krakhan has quit [Ping timeout: 255 seconds] 00:11:18 -!- Keanan has quit [Quit: Leaving.] 00:12:15 -!- Piginabag has quit [Quit: Page closed] 00:12:37 -!- jamezq has quit [Remote host closed the connection] 00:22:59 03Sage02 07* 0.15-a0-196-g942f6c4: Change Death's Door flavour message. 10(23 minutes ago, 1 file, 1+ 1-) 13http://s-z.org/neil/git/?p=crawl.git;a=commitdiff;h=942f6c4c2700 00:24:49 -!- Keanan has joined ##crawl-dev 00:32:23 -!- ystael has quit [Ping timeout: 255 seconds] 00:33:59 -!- SkiChan has quit [Quit: Page closed] 00:38:14 YES 00:42:24 -!- Kalir has quit [Quit: CADENZA-CLASS CLOCKWORK KNIGHT--OPERATION TERMINATED] 00:47:45 -!- bonghitz has quit [Quit: Leaving...] 00:49:22 -!- DrinkMachine has joined ##crawl-dev 00:49:22 -!- DrinkMachine has quit [Changing host] 00:49:22 -!- DrinkMachine has joined ##crawl-dev 00:50:41 -!- turde has quit [Ping timeout: 264 seconds] 00:53:41 -!- Nomi has quit [Ping timeout: 264 seconds] 00:55:27 YES 00:55:33 NO 00:56:01 also what the fuck there's a frost giant that's red 00:56:05 i.e. it looks like a fire giant 00:56:17 -!- defn has quit [Quit: WeeChat 0.4.3] 00:56:17 ? 00:56:49 my current game 00:58:40 -!- defn has quit [Client Quit] 00:58:45 -!- Zannick has quit [Ping timeout: 250 seconds] 01:00:18 https://crawl.develz.org/tavern/viewtopic.php?f=17&t=11941 01:04:11 -!- Dugar has quit [Ping timeout: 252 seconds] 01:05:01 -!- Bcadren is now known as RedBucket 01:05:13 any devs still here? 01:07:12 -!- RedBucket is now known as Bcadren 01:08:13 -!- mong has quit [Remote host closed the connection] 01:08:49 -!- yogaFLAME has quit [Quit: Page closed] 01:11:11 -!- Patashu has quit [Quit: Page closed] 01:15:39 -!- Wahaha has quit [Ping timeout: 250 seconds] 01:16:01 -!- nrook has quit [Quit: ChatZilla 0.9.90.1 [Firefox 28.0/20140314220517]] 01:16:48 -!- Lemuel has quit [Ping timeout: 240 seconds] 01:17:18 -!- t4nk021 has quit [Ping timeout: 240 seconds] 01:18:06 -!- NeremWorld has quit [Ping timeout: 252 seconds] 01:23:29 -!- P_R_Deltoid has quit [Quit: Leaving] 01:25:58 -!- bonghitz has quit [Remote host closed the connection] 01:26:18 -!- swayze has quit [Ping timeout: 240 seconds] 01:32:41 -!- Zannick has joined ##crawl-dev 01:34:18 -!- PleasingFungus has quit [Quit: ChatZilla 0.9.90.1 [Firefox 31.0a1/20140419030204]] 01:35:11 -!- ystael has quit [Ping timeout: 252 seconds] 01:36:52 -!- Nethris has quit [Quit: Leaving.] 01:44:12 -!- rast has quit [Read error: Connection reset by peer] 01:44:18 -!- iFurril has quit [Ping timeout: 240 seconds] 01:44:27 -!- rast has joined ##crawl-dev 01:46:08 -!- bonghitz has quit [Remote host closed the connection] 01:47:02 -!- jeanjacques has joined ##crawl-dev 01:51:41 -!- bmfx has quit [Ping timeout: 252 seconds] 01:53:38 -!- SkaryMonk has quit [Ping timeout: 240 seconds] 01:54:30 -!- SkaryMonk has joined ##crawl-dev 01:58:08 -!- Z_LAMP has quit [Ping timeout: 276 seconds] 01:59:56 -!- Nerem has quit [Ping timeout: 252 seconds] 02:05:56 -!- Furril has quit [Ping timeout: 276 seconds] 02:06:27 -!- lobf has joined ##crawl-dev 02:14:18 -!- inojin has quit [Ping timeout: 240 seconds] 02:16:36 Stable (0.14) branch on crawl.beRotato.org updated to: 0.14.0-24-gfb45beb 02:17:38 -!- Hailley has quit [Ping timeout: 240 seconds] 02:18:18 -!- wizzo has quit [Ping timeout: 265 seconds] 02:19:18 -!- kait has quit [Ping timeout: 240 seconds] 02:21:16 -!- WalkerBoh has quit [Remote host closed the connection] 02:21:58 -!- Stendarr has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/] 02:23:21 Unstable branch on crawl.beRotato.org updated to: 0.15-a0-196-g942f6c4 (34) 02:29:12 -!- Satonakaja has quit [Quit: Sayonara, Zetsubou Sensei!] 02:32:30 -!- SkaryMonk1 has joined ##crawl-dev 02:33:53 -!- wizzo has quit [Ping timeout: 264 seconds] 02:36:24 -!- RZX has quit [Quit: ChatZilla 0.9.90.1 [Firefox 28.0/20140314220517]] 02:39:34 -!- ussdefiant has quit [Ping timeout: 252 seconds] 02:41:22 -!- UncertainKitten has quit [Quit: Connection reset by pier.] 02:43:52 -!- minus_ has quit [Quit: Page closed] 02:47:07 -!- Keanan has quit [Quit: Leaving.] 02:48:57 -!- rchandra has left ##crawl-dev 02:54:58 -!- thetabyte has quit [Ping timeout: 252 seconds] 02:55:56 -!- kait has quit [Ping timeout: 255 seconds] 02:56:36 -!- caleba has quit [Quit: caleba] 03:05:43 -!- Kvaak has quit [Ping timeout: 250 seconds] 03:06:03 -!- Kvaak has joined ##crawl-dev 03:08:46 -!- Blazinghand has quit [Read error: Connection reset by peer] 03:14:48 -!- Red_Bucket has quit [Ping timeout: 240 seconds] 03:18:40 -!- Palyth has quit [] 03:27:23 -!- Whistling_Bread has quit [Ping timeout: 252 seconds] 03:28:14 -!- Patashu has joined ##crawl-dev 03:28:33 -!- Patashu_ has joined ##crawl-dev 03:28:33 -!- Patashu has quit [Disconnected by services] 03:29:03 -!- dtsund has quit [Quit: dtsund] 03:29:32 -!- lobf has quit [Quit: lobf] 03:31:03 -!- ontoclasm1 has joined ##crawl-dev 03:33:02 -!- ontoclasm has quit [Ping timeout: 252 seconds] 03:33:34 -!- lobf has joined ##crawl-dev 03:34:57 -!- lobf has quit [Client Quit] 03:35:14 -!- ystael has quit [Ping timeout: 252 seconds] 03:36:55 -!- DrKe has quit [Ping timeout: 250 seconds] 03:37:51 -!- simmarine has quit [Quit: Leaving] 03:43:20 -!- Akatosh has quit [Quit: Page closed] 03:43:29 -!- Wolfechu has quit [Ping timeout: 264 seconds] 03:45:58 -!- rast- has joined ##crawl-dev 03:46:31 -!- rast has quit [Read error: Connection reset by peer] 03:46:36 -!- rast- is now known as rast 03:50:30 -!- omnirizon has quit [Quit: leaving] 03:51:22 -!- Z_LAMP has quit [Ping timeout: 252 seconds] 03:58:11 -!- ystael has quit [Ping timeout: 252 seconds] 04:07:30 -!- Eonwe6 has quit [Ping timeout: 252 seconds] 04:10:59 -!- Bcadren is now known as ToiletArm 04:11:12 -!- Pepe has quit [Ping timeout: 240 seconds] 04:11:32 -!- st_ has quit [Ping timeout: 255 seconds] 04:14:38 -!- Hailley has quit [Ping timeout: 240 seconds] 04:15:32 why can there be shafts on D:1? that seems a bit TOO unfair by crawl standards 04:16:37 -!- bonghitz has quit [Remote host closed the connection] 04:17:34 they only take you to D:2 04:17:58 -!- agolden has quit [Quit: agolden] 04:19:38 -!- scummos__ has quit [Ping timeout: 240 seconds] 04:20:29 -!- neunon has quit [Ping timeout: 276 seconds] 04:20:47 -!- TAS-2012v has quit [Ping timeout: 245 seconds] 04:23:50 -!- Whistling_Bread has quit [Ping timeout: 252 seconds] 04:25:00 -!- ontoclasm1 has quit [Quit: Leaving.] 04:27:17 -!- Infinite_Monkeys has quit [Ping timeout: 264 seconds] 04:31:16 -!- Mad_Wack has quit [Quit: My MacBook Pro has gone to sleep. ZZZzzz…] 04:31:23 -!- SkaryMonk2 has joined ##crawl-dev 04:36:30 -!- SkaryMonk1 has quit [Ping timeout: 276 seconds] 04:36:30 -!- SomeoneAwful has quit [Quit: Leaving] 04:36:31 -!- Cheibriados has quit [Ping timeout: 258 seconds] 04:37:41 -!- Cheibriados has joined ##crawl-dev 04:37:41 -!- The topic of ##crawl-dev is: Crawl Development | Logs: http://s-z.org/crawl-dev/ | People with +v have commit access. | Please keep general Crawl-related chit-chat to ##crawl. | Dev wiki: http://crawl.develz.org/wiki | Long stuff to pastebin.ca please | Immortal Warwalrus and Crazy Yiuf forever. 04:37:43 -!- The topic of ##crawl is: Check out new European server at ??clan! | Play Crawl online now: type ??cao, ??cdo, ??cszo, ??clan, or ??webtiles for instructions | http://crawl.develz.org | FooTV: termcast.develz.org | ##crawl-offtopic: You got your gender in my peanut butter! Xom thinks this is hilarious. 04:39:22 -!- gareppa has quit [Quit: Sto andando via] 04:45:34 -!- Whistling_Beard has quit [Read error: Connection reset by peer] 04:45:48 -!- Quazifuji_ has quit [Ping timeout: 240 seconds] 04:50:28 -!- qoala has quit [] 04:51:57 -!- alefury has joined ##crawl-dev 04:52:02 -!- jeffro has quit [Ping timeout: 255 seconds] 04:52:45 Stable branch on crawl.develz.org updated to: 0.14.0-24-gfb45beb (34) 04:52:59 -!- jeffro has joined ##crawl-dev 04:55:58 -!- kait has quit [Read error: Connection reset by peer] 04:56:28 -!- Whistling_Beard has quit [Read error: Connection reset by peer] 04:56:38 -!- Ketsa has quit [Ping timeout: 240 seconds] 04:58:22 -!- ldf has quit [Quit: ldf] 05:02:17 -!- Patashu_ has quit [Quit: Soundcloud (Famitracker Chiptunes): http://www.soundcloud.com/patashu MSN: Patashu@hotmail.com , AIM: Patashu0 , YIM: patashu2 , Skype: patashu0 .] 05:02:47 -!- Patashu has joined ##crawl-dev 05:04:02 -!- MiraclePrism has quit [Ping timeout: 240 seconds] 05:05:20 -!- fungee has quit [] 05:06:26 -!- scummos__ has quit [Ping timeout: 246 seconds] 05:10:03 -!- iFurril has quit [Ping timeout: 255 seconds] 05:10:03 -!- Sorbius has quit [Ping timeout: 255 seconds] 05:14:17 -!- pantaril_ has quit [Remote host closed the connection] 05:14:36 -!- pantaril has quit [Remote host closed the connection] 05:14:44 -!- neunon has joined ##crawl-dev 05:14:48 -!- Lightli has quit [Ping timeout: 240 seconds] 05:14:50 -!- Whistling_Beard has quit [Ping timeout: 240 seconds] 05:16:30 -!- mumi has quit [Read error: Connection reset by peer] 05:30:17 -!- raskol has quit [Ping timeout: 264 seconds] 05:33:56 -!- radinms has quit [Ping timeout: 276 seconds] 05:35:08 -!- SurpriseTRex has quit [Ping timeout: 252 seconds] 05:37:48 -!- conted has quit [Ping timeout: 240 seconds] 05:38:51 -!- asema has quit [Changing host] 05:42:29 Trog (oka?) ammo gift give also throwing items by nago 05:43:16 -!- edlothiol has joined ##crawl-dev 05:46:26 -!- rast- has joined ##crawl-dev 05:48:46 -!- rast has quit [Ping timeout: 252 seconds] 05:48:47 -!- rast- is now known as rast 05:55:18 -!- Basil has quit [Ping timeout: 240 seconds] 06:02:31 -!- MgDark_MiBe has quit [Ping timeout: 250 seconds] 06:04:47 -!- Lasty1 has joined ##crawl-dev 06:09:48 -!- CrazyArbalest has quit [Client Quit] 06:20:35 -!- ToiletArm is now known as dudearm 06:29:31 -!- Lasty1 has quit [Quit: Leaving.] 06:30:31 -!- notcluie has quit [Quit: Page closed] 06:32:38 -!- SkaryMonk1 has joined ##crawl-dev 06:32:58 -!- SkaryMonk2 has quit [Ping timeout: 240 seconds] 06:33:10 Shield protection brand doesn't stack with enchantment levels by 1old3 06:33:52 -!- rast has quit [Ping timeout: 252 seconds] 06:36:14 -!- zxc232 has quit [Read error: Connection reset by peer] 06:47:18 -!- blueDave has quit [Ping timeout: 240 seconds] 06:52:26 -!- Furril has quit [Ping timeout: 240 seconds] 06:53:05 -!- scummos__ has quit [Ping timeout: 264 seconds] 06:53:18 -!- ldf has joined ##crawl-dev 06:56:05 -!- DrinkMachine has quit [Ping timeout: 264 seconds] 07:07:32 -!- scummos__ has quit [Ping timeout: 246 seconds] 07:20:31 -!- Z_LAMP has quit [Read error: Connection reset by peer] 07:21:50 -!- debo has quit [Quit: debo] 07:23:14 -!- BlackrayJack has quit [Ping timeout: 255 seconds] 07:29:18 -!- iFurril has quit [Ping timeout: 240 seconds] 07:31:06 -!- Sgeo has quit [Read error: Connection reset by peer] 07:34:55 -!- sd1989 has joined ##crawl-dev 07:39:07 -!- mdvedh has quit [Client Quit] 07:43:06 -!- Patashu has quit [Remote host closed the connection] 07:43:18 -!- Patashu has joined ##crawl-dev 07:44:07 -!- Rewans has quit [Quit: Page closed] 07:45:45 -!- dRbiG has quit [Quit: ZNC - http://znc.in] 07:47:41 -!- rast has joined ##crawl-dev 07:47:48 -!- mmazing has quit [Remote host closed the connection] 07:52:17 -!- Patashu has quit [Ping timeout: 265 seconds] 07:55:26 -!- Z_LAMP has quit [Read error: Connection reset by peer] 08:05:36 -!- sd1989 has quit [Quit: Page closed] 08:05:50 -!- ckyle has joined ##crawl-dev 08:06:15 -!- radinms has quit [Ping timeout: 252 seconds] 08:07:17 -!- LexAckson has joined ##crawl-dev 08:10:13 -!- debo has joined ##crawl-dev 08:12:48 -!- Xenobreeder has quit [Ping timeout: 240 seconds] 08:16:10 -!- Lawman0 has quit [Read error: Connection reset by peer] 08:23:26 -!- LexAckson has quit [Quit: Leaving] 08:27:13 -!- Foamed_ has quit [Client Quit] 08:30:14 -!- ckyle has quit [Quit: ckyle] 08:30:57 -!- Foamed has quit [Ping timeout: 265 seconds] 08:32:47 -!- SkaryMonk2 has joined ##crawl-dev 08:34:20 -!- SkaryMonk1 has quit [Ping timeout: 255 seconds] 08:42:39 jike (L13 DEFE) ERROR in 'tileweb.cc' at line 212: Socket write error: Resource temporarily unavailable (Swamp:2) 08:42:40 Hisar (L15 DsIE) ERROR in 'tileweb.cc' at line 212: Socket write error: Resource temporarily unavailable (Abyss:1) 08:42:41 Hiermare (L14 VSEE) ERROR in 'tileweb.cc' at line 212: Socket write error: Resource temporarily unavailable (D:12) 08:43:50 Bibburat (L11 MiBe) ERROR in 'tileweb.cc' at line 212: Socket write error: Resource temporarily unavailable (D:10) 08:43:50 hawkwood (L18 MiBe) ERROR in 'tileweb.cc' at line 212: Socket write error: Resource temporarily unavailable (Shoals:5) 08:43:51 Zicher (L18 SpVM) ERROR in 'tileweb.cc' at line 212: Socket write error: Resource temporarily unavailable (Snake:5) 08:44:06 jike (L13 DEFE) ERROR in 'tileweb.cc' at line 212: Socket write error: Resource temporarily unavailable (Swamp:2) 08:44:33 Hisar (L15 DsIE) ERROR in 'tileweb.cc' at line 212: Socket write error: Resource temporarily unavailable (Abyss:1) 08:44:45 Zicher (L18 SpVM) ERROR in 'tileweb.cc' at line 212: Socket write error: Resource temporarily unavailable (Snake:5) 08:44:46 Liesmith (L6 TrCK) ERROR in 'tileweb.cc' at line 212: Socket write error: Resource temporarily unavailable (Ossuary) 08:44:47 nefandi (L11 FoFi) ERROR in 'tileweb.cc' at line 212: Socket write error: Resource temporarily unavailable (D:9) 08:44:48 icemanSX (L3 GrFi) ERROR in 'tileweb.cc' at line 212: Socket write error: Resource temporarily unavailable (D:2) 08:44:49 ROCKEDEL (L6 GrGl) ERROR in 'tileweb.cc' at line 212: Socket write error: Resource temporarily unavailable (D:3) 08:44:56 YASD (L11 OgBe) ERROR in 'tileweb.cc' at line 212: Socket write error: Resource temporarily unavailable (Lair:3) 08:44:56 Bibburat (L11 MiBe) ERROR in 'tileweb.cc' at line 212: Socket write error: Resource temporarily unavailable (D:10) 08:47:40 -!- mizu_no_oto has quit [Quit: Computer has gone to sleep.] 08:51:04 -!- conted has quit [Quit: Page closed] 08:52:18 -!- RiotInferno has quit [Read error: Connection reset by peer] 08:54:40 -!- nooodl has joined ##crawl-dev 08:55:14 -!- Quashie has quit [Ping timeout: 240 seconds] 08:57:48 -!- CKyle has joined ##crawl-dev 09:05:03 -!- dck has joined ##crawl-dev 09:06:10 -!- mdvedh has quit [Client Quit] 09:08:59 -!- Netmonmatt has quit [Ping timeout: 255 seconds] 09:11:18 -!- Xenobreeder has quit [Ping timeout: 240 seconds] 09:19:18 -!- Daekdroom has quit [Quit: Saindo] 09:24:48 -!- yogidabear has quit [Ping timeout: 240 seconds] 09:38:19 -!- Skjarl has quit [Quit: Page closed] 09:40:17 apparently autopickup is turned off if a monster attempts to turn invisible while inside TSO's halo, is that supposed to happen? 09:45:14 -!- Spatzist has quit [Quit: Page closed] 09:47:36 -!- rast has quit [Read error: Connection reset by peer] 09:47:56 -!- rast has joined ##crawl-dev 09:56:40 -!- Kalir has quit [Changing host] 09:57:05 -!- PleasingFungus has joined ##crawl-dev 09:57:47 -!- zxc232 has quit [Read error: Connection reset by peer] 10:00:00 -!- dck has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client] 10:02:48 -!- Morg0th has quit [Quit: leaving] 10:04:40 When are unique’s floors determined? Is it at the start of a new game, or when you visit floors the unique could appear on? 10:07:15 -!- _D_ has quit [Quit: leaving] 10:09:27 -!- Bloax has joined ##crawl-dev 10:13:30 -!- gareppa has quit [Quit: Sto andando via] 10:15:53 should be when you initially enter the floor 10:16:09 pretty sure each floor is generated on the fly 10:16:26 uniques are placed by vaults, vault placement happens when the floor is generated, which is when the floor is first entered 10:17:17 a vault is considered for a floor if its branch and/or depth range is appropriate for the floor (althoiugh may subsequently be vetoed for other reasons, or just randomly not chosen for that floor) 10:21:14 -!- tali713 has quit [Quit: ZNC - http://znc.in] 10:23:05 geekosaur: This sounds new to me; are there really 1-tile vaults for various uniques? I thought normal dungeon generation placed them. 10:23:41 no it's been that way forever iirc 10:24:07 !source uniques.des 10:24:07 http://s-z.org/neil/git/?p=crawl.git;a=blob;f=crawl-ref/source/uniques.des;hb=HEAD 10:24:43 !source dat/des/builder/uniques.des 10:24:43 http://s-z.org/neil/git/?p=crawl.git;a=blob;f=crawl-ref/source/dat/des/builder/uniques.des;hb=HEAD 10:24:53 and yes, there are a bunch of silly 1-tile vaults to place uniques 10:25:59 iirc sometimes they do dumb things like knock out doors (in dungeon layout) while being placed?) 10:26:43 yep. and due to bugs in the level builder, sometimes they've done things like end up surrounded by trees with no way to reach them (but I would not be surprised if the recent change to make all trees opaque fixed this) 10:26:54 -!- syllogism has joined ##crawl-dev 10:27:28 Well, it looks like it works fine, but it feels like some sort of hack. 10:27:41 gee, it's crawl, whoda thunk? 10:28:03 oh, and the aforementioned feature/bug also applies to monster who turn invisible outside the halo but step inside it 10:28:07 * Nivim experiences light, sad laughter. 10:29:10 Kvaak: Does TSO's halo ever completely fill the screen? 10:29:17 at ****** I think, yes 10:29:18 (Or the view-range, that is.) 10:30:04 Well, since it doesn't always, I'm guessing the default is so that if something is invisible going into the halo, but then leaves, you don't autopickup and get shot at by the few invisible&ranged things. 10:30:51 yeah, that's presumably the reason why the halo doesn't affect autopickup 10:31:06 not sure it is a good enough reason though 10:31:07 -!- Zicher has quit [Quit: Page closed] 10:31:50 are there any permanently invisible monsters than can attack you from afar? 10:32:03 Vapours could before trunk 10:32:12 not permanently invis, but there are monsters with ranged attacks who can go invis 10:32:48 -!- Kalir has quit [Quit: CADENZA-CLASS CLOCKWORK KNIGHT--OPERATION TERMINATED] 10:33:46 mm, I'm not sure how vapors interact with autopickup but at least UHs don't disable autopickup 10:33:53 which isn't really an issue since they can only melee you anyway 10:34:36 elliptic: you fixed wanderer MP and didn't add the wanderer starting package upgrade? :( 10:34:53 -!- SkaryMonk2 has quit [Ping timeout: 276 seconds] 10:35:35 Lasty: it was an easy bugfix that I noticed when fixing a non-Wn bug, I'll look at your Wn patch after the tourney :) 10:37:03 Ah, okay :) 10:37:14 thanks! 10:37:23 -!- LexAckson has joined ##crawl-dev 10:38:12 -!- ZRN has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/] 10:40:23 -!- PleasingFungus has quit [Quit: ChatZilla 0.9.90.1 [Firefox 31.0a1/20140419030204]] 10:42:06 -!- Mandevil has quit [Quit: leaving] 10:43:57 -!- ussdefiant has joined ##crawl-dev 10:44:34 -!- Z_LAMP has quit [Read error: Connection reset by peer] 10:44:45 -!- blabber has joined ##crawl-dev 10:47:03 -!- gareppa has quit [Quit: Sto andando via] 10:47:25 -!- gareppa has quit [Read error: Connection reset by peer] 10:47:32 -!- lobf has joined ##crawl-dev 10:48:58 -!- Lawman0 has quit [Read error: Connection reset by peer] 10:58:04 -!- Crehl has quit [Quit: qqqqqqq] 10:58:17 -!- Mateji has quit [Ping timeout: 276 seconds] 10:58:48 -!- Lightli has quit [Ping timeout: 240 seconds] 10:59:11 -!- PleasingFungus has joined ##crawl-dev 10:59:31 -!- Akien has joined ##crawl-dev 11:01:15 -!- madSimon has quit [Quit: Page closed] 11:01:34 -!- scummos__ has quit [Read error: Operation timed out] 11:02:19 -!- gareppa has quit [Quit: Sto andando via] 11:07:24 -!- dudearm has quit [Ping timeout: 252 seconds] 11:12:35 -!- st_ has joined ##crawl-dev 11:16:07 -!- ontoclasm has joined ##crawl-dev 11:18:33 -!- DrinkMachine has joined ##crawl-dev 11:18:33 -!- DrinkMachine has quit [Changing host] 11:18:33 -!- DrinkMachine has joined ##crawl-dev 11:20:30 -!- yogaFLAME has quit [Quit: Page closed] 11:21:18 -!- radinms has quit [] 11:24:53 -!- ToastyP has quit [Disconnected by services] 11:30:07 -!- mizu_no_oto has quit [Quit: ["Textual IRC Client: www.textualapp.com"]] 11:30:44 -!- ontoclasm has quit [Read error: Connection reset by peer] 11:32:58 -!- dudearm has joined ##crawl-dev 11:34:11 -!- Foamed has quit [Quit: Heading to bed.] 11:35:20 -!- Basil has joined ##crawl-dev 11:35:44 -!- Basil is now known as Guest67935 11:36:24 -!- Zicher has quit [Quit: Page closed] 11:39:38 -!- ussdefiant has quit [Ping timeout: 252 seconds] 11:40:15 -!- iasov has quit [Remote host closed the connection] 11:45:52 -!- CKyle has quit [Quit: CKyle] 11:47:18 -!- notclule has quit [Ping timeout: 240 seconds] 11:48:01 -!- rast has quit [Read error: Connection reset by peer] 11:48:12 -!- rast- has joined ##crawl-dev 11:48:12 -!- rast- is now known as rast 11:49:42 -!- CKyle has joined ##crawl-dev 11:49:49 -!- BigBluFrog has quit [Quit: Page closed] 11:52:06 -!- nooodl_ has joined ##crawl-dev 11:52:44 -!- Nethris has quit [Quit: Leaving.] 11:56:08 -!- nooodl has quit [Ping timeout: 276 seconds] 11:57:09 -!- Ququman has joined ##crawl-dev 12:02:52 -!- bencryption has quit [Quit: WeeChat 0.4.3] 12:04:06 -!- rchandra has joined ##crawl-dev 12:05:21 Unstable branch on crawl.akrasiac.org updated to: 0.15-a0-196-g942f6c4 (34) 12:08:04 -!- ToastyP has quit [Disconnected by services] 12:08:08 -!- ToastyP_ is now known as ToastyP 12:09:58 -!- dudearm has quit [Ping timeout: 240 seconds] 12:18:17 -!- Netmonmatt has quit [Ping timeout: 264 seconds] 12:19:50 -!- ldf has quit [Quit: ldf] 12:23:14 -!- thetabyte has quit [Ping timeout: 252 seconds] 12:27:32 -!- dtsund has joined ##crawl-dev 12:32:29 -!- DrinkMachine has quit [Quit: Leaving] 12:33:36 -!- CKyle has quit [Quit: CKyle] 12:34:48 -!- Quazifuji_ has quit [Ping timeout: 240 seconds] 12:44:19 -!- Lightli has joined ##crawl-dev 12:45:54 -!- simmarine has joined ##crawl-dev 12:50:27 -!- Kalir has quit [Changing host] 12:51:19 -!- bonghitz has quit [Remote host closed the connection] 12:55:23 -!- blabber has quit [Quit: leaving] 12:56:14 -!- gammafunk has quit [Ping timeout: 255 seconds] 12:56:56 so, if I have a cloak quivered, and drop it, it will autoselect my worn cloak 12:58:43 -!- ldf has joined ##crawl-dev 12:59:11 -!- thetabyte has quit [Ping timeout: 276 seconds] 13:03:46 -!- Keanan has joined ##crawl-dev 13:13:59 -!- reaverb has joined ##crawl-dev 13:16:41 -!- gammafunk has joined ##crawl-dev 13:18:38 good feature 13:19:42 -!- DrinkMachine has joined ##crawl-dev 13:19:43 -!- DrinkMachine has quit [Changing host] 13:19:43 -!- DrinkMachine has joined ##crawl-dev 13:20:11 PleasingFungus: What's good feature. (that sounds like a learndb entry like good mantis) 13:20:34 [10:56] so, if I have a cloak quivered, and drop it, it will autoselect my worn cloak 13:20:48 -!- caleba has quit [Quit: caleba] 13:21:36 lol 13:21:55 So you'll try to throw the cloak you're wearing? 13:21:56 -!- clonepa has joined ##crawl-dev 13:21:57 -!- CKyle has joined ##crawl-dev 13:28:06 -!- clonepa has left ##crawl-dev 13:30:34 -!- UncertainKitten has joined ##crawl-dev 13:31:27 -!- Weeksy has quit [Client Quit] 13:31:56 -!- alefury|2 has joined ##crawl-dev 13:34:44 -!- _K_ has quit [Quit: Page closed] 13:42:06 -!- trystero has quit [Quit: Page closed] 13:43:45 -!- Guest67935 is now known as Basil 13:48:07 -!- rast has quit [Read error: Connection reset by peer] 13:48:22 -!- rast has joined ##crawl-dev 13:56:14 -!- MgDark_MiBe has quit [Ping timeout: 265 seconds] 13:57:50 -!- DrinkMachine has quit [Ping timeout: 252 seconds] 14:01:29 -!- gammafunk has quit [Ping timeout: 264 seconds] 14:01:39 -!- DrinkMachine has joined ##crawl-dev 14:01:39 -!- DrinkMachine has quit [Changing host] 14:01:39 -!- DrinkMachine has joined ##crawl-dev 14:03:25 -!- CKyle has quit [Quit: CKyle] 14:07:26 -!- CKyle has joined ##crawl-dev 14:08:53 -!- gammafunk has joined ##crawl-dev 14:10:45 -!- gammafun1 has joined ##crawl-dev 14:19:26 -!- thetabyte has quit [Ping timeout: 265 seconds] 14:19:53 -!- Hisar has quit [Quit: Page closed] 14:27:56 -!- P_R_Deltoid has quit [Read error: Connection reset by peer] 14:29:17 -!- ainsophyao has joined ##crawl-dev 14:30:59 -!- ainsophyao has quit [Remote host closed the connection] 14:36:51 -!- bonghitz has quit [Remote host closed the connection] 14:37:19 -!- jeanjacques has quit [Quit: quit] 14:37:29 -!- PleasingFungus has quit [Ping timeout: 255 seconds] 14:41:05 -!- bones has joined ##crawl-dev 14:41:13 -!- bones is now known as mccoy 14:43:30 -!- mccoy has left ##crawl-dev 14:43:38 -!- MiraclePrism has quit [Ping timeout: 240 seconds] 14:45:16 Crash on view of Rof of Striking by b4rR31_r0l1 14:45:18 -!- |34rR31_r0l1 has quit [Ping timeout: 240 seconds] 14:49:29 -!- reaverb has quit [Ping timeout: 264 seconds] 14:55:32 -!- Lasty has quit [Read error: Connection reset by peer] 14:56:08 -!- ToastyP_ has quit [Ping timeout: 252 seconds] 14:56:14 -!- Lasty has joined ##crawl-dev 14:59:36 -!- PleasingFungus has joined ##crawl-dev 15:00:10 -!- reaverb has joined ##crawl-dev 15:05:48 -!- Piginabag has quit [Ping timeout: 240 seconds] 15:14:02 -!- bonghitz has quit [Ping timeout: 240 seconds] 15:14:03 -!- Stendarr has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/] 15:14:40 -!- zxc232 has quit [Quit: Leaving.] 15:15:59 -!- Netmonmatt has quit [Ping timeout: 265 seconds] 15:16:28 -!- bonghitz_ has quit [Ping timeout: 265 seconds] 15:18:34 -!- Amnesiac has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/] 15:19:12 -!- Tux[Qyou] has quit [Quit: Excess flood] 15:20:58 -!- ontoclasm has joined ##crawl-dev 15:25:31 -!- Keanan has quit [Quit: Leaving.] 15:34:10 -!- Napcat has quit [Quit: leaving] 15:35:44 -!- Kellhus has quit [Quit: Page closed] 15:35:56 -!- Keanan has joined ##crawl-dev 15:41:23 -!- DrinkMachine has quit [Ping timeout: 255 seconds] 15:41:40 -!- Crehl has quit [Ping timeout: 252 seconds] 15:46:26 -!- thetabyte has quit [Ping timeout: 240 seconds] 15:48:18 -!- rast has quit [Read error: Connection reset by peer] 15:48:37 -!- rast has joined ##crawl-dev 15:49:06 -!- jday_ has quit [Quit: Leaving] 15:51:44 -!- BigBluFrog has quit [Quit: Page closed] 15:56:13 -!- gammafun1 has left ##crawl-dev 15:56:54 -!- gammafunk has left ##crawl-dev 15:59:14 -!- ToastyP has quit [Quit: ChatZilla 0.9.90.1 [Firefox 28.0/20140314220517]] 15:59:27 -!- Patashu has joined ##crawl-dev 15:59:48 -!- Krakhan has quit [Changing host] 16:02:02 -!- reaverb has quit [Ping timeout: 240 seconds] 16:03:48 -!- yogidabear has quit [Ping timeout: 240 seconds] 16:06:47 -!- DrinkMachine has joined ##crawl-dev 16:06:47 -!- DrinkMachine has quit [Changing host] 16:06:47 -!- DrinkMachine has joined ##crawl-dev 16:07:36 -!- Basil has quit [Read error: Connection reset by peer] 16:08:54 -!- ayutzia has quit [Quit: Page closed] 16:10:36 -!- mizu_no_oto has quit [Ping timeout: 265 seconds] 16:11:54 -!- _aardvark has quit [Ping timeout: 240 seconds] 16:13:12 -!- bonghitz has quit [Ping timeout: 252 seconds] 16:14:57 -!- LexAckson has quit [Ping timeout: 265 seconds] 16:16:36 03Grunt02 07* 0.15-a0-197-gb59056a: Add two unintentionally missing tables to Plane Rend lists (floatingatoll). 10(2 minutes ago, 1 file, 2+ 0-) 13http://s-z.org/neil/git/?p=crawl.git;a=commitdiff;h=b59056a637d7 16:16:54 03Grunt02 07* 0.15-a0-198-g2f4809b: Add floatingatoll to CREDITS.txt. 10(26 seconds ago, 1 file, 1+ 0-) 13http://s-z.org/neil/git/?p=crawl.git;a=commitdiff;h=2f4809b3e053 16:20:44 -!- Akien has quit [Quit: Quitte] 16:22:40 -!- nooodl has joined ##crawl-dev 16:24:35 -!- Patashu has quit [Ping timeout: 255 seconds] 16:25:58 -!- nooodl_ has quit [Ping timeout: 240 seconds] 16:35:22 -!- Lasty1 has joined ##crawl-dev 16:35:27 -!- Basil has joined ##crawl-dev 16:36:17 -!- hurdos has quit [Ping timeout: 255 seconds] 16:38:43 -!- gareppa has quit [Quit: Sto andando via] 16:49:41 -!- Lasty1 has quit [Quit: Leaving.] 16:51:45 -!- Lasty1 has joined ##crawl-dev 16:58:03 -!- caleba has quit [Quit: caleba] 16:58:21 -!- Chris7 has quit [] 17:03:57 Unstable branch on crawl.lantea.net updated to: 0.15-a0-198-g2f4809b (34) 17:04:10 -!- Quashie has quit [Ping timeout: 252 seconds] 17:05:16 -!- ldf has quit [Quit: ldf] 17:11:35 -!- DrinkMachine is now known as GLMachine 17:13:26 -!- bonghitz has quit [Ping timeout: 265 seconds] 17:14:18 -!- Z_LAMP has quit [Read error: Connection reset by peer] 17:15:57 -!- agolden has quit [Quit: agolden] 17:17:09 -!- agolden has quit [Client Quit] 17:19:27 -!- Foamed_ has quit [Client Quit] 17:20:51 -!- syllogism has quit [] 17:20:57 -!- Yen has quit [Ping timeout: 252 seconds] 17:22:30 -!- Foamed has quit [Ping timeout: 252 seconds] 17:24:18 -!- notcluie has quit [Ping timeout: 240 seconds] 17:25:10 -!- CKyle has quit [Quit: CKyle] 17:25:54 -!- Nethris has quit [Quit: Leaving.] 17:27:18 -!- notcluie_ has quit [Ping timeout: 240 seconds] 17:38:18 -!- ystael has quit [Ping timeout: 240 seconds] 17:41:12 -!- eb has joined ##crawl-dev 17:43:18 -!- eb has quit [Read error: Connection reset by peer] 17:43:24 -!- eb has joined ##crawl-dev 17:44:02 also I am totally not looking forward to resuming my tetm 17:44:05 whops 17:44:05 -!- bonghitz has quit [Quit: Leaving...] 17:44:13 wrong channel 17:47:21 -!- Arkaniad has quit [Client Quit] 17:48:28 -!- rast has quit [Read error: Connection reset by peer] 17:48:51 -!- rast has joined ##crawl-dev 17:50:23 -!- sinusoidal_ has quit [Quit: Page closed] 17:57:14 -!- nooodl_ has joined ##crawl-dev 17:59:49 -!- ebarrett has joined ##crawl-dev 17:59:49 -!- nooodl has quit [Ping timeout: 252 seconds] 18:01:38 let me guess 18:01:41 -!- Mad_Wack has quit [Quit: Textual IRC Client: www.textualapp.com] 18:01:43 https://crawl.develz.org/tavern/viewtopic.php?f=5&t=11818&p=167287#p167287 this is terrible like everything i think of 18:02:35 my personal feeling is that it's an interface problem, not a mechanics problem 18:02:41 ('mashing 5 to rest as an ogre' etc) 18:03:42 -!- eb has quit [Ping timeout: 265 seconds] 18:04:53 it's not 18:05:08 resting from 50 hp to 300 hp takes 416 turns 18:05:12 that's a lot of turns 18:05:26 -!- stanzill has quit [Quit: bonne nuit à tous] 18:05:33 300 hp is also a lot of hp 18:05:59 but that is a lot of turns. 18:06:30 http://instacalc.com/22359 18:07:14 -!- eb has joined ##crawl-dev 18:07:38 -!- jliou has quit [Quit: Leaving] 18:08:27 -!- CKyle has joined ##crawl-dev 18:09:00 <|amethyst> so instead we should make it so that, after standing still for 100 turns, you heal 50 hp per turn? 18:09:21 <|amethyst> seems kind of a buff to summoners 18:09:26 <|amethyst> (or anyone with allies) 18:09:43 well the conditions can be messed around with 18:10:11 honestly my thoughts are that resting is not something you can "fix" in crawl at this point 18:11:04 well following up, resting up to 300 from 50 hp at rr=maxhp/3 takes 250 turns 18:11:11 -!- ebarrett has quit [Ping timeout: 276 seconds] 18:11:34 and with this overpowered-resting it'd apparently take 150 18:12:06 <|amethyst> an exponential increase while standing still with no monsters in sight maybe makes sense 18:12:12 yeah 18:12:30 and secretly i'm getting pretty tired of walking around or swinging things 18:12:48 -!- Piginabag has quit [Ping timeout: 240 seconds] 18:12:52 <|amethyst> or you could just give everyone but DDs full HP the moment there are no monsters in sight 18:13:05 <|amethyst> (and remove poison) 18:13:17 sickness* 18:13:28 poison can still murder the shit out of you if you don't have rPois 18:13:32 which isn't all that uncommon 18:13:41 case DNGN_SLIMY_WALL missing break results in DNGN_FLOOR by floatingatoll 18:13:41 i think removing sickness makes sense anyway since sickness is basically just super weak, long-dur poison 18:13:50 -!- raskol has quit [Ping timeout: 252 seconds] 18:14:02 <|amethyst> does anything except purple ugly things have sickness? 18:14:09 zymes 18:14:11 komodos 18:14:13 haunt 18:14:21 %git HEAD^{/omodo} 18:14:23 07Sage02 * 0.15-a0-195-g844f214: Make komodo dragons bite harder, remove sickbite. 10(19 hours ago, 2 files, 2+ 4-) 13http://s-z.org/neil/git/?p=crawl.git;a=commitdiff;h=844f214cef96 18:14:27 <|amethyst> ah, forgot about zymes and haunt 18:14:30 based 18:14:41 i think both of those would work fine with poison instead of sick though 18:15:11 give haunt self fear 18:15:21 at whatever you targeted 18:15:22 <|amethyst> eb: you can't move closer to yourself? 18:15:24 <|amethyst> oh 18:15:58 I have no idea of this is good btw 18:15:58 zero thought put into it 18:16:25 it is half serious tho 18:16:59 (You are terrified of it!) 18:16:59 I'm pretty serious though, since 150(ish) turns of resting would be a big improvement over 450. 18:17:14 -!- raskol` has quit [Ping timeout: 240 seconds] 18:17:37 <|amethyst> 1 turn of resting would be an even bigger improvement 18:18:18 -!- Zooty has quit [Ping timeout: 240 seconds] 18:18:21 (oh, give it a rest, everyone) 18:18:26 (<_< >_> <_< >_> <_< >_>) 18:18:38 also all this sickness hating reminds me, sickness is actually relevant for tr 18:18:45 tilepick-p.cc: case SP_NAGA missing break results in SP_VAMPIRE hair by floatingatoll 18:18:45 -!- ainsophyao has joined ##crawl-dev 18:18:48 and not much else granted 18:19:02 is the 'if (!orc && !orc->alive())' meant to be || in godabil.cc:spare_beogh_convert()? 18:19:02 <|amethyst> that's also 150 turns to go from 5 to 30 HP 18:19:48 <|amethyst> floatingatoll: indeed, good catch 18:19:48 sickness is a visual effect for DD with sustab 18:19:56 shall i file? 18:20:09 <|amethyst> floatingatoll: don't bother :) 18:20:09 :) 18:20:26 |amethyst: could give a base value to fix that 18:20:33 so i figured out how to run clang's static analyzer on the codebase 18:20:36 it's not that sick is not relevant, it's that sick is in practice the same as a different effect 18:20:44 so there's not much reason to have both other than to add complications 18:20:51 -!- ainsophyao has quit [Remote host closed the connection] 18:20:52 <|amethyst> Bloax: well, it's currently 250 18:20:58 8412, 8413 and that one seem to be the actual 'serious' bugs 18:20:58 +10 halves that 18:21:01 (it also happens that sick is not relevant in most cases but that is kind of a side issue) 18:21:07 there were a few more i didn't fully understand :( 18:21:28 (clearly we need a cang static analyser) 18:21:28 cang 18:21:31 <|amethyst> one difference, as eb points out, is that sickness scales with your regen rate 18:21:49 <|amethyst> (not that that's necessarily a good thing) 18:21:54 -!- Crehl has quit [Quit: qqqqqqq] 18:22:56 a truly virtuous soul would go through crawl with a bunch of warning flags turned on 18:23:00 it's duration*(maxhp/3 >= 20 ? 10+maxhp/6 : maxhp/3) damage 18:23:01 i just did that 18:23:01 -Wall 18:23:03 o 18:23:06 you are a truly virtuous soul 18:23:07 well, many of them :) 18:23:10 -!- Ququman has quit [Read error: Connection reset by peer] 18:23:20 -wall -werror -wpedantic or w/e it is 18:23:27 so i'm looking at three null pointer derefs in this melee_attack.cc and wondering how to explain them in a bug report 18:23:42 forgot a /100 there 18:23:49 note_messages option can log DGL messages from console users by magicpoints 18:24:02 so at 300 maxhp 18:24:05 and 500 turns of sickness 18:24:09 you take 300 damage!! 18:24:25 I do wonder if 8412 is the reason for that old bug where floor shows up as green crystal walls 18:24:28 at 30 that's 50 whole damage 18:24:29 or w/e 18:24:34 maybe I'm getting it reversed 18:25:01 god, default-fallthrough switch statements are the worst. 18:25:02 -!- CKyle has quit [Quit: CKyle] 18:25:14 heh 18:25:27 -!- reaverb has joined ##crawl-dev 18:25:29 why on earth did ritchie think that as a good idea? 18:25:34 Reminds me of a good NetHack bug. 18:25:37 -!- debo has quit [Quit: debo] 18:25:49 (one which isn't present in 3.4.x but was around for most of 3.x) 18:25:54 mm? 18:26:02 walls were floors? 18:26:18 yeah, this bug's shown up a few times 18:26:19 -!- eb has quit [Quit: I quit] 18:26:20 <|amethyst> PleasingFungus: simplicity of implementation 18:26:22 really! 18:26:26 and been reported closed at least twice 18:26:31 <|amethyst> PleasingFungus: switch is just a bunch of gotos 18:26:35 http://nethackwiki.com/wiki/Yeenoghu#.22A_ludicrous_bug.22 18:26:37 Grunt: Is it that demon lord having death's attack flavor> 18:26:42 yeah I guess I should've known :( 18:26:44 i only had to slightly patch the Makefile to stop trying to run the analyze on the externs 18:26:54 'no stop i don't care if SDL is impossibly broken' 18:26:58 reaverb: Yes. 18:27:00 the implementation of switch is actually cool 18:27:01 floatingatoll: Thank you for doing this. 18:27:04 yeah! 18:27:06 it's a pity about the effects 18:27:10 i've got a lot more that i'm unsure how to file, though 18:27:17 working on melee_attack null derefs of 'defender' 18:27:19 todo port to SDL2 18:27:36 * reaverb wonders if Crawl's odd autogenerated makefile is worth the trouble. 18:27:47 You swing at the NULL. You generate a segmentation fault. 18:27:52 i had no trouble with it, once it was generated 18:28:11 <|amethyst> floatingatoll: if you file a single bug report with the (possibly trimmed and editorialized) output of the check, that would work 18:28:24 Grunt: that is a good bug 18:28:25 |amethyst: it's giving me HTML files with the steps it took annotated in the source 18:28:36 they're really nice, except i can't for the life of me explain some of this 18:28:44 * floatingatoll copies one 18:28:44 * Grunt reaches out with his deadly touch. PleasingFungus dies! 18:28:48 rip 18:28:49 http://nethackwiki.com/wiki/File:Yeenoghu.png someone should really do a proper nethack tileset 18:28:57 03Sage02 07* 0.15-a0-199-gd408608: Prevent firewood poly from Xom and chaos brand. 10(13 minutes ago, 2 files, 3+ 2-) 13http://s-z.org/neil/git/?p=crawl.git;a=commitdiff;h=d40860805085 18:28:59 <|amethyst> floatingatoll: do you have some place to post them permanently-ish? 18:28:59 yeah i imagine 18:29:00 hahaha 18:29:30 rip fun 18:29:44 Basil: rip 18:30:00 as a temporary measure, i do have a set of ASSERT(defender) and its ilk 18:30:16 but 18:30:20 i looked at ASSERT() 18:30:26 it aborts by .. dereferencing a null pointer. 18:30:36 https://crawl.develz.org/mantis/view.php?id=6150 https://crawl.develz.org/mantis/view.php?id=8108 this might be the bug 18:30:39 the irony. 18:30:51 oh hey yeah 18:31:01 hmm, i don't know that it's the same 18:31:04 but I'm not sure how exactly that missing break 18:31:05 <|amethyst> floatingatoll: yes, but it crashes *now*, not some time later several functions deep :) 18:31:06 would cause that bug 18:31:09 it seems like the reverse effect 18:31:11 |amethyst: true! 18:31:26 those both look like case/switch bugs, pleasing 18:31:36 <|amethyst> hm 18:31:40 -!- lobf has quit [Quit: lobf] 18:32:09 as a happy aside, it provides a multi-function path all the way through everything to explain precisely *why* defender is undefined when melee_attack::apply_defender_ac is called 18:32:21 post the html 18:32:31 yeah, one sec 18:32:32 does that poly check work if the defender is the player? 18:33:18 https://dl.dropboxusercontent.com/u/7533709/scan-build-2014-04-22-150728-34977-1/index.html 18:34:37 The intent is that it prevents Xom turning plants into treants when you rest with plants in view 18:34:38 -!- omnirizon has quit [Ping timeout: 265 seconds] 18:34:42 huh. that's neat 18:34:45 And I think that's what it does 18:34:46 the god-abil one was an && / || swap and amethyst got that 18:34:55 but confusing, like you said 18:34:59 * floatingatoll nods 18:35:11 i don't know enough about the game+internals to follow that logic chain and have a true sense of what is going on 18:35:16 Or rather, that's one thing the patch does, and the second bit is to prevent that happening when whacking plants with chaos 18:35:28 <|amethyst> Basil: right, it's the whacking plants bit that is a problem 18:35:35 <|amethyst> Basil: what if someone whacks the player with chaos? 18:35:37 which would be when the plant is a defender 18:35:42 Basil: but you can't do !mons_is_firewood(defender->as_monster()) is defender is the player 18:35:59 ah, so the 4-length one is "jump attack doesn't check to make sure defender is non-null" 18:36:32 if defender is the player* 18:36:54 MarvinPA: defender->as_monster() crashes when the player is the defender, or something? 18:37:00 <|amethyst> Basil: it returns null 18:37:06 hmm 18:37:17 null->anything is a zero-deref-abort, right? 18:37:26 MarvinPA: I think that's not quite right 18:37:36 it's if the attacker is a monster 18:37:46 I'll fix that in a second 18:38:01 talking about https://dl.dropboxusercontent.com/u/7533709/scan-build-2014-04-22-150728-34977-1/report-919dae.html#EndPath for reference 18:39:23 if it's desirable, i can write up my steps to repro for generating this. i used OS X, but it doesn't require anything beyond Xcode and the clang static analyzer tarball. 18:39:37 * floatingatoll likes to find small fixes with proofreading, basically 18:39:50 like this which removes two useless assignments: http://atoll.pastebin.mozilla.org/4909464 18:40:10 (and two of the 'dead store' reports) 18:40:24 (todo remove abandoned shops to dead stores) 18:40:25 <_< 18:40:29 haha 18:41:35 -!- Pepe has quit [Read error: Connection reset by peer] 18:42:26 -!- HellTiger_ has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/] 18:42:45 the ouch.cc trace seems to be complaining that you can pass both a null *bolt object AND doEffects true 18:42:56 which is because the function has two purposes, calculate *and* apply 18:43:46 floatingtoll: Yes, I hate how much Crawl code violates the single responsibility principle. 18:44:00 well, i don't have an opinion there, but it helps for preparing a patch :) 18:44:03 (to know) 18:45:38 so, http://atoll.pastebin.mozilla.org/4909504 18:45:47 to catch coding errors, basically. 18:45:48 -!- lawman0 has quit [Ping timeout: 240 seconds] 18:45:56 does anyone other than galehar know anything about transifex? 18:45:57 https://crawl.develz.org/tavern/viewtopic.php?f=19&t=11868 18:46:26 Transifex is a cloud-based Continuous Localization Platform trusted by thousands of developers. Localize software at the speed you develop code. 18:46:27 the dcss project seems to have mysteriously disappeared, i think i messaged galehar about that thread before but he's not been around 18:47:38 -!- UncertainKitten has quit [Ping timeout: 240 seconds] 18:48:14 -!- HellTiger has quit [Ping timeout: 276 seconds] 18:48:26 <|amethyst> that simulacrum thing... 18:49:00 <|amethyst> does item.orig_monnum really hold a monster_type? 18:49:06 MarvinPA, I don't think any of the other people who were listed as Transifex admins are around much (if at all) either? 18:49:22 -!- nooodl_ has quit [Quit: Ik ga weg] 18:49:30 <|amethyst> oh, I guess it does 18:49:45 dgn-height.cc, i think it's saying that if c.y - radius is greater than c.y + radius initially, it will divide-by-zero 18:49:47 -!- dtsund has quit [Quit: dtsund] 18:49:56 that seems .. unlikely, unless there's floats here, which there aren't. 18:50:00 possible, for very large values of radius 18:50:00 maybe worth an email to the mailing list then, i don't know who was an admin other than galehar and kilobyte 18:50:04 ah! 18:50:09 MarvinPA: jpeg 18:50:11 (oddly) 18:50:15 MarvinPA: and that's it. 18:50:18 are any such large values in use? 18:50:27 well, probably not 18:50:34 does 'int' here default to unsigned int? 18:51:04 * floatingatoll asks a stupid question, sorry. 18:51:28 -!- Patashu has joined ##crawl-dev 18:51:32 I'm pretty sure it defaults to signed. 18:51:57 Yeah, defaults to signed. 18:52:23 floatingatoll: also 18:52:26 if radius is 0 18:52:32 If I want a targetter (such as for casting a targetted spell or god ability) to provide extra information when highlighting an enemy, then I use a desc_filter, right? (directn.h direction_chooser_args, mon-info,h desc_filter) 18:52:33 ...no 18:52:38 misread 18:52:39 nvm 18:52:48 -!- BigBluFrog has quit [Ping timeout: 240 seconds] 18:53:38 -!- Pepe has quit [Read error: Connection reset by peer] 18:53:51 my theory was just to add if (divisor == 0) return; 18:54:06 since that means there was no valid adjustment to make, and the rest of the function just gives up at that point 18:54:12 -!- lobf has joined ##crawl-dev 18:54:20 i can't picture *how* it would occur, but one less opportunity for a null deref 18:54:24 er, div-by-zero 18:54:44 <|amethyst> floatingatoll: ASSERT(c.y - radius <= c.y) 18:54:48 ooo 18:54:50 <|amethyst> I guess 18:54:59 <|amethyst> floatingatoll: ASSERT(c.y - radius <= c.y && c.y + radius >= c.y) 18:55:03 <|amethyst> or 18:55:13 <|amethyst> ASSERT(c.y - radius <= c.y + radius) 18:55:13 well, or, ASSERT(c.y - radius <= c.y + radius) 18:55:18 since that's what the condition uses 18:55:38 -!- soundlust has quit [Ping timeout: 240 seconds] 18:55:41 this might be an instance of "analyzer doesn't quite understand math" 18:55:44 in principle, that's undefined behavior in the same case 18:55:46 no 18:55:46 i'm more worried about the melee-attack ones 18:55:48 the analyzer understands c 18:55:51 ok 18:56:00 anyway yeah this isn't a big deal 18:56:05 <|amethyst> floatingatoll: no, it's: 1) radius may be negative 18:56:06 I doubt it'll ever come up (huge radius) 18:56:10 oooh 18:56:11 what? 18:56:14 <|amethyst> floatingatoll: 2) radius may be so large as to overflow 18:56:22 * floatingatoll twitches 18:56:28 oh, I forgot about the negative case 18:56:35 <|amethyst> neither of which probably actually happens 18:56:41 -!- soundlust|2 has quit [Ping timeout: 276 seconds] 18:56:50 radius probably shouldn't be signed, but then you're mixing signed and unsigned math 18:57:01 no calls to dgn_smooth_heights provide any radius value at all 18:57:06 so ASSERT(radius > 0) ? 18:57:13 er, ASSERT(radius >= 1) i imagine :) 18:57:29 radius >= 0 would be fine 18:57:36 except for very large values of radius 18:57:45 hurk 18:57:49 hahahaha 18:57:50 okay, so i know what bug to file 18:57:53 -!- scummos__ has quit [Ping timeout: 264 seconds] 18:57:58 'convert dgn_smooth_heights to unsigned ints' 18:58:02 * floatingatoll :) 18:58:09 <|amethyst> I would not do that 18:58:15 <|amethyst> making it unsigned doesn't fix anything 18:58:18 * floatingatoll is half joking and has no actual idea what to do at all 18:58:43 should i drop a ticket for each patch i come up with? 18:59:10 please do not stress over c integer overflow behavior 18:59:17 <|amethyst> floatingatoll: one ticket would probably be fine, but one ticket per patch lets us keep our numbers up :) 18:59:50 03floatingatoll02 {|amethyst} 07* 0.15-a0-200-g2251764: dgn-proclayouts.cc: fix DNGN_SLIMY_WALL, DNGN_UNSEEN switch fallthroughs 10(50 minutes ago, 1 file, 2+ 0-) 13http://s-z.org/neil/git/?p=crawl.git;a=commitdiff;h=2251764b3164 18:59:50 03floatingatoll02 {|amethyst} 07* 0.15-a0-201-gb26498d: tilepick-p.cc: fix SP_NAGA switch fallthrough 10(43 minutes ago, 1 file, 1+ 0-) 13http://s-z.org/neil/git/?p=crawl.git;a=commitdiff;h=b26498d20019 18:59:50 03|amethyst02 07* 0.15-a0-202-g087243c: Fix a potential null dereference in Beoghification (floatingatoll) 10(35 minutes ago, 1 file, 1+ 1-) 13http://s-z.org/neil/git/?p=crawl.git;a=commitdiff;h=087243cc9157 18:59:53 * floatingatoll reads 'yes' 18:59:57 <|amethyst> I've got to go, could someone please apply the relevant fixes to 0.14 ? 18:59:58 things! 19:00:25 Beoghification is a very good word 19:00:27 I'm out 19:00:41 oh, i should do this on 0.14 19:00:50 * floatingatoll smiles 19:01:19 -!- PleasingFungus has quit [Quit: ChatZilla 0.9.90.1 [Firefox 31.0a1/20140325030201]] 19:01:29 floatingatoll: I'd recommend you carry on doing it the way you have been 19:02:27 ok. there's a .. lot .. of them 19:03:08 will take it slowly and teach myself the code as i go :) 19:10:16 -!- CKyle has joined ##crawl-dev 19:13:18 -!- Krakhan has quit [Ping timeout: 240 seconds] 19:14:35 -!- Keanan has quit [Quit: Leaving.] 19:17:28 -!- Krakhan has quit [Changing host] 19:19:26 -!- rossi has quit [Ping timeout: 252 seconds] 19:20:10 03Sage02 07* 0.15-a0-203-gac65f08: Fix a bug in chaos brand polymorph. 10(34 minutes ago, 1 file, 2+ 1-) 13http://s-z.org/neil/git/?p=crawl.git;a=commitdiff;h=ac65f0854c1f 19:20:13 -!- CKyle has quit [Quit: CKyle] 19:20:33 -!- PleasingFungus has joined ##crawl-dev 19:24:32 * reaverb notices that somebody still needs to apply the relevant fixes to 0.14. 19:25:22 -!- eb has joined ##crawl-dev 19:25:45 -!- Krakhan has quit [] 19:25:56 -!- Kvaak has quit [Ping timeout: 276 seconds] 19:27:17 -!- Foamed has quit [Ping timeout: 255 seconds] 19:28:40 I'm going to close the floatingatoll's patch issues on mantis. 19:29:30 uhh are bow brands broken? 19:29:43 Im equipping a flaming bow and regular arrows and not seeing any fire damage messages 19:29:48 or making dith mad 19:30:02 johlstei: Seems odd. what verson? 19:30:12 &whereis johlstei 19:30:13 some tip build somewhere in 0.14 i think 19:30:13 %whereis johlstei 19:30:14 johlstei the Grappler (L9 TrIE), a worshipper of Ashenzari, dead on D:8 on 2014-04-22 after 6898 turns. 19:30:21 nah not online 19:30:23 my own build with wizmode 19:30:26 that i used to test this 19:30:41 johlstei: is it a bow of flaming or a bow of flame 19:30:58 johlstei: flaming is the melee brand and won't work on launchers 19:31:05 oh haha okay 19:31:12 wait its bow of flame 19:31:27 err nah it says flame in one place, flaming the other 19:31:42 yeah, it will say (flame) in the short description in the main screen 19:31:47 of flaming in your inventory 19:32:34 thank you that was it 19:32:36 appreciate it 19:33:14 np, someone had the reverse issue (melee weapon with launcher brand) a few days ago :) 19:33:38 of course the code handling those brands separately like that isn't great 19:34:11 no worries, im not here to play code police, one day when the ranged code is rewritten im sure everyone will be happy 19:34:33 -!- Krakhan has quit [Changing host] 19:34:45 yeah, "wait until Grunt finishes rewriting everything" is our plan :P 19:36:24 elliptic: He's already implmented melee and range brands being the same if I recall correctly. 19:37:29 yeah, it sounded like he was mostly done with the rewrite (though balance will certainly need some work) 19:37:59 -!- rchandra has left ##crawl-dev 19:38:28 There are a couple of loose ends to tie up and then it's all balance work, basically. 19:40:01 is ranged delay going to work the same way as melee delay? 19:40:14 (or at least not be affected by stats?) 19:40:39 Right now it works the same as melee delay (this *is* based on melee code after all). 19:41:01 This is partly based on the theory that galehar or someone will eventually come up with a new attack delay formula <_< 19:42:54 -!- lobf has quit [Quit: lobf] 19:47:08 -!- demiskeleton has quit [Ping timeout: 265 seconds] 19:48:51 -!- rast has quit [Read error: Connection reset by peer] 19:49:03 * reaverb wonders if enough time has passed that he can say his player-reacts.cc patch did not break Xcode or MSVC. 19:49:04 -!- rast has joined ##crawl-dev 19:56:20 -!- Zermako has quit [Quit: good night] 20:02:48 -!- Foamed_ has quit [Quit: Heading to bed.] 20:04:22 -!- CKyle has joined ##crawl-dev 20:05:27 -!- Lasty1 has quit [Quit: Leaving.] 20:06:46 -!- turde has quit [Ping timeout: 252 seconds] 20:08:18 -!- Moredread has quit [Ping timeout: 240 seconds] 20:11:23 -!- Watball has quit [Quit: Leaving] 20:14:41 is there a formula for 'probability that xdy will be greater than z' ? 20:19:21 -!- agolden has quit [Quit: agolden] 20:19:44 -!- emagenta has quit [Quit: Leaving.] 20:20:55 -!- computergeeksjw has quit [Client Quit] 20:21:02 -!- dudearm has joined ##crawl-dev 20:21:12 Patashu: Yes there is. 20:21:40 But that's a statistics question, not a Crawl development question. I don't know the anser off the top of my head. 20:23:55 it is a crawl development question now :) 20:23:58 because I need it for a patch I am making :) 20:24:31 Patashu: Maybe x_chance_in_y() would be better? What's the patch? 20:25:13 if it's something like displaying actual chance to pacify or to hex something i think it is very unlikely that gets into crawl 20:25:28 -!- edlothiol has quit [Ping timeout: 252 seconds] 20:25:28 crate: why is that? spell miscast rate used to be words and now it is a %. 20:25:55 this is much closer to doing things like displaying actual spell damage or melee damage 20:26:00 which i am pretty confident will not happen 20:26:18 (also it's an info leak for pacification) 20:26:22 (since it tells you monster maxhp) 20:26:30 oh, I have a plan for that actually 20:26:32 it'll show two %s 20:26:38 first is if the monster rolled min max hp 20:26:41 second is if the monster rolled max max hp 20:26:44 well see now you're just getting into displaying lots of numbers 20:26:49 that sounds even less likely to make it in then, yes 20:26:50 yeah, that's the main problem with it 20:27:02 lol 20:27:06 i actually think the pacification messages as they are are fine 20:27:06 Patashu: Also, the reason for removing words was that those words were incredably misleading. 20:27:06 and the hex ones 20:27:17 they tell me what i need to know 20:27:22 well, if I can't do a %-% and I can't leak max hp, then I can't do anything 20:27:23 XD 20:27:39 yes, your patch is aimed at a game with a different design philosophy 20:28:26 crate: One thing is that pacify messages seem unlike new hex messages 20:28:35 yes, the pacify messages are like old hex messages 20:28:42 they tell you 'you didn't make it' or 'oh, you just barely missed' like old hex messages 20:28:42 -!- _aardvark has quit [Ping timeout: 240 seconds] 20:29:08 well you can presumably change that and that would get accepted 20:29:09 (or like current melee messages for that matter!) 20:29:34 That Enchantress person seems sort of dodgy 20:29:35 i dont find the new hex messages significantly more useful than the old ones, though i do agree they are better 20:29:41 (just not a huge difference imo) 20:29:54 having fancy adjectives every single time you attack a monster and miss seems awful and useless to me 20:30:13 crate: the usefulness is that (if you don't want to do the calculations of MR and hex power and all that) then after failing just once you know how likely it will be on every different cast 20:30:14 so let's not bring melee messages into the discussion :P 20:30:17 which is better than old hexes 20:30:18 melee combat has lots of messages as-is yes 20:30:22 Patashu, yes i know the difference 20:31:15 on average the old system told you that also, and the majority of the time there is no real difference 20:31:39 the new messages are better, but it's not a big deal 20:32:47 -!- Lobsterpants has quit [Client Quit] 20:34:09 -!- Bloax has quit [Quit: Error: Bloax not found] 20:34:16 btw, there is actually a small actual_max_hp information leak in ely healing. it tells you if you could never pacify the monster with this invocation, based on its actual_max_hp not its max_possible_max_hp 20:34:18 (but no one cares) 20:35:19 well it tells you 1) after you've tried to do so (so you at least spend a turn) and 2) only if attempting to pacify was pretty hopeless regardless 20:36:34 -!- debo has joined ##crawl-dev 20:39:11 * reaverb wonders why max hp is randomized in the first place. 20:40:56 -!- CKyle has quit [Quit: CKyle] 20:44:24 -!- bh has joined ##crawl-dev 20:44:31 transifexpocalypse? 20:44:32 bh: You have 1 message. Use !messages to read it. 20:44:50 transifu-- wait. 20:45:02 -!- Lobsterpants has quit [Quit: Page closed] 20:47:54 ??goodplayer 20:47:55 goodplayer ~ goodplayers[1/1]: 10 or more wins. 20:49:18 -!- conted has quit [Ping timeout: 240 seconds] 20:51:26 dgn-height.cc: avoid divide-by-zero in dgn_smooth_height_at() when divisor result is 0 by floatingatoll 20:53:05 -!- Eonwe7 has quit [Read error: Connection reset by peer] 20:54:59 -!- thetabyte has quit [Ping timeout: 276 seconds] 20:56:37 Maybe yred animate remains hunger cost could be halved? 20:57:46 -!- raskol` has quit [Quit: quit] 20:58:41 Basil: I don't think you really need to ask permission for such a small tweak. <_< 20:58:53 It's not like it can't be reverted. 21:00:08 I'd like to avoid fooling around with reverts 21:00:27 And I ask because I'm not really sure what the hunger cost is supposed to achieve in the first place 21:00:36 reaverb: it's still reasonable to ask for input from other people here... obviously he doesn't have to do so, but it can't hurt 21:01:13 it having a hunger cost is reasonable, it does limit a bit how many corpses you make into zombies 21:01:20 It can if they have ridiculous ideas ;) 21:01:27 since you lose nutrition from using it + you lose nutrition from not getting chunks 21:01:34 ouch.cc: add argument checks for function check_your_resists() by floatingatoll 21:01:48 crate: I just won an OgDK and found at no time was I food constrained 21:02:06 it gives you a zombie or two or three fewer per floor 21:02:10 Mostly I chop up "useless" corpses, and I dislike that makes me focus more on the food game 21:02:33 For reference, Animate Remains is currently half the hunger cost of Banish 21:02:37 <|amethyst> floatingatoll: the patch in 8416 has a problem 21:02:39 ok 21:02:40 elliptic: Yes, asking for feedback on ideas is good. I just thought from the phrasing Basil wouldn't do it if he didn't get somebody else to approval it, which I didn't think was desirable. 21:02:42 * floatingatoll checks it 21:02:59 aw, damn 21:03:01 i hate these non-braces things 21:03:07 * floatingatoll comes from non-C :( 21:03:24 -!- MaxFrost has quit [Ping timeout: 252 seconds] 21:03:49 Does anyone find that food is actually a hard constraint on how they play? 21:04:02 -!- debo has quit [Ping timeout: 255 seconds] 21:04:08 -!- mamgar has quit [Read error: Connection reset by peer] 21:04:18 bh: Healers, apparently. 21:04:30 Also berserking occasionaly, but that's a bit more tactical. 21:04:54 reaverb: and it stops you from spamming spells that you shouldn't be casting 21:05:03 Like? 21:05:13 |amethyst: _2.patch added, i don't have delete rights on the broken one 21:05:28 floatingatoll: I'll do, I'll delete it. 21:05:32 -!- CKyle has joined ##crawl-dev 21:05:36 ta 21:05:37 s/I'll do/I do/ 21:05:48 -!- tabstorm has joined ##crawl-dev 21:06:10 There done. 21:06:44 (I also resolved your two previous patches which were pushed, btw) 21:07:00 -!- alefury|2 has quit [] 21:07:12 * floatingatoll bows 21:07:27 So, that's no objections to halving animate remains hunger, I take it? 21:07:38 did godprayer.cc used to have more code after the "Return early so we don't offer our Necronomicon to Kiku" comment? 21:08:10 or, should it return did_something instead of true? or .. 21:08:15 -!- rchandra has joined ##crawl-dev 21:09:01 I just noticed that roll_dice and roll in random.cc use 0-based dice rather than 1-based dice. I bet a lot of people have forgotten that when coding/looking at the source 21:09:03 i read through it and it seems like the theory here is that returning true, no matter what, prevents us from offering a book to the god via prayer. (which i didn't know i could do.) 21:09:03 !source godprayer.cc 21:09:04 http://s-z.org/neil/git/?p=crawl.git;a=blob;f=crawl-ref/source/godprayer.cc;hb=HEAD 21:09:09 line 273 21:09:15 -!- Piginabag has quit [Quit: Page closed] 21:09:58 Patashu: dive the source :) 21:10:39 Patashu: errors tend to be caught pretty quickly - although it took me a while to get the box_level bug fixed. 21:11:09 -!- debo has joined ##crawl-dev 21:11:11 However, good luck browing through ever random2() call in the source if you're willing to do that. 21:11:17 s/ever/every 21:11:31 -!- Lasty1 has joined ##crawl-dev 21:11:51 reaverb: I just noticed that the formula for lesser healing/greater healing on the wiki is wrong 21:11:54 because 21:12:07 the formula is presented as though roll_dice(x,y) calls are 1-indexed 21:12:11 but they're not, they're 0-indexed 21:12:17 Patashu: There are a lot of things on the wiki which are wrong. The formulas are hardly the only thing. 21:12:33 godwrath.cc: greater = 2 + random2(you.experience_level / 5 - 2); // up to 6 at XL27 21:12:36 <|amethyst> floatingatoll: yes, in 0.7.0 21:12:36 5, actually, right? 21:13:06 <|amethyst> floatingatoll: 4 actually 21:13:08 2+random2(27/5)-2) = 2+random2(3) = 2+(0, 1 or 2) = 4 21:13:10 or am I missing something 21:13:12 you're not :) 21:13:32 Patashu: Wow that's weird. 21:13:45 <|amethyst> Patashu: roll_dice is 1-based though 21:13:50 lemme look again 21:13:58 mon-project.cc: double angle0 = random2(2097152) * PI / 1048576; 21:14:00 OH 21:14:00 * floatingatoll blinks 21:14:02 <|amethyst> Patashu: see line 202 21:14:03 sneaky, it's 1-based indeed 21:14:19 <|amethyst> if it says "dice" it's probably 1-based 21:14:19 floatingatoll: I have no idea why that comment in godprayer.cc is there but if you look at the function in it's entirely the return true; makes perfect sense. I would just remove it the comment, but somebody could run a git blame if they wanted to. 21:14:31 floatingatoll: that's grabbing a random angle between 0 and 2*PI 21:14:39 random.cc has all the indexing in set notation, whihc is very nice. 21:14:41 reaverb: i only found it because the assignment to did_something is useless now 21:14:48 |amethyst: thanks for correcting my mistake early, lol 21:14:50 <|amethyst> reaverb: well, there's a return just after that too 21:15:04 and, yeah, it returns out immediately afterwards 21:15:11 with .. either true or false, depending on did_something 21:15:29 so the real question: if did_something is false at that point, is it a bug to return true? 21:15:32 maybe it should use rand_round_div(you.experience_level, 5) ? 21:15:35 then at least it can go up to 5 :) 21:15:53 floatingatoll: No, return did_something is called if that if KIKU statment is false, and can return either value. 21:15:58 * floatingatoll nods 21:16:08 but in the case where the last line of kiku says 'return true' 21:16:15 is that still the appropriate behavior, or should it return did_something? 21:16:24 * floatingatoll has no idea what happens down the line based on that return value 21:16:37 feels weird to be forcing a return true even if nothing did_something 21:16:50 -!- Lasty1 has quit [Quit: Leaving.] 21:16:51 floatingatoll: Ah, I see. I would also delete line 273. 21:16:53 <|amethyst> floatingatoll: see pray() 21:17:26 <|amethyst> floatingatoll: that makes it so that if you pray over the altar to get a book, bot the book couldn't be created, it doesn't go on to do a normal prayer 21:17:33 flatingatoll: Of course ideally I would change gods to classes and make this function a method so we don't have all those nasty If you_worship() calls. 21:17:49 ah. 21:17:58 <|amethyst> which doesn't matter for Kiku since prayer no longer sacrifices 21:18:13 Well there would be text bugs about duplicate messages. 21:18:16 <|amethyst> so it only affects the messages 21:18:46 <|amethyst> reaverb: OTOH, the current situation means you might not get a message at all 21:18:58 <|amethyst> reaverb: if you're a felid and the necronomicon couldn't be created 21:19:11 <|amethyst> (which would only happen AFAIK if there are too many items on the level) 21:19:31 |amethyst: In that case the function returns false, see line 262 21:19:31 if (thing_created == NON_ITEM) 21:19:41 is that always NON_ITEM if it fails entirely? 21:20:04 <|amethyst> reaverb: err, sorry, if move_item_to_grid fails 21:20:09 * floatingatoll reads items() 21:20:16 if it can't get a slot, it returns NON_ITEM 21:20:19 -!- Daekdroom has quit [Quit: Saindo] 21:20:37 so, yeah, if item creation fails, onwards to prayer 21:20:51 <|amethyst> hm 21:21:01 move_item_to_grid, however, can return false in some cases. 21:21:08 lots of bool returns in it 21:21:54 <|amethyst> move_item_to_grid currently will only set thing_created to NON_ITEM if the feature destroys the item 21:22:08 <|amethyst> but since kiku altars aren't lava, that shouldn't happen 21:22:17 |amethyst: Yes, does C++ short circuit? I would just add || move_item_to_grid to the if item==NON_ITEM call. 21:22:23 so, how about this? 21:22:23 <|amethyst> but, yeah, ignoring the return of move_item_to_grid seems bad 21:22:24 http://atoll.pastebin.mozilla.org/4911091 21:22:36 if anything goes wrong, it returns false, and a normal prayer message occurs 21:22:43 if it successfully delivers the book, did_something is true, so no duplicate message 21:22:48 <|amethyst> floatingatoll: err 21:23:09 <|amethyst> floatingatoll: that pretends it failed if the item ends up in slot 0 21:23:22 oh, i see. 21:23:23 -!- raskol has quit [Ping timeout: 255 seconds] 21:23:26 return value vs. assignment to thing_created, got it. 21:24:22 revised http://atoll.pastebin.mozilla.org/4911114 21:24:38 |amethyst: Also, this message always appears: mpr("You prostrate yourself in front of the altar and pray.") 21:24:50 floatingatoll: How are you making these patches so fast? 21:24:57 reaverb: ? 21:25:00 (Besides not compiling) 21:25:13 vim, recompiling single files, lots of practice at patch discussion on irc i guess 21:25:34 flatingatoll: So you use the same git patch commands? 21:25:43 git diff | ~/bin/pastebin diff 21:25:52 also, i have a stash with like 12 commits pending as i go throught hem 21:26:22 floatingatoll: I haven't really looked at bin stuff before, guess I probably should. 21:26:47 Oh, that automatically pastes something oops. 21:26:48 i'll submit this one as 'check the result value of move_item_to_grid, return did_something even if necro-kiku' 21:27:53 in C++ can I do this? int arraysize = num*size-(num-1); int seed[arraysize]; 21:28:04 or do I need to use a vector? 21:28:05 hey ##dev -- we have all sorts of challenge races: no teleport, no healing, no armour, no potions. We need a no jewelry race 21:28:08 "need" 21:28:11 NEED 21:28:15 ??bh 21:28:15 bh[1/4]: When it comes to stupid ideas, I'm your man. 21:28:18 ha! 21:28:29 there's no 'no scrolls' race yet, hint hint 21:28:43 scrolls are complicated because of remove curse 21:28:44 * floatingatoll hums 'losing my religion' 21:28:54 oh, and the 'no god' race 21:29:09 do any gods grant remove curse as a blessing? 21:29:09 Patashu: You can do that. 21:29:19 in sufficient likelihood to be of any use whatsoever, really 21:29:26 Patashu: I would recommand ##C++-general for C++ questions though. 21:29:47 You teleport away from the altar! Your prayer is interrupted. Vehumet is angry with you. 21:30:01 * floatingatoll hee hee. 21:30:21 that would actually be terrific, if a cursed ring of teleport could result in god wrath for betraying them during the prayer ritual. 21:30:32 sounds like a 4.1 thing 21:30:37 I still don't get why people make "challenge" races which are just "Don't use X" 21:30:46 or at least a 4.1-esque thing) 21:30:46 'all scrolls are remove curse' 21:30:54 would be a useful challenge 21:31:03 Make it a bit more interesting! Add something like Formorcides where the restiction comes with gains! 21:31:07 just set the scroll drop to 100% remove curse and call it 'no scrolls' :) 21:31:21 (do scrolls damage you when they incinerate in your bag? do they cascading damage other items?) 21:31:29 No. 21:31:33 To the second. 21:31:37 and the first actually 21:31:53 IVAN is the roguelike where stuff destroying in your backpack can effect you 21:31:53 not crawl 21:32:01 * floatingatoll knows not of it 21:32:20 i was just thinking of negative effects from dropping an excessive number of remove curse scrolls 21:32:42 @floatingatoll: The vault warden activates a sealing rune. The altars slam shut! You are pushed out of the altar! Your prayer is interrupted. 21:32:54 huh! 21:33:42 (btw, is it a bug or devs being nice that if a vault warden seals stairs after you start climbing you're not interrupted?) 21:33:44 (I for one appreciate it ;) ) 21:34:00 That was an unintended effect of delay code 21:34:20 floatingatoll: Endless Ash swapping for one thing. 21:34:29 Or rather, wardens stopping you midascent was. 21:34:47 Patashu: It was decided it was a bug but it was pretty ambigious. It was cetainly not intended. 21:34:49 <|amethyst> %git 63f152f 21:34:50 07Grunt02 * 0.14-a0-3245-g63f152f: Allow players to continue traversing stairs if they get sealed halfway. 10(6 weeks ago, 1 file, 3+ 3-) 13http://s-z.org/neil/git/?p=crawl.git;a=commitdiff;h=63f152f1fce2 21:35:02 thanks 21:35:25 so the (almost) no scroll challenge would just be a simple 'return if not SCROLL_REMOVE_CURSE' prior to move_item_to_whatever 21:35:34 * floatingatoll didn't know there were challenges 21:36:00 <|amethyst> presumably you'd want messages 21:36:57 <|amethyst> and move_item_to_player isn't the only way to get a scroll in your inventory 21:37:20 03Sage02 07* 0.15-a0-204-g4af7b67: Halve Yred animate remains hunger cost. 10(17 minutes ago, 1 file, 2+ 2-) 13http://s-z.org/neil/git/?p=crawl.git;a=commitdiff;h=4af7b67809a2 21:37:23 <|amethyst> at the very least there's Wr starting equipment 21:37:33 How about we make the indestructable startegic consumable item catagory first then try no scrolls? 21:37:48 ? 21:38:25 floatingatoll: Idea floating around to make !benfical mutation, !cure mutation !XP, ?acquire ?enchant foo etc. into a new item catagory since it never makes sense to carry them around. 21:38:32 Since you can come back at any time to use them. 21:38:46 <|amethyst> so that then you can carry them around 21:38:52 that notation is !potion ?scroll ? 21:39:01 <|amethyst> floatingatoll: yes 21:39:10 flatingatoll: Yes, since in ACSII potions are shown as ! and scrolls as ? 21:39:16 yeah 21:39:21 reaverb: their glyph should be the interrobang 21:39:24 indestructible strategic consumable category seems sort of pointless if we are removing item destruction anyway 21:39:37 -!- SurpriseTRex has quit [Ping timeout: 240 seconds] 21:39:45 would the item category count as additional inventory slots beyond the current backpack limit? 21:39:58 or is it purely to prevent destruction and thus to prevent needless dungeon travel just to pick them up 21:41:06 I think there a few advantages (new acquire catagory, quickly tell if a consumable is stategic) but I'm more concerned that sevarl previous attempts to remove item destruction have failed while new item catagory is pretty universally liked. 21:41:26 new acquire category? that sounds bad 21:41:35 <|amethyst> acquire acquirement 21:41:38 there haven't been "previous attempts to remove item destruction" 21:41:56 <|amethyst> there was a branch that removed item destruction and replaced it with inability to use items 21:42:09 <|amethyst> most of the objections to that were to the latter part 21:42:19 yes, that branch was doing two separate things 21:42:27 godprayer.cc: Kiku/Necronomicon fixes, check result of move_item_to_grid and fix return value by floatingatoll 21:42:32 <|amethyst> (though there were some objections to removing it entirely beforehand, which is why bh added the alternative instead) 21:42:42 Speaking of, should I crib newrefrig code from there 21:42:44 treatise of acquirement? 21:42:53 tapestry! papyrus! 21:42:58 * floatingatoll mumbles nouns to himiself 21:43:10 ^right. I'd rather remove it altogether 21:43:26 <|amethyst> "tablet" 21:43:34 <|amethyst> and then it's ambiguous 21:43:40 webtiles hates item destructions. What can I say? I'm just a man of the people. 21:43:42 <|amethyst> it could be a stone tablet for ?enchant, a pill for !XP 21:43:48 -!- zeia has quit [Ping timeout: 240 seconds] 21:44:08 |amethyst: Heh, but I think a stone tablet works fine for XP. 21:44:19 What would the glyph be? 21:44:24 <|amethyst> Then we'll need to remove sticky flame probably 21:44:32 <|amethyst> sicne it's kind of pointless without the item destruction 21:44:37 bye bye mottled dragons 21:44:42 <|amethyst> poison that checks a different resistance 21:44:42 |amethyst: it could just have a damage boost 21:44:42 bye bye mottled dragon armour 21:44:53 It isn't pointless, It's just like posion but you're on fire. 21:44:56 mm, actually 21:44:59 Dmg over time is fine. 21:45:01 it is sufficiently different from poison I think, since curing doesn't cure it 21:45:03 I thought the point of sticky flame is that it does damage over time and rPois doesn't help 21:45:11 Should -Potion from Ozo's refrig stack per cast? 21:45:21 <|amethyst> I guess the curing thing makes sense 21:45:24 is there a sticky for each resist type? 21:45:31 fire, cold, negative, electricity, poison 21:45:31 Basil: I don't think so. 21:45:39 <|amethyst> floatingatoll: no, just flame and poison 21:45:42 Basil: i assume if youre casting it a lot its going to have a lot of dead dudes at the end 21:45:49 And should there be a fixed number of turns it disables potions? 21:45:58 5, 10, some random number 21:46:08 You throw an electric eel egg at the monster. It sticks! It zaps the monster! 21:46:28 Basil: there should be some randomization at least 21:46:35 I'd say it shouldn't depend on spell power, though 21:46:42 <|amethyst> bh: rPois doesn't help against sickness either, but it sounds like it's on the way out 21:46:45 just pick some range 21:46:47 sticky negative energy would be more like a malignant aura of draining 21:46:59 |amethyst: rPois is on its way out? 21:47:00 elliptic: 5-10 turns or 7-15 sound better 21:47:05 |amethyst: and curing does cure sickness 21:47:12 <|amethyst> bh: OTOH, there are 1) the curing thing 2) the fact that sickness was a lot weaker than poison unless you have high regen 21:47:20 <|amethyst> bh: sickness I mean 21:47:22 And when you recast, it rolls again and takes the higher of the remaining duration and the new roll 21:47:34 every race that has poison immunity also has sickness immunity 21:47:49 Basil: how about 7-15 if it isn't going to stack 21:47:50 so i dont think the rpois thing is a big deal 21:47:55 wrt sickness 21:47:56 sounds good 21:48:14 anyway I think sticky flame is at least worth trying with increased damage to the player 21:48:29 rather than removing it immediately 21:48:40 <|amethyst> crate: huh? every race that has fire vulnerability can't use potions, but that doesn't mean they're the same thing 21:48:50 also another thing differentiating sticky flame from poison is that now poison works differently 21:48:51 (Would anybody object if I later changed all those did_something from godprayer.cc to return statements? Single exit point is good, but pretending to have a single exit point with a binary flag is silly) 21:48:59 -!- rast has quit [Read error: Connection reset by peer] 21:49:15 |amethyst, well there is precedence for rpois-ignoring poison 21:49:20 -!- rast has joined ##crawl-dev 21:49:25 reaverb: i didn't check how many of them fell through to th enext after assigning that flag 21:49:26 (parrow, player otr) 21:49:28 but, sure, has my vote 21:49:33 'less non-apparent' 21:49:41 floatingatoll: None of them do. 21:49:46 hah. 21:49:57 <|amethyst> meaning those should be elses 21:50:03 (Which is one reason this should be polymorphic) 21:50:39 -!- crate has left ##crawl-dev 21:51:39 -!- bh has quit [Quit: sleep] 21:53:15 -!- nerdlord_ has quit [Ping timeout: 250 seconds] 21:54:33 hmm 21:54:48 Should monster refrig still pop potions? 21:54:52 -!- pwnmonkey has quit [Read error: Connection reset by peer] 21:54:53 -!- CKyle has quit [Quit: CKyle] 21:55:30 Basil: Does it pople the monster's potions? 21:55:34 <|amethyst> Basil: before or after removal of item destruction? 21:55:39 before 21:55:47 -!- Quashie has quit [Ping timeout: 255 seconds] 21:55:55 <|amethyst> reaverb: monsters are not subject to item destruction at all, are they? 21:56:06 Well, it could also prevent the player from drinking potions 21:56:06 <|amethyst> other than acid breath 21:56:09 but that sounds a little iffy 21:56:15 |amethyst: just corrosion, yeah 21:56:18 |amethyst: I don't know. 21:56:30 Basil: that sounds definitely iffy to me :P 21:56:43 <|amethyst> that would be a pretty big Fannar buff I think, yes 21:57:09 -!- debo has quit [Quit: debo] 21:57:18 -!- tabstorm has quit [Ping timeout: 240 seconds] 21:57:21 my philosophy about effects that prevent the player from using scrolls or potions is that they should always be the player's choice 21:57:39 util/ tile.cc, tile_list_processor.cc warnings from -Wlogical-op-parentheses by floatingatoll 21:57:39 the player can choose to cast lichform or cast refrig, or play a mummy 21:57:54 I'll leave monster refrig untouched 21:58:12 <|amethyst> elliptic: plague shamblers currently do that 21:58:42 and there is so much complaining about them 21:58:43 |amethyst: yeah, and I don't like it very much (neither did dracoomega the last time we talked about it, iirc) 21:58:44 everywhere 21:58:45 forever 21:59:04 <|amethyst> floatingatoll: I don't think we're going to reparenthesise everything that uses both && and || 21:59:10 PleasingFungus: complaining about Plague shamblers? 21:59:13 yes 21:59:48 |amethyst: automated tools! Are you a programmer or not? 22:00:10 Assumign that was in responce to a suggestion to change the programming guide. 22:00:11 -!- Fizybubbleh has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client] 22:00:18 <|amethyst> reaverb: I'm not sure I'd want to automatically do it either 22:00:24 s/guide/programming style./ 22:00:26 <|amethyst> reaverb: it was a response to 8418 22:00:35 <|amethyst> tool/tile.cc:126:23: warning: '&&' within '||' [-Wlogical-op-parentheses] 22:01:22 <|amethyst> what would be nice is to check whether the indentation implies something other than the actual precedence 22:01:26 -!- DickDiaper has quit [Quit: leaving] 22:01:38 Wow, our programming style causing a compile warining? Heh. 22:01:49 the problem with stuff like plague shambler melee is that it is extremely unlikely that the effect will actually do something... but those occasional times when it does (usually because the player didn't know what the effect did) it feels really bad 22:02:18 -!- turde has quit [Ping timeout: 240 seconds] 22:02:21 it would be a bit better if plague shamblers were actually at all dangerous on their own, but then they would just turn into a "do not melee this" monster 22:02:24 <|amethyst> reaverb: -Wlogical-op-parentheses means "force me to fully parenthesise any expression that mixes && and ||" 22:02:33 -!- wheals has joined ##crawl-dev 22:02:39 elliptic: Maybe zymes should make you retch? 22:02:44 heh 22:02:51 <|amethyst> -Warithmetic-op-parentheses 22:02:53 |amethyst: Yes, that makes a lot of sense to have a warining whihc does that. 22:02:58 -!- ystael has quit [Ping timeout: 240 seconds] 22:03:01 <|amethyst> reaverb: yes, but it's not a default 22:03:02 -!- CKyle has joined ##crawl-dev 22:03:23 <|amethyst> anyway, our coding style doesn't say "don't parenthesise these" 22:03:42 <|amethyst> but it doesn't require full parenthesisation anyway 22:05:05 -!- MgDark_MiBe has quit [Quit: ChatZilla 0.9.90.1 [Firefox 27.0/20131216183647]] 22:05:07 <|amethyst> ... || ((x < (m_width - 1)) && (flags[(x+1) + (y * m_width)])) 22:05:47 <|amethyst> s/ anyway/ either/ 22:05:53 elliptic: give them death drake breath 22:06:02 or 'plagueball' 22:06:12 -!- FeksClaus has quit [Quit: Leaving] 22:06:50 idk what plagueball would be but it sounds really bad! 22:07:25 if it's of any comfort, i don't have an opinion on coding style, i'm just noting warnings that someone might care about 22:07:42 |amethyst: those 6 instances are the only ones that trigger the warning, so i didn't have any others to note 22:07:54 feel free to wontfix! 22:07:54 <|amethyst> floatingatoll: those aren't even in crawl itself 22:08:01 the tile stuff isn't part of crawl? 22:08:05 <|amethyst> floatingatoll: there is plenty of stuff in crawl proper that would trigger those warnings 22:08:18 <|amethyst> floatingatoll: rltiles/tool/ is part of the build chain 22:08:22 * floatingatoll winces 22:08:23 i'm sorry 22:08:31 <|amethyst> floatingatoll: it is part of crawl in that sense 22:08:37 <|amethyst> floatingatoll: (it's not third-party) 22:08:40 yeah, but that's not what i meant to be filing about 22:08:55 this was meant to be crawl only 22:09:04 and actual warnings, not just randomness. 22:09:09 <|amethyst> floatingatoll: I mean, you probably *should* see hundreds of those warnings 22:09:17 <|amethyst> floatingatoll: if you compile crawl itself with that flag 22:09:20 sure, i have no idea why the -W flags are applied differently 22:09:22 i didn't enable it myself 22:09:30 scan-build make APPLE_GCC=y NO_PKGCONFIG=y CONTRIB_SDL=y TILES=y CFLAGS='-I/usr/include/c++/4.2.1' FULLDEBUG=YesPlease DEBUG=YesPlease NOOPTIMIZE=YesPlease 22:09:41 presumably this is triggering some -W in one place and not the other 22:09:58 -!- DarthXaos has quit [Ping timeout: 252 seconds] 22:10:06 <|amethyst> floatingatoll: they're potentially two different compilers 22:10:27 <|amethyst> floatingatoll: since rltiles/tool/ is built for the host but crawl for the target 22:10:52 <|amethyst> floatingatoll: not sure about the details of that on Mac, but at the very least there is a difference when you do universal builds 22:11:01 oh! that explains another line i saw and didn't understand. 22:11:10 yeah, so, it's using clang for the tiles stuff. 22:11:18 * floatingatoll resists the temptation to try clang on crawl itself 22:11:35 <|amethyst> I thought your static analysis stuff was from clang? 22:11:37 floatingatoll: Do it! Do it! 22:11:44 <|amethyst> Crawl should compile with clang 22:11:44 -!- Kellhus has quit [Quit: Page closed] 22:11:47 clang is somehow interpreting the output of gcc 22:11:51 i don't pretend to understand 22:11:53 <|amethyst> I don't know how recently that's been tested though 22:12:00 if you're on a mac 22:12:03 well uh 22:12:07 type "gcc" 22:12:10 on the command line 22:12:13 and I think things will become clearer 22:12:37 yeah, but APPLE_GCC=y which means who knows what in crawl terms 22:12:39 -!- CKyle has quit [Quit: CKyle] 22:12:55 and iirc the makefile hard-codes the path to /Applications/Xcode.app which makes it fail with developer previews 22:13:30 no that's not what I'm talking about 22:13:31 did you do what I said 22:13:31 and type gcc 22:13:33 Apple LLVM 5.1 (clang-503.0.40), more or less as expected 22:13:53 yes. afaik gcc isn't involved at all, there's no interpretation of output 22:13:54 -!- gammafunk has joined ##crawl-dev 22:13:57 it's just clang aliased to gcc 22:14:04 as far as I can tell 22:14:33 Floatingatoll: The Makefile says to blame Steven Noonan 22:14:36 <|amethyst> Didn't Mac used to use llvm-gcc ? 22:14:38 PS who is Steven Noonan? 22:14:40 reaverb: heh, why 22:14:43 for what 22:14:43 <|amethyst> reaverb: neunon 22:14:56 floatingatoll: He wrote the makefile apparently. 22:14:59 o. please assume I don't know what I'm talking about 22:15:01 idk 22:15:08 <|amethyst> reaverb: he added mac support I think 22:15:09 fewer complaints now! https://dl.dropboxusercontent.com/u/7533709/scan-build-2014-04-22-194401-59437-1/index.html 22:15:10 |amethyst, as of xcode 5.0 gcc is gone and the old llvm-gcc is now a wrapper for clang 22:15:16 mac build works great, btw 22:17:26 -!- mizu_no_oto has quit [Quit: Computer has gone to sleep.] 22:17:59 -!- Krakhan has quit [] 22:18:07 -!- tcsc has quit [Quit: bye!] 22:18:08 -!- qoala has joined ##crawl-dev 22:18:18 -!- HDA has quit [Ping timeout: 240 seconds] 22:18:42 -!- Thalfon has quit [] 22:18:47 -!- nrook has joined ##crawl-dev 22:20:32 this warning in mon-death.cc seems to indicate that holy kills are not, as indicated, noticed. http://bit.ly/1jIvHFZ 22:21:15 but i can't tell how this notice variable is working at all. 22:21:37 floatingatoll: Maybe the functionality is all in the side effects? 22:21:50 hmm. 22:22:10 that was one theory. if that's the case, then is this assignment relevant? 22:22:19 * floatingatoll checks the past 22:22:21 flatinatoll: yes, the functionality is in the side effects. 22:22:28 <|amethyst> notice isn't used at all 22:22:33 PS you nick is really hard to spell. 22:22:40 atoll is fine 22:22:55 Thanks atoll 22:23:00 Refrig is not often used, right? 22:23:06 Doesn't ping you, can't tell if you think of that as good or bad. 22:23:14 Basil: correct it's not used much. 22:23:20 Maybe for mummies. 22:23:42 <|amethyst> it was nerfed recently 22:24:01 okay, found it 22:24:07 It wakes dudes up now 22:24:11 Or was there another nerf? 22:24:13 <|amethyst> yeah 22:24:14 f2ed529e6b removed the Vehumet code that cared about 'notice' values 22:24:15 <|amethyst> %git 6232120 22:24:15 07MarvinPA02 * 0.14-a0-295-g6232120: Fix OTR and Ozo's Refrigeration not turning allies hostile 10(6 months ago, 1 file, 3+ 0-) 13http://s-z.org/neil/git/?p=crawl.git;a=commitdiff;h=62321204ccf9 22:24:26 and no other code seems to care 22:24:34 -!- agolden has quit [Quit: agolden] 22:24:39 %git f2ed529e6b 22:24:40 07MarvinPA02 * 0.11-a0-2235-gf2ed529: Make Vehumet accept demon and holy kills, don't accept ally kills 10(2 years, 1 month ago, 3 files, 8+ 23-) 13http://s-z.org/neil/git/?p=crawl.git;a=commitdiff;h=f2ed529e6b31 22:24:54 -!- lobf has joined ##crawl-dev 22:25:03 Hmm, That function 1500 lines long? 22:25:08 yes 22:25:30 and through two renames 22:25:43 -!- CKyle has joined ##crawl-dev 22:26:03 i could patch to remove all of the notice assignments, since it seems unnecessary to be tracking it now. 22:26:04 Good exciting function 22:26:12 <|amethyst> floatingatoll: working on it 22:26:13 checked back as far as 2009 and nothing else cared 22:26:17 oh, okay, have fun amethyst :) 22:26:45 Hmm… I should probably be sleeping but this channel is so active right now1 22:26:58 First time replacing a ! with a 1 22:27:19 1learn add 22:27:22 item_use.cc assigns item_slot = -1 in two places before immediately returning. http://bit.ly/1idOw7h 22:27:23 1le-- 22:27:26 !abyss Basil 22:27:27 Grunt casts a spell. Basil is devoured by a tear in reality! 22:27:38 -!- Fhqwhgads_ has quit [Remote host closed the connection] 22:27:41 is the second place supposed to care that the first place might have already assigned -1? 22:27:55 1abyss grunt 22:28:11 1nerf wheals 22:28:22 * floatingatoll can't tell if this is action-at-a-distance, legacy cruft, or failing to pass the selected weapon into .. something 22:29:08 <|amethyst> floatingatoll: I think the second one was likely moved, probably fairly recently 22:29:18 that's my change i think 22:29:56 i refactored the code and i guess left that in without it needing to be there 22:30:05 that code seems to have appeared, fully formed, in 6dfddf1c4dda 22:30:14 in case it helps any 22:30:23 %git 6a44e583 22:30:23 07wheals02 * 0.14-a0-2882-g6a44e58: Allow the player to choose a weapon when reading an enchant weapon scroll. 10(8 weeks ago, 5 files, 82+ 54-) 13http://s-z.org/neil/git/?p=crawl.git;a=commitdiff;h=6a44e583e1c9 22:30:26 ohai 22:30:34 it's you! 22:30:40 uh-oh 22:30:46 oh i guess i didn't edit that part after all 22:30:48 wheals: take cover!!! The code refactoring squad is here to get you!!! 22:30:50 <_< 22:31:02 * floatingatoll cares not for refactoring :) 22:31:05 ??incursion 22:31:05 incursion[1/3]: Interesting roguelike that has D&D-style character feats. http://www.incursion-roguelike.net/ 22:31:09 ??incursion[$ 22:31:09 incursion[3/3]: that seems like the simplest way to manage an inventory 22:31:31 at least, not this year. not good enough at this codebase to make sensible chocies 22:31:39 I like refactoring! 22:31:46 floatingatoll: flip a coin 22:31:49 edge 22:31:50 It's like solving a puzzle, except if you get it wrong nobody cares. 22:32:03 edge is delete 22:32:09 warnings resolved 22:32:11 ggdG 22:32:14 <|amethyst> reaverb: depends on how wrong you get it :) 22:32:36 |amethyst: Compile testing! (and eventually Unit Testing!) 22:33:21 wheals: would you like a ticket for that? 22:34:04 -!- Wahaha has quit [] 22:35:04 hm 22:35:22 i guess item_slot is overwritten by the prompt_invent_item call immediately 22:35:23 -!- Mad_Wack has quit [Quit: My MacBook Pro has gone to sleep. ZZZzzz…] 22:35:57 no reason for the other item_slot = -1 to exist either, then? 22:36:10 * floatingatoll defers to (flip a coin) reaverb 22:36:16 reaverb: you win the flip! 22:36:19 !rng heads tails 22:36:19 The RNG chooses: heads. 22:36:24 ooh. 22:36:25 ... Heads. 22:36:29 -!- Sikorkyl has quit [Client Quit] 22:36:31 i couldn't find any reason for the second -1, though 22:36:58 * reaverb does not understand the thing with coinflips. 22:39:08 -!- Arkaniad|Laptop has quit [Remote host closed the connection] 22:39:30 <|amethyst> wheals: the first one doesn't even do anything 22:39:38 <|amethyst> wheals: since it's inside if (item_slot == PROMPT_ABORT) 22:39:47 <|amethyst> wheals: and guess what the numeric value of PROMPT_ABORT is 22:39:52 hahaha 22:40:01 -!- Lasty has quit [Read error: Connection reset by peer] 22:40:03 0! 22:40:51 There has to be an automated tool to find these things. 22:40:55 * floatingatoll smiles 22:41:27 <|amethyst> reaverb: that's what floatingatoll is doing, looking for dead assignments and possible null dereferences with clang's static analysis 22:41:31 o/` i am the very model of an analyzer general / i wander through your code base finding switch errors ephemeral o/` 22:41:40 <|amethyst> though that wouldn't catch this first one probably 22:41:46 indeed, it did not 22:41:48 <|amethyst> err 22:41:58 i've run into a couple things it could catch if i knew how to *write* analyzers 22:42:00 <|amethyst> though it should, since it is a dead assignment 22:42:00 -!- kekekela has quit [Quit: Page closed] 22:42:13 <|amethyst> but it wouldn't catch the "it's already -1 here" thing 22:42:20 |amethyst: I mean the more general silliness in the codebase. I mean, there has to be a some program out there which can turn switch statements into static classes at least. 22:42:51 or at least a vim :map 22:43:06 <|amethyst> reaverb: well, remember that in C++ if you want polymorphism you need to use pointers or references 22:43:18 03wheals02 07* 0.15-a0-205-g577fbdc: Remove some unused assignments (floatingatoll). 10(4 minutes ago, 1 file, 0+ 4-) 13http://s-z.org/neil/git/?p=crawl.git;a=commitdiff;h=577fbdc5c3c9 22:43:21 <|amethyst> reaverb: which is not always straightforward 22:43:40 <|amethyst> inheritance polymorphism that is 22:44:31 |amethyst: I meant as a intermeditary form, but yes the referance thing is always a little inconviencent. 22:46:46 <|amethyst> reaverb: if we do something about old macs so we can drop gcc 4.2 support, we could at least upgrade some of our enums to enum classes 22:47:25 <|amethyst> (also, move monster from chei to sizzell so it isn't running on a machine with an ancient compiler) 22:47:39 have the floating monster problems been resolved? 22:47:42 %git 2cc1fcd4c 22:47:42 07Matthew_Cline02 * 0.5-a0-1396-g2cc1fcd: Some more attempts to prevent/catch/diagnose floating monster problems. Among other things: 10(5 years ago, 5 files, 86+ 9-) 13http://s-z.org/neil/git/?p=crawl.git;a=commitdiff;h=2cc1fcd4c229 22:48:01 i hope they have by now 22:48:15 !source bogosity 22:48:17 <|amethyst> I don't think I've seen those errors 22:48:18 Couldn't find bogosity in the Crawl source tree 22:48:19 that patch carried through to mon-act.cc and is emitting some vague warnings 22:48:25 files.cc: save_ghost() do_diagnostics redefined twice when BONES_DIAGNOSTIC and WIZARD by floatingatoll 22:48:43 DEBUG_MONS_SCAN, which was missed in the great mons->monster rename of 2011 22:49:35 -!- Arkaniad|Laptop has quit [Client Quit] 22:49:36 -!- P_R_Deltoid has quit [Read error: Connection reset by peer] 22:49:47 -!- wheals has quit [Quit: Leaving] 22:50:11 * floatingatoll ignores it 22:50:30 finalAnswer in mon-cast.cc is terrifying 22:51:00 by the time the draco_breath logic kicks in, it isn't even attended to any longer 22:51:01 floatingatoll: it used to be even worse! 22:51:16 <|amethyst> floatingatoll: I fail to see how your patch at 8419 avoids the warning 22:51:30 <|amethyst> floatingatoll: doesn't it still have an assignment immediately after initialization? 22:51:43 |amethyst: yes, but not *two* assignments immediately after initialization 22:51:58 clang isn't warning me about 'type var = default; #ifdef \n var = new; #endif' 22:52:26 i defer to y'all if it matters 22:52:56 since the list of debug flags to activate the double assignment is high and the runtime cost is basically zero 22:53:01 -!- Pisano has quit [] 22:53:10 <|amethyst> yeah 22:53:19 <|amethyst> I wouldn't worry about changing things solely to shut up the analyzer 22:53:20 no offense taken by marking anything i file as "refuse to fix" :) 22:53:25 <|amethyst> but only when it reveals an actual bug 22:53:29 * floatingatoll tries to use judgement but there will be failures 22:53:53 !source mon-cast.cc 22:53:53 http://s-z.org/neil/git/?p=crawl.git;a=blob;f=crawl-ref/source/mon-cast.cc;hb=HEAD 22:54:09 line 3216 has a 'finalAnswer = true', but it's far too late in that function to care about finalAnswer anymore 22:54:17 is that a problem? 22:54:38 it feels like it's missing a 'if (finalAnswer == true)' but i can't be sure 22:54:45 wrapping the entire draco_breath segment 22:55:29 |amethyst: Could I do someth linke #ifndef APPLE_GCC ? I think I might know a way to shut down a bunch of warnings on mac if I can. 22:55:32 <|amethyst> floatingatoll: that would mean they only do breath as a fallback 22:56:36 i imagine something used to follow that cared about finalAnswer, or it makes sense to retain it for sanity later on 22:56:40 ok 22:56:50 <|amethyst> reaverb: are they actually Mac-specific? 22:56:51 it does read like a very carefully constructed fallback. those are a lot of conditions. 22:57:31 !source tilesdl.cc 22:57:32 http://s-z.org/neil/git/?p=crawl.git;a=blob;f=crawl-ref/source/tilesdl.cc;hb=HEAD 22:57:42 should there be an 'else' at line 985, since message_overlay is defined? 22:57:47 |amethyst: I believe so. it's in libutil.cc, and the compiler claims that a function was already declared in Apple's library. 22:58:15 on almost every single file in Crawl's source code, even the one which don't use the function. 22:58:28 reaverb: to use the analyzer, i had to add #ifndef nullptr and also #ifndef LIBCPP_MEMORY around line 407 22:58:29 <|amethyst> reaverb: probably you'd want to use some macro that identifies the libc in use 22:58:46 the first one is at line 29, in AppHdr.h 22:59:09 that silenced a huge pile of warnings and redefine conflicts and template argument complaints and let me proceed 22:59:13 how hard would it be to make a cartesian plane in crawl? 22:59:13 |amethyst: Maybe but I have zero idea how to do that. (macro in makefile?) 22:59:39 reaverb: http://atoll.pastebin.mozilla.org/4912119 22:59:43 <|amethyst> dudearm: Crawl is set in a cartesian plane, or am I misunderstanding what you mean? 22:59:55 * floatingatoll folds a piece of grid paper, stamps DONE on the wings, throws it 23:00:26 atoll: I'm not quite sure what you mean about the "analyzer", but I'll try that patch. 23:00:29 |amethyst Cartesian planes...uhh when you hit one edge, you return to the other. 23:00:35 reaverb: 'clange static analyzer' 23:00:43 clang. wow, tired. 23:00:44 fakes being endless, but isn't. 23:00:46 <|amethyst> dudearm: you mean a torus 23:01:14 it appears to care deeply about template conflicts between AppHdr.h and system library defines 23:01:25 so that is my local patch to keep it quiet 23:01:27 <|amethyst> dudearm: Just having you jump at the edge isn't a problem 23:01:39 atoll: Is there a quick way to apply a patch on pastebin? 23:01:40 <|amethyst> dudearm: but making it seamless would be kind of a pain 23:01:44 hm, yes 23:01:44 sec 23:01:53 |amethyst yea seamless is what I meant. 23:01:53 <|amethyst> dudearm: you'd probably need to duplicate stuff and recenter when you get close to the edge 23:02:03 curl 'https://atoll.pastebin.mozilla.org/?dl=4912119' | git apply 23:02:10 But the Abyss use to be like that, didn't it? 23:02:17 -!- Mandevil has quit [Quit: leaving] 23:02:25 <|amethyst> dudearm: kind of like what the abyss does, except instead of generating new stuff randomly you'd move it from the place that is about to fall off the map 23:03:05 atoll: I keep getting at "corrupt patch at line 29" error. 23:03:11 ugh. 23:03:14 What about a reverse branch? like branch: 5 is the highest and branch:1 is the lowest? 23:03:33 https://dl.dropboxusercontent.com/u/7533709/AppHdr.patch 23:04:59 -!- MiraclePrism has quit [Ping timeout: 276 seconds] 23:05:00 okay, the rest are irrelevant and so i'm down to the 3 melee_attack null pointer warnings. 23:05:18 -!- KurzedMetal has quit [Ping timeout: 265 seconds] 23:05:23 <|amethyst> dudearm: not currently supported, but it could be done with enough code 23:05:41 -!- ussdefiant has joined ##crawl-dev 23:05:44 first one. melee_attack::handle_phase_attempted(); defender false, attacker->is_player false, jumping_attack true 23:05:48 sounds like you could get some fun bugs 23:06:09 probably it would be easiest to just cheat and call floor 1 floor 5 23:06:59 what's mprf()? 23:07:20 <|amethyst> floatingatoll: like printf but it goes to crawl's message area 23:07:36 <|amethyst> or, like mpr with sprintf built-in 23:07:42 okay. is it possible for a monster to jump attack without a defender? 23:07:56 floatingatoll: it shouldn't be 23:08:03 <|amethyst> I don't think it's currently possible for a monster to jump attack 23:08:12 but i can imagine it happening in some edge case 23:08:31 hey, for my 'pacification messages are like new hex messages' shelf, should I try and make the categories equivalent to the probabilities of the new hex messages categories? 23:08:32 because I can do that 23:08:33 oh right, jumping spiders don't actually jump 23:08:33 |amethyst Just a branch idea I had: 5 is the highest, branch is full of enemies with knock back and 'holes' (which function like shaft traps, but are larger (like pools of water) and don't close. 23:08:35 hmm 23:08:55 can a *player* jump attack without a defender? 23:08:55 dudearm: sounds awful lol 23:08:57 for crawl at least 23:09:17 -!- nosrepemos has quit [Ping timeout: 264 seconds] 23:09:20 <|amethyst> floatingatoll: not without a defender initially existing, but I'm not sure about what sitations might change defender 23:09:37 heh. 23:09:48 dudearm: i get what you're going for, but getting shafted into a floor you already cleared is just annoying, rather than dangerous 23:09:57 -!- DrinkMachine has joined ##crawl-dev 23:09:57 -!- DrinkMachine has quit [Changing host] 23:09:57 -!- DrinkMachine has joined ##crawl-dev 23:10:04 the reason shaft traps are great is because they dump you into danger 23:10:14 excitement! the unknown! 23:10:21 rupert and six skeletal warriors! 23:10:37 ?/shouts loudly 23:10:38 Matching entries (1): chaos_brand[12]: You hit the goblin. You fall down a shaft! Your mindless thralls stay behind. 12 skeletal warriors and Rupert come into view. Your giant spiked club of chaos shouts loudly! 23:10:45 Could be worse! 23:10:53 haha, I misremembered the number 23:11:02 okay. well, if it happens, null-pointer dereference in mprf(), which means a guaranteed crash 23:11:07 at least it'll be immediately apparent where the issue is 23:11:14 * floatingatoll smiles, moves on 23:12:21 -!- ToastyP has quit [Quit: ChatZilla 0.9.90.1 [Firefox 28.0/20140314220517]] 23:13:18 <|amethyst> an assert might be better though, so that we know where the error happened even if it's a windows user that crashes (no stack trace) 23:13:29 -!- GLMachine has quit [Ping timeout: 264 seconds] 23:13:41 yeah asserts beat null references 23:13:48 03Sage02 07* 0.15-a0-206-g2c29f1d: Change Ozocubu's Refrigeration. 10(28 minutes ago, 10 files, 30+ 6-) 13http://s-z.org/neil/git/?p=crawl.git;a=commitdiff;h=2c29f1d7c6e1 23:13:51 Fan of gales does not blow away clouds you are standing in. by RedBucket 23:13:51 fr: replace all traps with shaft traps 23:13:57 heh! 23:14:15 okay. 23:14:18 -!- blueDave has quit [Ping timeout: 240 seconds] 23:14:44 -!- Feles has quit [Remote host closed the connection] 23:14:59 ooo, that ozo's change 23:15:22 |amethyst what if made it a constant spawning branch like Abyss or hell then (can't be cleared). 23:16:05 -!- TAS_2012v has quit [Read error: Connection reset by peer] 23:16:12 <|amethyst> dudearm: it wasn't me that raised that objection, but I don't think that helps a lot 23:16:48 <|amethyst> dudearm: since it will still probably be less populated than the level you fell from 23:17:00 -!- CKyle has quit [Quit: CKyle] 23:17:02 -!- demiskeleton has quit [Read error: Connection reset by peer] 23:17:15 <|amethyst> dudearm: also, infinite sources of XP are probably not something that we need more of 23:17:26 -!- CKyle has joined ##crawl-dev 23:17:28 okay, so, three ASSERT(defender); then 23:17:40 as best as i can figure these *ought* to be unreachable through *normal* play 23:18:16 -!- DrinkMachine has quit [Quit: Leaving] 23:18:57 -!- yogidabear has quit [Quit: Page closed] 23:19:22 -!- agolden has quit [Client Quit] 23:19:31 floatingatoll: we've had numerous bugs arise from stuff dying/vanishing in the middle of attack resolution, so better safe than sorry 23:19:46 oh! 23:19:49 ...that reminds me, did anyone ever fix the invisible hydra bug 23:20:15 <|amethyst> ontoclasm: a few times :/ 23:20:21 hah 23:20:35 <|amethyst> well, dying in the middle of the attack doesn't change the pointer to null 23:20:43 What's this invsible hydra bug? 23:20:46 and apparently monsters can't jump at all 23:20:49 er, jump attack? 23:20:50 i guess? 23:21:12 atoll: Jumping Spiders at least fake. There's lots of monster-player asymmertry for no particular reason. 23:21:22 so it goes 23:21:24 do jumping spiders predate jump attack? I guess not 23:21:29 Also a lot of asymerty for very good reasons, but a lot is really werid. 23:21:44 PleasingFungus: No, jumping spiders predate jump attack. 23:21:53 reaverb: something to do with having a flaming spectral weapon chop a hydra's last head 23:22:01 huh. were they in the old spider portal? 23:22:03 <|amethyst> PleasingFungus: yes, they do, as do blue devils' swoop attack 23:22:16 <|amethyst> s/do/does/ 23:22:19 <|amethyst> err 23:22:20 you got (get?) a living hydra that is invisible and sort of dead 23:22:23 <|amethyst> the second one 23:22:24 I thought spider was more recent than felids... 23:22:31 it is 23:22:35 I think 23:22:36 ontolclasm: That sounds just obscure enough to be completely maddening. 23:22:40 felids got jump very recently 23:22:51 felids didn't have jump attack since felids also predate jump attack 23:23:03 jump attack is really really recent 23:23:10 like 2013 recent 23:23:15 0.14 recent. IIRC. 23:23:21 reaverb: i haven't checked it since i was playing the hask that discovered it 23:23:23 ahhh 23:23:23 !source changelog.txt 23:23:23 http://s-z.org/neil/git/?p=crawl.git;a=blob;f=crawl-ref/source/changelog.txt;hb=HEAD 23:23:32 <|amethyst> %git c80f2be 23:23:32 07gammafunk02 {|amethyst} * 0.14-a0-84-gc80f2be: Evokable Jump attack ability 10(10 months ago, 36 files, 922+ 203-) 13http://s-z.org/neil/git/?p=crawl.git;a=commitdiff;h=c80f2bed60bc 23:23:48 Yeah, that was gammafunk's first contribution. 23:23:56 if you have berserkitis, can it trigger off a jump attack 23:23:57 huh, used to be evocations-based range 23:23:57 I tried to help but failed miserably. 23:24:03 -!- dtsund has joined ##crawl-dev 23:24:13 to laugh at your exh antizerk tactics 23:24:18 melee_attack.cc: qty.3 of ASSERT(defender); to defend against static analysis null-pointer derefs by floatingatoll 23:24:18 haha 'self-electrocution'. I wonder if that code was removed with electrocution? 23:24:59 03|amethyst02 07* 0.15-a0-207-g67f9d04: Simplify. 10(2 hours ago, 1 file, 16+ 20-) 13http://s-z.org/neil/git/?p=crawl.git;a=commitdiff;h=67f9d0461c7b 23:24:59 03|amethyst02 07* 0.15-a0-208-g7a2063a: Avoid a theoretical divide by zero (floatingatoll, #8415) 10(2 hours ago, 1 file, 4+ 1-) 13http://s-z.org/neil/git/?p=crawl.git;a=commitdiff;h=7a2063a1c841 23:24:59 03|amethyst02 07* 0.15-a0-209-g940360b: Add argument check for check_your_resists (floatingatoll, #8416) 10(2 hours ago, 1 file, 2+ 0-) 13http://s-z.org/neil/git/?p=crawl.git;a=commitdiff;h=940360b8b1c0 23:24:59 03|amethyst02 07* 0.15-a0-210-gb09f9d7: Remove an unused variable (floatingatoll). 10(53 minutes ago, 1 file, 45+ 46-) 13http://s-z.org/neil/git/?p=crawl.git;a=commitdiff;h=b09f9d74bf7d 23:25:47 -!- CKyle has quit [Ping timeout: 276 seconds] 23:26:07 -!- lessens has quit [Ping timeout: 252 seconds] 23:26:32 is anyone here on 10.7? 23:26:51 (just curious what xcode-select -p emits) 23:27:03 I'm on 10.6 - probably the closest to Mountain Lion. 23:27:10 do you even have an xcode-select? 23:27:17 Might want to check out ##mac although they are a bit fanboyish. 23:27:33 atoll: No clue what that is, Apple will not let me have Xcode 4 on 10.6 23:27:41 .. okay 23:28:01 * floatingatoll rewrites 23:28:13 atoll: What, is xcode-select something really widely used I should know about? 23:28:16 no 23:28:24 i'm poking at the Makefile and was curious which path to take 23:28:31 the harder but ultimately safer path, it turns out 23:29:01 -!- UncertainKitten has joined ##crawl-dev 23:29:01 Yes, this is why we haven't moved to C++11 yes, silly Apple. 23:29:21 wait, I just realized 23:29:25 I might be trying to do something that's not possible in C++... 23:29:32 C++ doesn't have lambdas/closures/anonymous functions, right? 23:29:40 C++11 does : ) 23:29:45 <|amethyst> C++11 does but we can't use C++11 yet 23:29:46 Crawl C++ does not. 23:30:05 oh snap, ok 23:30:24 Patashu: Maybe try function pointers? 23:30:30 <|amethyst> however, you can often simulate them with classes 23:30:32 yeah, I think I can do it with a function pointer still 23:30:42 <|amethyst> yeah, or function pointers if you don't need closure 23:30:43 Not as elegant but yeah. 23:31:22 how do I say, 'this argument is a function that takes an int and returns a vector of ints' 23:31:25 in C++ 23:31:32 -!- bzn has quit [Quit: Page closed] 23:32:31 function foo 23:32:44 (C++ doesn't enforce arguments and outputs) 23:32:52 augh 23:33:23 <|amethyst> huh? 23:35:42 Patashu: You can enforce outputs/inputs for the pointers themselves though. 23:35:43 <|amethyst> std::function is C++11 isn't it? 23:35:56 <|amethyst> and is a template 23:36:22 I want to say like this: float probability(int x, int y, function_that_takes_int_and_returns_vector_of_ints callback) 23:36:31 what do I put for function_that_takes_int_and_returns_vector_of_ints ? 23:36:44 |amethyst: It is C++11 23:37:27 Patashu: function name_of_function_pointer 23:38:26 -!- Basil has quit [Ping timeout: 240 seconds] 23:38:46 -!- Basil__ has joined ##crawl-dev 23:39:30 -!- _aardvark has quit [] 23:39:52 <|amethyst> reaverb: doesn't that give a "missing template arguments" error? 23:40:31 |amethyst: I'm just looking at documentionat and tutorials - I haven't actually tried this. 23:40:47 http://www.cprogramming.com/tutorial/function-pointers.html 23:41:09 Oh, uh, looks like that psuedo code. 23:41:16 Which is really misleading. 23:41:18 <|amethyst> yeah 23:41:35 <|amethyst> you want vector (*callback)(int) 23:41:59 Patashu: Yes, |amethyst is right. 23:42:08 thanks 23:42:17 Sorry for messing that up. 23:42:43 <|amethyst> the C++11 way would be function(int)> callback 23:43:20 okay, the xcode patch is my last for tonight 23:44:03 thanks for all the help following along with these! 23:44:33 atoll: Any time - you're helping us! 23:44:48 -!- wheals has joined ##crawl-dev 23:44:56 i ended up with only one remaining question, about message_y_divider 23:44:58 Well any time we're online. Which is most of the time. 23:45:01 https://dl.dropboxusercontent.com/u/7533709/scan-build-2014-04-22-194401-59437-1/report-8c0970.html#EndPath 23:45:13 983-984 are irrelevant entirely 23:45:18 Makefile doesn't understand Xcode developer previews by floatingatoll 23:45:25 the value is overwritten later on without being read first 23:45:29 is the comment still accurate? 23:45:46 -!- Nethris has quit [Quit: Leaving.] 23:45:49 -!- rebthor has quit [Quit: ChatZilla 0.9.90.1 [Firefox 28.0/20140314220517]] 23:47:58 -!- sinusoidal has quit [Quit: Page closed] 23:48:11 <|amethyst> I think this is a case where removing the dead assignment makes the code more fragile 23:48:40 * floatingatoll nods 23:48:45 atoll: I think those overrides still do basically what the dead assignment does. the one in the else block is exactly the same. 23:48:56 |amethyst: what do you mean by more fragile? 23:49:13 -!- rast has quit [Read error: Connection reset by peer] 23:49:35 -!- rast has joined ##crawl-dev 23:49:39 <|amethyst> reaverb: if one of those ifs is changed to not set message_y_divider in some case (say, if that last else on line 1021 became an else if (blah)) 23:49:54 <|amethyst> reaverb: then message_y_divider would no longer have a sane value 23:50:47 i jsut now on my fourth read of it found the !message_overlay in the long if clause 23:51:09 so, yeah, if it's a sane default, ++ to leaving it 23:51:13 just making sure it's working as intended 23:52:21 |amethyst: I think that fact speaks to more general code problems (No unit tests to ensure this won't happen, lack of clarity in design which would make it obvious message_y_divider must be set) but leaving it for now is acceptable. 23:52:43 which is why that statement struck me as odd at first. 23:53:30 <|amethyst> lack of anyone active who knows the local tiles code... 23:53:36 Heh. 23:54:12 Yes the thought that Crawl functions on dozens of people who know or knew how tiny parts of it work is sort of terrifing/amazing. 23:55:02 -!- Eonwe7 has quit [Quit: Nettalk6 - www.ntalk.de] 23:57:05 :) 23:57:19 that's how i approach all of this tidying work anyways 23:57:23 That's largely true of any sufficiently large project, isn't it? 23:57:24 seems to help! 23:57:28 be well, all 23:57:38 Grunt: Yes, even outside of programming. 23:57:43 I do know bits and pieces of the local tile code, mainly from back when I added the abilities menu. 23:58:00 (And also my abortive attempts to start on an SDL2 port.) 23:59:24 -!- hurdos1 has quit [Quit: Leaving.]