00:01:08 -!- valrus has joined ##crawl-dev 00:02:08 -!- valrus has quit [Remote host closed the connection] 00:05:22 -!- medgno has quit [Quit: Quitting] 00:10:51 crate the Phalangite (L22 MfIE) ERROR in 'melee_attack.cc' at line 945: Invalid attack flavour for noise_factor (WizLab) 00:11:23 crate the Phalangite (L22 MfIE) ERROR in 'melee_attack.cc' at line 945: Invalid attack flavour for noise_factor (WizLab) 00:11:39 crate the Phalangite (L22 MfIE) ERROR in 'melee_attack.cc' at line 945: Invalid attack flavour for noise_factor (WizLab) 00:12:14 crate the Phalangite (L22 MfIE) ASSERT(attk_type < static_cast(sizeof(attack_types) / sizeof(const char *))) in 'melee_attack.cc' at line 3856 failed on turn 93674. (WizLab) 00:14:02 this is very strange 00:14:15 evidently setting you.time_taken = 0 isn't quite the right thing to do 00:14:27 -!- Brannock has quit [Ping timeout: 258 seconds] 00:14:50 it claims to take no time now when you cancel an attack, but if you do it many times in a row then monsters will get moves occasionally 00:15:37 isn't there a thing to call that resets it 00:15:53 swear i saw that somewhere 00:16:09 eronarn: well, the issue is that previously cancelled attacks were taking 1.0 aut 00:16:21 which is obviously bad 00:17:13 elliptic: i mean that when you cancel a spell or the like, i believe there's a function that gets called - i'm not sure how aborting in the combat code is doing it 00:17:16 been a while since i looked at crawl code 00:17:26 hm, will look 00:17:51 -!- st_ has quit [Ping timeout: 248 seconds] 00:18:55 crawl_state.zero_turns_taken(); 00:18:58 will try that, thanks 00:19:08 I wish I knew why what I did didn't work, though 00:19:27 -!- Wensley has quit [Ping timeout: 248 seconds] 00:19:54 <|amethyst> hm... I don't think that will do anything wrt monsters getting turns... all it does is call cancel_cmd_repeat() 00:21:53 well it caused a crash (ASSERT(!you.turn_is_over)) so maybe that wasn't right either, yes :) 00:22:07 maybe I should actually figure out where the combat code path is setting you.turn_is_over 00:22:37 -!- SamB has quit [Ping timeout: 240 seconds] 00:23:59 <|amethyst> elliptic: you need to set cancel_attack it looks like 00:24:12 yeah, I just got there also :) 00:25:44 someone should really go through the melee code and see how many variables are never being used 00:25:56 and figure out whether they should be used 00:26:58 <|amethyst> elliptic: did_hit is set but afaict never read 00:27:22 -!- SamB has joined ##crawl-dev 00:29:12 can't you get gcc to spit that out 00:29:20 <|amethyst> attacker_to_hit_penalty is set by the initialiser and used nowhere else 00:29:21 for the trivial sense of it never being used after assignment 00:29:58 <|amethyst> probably only for locals 00:30:59 it would certainly require LTO to do for globals ... 00:31:04 <|amethyst> these are member variables, and can be accessed from distant compilation units 00:31:33 <|amethyst> what SamB said 00:32:02 members are even harder 00:32:50 I was also wondering about variables like cancel_attack used to be 00:33:19 which seems more complicated to check for 00:33:26 <|amethyst> yeah, since it is set and it is read 00:33:29 yeah 00:33:32 <|amethyst> it's just never set to anything but false 00:33:54 -!- Cryp71c has quit [Quit: Leaving] 00:33:57 I guess you could try to find variables that are only ever set to one value, in any code path 00:35:47 <|amethyst> needs_message is only ever set once, and can be easily computer from two other members: it should be a member function 00:36:06 03elliptic * r79bf8a7b81a4 10/crawl-ref/source/melee_attack.cc: Fix attack delay bugs. 00:37:05 <|amethyst> hm 00:37:35 <|amethyst> actually, I guess needs_message is slightly more complicated when you look at general attacks; only in melee attacks is it ever set to something other than false 00:39:26 !tell cryp71c Attack delay stuff is hopefully fixed :) though as always I might have accidentally clobbered something in the process... 00:39:26 elliptic: OK, I'll let cryp71c know. 00:42:19 <|amethyst> defender_{body_armour,shield}_penalty are also set but unused 00:42:25 <|amethyst> (the attacker versions are, of course) 00:42:37 <|amethyst> s/are,/are used,/ 00:44:09 not sure whether it makes sense to remove some of the unused stuff right now to make things a little less cluttered, or wait until UCC settles down a bit more 00:45:01 probably wait until it settles a bit 00:45:07 some of those maybe should be used? 00:45:18 <|amethyst> probably not the defender penalties though 00:45:49 yeah, the defender penalties aren't being used anytime soon at least 00:45:52 likely it would be best to talk about it with him ... 00:46:26 <|amethyst> unless ev calculations get moved into attack or something like that 00:48:25 <|amethyst> !tell Cryp71c The following members of attack appear to be unused: did_hit, defender_body_armour_penalty, defender_shield_penalty, and attacker_to_hit_penalty . 00:48:26 |amethyst: OK, I'll let Cryp71c know. 01:15:15 the combat stuff cryptic is working on seems awfully messy 01:46:06 03evilmike * ra84d1178d09f 10/crawl-ref/source/dat/des/branches/temple.des: Modifications to lemuel_temple_firewalk vaults. 01:48:11 -!- edlothiol has joined ##crawl-dev 01:56:24 -!- MarvinPA_ has quit [Read error: Connection reset by peer] 01:56:52 -!- MarvinPA_ has joined ##crawl-dev 02:02:25 -!- SamB_ has joined ##crawl-dev 02:02:31 -!- SamB_XP_ has joined ##crawl-dev 02:02:53 -!- SamB_XP has quit [Read error: Connection reset by peer] 02:04:37 -!- SamB has quit [Ping timeout: 240 seconds] 02:18:08 03elliptic * r775e800caf40 10/crawl-ref/source/melee_attack.cc: Remove duplicate copy of code for vampire bite-stabbing. 02:18:18 03elliptic * rd3604ebb42de 10/crawl-ref/source/melee_attack.cc: Make stabs always hit the monster. 02:19:23 yay, there might not currently be any known UCC bugs with balance impact... just messages and that crash 02:19:42 though I'm sure there are other things that are off, maybe major things 02:19:51 we just haven't found them yet 02:20:57 -!- Cryp71c has joined ##crawl-dev 02:21:00 Rar 02:21:00 Cryp71c: You have 2 messages. Use !messages to read them. 02:21:01 !messages 02:21:02 (1/2) elliptic said (1h 41m 35s ago): Attack delay stuff is hopefully fixed :) though as always I might have accidentally clobbered something in the process... 02:21:03 !messages 02:21:03 (1/1) |amethyst said (1h 32m 37s ago): The following members of attack appear to be unused: did_hit, defender_body_armour_penalty, defender_shield_penalty, and attacker_to_hit_penalty . 02:21:52 elliptic, |amethyst, thanks, I'll leave in but comment out the attacker / defender stuff if it is unused. It probably aught to remain in (at least in comment) 02:22:07 elliptic, changing anything in combat seems to have a fairly reasonable chance of clobbering something. 02:22:15 I think that's a design requirement. 02:23:12 Cryp71c: anyway I *think* the only UCC bugs that are known at the moment are stuff with messages being weird and that crash with statues 02:23:28 yeah I'll fix the statues tomorrow morning 02:27:26 -!- Cryp71c has quit [Quit: Leaving] 02:32:04 -!- SamB_XP_ has quit [Read error: Connection reset by peer] 02:32:08 -!- heteroy has quit [Quit: ChatZilla 0.9.87 [Firefox 3.6.24/20111103063747]] 02:32:15 -!- SamB__ has joined ##crawl-dev 02:32:40 -!- SamB_XP_ has joined ##crawl-dev 02:35:25 -!- SamB_ has quit [Ping timeout: 240 seconds] 02:50:23 -!- the_glow has quit [Ping timeout: 248 seconds] 02:53:44 -!- the_glow has joined ##crawl-dev 03:14:00 -!- evilmike has quit [Read error: Connection reset by peer] 03:21:15 -!- edlothiol has quit [Ping timeout: 260 seconds] 03:51:51 -!- MarvinPA_ has quit [Read error: Connection reset by peer] 03:59:36 -!- mikee_ has quit [Quit: HydraIRC -> http://www.hydrairc.com <- \o/] 04:03:04 -!- ortoslon has joined ##crawl-dev 04:05:42 -!- monqy has quit [Quit: hello] 04:08:20 -!- ortoslon has quit [Quit: bye] 04:14:13 Enslave soul power by yred resulted in hostile enemy due to unarmed extra attack (https://crawl.develz.org/mantis/view.php?id=4976) by Surr 04:27:53 -!- MarvinPA has joined ##crawl-dev 04:29:04 -!- ais523 has joined ##crawl-dev 04:42:44 -!- dtsund has quit [Quit: dtsund] 05:02:20 arrian (L13 DsAM) ASSERT(smc) in 'mon-util.cc' at line 445 failed. (Lair:8) 05:02:44 !lm arrian crash -log 05:02:45 1. arrian, XL13 DsAM, T:29610 (milestone): http://crawl.develz.org/morgues/trunk/arrian/crash-arrian-20111129-110215.txt 05:08:17 -!- absolutego has joined ##crawl-dev 05:15:20 Assert in mon-util.cc (https://crawl.develz.org/mantis/view.php?id=4977) by absolutego 05:37:20 -!- jeanjacques has joined ##crawl-dev 05:41:10 -!- ais523_ has joined ##crawl-dev 05:41:33 -!- ais523 has quit [Disconnected by services] 05:41:35 -!- ais523_ is now known as ais523 05:42:34 This is probably our Tengu? http://i.imgur.com/g0lRF.png 05:43:20 !tell due source material for Tengu: http://i.imgur.com/g0lRF.png 05:43:20 Keskitalo: OK, I'll let due know. 05:47:42 * due click. 05:47:47 HAHAHA, <3 05:47:47 due: You have 1 message. Use !messages to read it. 05:47:58 wtf 05:53:58 -!- absolutego has quit [Quit: Lost terminal] 06:33:07 -!- syllogism has joined ##crawl-dev 06:36:16 noobrobin (L19 MfEE) ASSERT(smc) in 'mon-util.cc' at line 445 failed. (Snake:4) 06:36:37 -!- MarvinPA has quit [Ping timeout: 240 seconds] 06:43:59 -!- ais523 has quit [Ping timeout: 244 seconds] 06:47:12 -!- ais523 has joined ##crawl-dev 06:50:39 -!- ais523 has quit [Excess Flood] 06:52:46 -!- ais523 has joined ##crawl-dev 06:56:56 -!- Adam__ has quit [Quit: Leaving] 07:04:39 -!- Ragdoll has joined ##crawl-dev 07:05:23 !lm noobrobin crash -log 07:09:17 -!- Sequell has quit [Ping timeout: 258 seconds] 07:09:59 -!- Sequell has joined ##crawl-dev 07:10:20 !lm noobrobin crash -log 07:10:20 1. noobrobin, XL19 MfEE, T:20925 (milestone): http://crawl.develz.org/morgues/trunk/noobrobin/crash-noobrobin-20111129-123553.txt 07:13:39 -!- edlothiol has joined ##crawl-dev 07:15:47 -!- ais523 has quit [Ping timeout: 252 seconds] 07:19:50 -!- ais523 has joined ##crawl-dev 07:26:10 -!- ais523 has quit [Ping timeout: 244 seconds] 07:35:11 -!- Cryp71c has joined ##crawl-dev 07:35:16 Morning 07:39:01 03dolorous * r113baa719323 10/crawl-ref/source/melee_attack.cc: Fix indentation. 07:54:50 How can I spawn a frost-covered statue in wizmode? Not coming up on &M 07:56:13 Look up the MONS line from the vault definitions, you should be able to enter that into &M 08:00:25 -!- MarvinPA has joined ##crawl-dev 08:02:03 thanks kesk 08:08:12 -!- valrus has joined ##crawl-dev 08:12:09 -!- Ragdoll has quit [Ping timeout: 244 seconds] 08:30:22 -!- syllogism has quit [*.net *.split] 08:34:03 any constriction feedback? 08:36:01 none that I've heard yet..people may be caught up in combat issues. 08:36:20 elliptic, let me know when you're in. 08:36:24 -!- syllogism has joined ##crawl-dev 08:37:11 @??statue 08:37:12 statue (158) | Speed: 10 | HD: 8 | Health: 70 | AC/EV: 12/1 | Damage: 20 | Flags: 11non-living | Res: 13magic(immune), 05fire++, 02cold++, 10elec++, 03poison++, 12drown, 04rot+++, 13neg+++, 13torm | XP: 561. 08:40:20 statues by themselves won't trigger that problem 08:40:26 you need the kind that have weapons 08:41:05 blueDave, hur? 08:41:16 What're you talking about? 08:41:32 thought you were looking for statues for the assert problem 08:41:43 Oh, I've got the right statue, and I know what's causing the issue. 08:42:21 *Technically* the vault doesn't use an appropriate monster, as far as I can tell. 08:42:57 I've been seeing a lot of unique stuff from vaults 08:43:07 same mechanism as the spriggan baker probably 08:43:27 git one last night with about 10 special kinds of bats 08:43:37 got 08:43:41 lol 08:46:39 elliptic, essentially whats going on is that the vault uses statue name:frost-covered to create a frost-covered statue, however if you refer to mon-data, statue's first attack is AT_WEAP_ONLY, which is reserved for ranged attacks. This eventually results in melee attack freaking out (and thus, failing assertions) since the attack flavour expects a ranged weapon. I have no idea how this would've worked pre-ucc, the areas I' 08:46:40 m working with were largely copied / pasted. 08:47:03 s/ranged attacks/ranged (weapon) attacks, which the frost-covered statue has none of. 08:48:32 -!- ais523 has joined ##crawl-dev 08:50:26 <|amethyst> Cryp71c: what previously happened was that mons_perform_attack_rounds() replaced it with one of AT_NONE, AT_SHOOT, and AT_HIT depending on what the attacker was wielding 08:50:50 |amethyst, that still happens in adjust_noise, which still fails out (AT_NONE) is still an invalid attack type. 08:53:34 Who makes a lot of vaults...trying to figure out if vehumet_statue was new or old... 08:53:43 <|amethyst> Cryp71c: ah, there was also an if (attk.type == AT_NONE) { .... break } 08:53:55 <|amethyst> Cryp71c: before the noise handling 08:54:24 |amethyst, in the pre-ucc code? 08:54:56 <|amethyst> yeah, looking at 5592907:./fight.cc line 5541 08:55:56 |amethyst, so I don't understand...these statues don't do anything... ? 08:56:10 -!- Vandal has joined ##crawl-dev 08:56:12 (that's what will happen for these vaults) 08:56:17 <|amethyst> by themselves, no. The idea is you give them spells 08:56:26 |amethyst, the vaults don't give them spells. 08:56:33 <|amethyst> or weapons, I guess 08:56:37 ohwait...yeah they do 08:56:38 <|amethyst> which vault is this? 08:56:38 :P 08:56:40 vehumet_statue 08:56:41 -!- st_ has joined ##crawl-dev 08:56:43 <|amethyst> the iskendeun one does 08:56:45 they do give spells. 08:58:10 -!- Lohen has quit [Ping timeout: 260 seconds] 08:58:36 Gah that's such an ugly special case. 08:59:33 <|amethyst> also, the AT_WEAP_ONLY -> AT_HIT/SHOOT/NONE rewriting should probably happen earlier in the attack 09:00:11 <|amethyst> right now it happens quite late, but that means mons_attack_verb will see AT_WEAP_ONLY 09:02:38 -!- valrus has quit [Remote host closed the connection] 09:06:48 There we go, fixed. 09:07:30 search on mons_statue_archer in the vault defs for examples of weapon ones 09:07:40 the frost one is supposed to be spells only 09:08:05 blueDave, yeah, weapon ones are fine since they get transformed into AT_SHOOT (or they may circumvent the melee attack code [which is good] altogether) 09:08:27 <|amethyst> yeah, deep elf master archers don't crash 09:10:04 <|amethyst> AT_WEAP_ONLY could probably be removed if you split "statue" into three monsters, one with AT_NO_ATK, one with AT_HIT, and one with AT_SHOOT 09:10:28 <|amethyst> but that causes problems with saved games 09:12:13 splitting statue into three monsters sounds bad 09:13:27 <|amethyst> and archer statues can crash if you're next to them 09:13:33 <|amethyst> ASSERT(attk_type < static_cast(sizeof(attack_types) / sizeof(const char *))) in 'melee_attack.cc' at line 3856 failed. 09:14:15 <|amethyst> likewise the melee statues 09:14:47 <|amethyst> (this because the attack type isn't rewritten until well after handle_phase_hit()) 09:16:23 WHAT! NO!!! Where's dispel undead on necromancer :( 09:16:53 damnit that was one of the best parts of early necro :( 09:17:16 It was like pour water for an FE. :D 09:18:25 <|amethyst> Cryp71c: I might have a fix, testing 09:18:36 |amethyst, I've already relocated the necessary code 09:18:41 <|amethyst> ah, okay 09:18:51 one sec 09:18:52 pushing 09:19:21 varsovie, yeah but pour water would be ice magic, dispel undead no matter how you cut it is still necromancy. 09:20:54 03Cryp71c * r6e7bdf42985a 10/crawl-ref/source/melee_attack.cc: Fix attack_type handling 09:21:15 could be hexe 09:21:52 na, that would make less sense imo..the only possible change I could see is if you created a "Life Magic" and put it in there. 09:22:04 davejl the Gusty (L2 DEAE) ASSERT(item_slot >= 0) in 'item_use.cc' at line 4872 failed on turn 711. (D:1) 09:22:27 <|amethyst> there used to be SPTYP_HOLY 09:24:31 summon and hexe, or hexe and necro. But anyway, I would prefer a "dispel bats". 09:24:33 huh? what happened to necromancer? 09:24:37 <|amethyst> Cryp71c: great, all three styles of plain statues work now 09:25:02 <|amethyst> Eronarn: dispel undead was replaced with control undead in the book of Necromancy 09:25:14 oh, that's good 09:25:16 dispel undead got moved to the book of death and spell lvl 5 09:30:36 -!- Brannock has joined ##crawl-dev 09:31:30 Spoilers in exlusions (https://crawl.develz.org/mantis/view.php?id=4978) by FatBoy 09:34:15 <|amethyst> Cryp71c: I suspect #4976 (Enslave soul power by yred resulted in hostile enemy due to unarmed extra attack) is also in your bailiwick 09:34:45 Eronarn, no! Quit encouraigng their nerfs to Ne :P 09:39:09 Unstable branch on crawl.akrasiac.org updated to: 0.10-a0-2392-g113baa7 (32) 09:40:02 Cryp71c: Ne deserves nerfing :) 09:40:19 also, now maybe someone will care enough to code 'permaenslave' effects 09:40:46 -!- Pingas has quit [Read error: Connection reset by peer] 09:40:55 Eronarn, lol, was so awesome finding player ghosts as a Ne, was like "FREE XP!" (and lots of it too!) 09:41:01 -!- Pingas has joined ##crawl-dev 09:41:55 Cryp71c: now you can enslave player ghosts and kill the entire level 09:42:04 how long is the enslave? 09:43:16 not long enough to do that, which is why i mentioned the permaenslave ;) 09:43:54 -!- alefury has joined ##crawl-dev 09:44:20 :P 09:44:28 (it's like the idea of sustaining buffs - commit some MP and the spell doesn't end) 09:45:11 I like that concept, Dragon Age style buffs. 09:45:16 Dragon Age Origins* 09:48:12 mhh, theres a wiki page for it, and there was a bit of tavern discussion 09:48:23 galehar wanted to implement it, but is busy now :( 09:48:57 alefury, lol, add it to the list of stuff that everyone wants to do at some point or another :P I'd do it, but after UCC isn't so retarded, real symmetry is up on the table next. 09:49:00 it's a tricky issue for some spells 09:49:09 s/do it/try to do it 09:49:12 if it just autorecasts, that's not so great 09:49:18 but if it's truly permanent, that has problems too 09:49:20 galehar said it probably wouldnt be that hard 09:49:27 demoing it with enslave would be a good start 09:49:36 because there, the thing will eventually die 09:49:42 the most polished idea is the one on the wiki page under "alternative implementation" or something 09:49:43 Eronarn, what problems would you see with permanent? 09:49:52 also, self affecting enchantments only 09:49:53 alefury, got a link to that wiki page? 09:49:57 no perma enslavement 09:50:26 that has issues because of mr 09:50:53 Cryp71c: power -> duration; does low power = more MP cost? does that mean losing int leads you to negative MP, or does the spell disable? how do you balance a spell if it's meh at L3 as a cast but broken at L3 as a sustain? 09:51:19 how do success rates apply? can you take off all your armor and cast and then put it back on? 09:51:39 https://crawl.develz.org/wiki/doku.php?id=dcss:brainstorm:magic:power_duration 09:51:40 Eronarn, ah, right. 09:51:58 Eronarn ever played DA:O ? 09:52:02 alternate implementation is what galehar added after some tavern discussion and thinking 09:52:12 I like its armor implications on casters as well, seems to be well balanced 09:52:23 the goal is to emulate non-permanent buffs fairly well, to avoid balance issues 09:52:51 then if the permanent version of a buff is overpowered, it was already overpowered before, and both the permanent and the non-permanent version can be nerfed 09:53:21 alefury, well, if non-permanent becomes permanent, you should only have to nerf the (new) permanent. 09:53:24 But I get what you're sayin. 09:53:44 well, both versions are supposed to be available 09:53:55 maybe this can change later 09:54:05 -!- Ragdoll has joined ##crawl-dev 09:54:06 idea is Z for permabuff 09:54:15 anyway, i think all of that is on the wiki 09:55:06 ... but Z is already used ? 09:55:35 <|amethyst> presumably this would go along with moving 'Z' to 'z' and removing the old 'z' 09:55:57 i really don't like galehar's proposal there 09:56:26 i preferred the one above on the page, where if your success rate dropped below a threshold, it only then started to expire 09:56:33 SamB_: Z is unused for self enchantments 09:56:56 or rather, it is currently the same as z 09:57:01 -!- SamB__ is now known as SamB 09:57:30 also, MP regen isn't displayed to the user 09:57:38 Eronarn: the idea behind that proposal is to be as close to the status quo as possible while removing the tedium 09:57:44 tome has that, and it works well there, but this isn't tome 09:58:24 telling the player that MP regen is reduced can be handled with messages 09:58:26 alefury: i don't think the status quo is something to be emulated 09:59:09 it works, and departure from the current way buffs work would mean the old way would have to go. this is a lot more controversial than just automating the recasts. 09:59:32 also... i'd rather see a higher permanent MP cost, and no explicit MP regen cost 09:59:37 nothing wrong with changing the system, but it may be hard to convince people, and i dont see whats wrong with current buffs 09:59:42 there's an implicit MP regen cost because your MP regen rate depends on your MP 10:00:30 maybe add that as a comment, because mp regen being based on the unmodified max mp isnt mentioned in the proposal 10:00:52 and its easy to miss for someone implementing it 10:01:08 Eronarn, you could not reduce maxMP, but instead "grey-out" the bar that cannot be regen'd and code in a soft cap. 10:01:46 alefury: also keep in mind... actually doing the recast at some point means you might try and cast while paralyzed, or while -int, or etc. 10:02:09 it feels like god wrath timers all over again 10:02:32 having it be based on success rate changes lets it be continuous 10:02:56 yeah, but its also harder to justify, because it does more than remove tedium 10:03:34 hmm... You have quaffed a potion of experience. Select the skills to train. 10:03:38 how do I select it? 10:03:46 adding autorecast to autoexplore, autotravel and autofight is something few people would object to 10:03:54 there should be a skill menu 10:03:55 when i press the letter in front of the skill it just switched none/train/focus 10:04:08 yes 10:04:12 alefury: it is easy to justify: it will be more fun if getting int drained or transforming instantly affects your sustained buffs, but undoing it instantly changes them back, rather than suddenly getting hit with a miscast and an expiring spell 10:04:19 <|amethyst> Napkin: that's it... the selections you make there are used to divide up the XP 10:04:40 so.. i am supposed to activate/deactivate skills and then press enter? 10:04:40 <|amethyst> it should show old and new levels at the end of each skill 10:04:51 -!- ais523 has quit [Remote host closed the connection] 10:05:14 that's quite a bad interface - i'm surprised 10:05:16 well, i prefer galehar's proposal in theory, im not sure how it would compare to the other one in practice. just comment on the wiki so your concerns dont get lost :P 10:05:18 Napkin, yeah, it almost identically resembles the regular 'm' screen, but whatever you pick won't be remembered and will only apply to your pot of exp 10:05:31 in class, don't want to write up a wiki thing right now 10:05:33 Napkin, did it show arrows and #s (I think in blue) indicating what the new skill level would be? 10:05:45 it still shows 10:05:55 i haven't pressed enter yet 10:05:56 well, maybe write it later :P 10:05:58 Napkin, I'm surprised you think so, I had a potion of exp earlier and loved the new interface, once I Figured out what the hell I was doing. 10:06:03 Napkin, on one of hte servers? 10:06:17 exactly @ what the hell i was doing 10:06:30 CDO, Cryp71c 10:06:52 Napkin, yep, I gotcha. does it cycle through grey, + and * ? 10:07:14 something like "setup distribution and press enter to accept" would have made it much easier to understand, in my opinion 10:07:28 yes, it cycles 10:08:19 IMO, that's the only oddity (it should use only grey / selected) 10:08:40 The text at the bottom was helpful enough, perhaps adding on a "When finished, press enter to confirm selection" 10:08:43 <|amethyst> why shouldn't you be able to focus a skill with !experience 10:08:49 nah.. sticking to what setting you have selected (2 selections or 3 selections" is ok 10:09:17 |amethyst, ah, right..I briefly forgot that it would change slightly 10:09:21 So yeah, I guess cycling is good. 10:10:20 apart from the missing explanation, this is a great feature :) 10:10:31 first potion of experience since playing 0.9 10:10:59 yeah, loads better than before..though I think the whole concept of "dump lots of xp into pool" was cludgy. 10:11:23 <|amethyst> hm... the View(!) line shouldn't be there for !experience etc 10:11:37 <|amethyst> since toggling through the views doesn't actually change anything 10:11:46 it wasn't there 10:11:56 or at least not advertised 10:12:00 <|amethyst> I guess that's a 0.10 thing then 10:16:22 03Cryp71c * r1d46f048e722 10/crawl-ref/source/melee_attack.cc: Change combat-message ordering 10:16:32 03Cryp71c * rda8b10da2c1b 10/crawl-ref/source/melee_attack.cc: Mantis 4976: Aux unarmed on friendly (enslaved soul) 10:20:59 <|amethyst> Cryp71c: I suppose that works... I was thinking to explicitly track whether the monster was alive again after monster_die 10:21:35 <|amethyst> but I suppose there could be other melee enslavement effects that don't require killing the monster 10:22:03 |amethyst, you could check for enemy friendliness wherever we're prsently checking for enemy death, but yeah..that may not always be the appropriate place to check for it and would result in a lot more code than the change I've pushed. 10:23:08 speaking of pushing, why can't |amethyst do that yet? 10:23:10 <|amethyst> can an attack make any other attitude changes? 10:23:25 kilobyte, Napkin: hmm? 10:23:35 who gave write permissions to you, SamB? 10:23:36 |amethyst, not that I can think off of the top of my head 10:23:46 (probably dpeg?) 10:23:59 well, not sure if dpeg actually gave the permissions 10:24:14 usually he's consulted though. 10:24:22 and, does |amethyst actually want to? 10:24:29 oh, was it dpeg who said I could be in? 10:24:52 <|amethyst> it would mean that I wouldn't have to bug you guys to push my changes :) 10:25:56 :) 10:26:00 kilobyte actually gave me the commit bit iirc ... 10:27:10 <|amethyst> (speaking of which... I have three things waiting for review: branches visual-spell, sleep-brand-fix, and describe-fixes in 10:27:28 <|amethyst> git://gitorious.org/~neilmoore/crawl/neilmoore-crawl.git 10:27:44 ... but that was only because whoever gave me most of the other stuff had somehow not realized I needed something done on gitorious 10:28:15 |amethyst: more describe fixes? 10:29:01 <|amethyst> SamB: yeah, these are for the goblin corpse of Ijyb and for doubled origins in dumps (and a few misc fixes to use DESC_THE instead of "The %s") 10:29:34 <|amethyst> I also had a list somewhere of a bunch of bugs that should be closed after the previous describe fixes 10:30:09 <|amethyst> here we go: The following bugs have been fixed and should be marked as resolved: 4943 (7c8b1c8), 4947 (80a398b), 4954, 4955, 4959, 4960 (f6aaac5); 10:30:16 |amethyst: hmm, you have a lot of superfluous branches in your repo 10:30:19 oh, an Ogre talks to me? 10:30:46 probably because you didn't start by deleting (almost) all the branches like I did with mine 10:31:01 (and because gitorious is stupid like that and copies them all) 10:31:02 <|amethyst> SamB: every patch I've submitted got its own branch, and sometimes more than one if I screwed up the first time 10:31:15 |amethyst: no, I mean the ones you did not make 10:31:19 <|amethyst> oh, yeah 10:31:21 <|amethyst> I haven't deleted anything 10:31:54 for some reason gitorious copies all branches from the parent repository when you fork 10:32:00 <|amethyst> I'm not even sure how (I mean, I know how locally, but no idea how that works with gitorious) 10:32:12 omg.. cursed staff of energy? 10:32:14 geez.. 10:32:38 |amethyst: man git-push 10:32:45 <|amethyst> SamB: oh, --mirror ? 10:33:07 <|amethyst> ah, or pushing an empty source 10:33:07 not sure about mirror 10:33:32 git push remote :branch 10:33:50 git push remote ":*" 10:33:51 maybe ? 10:34:02 and then push all your branches again, obviously 10:37:16 * SamB thinks "Chrome Web Store" is a really really dumb name 10:39:24 <|amethyst> :* didn't work, but --mirror did kind of 10:39:57 <|amethyst> in that it also pushed all the origin/ tags (my origin is the main crawl repo, but I push to my repo) 10:40:07 ouch 10:40:24 <|amethyst> but they don't show up under "branches" so I don't care 10:40:36 <|amethyst> it just clutters the history 10:41:38 oh, yeah, I'm not seeing any issues here either 10:41:43 so it's all good 10:41:56 mirror is usually not that good 10:42:08 because it uploads remote branches as remote branches 10:42:15 Napkin: we just covered that 10:42:19 maybe gitorious doesn't support that though 10:42:29 you talked about tags 10:42:43 but that doesn't seem to be an actual problem 10:42:55 Napkin: oh, I think he meant refs 10:43:08 <|amethyst> the branches get turned into tags 10:43:14 oh? 10:43:44 <|amethyst> 16:38 10:43:44 maybe git push --delete --all 10:43:44 <|amethyst> Neil Moore tagged crawl/neilmoore-crawl 10:43:45 <|amethyst> origin/HEAD: Created tag origin/HEAD 10:45:56 <|amethyst> likewise origin/master origin/unarmed_combat_control etc. 10:47:56 <|amethyst> anyway, I'd best be going to work... the branches again were describe-fixes, visual-spell, and sleep-brand-fix 10:48:21 |amethyst: thanks! 10:48:48 sorry to be such a bother WRT the useless branches 10:53:35 -!- ais523 has joined ##crawl-dev 11:04:24 -!- blabber has joined ##crawl-dev 11:13:43 -!- monqy has joined ##crawl-dev 11:33:43 -!- ainsophyao has quit [Remote host closed the connection] 11:38:34 <|amethyst> Another minor fix: git://gitorious.org/~neilmoore/crawl/neilmoore-crawl.git dd-lich-nomem-reason 11:39:53 -!- MarvinPA_ has joined ##crawl-dev 11:43:18 -!- MarvinPA has quit [Ping timeout: 258 seconds] 11:48:19 <|amethyst> (the problem is that, if a DD in lichform reads Regeneration, he/she gets the message "You cannot currently memorise or cast this spell because you are in Lich form"; the fix gives the non-lichform message instead) 12:09:40 <|amethyst> Cryp71c: re #4977 : the crash occurred when a balrug with a demon whip of pain killed something with fire... the pain brand continued to proc, and then eventually crashed when checking the (dead) monster's holiness 12:10:43 <|amethyst> Cryp71c: would it be safe to only call apply_damage_brand if defender->alive() ? 12:11:24 instead of doing that, should add an appropriate check to see if defender died, and exit all code. 12:11:28 <|amethyst> hm 12:11:29 <|amethyst> actually 12:11:46 <|amethyst> this is because of db7d1423 (Fix vampirism not occuring on kill-hit) 12:12:02 <|amethyst> so fixing it in the obvious way will re-introduce that bug 12:12:26 -!- alefury has quit [Quit: ChatZilla 0.9.85 [Iceape 2.0.11/20110929064733]] 12:12:42 <|amethyst> hm... actually, I guess it's not because of that 12:14:29 <|amethyst> ... or maybe it is... I think I was misreading where the call to apply_damage_brand was originally located 12:16:46 I ran out of energy to track down bugs, but is it plausible that that crash could only happen for monsters? I feel like we would have seen it more if it happened with players too 12:17:25 was it a matter of balrugs with demon whip of pain getting AF_FIRE damage and pain brand damage also? 12:17:26 <|amethyst> elliptic: only monsters... the attack flavour did the killing damage 12:17:29 <|amethyst> yeah 12:17:38 yeah, okay 12:18:02 probably brands should be applied before attack flavour anyway? 12:18:02 <|amethyst> http://crawl.develz.org/morgues/trunk/arrian/crash-arrian-20111129-110215.txt is the crash dump 12:30:09 |amethyst: so what should I try to try out the new describe-fixes ? 12:33:15 -!- edlothiol has quit [Quit: leaving] 12:34:06 <|amethyst> a few things. 1. kill a unique, examine its corpse with xv (the description should be that of an ordinary corpse), try butchering/bottling it (you shouldn't see "the the" but you would before). See #4969 for more info 12:34:41 <|amethyst> 2. get an artefact and do a dump. You should only see the artefact's origin once (in parentheses before the description, not at the end of the description) 12:36:20 <|amethyst> 3. piss off jiyva so it slimifies nearby creatures. you should get "Jiyva's putrescence saturates the blah!" (in trunk it's ". . . saturates the the blah!") 12:38:21 <|amethyst> Also, it removes an extra blank line in wand descriptions (so there should be no more double blank lines), and re-adds a blank line before the weapon stats of rod and staves (so those stats are in their own "paragraph") 12:39:49 <|amethyst> re: 2. it removes item origins from all non-verbose descriptions; it would be good to verify that they're not wanted in any such description 12:40:19 <|amethyst> the origins should still be present in the i description, since that's verbose 12:48:22 <|amethyst> hm.. my sleep-brand-fix is buggy... if you fire a needle of sleep at a friendly creature and it works, the creature will not become hostile 12:49:14 <|amethyst> hm 12:49:18 <|amethyst> or maybe that's not a bug 12:50:03 <|amethyst> because AFAICT it wouldn't have upset friendlies before... the check explicitly excludes wont_attack monsters when damage is zero 12:51:27 Cryp71c: i don't suppose there is any chance of you rewriting code to keep monsters in existence until a turn is totally processed? :P 12:51:47 so many bugs are caused by monsters dying and then being operated on 12:52:23 Eronarn, maybe, I can look at how the code lays out, I fear as many bugs would be created by such a change as exist presently. 12:52:36 well, you have time for a new big project now, right? :) 12:57:36 |amethyst: hmm, well, are there options I have to enable to get that in my dumps ? 12:58:12 <|amethyst> SamB: dump_item_origins = all 12:59:00 <|amethyst> hm... I had thought "artefacts" was there by default, though 13:04:19 oh, do I need to ID it first ?!? 13:05:22 <|amethyst> in order to get the full description with the duplicate text, yes 13:05:34 <|amethyst> if it's unided you should still get the parenthesised origin 13:05:40 <|amethyst> l - a scale-covered lance {slay drac, +Rage rPois rF+ AC+5} 13:05:40 <|amethyst> (You found it on level 1 of the Elven Halls) 13:06:41 <|amethyst> if it's identified, before my patch you get something like: 13:06:53 <|amethyst> l - the +9,+6 Wyrmbane {slay drac, +Rage rPois rF+ AC+5} 13:06:53 <|amethyst> (You found it on level 1 of the Elven Halls) 13:06:53 <|amethyst> 13:06:53 <|amethyst> This legendary weapon is deadly to all dragonkind. It also provides some 13:06:54 <|amethyst> .. 13:06:58 <|amethyst> You found it on level 1 of the Elven Halls. 13:07:15 <|amethyst> back in a bit 13:07:25 oh, also for "artefacts" to apply, it seems 13:07:38 <|amethyst> oh 13:08:04 <|amethyst> I guess my unided artefacts were identified because I used "all" 13:08:12 <|amethyst> I guess that makes sense, sort of 13:08:35 eh ? 13:09:03 I don't believe that happened here... 13:09:18 <|amethyst> err, not identified 13:09:36 <|amethyst> I mean, my unided artefacts got descriptions because I used dump_item_origins = all 13:09:48 descriptions just because you asked for origins? 13:10:09 <|amethyst> sorry, I keep misspeaking 13:10:17 fair enough 13:10:49 <|amethyst> I got origins (and not descriptions) for my unided artefacts, but I think that's because I used dump_item_origins = all... so it was being dumped because it was a weapon, not because it was an artefact 13:11:55 how do I get Jivya ? 13:12:12 <|amethyst> yes, that is it... with the default dump_item_origins = artefacts, rods I get origins only for the IDed ones 13:12:39 <|amethyst> &_jiyva then &W to invoke wrath (do it with monsters around for the slimification) 13:12:59 hmm, I'm getting some message about jivya not accepting followers 13:14:34 <|amethyst> SamB: y before v 13:14:39 oh 13:14:53 these guys are so hard to sepell 13:16:21 <|amethyst> re sleep-brand-fix, really what should happen is the monster gets annoyed before being put the sleep 13:16:29 <|amethyst> s/the sleep/to sleep/ 13:18:00 <|amethyst> but I'm not sure how to best do that... maybe in _sleep_hit_victim() or put_to_sleep() 13:19:10 <|amethyst> my patch, or something similar, is still necessary to make it work at all (since the monster is already asleep at monster_post_hit, it won't do to annoy the monster then) 13:20:56 <|amethyst> hmm 13:22:44 <|amethyst> I guess another fix would be to modify 24ef732 somewhat... it causes both ME_WHACK and ANNOY to wake monsters... but if you only did that for WHACK, that should still fix the no-wake-on-stab bug that commit was intended to fix, while allowing sleep brand to work 13:22:50 03|amethyst * r20fcd5e4df9c 10/crawl-ref/source/describe.cc: Only include item origins in verbose descriptions. 13:22:54 03|amethyst * rbd487750b567 10/crawl-ref/source/ (delay.cc describe.cc itemname.cc): More description and messaging fixes. 13:22:55 03|amethyst * r66f00dbb8435 10/crawl-ref/source/ (godwrath.cc mon-ench.cc mon-place.cc): Use DESC_THE/DESC_A in a few more places. 13:22:55 03SamB * r422ade583880 10/crawl-ref/source/ (6 files): Merge branch 'describe-fixes' of git://gitorious.org/~neilmoore/crawl/neilmoore-crawl 13:24:03 davejl the Grasshopper (L2 FeWr) ASSERT(item_slot >= 0) in 'item_use.cc' at line 4872 failed on turn 605. (D:1) 13:27:40 Skeleton toad tile brightness (https://crawl.develz.org/mantis/view.php?id=4979) by Robsoie 13:29:14 davejl the Grasshopper (L2 FeWr) ASSERT(item_slot >= 0) in 'item_use.cc' at line 4872 failed on turn 676. (D:1) 13:31:29 <|amethyst> I'll have to think about the sleep brand thing some more... ME_ANNOY *should* wake monsters normally; it's just sleep-branded needles that are the problem 13:32:24 |amethyst: Can�t we add some "doesn't annoy" property in the sleep brand? 13:32:38 <|amethyst> it probably should annoy in general 13:32:54 <|amethyst> my fix made it not annoy, and the problem was you could sleep a friendly and it would remain friendly 13:33:11 <|amethyst> which is not how, e.g., ensorcelled hiberantion works (there the monster is slept, but hostile) 13:33:12 ah 13:33:30 So it doesn't trigger annoy? 13:33:40 s/annoy/whack... 13:33:48 <|amethyst> in trunk it does, and that makes needles of sleep not work at all 13:33:53 I'lljust go source dive... 13:34:02 <|amethyst> it triggers ANNOY, not WHACK 13:34:16 That's what I meant, sorry :) 13:34:34 <|amethyst> my partial fix, with the problems I mentioned above regarding friendlies, is at git://gitorious.org/~neilmoore/crawl/neilmoore-crawl.git sleep-brand-fix 13:36:02 <|amethyst> one could re-sleep the monster after the behaviour_event... but then if you fire a needle of sleeping at a sleeping hostile, and the hostile resists, it won't wake 13:42:34 <|amethyst> hm 13:43:47 -!- Pingas has quit [Read error: Connection reset by peer] 13:44:54 arrian (L13 CeFE) ASSERT(item_slot >= 0) in 'item_use.cc' at line 4872 failed. (Lair:6) 13:45:27 <|amethyst> even without sleep-brand-fix, sleeping needles won't annoy friendlies, since no damage was done... I should be testing with neutrals 13:47:49 <|amethyst> okay, I have something that works-ish 13:48:46 |amethyst: Can I make a teeny tiny request? 13:48:54 <|amethyst> ghallberg: yeah? 13:48:58 <|amethyst> it puts the monster back to sleep after annoying it... friendlies, good neutrals, and fellow slimes will not be affected, but that's because zero-damage beams explicitly do not annoy them 13:49:10 |amethyst: When you do work on a bug, can you please post a note about it on the mantis issue? 13:49:34 Every time I've tried to fins something to fix in the last week I found that you already did it :) 13:49:45 <|amethyst> yeah, sorry about that 13:49:47 You're too good at this! :D 13:50:09 Honestly I feel really stupid for complaining. 13:50:12 <|amethyst> hm, what was the bug number on needles of sleeping? 13:50:22 <|amethyst> or was it not in mantis? 13:51:21 Doesn't look like it. 13:53:45 it isn't on mantis, yeah 13:55:56 <|amethyst> okay, I have a new attempt... needles of sleeping still don't upset friendlies or good neutrals, but they do upset true neutrals 13:59:36 <|amethyst> git://gitorious.org/~neilmoore/crawl/neilmoore-crawl sleep-brand-fix (I deleted the old branch and pushed a new one) 14:02:11 <|amethyst> was the "VISUAL SPELL" bug in mantis? it looks like no 14:04:25 <|amethyst> anyway, I need to be going for a bit 14:04:30 <|amethyst> SamB: thanks for pushing 14:05:51 -!- Karagy has joined ##crawl-dev 14:06:28 commanderc (L15 MiAr) ASSERT(attk_type < static_cast(sizeof(attack_types) / sizeof(const char *))) in 'melee_attack.cc' at line 3856 failed. (D:17) 14:07:56 -!- Eifeltrampel has joined ##crawl-dev 14:10:09 -!- alefury has joined ##crawl-dev 14:22:12 -!- the_glow has left ##crawl-dev 14:33:24 <|amethyst> !lm commanderc crash 14:33:24 1. [2011-11-29] commanderc the Severer (L15 MiAr) ASSERT(attk type < static cast(sizeof(attack types) / sizeof(const char *))) in 'melee attack.cc' at line 3856 failed on turn 53459. (D:17) 14:33:28 <|amethyst> !lm commanderc crash -log 14:33:28 1. commanderc, XL15 MiAr, T:53459 (milestone): http://crawl.develz.org/morgues/trunk/commanderc/crash-commanderc-20111129-200617.txt 14:34:21 <|amethyst> okay, that's an old version 14:34:56 <|amethyst> I thought develz was updated, but no, that was akrasiac 14:36:13 <|amethyst> (and even that was one revision behind the AT_WEAP_ONLY fix) 14:39:27 ??lich form 14:39:28 necromutation[1/1]: Level 8. Induces lichform for 18 + 2d(power) turns,+3 str, small unarmed bonus (drain) and AC, MR, +cold, +pois, death enhancer, and undead for all game purposes (no food/potion use, negative energy immunity, mutation immunity, torment immunity, prevents transformations, dispel undead vulnerability, no berserk). 14:41:24 -!- syllogism has quit [] 14:43:29 <|amethyst> SamB: for that one, play a DD, cast necromutation, and do ?/sregeneration 14:44:01 <|amethyst> with my patch it has the same message with and without necromutation up 14:45:06 looks good 14:46:35 -!- ortoslon has joined ##crawl-dev 14:47:33 <|amethyst> re the needle of sleeping thing, I considered just swapping the order of monster_post_hit and apply_hit_funcs.... I just tested it, and that makes missile explosions not anger friendlies (since no damage is done until apply_hit_funcs) 14:48:07 you still have to be able to train a skill to reskill exp out of it with ash 14:49:50 -!- Lunarharp has joined ##crawl-dev 14:52:24 -!- Lunarharp has quit [Client Quit] 14:53:26 |amethyst: I'm looking for stuff like "_Your orc wizard glows brightly for a moment." with the other one? 14:53:45 jeanjacques: report please? 14:54:41 <|amethyst> elliptic: 4914 14:55:03 <|amethyst> SamB: that one's actuall just an ENCHANT: so it worked fine before 14:55:12 |amethyst: oh 14:55:24 <|amethyst> SamB: "The wizard's eyes start to glow" is one 14:55:32 what should I do to my orcs to get them to do that? 14:55:48 <|amethyst> SamB: I don't think orcs will do that 14:55:52 oh 14:56:00 <|amethyst> SamB: try boris, he has quite a few visuals 14:56:04 jeanjacques: okay, don't report actually :) (thanks |amethyst!) 14:56:27 <|amethyst> "Boris stares at you.", "Boris gestures.", "You feel disoriented/weakened/troubled." 14:57:52 <|amethyst> oh, actually, "The orc wizard's eyes start to glow" should be one I think, assuming they get the _wizard_medium_ list 14:58:32 oh too late -_- 15:03:09 ashenzaris Transfer Knowledge ability requires training ability for the source skill (https://crawl.develz.org/mantis/view.php?id=4980) by jeanjacques 15:04:13 <|amethyst> should you be able to reskill *to* an untrainable skill? 15:04:38 yes 15:05:22 is just giving you knowledge, so no way of exercising that skill should be required 15:05:30 probably the easiest way to do it, not much of an unfair advantage in any case 15:07:19 <|amethyst> git://gitorious.org/~neilmoore/crawl/neilmoore-crawl ash-reskill-from-any 15:08:07 <|amethyst> gah 15:08:17 <|amethyst> git://gitorious.org/~neilmoore/crawl/neilmoore-crawl.git ash-reskill-from-any 15:16:07 <|amethyst> Fyren has a patch in 4910 ("Skill menu not exitable under rare circumstance") that looks reasonable, except it needs some braces to meet the coding style 15:16:22 -!- ainsophyao has joined ##crawl-dev 15:21:07 03elliptic * r13986762544b 10/crawl-ref/source/main.cc: Fix DD + Trog's Hand + Guardian Spirit being abusable for faster healing (lunarharp). 15:22:24 -!- Cryp71c has quit [Quit: Leaving] 15:25:01 -!- ortoslon has quit [Quit: bye] 15:28:55 <|amethyst> I can't reproduce 4886 (ASSERT(feat_is_solid(feat)) in 'beam.cc' at line 1114 failed) 15:29:32 <|amethyst> I'm following magykun's steps and the tentacle dies without crashing... let me try their save 15:31:11 The splash of acid hits you! The acid corrodes your cursed +1 cloak! The acid corrodes your +1 dwarven helmet! The acid corrodes your +1 pair of gauntlets! The acid corrodes your +2 elven robe of resistance! 15:31:16 one shot, fucking A 15:31:23 hey 15:31:28 http://www.fz.se/filmer/20111129/legend-of-grimrock-beta-trailer/ 15:31:34 seen this trailer for a new 3d dungeon crawler? 15:31:45 of course, cbus :) 15:31:51 :) 15:34:11 so.. how high is the chance, that a oklob plant's acid splash corrodes each and every piece of armour you wear? 15:38:58 very high, if you're naked 15:39:01 looks like 0.3*0.15*0.15*0.15*0.2*0.82*0.82*0.82*0.66 chance in your case 15:39:34 7.3 * 10^(-5) 15:40:33 as usual, Napkin has great luck 15:41:36 expected value of AC loss was about half a point 15:41:58 We need to make Napkin-Crawl before frustration makes us lose our sysadmin :) 15:42:21 03|amethyst * rd1e3e1d8bd2d 10/crawl-ref/source/message.cc: Fix VISUAL SPELL: and similar messages. 15:42:21 03|amethyst * r11d7403bb584 10/crawl-ref/source/spl-book.cc: Clarify that DD liches can never memorise Regeneration 15:42:22 03SamB * r5ed357ef944c 10/crawl-ref/source/spl-book.cc: Merge branch 'dd-lich-nomem-reason' of git://gitorious.org/~neilmoore/crawl/neilmoore-crawl 15:42:32 03SamB * re7466cb96502 10/crawl-ref/source/message.cc: Merge branch 'visual-spell' of git://gitorious.org/~neilmoore/crawl/neilmoore-crawl 15:42:45 <|amethyst> SamB: thanks 15:47:58 <|amethyst> oh... 4886 is in 0.9, no wonder I couldn't reproduce 15:49:00 |amethyst: what is this about braces for coding style ? 15:49:23 <|amethyst> SamB: Fyren's menu.patch has something like 15:49:26 <|amethyst> if (foo 15:49:31 <|amethyst> && bar) 15:49:35 <|amethyst> something 15:49:40 so ? 15:49:46 * SamB has seen that a lot 15:50:14 <|amethyst> usually DCSS uses { } when the condition or the statement takes multiple lines 15:50:19 oh, possibly 15:50:33 certainly wouldn't hurt 15:51:07 -!- alefury has quit [Ping timeout: 244 seconds] 15:52:01 <|amethyst> as for 4886, it looks like 15:52:16 <|amethyst> it looks like ff00130 should be backported to 0.9 15:52:48 <|amethyst> but I haven't tested, because it will take me half an hour to build 0.9 :) 15:53:16 -!- alefury has joined ##crawl-dev 15:53:26 oklob can be teleported. It's, conceptually, ok? 16:00:00 <|amethyst> hm... I'm trying to figure out what stops plants from being teleported/polymorphed 16:00:46 Legend of Grimrock looks like remake for old "Dungeon Master II: The Legend of Skullkeep" from Interplay. 16:01:05 <|amethyst> oh, they're MAG_IMMUNE 16:01:24 ghallberg :D 16:01:26 |amethyst, what stops plants being teleported? May bee roots? -) 16:01:39 *be 16:01:54 <|amethyst> Karagy: apparently they're completely immune to enchantment, including teleport as well 16:02:05 <|amethyst> s/as well/ 16:02:12 but distortion can teleport them 16:02:20 <|amethyst> oh, right 16:02:31 from what version? In 0.6 I sucessfully teleported oklobs in Huve. 16:02:36 *Hive 16:02:38 -!- ainsophyao has quit [Remote host closed the connection] 16:02:42 <|amethyst> Karagy: I mean plain plants 16:02:47 <|amethyst> Karagy: oklobs are not magic immune 16:03:17 <|amethyst> I've not teleported them before, but I have polymorphed them 16:04:20 <|amethyst> I guess the teleport places their roots safely in the ground :) 16:05:37 ... with dirt around roots. And make shaft -) 16:11:53 <|amethyst> is there a reason boggarts have a mass of zero? 16:14:25 -!- DaneiTWO has joined ##crawl-dev 16:17:28 -!- timecircuits has joined ##crawl-dev 16:17:51 -!- Danei has quit [Ping timeout: 248 seconds] 16:18:32 <|amethyst> there seem to be a lot of monsters (boggarts, golden eyes, many Js, green death, killer klown) with mass 0 but not CE_NOCORPSE 16:19:18 <|amethyst> I guess that makes sense for the poisonous ones because that makes them vulnerable to ignite poison 16:21:31 <|amethyst> but boggarts, pulsating lumps, killer clowns, serpent of hell, and TRJ all have either CE_CONTAMINATED or CE_CLEAN, and it's not clear to me why those wouldn't be CE_NOCORPSE 16:22:03 the serpent of hell drops a corpse, doesn't it? 16:22:12 -!- MarvinPA_ is now known as MarvinPA 16:22:25 such are good questions for the ML, if nobody has time to answer here, |amethyst 16:22:40 or you're saying it shouldn't? i don't entirely follow :P 16:22:51 <|amethyst> I guess it's to let vampires drain them? 16:23:07 <|amethyst> I didn't check the variants, but the base entry for SoH has mass 0 16:23:50 A the corpse of the Serpent of Hell. 16:24:02 (woo more description bugs) 16:24:02 <|amethyst> hmm 16:24:12 <|amethyst> MarvinPA: is that fully up-to-date master? 16:24:21 oh, nope 16:24:33 (woo too ;)) 16:24:50 goooood morning 16:25:03 <|amethyst> MarvinPA: hmm... when I do &oXserpent of hell it says "That monster doesn't leave corpses; make one anyway?" 16:25:07 moin due! 16:25:22 i just did it by spawning the serpent and stabbing it 16:25:46 Oh cool, I got dungeons of dredmore from humble bundle. 16:25:49 Is it any good? 16:25:51 so i guess it must have something elsewhere that causes it to drop a corpse? 16:26:00 -!- Ragdoll has quit [Quit: Ik ga weg] 16:26:19 i definitely know it drops them in regular games, since you then get a serpent-of-hell inscribed dragon hide :P 16:27:36 quite nice, ghallberg 16:27:43 also, it seems wrong for vampire bite attempts to check for chunk type anyway, surely 16:27:58 shouldn't it check for blood? 16:28:01 extremely difficult, in my opinion (highest difficulty, roguelike setting) 16:28:07 oh it does that too 16:28:09 weird 16:28:20 Napkin: I see. 16:28:35 I'll install and splat something before bed. 16:30:30 -!- blabber has quit [Quit: gn8] 16:31:47 hey ghallberg, keep me posted, what combo you managed to survive with? 16:39:36 Combos are terribly long though :P 16:43:05 :D 16:53:49 -!- edlothiol has joined ##crawl-dev 16:55:04 |amethyst: CE_CONTAMINATED matters for vampires 16:55:28 doesn't make sense for a vampire to dislike human blood, though 16:56:09 icky human blood! 16:56:11 <|amethyst> ah, I see, half nutrition 17:01:31 mrwooster the Grave Robber (L4 DDNe) ASSERT(item_slot >= 0) in 'item_use.cc' at line 4872 failed on turn 3883. (D:4) 17:01:50 <|amethyst> I'm not sure it makes sense for human corpses to be contaminated 17:03:47 <|amethyst> !lm mrwooster crash -log 17:03:47 1. mrwooster, XL4 DDNe, T:3883 (milestone): http://crawl.akrasiac.org/rawdata/mrwooster/crash-mrwooster-20111129-230130.txt 17:06:44 I'd rather have different rules for different species, though 17:07:12 all but one rats give contaminated meat so felids will get sick when eating them 17:08:23