02:51:46 <Cbrotell> Unstable branch on cbro.berotato.org updated to: 0.27-a0-1256-gced786f65e (34)
03:15:28 <Discord|> <12e​bering> Dramatic
05:04:45 <Cheibriados> New branch created: pull/1980 (3 commits) 13https://github.com/crawl/crawl/pull/1980
05:04:45 <Cheibriados> 03DreamDust02 {GitHub} 07https://github.com/crawl/crawl/pull/1980 * 0.27-a0-1257-ge658912: Adding 3 vaults to float.des 10(26 minutes ago, 1 file, 151+ 0-) 13https://github.com/crawl/crawl/commit/e658912a1bb0
05:04:45 <Cheibriados> 03DreamDust02 {GitHub} 07https://github.com/crawl/crawl/pull/1980 * 0.27-a0-1258-g94a4367: Adding 2 vaults to swamp.des 10(17 minutes ago, 1 file, 64+ 0-) 13https://github.com/crawl/crawl/commit/94a436753775
05:04:45 <Cheibriados> 03DreamDust02 {GitHub} 07https://github.com/crawl/crawl/pull/1980 * 0.27-a0-1259-g21aeeed: Adding a vault to elf.des 10(9 minutes ago, 1 file, 23+ 0-) 13https://github.com/crawl/crawl/commit/21aeeed1a490
05:25:02 <Cheibriados> 03gammafunk02 07* 0.27-a0-1257-gc40782c: A quote for scrolls of identification (nicolae, 12593) 10(3 days ago, 1 file, 7+ 1-) 13https://github.com/crawl/crawl/commit/c40782c2dad4
05:25:02 <Cheibriados> 03gammafunk02 07* 0.27-a0-1258-ga7538b3: Some cleanups for Shoals.des 10(3 days ago, 1 file, 177+ 175-) 13https://github.com/crawl/crawl/commit/a7538b32033a
05:25:02 <Cheibriados> 03gammafunk02 07* 0.27-a0-1259-gde6c002: Some Shoals vaults from nicolae (12593) 10(47 minutes ago, 1 file, 701+ 0-) 13https://github.com/crawl/crawl/commit/de6c002c3708
05:25:02 <Cheibriados> 03gammafunk02 07* 0.27-a0-1260-g27faaac: Checkwhite 10(10 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/27faaac778a0
09:31:48 <Cheibriados> 03advil02 07* 0.27-a0-1261-g534494d: fix: prevent save corruption on &P crashes 10(3 minutes ago, 2 files, 18+ 1-) 13https://github.com/crawl/crawl/commit/534494da4662
10:09:20 <advil> does anyone know why sometimes a crashed crawl process requires kill -9 and sometimes it doesnt?
10:09:37 <advil> I definitely feel like the frequency of it needing that has increased a bunch lately
10:09:49 <advil> (well, it'll time out eventually so it doesn't "need" it)
10:11:02 <Pinkbeast> I expect it always to if gdb is still thinking about the backtrace
10:23:59 <advil> this is a mac, so gdb isn't run
11:31:57 <Discord|> <10P​leasingFungus> today's pet peeve: spl-data.h spell-type.h
11:33:29 <Discord|> <09h​ellmonk> mon-book is more annoying bc its not the file with the monster books
11:33:33 <Discord|> <10P​leasingFungus> haha, yes
11:33:45 <Discord|> <10P​leasingFungus> that one's gotten me too
11:36:26 <floraline> !cko
11:36:26 <Kelbell> apollothirteen (L26 @ Vaults:5, T:90319), violentviolet (L26 @ Vaults:5, T:76446), steves (L19 @ Spider:3, T:62485), tboon (L19 @ Depths:3, T:45485), particleface (L18 @ Shoals:3, T:49946), staticflow (L17 @ Elf:1, T:42530), bzbzbz (L16 @ Orc:2, T:42241), Lightli (L15 @ D:12, T:31802), Eugor (L12 @ Lair:1, T:16703), WindowMaker (L12 @ Lair:1, T:15303), Lintmaker (L11 @ D:9, T:8222), Namarukai (L10 @ D:7, T:12243), tu...
11:41:47 <Discord|> <10P​leasingFungus>      case BEAM_DAMNATION:         break; // sucks to be you (:   this is a good comment. i wonder if i wrote it
11:42:01 <Kelbell> floraline (L1 HOFi) ERROR in 'wizard.cc' at line 79: Intentional crash (D:1)
11:46:07 <Discord|> <08n​icolae> finally, after all these years, scroll of identify has the marcus aurelius quote..............
12:08:36 <Cheibriados> 03PleasingFungus02 07* 0.27-a0-1262-g1b1a975: Rework Air Elementals 10(39 minutes ago, 22 files, 98+ 93-) 13https://github.com/crawl/crawl/commit/1b1a975c3d6d
12:10:54 <Discord|> <10P​leasingFungus> @advil how hard do you think it would be to allow quivering scrolls? like, for example, scroll of fear
12:19:55 <advil> sounds doable
12:19:55 <Discord|> <08n​icolae> lol, i completely redid some of my elf ideas because the air elementals kept killing everything, so i guess now i can bring that back
12:20:06 <advil> is that a thing that people want? (quivering scrolls)
12:20:29 <Discord|> <08n​icolae> a scroll of fear would make the monsters quivering, though
12:20:44 <advil> lol was this just an elaborate pf pun
12:23:24 <Discord|> <10P​leasingFungus> no
12:23:31 <Discord|> <10P​leasingFungus> i like the pun tho
12:23:37 <Discord|> <10P​leasingFungus> hadn’t thought of it
12:24:01 <Discord|> <10P​leasingFungus> this is in context of a convo about seeing ?fear success chance
12:27:14 <dcss-ci> 04Build failed for 08master @ 1b1a975c 06https://github.com/crawl/crawl/actions/runs/925761417
12:34:12 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.27-a0-1262-g1b1a975c3d (34)
12:57:15 <Discord|> <06a​dvil> ah, as a generic interface that always allows showing targeters
12:58:19 <Discord|> <06a​dvil> it's definitely implementable, I wonder if there's a simpler way to get to the targeter though
12:59:02 <Discord|> <06a​dvil> I didn't do it because outside of like lategame id scrolls and zigs, it didn't seem to me that the stacks for scrolls/pots would be big enough to be worth the clutter in the Q menu
13:00:12 <Discord|> <06a​dvil> alternative, make fear a wand or misc item 😄
13:09:40 <Discord|> <10P​leasingFungus> i'm definitely worried that people wouldn't actually know about or use this, yes
13:09:44 <Discord|> <10P​leasingFungus> it's not the most obvious interface
13:09:47 <Discord|> <10P​leasingFungus> was just one thought
13:11:36 <Discord|> <09h​ellmonk> Describe the success rate at every will value in the item desc
13:11:40 <Discord|> <09h​ellmonk> Ez
13:14:47 <Cheibriados> 03PleasingFungus02 07* 0.27-a0-1263-g6f2aa7e: Let Storm Form go mano-e-mano (engine, Reeces) 10(84 seconds ago, 2 files, 3+ 1-) 13https://github.com/crawl/crawl/commit/6f2aa7e3026e
13:17:07 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.27-a0-1263-g6f2aa7e302 (34)
13:26:25 <dcss-ci> 04Build failed for 08master @ 6f2aa7e3 06https://github.com/crawl/crawl/actions/runs/925916792
13:30:07 <Henzell> Unstable branch on crawl.akrasiac.org updated to: 0.27-a0-1262-g1b1a975 (34)
13:54:20 <Cheibriados> 03advil02 07* 0.27-a0-1264-ge710ad1: fix: improve crashes for unrecoverable builder lua errors 10(4 hours ago, 6 files, 67+ 6-) 13https://github.com/crawl/crawl/commit/e710ad149d88
13:54:20 <Cheibriados> 03advil02 07* 0.27-a0-1265-g738ad7b: fix: revert a debugging change 10(23 minutes ago, 1 file, 1+ 3-) 13https://github.com/crawl/crawl/commit/738ad7bf9815
13:54:20 <Cheibriados> 03advil02 07* 0.27-a0-1266-g85dd5f3: build: shorten mut_species.lua test 10(18 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/85dd5f356d46
13:54:20 <Cheibriados> 03advil02 07* 0.27-a0-1267-g90a9cae: fix: get rid of "unable to find exits" error in bounce.lua test 10(7 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/90a9cae496eb
13:56:59 <Discord|> <06a​dvil> @gammafunk e710ad1 isn't really what you most wanted but it should improve things a lot
13:58:57 <Discord|> <06a​dvil> now it crashes immediately with the lua error shown, and to recover from the crash the game now does an unforced level regeneration on load
14:06:51 <dcss-ci> 04Build failed for 08master @ 90a9cae4 06https://github.com/crawl/crawl/actions/runs/926011882
14:13:22 <Cheibriados> 03advil02 07* 0.27-a0-1268-gdcd9d5d: fix: remove an ENCH_VORTEX reference for CI 10(48 seconds ago, 1 file, 1+ 2-) 13https://github.com/crawl/crawl/commit/dcd9d5d9b85b
14:14:21 <advil> as an aside I think that code should have failed unbrace before that commit, not sure why it didn't
14:14:45 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.27-a0-1267-g90a9cae496 (34)
14:17:20 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.27-a0-1268-gdcd9d5d9b8 (34)
14:23:48 <Cheibriados> 03advil02 07* 0.27-a0-1269-g5d3a65c: fix: more vortex removal for CI 10(23 seconds ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/5d3a65c7231d
14:24:13 <Discord|> <10P​leasingFungus> oh, yeah, oops
14:24:25 <Discord|> <10P​leasingFungus> ty!
14:32:09 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.27-a0-1269-g5d3a65c723 (34)
14:35:06 <dcss-ci> 04Build failed for 08master @ dcd9d5d9 06https://github.com/crawl/crawl/actions/runs/926056020
14:38:29 <advil> sad that we never get to see the success messages
15:17:31 <Cheibriados> 03advil02 07* 0.27-a0-1270-g10283c2: feat: tweak polar vortex glyph colours 10(4 minutes ago, 1 file, 4+ 4-) 13https://github.com/crawl/crawl/commit/10283c22388c
15:19:42 <Discord|> <10P​leasingFungus> i was vaguely thinking about changing that
15:19:56 <Discord|> <10P​leasingFungus> but hadn’t gone as far as looking at current colours
15:20:03 <Discord|> <10P​leasingFungus> ty for changing it!
15:32:13 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.27-a0-1270-g10283c2238 (34)
16:32:59 <Discord|> <06a​dvil> well, we'll see if the new colors work
16:33:08 <Discord|> <06a​dvil> possibly the tiles could use some changes as well?
16:47:17 <Discord|> <10P​leasingFungus> possibly
17:07:35 <Cheibriados> 03advil02 07* 0.27-a0-1271-g5a9c36e: build: reduce iterations for uniques testing 10(2 minutes ago, 1 file, 12+ 8-) 13https://github.com/crawl/crawl/commit/5a9c36edca1e
17:09:43 <Cheibriados> 03advil02 07* 0.27-a0-1272-g7c8ad2e: fix: remove accidental debug messaging 10(32 seconds ago, 1 file, 0+ 3-) 13https://github.com/crawl/crawl/commit/7c8ad2e4073f
17:17:11 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.27-a0-1272-g7c8ad2e407 (34)
17:17:13 <advil> gotta keep my commit count up
17:18:23 <Discord|> <09g​ammafunk> @advil nice, thanks. That should make figuring out the source lines of those types of errors easier.
17:18:36 <advil> huh I actually moved into 5th place on the github contributors page
17:35:38 <Discord|> <06a​dvil> whoa int monster::mindex() const {     return this - env.mons.buffer(); }
17:35:58 <Discord|> <06a​dvil> til mindexes are pointer arithmetic cast to ints??
17:36:40 <Discord|> <06a​dvil> should not have looked at the details sausage
17:37:27 <jilles> works fine as long as all monsters are part of env.mons
17:40:42 <Discord|> <06a​dvil> a sadly false assumption
17:42:20 <Discord|> <06a​dvil> in fact I wonder if this could be the source of some weird item issues with transiting monsters such as ancestor, item link for monster items is derived from mindex and held_by_monster() requires a positive item link to be valid
17:42:56 <Discord|> <09h​ellmonk> gotta toss that sausage on the grill
17:43:06 <jilles> subtracting two pointers that aren't from the same array (and also not one past the end) is UB
17:43:27 <Discord|> <06a​dvil> ouch, is it?
17:43:43 <Discord|> <06a​dvil> it probably just behaves like normal arithmetic for most compilers
17:45:27 <jilles> it's generally something like ((intptr_t)p - (intptr_t)q) / sizeof(*p)
17:45:47 <Discord|> <06a​dvil> lol
17:45:57 <jilles> but the compiler might be able to optimize a bit by knowing that the remainder of the division is 0
17:46:34 <jilles> also, in segmented architectures the segment part might be completely ignored
17:47:13 <jilles> if you're in a memory model where an array must be contained within a segment
17:47:38 <Discord|> <06a​dvil> I suppose in a lot of cases this mostly works as an id despite all this, unless some code is doing things like checking the sign
17:56:35 <Discord|> <06a​dvil> not entirely sure what to do about this, this is the sort of low-level crawlcode it's quite alarming to mess with
18:00:02 <Discord|> <06a​dvil> it does look like the transit code is sort of supposed to handle this, it at least stores the items separately
18:05:30 <Aliscans> If you're worried about mindex being called on something which isn't in env.mons, would an assert prevent it from creating obscure errors?
18:18:27 <Discord|> <06a​dvil> not immediately sure how to check that without iterating through env.mons
18:19:24 <Discord|> <06a​dvil> the code does have a check for this (invalid_monster_index) but it assumes (contra what jilles points out) that the arithmetic is well-defined for arbitrary monster objects
18:23:53 <Lantell> Unstable branch on underhound.eu updated to: 0.27-a0-1272-g7c8ad2e407 (34)
20:50:41 <Cheibriados> 03nlavsky02 {GitHub} 07* 0.27-a0-1273-gec92ba8: Don't put Refrigeration users under penance for tracer checks (#1978) 10(10 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/ec92ba881d03
21:02:03 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.27-a0-1273-gec92ba881d (34)
22:40:32 <Yermak> Blinkbolt doesn't work with tab autofight!
23:11:36 <Discord|> <10P​leasingFungus> i wonder what it should do
23:37:11 <Yermak> Blink at some enemy?
23:39:30 <Discord|> <10P​leasingFungus> probably
23:56:23 <Discord|> <09h​ellmonk> case 0:     case 1:     case 2: // recital         simple_god_message(" recites the Axioms of Law to you!", god);         switch (random2(3))         {         case 0:             confuse_player(5 + random2(3));             break;         case 1:             you.put_to_sleep(nullptr, 30 + random2(20));             break;         case 2:             paralyse_player(_god_wrath_name(god));
23:56:23 <Discord|> return false;         }
23:56:29 <Discord|> <09h​ellmonk> look at this code and tell me there is a god
23:58:58 <Discord|> <10P​leasingFungus> i won't do it