00:04:57 <10PleasingFungus> ASSERT(wrapcol >= 2) in 'cio.cc' at line 191 failed. Version: Dungeon Crawl Stone Soup 0.27-a0-930-gf56c19cca7 Platform: unix (OS X) Bits: 64 Game mode: normal Tiles: yes Seed: 10352176140041513627, deterministic pregen: 1 Command line: ./crawl RC options: restart_after_game = true Crash caused by signal #4: Illegal instruction: 4 Obtained 20 stack frames. 0x0000000109dd79fb: 00:04:58 write_stack_trace(__sFILE*) + 123 0x0000000109de5070: do_crash_dump() + 1584 0x0000000109dd7764: crash_signal_handler(int) + 180 0x00007fff6aa1a5fd: _sigtramp + 29 0x000000000000ffff: 0x0 + 65535 0x0000000109de7389: _BreakStrToDebugger(char const*, bool) + 9 0x0000000109de7369: AssertFailed(char const*, char const*, int, char const*, ...) + 329 0x0000000109dadf18: wrapcprint_skipping(int, int, 00:04:58 std::__1::basic_string, std::__1::allocator > const&) + 472 0x0000000109dadffd: wrapcprintf(char const*, ...) + 189 0x0000000109ef4b82: formatted_string::display(int, int) const + 242 0x000000010a0e0014: message_window::show() + 148 0x000000010a0eac16: message_window::add_item(std::__1::basic_string, std::__1::allocator >, prefix_type, 00:04:59 bool) + 630 0x000000010a0e7b39: message_store::append_store(circ_vec) + 793 0x000000010a0e73fa: load_messages(reader&) + 666 0x0000000109ee2989: restore_game(std::__1::basic_string, std::__1::allocator > const&) + 4137 0x000000010a364a35: startup_step() + 2901 0x000000010a536d79: _launch_game() + 25 0x000000010a5302bf: main + 1215 0x0000000109d1f944: start 00:04:59 52 0x0000000000000001: 0x0 + 1 i'm getting this crash every time i try to load a game (any game) and it's quite annoying 00:05:06 <10PleasingFungus> wonder if something recent changed 00:05:25 <10PleasingFungus> @advil could this be caused by cfdca905f54dd5fbbedc34abe0a1e7decc19eacd somehow? 00:06:00 <10PleasingFungus> hm, assume it is, that's where the assert was added 00:08:34 <10PleasingFungus> i've removed it for now 00:08:34 <10PleasingFungus> can investigate later if you want 00:08:48 03PleasingFungus02 07* 0.27-a0-931-g5a74e75: Remove a hairtrigger assert 10(51 seconds ago, 1 file, 0+ 1-) 13https://github.com/crawl/crawl/commit/5a74e75d8f72 00:16:52 Unstable branch on crawl.kelbi.org updated to: 0.27-a0-931-g5a74e75d8f (34) 00:46:43 Hematite12 (L25 MfGl) ERROR in 'tags.cc' at line 4596: Invalid item: (quantity: 0) gold piece (Vaults:4) 01:34:38 Unstable branch on crawl.develz.org updated to: 0.27-a0-931-g5a74e75d8f (34) 01:55:44 Windows builds of master branch on crawl.develz.org updated to: 0.27-a0-931-g5a74e75d8f 02:47:38 Unstable branch on cbro.berotato.org updated to: 0.27-a0-931-g5a74e75d8f (34) 02:53:51 Monster database of master branch on crawl.develz.org updated to: 0.27-a0-931-g5a74e75d8f 02:58:52 03AlexanderPosch02 07https://github.com/crawl/crawl/pull/1885 * 0.27-a0-918-g6234633: Fix string_spell_range: What should the range in the spell description show? The "normal range" or the "range restricted to los" or a mixture (like this @--->~~~...)? I have currently implemented the mixed model I also avoided using you.stuff in header file 10(9 minutes ago, 5 files, 16+ 10-) 13https://github.com/crawl/crawl/commit/6234633664e9 03:31:01 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-4135-g7666618ddd 07:17:45 -!- amalloy is now known as amalloy_ 09:33:23 <12ebering> @Sastreii Regarding abyssal trees, I didn't see them go by if you had uploaded them previously, but I think what we'd be looking for are tree variants for each colour (the 15 ansi console colours other than black) that blend well with abyss walls: https://github.com/crawl/crawl/tree/master/crawl-ref/source/rltiles/dngn/wall/abyss and the demonic plant 09:33:23 https://github.com/crawl/crawl/blob/master/crawl-ref/source/rltiles/mon/fungi_plants/plant_demonic.png 09:35:26 <12ebering> More demonic plant variants would also be nice (and feel free to re-do demonic plants to blend with your abyssal trees if that gives the flexibility you need) 09:45:15 <13Sastreii> mh ok. i'll put there some if you missed them, after that i'll try to do something different. the demonic plant tile is pretty good, i'll probably make some variants of the original 09:46:11 <13Sastreii> this is what i made so far 09:46:12 <13Sastreii> https://cdn.discordapp.com/attachments/747522859361894521/830438516914782238/Schermata_2021-04-10_alle_15.45.21.png 09:46:27 <12ebering> oh nice 09:46:50 <12ebering> not sure if we'll actually need all of the colour variants, but the abyss does like to be colourful 09:48:19 <13Sastreii> yeah that's why i used two color palette 09:48:24 <13Sastreii> since the layout and the colors of the abyss are always changing is difficult to use only one palette imo. 09:48:47 <13Sastreii> but i can try if needed 09:49:36 <12ebering> no need, if you can cover each of the 15 variant colours (maybe 14 colourful pairs plus an all white "skeleton"?) by using pairs the tile-picking code can be set up to treat them appropriately 09:50:15 <12ebering> the two trees palattes you've got in that image would work with lightblue/lightmagenta and green/magenta 09:50:31 <12ebering> and the tile picker would grab the blue-trunked one for either lightblue or lightmagenta 09:52:20 <13Sastreii> mm i saw that tiles, some of them are very similar, near identical 09:52:55 <13Sastreii> for example, those are abyss yellow and abyss brown 09:52:55 <13Sastreii> https://cdn.discordapp.com/attachments/747522859361894521/830440211208732752/abyss_yellow7.png 09:52:56 <13Sastreii> https://cdn.discordapp.com/attachments/747522859361894521/830440213263286292/abyss_brown7.png 10:01:16 <12ebering> Oof, I'd never noticed. (I am a console player and when I'm working on the UI side I'm mostly working on improvements for low-vision players) 10:09:13 -!- tiobot is now known as Guest96093 10:21:03 I am browsing pull requests in the crawl github but I can't seem to find some pull requests of rather big changes. 10:22:05 Not every change has a corresponding pull request 10:22:15 So how is it merged? 10:22:22 devteam members (those with commit access) are free to push changes directly to master 10:23:24 lol 10:23:53 What a peculiar choice 10:29:15 * Pinkbeast blinks 11:05:58 Still, that did remind me to stick a fact or two into their A0 reddit thread 11:24:25 CPTANT: older article but still relevant: https://www.rockpapershotgun.com/making-dungeon-crawl-stone-soup-with-253-cooks-and-no-head-chef 11:25:35 they paarted the channel 12:04:04 <10PleasingFungus> need to send a !tell, i suppose 🙂 12:35:30 03advil02 07* 0.27-a0-932-g94b7631: Fix a Na mutation physiology check 10(5 minutes ago, 1 file, 3+ 3-) 13https://github.com/crawl/crawl/commit/94b7631ddb6d 12:42:01 -!- amalloy_ is now known as amalloy 12:47:00 Unstable branch on crawl.kelbi.org updated to: 0.27-a0-932-g94b7631ddb (34) 13:28:48 Unstable branch on crawl.akrasiac.org updated to: 0.27-a0-932-g94b7631 (34) 13:52:36 03ebering02 07* 0.27-a0-933-g9aecc56: Implement petrified trees 10(2 hours ago, 30 files, 105+ 63-) 13https://github.com/crawl/crawl/commit/9aecc562e69b 13:52:36 03ebering02 07* 0.27-a0-934-g68d955c: Generalize the dead tree description 10(72 minutes ago, 1 file, 1+ 2-) 13https://github.com/crawl/crawl/commit/68d955cad3f1 13:52:36 03ebering02 07* 0.27-a0-935-g97c99b9: A petrified tree ecumenical altar 10(56 minutes ago, 1 file, 17+ 0-) 13https://github.com/crawl/crawl/commit/97c99b9d80fb 13:52:36 03ebering02 07* 0.27-a0-936-ga5483dd: Some petrified tree ruins for the desolation 10(19 minutes ago, 1 file, 85+ 1-) 13https://github.com/crawl/crawl/commit/a5483dda3608 13:53:16 <12ebering> I perhaps got carried away making petrified trees appear on t 13:53:37 <12ebering> I blame @PleasingFungus 13:54:33 <10PleasingFungus> heh heh heh 13:56:26 03PleasingFungus02 07* 0.27-a0-937-g420bc24: Re-tweak dead tree description 10(40 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/420bc2496c6e 14:18:03 Unstable branch on crawl.kelbi.org updated to: 0.27-a0-937-g420bc2496c (34) 14:23:43 <13Sastreii> in the meantime, i've tried to revamp Erek-dunno how to write it 14:23:44 <13Sastreii> https://cdn.discordapp.com/attachments/747522859361894521/830508359153090650/erek.png 14:24:16 <13Sastreii> always maintaining the original design bc it's cool 14:27:09 <13Sastreii> (i got inspired by the final boss of metal slug 5 too) 14:29:31 <10PleasingFungus> ereshkigal 14:29:46 <10PleasingFungus> https://en.wikipedia.org/wiki/Ereshkigal 14:30:14 <10PleasingFungus> big fan of the star sparklse 14:30:26 <06advil> and owl friends 14:32:11 <06advil> fr Erishkigal -> 𒀭𒊩𒌆𒆠𒃲 14:33:55 <10PleasingFungus> wow 14:35:58 I can't see what advil's emoji is in irc nor discord 14:36:05 do I need the DLC to view it? 14:36:12 <06advil> 2021 may suck but we finally can type cuneiform whenever we want* * irc results may vary 14:36:20 <06advil> haha or discord results too I guess 14:36:52 ...but I'm on linux...the world's most advanced OS... 14:38:02 <06advil> big sur ftw 14:38:02 <06advil> actually my old mac irc client has it too so it's probably just a matter of how completionist the font is 14:38:02 <06advil> do you see the cuneiform in your browser in that wikipedia entry? I just pasted that 14:38:18 <13Sastreii> i'm seeing empty blocks too lol 14:38:44 advil: Sadly no, just those unicode squares 14:38:50 <06advil> rip 14:38:56 <06advil> my optimism about 2021 was misplaced 14:40:16 <06advil> https://cdn.discordapp.com/attachments/747522859361894521/830512523790647367/Screen_Shot_2021-04-10_at_2.39.21_PM.png 14:41:05 that's neat 14:42:08 <06advil> @PleasingFungus I'm a bit worried about this, I added that assert because as far as I can see the code can loop infinitely if wrapcol is 2 or 1; how were you triggering it? 14:42:19 <06advil> to trigger it with wrapcol 2 you do need widechars 14:43:54 <06advil> er, wrapcol 1 14:43:57 <06advil> that whole thing is a bunch of off by 1 pitfalls 14:43:59 <10PleasingFungus> any time i started the game and loaded any save, it would crash with this error 14:44:06 <10PleasingFungus> that includes older and newer saves 14:44:10 <10PleasingFungus> offline, tiles, fulldebug 14:44:22 <06advil> well, needless to say that did not happen to me 🙂 14:44:30 <10PleasingFungus> it made development very annoying 14:44:31 <06advil> did you have a stack trace? 14:44:39 <10PleasingFungus> https://discord.com/channels/735056636644687913/747522859361894521/830292242375639050 14:44:52 <10PleasingFungus> should be pretty trivial for me to repro it again if you want more info 14:47:36 <06advil> hm, definitely something very odd going on there, not sure why it's only happening for you 14:49:44 <06advil> by fulldebug do you mean console fulldebug? 14:50:13 <10PleasingFungus> no, i mean tiles 14:50:57 <10PleasingFungus> make TILES=y FULLDEBUG=y -j=whatever 14:51:39 <|amethyst> @PleasingFungus Re your Ereshkigal FR, I have an even better one 14:51:41 <|amethyst> Cunei Form 14:51:49 <10PleasingFungus> not my fr, but a good fr 14:51:59 <|amethyst> oh, advil, sorry 14:52:00 <10PleasingFungus> also feels like a very nicolae fr 14:52:05 <|amethyst> I'm bad at reading 14:53:37 <06advil> hrm, in that code path the value of wrapcol is filled in by cgetsize(get_cursor_region()).x 14:56:34 <06advil> maybe something is different in tiles during game start 14:56:49 <10PleasingFungus> could be 15:42:20 <|amethyst> btw, is there a particular reason our catch2 tests use REQUIRE(...) instead of CHECK(...) ? 15:42:43 <06advil> my catch2 editing is 98% cargo cult 15:42:51 <|amethyst> also, why is everything tagged [single-file] 15:43:00 <|amethyst> oh, I guess that answers that question as well 15:43:18 <06advil> aidanh did most of the work of setting that up 15:44:04 <|amethyst> in my class I did a live-coding demo of TDD using catch2, which I thought was great fun 15:46:10 <|amethyst> given the recent line_reader bug (for which I apologise, because it was almost certainly my fault), I think that should be a target for some unit tests 15:46:27 <06advil> sounds good 15:46:40 <06advil> I have definitely worked on that code at some point in the past few years 15:48:11 <|amethyst> BTW, a question from my exam 3 or 4 weeks ago: 15:48:11 <|amethyst> he Dungeon Crawl: Stone Soup project does not, in general, use the Extreme Programming (XP) methodology. Identify at least three reasons that XP is not the best choice for the project as it currently stands, justifying your answers. Suggest at least two ways that the code and the project could be changed to better support Extreme Programming, and explain how those changes would make the XP 15:48:11 <|amethyst> methodology easier to apply to Crawl development. 15:48:11 <|amethyst> You may wish to refer to the Agile Alliance glossary page on Extreme ProgrammingLinks to an external site. download , especially but not exclusively the the "When Applicable" section. If you reference other Internet sources, be sure to cite them at the end of your response. 15:48:16 <|amethyst> sorry for the crappy paste 15:52:48 <|amethyst> Also, apparently catch2 has now moved to a 2-file solution (amalgamated header + amalgamated CPP file), though the tutorial has (other that the first couple of paragraphs) not been updated to reflect that 15:54:01 <|amethyst> I guess we should upgrade at some point 16:14:13 03ebering02 07* 0.27-a0-938-g1b49dfe: Trade Ice Beast for Metabolic Englaciation in the IE Start (Nomi) 10(17 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/1b49dfe8c25f 16:16:56 Unstable branch on crawl.kelbi.org updated to: 0.27-a0-938-g1b49dfe8c2 (34) 16:23:56 <|amethyst> well, there goes my only method for dealing with hostile ice beasts as an IE 16:26:18 New branch created: pull/1892 (1 commit) 13https://github.com/crawl/crawl/pull/1892 16:26:18 03robertxgray02 07https://github.com/crawl/crawl/pull/1892 * 0.27-a0-860-gcd0a0e9: Update Android build scripts 10(26 hours ago, 47 files, 530+ 1353-) 13https://github.com/crawl/crawl/commit/cd0a0e9ae05b 16:28:07 <05kate> oh i wonder if hailstorm should lose the thing where it doesn't affect icy creatures, that was basically just a special exception so that it would work alongside summon ice beast 16:28:34 <05kate> it'd be more consistent for it to just deal proper icicle-flavoured damage across the board 16:29:22 <|amethyst> kate-: I mean, before that commit I'd prefer it not to affect friendlies, but if IE doesn't get SIB by default, that sounds like a good improvement 16:32:25 <08wormsofcan> can't wait for some metabolic englaciatino buffs 16:32:55 <05kate> yeah, i think it was an okay exception before, but with ice beast no longer in the starting book i think it'd be clearer for it to just work on everything 16:34:19 <05kate> does mean we'd tragically lose the potential rare message "The ice statue dances in the hail." 16:35:32 wow, that is a sick rare message 16:58:53 03|amethyst02 07* 0.27-a0-939-g8328ce2: Avoid a "no previous declaration" warning when building tests 10(28 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/8328ce2b0669 16:58:53 03|amethyst02 07* 0.27-a0-940-g8df42ad: Add basic unit tests for comma_separated_line and join_strings 10(27 minutes ago, 2 files, 28+ 0-) 13https://github.com/crawl/crawl/commit/8df42ad0ea23 17:02:01 Unstable branch on crawl.kelbi.org updated to: 0.27-a0-940-g8df42ad0ea (34) 17:07:19 <|amethyst> Want to use TEMPLATE_PRODUCT_TEST_CASE to also try different commas and "and"s, but I'm not sure how to access the individual template parameters to build the compared-against strings 17:08:02 <|amethyst> also, not sure how I missed it before, but do we seriously not use the Oxford comma? 17:09:23 <|amethyst> I'd like to thank my parents, Ayn Rand and God 17:13:51 04Build failed for 08master @ 8df42ad0 06https://github.com/crawl/crawl/actions/runs/736717182 17:16:00 03|amethyst02 07* 0.27-a0-941-g386ccf3: Checkwhite (doh) 10(58 seconds ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/386ccf399c1c 17:22:14 03AlexanderPosch02 07https://github.com/crawl/crawl/pull/1885 * 0.27-a0-919-gc05c376: Remove check if reflected beam is in los-radius & remove +1 reflection bonus for Kobolds 10(11 minutes ago, 1 file, 1+ 12-) 13https://github.com/crawl/crawl/commit/c05c3768a8fd 17:22:14 03AlexanderPosch02 07https://github.com/crawl/crawl/pull/1885 * 0.27-a0-920-gbfc6f07: Whitespace and unbrace 10(3 minutes ago, 1 file, 3+ 1-) 13https://github.com/crawl/crawl/commit/bfc6f0796132 17:31:52 Unstable branch on crawl.kelbi.org updated to: 0.27-a0-941-g386ccf399c (34) 17:32:44 <|amethyst> comments and other docs tend to use it, so I'm tempted to change comma_separated_fn accordingly 17:34:13 <|amethyst> but I guess there are instances of things like comma_separated_line(begin(foo), end(foo), ", ", ", "), so that would require actual work... 17:39:46 New branch created: pull/1893 (2 commits) 13https://github.com/crawl/crawl/pull/1893 17:39:46 03MinticePIU02 {GitHub} 07https://github.com/crawl/crawl/pull/1893 * 0.27-a0-942-ga6952ad: Update status.txt 10(8 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/a6952adc839f 17:39:46 03MinticePIU02 {GitHub} 07https://github.com/crawl/crawl/pull/1893 * 0.27-a0-943-g0ae4a03: Merge pull request #1 from MinticePIU/MinticePIU-nomoreskilldrain 10(7 minutes ago, 0 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/0ae4a0392c5d 17:40:47 <|amethyst> kate-: wow, despite having played a bunch of IEs post-Frozen-Ramparts, I have never seen that messsage 17:40:53 <|amethyst> or at least never noticed it 17:44:23 <|amethyst> BTW, I asked PF about this previously, but does anyone want to give a talk to my software engineering class? 17:45:01 <|amethyst> MW 4:00-5:15 US Eastern time (UTC -4 during the summer) 17:45:54 <06advil> I can't commit to anything new right now 😦 17:45:54 <06advil> oh also that overlaps with my class time too 17:45:54 <|amethyst> oh? class? 17:45:54 <|amethyst> are you teaching? 17:45:54 <06advil> I am 17:45:54 <|amethyst> what? 17:45:54 <06advil> nothing related to any of this 17:46:03 <06advil> my ugrad class a freshman seminar on language and advertising 17:46:27 <|amethyst> linguistics dept., or communication, or something else? 17:46:36 <06advil> cognitive science 17:46:41 <|amethyst> nice 17:46:53 <06advil> I'm also co-teaching a CS/CogSci grad class on natural language understanding oriented at event and relation extraction! 17:47:36 <|amethyst> my uni doesn't have a cogsci major/program, but there is a minor at least 17:47:48 <06advil> it's pretty rare to have a full on major 17:47:55 <06advil> we sort of have it instead of a linguistics program 17:48:02 <|amethyst> considered taking that as an undergrad O these many decades ago, but I was running out of time and schedule slots 17:49:18 <|amethyst> If computer science hadn't been a thing, I'd have probably majored in linguistics 17:49:34 <|amethyst> still disappointed that I didn't at least try for a minor 17:50:06 <06advil> well, there's only so many things that can be done 17:50:11 <06advil> I did both but I took 5 years 17:51:44 <|amethyst> I did take a Sanskrit class from the Linguistics department, co-taught by a linguistics prof (who made the class around 40% about PIE) and a maths prof (who was Indian and learned Sanskrit as part of his education, and whom I had also had for Abstract Algebra) 17:51:57 <06advil> sounds fun 17:52:15 <06advil> I audited a sanskrit class at one point but didn't really get much out of it, you gotta do the work for that kind of thing 17:52:26 <|amethyst> yeah 17:52:44 <|amethyst> we had to memorise a Sanskrit passage (of our choice) 17:53:00 <|amethyst> I chose the one that Oppenheimer poorly translated 17:54:35 <|amethyst> Mrtyuh sarva-harvascaham udbhavasca bhavisyatam etc etc 17:56:22 <06advil> do you still have it? 17:56:31 <|amethyst> ? 17:56:44 <06advil> do you still remember the whole thing? 17:57:35 <|amethyst> Only those two lines 17:57:35 <|amethyst> I memorized around 8, but only remember those two 17:58:09 <|amethyst> I also forgot nearly all of the devanagari I learned 17:58:47 <06advil> yeah, does seem like something that needs continual practice 17:59:04 <06advil> the dead language I spent some time on was old irish, and I have very little active memory of it 17:59:11 <|amethyst> oh, nice 17:59:29 <06advil> every once in a while I pick up the grammar and look at it (though it's in my office that I haven't been to since august, rip) 18:00:06 <|amethyst> I I did visit the Gaeltacht once, but my Irish is pretty much nonexistant, let alone my Old Irish 18:00:29 <06advil> old irish, it turns it, is not extremely helpful for modern irish 18:00:39 <|amethyst> it was kind of cool, though, to see bilingual street signs etc. in Limerick 18:00:55 <|amethyst> (which is very much not in the Gaeltacht) 18:01:31 <06advil> heh 18:15:13 <|amethyst> someone will have to remind me... what do I need to do so that "git fetch origin" fetches pull requests too? 18:15:52 <|amethyst> currently it gets old gitorious merge requests, but not github PRs 18:20:40 New branch created: pull/1894 (16 commits) 13https://github.com/crawl/crawl/pull/1894 18:20:42 03mgdelmonte02 07https://github.com/crawl/crawl/pull/1894 * 0.26-a0-611-gaaad8d9: fixing weapon subtype 10(7 months ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/aaad8d975419 18:20:42 03mgdelmonte02 07https://github.com/crawl/crawl/pull/1894 * 0.26-a0-635-g48fe345: Merge remote-tracking branch 'upstream/master' 10(7 months ago, 0 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/48fe345468df 18:20:42 03mgdelmonte02 07https://github.com/crawl/crawl/pull/1894 * 0.26-a0-636-g37e7bad: added c_message hook 10(7 months ago, 2 files, 9+ 0-) 13https://github.com/crawl/crawl/commit/37e7bad09d32 18:20:42 03mgdelmonte02 07https://github.com/crawl/crawl/pull/1894 * 0.26-a0-637-g827209d: better to hook after muting 10(7 months ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/827209d36604 18:20:42 03mgdelmonte02 07https://github.com/crawl/crawl/pull/1894 * 0.26-a0-668-g8680f2d: Merge remote-tracking branch 'upstream/master' 10(6 months ago, 0 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/8680f2d77dab 18:20:42 03mgdelmonte02 07https://github.com/crawl/crawl/pull/1894 * 0.26-a0-1059-gceb1e6d: Merge remote-tracking branch 'upstream/master' 10(4 months ago, 0 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/ceb1e6d70423 18:20:42 03mgdelmonte02 07https://github.com/crawl/crawl/pull/1894 * 0.27-a0-47-gc8fb07d: merge 10(3 months ago, 0 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/c8fb07d2d5b7 18:20:42 03mgdelmonte02 07https://github.com/crawl/crawl/pull/1894 * 0.27-a0-81-gfe4a5ac: Merge remote-tracking branch 'upstream/master' 10(3 months ago, 0 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/fe4a5ac0c8c3 18:20:42 03mgdelmonte02 07https://github.com/crawl/crawl/pull/1894 * 0.27-a0-87-ge38b3b4: Merge remote-tracking branch 'upstream/master' 10(3 months ago, 0 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/e38b3b41323c 18:20:42 03mgdelmonte02 07https://github.com/crawl/crawl/pull/1894 * 0.27-a0-101-g060870a: Merge remote-tracking branch 'upstream/master' 10(3 months ago, 0 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/060870a63989 18:20:42 ... and 6 more commits 18:20:57 <06advil> PRs are in the submitter's repo unless they are based on a devteam local branch, so you will have to fetch that 18:21:01 <06advil> there's a merge based workflow for doing it that you can just copy from the PR page itself on github, but I prefer a rebase-based workflow that I've documented here: https://gist.github.com/rawlins/dcd19d7156e83ea3d1e0e1e2617988e8 18:21:11 <06advil> it's extremely possible that there could be better ways 18:21:40 |amethyst: https://gist.github.com/piscisaureus/3342247 18:22:06 PRs live in the submitter repo, but the owner repo gets a ref pointing to them as well 18:23:00 [remote "origin"] url = https://github.com/crawl/crawl.git fetch = +refs/heads/*:refs/remotes/origin/* fetch = +refs/pull/*:refs/remotes/origin/pull/* 18:23:00 Unstable branch on underhound.eu updated to: 0.27-a0-941-g386ccf399c (34) 18:23:10 |amethyst: what I have, with proper newlines 18:23:25 that second fetch gets the pull request refs 18:23:28 <|amethyst> amalloy: gammafunk: excellent, many thanks! 18:23:39 then origin/pull/NUMBER/head is what I usually check out 18:23:49 not sure about the use case for origin/pull/NUMBER/merge 18:24:05 which is another branch that exists for those 18:24:30 <|amethyst> getting a few errors about submodules, but that did work 18:24:48 need a `git submodule update' ? 18:25:03 <06advil> there are recent submodule changes 18:25:07 <|amethyst> claims to be up-to-date 18:25:24 <|amethyst> I suspect that's because some of the old PRs have older submodule versions 18:25:49 How are people doing command-line pushes authentication-wise these days? 18:26:31 03mgdelmonte02 07https://github.com/crawl/crawl/pull/1894 * 0.27-a0-949-g5c98062: added item.description 10(6 minutes ago, 3 files, 18+ 2-) 13https://github.com/crawl/crawl/commit/5c9806268edf 18:26:48 I'm pushing to https and typing username/pw, but github has been warning me this will go away 18:26:48 not sure if I should set up ssh urls and use ssh keys or what 18:27:37 <10PleasingFungus> gammafunk: ssh is your friend 18:27:44 <06advil> I have a one-time pw thing per device that is just saved in ~/.git-credentials 18:27:52 <|amethyst> gammafunk: git remote set-url --push origin ssh://git@github.com// (after adding a pubkey to your account) 18:28:47 <|amethyst> spent like half a class meeting on this in fact 18:28:49 <06advil> by one-time pw in their terminology I mean "personal access token" 18:29:27 <|amethyst> (I have not set up 2FA, because I don't want to depend on my phone that much) 18:30:53 <06advil> ah in fact it appears that personal access tokens are one of the intended replacement things for passwords once those go away 18:30:55 yeah, ok, thanks all; I do use 2FA a lot already, so maybe I can use that, otherwise I'll just set up ssh 18:31:12 <06advil> if you generate a token you can just use it where you currently would a password 18:31:28 I assume you don't have to generate those but every so often (per-device)? 18:31:46 I can read the github docs 18:32:38 <06advil> yeah, you can refresh them if you want but they are generated sporadically 18:32:38 <06advil> they also can be set with much more restricted permissions vs password 18:32:38 <06advil> it's the sort of thing where github only lets you view them once, but you can make as many as you want 18:33:43 <06advil> "For developers, if you are using a password to authenticate Git operations with GitHub.com today, you must begin using a personal access token over HTTPS (recommended) or SSH key by August 13, 2021, to avoid disruption." 18:35:12 <10PleasingFungus> using a personal access token without a hardware key sounds crummy 18:35:18 <10PleasingFungus> for git 18:37:34 <06advil> how so? 18:38:29 <06advil> I mean, it's expected that you cache them 18:39:29 <|amethyst> btw, since I just logged into github for the first time in a bit, what's this "Codespaces" thing? Is it just VS Code in the browser? 18:42:38 <10PleasingFungus> how long can you cache them for? tbqh i’ve never used them 18:44:42 I assume you can use either your phone or 2FA desktop app both to verify the 2FA 18:45:31 but as long as it allows caching in a reasonable way, like 30 days at least, should be ok 18:46:09 that's how discord and twitch 2FA work, at least 18:50:25 03kate-02 07* 0.27-a0-942-g7a51355: Make Hailstorm affect icy creatures 10(2 hours ago, 2 files, 6+ 22-) 13https://github.com/crawl/crawl/commit/7a5135572456 18:50:25 03kate-02 07* 0.27-a0-943-g91442b7: Tweak Cigotuvi's embrace description 10(10 minutes ago, 1 file, 5+ 5-) 13https://github.com/crawl/crawl/commit/91442b771cb9 18:50:25 03kate-02 07* 0.27-a0-944-gf450e38: Update Shadow form status description (Mintice) 10(9 minutes ago, 1 file, 5+ 5-) 13https://github.com/crawl/crawl/commit/f450e38dac88 18:51:06 <06advil> I'm not very sure, maybe they don't time out at all? I don't remember changing them very much, possibly I'm being insecure 18:51:23 <06advil> though they're stored about as securely as my ssh privkey is, except way more ephemeral (easily revocable, limited to providing repo access only) 18:52:58 <10PleasingFungus> hm 18:52:59 <10PleasingFungus> interesting 18:53:04 <10PleasingFungus> i have a lot to learn, clearly 18:53:11 about gnomes, I agree 18:53:15 but so do we all 19:02:51 Unstable branch on crawl.kelbi.org updated to: 0.27-a0-944-gf450e38dac (34) 19:13:27 <05kate> hmm, i wonder how silly this infinite rampaging idea ends up being 19:13:33 <05kate> b - the +3 pair of seven-league boots (worn) {Rampage+∞} 19:14:34 <10PleasingFungus> ooh 19:14:34 <10PleasingFungus> i'm into it personally 19:16:32 it's no boots of the spider, but 19:16:34 <05kate> i guess the main concern would be it working with stabs 19:17:27 <05kate> which rampaging currently does by default, so that would maybe get a bit ridiculous at full los 19:18:30 <05kate> could steal the palentonga thing and have it be slightly noisy when it activates 19:20:25 <10PleasingFungus> theft is fun 19:21:03 <|amethyst> I assume that is "move as much as necessary in a single direction" 19:22:13 <|amethyst> in which case, doesn't that run up against the same problems as old Searing Ray? 19:24:54 <05kate> hmm true, if you mean in terms of only working in the cardinal directions? (although that's also true of regular rampaging) 19:25:04 <|amethyst> yeah 19:26:16 <05kate> it does definitely exaggerate that issue a lot though, yeah 19:26:16 <|amethyst> not that I mind, but when I complained about the SR change, that was the counterargument 19:28:26 03gammafunk02 07* 0.27-a0-945-g5e7b979: Reorganize shoals.des 10(25 hours ago, 1 file, 316+ 320-) 13https://github.com/crawl/crawl/commit/5e7b9793158c 19:28:26 03gammafunk02 07* 0.27-a0-946-g0e2820b: Cleanups for spider.des 10(25 hours ago, 1 file, 11+ 11-) 13https://github.com/crawl/crawl/commit/0e2820b0bfc8 19:28:26 03gammafunk02 07* 0.27-a0-947-g57c748b: Cleanups for snake.des 10(24 hours ago, 1 file, 440+ 459-) 13https://github.com/crawl/crawl/commit/57c748b47e79 19:28:26 03gammafunk02 07* 0.27-a0-948-gec3affb: Some Snake vault revamps 10(20 hours ago, 1 file, 70+ 60-) 13https://github.com/crawl/crawl/commit/ec3affb84e7c 19:29:06 <05kate> yeah, i do think it's not ideal, but maybe as an unrand it can get away with being a bit weird in that regard 19:29:06 <|amethyst> true 19:29:18 <|amethyst> alternatively, adding an (a)bility could work 19:31:53 Unstable branch on crawl.kelbi.org updated to: 0.27-a0-948-gec3affb84e (34) 19:33:24 <|amethyst> gammafunk: btw, why no lava snakes in snake.des? I mean, they're not exactly powerful, but they do seem thematic for the lava endings 19:35:50 <|amethyst> gammafunk: and they're not all that likely to be seen otherwise 19:36:43 Was !cancellation looking grey when it'd have no effect changed? Because if no, then there is a bug. 19:37:18 |amethyst: I want to remove those from snake generation because they're just too weak 19:37:27 they mostly find usage in earlier thematic vaults and volcanoes 19:37:40 they're just pretty flimsy and don't do a lot of damage for Snake depth 19:37:44 @??lava snake 19:37:45 lava snake (04S) | Spd: 10 | HD: 3 | HP: 13-20 | AC/EV: 2/17 | Dam: 704(fire:3-5) | Res: 06will(10), 04fire+++ | Vul: 12cold | Corpse | XP: 48 | Sp: spit lava (3d10) [11!AM, 06!sil, 08breath] | Sz: small | Int: animal. 19:37:53 hd:3 19:38:17 <|amethyst> true 19:38:33 <|amethyst> maybe they should appear in D or Lair more often 19:38:40 yeah 19:38:54 lava is rare in both places, would need more vaults placing them 19:38:58 <|amethyst> yeah 19:39:12 <|amethyst> 3d10 spit lava is not exactly trivial though 19:39:13 <10PleasingFungus> how about this: lava serpents 19:39:24 <10PleasingFungus> like lava snakes... but bigger 19:39:45 3d10 lava spit would be ok as a salamander breath attack, yeah 19:39:52 @??electric eel 19:39:53 electric eel (12;) | Spd: 10 | HD: 3 | HP: 13-20 | AC/EV: 1/15 | cold-blooded | Res: 06will(10), 11elec+++, 12drown | Corpse | XP: 53 | Sp: b.electrical (3d6) [11!AM, 06!sil] | Sz: small | Int: animal. 19:40:48 those actually do less and are water spawns in lair branches, but they're another thing I don't like being used that late 19:40:48 basically I think we need better scaling for lava and water-bound monsters 19:40:56 <|amethyst> I am trying to come up with a terrible pun involving "ophidian", but it's not working 19:41:04 it's like electric eel -> lava snake (both quite weak) ... kraken 19:41:35 although another route is not use water-bound monsters, and let water and lava generating monsters leave their terrain 19:41:39 like salamanders, swamp worms, etc 19:42:32 but yeah, as far as mostly flavor monsters go, lava snakes are ok-ish for snake, but would prefer use of salamander mosnters and deffo draw the line at using e.g. adders, ball pythons 19:42:32 <|amethyst> yeah, being tightly terrain-bound seems like the biggest problem 19:43:35 <|amethyst> electric eels outside of water seems a little weird flavour-wise, but not so much lava snakes, since they're not based on anything real-world 19:43:51 <|amethyst> (not that real-world electric eels spit lightning...) 19:43:56 <10PleasingFungus> i still want krakens to shoot fireballs like in that ridiculous dcss-tileset-based fps 19:44:02 <10PleasingFungus> that absolutely ruled 19:44:29 well I had a terrible lava snake infestation in my backyard volcano once, hugely inconvenient and expensive to call in a lava pest specialist 19:45:18 a two-phased kraken fps fight 19:47:15 <|amethyst> https://i.redd.it/t8lxrrgecmy41.png FR: sand kraken 19:48:46 powerful shark tile 19:49:00 or is it...a dolphin? 19:49:20 lol does it really sell for $50 19:49:41 <|amethyst> it's a class, so that's not *that* outrageous 19:51:38 as long as they don't charge you an arm and a leg for the textbook and it turns out it's just the crawl manual 19:55:08 <|amethyst> We should charge for docs/develop/* and for the "philosophy" section of the manual 19:55:44 <10PleasingFungus> crawl used that tile as a shark! 19:55:50 <10PleasingFungus> but it does look a lot like a dolphin 19:55:51 <10PleasingFungus> so who can say 19:57:07 <|amethyst> David Attenborough, that's who 19:58:20 <|amethyst> "Here we have the humble quokka, which is distinguished by its rapid movement" 20:00:51 it really looks to me like it's walking on it's back two fins 20:01:41 <|amethyst> "Candygram" 20:19:02 𒀭𒊩𒌆𒆠𒃲 20:23:31 <06advil> wonder what a good workflow would be for testing (to the extent we can) those android PRs 20:27:34 <06advil> most of it looks non-relevant to normal crawl or innocuous, but I guess the lua version bump is the main thing 21:22:46 <10PleasingFungus> hrm 21:22:54 <10PleasingFungus> i'm failing to set a new DEFINE via the command line 21:24:17 <10PleasingFungus> make -j8 TILES=Y FULLDEBUG=y CHAOS_CRAWL=Y doesn't result in code with #ifdef CHAOS_CRAWL being compiled 21:24:30 <10PleasingFungus> feels like i'm missing something obvious 21:26:03 <08nicolae> agreed, i also agree with the fr 21:26:36 <08nicolae> i think they have englaciatinos at crawlbucks 21:27:54 <08nicolae> i love it, imo crawl needs more unrand boots 21:28:54 <08nicolae> obsidian ophidian, although that's more of a rhyme than a pun 21:29:25 <10PleasingFungus> it's fun though 21:29:43 <08nicolae> also the recent discussion re: ditching lava snakes from snake is going to mess up a couple of my works in progress 😔 21:31:04 Really fire in your ally the briar patch's direction? 13https://crawl.develz.org/mantis/view.php?id=12558 by Yermak 21:31:55 <10PleasingFungus> noo 21:32:15 <08nicolae> eh, i'd already submitted a few vaults for spider that had ants and then they cut ants 21:32:39 <10PleasingFungus> need to get hellmonk to actually make those new spider monsters 21:34:11 <08nicolae> agreedeaux 21:37:46 <06advil> I don't know what chaos crawl is but from the cl to force a #define wouldn't you want EXTERNAL_DEFINES="-DCHAOS_CRAWL"? 21:37:46 <06advil> unless there is specifically custom Makefile code somewhere that translates CHAOS_CRAWL=y into -DCHAOS_CRAWL 21:37:58 <10PleasingFungus> hm, sounds plausible 21:38:02 <10PleasingFungus> i've never worked with external defines before 21:38:06 <10PleasingFungus> i'll try that now 21:38:27 <06advil> I added a note to the Makefile about how to do this recently when documenting the versioned cache option 21:38:37 <10PleasingFungus> the makefile is very long 😦 21:38:52 <10PleasingFungus> i did look 21:42:01 <06advil> for things like WEBTILES=y there is code that specifically sets up the defines, e.g. ifdef WEBTILES DEFINES_L += -DUSE_TILE DEFINES_L += -DUSE_TILE_WEB endif, so if whatever CHAOS_CRAWL is is going to be used a lot you could consider adding that 21:42:14 <10PleasingFungus> it is very unlikely that it will be used a lot 21:42:23 <10PleasingFungus> i'm dusting off an extremely antique april fool's branch 21:42:24 <10PleasingFungus> by popular demand 21:45:17 -!- mhcerri_ is now known as mhcerri 21:55:38 <08nicolae> which one 21:58:00 <10PleasingFungus> chaoscrawl! 22:48:37 the best april fools prank comes two weeks late so nobody's expecting it 22:51:41 march, fools! 23:50:55 03PleasingFungus02 07[chaoscrawl] * 0.27-a0-942-g1216cdb: Chaoscrawl 10(5 years ago, 10 files, 168+ 21-) 13https://github.com/crawl/crawl/commit/1216cdbe5edf 23:50:55 03PleasingFungus02 07[chaoscrawl] * 0.27-a0-943-g6c63041: WIP: use mi instead of direct monster pronoun/name 10(7 minutes ago, 8 files, 56+ 35-) 13https://github.com/crawl/crawl/commit/6c6304177302 23:51:41 <10PleasingFungus> hm, this was a huge pain in the butt 23:51:41 <10PleasingFungus> didn't expect that 23:51:41 <10PleasingFungus> anyway, mostly works but anything that calls monster::name or monster::pronoun is wrong 23:51:41 <10PleasingFungus> which is very annoying 23:51:41 <10PleasingFungus> i'm not 100% convinced those functions should exist even in mainline, though i can see arguments either way 23:51:41 <10PleasingFungus> hrm 23:51:44 <10PleasingFungus> maybe i'll do a hack 23:52:21 <10PleasingFungus> oh, no, i see how to fix this in a better way 23:54:59 <10PleasingFungus> monster::name is actually fine, thankfully 23:55:16 <08wormsofcan> You gouge Harold!! You devour Harold! You feel better. You kill Harold! Harold groans, "My... family..." and then collapses, dead. 23:55:19 <08wormsofcan> nice message ordering 23:55:25 <10PleasingFungus> classic 23:55:37 <10PleasingFungus> reverse polish death wails 23:59:21 03PleasingFungus02 07[chaoscrawl] * 0.27-a0-944-g578a34e: Fix pronouns better 10(75 seconds ago, 9 files, 39+ 63-) 13https://github.com/crawl/crawl/commit/578a34ee42c0