01:34:32 <Gretell> Unstable branch on crawl.develz.org updated to: 0.27-a0-3-gcf006a40f5 (34)
01:55:24 <Gretell> Windows builds of master branch on crawl.develz.org updated to: 0.27-a0-3-gcf006a40f5
02:36:53 <Cbrotell> Unstable branch on cbro.berotato.org updated to: 0.27-a0-3-gcf006a40f5 (34)
02:53:35 <Gretell> Monster database of master branch on crawl.develz.org updated to: 0.27-a0-3-gcf006a40f5
03:08:20 <wheals> !tell |amethyst can you add 0.26 to cao?
03:08:21 <Sequell> wheals: OK, I'll let |amethyst know.
03:08:56 <wheals> advil: and can you add it to cbr2?
03:30:51 <Kelbell> Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-3840-g9efd504fd6
03:32:42 <Kelbell> Fork (bcadrencrawl) on crawl.kelbi.org updated to: 0.03-79-gce8861502e
05:41:58 -!- amalloy is now known as amalloy_
12:02:17 <Discord|> <10P​leasingFungus> the mysterious throw_2 parameter in throw_it dates back to before the creation of the git repo
12:02:22 <Discord|> <10P​leasingFungus> is this what they call 'legacy code'...
12:03:59 <Discord|> <12e​bering> throw_2
12:04:02 <Discord|> <12e​bering> throw_3
12:04:05 <Discord|> <12e​bering> throw_red
12:04:07 <Discord|> <12e​bering> throw_blue
12:04:19 <Cheibriados> 03PleasingFungus02 07* 0.27-a0-4-gd0772db: Remove an unused parameter 10(6 minutes ago, 2 files, 5+ 8-) 13https://github.com/crawl/crawl/commit/d0772dbefd8c
12:04:19 <Cheibriados> 03PleasingFungus02 07* 0.27-a0-5-gf342683: Rename a mysterious 15-year-old variable 10(20 seconds ago, 1 file, 5+ 5-) 13https://github.com/crawl/crawl/commit/f34268347508
12:06:25 <Henzell> Unstable branch on crawl.akrasiac.org updated to: 0.27-a0-3-gcf006a4 (34)
12:13:17 <Discord|> <10P​leasingFungus> (i'll cherry-pick these back to 0.26 in a bit)
12:18:49 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.27-a0-5-gf342683475 (34)
12:19:39 <Aliscans_> PleasingFungus: throw_2 dates back to before Stone Soup. Back then, the comment at the start of the function actually made sense.
12:20:26 <Discord|> <10P​leasingFungus> huh, i just noticed that dummy_target does not actually exist
12:20:32 <Discord|> <10P​leasingFungus> good point
12:22:04 <Aliscans_> I'm not sure what mon-act:_mons_throw() was supposed to refer to, either.
12:22:24 <Discord|> <10P​leasingFungus> huh
12:23:50 <Discord|> <10P​leasingFungus> that function used to exist
12:23:57 <Discord|> <10P​leasingFungus> it was in mon-act.cc
12:24:06 <Discord|> <10P​leasingFungus> not sure when it ceased to exist
12:24:23 <Discord|> <10P​leasingFungus> or when it moved to throw.cc, rather
12:45:11 <Cheibriados> 03PleasingFungus02 07* 0.27-a0-6-ge5df516: Ban shift-dir pproj (12422) 10(3 minutes ago, 3 files, 22+ 8-) 13https://github.com/crawl/crawl/commit/e5df516c9939
12:50:55 <Cheibriados> 03PleasingFungus02 07* 0.27-a0-7-g2922b9e: More throwing code cleanup 10(53 seconds ago, 2 files, 11+ 20-) 13https://github.com/crawl/crawl/commit/2922b9e7433c
12:51:48 <Cheibriados> 03PleasingFungus02 07[stone_soup-0.26] * 0.26-b1-5-g63f240e: Remove an unused parameter 10(54 minutes ago, 2 files, 5+ 8-) 13https://github.com/crawl/crawl/commit/63f240e5e188
12:51:48 <Cheibriados> 03PleasingFungus02 07[stone_soup-0.26] * 0.26-b1-6-g22fb5e4: Rename a mysterious 15-year-old variable 10(48 minutes ago, 1 file, 5+ 5-) 13https://github.com/crawl/crawl/commit/22fb5e480d4b
12:51:48 <Cheibriados> 03PleasingFungus02 07[stone_soup-0.26] * 0.26-b1-7-g7367326: Ban shift-dir pproj (12422) 10(9 minutes ago, 3 files, 22+ 8-) 13https://github.com/crawl/crawl/commit/7367326e8aa1
12:51:48 <Cheibriados> 03PleasingFungus02 07[stone_soup-0.26] * 0.26-b1-8-ga3f0790: More throwing code cleanup 10(2 minutes ago, 2 files, 11+ 20-) 13https://github.com/crawl/crawl/commit/a3f0790d1816
12:52:17 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.27-a0-6-ge5df516c99 (34)
12:58:40 <Discord|> <10P​leasingFungus> huh, throw_2 predates throw_it
13:01:16 <Discord|> <10P​leasingFungus> seems to date to at least 2.7 (wasn't in 1.1)
13:01:53 <advil> > "we never pass a meaningful target in"
13:01:54 <advil> ???
13:02:27 <advil> sort of the opposite of correct :-)
13:03:01 <Cheibriados> bool actor::has_usable_tentacle() is pointless 13https://crawl.develz.org/mantis/view.php?id=12427 by bcadren
13:03:43 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.27-a0-7-g2922b9e743 (34)
13:04:01 <advil> in fact that's exactly the one use of that paradigm where it's more complicated because it always passes in a meaningful target
13:04:43 <advil> *more complicated than it needs to be
14:18:56 <Discord|> <10P​leasingFungus> advil: as far as I can tell, absolutely no information is passed in via target from throw_item_no_quiver to ammo_action::trigger or from there to throw_it. Information is passed back (specifically target.isCancel), but no information is passed in.
14:18:59 <Discord|> <10P​leasingFungus> Am I missing something?
14:19:16 <Discord|> <10P​leasingFungus>      // causes interactive targeting unless target was provided     dist target;     a->trigger(target);     if (target.isCancel)         canned_msg(MSG_OK);
14:20:11 <Discord|> <10P​leasingFungus> !source quiver.cc:694
14:20:12 <Discord|> <04C​erebot> https://github.com/crawl/crawl/blob/master/crawl-ref/source/quiver.cc#L694
14:21:13 <Discord|> <10P​leasingFungus> neither of these make any changes whatsoever to target. They pass in a default-initialized struct.
14:21:21 <Discord|> <10P​leasingFungus> Good use of 🙂 , however 🙂
14:27:54 <Cheibriados> 03PleasingFungus02 07* 0.27-a0-8-g18013ae: Remove unused variable (Mesh) 10(22 seconds ago, 1 file, 0+ 3-) 13https://github.com/crawl/crawl/commit/18013ae1f5cc
14:28:48 <Cheibriados> 03PleasingFungus02 07[stone_soup-0.26] * 0.26-b1-9-ge558b5c: Remove unused variable (Mesh) 10(76 seconds ago, 1 file, 0+ 3-) 13https://github.com/crawl/crawl/commit/e558b5cfc16d
14:32:16 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.27-a0-8-g18013ae1f5 (34)
14:40:44 <advil> PleasingFungus: you are indeed
14:41:54 <advil> target is non-default all over the place in calls to trigger
14:42:26 <Discord|> <10P​leasingFungus> oh, i think i see the misunderstanding
14:42:46 <Discord|> <10P​leasingFungus> by "never", i meant "never in any call to ammo_action::trigger or throw_it"
14:42:57 <Discord|> <10P​leasingFungus> I did not mean "never in any call to any ::trigger"
14:43:01 <Discord|> <10P​leasingFungus> does that clarify the situation?
14:43:05 <advil> no?
14:43:18 <Discord|> <10P​leasingFungus> hm, in that case i remain extremely confused
14:43:44 <Discord|> <10P​leasingFungus> can you please show me a codepath that leads to throw_it being passed a non-default target?
14:44:13 <advil> !source l-crawl.cc:451
14:44:14 <Sequell> https://github.com/crawl/crawl/blob/master/crawl-ref/source/l-crawl.cc#L451
14:44:37 <Discord|> <10P​leasingFungus> ah, polymorphism...
14:44:53 <advil> yeah, ammo_action isn't even exposed outside quiver.cc
14:45:25 <advil> !source autofight.lua:322
14:45:25 <Sequell> https://github.com/crawl/crawl/blob/master/crawl-ref/source/dat/clua/autofight.lua#L322
14:45:28 <Discord|> <10P​leasingFungus> sure, though ammo_to_action provides pretty similar results
14:46:27 <Discord|> <10P​leasingFungus> this code is quite complex...
14:46:47 <Discord|> <10P​leasingFungus> it would be nice if targeting was done consistently outside throw_it
14:47:23 <Discord|> <10P​leasingFungus> i suppose that means that you'd do it in throw_item_no_quiver and pass that through ammo_action::trigger
14:47:53 <Discord|> <10P​leasingFungus> rather than having throw_it sometimes prompt the player to target and sometimes use a pre-provided target
14:47:57 <Discord|> <10P​leasingFungus> hm, i wonder if i broke autofight
14:49:00 <Discord|> <10P​leasingFungus> doesn't look like it?
15:03:43 <advil> I'm not sure that would be simpler, the way targeting works in direction_chooser
15:03:50 <advil> one could try to refactor that more of course
15:39:52 <advil> re 63f240e, I think that should be reverted
15:40:07 <advil> the dist parameter isn't currently used but my intent was to add a lua function that uses it
15:41:04 <advil> also, I think you were misled by "causes interactive targeting unless target was provided"
15:41:30 <advil> maybe
16:03:51 <Cheibriados> 03advil02 07* 0.27-a0-9-g9262620: Simplify throw_it (PleasingFungus) 10(9 minutes ago, 3 files, 46+ 51-) 13https://github.com/crawl/crawl/commit/92626205c41e
16:03:51 <Cheibriados> 03advil02 07* 0.27-a0-10-gfb19f2a: Add lua support for targeted CMD_THROW_ITEM_NO_QUIVER 10(6 minutes ago, 3 files, 13+ 6-) 13https://github.com/crawl/crawl/commit/fb19f2a25f3a
16:06:39 <advil> for shift-aiming my instinct would be to target the first monster on the cardinal path
16:07:27 <Discord|> <10P​leasingFungus> i had a note about that in the commit comment
16:07:47 <Discord|> <10P​leasingFungus> it seemed like significantly more work for a feature that i sort of doubt anyone uses
16:07:50 <Discord|> <10P​leasingFungus> (because it never worked)
16:07:55 <Discord|> <10P​leasingFungus> but if you want it, go for it
16:08:14 <advil> did it not work when there was a monster in line?
16:08:25 <Discord|> <10P​leasingFungus> hm
16:08:34 <Discord|> <10P​leasingFungus> i don't think so but i could certainly be wrong
16:08:47 <advil> I had assumed from yermak's report that he was actually using it, but it might have just been a miskey
16:11:30 <Discord|> <10P​leasingFungus> fair
16:18:37 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.27-a0-10-gfb19f2a25f (34)
16:19:19 <Cheibriados> 03advil02 07* 0.27-a0-11-gc4307f1: Fix `F`+pproj logic (10804) 10(2 minutes ago, 1 file, 5+ 4-) 13https://github.com/crawl/crawl/commit/c4307f12cd2b
16:19:54 <advil> well, maybe I'll do it if I get to it
16:21:18 <Cheibriados> 03advil02 07[stone_soup-0.26] * 0.26-b1-10-g2f1f0d0: Simplify throw_it (PleasingFungus) 10(26 minutes ago, 3 files, 46+ 51-) 13https://github.com/crawl/crawl/commit/2f1f0d08ebb9
16:21:18 <Cheibriados> 03advil02 07[stone_soup-0.26] * 0.26-b1-11-g2c1537b: Add lua support for targeted CMD_THROW_ITEM_NO_QUIVER 10(23 minutes ago, 3 files, 13+ 6-) 13https://github.com/crawl/crawl/commit/2c1537b7304e
16:21:18 <Cheibriados> 03advil02 07[stone_soup-0.26] * 0.26-b1-12-g88165c4: Fix `F`+pproj logic (10804) 10(4 minutes ago, 1 file, 5+ 4-) 13https://github.com/crawl/crawl/commit/88165c4e8eed
16:31:59 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.27-a0-11-gc4307f12cd (34)
17:52:25 <Cheibriados> 03PleasingFungus02 07* 0.27-a0-12-g5dcdf96: Don't spawn 8 will-o-the-wisps in Lair (Goratrix) 10(42 seconds ago, 1 file, 4+ 4-) 13https://github.com/crawl/crawl/commit/5dcdf963e0b6
17:53:19 <Cheibriados> 03PleasingFungus02 07[stone_soup-0.26] * 0.26-b1-13-gc21e740: Don't spawn 8 will-o-the-wisps in Lair (Goratrix) 10(2 minutes ago, 1 file, 4+ 4-) 13https://github.com/crawl/crawl/commit/c21e7409c469
18:02:07 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.27-a0-12-g5dcdf963e0 (34)
18:23:22 <Cheibriados> New branch created: IDFA (1 commit) 13https://github.com/crawl/crawl/tree/IDFA
18:23:22 <Cheibriados> 03PleasingFungus02 07[IDFA] * 0.27-a0-13-ga0310fc: Give monsters infinite ammo 10(70 seconds ago, 3 files, 7+ 40-) 13https://github.com/crawl/crawl/commit/a0310fc7c357
18:24:03 <Lantell> Unstable branch on underhound.eu updated to: 0.27-a0-12-g5dcdf963e0 (34)
18:45:30 -!- amalloy_ is now known as amalloy
18:58:39 <Cheibriados> New branch created: los-hex-success-chances (6 commits) 13https://github.com/crawl/crawl/tree/los-hex-success-chances
18:58:39 <Cheibriados> 03ebering02 07[los-hex-success-chances] * 0.27-a0-4-ged63ef4: Rename a function for clarity 10(38 minutes ago, 3 files, 6+ 6-) 13https://github.com/crawl/crawl/commit/ed63ef442676
18:58:39 <Cheibriados> 03ebering02 07[los-hex-success-chances] * 0.27-a0-5-g9710f16: Refactor targeter_multiposition 10(32 minutes ago, 3 files, 50+ 29-) 13https://github.com/crawl/crawl/commit/9710f16717a1
18:58:39 <Cheibriados> 03ebering02 07[los-hex-success-chances] * 0.27-a0-6-g5838697: Fix a targeting information leak in Absolute Zero (12415) 10(27 minutes ago, 1 file, 9+ 6-) 13https://github.com/crawl/crawl/commit/583869744a13
18:58:39 <Cheibriados> 03ebering02 07[los-hex-success-chances] * 0.27-a0-7-g60eff70: Adjust Metabolic Englaciation 10(24 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/60eff7097be0
18:58:39 <Cheibriados> 03ebering02 07[los-hex-success-chances] * 0.27-a0-8-g8505477: Add detailed static targeters for LOS enchantments 10(23 minutes ago, 4 files, 188+ 18-) 13https://github.com/crawl/crawl/commit/850547751e41
18:58:39 <Cheibriados> 03ebering02 07[los-hex-success-chances] * 0.27-a0-9-g5d0d681: Allow static-targeter preview of Confusing Touch 10(13 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/5d0d6810460c
18:59:28 <ebering> If someone with more C++ guru experience could take a quick look at how I implemented the static targeters in this branch (in particular the constructors that intentionally interact with a virtual method)I'd appreciate it
18:59:56 <ebering> otherwise this branch should be good to merge and provide some long lusted for features
20:12:04 -!- amalloy is now known as amalloy_
22:39:16 <Discord|> <10P​leasingFungus> this sounds sick
22:39:23 <Discord|> <10P​leasingFungus> (for 0.27, ofc)
23:49:34 <|amethyst> !tell ebering thanks for the suggestions!  just wish I had more software engineering background so I could get the requirements-gathering bit right
23:49:34 <Sequell> |amethyst: You have 1 message. Use !messages to read it.
23:49:34 <Sequell> |amethyst: OK, I'll let ebering know.