01:51:46 Windows builds of master branch on crawl.develz.org updated to: 0.26-a0-831-g7192265339 02:16:35 advil: yep, that's supposed to check that headers include their dependencies; what's the error you run into? 02:40:26 Unstable branch on cbro.berotato.org updated to: 0.26-a0-831-g7192265339 (34) 02:52:06 Monster database of master branch on crawl.develz.org updated to: 0.26-a0-831-g7192265339 03:31:03 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-3681-ga1082b90cb 03:52:37 %git 06017ff571f0b7500b75eef9a1b4e275c6fabd4a 03:52:37 07advil02 * 0.26-a0-822-g06017ff: Add a script for automated placement and connectivity testing 10(18 hours ago, 13 files, 319+ 75-) 13https://github.com/crawl/crawl/commit/06017ff571f0 04:00:16 wow 04:00:23 implemented command-line parsing in lua 04:01:14 ooh 04:01:43 I noticed that test in gauntlet_exit_mini_maze 04:02:11 !vault gauntlet_exit_mini_maze 04:02:11 1/1. https://github.com/crawl/crawl/blob/master/crawl-ref/source/dat/des/portals/gauntlet.des#L975 04:38:49 that looks pretty good 04:39:10 re taking too long for CI, it could probably be skipped for commits that don't modify vaults 05:21:46 if you can determine which vaults are affected by a commit, it should be possible to only test affected vaults in CI 05:23:37 how would that work? 05:23:56 commit comments that explicity initiated a test? 05:39:47 the script that is run by GHA can receive the refs to the git commits being tested, and so can list the files in those commits 05:40:42 basically, you'd only need to test vaults in des files that were created/modified 05:42:21 hrm, yeah, the problem is that it'd have to inspect the diff, since there are des files with many many vaults 05:42:32 https://docs.github.com/en/free-pro-team@latest/actions/reference/environment-variables#default-environment-variables 05:42:37 so if it just went by file, it would test too much 05:43:02 yup, you'd have to do that if you wanted more fine-grained pruning of tests 05:44:47 I guess you could have a GA script that was given the ref, inspected it, and made that determination? 05:45:28 actually, you have other issues, like DES that depends on e.g. lua functions defined elsewhere 05:45:46 not sure you can really determine what could affect a vault 05:51:00 hm, that's true.. 05:52:07 well, if you have lua functions defined elsewhere, ideally you'd be able to determine the transitive set of dependant vaults and just test those 05:52:26 but even so, you can still prune most of the tests for changes that just edit vaults without touching lua 07:07:42 wizamalloy (L11 DrFi) ASSERT(range >= 0) in 'beam.cc' at line 661 failed. (beam '', source 'player', item 'none'; has range -1) (Slime:5) 09:08:16 aidanh: `make: *** No rule to make target `ability.h.cc', needed by `ability.h.o'. Stop.` 09:11:23 odd... what's your command line? 09:11:32 `make header-build-tests`? 09:13:28 not sure why the dependency would be .h.cc instead of just .h 09:14:03 <06a​dvil> Found an implicit rule for `ability.h.o'. Considering target file `ability.h.cc'. File `ability.h.cc' does not exist. Looking for an implicit rule for `ability.h.cc'. No implicit rule found for `ability.h.cc'. Finished prerequisites of target file `ability.h.cc'. Must remake target `ability.h.cc'. 09:14:14 well, that formatted terribly on the irc side 09:15:02 it appears to be ignoring the %.h.o: rule? 09:15:34 discord is aptly named 09:15:44 looks great in discord! 09:15:57 I pasted it there because it supports ``` blocks 09:23:37 urgh, irc is really stuck in the 7th century in some regards 09:26:25 looks like the %.h.o is being ignored, yeah... hmm 09:28:14 or perhaps the %.o rule is taking priority? 09:33:35 the debug log has two instances of `Trying pattern rule with stem `ability.h'.` so I think it is finding both but the %.o rule is applying 09:37:00 and when I remove the regular .o rule it works 09:40:15 "Prior to version 3.82, when gmake finds multiple matches during a pattern search, it prefers patterns declared earlier in the makefile over patterns declared later. As of 3.82, gmake instead prefers the pattern that results in the shortest stem." 09:40:15 I have 3.81 09:45:07 03advil02 07* 0.26-a0-832-g78611b2: Reorder a Makefile rule for backwards compatibility 10(80 seconds ago, 1 file, 15+ 9-) 13https://github.com/crawl/crawl/commit/78611b2a4a5a 09:46:47 Unstable branch on crawl.kelbi.org updated to: 0.26-a0-832-g78611b2a4a (34) 09:54:15 nice, thanks 10:31:25 <10P​leasingFungus> !crashlog 10:31:27 <04C​erebot> 22763. FromWork, XL16 FoBe, T:31399 (milestone): https://crawl.project357.org/morgue/FromWork/crash-FromWork-20201115-143528.txt 10:31:50 <10P​leasingFungus> oh that was amalloy 11:43:38 that md file should probably use some different styles if we are showing it as plain text 11:44:04 e.g. the 2-line header syntax 11:44:30 (it doesn't look that great in game) 11:46:42 also, I'd sort of guess that that crash is because some server scripts might copy only .txt files? 11:47:14 it seems to work on cao so maybe dgl-config is ok 11:49:15 of course what we really need is a md -> formatted_string parser :D 11:52:20 noo please 11:52:57 %git 23cac7494c9 11:52:57 07Sebastian Łużyński02 {wheals} * 0.26-a0-789-g23cac74: Update and rename quickstart.txt to quickstart.md 10(3 weeks ago, 2 files, 148+ 147-) 13https://github.com/crawl/crawl/commit/23cac7494c95 11:53:19 I would guess this PR actually was done not realizing this doc could be shown in game? 11:54:03 probably; it looks quite reasonable otherwise 11:54:53 an alternative would be to (similar to the manual) generate a txt version 11:54:53 looks like we have our own homebrewed rst converter, and don't presuppose anything for md 11:54:59 I love pandoc but it is super heavy as a dep 11:55:32 and bake that text version into the binary maybe 11:55:59 well, that would apply to a whole bunch of stuff if so 11:56:39 %git 00c8f0b8f8 11:56:39 07wheals02 * 0.26-a0-793-g00c8f0b: Fix the path for quickstart.md 10(5 days ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/00c8f0b8f8e0 11:56:47 true true 11:56:47 you can see the list nearby that change 11:57:10 at least the manual and aptitudes.txt are autogenerated iirc 11:58:59 man not much out there besides pandoc 11:59:20 well, lots of parsers 12:00:30 markdown is a fiddly thing to parse, although I suspect our use is pretty straightforward 12:00:40 if we wanted to actually do md parsing this looks promising: https://github.com/mity/md4c 12:05:09 lol "I suggest printing it out" 12:06:18 that doesn't look bad 12:07:22 i think it's safe to say we will not be needing their latex math parsing support 12:09:10 03advil02 {GitHub} 07* 0.26-a0-833-g7262b39: Tweaks to quickstart.md 10(10 seconds ago, 1 file, 20+ 18-) 13https://github.com/crawl/crawl/commit/7262b396526e 12:10:14 Unstable branch on crawl.akrasiac.org updated to: 0.26-a0-832-g78611b2 (34) 12:10:47 do they really parse that and not just offload it to mathjax? 12:12:24 i didn't actually look, I just glanced at the test cases and saw a latex one 12:15:02 New branch created: pull/1617 (1 commit) 13https://github.com/crawl/crawl/pull/1617 12:15:02 03Midn802 {GitHub} 07https://github.com/crawl/crawl/pull/1617 * 0.26-a0-833-g44b4390: Fix "The Exile" Description 10(22 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/44b439099692 12:16:55 Unstable branch on crawl.kelbi.org updated to: 0.26-a0-833-g7262b39652 (34) 12:23:13 03Aidan Holm02 07[wip-nested-format] * 0.26-a0-788-gb3353ea: WIP: Add line-wrapping functions for formatted_string 10(10 minutes ago, 2 files, 155+ 0-) 13https://github.com/crawl/crawl/commit/b3353eabe1a5 12:23:13 03Aidan Holm02 07[wip-nested-format] * 0.26-a0-789-ga7c40f9: Unify some text widget text wrapping code 10(6 minutes ago, 2 files, 21+ 35-) 13https://github.com/crawl/crawl/commit/a7c40f98e530 12:23:13 03Aidan Holm02 07[wip-nested-format] * 0.26-a0-790-gdf656d4: Encode nested colours in formatted_string 10(11 months ago, 5 files, 129+ 27-) 13https://github.com/crawl/crawl/commit/df656d4371b8 12:23:16 Branch pull/1249 updated to be equal with wip-nested-format: 13https://github.com/crawl/crawl/pull/1249 12:44:16 does anyone know why xp evocable charges are not checked in evoke_check? There's a comment about it so I assume someone considered it and then didn't do it? 12:45:24 lol I think I wrote this comment, in this branch 12:46:06 nevermind 15:33:40 -!- aidanh_ is now known as aidanh 16:14:29 -!- amalloy_ is now known as amalloy 16:43:44 <10P​leasingFungus> lol 16:52:26 03advil02 07[targeted-commands] * 0.26-a0-872-g50bb1b0: Some tweaks around quiver mp usage 10(5 hours ago, 4 files, 50+ 11-) 13https://github.com/crawl/crawl/commit/50bb1b09f733 16:52:26 03advil02 07[targeted-commands] * 0.26-a0-873-ga4b80ce: Implement quivering/firing misc evocables 10(3 hours ago, 2 files, 145+ 54-) 13https://github.com/crawl/crawl/commit/a4b80ce5f6c0 16:52:26 03advil02 07[targeted-commands] * 0.26-a0-874-g91a4087: Implement target preselection for artefacts 10(3 hours ago, 5 files, 20+ 10-) 13https://github.com/crawl/crawl/commit/91a40870a03d 16:52:26 03advil02 07[targeted-commands] * 0.26-a0-875-g82a9eac: Allow quivering evokable unrands 10(12 minutes ago, 2 files, 143+ 1-) 13https://github.com/crawl/crawl/commit/82a9eac5ee27 16:52:26 03advil02 07[targeted-commands] * 0.26-a0-876-g1d291ea: Update some options text for quivering-related changes 10(41 seconds ago, 1 file, 19+ 13-) 13https://github.com/crawl/crawl/commit/1d291eaf2600 16:52:36 Branch pull/1581 updated to be equal with targeted-commands: 13https://github.com/crawl/crawl/pull/1581 18:21:56 Unstable branch on underhound.eu updated to: 0.26-a0-833-g7262b39652 (34) 23:02:32 Maybe this is a bug? trunk webtiles. https://tinyurl.com/y355pkp5 23:03:43 It looks like it is showing more dungeon that it should in the minimap. Spectators don't see the expanded mini-map.