00:40:33 <aidanh> CrawlCycle: that auto-generated data sounds like a bug
00:41:02 <aidanh> !source test_ng-init-branches.cc
00:41:03 <Sequell> https://github.com/crawl/crawl/blob/master/crawl-ref/source/catch2-tests/test_ng-init-branches.cc
00:41:49 <aidanh> !source ng-init-branches.cc
00:41:50 <Sequell> https://github.com/crawl/crawl/blob/master/crawl-ref/source/ng-init-branches.cc
00:44:16 <aidanh> CrawlCycle: in every game, only a subset of branches appear, with potentially varying depths. That code generates the set of branches (and their depths) for a new game
00:45:06 <aidanh> in general, if code is unclear, use git blame; we try to leave good commit messages
00:45:28 <aidanh> !source species-data.h
00:45:28 <Sequell> https://github.com/crawl/crawl/blob/master/crawl-ref/source/species-data.h
00:49:45 <aidanh> it's possible that's only included in one file, e.g. main.cc, in which case it's not a problem; can't really grep on mobile..
01:38:14 -!- amalloy_ is now known as amalloy
02:13:53 <Cbrotell> Unstable branch on cbro.berotato.org updated to: 0.26-a0-683-g5206c1d7ac (34)
03:30:52 <Kelbell> Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-3603-ge1cc4b0452
03:47:03 <Kelbell> Fork (bcadrencrawl) on crawl.kelbi.org updated to: 0.22.1-3084-g67bc199fa1
05:54:11 -!- amalloy is now known as amalloy_
07:50:05 <Cheibriados> 03Aliscans02 {GitHub} 07https://github.com/crawl/crawl/pull/1592 * 0.26-a0-673-ged19cc2: Revert a change 10(4 minutes ago, 1 file, 2+ 3-) 13https://github.com/crawl/crawl/commit/ed19cc223cf7
08:13:32 <Cheibriados> 03Aidan Holm02 07* 0.26-a0-684-gcf72488: Add some test cases for coordit.cc 10(3 days ago, 2 files, 205+ 0-) 13https://github.com/crawl/crawl/commit/cf72488783fa
08:13:32 <Cheibriados> 03Aidan Holm02 07* 0.26-a0-685-g974c44d: Split env.tile_* fields into a separate global 10(2 days ago, 25 files, 326+ 284-) 13https://github.com/crawl/crawl/commit/974c44d4c82d
08:27:35 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.26-a0-685-g974c44d4c8 (34)
09:22:38 <Cheibriados> New branch created: iwyu (4 commits) 13https://github.com/crawl/crawl/tree/iwyu
09:22:39 <Cheibriados> 03Aidan Holm02 07[iwyu] * 0.26-a0-686-ge87d648: Add tag-version.h includes 10(19 minutes ago, 179 files, 230+ 0-) 13https://github.com/crawl/crawl/commit/e87d64898f45
09:22:39 <Cheibriados> 03Aidan Holm02 07[iwyu] * 0.26-a0-687-g5f85e04: Move a bunch of preprocessor macros out of AppHdr.h 10(4 months ago, 2 files, 108+ 92-) 13https://github.com/crawl/crawl/commit/5f85e0466e6b
09:22:39 <Cheibriados> 03Aidan Holm02 07[iwyu] * 0.26-a0-688-g61aa97c: Add missing '#pragma once' lines to headers 10(2 minutes ago, 23 files, 44+ 0-) 13https://github.com/crawl/crawl/commit/61aa97cf8b71
09:22:39 <Cheibriados> 03Aidan Holm02 07[iwyu] * 0.26-a0-689-g5815f2e: Add missing std:: in enum.h 10(71 seconds ago, 1 file, 3+ 3-) 13https://github.com/crawl/crawl/commit/5815f2e42b78
13:24:29 <Henzell> Unstable branch on crawl.akrasiac.org updated to: 0.26-a0-685-g974c44d (34)
13:47:13 -!- PElf is now known as ProzacElf
15:39:28 -!- aidanh_ is now known as aidanh
16:40:55 <DrPraetor> Bring sludge elves back.  They have Evolution 2, their unarmed attacks are chaos branded, Zin hates them.
17:03:46 <Discord|> <10P​leasingFungus> that seems like a new race suggestion
17:47:14 <Discord|> <10P​leasingFungus> oh, if someone did want to refactor our codebase, they should refactor mon-ench.cc
17:47:18 <Discord|> <10P​leasingFungus> that thing is an absolute nest of bugs
17:47:26 <Discord|> <10P​leasingFungus> begging to be reworked
17:48:15 <Discord|> <10P​leasingFungus> and relies much less on global state than other things
17:54:04 <Cheibriados> 03PleasingFungus02 07* 0.26-a0-686-gcdb3167: Make boulder beetles slower than speed 100 10(17 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/cdb31674f66c
17:54:04 <Cheibriados> 03PleasingFungus02 07* 0.26-a0-687-gc79dab0: Decay rolling over time 10(5 minutes ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/c79dab02b1f3
17:54:04 <Cheibriados> 03PleasingFungus02 07* 0.26-a0-688-g3ec5dac: Randomize roll duration more precisely 10(5 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/3ec5dac9c622
17:54:04 <Cheibriados> 03PleasingFungus02 07* 0.26-a0-689-gc93c913: Don't let rolling boulder beetles push (ardl) 10(2 minutes ago, 1 file, 4+ 0-) 13https://github.com/crawl/crawl/commit/c93c913f66df
18:02:20 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.26-a0-689-gc93c913f66 (34)
18:23:33 <Lantell> Unstable branch on underhound.eu updated to: 0.26-a0-689-gc93c913f66 (34)
19:16:57 -!- introsp3ctive is now known as introsp3ctive_se
20:26:22 <twelwe> is there a design reason behind Fo dig status being removed when trying (and of course failing) to dig through non-diggable walls?
20:50:58 <Discord|> <10P​leasingFungus> probably bug
21:02:48 <twelwe> i think its derogatory to call a formicid a bug
21:03:48 <spicycat> removing the status helps cause pure ownage
22:31:22 <aidanh> !source mon-ench.cc
22:31:22 <Sequell> https://github.com/crawl/crawl/blob/master/crawl-ref/source/mon-ench.cc
22:52:16 <Cheibriados> 03PleasingFungus02 07* 0.26-a0-690-gcb57259: Fix always_show_zot (vt) 10(38 seconds ago, 1 file, 5+ 3-) 13https://github.com/crawl/crawl/commit/cb572590781e
23:02:11 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.26-a0-690-gcb57259078 (34)
23:16:19 <aidanh> PleasingFungus: got any example commits for mon ench bug fixes?
23:16:43 <Discord|> <10P​leasingFungus> %git c79dab02b1f3
23:16:44 <Discord|> <04C​erebot> PleasingFungus * 0.26-a0-687-gc79dab0: Decay rolling over time (5 hours ago, 1 file, 1+ 0-) https://github.com/crawl/crawl/commit/c79dab02b1f3
23:17:25 <Discord|> <10P​leasingFungus> %git 8e44f26cd4b246c607274b9f6575f1cb4f602154
23:17:25 <Discord|> <04C​erebot> gammafunk * 0.25-a0-465-g8e44f26: Correct and refactor monster enchant durations (9 months ago, 2 files, 6+ 10-) https://github.com/crawl/crawl/commit/8e44f26cd4b2
23:19:25 <Discord|> <10P​leasingFungus> heh, 77c7a9b7307a6c32a767b2c7af097a289085a6f4 counts but that's 4 years old
23:21:45 <Discord|> <10P​leasingFungus> 'absolute nest of bugs' may have been a strong phrasing 🙂
23:21:48 <Discord|> <10P​leasingFungus> but i suspect there's more lurking there
23:22:35 <aidanh> it looks like it could be possible to group each enchantment's behavior into a class
23:22:44 <aidanh> similar to potions
23:22:53 <aidanh> there's some interaction, but not much
23:23:39 <aidanh> (interaction between enchantments that is)
23:25:01 <aidanh> i suspect that adding unit tests would be tough though, there's still dependency on monster state at least
23:26:24 <Discord|> <10P​leasingFungus> yeah, probably unit tests are still tough
23:26:24 <Discord|> <10P​leasingFungus> but i agree with myself from 4 years ago!
23:26:24 <Discord|> <10P​leasingFungus> %git 77c7a9b7307a6c32a767b2c7af097a289085a6f4
23:26:24 <Discord|> <10P​leasingFungus> >     TODO: dataify monster enchantments...
23:26:24 <twelwe> what if there was something you could tell your younger self
23:26:25 <Discord|> <04C​erebot> PleasingFungus * 0.19-a0-908-g77c7a9b: Make mons Black Mark fade over time! Yay! (10470) (4 years, 4 months ago, 1 file, 1+ 0-) https://github.com/crawl/crawl/commit/77c7a9b7307a
23:27:41 <Discord|> <10P​leasingFungus> could i tell myself the contents of the 2000-2050 sports almanac
23:32:00 <twelwe> i would have told myself to play more during the double damage melee bug and win skyrockets worth of streaks
23:52:25 -!- amalloy_ is now known as amalloy