00:02:11 -!- amalloy_ is now known as amalloy
01:08:22 <Cheibriados> 03CrawlCycle02 07https://github.com/crawl/crawl/pull/1590 * 0.26-a0-688-gb00c291: feat: Add require_execstring 10(37 minutes ago, 3 files, 14+ 18-) 13https://github.com/crawl/crawl/commit/b00c29145abc
01:42:00 <Cheibriados> 03CrawlCycle02 07https://github.com/crawl/crawl/pull/1590 * 0.26-a0-689-gac2f238: build: Alphabetize TEST_OBJECTS in Makefile.obj 10(3 minutes ago, 1 file, 5+ 5-) 13https://github.com/crawl/crawl/commit/ac2f238f9834
02:47:30 <Cbrotell> Unstable branch on cbro.berotato.org updated to: 0.26-a0-682-g294304f6e8 (34)
03:32:51 <Kelbell> Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-3603-ge1cc4b0452
03:48:18 <Kelbell> Fork (bcadrencrawl) on crawl.kelbi.org updated to: 0.22.1-3077-g1f18bfda78
05:52:18 -!- amalloy is now known as amalloy_
07:24:00 <Cheibriados> 03amcnicky02 07https://github.com/crawl/crawl/pull/1546 * 0.26-a0-521-g96d2570: Changes following @PleasingFungus' review 10(6 minutes ago, 9 files, 212+ 143-) 13https://github.com/crawl/crawl/commit/96d2570dd377
08:20:07 <Cheibriados> 03amcnicky02 {GitHub} 07https://github.com/crawl/crawl/pull/1546 * 0.26-a0-685-g05755ea: Merge branch 'master' into abyss_unique_staging 10(2 minutes ago, 0 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/05755ea7fbdc
08:34:27 <advil> re this constructor thing, adding `you` and `env` to the constructors is simply the wrong way to accomplish the goal here I think
08:34:55 <advil> `you` is only used because the iterator internally stores mindexes and is basically a shortcut, there are any number of ways to directly eliminate the reference to you
08:35:27 <advil> the issue with env suggests that the iterator should just be part of env in one way or another
08:36:02 <advil> not a standalone class
08:36:14 <advil> which could of course result in it internally storing a reference to env
08:38:14 <amcnicky> Hello, would anyone be able to help me figure out this debug compile error?
08:38:18 <amcnicky> abyss.cc:1921:43: error: ‘grd’ was not declared in this scope
08:38:50 <amcnicky> getting it in a few places
08:38:55 <amcnicky> like also   if (grd(where) == DNGN_FLOOR && !env.markers.find(where, MAT_ANY))
08:39:14 <amcnicky> but there are other references to grd within the file which don't generate this error
08:40:01 <amcnicky> The relevant PR/compile checks are here for reference https://github.com/crawl/crawl/pull/1546/checks?check_run_id=1280852100
08:41:08 <amcnicky> I would have thought grd was in scope for the whole file so not sure where to start!
08:42:06 <advil> there was recently a bunch of commits merged that removed grd etc
08:42:43 <advil> use env.grid instead
08:42:47 <amcnicky> ah I see
08:42:50 <amcnicky> perfect, thank you
08:42:50 <advil> %git e1d8dbde3443832f8
08:42:50 <Cheibriados> 07Aidan Holm02 * 0.26-a0-680-ge1d8dbd: Remove grd() helper macro 10(2 days ago, 106 files, 817+ 818-) 13https://github.com/crawl/crawl/commit/e1d8dbde3443
08:43:06 <advil> %git 4ee14324bdca
08:43:06 <Cheibriados> 07Aidan Holm02 * 0.26-a0-678-g4ee1432: Remove menv() helper macro 10(2 days ago, 33 files, 117+ 118-) 13https://github.com/crawl/crawl/commit/4ee14324bdca
08:43:09 <advil> for motivation
08:47:43 <amcnicky> would I need to update all grd references in the files this PR touches or would it just be grd references on lines which are added/modified by my PR?
08:48:30 <advil> that commit should change everything that uses `grd` in master
08:48:49 <advil> so it should just be lines in your PR
08:48:57 <amcnicky> ok nice, thank you
08:53:43 <Cheibriados> 03amcnicky02 07https://github.com/crawl/crawl/pull/1546 * 0.26-a0-521-g40ae043: Changes following @PleasingFungus' review 10(2 hours ago, 9 files, 213+ 144-) 13https://github.com/crawl/crawl/commit/40ae0437edf6
09:02:01 <aidanh> there's little real difference between env.iterator() and iterator(env), although if there's more than one dep, you have to choose one class as the 'parent'
09:03:22 <aidanh> but i would humbly suggest not adding any more code/methods/API to env :)
09:10:48 <aidanh> possibly the best thing to do with env is to break it into several globals; e.g. env.tile_* iirc are related to map drawing, env.level_* is probably mapgen gunk, etc
09:11:47 <aidanh> possibly only item, mons, grid, pgrid, mgrid, igrid and a few others are really what one thinks of the 'environment'
09:24:40 <CrawlCycle> advil: if we move the iterator to become part of the env class
09:25:11 <CrawlCycle> would we also refactor other iterators to become part of the env class?
09:25:23 <CrawlCycle> after that, would the env class become too big?
09:25:56 <CrawlCycle> not every entity need every iterator from the env class.
09:27:37 <aidanh> CrawlCycle: there's some traceback you missed, but it was basically just me saying the same thing
09:29:10 <aidanh> env is relatively benign, in that it's just a struct which gathers a bunch of globals into one, rather than providing any behavior
09:31:02 <aidanh> still, it'd be better if it were broken up; it's still a bad influence on code structure
09:31:56 <CrawlCycle> yea
09:33:47 <aidanh> `you` will be a bigger problem
09:34:06 <CrawlCycle> are there any way to see the correlation between the usage of the method/attribute of the env class?
09:36:01 <CrawlCycle> i don't think sourcetrail does that.
09:36:01 <aidanh> not afaik
09:36:30 <aidanh> it'd be fairly easy if you had a file:line -> function name map
09:39:20 <CrawlCycle> clang has python binding
09:46:23 <aidanh> eh... possible but not fun
09:46:51 <CrawlCycle> or just do it the quick and dirty way
09:47:09 <CrawlCycle> see if a line's first character is not white space
09:47:28 <CrawlCycle> and if the next line is a brace
09:47:44 <CrawlCycle> if yes, keep going to the next line until we see a line with just a closing brace
09:47:56 <CrawlCycle> everything in between is treat as an entity.
09:48:31 <CrawlCycle> have to match the env too.
09:48:32 <aidanh> yeah, that's a more likely approach, especially since correlation between different attributes is going to be somewhat fuzzy anyway
09:50:04 <CrawlCycle> an even more rough approach is to measure
09:50:21 <CrawlCycle> the line seperation between an invocation of env
09:50:33 <CrawlCycle> and the next invocation of env
09:50:44 <CrawlCycle> and then cluster
09:50:56 <CrawlCycle> very rough. clustering might take a long time.
09:51:53 <aidanh> that sounds overly complicated to me
09:52:00 <CrawlCycle> hmm. probably the quick and dirty way is easier
09:52:02 <CrawlCycle> yea.
09:55:55 <Cheibriados> New branch created: split-tile-env (2 commits) 13https://github.com/crawl/crawl/tree/split-tile-env
09:55:55 <Cheibriados> 03Aidan Holm02 07[split-tile-env] * 0.26-a0-683-gb2a6397: Add some test cases for coordit.cc 10(21 hours ago, 2 files, 205+ 0-) 13https://github.com/crawl/crawl/commit/b2a6397c1dcc
09:55:55 <Cheibriados> 03Aidan Holm02 07[split-tile-env] * 0.26-a0-684-gb55e122: Split env.tile_* fields into a separate global 10(13 minutes ago, 24 files, 293+ 284-) 13https://github.com/crawl/crawl/commit/b55e12226649
09:56:47 <aidanh> huh, thought i already pushed that first one
09:59:15 <dcss-ci> 04Build failed for 08split-tile-env @ b55e1222 06https://github.com/crawl/crawl/actions/runs/317802439
10:00:50 <CrawlCycle> is it ok to make a pull request that depends on a previous pull request?
10:01:56 <CrawlCycle> i wrote a 3 actor test scenario (player, orc, bat) that depends on the lua fixture for catch2.
10:04:51 <aidanh> in theory yes, in practice, better not
10:05:37 <aidanh> what I saw of the lua fixture looked pretty good, but it will likely need some revisions, possibly substantial ones
10:06:18 <CrawlCycle> hmm. then i just leave it in my fork.
10:06:26 <CrawlCycle> what kind of revisions?
10:07:50 <Cheibriados> 03Aidan Holm02 07[split-tile-env] * 0.26-a0-684-ga4978d8: Split env.tile_* fields into a separate global 10(25 minutes ago, 25 files, 326+ 284-) 13https://github.com/crawl/crawl/commit/a4978d813268
10:30:25 <Cheibriados> 03CrawlCycle02 07https://github.com/crawl/crawl/pull/1590 * 0.26-a0-690-g30ec7f7: style: Checkwhite 10(4 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/30ec7f7db949
10:36:59 <Kelbell> Sobieck (L6 KoEE) Crash caused by signal #6: Aborted (D:2)
10:54:22 <amcnicky> Is there a way to iterate over monsters that are currently alive in the game? iterating over monsters on the floor would likely also be sufficient
10:54:54 <wheals> monsters on the floor is simply monster_iterator
10:55:19 <amcnicky> thanks
10:55:20 <wheals> all monsters requires doing excursions to other levels, or a delayed action
10:55:33 <wheals> !fn watchhash () $(hash cao http://crawl.akrasiac.org:8080/#watch- cbr2 http://cbro.berotato.org:8080/#watch- cko https://crawl.kelbi.org:8081/#watch- cpo https://crawl.project357.org/watch/ cue http://underhound.eu:8080/#watch- cwz http://webzook.net:8080/#watch- cxc http://crawl.xtahua.com:8080/#watch- lld http://lazy-life.ddo.jp:8080/#watch-)
10:55:34 <Sequell> Redefined function: !fn watchhash () $(hash cao http://crawl.akrasiac.org:8080/#watch- cbr2 http://cbro.berotato.org:8080/#watch- cko https://crawl.kelbi.org:8081/#watch- cpo https://crawl.project357.org/watch/ cue http://underhound.eu:8080/#watch- cwz http://webzook.net:8080/#watch- cxc http://crawl.xtahua.com:8080/#watch- lld http://lazy-life.ddo.jp:8080/#watch-) (was: !fn watchhash () $(hash ca...
11:25:53 -!- bairyn is now known as ByronJohnson
14:46:07 <advil> %git 850bfe61e39c27fcdc3d
14:46:07 <Cheibriados> 07advil02 * 0.26-a0-67-g850bfe6: Fix an interaction of fallback randarts and acquirement (12277) 10(4 months ago, 3 files, 51+ 8-) 13https://github.com/crawl/crawl/commit/850bfe61e39c
16:40:39 <Cheibriados> 03amcnicky02 07https://github.com/crawl/crawl/pull/1546 * 0.26-a0-522-g7265d00: Changes following @Gammafunk's review, and testing 10(3 hours ago, 11 files, 90+ 174-) 13https://github.com/crawl/crawl/commit/7265d006d91b
16:40:39 <Cheibriados> 03amcnicky02 {GitHub} 07https://github.com/crawl/crawl/pull/1546 * 0.26-a0-686-ge69e56a: Merge branch 'master' into abyss_unique_staging 10(3 minutes ago, 0 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/e69e56a5f401
17:12:28 <CrawlCycle> dgn.create_monster(79, 31, "orc ench:invis") says
17:12:35 <CrawlCycle> Point (79, 31) is out of bounds
17:13:34 <CrawlCycle> does that mean the valid range of x is X_BOUND_1 < x < X_BOUND_2 for monster placement?
17:14:32 <CrawlCycle> or
17:14:35 <CrawlCycle> X_BOUND_1 + 1 < x < X_BOUND_2 - 1?
17:21:25 <CrawlCycle> probably it is (X_BOUND_1 + 1) < x < (X_BOUND_2 - 1)
17:21:40 <CrawlCycle> probably it is (X_BOUND_1 + 1) <= x < (X_BOUND_2 - 1)
19:02:07 <CrawlCycle> the fixture is a bit slow. 5768 setup+tear-down takes about 4 to 5 seconds
19:02:45 <CrawlCycle> that is the number of setup+teardown in my tests of the fixture
19:14:29 <CrawlCycle> generally, running 5768 different tests with 4-5 second overhead for setup and tear-down of the fixture would be fine.
20:53:03 <Cheibriados> 03CrawlCycle02 07https://github.com/crawl/crawl/pull/1590 * 0.26-a0-691-gf37373f: refactor: Move #include from .h to .cc 10(6 minutes ago, 5 files, 46+ 48-) 13https://github.com/crawl/crawl/commit/f37373f060f5
20:58:39 <Cheibriados> 03CrawlCycle02 07https://github.com/crawl/crawl/pull/1590 * 0.26-a0-692-gdc3fa68: refactor: Remove namespace details_fixture_lua 10(5 minutes ago, 3 files, 173+ 177-) 13https://github.com/crawl/crawl/commit/dc3fa68a92e8
21:09:19 -!- amalloy_ is now known as amalloy
21:09:51 <Cheibriados> 03CrawlCycle02 07https://github.com/crawl/crawl/pull/1590 * 0.26-a0-693-ga173607: refactor: Remove declarations of internals in .h 10(8 minutes ago, 3 files, 15+ 34-) 13https://github.com/crawl/crawl/commit/a173607aa2d7
21:15:27 <Cheibriados> 03CrawlCycle02 07https://github.com/crawl/crawl/pull/1590 * 0.26-a0-694-g0acdc93: refactor: Rename require_execstring to dlua_exec 10(6 minutes ago, 3 files, 10+ 10-) 13https://github.com/crawl/crawl/commit/0acdc930a066
21:15:27 <Cheibriados> 03CrawlCycle02 07https://github.com/crawl/crawl/pull/1590 * 0.26-a0-695-gc8905b3: refactor: Add #include<string> 10(79 seconds ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/c8905b3af73d
21:26:40 <Cheibriados> 03CrawlCycle02 07https://github.com/crawl/crawl/pull/1590 * 0.26-a0-696-gd3bf038: refactor: Use raw strings to escape quotes \" 10(8 minutes ago, 1 file, 7+ 8-) 13https://github.com/crawl/crawl/commit/d3bf03895e64
21:32:16 <Cheibriados> 03CrawlCycle02 07https://github.com/crawl/crawl/pull/1590 * 0.26-a0-697-g3c90f3f: refactor: Remove 'fixture_lua' from names of tests 10(9 minutes ago, 1 file, 6+ 10-) 13https://github.com/crawl/crawl/commit/3c90f3f89d6f
21:37:52 <Cheibriados> 03CrawlCycle02 07https://github.com/crawl/crawl/pull/1590 * 0.26-a0-698-g0679628: refactor: Replace INFO by CAPTURE macro of catch2 10(7 minutes ago, 1 file, 6+ 9-) 13https://github.com/crawl/crawl/commit/067962843a10
21:49:05 <Cheibriados> 03CrawlCycle02 07https://github.com/crawl/crawl/pull/1590 * 0.26-a0-699-ge8aeb7a: style: Indent, checkwhite, and unbrace 10(6 minutes ago, 5 files, 77+ 74-) 13https://github.com/crawl/crawl/commit/e8aeb7a0780b
21:54:41 <Cheibriados> 03CrawlCycle02 07https://github.com/crawl/crawl/pull/1590 * 0.26-a0-700-gd105a93: style: Remove an empty line 10(6 minutes ago, 1 file, 0+ 1-) 13https://github.com/crawl/crawl/commit/d105a93fd841
22:17:08 <Cheibriados> 03CrawlCycle02 07https://github.com/crawl/crawl/pull/1590 * 0.26-a0-701-g076bd81: test: Use random coordinates to test FixtureLua 10(11 minutes ago, 1 file, 54+ 33-) 13https://github.com/crawl/crawl/commit/076bd819d4a1
22:24:55 -!- elliptic_ is now known as elliptic
22:43:33 <CrawlCycle> how to set the rng seed in initialization of crawl?
22:43:54 <CrawlCycle> Is it sufficient to set crawl_state.seed and you.seed?
22:44:12 <CrawlCycle> I am doing a cut-down initialization of crawl in a fixture for catch2 tests.
23:30:26 <aidanh> Ideally all seeds (stdlib, crawl's random code, and those vars) would be set to a fixed value in a fixture that'd be used for all tests
23:33:16 <CrawlCycle> i am trying to add "-seed <decimal#>" to the fake command line arguments.
23:33:33 <CrawlCycle> that i feed to the cut-down main function of crawl.
23:38:43 <CrawlCycle> but parse_args say unknown option
23:39:30 <CrawlCycle> when I give it "crawl -seed 729\0" with argc and argv
23:40:02 <CrawlCycle> unknown option -seed 729
23:40:39 <aidanh> perhaps you're not splitting -seed and 729 into separate argv elements
23:41:30 <CrawlCycle> oh. right.
23:49:04 <CrawlCycle> crawl doesn't use srand
23:49:36 <CrawlCycle> so i guess there is no need to set seed of <stdlib.h>
23:50:21 <aidanh> I'd set it anyway; can't hurt
23:51:15 <aidanh> Catch2 generators use the cstdlib rand stuff, so that should be seeded as well