00:01:34 <wheals> looking again, it looks like it.puton does check that, but maybe it's somehow getting called before the delay is over so the amulet isn't on yet
00:01:58 <wheals> which makes no sense to me, ready() shouldn't be called in the middle of a delay
00:07:43 <CrawlCycle> why can clua cause that kind of problem?
00:09:09 <CrawlCycle> gammafunk: I want my spy camera!
00:11:00 <gammafunk> CrawlCycle: fwiw, often access to the save isn't all that helpful, and the stacktrace+log has all the info you need
00:11:33 <gammafunk> I guess I should say stacktrace+log+reading code
00:13:36 <CrawlCycle> oh. maybe I will read that part of the source code a few months later.
00:14:09 <CrawlCycle> i mean the part that save the game.
00:15:41 <CrawlCycle> right now I can try to put some clua command into a unit test.
00:16:16 <CrawlCycle> scenario test actually.
00:17:58 -!- amalloy is now known as amalloy_
00:17:58 <CrawlCycle> maybe someday we will start putting player's save files into tests
00:19:18 <CrawlCycle> is it some kind of race condition between the two lua interpreters?
00:19:22 <CrawlCycle> i mean dlua and clua
00:19:42 <CrawlCycle> do we use co-routines in the lua code?
00:22:46 <wheals> i tracked down the rcfile https://cbro.berotato.org/rcfiles/crawl-git/vortex.rc
00:22:57 <wheals> definitely some interesting stuff
00:23:53 <CrawlCycle> what is his crime?
00:24:01 <CrawlCycle> let me see...
00:25:14 <Implojin> that vortex rc is the coolest crawl rc since gw, i have an earlier version of it saved locally
00:25:53 <CrawlCycle> bot?
00:26:11 <Implojin> i think it's an assist script like ff but less crap
00:27:38 <CrawlCycle> so it is an android instead of a bot.
00:27:42 <Implojin> "oh hey we need pathfinding, let me just implement a* in clua real quick"
00:30:56 <CrawlCycle> that is the right script to get banished to the abyss
00:31:18 <CrawlCycle> let's see how would his a* work in that case
00:36:40 <Cheibriados> 03PleasingFungus02 07[bogged-down] * 0.26-a0-700-ga0bc02d: Fix foxfire crash (Lightli) 10(20 seconds ago, 1 file, 5+ 0-) 13https://github.com/crawl/crawl/commit/a0bc02d1c1f9
00:36:59 <Cheibriados> Branch pull/1533 updated to be equal with bogged-down: 13https://github.com/crawl/crawl/pull/1533
00:37:52 <Implojin> PF how long do we have to wait for live newswamp
00:37:56 <Cheibriados> 03PleasingFungus02 07[bogged-down] * 0.26-a0-701-g7874d04: Remove insubstantial wisps from swamp gen 10(37 seconds ago, 1 file, 0+ 1-) 13https://github.com/crawl/crawl/commit/7874d0465818
00:38:15 <Cheibriados> Branch pull/1533 updated to be equal with bogged-down: 13https://github.com/crawl/crawl/pull/1533
00:38:29 <Implojin> im vaguely excited for this
00:59:32 <gammafunk> he has to add shadow traps to swamp first
01:12:50 <Cheibriados> New branch created: batty (1 commit) 13https://github.com/crawl/crawl/tree/batty
01:12:51 <Cheibriados> 03PleasingFungus02 07[batty] * 0.26-a0-668-g48e721f: Make bats less anthrosolipsistic 10(8 weeks ago, 1 file, 19+ 19-) 13https://github.com/crawl/crawl/commit/48e721fe4b55
01:19:09 <Cheibriados> 03PleasingFungus02 07[batty] * 0.26-a0-669-gc69013b: Scale battiness by bat speed 10(22 seconds ago, 1 file, 4+ 1-) 13https://github.com/crawl/crawl/commit/c69013b7fb08
01:21:29 <Lantell> Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-3603-ge1cc4b0452
01:22:31 <Cheibriados> Branch master updated to be equal with batty: 13https://github.com/crawl/crawl/tree/master
01:32:09 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.26-a0-668-gd58323b419 (34)
01:34:58 <Gretell> Unstable branch on crawl.develz.org updated to: 0.26-a0-668-gd58323b419 (34)
01:55:34 <Gretell> Windows builds of master branch on crawl.develz.org updated to: 0.26-a0-668-gd58323b419
02:14:18 <Cbrotell> Unstable branch on cbro.berotato.org updated to: 0.26-a0-668-gd58323b419 (34)
02:53:36 <Gretell> Monster database of master branch on crawl.develz.org updated to: 0.26-a0-668-gd58323b419
03:31:05 <Kelbell> Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-3603-ge1cc4b0452
03:40:41 <Kelbell> Fork (bcadrencrawl) on crawl.kelbi.org updated to: 0.22.1-3064-gba2439c231
04:38:07 <Cheibriados> 03Aidan Holm02 07* 0.26-a0-669-gb5bd653: Remove references to globals across files 10(4 days ago, 4 files, 24+ 22-) 13https://github.com/crawl/crawl/commit/b5bd6537f432
05:19:16 <Cheibriados> New branch created: remove-env-defines (5 commits) 13https://github.com/crawl/crawl/tree/remove-env-defines
05:19:16 <Cheibriados> 03Aidan Holm02 07[remove-env-defines] * 0.26-a0-670-gd0412a8: Remove mgrd() helper macro 10(33 minutes ago, 33 files, 117+ 118-) 13https://github.com/crawl/crawl/commit/d0412a8d72ee
05:19:16 <Cheibriados> 03Aidan Holm02 07[remove-env-defines] * 0.26-a0-671-gc42ca23: Remove mitm() helper macro 10(19 minutes ago, 54 files, 416+ 417-) 13https://github.com/crawl/crawl/commit/c42ca232872c
05:19:16 <Cheibriados> 03Aidan Holm02 07[remove-env-defines] * 0.26-a0-672-g4fefef6: Remove grd() helper macro 10(12 minutes ago, 106 files, 817+ 818-) 13https://github.com/crawl/crawl/commit/4fefef669940
05:19:16 <Cheibriados> 03Aidan Holm02 07[remove-env-defines] * 0.26-a0-673-gc7c2470: Remove mgrd() helper macro 10(8 minutes ago, 27 files, 85+ 86-) 13https://github.com/crawl/crawl/commit/c7c247064877
05:19:16 <Cheibriados> 03Aidan Holm02 07[remove-env-defines] * 0.26-a0-674-g6e2f078: Remove igrd() helper macro 10(4 minutes ago, 20 files, 64+ 67-) 13https://github.com/crawl/crawl/commit/6e2f07897c55
06:02:03 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.26-a0-669-gb5bd6537f4 (34)
06:27:32 -!- Tiobot is now known as Guest66074
08:34:06 -!- bairyn is now known as ByronJohnson
10:39:27 <Cbrotell> vortex (L8 DEFE) ASSERT(you.equip[slot] == -1) in 'player-equip.cc' at line 58 failed. (D:6)
11:18:07 <Cheibriados> New branch created: pull/1587 (1 commit) 13https://github.com/crawl/crawl/pull/1587
11:18:08 <Cheibriados> 03CrawlCycle02 07https://github.com/crawl/crawl/pull/1587 * 0.26-a0-670-gd7104af: test: Add catch2 fixture for running dLua/cLua 10(8 minutes ago, 6 files, 685+ 1-) 13https://github.com/crawl/crawl/commit/d7104afbdd8b
11:34:56 <Cheibriados> 03CrawlCycle02 07https://github.com/crawl/crawl/pull/1587 * 0.26-a0-671-g591b3c0: style: Remove braces 10(4 minutes ago, 1 file, 3+ 4-) 13https://github.com/crawl/crawl/commit/591b3c0109d1
11:46:08 <Cheibriados> 03CrawlCycle02 07https://github.com/crawl/crawl/pull/1587 * 0.26-a0-672-gc690abf: style: Add newline to end of file 10(6 minutes ago, 5 files, 5+ 5-) 13https://github.com/crawl/crawl/commit/c690abfafb10
12:10:21 <wheals> %git show
12:10:21 <Cheibriados> Could not find commit show (git returned 128)
12:10:27 <wheals> doh
12:10:29 <wheals> %git
12:10:29 <Cheibriados> 07Aidan Holm02 * 0.26-a0-669-gb5bd653: Remove references to globals across files 10(4 days ago, 4 files, 24+ 22-) 13https://github.com/crawl/crawl/commit/b5bd6537f432
12:11:31 <wheals> aidanh: shouldn't np in the _dgn_find_nearest_square part of that just be equal to *ai? rather than p + *ai
12:13:28 <aidanh> er, yes, good catch
12:17:31 <Cheibriados> 03Aidan Holm02 07* 0.26-a0-670-g578ab30: Fix out-of-bounds access (wheals) 10(2 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/578ab304f51f
12:32:17 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.26-a0-670-g578ab304f5 (34)
12:51:37 <CrawlCycle> i have just submitted a pull request for a catch2 fixture for running dlua commands.
12:51:53 <CrawlCycle> it would make setting up scenarios for test easier.
12:54:05 <CrawlCycle> like the existing cath2 tests, the fixture doesn't mock the global game state.
12:54:53 <CrawlCycle> does it look ok? should i start writing tests with the fixture?
13:06:34 <Henzell> Unstable branch on crawl.akrasiac.org updated to: 0.26-a0-670-g578ab30 (34)
13:14:48 <CrawlCycle> if real mock is better for crawl, which mocking framework is good?
14:38:52 <CrawlCycle> i don't see a repository that uses catch2, gmock, and gnu make.
14:40:16 <CrawlCycle> can't find "googletest", "googlemock" in log of this channel.
14:41:52 <CrawlCycle> here is a repository that integrates catch2 and googlemock using cmake: https://github.com/matepek/catch2-with-gmock
14:42:27 <CrawlCycle> it is experimental, and I think cmake does lots of lookup.
14:46:35 <CrawlCycle> oh. and google mock got absorbed into google test
14:46:42 <CrawlCycle> https://github.com/google/googlemock
14:50:29 <CrawlCycle> While that issue mentioned some mocking frameworks that can work with catch2, all of those mocking frameworks have less than 1k stars in github.
14:52:07 <CrawlCycle> last fakeit release is 2018
14:53:13 <CrawlCycle> The most recent release of trompeloeil is jun 8. But it doesn't look mature.
14:54:08 <CrawlCycle> https://github.com/rollbear/trompeloeil/issues/204
15:03:23 <CrawlCycle> is it ok to just use googletest?
15:07:31 <CrawlCycle> trompeloeil is the only mocking framework mentioned in catch2's doc: https://github.com/catchorg/Catch2/blob/b9853b4b356b83bb580c746c3a1f11101f9af54f/docs/opensource-users.md
15:59:54 <CrawlCycle> googletest may have slow compilation time
16:01:06 <CrawlCycle> if i jump through the hops to get googletest working, would it help crawl?
16:01:27 <CrawlCycle> i am not familiar with the msvc solutions
16:01:32 <CrawlCycle> but i can try.
16:08:01 <CrawlCycle> trompeloeil is c++14
16:14:13 <CrawlCycle> fakeit has several pull request for fixing compatibilit with catch2
16:14:31 <CrawlCycle> people ask if there are any plans to release the fix
16:15:03 <CrawlCycle> last stable release 2018...
16:16:58 <CrawlCycle> no wonder trompeloeil is the only mocking framework mentioned in catch2's doc.
16:19:02 <CrawlCycle> if i am dev, i would hate long compilation time of tests.
16:21:07 <CrawlCycle> anyway, i will try to add googletest. if this is something that you guys don't want, please tell me.
16:21:37 <CrawlCycle> i want to add googletest for mocking the global game state (you, env, crawl_state).
16:21:58 <CrawlCycle> that will help to isolate units and do real unit tests.
16:22:30 -!- amalloy_ is now known as amalloy
16:35:08 <Cbrotell> D12ThenQuit (L13 HuAr) ASSERT(attacker) in 'attack.cc' at line 394 failed. (Gauntlet)
16:48:53 <CrawlCycle> oh. trompeloeil say it uses c++11/14
18:13:47 -!- amalloy is now known as amalloy_
18:15:32 -!- amalloy_ is now known as amalloy
18:25:06 <Lantell> Unstable branch on underhound.eu updated to: 0.26-a0-670-g578ab304f5 (34)
19:02:35 <Aliscans> Could anyone tell me if the Crawl servers gather statistics on which non-default options people use?
19:04:04 <Aliscans> I was thinking of creating a PR to change how travel_open_doors=false worked. The current behaviour seems a bit pointless to me, but perhaps someone else finds it really useful.
19:04:25 <Cbrotell> D12ThenQuit (L13 HuAr) ASSERT(attacker) in 'attack.cc' at line 394 failed. (Gauntlet)
19:05:54 <advil> Aliscans no stats like that
19:06:21 <Aliscans> Thanks. It was just a thought.
19:06:26 <advil> my experience with dcss is that if you do change something like that, a dozen people pop up to say they liked the old way -- but that probably shouldn't be an actual barrier to change
19:07:12 <advil> asking on the discord might be one way to gauge the waters; you could also check what (if anything) some of the popular rc file includes like hda do
19:09:05 <Aliscans> Thanks, I'll have a look.
19:10:32 <Pinkbeast> FWIW I use it as false having set that intentionally, but I'm not sure how you propose to change it.
19:14:52 <Aliscans> I was thinking of having it explore as much as it can of the level without opening doors. Depending on the layout, it may be able to look everywhere like that.
19:16:49 <Aliscans> How does explore fit into your play style?
19:49:39 <CrawlCycle> is it ok to change function's signatures in the following way?
19:50:01 <CrawlCycle> f() -> f(player you_=you)
19:50:55 <CrawlCycle> this change would allow me to replace the "you" used in the function
19:52:02 <CrawlCycle> and the other functions in the main source code won't need any modification to fit with this change
19:52:02 <CrawlCycle> this would help testing because I can do something like this:
19:52:02 <CrawlCycle> f(fake_you)
19:52:05 <CrawlCycle> and replace the you by a mock
19:52:39 <CrawlCycle> and I can use a mock you instead of initializing the full crawl environment
19:52:49 <CrawlCycle> and bring in lots of uncontrolled variables in the test.
19:53:12 <CrawlCycle> fake_you is a mock that also inherits from the real player you.
19:54:15 <CrawlCycle> class mock_player : player { MAKE_MOCK1(func, void(int)); } etc
20:00:34 <CrawlCycle> i guess i will just work on it, submit another pull request, and then i will know if i did something wrong.
20:01:54 <CrawlCycle> ebrings mentioned that crawl's code is highly cross-loaded. therefore, unit test is not possible.
20:03:15 <CrawlCycle> sorry, i mean ebering.
20:04:59 <CrawlCycle> i hope mocks like this can isolate the units for unit testing.
20:14:27 <CrawlCycle> i don't know if refactoring this way is an acceptable risk. please tell me if it is. i will stop working on this and try to come up with another way.
20:15:01 <CrawlCycle> honestly, i have been thinking about this all day and nearly pulled my hairs out
20:16:19 <CrawlCycle> currently, the class/function directly use the global variables instead of a reference of the global variables.
20:16:45 <CrawlCycle> i can't think of a way to replace the global used in the function/class by a mock
20:16:51 <CrawlCycle> without changing the source code.
20:19:03 <CrawlCycle> oh, and advil (did he?) told me don't look at beam.cc
20:19:18 <CrawlCycle> i am glad that i haven't looked at it yet.
21:53:53 <CrawlCycle> Did they post ascii art in the chat? Why some chat log is 100+k?
21:53:55 <CrawlCycle> http://s-z.org/crawl-dev/%23%23crawl-dev-20100104.lg
22:30:21 <jfcaron> How do I get an account on the wiki?
22:34:30 <jfcaron> Ok I read ??wiki[2 and emailed the person there.  Hopefully that's not out of date.
22:34:30 <CrawlCycle> did you ask this question at discord?
22:34:41 <CrawlCycle> i think most of them are there because i talked too much.
22:35:05 <jfcaron> No I try not to use discord. =(
22:35:11 <CrawlCycle> maybe try to look at the most recent contributor in the wiki
22:35:24 <jfcaron> Yeah none of them are on IRC it looks like.
22:35:25 <CrawlCycle> then try to find that person, if everything else failed
22:35:38 <CrawlCycle> look at the logs. sometimes they are here.
22:35:40 <jfcaron> Spudwalk and Ge0ff are the main contributors.
22:35:59 <jfcaron> !seen Ge0ff
22:35:59 <Sequell> I last saw Ge0ff at Sat Jul 25 18:02:35 2020 UTC (12w 1d 8h 33m 23s ago) quitting, saying 'Quit: Leaving'.
22:36:08 <jfcaron> !seen Spudwalk
22:36:09 <Sequell> Sorry jfcaron, I haven't seen spudwalk.
22:38:08 <CrawlCycle> maybe ask if you can edit the entries of the knowledge bot?
22:38:35 <CrawlCycle> 3 years ago, someone at reddit say email crawlwiki@gmail.com
22:39:17 <jfcaron> Yeah I tried that one some months ago.
22:39:22 <jfcaron> I must've found the same reddit post.
22:40:17 <CrawlCycle> maybe you can ask if you can edit the entries of the knowledge bot.
22:41:23 <CrawlCycle> that is similar to what you want.
22:41:42 <CrawlCycle> maybe that guy know something too.
22:46:17 <CrawlCycle> jfcaron, can you look up the domain registration information of that website?
22:46:28 <CrawlCycle> does that have the email of the webmaster/
22:46:29 <CrawlCycle> ?
22:47:51 <jfcaron> no
22:47:57 <jfcaron> protected by GDPR lol
22:51:19 <CrawlCycle> sorry. i don't know.
22:51:30 <CrawlCycle> i think i tried a long time ago.
22:55:03 <CrawlCycle> hmm. let me think about this.
22:55:34 <CrawlCycle> maybe my pull request is too big. so no one wants to look at it.
22:55:51 <CrawlCycle> or there are too few people want to review pull request
22:56:17 <CrawlCycle> most of the pull requests that get accepted adds a new feature or fix a bug.
22:57:48 <CrawlCycle> actually, i would know if the reviewer take a 10 sec look, and then leave a copy-and-pate comment saying this is too large, we won't look at it.
22:58:13 <CrawlCycle> that might be better for future pull requests that are too big
22:58:47 <CrawlCycle> that won't take a lot of time.
23:02:31 <CrawlCycle> if there are not enough people to look at pull requests, i can try to look at some of it and leave some comments a few times per week.
23:05:31 <CrawlCycle> if you guys can leave a note in github that would be nice too.
23:06:24 <CrawlCycle> one of my pull request automatically grab all tests in the catch2-test folder.
23:06:47 <CrawlCycle> it is only 3 lines.
23:08:35 <CrawlCycle> anyway crawl is a great game. thanks for developing this.
23:09:30 <CrawlCycle> bye
23:45:11 <twelwe> you're welcome