00:40:08 Setting option always_show_zot to true causes misreport of status 13https://crawl.develz.org/mantis/view.php?id=12372 by vt 01:17:20 40 commits modified the catcher2 directory 01:18:22 39 commits modified the test directory since we started to have catcher2 tests 01:21:45 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-3603-ge1cc4b0452 01:22:01 with 362 lines changed 01:32:25 majority of those lines are from one commit with 302 lines changed 01:35:47 the 40 commits in the catcher2 directory changed 2539 lines, not counting the commit for adding catcher2 to claw 01:36:46 hmm. what does that 302 lines of lua code do? 01:37:49 the 302 lines of lua code is qw's bot for playing dcss 01:44:58 i don't want to modify the source code to add lua binding when i write test 01:45:14 the lua code for placing monsters/setting up dungeon is nice 01:45:36 is it possible to call the lua code in a catcher2 test? 01:47:58 i would imagine that it is difficult to write lua binding for iterators 01:48:22 without writing that kind of binding, i would have to add function for the unit-test in the main source 01:48:53 and create lua binding for the unit-test in the main source 01:49:25 and then use lua to place monsters in a lua test. 02:37:30 -!- maier is now known as kenran 03:31:07 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-3603-ge1cc4b0452 03:46:35 Fork (bcadrencrawl) on crawl.kelbi.org updated to: 0.22.1-3049-ge1007305a9 05:52:54 -!- amalloy is now known as amalloy_ 09:54:43 Ratskin Cloak - No Warning That Hell Rats Incite Ely Wrath 13https://crawl.develz.org/mantis/view.php?id=12373 by gressup 10:28:00 03PleasingFungus02 07* 0.26-a0-666-gee0ae89: Mark ratskin as evil (12373) 10(33 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/ee0ae89446c4 10:34:37 Unstable branch on crawl.kelbi.org updated to: 0.26-a0-666-gee0ae89446 (34) 11:05:51 03PleasingFungus02 07* 0.26-a0-667-g9264253: Make pacified monsters visible (hellmonk) 10(77 seconds ago, 1 file, 6+ 5-) 13https://github.com/crawl/crawl/commit/92642533e475 11:17:32 Unstable branch on crawl.kelbi.org updated to: 0.26-a0-667-g92642533e4 (34) 11:35:38 04Build failed for 08master @ 92642533 06https://github.com/crawl/crawl/actions/runs/308844415 12:22:38 hm, something went wrong with installing pyyaml on mac there 13:06:32 Unstable branch on crawl.akrasiac.org updated to: 0.26-a0-667-g9264253 (34) 17:19:27 -!- aidanh_ is now known as aidanh 18:25:13 Unstable branch on underhound.eu updated to: 0.26-a0-667-g92642533e4 (34) 20:25:03 How to define DEBUG_DIAGNOSTICS? 20:25:19 crawl seems to have a macro called "defined" 20:25:44 when I add "#define DEBUG_DIAGNOSTICS true" before 20:25:59 including makeitem.h 20:26:43 somehow the line #if defined(DEBUG_DIAGNOSTICS) || ... 20:26:43 doesn't detect that I have "#define DEBUG_DIAGNOSTICS true" 20:26:43 a fulldebug build (`make debug`) entails DEBUG_DIAGNOSTICS 20:27:18 that's the intended way to do that 20:27:21 i think i can make catch2 tests run dlua commands now 20:27:35 it rand several lua tests without problem 20:27:38 ran* 20:27:42 `defined` is a C preprocessor operator 20:29:38 ok.. the magic word is YesPlease 20:30:50 well, that word is not specifically needed 20:31:07 and not needed with `make debug` 20:32:19 i am looking at the Makefile to figure out what are the #define for the debug target 20:32:28 the Makefile uses `YesPlease` for something but any string works 20:32:36 s/for something/for some reason 20:32:52 wait.. it is a makefile not c++ source 20:32:57 those are variables 20:34:17 !source AppHdr:303 20:34:18 Can't find AppHdr. 20:34:20 i just don't get why defining DEBUG_DIAGNOSTICS before #include "makeitems.h" doesn't work 20:34:26 !source AppHdr.h:303 20:34:26 https://github.com/crawl/crawl/blob/master/crawl-ref/source/AppHdr.h#L303 20:34:29 maybe i should see the catcher.hpp or the test_main.cc 20:34:40 or something in between 20:35:11 test_main includes fake_main.hpp 20:36:34 nothing in the catch2-tests directory has #undef DEBUGxyz 20:37:10 hmm... i guess i will just let this one go. 20:37:55 i can still run most of the lua tests without problem 20:37:55 within a catcher test 20:45:47 i add the #deinfe DEBIG_DIAGNOSTICS before all the #includes in my own test_hybrid.cc in the catcher2-tests file 20:45:51 advil that make sense 20:46:12 but if another file, such as test_main.cc also includes AppHdr.h 20:46:32 and doesn't have #define DEBUG_DIAGNOSTICS there 20:47:08 then the AppHdr.h would spontaneously define NDEBUG whenever it doesn't see #define DEBUG 20:47:35 and the catcher2 test build one single executable for all tests in the catcher2-test directory 20:48:15 at least i can still use the dgn.place_monster function 20:48:31 without #define DEBUG_DIAGNOSTICS 20:49:12 thanks 21:01:45 ctest.cc contains the harness for running lua scripts and lua tests 21:03:01 The _init_test_binding function in ctest.cc defines 3 bindings that allow the lua interpretor to call c functions 21:03:27 those are "begin_test" which binds to the c++ function crawl_begin_test 21:03:46 "test_success" -> crawl_test_success 21:03:58 "script_args" -> crawl_script_args 21:04:30 somehow none of the lua test/scripts use the "begin_test", "test_success", and "script_args" function. 21:04:33 why? 21:05:57 the c++ harness is partially specified in the run_test function. 21:06:26 the run_test function simply increment the count of successful test whenever it sees that dlua.error.empty() 21:06:30 is true 21:14:12 are there some complicated reasons that LRD doesn't prioritize hitting multiple targets instead of the closest target, when it could instead hit the closest and another enemy? 21:15:07 i often find a situation where there is, say , Y.Y, begn LRD cast, and it will only target the first yak when it can certainly hit both and end up repositioning the target wall 22:23:33 where did crawl initialize curses? 22:28:10 does crawl has a function that supress all output to screen? 22:49:31 -!- amalloy_ is now known as amalloy