00:58:56 -!- amalloy_ is now known as amalloy 01:34:25 Unstable branch on crawl.develz.org updated to: 0.26-a0-576-gcfaa98f945 (34) 01:55:09 Windows builds of master branch on crawl.develz.org updated to: 0.26-a0-576-gcfaa98f945 03:12:00 Unstable branch on crawl.beRotato.org updated to: 0.26-a0-576-gcfaa98f (34) 03:30:52 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-3545-g7c84a495e7 07:29:27 -!- amalloy is now known as amalloy_ 07:50:16 03Implojin02 {ebering} 07* 0.26-a0-577-gba4b82f: Fix plant wither duration 10(23 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/ba4b82f8d22d 07:59:45 03ebering02 07* 0.26-a0-578-gc4b6802: Update the changelog 10(18 seconds ago, 1 file, 8+ 3-) 13https://github.com/crawl/crawl/commit/c4b6802de3e0 08:01:56 Unstable branch on crawl.kelbi.org updated to: 0.26-a0-578-gc4b6802de3 (34) 08:03:41 advil: or amalloy_ could you adjust the TU pin please? https://www.reddit.com/r/dcss/comments/ieh9ht/trunk_updates_21_august_2020/ 08:10:16 I’m loving these more regular trunk update posts 09:26:10 Furslid (L23 FoFi) Crash caused by signal #6: Aborted (D (Sprint)) 10:09:09 Morgoth (L11 BaAM) Crash caused by signal #6: Aborted (Lair:1) 13:06:18 Unstable branch on crawl.akrasiac.org updated to: 0.26-a0-578-gc4b6802 (34) 15:12:06 !source mara_summon 15:12:06 Can't find mara_summon. 15:13:02 !source cast_phantom_mirror 15:13:03 1/1. https://github.com/crawl/crawl/blob/master/crawl-ref/source/mon-cast.cc#L3063 15:13:47 !source clone_mons 15:13:48 1/2. https://github.com/crawl/crawl/blob/master/crawl-ref/source/mon-clone.cc#L264 15:19:46 -!- amalloy_ is now known as amalloy 15:20:01 the bug https://crawl.develz.org/mantis/view.php?id=12340 how should the fix be approached? allow player to attempt to enslave the illusion and fail? 15:28:56 or allow it to apply the effect not knowing if they got the correct one, which would waste the attempt 15:36:48 can't allow it to cast and fail because that would still be an info leak 15:40:08 it's an info leak that costs the player resources, though, which is not always bad. in the same way, killing the image "leaks" the information that it was a fake 15:42:45 so apply the effect even if it's an illusion? then how should the killing of the enslaved illusion be handled? I'd guess not removing an existing enslaved soul, and maybe a message saying they got tricked 15:43:12 i was talking about your proposal to allow it to cast and fail 15:43:20 it should probably fail and cost a turn, yeah (with a message about it failing because you can't enslave a clone or something) 15:45:09 fail and cost a turn only for the illusions? same function gets called if player tries to enslave something else that can't 15:48:45 in ability.cc line 2431 could add a turn pass but it feels to me like that's a change to the entire ability, which I'm not qualified to decide. personally I think it's ok 15:51:34 lots spells and abilities work like that yeah, for example single-target spells you can target at empty space trying to hit invisible things 15:51:37 lots of* 15:52:19 where it'll fail and not cost a turn if you target something you can see and know it wouldn't be affected, it'll fail and cost a turn if you target empty space and there's nothing there, and succeed if you target empty space and there's a valid invisible target there 15:54:23 (although in those cases i think it's better to just not allow trying to target invisible things) 15:57:58 unless I'm reading it wrong, it currently does not allow targeting invisible things 15:58:11 ability.cc:2428 16:00:46 right, which is good i think, that was just an example of a similar kind of behaviour where you learn some information by failing to cast the spell/ability 16:01:49 ah gotcha. so you think just adding a turn delay before printing the fail message is an appropriate solution? 16:09:46 the way to do it would be to return spret::success early, to bail out before actually applying the enchantment while still spending a turn and the ability costs 16:30:17 changing ability.cc:2432 to return spret:success; and testing it on an illusion caused the message to popup, and a turn to pass. using it on the real mara applies the effect and causes a turn to pass. 16:30:42 i'm not 100% sure if it took the piety usage 16:31:10 i'd expect it to. but you could test by freezing time and just using the ability a bunch of times 16:31:19 (with `) 16:32:24 yeah that's kinda what I have to do. also, using it on an unseen horror's square caused the same result, MP used, fail message and time pass 16:33:48 just setting piety to 120 then using it caused a star to go away in piety so I think it's a working change. I'll make a PR if you think it's ready to be applied? 16:48:50 kate-: "it'll fail and cost a turn if you target empty space and there's nothing there, and succeed if you target empty space and there's a valid invisible target there" other changes needed to satisfy this statement 16:51:57 breaking apart mon == nullptr and leaving that result as a spret::abort would make it behave as your described 17:09:15 oh i read that wrong. so the idea is to make all uses of enslave soul cost the MP and piety, even if it's an empty tile or invalid monster (jelly)? 17:49:14 03PleasingFungus02 07* 0.26-a0-579-g3afe496: Fix objstat 10(32 seconds ago, 3 files, 36+ 1-) 13https://github.com/crawl/crawl/commit/3afe4966bfaf 17:58:33 Naruni: the only thing that should change from the current behaviour is that trying to use it on a clone should take a turn+ability costs 18:03:58 prevent ground targeting spells (eg remove Z) 18:04:11 if you can't see an invis monster, you can't target it. Even if you "know" where it is 18:04:24 similarly remove force attack 18:18:34 Unstable branch on crawl.kelbi.org updated to: 0.26-a0-579-g3afe4966bf (34) 18:25:34 Unstable branch on underhound.eu updated to: 0.26-a0-579-g3afe4966bf (34) 19:09:13 git push 19:09:14 fatal: The current branch tweak_enslave_soul has no upstream branch. 19:09:14 To push the current branch and set the remote as upstream, use 19:09:14 19:09:14 git push --set-upstream origin tweak_enslave_soul 19:09:20 ugh git gets me again. 19:12:24 New branch created: pull/1530 (1 commit) 13https://github.com/crawl/crawl/pull/1530 19:12:24 03Naruni02 07https://github.com/crawl/crawl/pull/1530 * 0.26-a0-580-g19af418: Tweak enslave soul when used on clones 10(14 seconds ago, 1 file, 7+ 0-) 13https://github.com/crawl/crawl/commit/19af418c81a6 19:34:19 03PleasingFungus02 07* 0.26-a0-580-g4860111: Don't show removed branches in &~ 10(2 minutes ago, 1 file, 3+ 1-) 13https://github.com/crawl/crawl/commit/4860111d27d4 19:47:18 Unstable branch on crawl.kelbi.org updated to: 0.26-a0-580-g4860111d27 (34) 21:40:14 -!- amalloy is now known as amalloy_ 21:45:27 New branch created: bogged-down (20 commits) 13https://github.com/crawl/crawl/tree/bogged-down 21:45:28 03PleasingFungus02 07[bogged-down] * 0.26-a0-581-ge408dee: Buff bog bodies 10(2 days ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/e408dee6bd3c 21:45:28 03PleasingFungus02 07[bogged-down] * 0.26-a0-582-g01a3a88: Refactor monster death effects 10(30 hours ago, 1 file, 44+ 31-) 13https://github.com/crawl/crawl/commit/01a3a881d357 21:45:28 03PleasingFungus02 07[bogged-down] * 0.26-a0-583-g9abc9c3: New monster: bloated husk 10(30 hours ago, 6 files, 42+ 0-) 13https://github.com/crawl/crawl/commit/9abc9c377ea5 21:45:28 03PleasingFungus02 07[bogged-down] * 0.26-a0-584-g5d07528: New monster: bunyip 10(29 hours ago, 7 files, 33+ 0-) 13https://github.com/crawl/crawl/commit/5d0752877bbb 21:45:28 03PleasingFungus02 07[bogged-down] * 0.26-a0-585-gad9da81: New monster: devouring swarm 10(26 hours ago, 30 files, 182+ 5-) 13https://github.com/crawl/crawl/commit/ad9da81230a1 21:45:28 03PleasingFungus02 07[bogged-down] * 0.26-a0-586-gac89d69: Power up insubstantial wisps 10(25 hours ago, 4 files, 55+ 2-) 13https://github.com/crawl/crawl/commit/ac89d6983a5b 21:45:28 03PleasingFungus02 07[bogged-down] * 0.26-a0-587-g0ff7132: New monster: Kitsune 10(24 hours ago, 11 files, 63+ 9-) 13https://github.com/crawl/crawl/commit/0ff713279d05 21:45:28 03PleasingFungus02 07[bogged-down] * 0.26-a0-588-g3706ab4: New monster: goliath frog 10(21 hours ago, 14 files, 57+ 16-) 13https://github.com/crawl/crawl/commit/3706ab484a2b 21:45:28 03PleasingFungus02 07[bogged-down] * 0.26-a0-589-g7e1f87e: New monster: eleionoma 10(8 hours ago, 14 files, 150+ 3-) 13https://github.com/crawl/crawl/commit/7e1f87e40df4 21:45:28 03PleasingFungus02 07[bogged-down] * 0.26-a0-590-gf34f968: Remove unused M_HYBRID flag 10(7 hours ago, 4 files, 15+ 22-) 13https://github.com/crawl/crawl/commit/f34f968a059a 21:45:28 ... and 10 more commits 21:47:27 i'll do a nice writeup of this in like 30min 22:05:03 04Build failed for 08bogged-down @ bc883708 06https://github.com/crawl/crawl/actions/runs/220268186 22:07:52 New branch created: pull/1533 (20 commits) 13https://github.com/crawl/crawl/pull/1533 22:07:52 Branch pull/1533 updated to be equal with bogged-down: 13https://github.com/crawl/crawl/pull/1533 22:30:00 03Naruni02 07https://github.com/crawl/crawl/pull/1530 * 0.26-a0-581-gdebd134: Fix whitespace 10(in the future, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/debd13469947